Re: Review Request 64983: Setup heartbeat for api endpoint.

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64983/#review194880 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 5:44

Re: Review Request 64981: alert_definitions topic doesn't emit any events to client.

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64981/#review194876 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 4:55

Re: Review Request 64979: Delete host event doesn't have hostName property.

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64979/#review194871 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 3:57

Re: Review Request 64977: UI receives a topology event when turning on/off maintenance mode for the host

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64977/#review194867 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 3:01

Re: Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64951/#review194857 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 1:20

Re: Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception

2018-01-04 Thread Dmytro Grinenko
/UpgradeCatalog252.java Lines 21 (patched) <https://reviews.apache.org/r/64951/#comment273904> please check https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambarim Java Import Order - Dmytro Grinenko On Jan. 4, 2018, 5 p.m., Vitalyi Brodetskyi

Re: Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

2018-01-04 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64956/#review194837 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 4, 2018, 8:16

Re: Review Request 64722: [Patch Hive]webhcat: test_sqoop fails with hdfs:///hdp/apps/2.6.*/sqoop/sqoop.tar.gz does not exist

2017-12-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64722/#review194244 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 19, 2017, 8:58

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64652/#review193938 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 15, 2017, 5 p.m

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Dmytro Grinenko
ersion, and register new one with same id but different actual version. Would this cause any issue? - Dmytro Grinenko On Dec. 15, 2017, 5 p.m., Myroslav Papirkovskyy wrote: > > --- > This is an automatically generated e

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

2017-12-15 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64637/#review193904 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 15, 2017, 3:38

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

2017-12-14 Thread Dmytro Grinenko
/package/scripts/livy_service.py Line 48 (original), 52 (patched) <https://reviews.apache.org/r/64637/#comment272532> i don't understand why we removing the pid file, but let's fix this later - Dmytro Grinenko On Dec. 15, 2017, 3:03 a.m., Jonathan Hurley

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

2017-12-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64637/#review193873 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 15, 2017, 3:03

Re: Review Request 64579: Node Managers fail to start after Spark2 is patched due to CNF YarnShuffleService

2017-12-13 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64579/#review193721 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 13, 2017, 5:12

Re: Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-13 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64554/#review193720 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 13, 2017, 3:46

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Dmytro Grinenko
> On Dec. 5, 2017, 1:01 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java > > Lines 154 (patched) > > > > > > We really shouldn't be hardcoding

Re: Review Request 64348: Pig service check failed after PU with LzoCodec CNF

2017-12-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64348/#review192898 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 5, 2017, 6:33

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-11-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64223/#review192369 --- Ship it! Ship It! - Dmytro Grinenko On Nov. 30, 2017, 9:18

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-11-30 Thread Dmytro Grinenko
--- > > (Updated Nov. 30, 2017, 8:28 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-22568 > https://issues.apache.org/jira/browse/AMBARI-22568 > > > Repository: ambari >

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Dmytro Grinenko
/libraries/functions/lzo_utils.py Line 86 (original), 86 (patched) <https://reviews.apache.org/r/64205/#comment270336> this is kinda oddly "expect.except" - Dmytro Grinenko On Nov. 30, 2017, 11:46 a.m., Dmitro L

Re: Review Request 64166: History and Hive server start failed during IOP migration with AttributeError

2017-11-29 Thread Dmytro Grinenko
/libraries/functions/copy_tarball.py Lines 96 (patched) <https://reviews.apache.org/r/64166/#comment270177> seems that tez_version variable is better to rename to something like component_version or just version - Dmytro Grinenko On Nov. 29, 2017, 4:55 p.m., Jonathan Hurley

Re: Review Request 64161: Tie MapReduce to Hive and Tez For Patch Upgrades

2017-11-29 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64161/#review192124 --- Ship it! Ship It! - Dmytro Grinenko On Nov. 29, 2017, 2:49

Re: Review Request 64090: ATS start failed during patch upgrade due to CNF SparkATSPlugin

2017-11-28 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64090/#review192021 --- Ship it! Ship It! - Dmytro Grinenko On Nov. 27, 2017, 7:01

Re: Review Request 64085: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-11-27 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64085/#review191882 --- Ship it! Ship It! - Dmytro Grinenko On Nov. 27, 2017, 2:05

Re: Review Request 63962: Conditionally Rebuild MapReduce and Tez Tarballs with LZO if Enabled

2017-11-20 Thread Dmytro Grinenko
as we operating with our temporary created directory and have full ownership on it - Dmytro Grinenko On Nov. 20, 2017, 7:27 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 63807: Add Native Libraries To Tez Tarball

2017-11-14 Thread Dmytro Grinenko
d) <https://reviews.apache.org/r/63807/#comment268614> I know, they were here, but that is not pythonic. Please remove round brackets, they r reducant - Dmytro Grinenko On Nov. 14, 2017, 9:21 p.m., Jonathan Hurley wrote: > > --- >

Re: Review Request 63807: Add Native Libraries To Tez Tarball

2017-11-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63807/#review191012 --- - Dmytro Grinenko On Nov. 14, 2017, 9:21 p.m., Jonathan Hurley

Re: Review Request 63807: Add Native Libraries To Tez Tarball

2017-11-14 Thread Dmytro Grinenko
d) <https://reviews.apache.org/r/63807/#comment268614> I know, they were here, but that is not pythonic. Please remove round brackets, they r reducant - Dmytro Grinenko On Nov. 14, 2017, 9:21 p.m., Jonathan Hurley wrote: > > --- >

Re: Review Request 63684: Patch Upgrades Broken For Clients Due To Versioned LD Library

2017-11-08 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63684/#review190532 --- Ship it! Ship It! - Dmytro Grinenko On Nov. 8, 2017, 9:22

Re: Review Request 63593: Remove Auto-Installation of Mysql Connector

2017-11-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63593/#review190222 --- Ship it! Ship It! - Dmytro Grinenko On Nov. 6, 2017, 8:31

Re: Review Request 63305: Downgrade From HDP 2.6 to 2.5 Leaves 2.6 Hosts as CURRENT Instead of INSTALLED

2017-10-25 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63305/#review189242 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 25, 2017, 7:57

Re: Review Request 63150: Ambari Schema Upgrade Failed during Ambari Upgrade

2017-10-19 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63150/#review188688 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 19, 2017, 3:38

Re: Review Request 63032: YARN Service Checks Fails Because of Old hadoop-client Classpath Entry

2017-10-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63032/#review188152 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 16, 2017, 4:22

Re: Review Request 62996: Restart of random service could fail during express downgrade

2017-10-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62996/#review188112 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 16, 2017, 1:53

Re: Review Request 62934: Set current_version for Backward Compatibility

2017-10-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62934/#review187796 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 12, 2017, 1:57

Re: Review Request 62922: "ambari-server upgrade" failed on db schema [Upgrade]

2017-10-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62922/#review187768 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 12, 2017, 5:30

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

2017-10-04 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187081 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 3, 2017, 9:11

Re: Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI

2017-09-18 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62364/#review185580 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 18, 2017, 5:46

Re: Review Request 62259: Upgrade to IOP 4.2.5 from IOP 4.1 failed with combined Solr host names longer than item_text column size in table upgrade_item

2017-09-18 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62259/#review185573 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 18, 2017, 5:36

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62331/#review185412 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 14, 2017, 3:13

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-12 Thread Dmytro Grinenko
e moved to the top of the function and be used after for the check? - Dmytro Grinenko On Sept. 12, 2017, 8:10 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62226/#review185207 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 12, 2017, 3:50

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
142 (original), 142 (patched) <https://reviews.apache.org/r/62226/#comment261496> i like this way more than that big "stairs" - Dmytro Grinenko On Sept. 12, 2017, 3:50 p.m., Jonathan Hurley wrote: > > --- >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
> On Sept. 12, 2017, 3:42 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 126 (patched) > > <https://reviews.apache.org/r/62226/diff/3/?file=1820189#file1820189line126> > >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
/functions/stack_select.py Lines 126 (patched) <https://reviews.apache.org/r/62226/#comment261491> if not supported_packages: supported_packages = get_supported_packages() else no sence on this - Dmytro Grinenko On Sept. 12, 2017, 2:21 p.m., Jonathan Hurley

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62226/#review185197 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 12, 2017, 2:21

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 145 (patched) > > <https://reviews.apache.org/r/62226/diff/2/?file=1819598#file1819598line145> > > >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 145 (patched) > > <https://reviews.apache.org/r/62226/diff/2/?file=1819598#file1819598line145> > > >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
> On Sept. 12, 2017, 1:07 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 125 (patched) > > <https://reviews.apache.org/r/62226/diff/2/?file=1819598#file1819598line125> > >

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-12 Thread Dmytro Grinenko
common/src/main/python/resource_management/libraries/functions/stack_select.py Lines 145 (patched) <https://reviews.apache.org/r/62226/#comment261466> while map function is present in python, using generators is more prefferable - Dmytro Grinenko On Sept. 11, 2017, 7:43

Re: Review Request 62095: Installation should ignore OS that are not managed by Ambari

2017-09-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62095/#review184684 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 6, 2017, 1:55

Re: Review Request 62095: Installation should ignore OS that are not managed by Ambari

2017-09-05 Thread Dmytro Grinenko
ache commons instead of spring internals? - Dmytro Grinenko On Sept. 5, 2017, 9:04 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 61949: Reject PATCH VDFs with Services that are not Included in the Cluster

2017-09-01 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61949/#review184353 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 1, 2017, 1:20

Re: Review Request 61715: package_regex in get_package_from_available() can match wrong pkg

2017-08-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61715/#review184142 --- Ship it! Ship It! - Dmytro Grinenko On Aug. 29, 2017, 3:07

Re: Review Request 61715: PREVIEW: package_regex in get_package_from_available() can match wrong pkg

2017-08-28 Thread Dmytro Grinenko
ackage to respective os provider? - Dmytro Grinenko On Aug. 28, 2017, 3:49 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61746: Prevent New Clusters from Being Provisioned With PATCH/MAINT Repos

2017-08-21 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61746/#review183324 --- Ship it! Ship It! - Dmytro Grinenko On Aug. 19, 2017, 1:23

Re: Review Request 61622: Begin Using Service Versions In Python stack_feature Code

2017-08-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61622/#review182913 --- Ship it! Ship It! - Dmytro Grinenko On Aug. 14, 2017, 9:01

Re: Review Request 61622: Begin Using Service Versions In Python stack_feature Code

2017-08-14 Thread Dmytro Grinenko
issue - Dmytro Grinenko On Aug. 14, 2017, 9:01 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-07 Thread Dmytro Grinenko
/org/apache/ambari/server/checks/AbstractCheckDescriptor.java Line 249 (original), 255 (patched) <https://reviews.apache.org/r/61490/#comment258234> could we put here some usefull information about request and kind of error occurs? - Dmytro Grinenko On Aug. 8, 2017, 3:48 a.m., Jo

Re: Review Request 61186: Service repos are not updated with "latest" url in repoinfo.xml

2017-07-27 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61186/#review181581 --- Ship it! Ship It! - Dmytro Grinenko On July 27, 2017, 5:05

Re: Review Request 61146: Replace Hard Coded stack-select Structures

2017-07-27 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61146/#review181559 --- Ship it! Ship It! - Dmytro Grinenko On July 26, 2017, 7:04

Re: Review Request 61146: Replace Hard Coded stack-select Structures

2017-07-26 Thread Dmytro Grinenko
> On July 26, 2017, 7:39 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > > Lines 131 (patched) > > <https://reviews.apache.org/r/61146/diff/1/?file=1782632#file1782632line175> > > > >

Re: Review Request 61146: Replace Hard Coded stack-select Structures

2017-07-26 Thread Dmytro Grinenko
ources and sync on changes or post to agent initial version and after just post on changes? Current request r not small entites, and proly it is not good idea to make them even more larger. - Dmytro Grinenko On July 26, 2017, 7:04 p.m., Jonathan Hurley

Re: Review Request 60919: AMBARI-21502. Cross-stack migration from BigInsights to HDP, EU needs to set hive-site custom.hive.warehouse.mode to 0770

2017-07-17 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60919/#review180748 --- Ship it! Ship It! - Dmytro Grinenko On July 17, 2017, 9:31

Re: Review Request 60897: Add UID/GID related enhancements

2017-07-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60897/#review180641 --- Ship it! Ship It! - Dmytro Grinenko On July 16, 2017, 5:07

Re: Review Request 60866: AMBARI-21477: Remove Falcon proxy entries from Knox kerberos.json

2017-07-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60866/#review180558 --- Ship it! Ship It! - Dmytro Grinenko On July 14, 2017, 1:34

Re: Review Request 60543: DB consistency checker throws errors for missing 'parquet-logging' and 'product-info' configs after Ambari upgrade

2017-07-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60543/#review179631 --- Ship it! Ship It! - Dmytro Grinenko On June 29, 2017, 4:28

Re: Review Request 60543: DB consistency checker throws errors for missing 'parquet-logging' and 'product-info' configs after Ambari upgrade

2017-07-05 Thread Dmytro Grinenko
June 29, 2017, 4:28 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60543/ > --- > > (Updated June 29, 2017, 4:28 p.m.) > > > Rev

Re: Review Request 60543: DB consistency checker throws errors for missing 'parquet-logging' and 'product-info' configs after Ambari upgrade

2017-06-29 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60543/#review179275 --- Ship it! Ship It! - Dmytro Grinenko On June 29, 2017, 4:28

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

2017-06-28 Thread Dmytro Grinenko
ply, visit: > https://reviews.apache.org/r/60498/ > --- > > (Updated June 28, 2017, 12:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro > Lisnichenko, and Jonathan Hurley. > >

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

2017-06-28 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/#review179096 --- Ship it! Ship It! - Dmytro Grinenko On June 28, 2017, 12:27

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

2017-06-28 Thread Dmytro Grinenko
> On June 28, 2017, 12:10 p.m., Dmytro Grinenko wrote: > > ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java > > Lines 683 (patched) > > <https://reviews.apache.org/r/60498/diff/1/?file=1766136#file1766136line683> > > > >

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

2017-06-28 Thread Dmytro Grinenko
check for this - Dmytro Grinenko On June 28, 2017, 8:59 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 59912: Run status commands with real configurations and parameters information

2017-06-08 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59912/#review177293 --- Ship it! Ship It! - Dmytro Grinenko On June 8, 2017, 10:38

Re: Review Request 59835: Agent Host Disk Usage Alert Hardcodes the Stack Directory

2017-06-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59835/#review177020 --- Ship it! Ship It! - Dmytro Grinenko On June 6, 2017, 10:45

Re: Review Request 59394: Race condition: webhdfs call mkdir /tmp/druid-indexing before /tmp making tmp not writable.

2017-06-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59394/#review177018 --- Ship it! Ship It! - Dmytro Grinenko On May 19, 2017, 9:54

Re: Review Request 59277: Upgrades Should Be Associated With Repositories Instead of String Versions

2017-05-16 Thread Dmytro Grinenko
ply, visit: > https://reviews.apache.org/r/59277/ > --- > > (Updated May 15, 2017, 5:35 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-21022 > https://issues.apache.org/jira/browse/AMBAR

Re: Review Request 59176: Add missing 'cluster_host_info' column to 'request' table to MSSQL DDL

2017-05-11 Thread Dmytro Grinenko
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59176/ > --- > > (Updated May 11, 2017, 1:17 p.m.) > > > Review request for Ambari, Dmytro Grinenk

Re: Review Request 59176: Add missing 'cluster_host_info' column to 'request' table to MSSQL DDL

2017-05-11 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59176/#review174642 --- Ship it! Ship It! - Dmytro Grinenko On May 11, 2017, 1:17

Re: Review Request 57940: JAVA_LIBRARY_PATH in hadoop-env.sh is different on host and downloaded configs

2017-03-26 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57940/#review170123 --- Ship it! Ship It! - Dmytro Grinenko On March 26, 2017, 9:34

Re: Review Request 57295: Atlas service check fails during EU on wire encrypted cluster

2017-03-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57295/#review168006 --- Ship it! Ship It! - Dmytro Grinenko On March 6, 2017, 2:57

Re: Review Request 56950: Error during EU while updating Ranger Log4J service configs

2017-02-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56950/#review166516 --- Ship it! Ship It! - Dmytro Grinenko On Feb. 22, 2017, 9:11

Re: Review Request 56790: Getting Internal Server Error (500) on services API while trying to start all services with atleast one component in INSTALL_FAILED state

2017-02-22 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56790/#review166351 --- Ship it! Ship It! - Dmytro Grinenko On Feb. 22, 2017, 10:51

Re: Review Request 56020: Ambari HDFS Metric alerts turns to UNKNOWN status with error "argument of type 'NoneType' is not iterable"

2017-01-27 Thread Dmytro Grinenko
cation. This should help use to debug issues here later - Dmytro Grinenko On Jan. 27, 2017, 2:22 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 56023: Upgrade default JDK installed by Ambari to be >8u100

2017-01-27 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56023/#review163271 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 27, 2017, 3:14

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161689 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 12, 2017, 2:09

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-15 Thread Dmytro Grinenko
/serveraction/upgrades/UpgradeUserKerberosDescriptor.java (line 252) <https://reviews.apache.org/r/55424/#comment233001> should be this an atomic operation? - Dmytro Grinenko On Jan. 12, 2017, 2:09 p.m., Eugene Chekanskiy

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
ed e-mail. To reply, visit: > https://reviews.apache.org/r/55424/ > --- > > (Updated Jan. 11, 2017, 1:32 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Robert Levas. > > > Bugs:

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
5424/#review161228 --- On Jan. 11, 2017, 1:32 p.m., Eugene Chekanskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55424/ > ---

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
https://reviews.apache.org/r/55424/ > --- > > (Updated Jan. 11, 2017, 1:32 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Robert Levas. > > > Bugs: AMBARI-19464 > https://issues.apache.org/jira/browse/AMBARI-19464 > > > Repository:

Re: Review Request 55230: HOU Fails To Restart NameNode in non-HA Cluster

2017-01-06 Thread Dmytro Grinenko
> On Jan. 6, 2017, 7:29 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py, > > line 22 > > <https://reviews.apache.org/r/55230/diff/1/?file=1597766#file1597766line22> > > > >

Re: Review Request 55230: HOU Fails To Restart NameNode in non-HA Cluster

2017-01-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55230/#review160732 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 6, 2017, 2:21

Re: Review Request 55018: Fix hive-site.xml and hive-env.sh permissions for /etc/hive/conf (client) folder from 600 to 644.

2016-12-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55018/#review160095 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 23, 2016, 6:30

Re: Review Request 55000: Perf: Deploy 3000 Agent cluster and find perf bugs. Part 4

2016-12-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55000/#review160076 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 23, 2016, 12:22

Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

2016-12-23 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55002/#review160077 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 23, 2016, 12:35

Re: Review Request 54942: AMBARI-19272. Ignored mount points logged for each mount

2016-12-22 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54942/#review160018 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 21, 2016, 4:52

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

2016-12-12 Thread Dmytro Grinenko
Because this is changing data, should the data manipulation be wrapped > > in an `executeInTransaction(Runnable)` ? > > Dmytro Grinenko wrote: > moreover, i'm not sure that @Transactional annotation will have any > effect on DDL changes via dbAccessor or any other way to make sch

Re: Review Request 54674: AMBARI-19170. NPE during Ambari server schema upgrade

2016-12-12 Thread Dmytro Grinenko
> On Dec. 12, 2016, 8:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1555 > > > > > > Because this is changing data, should the

Re: Review Request 53054: Move AMBARI_INFRA role command order to common-services/AMBARI_INFRA

2016-10-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53054/#review153378 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:36

Re: Review Request 53051: Move LOGSEARCH role command order to common-services/LOGSEARCH

2016-10-20 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53051/#review153376 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 20, 2016, 9:34

  1   2   >