Re: Review Request 57253: Credential Store should be enabled by default on fresh installs

2017-03-03 Thread Jayush Luniya
upgrading an existing cluster does not enable the credential store for already deployed services? - Jayush Luniya On March 2, 2017, 7:48 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 57115: AMBARI-20219 : Grafana Start Failed on HDF cluster

2017-02-27 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57115/#review166978 --- Ship it! Ship It! - Jayush Luniya On Feb. 28, 2017, 12:46

Re: Review Request 57089: HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-02-27 Thread Jayush Luniya
> On Feb. 27, 2017, 6:43 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml, > > line 24 > > > > > > This should be a brand new version of Slider. > >

Re: Review Request 57096: Remove HDP version check in KAFKA service

2017-02-27 Thread Jayush Luniya
/stack_features.json (line 25) <https://reviews.apache.org/r/57096/#comment239011> Can you add this to ambari/ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.jsonas well? - Jayush Luniya On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan

Re: Review Request 57096: Remove HDP version check in KAFKA service

2017-02-27 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57096/#review166929 --- Ship it! Ship It! - Jayush Luniya On Feb. 27, 2017, 7:10

Re: Review Request 57096: Remove HDP version check in KAFKA service

2017-02-27 Thread Jayush Luniya
d e-mail. To reply, visit: > https://reviews.apache.org/r/57096/ > --- > > (Updated Feb. 27, 2017, 7:10 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jayush Luniya. > > > Bugs: AMBARI-20212 > h

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

2017-02-23 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56727/#review166606 --- Ship it! Ship It! - Jayush Luniya On Feb. 23, 2017, 11:24

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

2017-02-23 Thread Jayush Luniya
/ConfigHelper.java (line 565) <https://reviews.apache.org/r/56727/#comment238606> Can you add documentation to the new methods - Jayush Luniya On Feb. 23, 2017, 10:42 p.m., Madhuvanthi Radhakrishnan wrote: > > ---

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

2017-02-23 Thread Jayush Luniya
/AmbariManagementControllerImpl.java (line 42) <https://reviews.apache.org/r/56727/#comment238605> USER_GROUP should be removed - Jayush Luniya On Feb. 23, 2017, 10:42 p.m., Madhuvanthi Radhakrishnan wrote: > > ---

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

2017-02-23 Thread Jayush Luniya
supported with JDK 1.7+ http://docs.hortonworks.com/HDPDocuments/Ambari-2.4.2.0/bk_ambari-installation/content/jdk_requirements.html https://docs.oracle.com/javase/tutorial/java/generics/types.html - Jayush Luniya On Feb. 23, 2017, 7:39 p.m., Madhuvanthi Radhakrishnan wrote: >

Re: Review Request 56710: Relax ranger config DB consistency check rules

2017-02-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56710/#review165871 --- Ship it! Ship It! - Jayush Luniya On Feb. 16, 2017, 11:24

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

2017-02-16 Thread Jayush Luniya
> On Feb. 16, 2017, 4:21 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > line 547 > > <https://reviews.apache.org/r/56727/diff/1/?file=1635856#file1635856line547> > > > > Nit! getProp

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

2017-02-16 Thread Jayush Luniya
default.json (line 23) <https://reviews.apache.org/r/56727/#comment237701> Might want to add a custom service's user group mapping and add unit tests to ensure the custom service's user groups get created. - Jayush Lu

Re: Review Request 56641: Change Livy recovery folder permission to 0700

2017-02-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56641/#review165864 --- Ship it! Ship It! - Jayush Luniya On Feb. 14, 2017, 5:29

Re: Review Request 56710: Relax ranger config DB consistency check rules

2017-02-16 Thread Jayush Luniya
- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56710/ > ----------- > > (Updated Feb. 16, 2017, 11:24 a.m.) > > > Review request for Ambari, Dmitro Li

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-09 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56418/#review165066 --- Ship it! Ship It! - Jayush Luniya On Feb. 9, 2017, 11:14

Re: Review Request 56512: Add 'yarn.client.failover-proxy-provider' in yarn-site.xml by default for all HA enabled clusters - addendum

2017-02-09 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56512/#review164993 --- Ship it! Ship It! - Jayush Luniya On Feb. 9, 2017, 7:27 p.m

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-08 Thread Jayush Luniya
> On Feb. 9, 2017, 3:29 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java, > > line 136 > > <https://reviews.apache.org/r/56418/diff/1/?file=1627089#file1627089line136> > > >

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-08 Thread Jayush Luniya
.getObject().add("ServiceComponentInfo/service_name"); serviceComponentNode.getObject().add("ServiceComponentInfo/component_name"); serviceComponentNode.getObject().add("ServiceComponentInfo/recovery_enabled"); - Jayush Luniya On Feb. 8, 201

Re: Review Request 56439: spark/livy (1.x) should not be configured in Zeppelin's interpreter if they are not installed

2017-02-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56439/#review164769 --- Ship it! Ship It! - Jayush Luniya On Feb. 8, 2017, 5:04 p.m

Re: Review Request 56276: AMBARI-19845 Secure Ranger passwords in Ambari Stacks

2017-02-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56276/#review164717 --- Ship it! Ship It! - Jayush Luniya On Feb. 7, 2017, 1:14 p.m

Re: Review Request 56377: Log Search should use Credential Store API to store keystore/truststore passwords - ambari side

2017-02-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56377/#review164715 --- Ship it! Ship It! - Jayush Luniya On Feb. 7, 2017, 4:12 p.m

Re: Review Request 56400: Ambari doesn't appear to configure logging correctly for LLAP

2017-02-07 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56400/#review164557 --- Ship it! Ship It! - Jayush Luniya On Feb. 7, 2017, 6:46 p.m

Re: Review Request 56227: ambari-server start failed with exit code 1.

2017-02-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56227/#review164001 --- Ship it! Ship It! - Jayush Luniya On Feb. 2, 2017, 2:19 p.m

Re: Review Request 56130: Hive LLAP and Hive2 log4j changes should be removed from upgrade packs hdp 2.3 and hdp 2.4

2017-01-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56130/#review163706 --- Ship it! Ship It! - Jayush Luniya On Jan. 31, 2017, 6:39

Re: Review Request 56039: Add common log rotation settings to hive log4j2

2017-01-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56039/#review163464 --- Ship it! Ship It! - Jayush Luniya On Jan. 27, 2017, 9:51

Re: Review Request 55817: AMBARI-19618 Make cohosted components configurable in metainfo.xml instead of hardcoding in UI

2017-01-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55817/#review162992 --- Yao, please add Jaimin to this review. - Jayush Luniya On Jan

Re: Review Request 55848: AMBARI-19630: Ambari should accept stack version in format of x.x.x.x without the build level digits

2017-01-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55848/#review162991 --- Ship it! Ship It! - Jayush Luniya On Jan. 23, 2017, 4:51

Re: Review Request 55865: Stack advisor needs to enforce component dependency for slaves and masters

2017-01-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55865/#review162990 --- Ship it! Ship It! - Jayush Luniya On Jan. 24, 2017, 7:50

Re: Review Request 55925: AMBARI-19704 Enable Group Sync when Incremental sync is enabled for Ranger Usersync

2017-01-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55925/#review162989 --- Ship it! Ship It! - Jayush Luniya On Jan. 25, 2017, 11:40

Re: Review Request 55814: Add log rotation settings - handle upgrade scenario - Storm, Hive

2017-01-23 Thread Jayush Luniya
g/r/55814/#comment234108> Nit! WebHCat instead of Webhcat - Jayush Luniya On Jan. 21, 2017, 6:11 a.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 55854: Small fixes for common log rotation

2017-01-23 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55854/#review162763 --- Ship it! Ship It! - Jayush Luniya On Jan. 23, 2017, 8 p.m

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

2017-01-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55692/#review162379 --- Ship it! Ship It! - Jayush Luniya On Jan. 19, 2017, 10:40

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

2017-01-19 Thread Jayush Luniya
s/HDP/2.0.6/properties/stack_features.json - Jayush Luniya On Jan. 18, 2017, 11:46 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host

2017-01-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review162173 --- Ship it! Ship It! - Jayush Luniya On Jan. 18, 2017, 6:01

Re: Review Request 55609: Add Livy session recovery configurations in Ambari

2017-01-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55609/#review162172 --- Ship it! Ship It! - Jayush Luniya On Jan. 18, 2017, 2:25

Re: Review Request 55663: Add support for call context to the stack advisor

2017-01-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55663/#review162171 --- Ship it! Ship It! - Jayush Luniya On Jan. 18, 2017, 5:54

Re: Review Request 55674: AMBARI-19044 ADDENDUM Install & configure Ranger plugin components independently of Ranger admin components

2017-01-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55674/#review162152 --- Ship it! Ship It! - Jayush Luniya On Jan. 18, 2017, 1:35

Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host

2017-01-17 Thread Jayush Luniya
utomatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6/ > --- > > (Updated Jan. 17, 2017, 2:12 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, > Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid

Re: Review Request 55630: Hbase, Zookeeper start failed

2017-01-17 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55630/#review161892 --- Ship it! Ship It! - Jayush Luniya On Jan. 17, 2017, 4:38

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review161813 --- Ship it! Ship It! - Jayush Luniya On Jan. 13, 2017, 3:33

Re: Review Request 55538: AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file to desired location

2017-01-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55538/#review161781 --- Ship it! Ship It! - Jayush Luniya On Jan. 16, 2017, 6:45

Re: Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

2017-01-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55182/#review161762 --- Ship it! Ship It! - Jayush Luniya On Jan. 5, 2017, 4:33 p.m

Re: Review Request 55524: Add log rotation settings to Hive, Druid, Storm

2017-01-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55524/#review161759 --- Ship it! Ship It! - Jayush Luniya On Jan. 13, 2017, 9:48

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-12 Thread Jayush Luniya
patch? - Jayush Luniya On Jan. 10, 2017, 1:31 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-12 Thread Jayush Luniya
/test_stack_advisor.py (line 1551) <https://reviews.apache.org/r/46268/#comment232703> Please run without -DskipPythonTests flag - Jayush Luniya On Jan. 10, 2017, 1:31 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically g

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-12 Thread Jayush Luniya
518) <https://reviews.apache.org/r/46268/#comment232686> Is this supposed to be part of the fix? ambari-web/app/controllers/wizard/step7_controller.js (line 539) <https://reviews.apache.org/r/46268/#comment232687> Is this supposed to be part of the fix? - Jayush Luniya

Re: Review Request 55174: AMBARI-19360 : Ranger policies not syncing for storm, kafka and knox

2017-01-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55174/#review161420 --- Ship it! - Jayush Luniya On Jan. 11, 2017, 2:59 p.m., Vishal

Re: Review Request 55402: Minor: Ownership is changed before the creation of directory

2017-01-12 Thread Jayush Luniya
; > AssertionError: 'Execute' != 'Directory' > > > > -- > > Total run:1158 > > Total errors:0 > > Total failures:4 > > ``` > > A

Re: Review Request 55373: AMBARI-19438 Add enable delta sync property for Ranger

2017-01-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55373/#review161284 --- Ship it! Ship It! - Jayush Luniya On Jan. 10, 2017, 8:15

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-11 Thread Jayush Luniya
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46268/ > --- > > (Updated Jan. 10, 2017, 1:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Je

Re: Review Request 55402: Minor: Ownership is changed before the creation of directory

2017-01-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55402/#review161282 --- Ship it! Ship It! - Jayush Luniya On Jan. 11, 2017, 4:25

Re: Review Request 55174: AMBARI-19360 : Ranger policies not syncing for storm, kafka and knox

2017-01-11 Thread Jayush Luniya
/stack_features.json (line 337) <https://reviews.apache.org/r/55174/#comment232503> What about HDF since it doesnt have HDFS? Not supported feature? - Jayush Luniya On Jan. 11, 2017, 2:59 p.m., Vishal Suvagia wrote: > > ---

Re: Review Request 53808: AMBARI-18905 - Management pack purge option should support extensions

2016-11-16 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53808/#review156120 --- Ship it! Ship It! - Jayush Luniya On Nov. 16, 2016, 1:16

Re: Review Request 53564: Ranger install asks to populate AD domain and marks its required when no AD is in play

2016-11-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53564/#review155367 --- Ship it! Ship It! - Jayush Luniya On Nov. 8, 2016, 2:45 a.m

Re: Review Request 53454: AMBARI-18795: Ambari-server: Stack definition to specify which services support credential store

2016-11-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53454/#review155310 --- Ship it! Ship It! - Jayush Luniya On Nov. 8, 2016, 5:16 p.m

Re: Review Request 53564: Ranger install asks to populate AD domain and marks its required when no AD is in play

2016-11-08 Thread Jayush Luniya
tps://reviews.apache.org/r/53564/#comment225178> The message is a bit misleading. HDF-2.0 is equivalent to HDP-2.5. The logic really is for which base stack folder to use. Also is there a long term solution to make this logic stack agnostic? - Jayush Luniya On Nov. 8, 2016, 2:45 a.m.,

Re: Review Request 53454: AMBARI-18795: Ambari-server: Stack definition to specify which services support credential store

2016-11-06 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53454/#review155079 --- Ship it! Ship It! - Jayush Luniya On Nov. 4, 2016, 8:32 p.m

Re: Review Request 53454: AMBARI-18795: Ambari-server: Stack definition to specify which services support credential store

2016-11-04 Thread Jayush Luniya
/metainfo.xml (line 26) <https://reviews.apache.org/r/53454/#comment224797> What about RANGER in HDP-2.2 and HDP-2.3? - Jayush Luniya On Nov. 4, 2016, 4:53 p.m., Nahappan Somasundaram wrote: > > --- > This is a

Re: Review Request 53346: AMBARI-18765 - Services with invalid themes hang the UI when you attempt to add them

2016-11-03 Thread Jayush Luniya
> On Nov. 3, 2016, 4:21 p.m., Jayush Luniya wrote: > > Ship It! Ok with the change, but does this need to be in 2.4.2 or fine with keeping this in 2.5.0? - Jayush --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 53346: AMBARI-18765 - Services with invalid themes hang the UI when you attempt to add them

2016-11-03 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53346/#review154748 --- Ship it! Ship It! - Jayush Luniya On Nov. 1, 2016, 6:47 p.m

Re: Review Request 53412: AMBARI-18778: Ambari-server: Blueprint enhancements to support enabling or disabling credential store

2016-11-03 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53412/#review154684 --- Ship it! Ship It! - Jayush Luniya On Nov. 2, 2016, 11:54

Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

2016-11-03 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53283/#review154683 --- Ship it! Ship It! - Jayush Luniya On Nov. 2, 2016, 5:49 p.m

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

2016-11-03 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/#review154682 --- Ship it! Ship It! - Jayush Luniya On Oct. 31, 2016, 8:10

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for HBase, Spark, Spark2, Zeppelin to AmbariPreupload script

2016-10-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53188/#review154304 --- Ship it! Ship It! - Jayush Luniya On Oct. 29, 2016, 4:36

Re: Review Request 53182: Zeppelin fails to start after deployment due to timing issue

2016-10-31 Thread Jayush Luniya
ctions/decorator.py#L29 Example: https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L51 - Jayush Luniya On Oct. 27, 2016, 11:19 a.m., Renjith Kamath

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Jayush Luniya
/common-services/MICROSOFT_R/8.0.5/metainfo.xml (line 35) <https://reviews.apache.org/r/52860/#comment222388> Rename to microsoft_r_node_client.py? - Jayush Luniya On Oct. 14, 2016, 10:07 a.m., Balázs Bence Sári wrote: > > -

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52860/#review153109 --- Ship it! Ship It! - Jayush Luniya On Oct. 14, 2016, 10:07

Re: Review Request 49484: Remove spark.yarn.max.executor.failures configuration in Spark Ambari definition

2016-10-18 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49484/#review153107 --- Ship it! Ship It! - Jayush Luniya On Oct. 17, 2016, 6:40

Re: Review Request 52551: Update Mirosoft R version in mpack

2016-10-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52551/#review151549 --- Ship it! Ship It! - Jayush Luniya On Oct. 5, 2016, 12:31

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-10-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review151547 --- Ship it! Ship It! - Jayush Luniya On Sept. 30, 2016, 12:39

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

2016-10-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/#review151548 --- Ship it! Ship It! - Jayush Luniya On Oct. 4, 2016, 12:43

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

2016-10-03 Thread Jayush Luniya
/ServiceInfo.java (line 71) <https://reviews.apache.org/r/52485/#comment219465> No XmlElement? - Jayush Luniya On Oct. 3, 2016, 3:20 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

2016-10-03 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/#review151187 --- Add unit tests - Jayush Luniya On Oct. 3, 2016, 3:20 p.m

Re: Review Request 52264: AMBARI-18466 Component should be renamed to "Microsoft R Server Client"

2016-09-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52264/#review150856 --- Ship it! Ship It! - Jayush Luniya On Sept. 26, 2016, 6:07

Re: Review Request 52223: AMBARI-18051 - Services should be able to provide their own pre-req checks by supplying a jar file

2016-09-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52223/#review150854 --- Ship it! Ship It! - Jayush Luniya On Sept. 23, 2016, 7:59

Re: Review Request 52298: Refactor yarn() function in YARN service. Part 1.

2016-09-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52298/#review150853 --- Ship it! Ship It! - Jayush Luniya On Sept. 27, 2016, 10:05

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2016-09-22 Thread Jayush Luniya
/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml (line 21) <https://reviews.apache.org/r/52123/#comment217856> So if there is no public repo, will the customer be creating a local/private repo? - Jayush Luniya On Sept. 22, 2016, 8:59 a.m., Balázs Bence Sári

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-09-20 Thread Jayush Luniya
- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51815/ > ------- > > (Updated Sept. 16, 2016, 4:57 p.m.) > > > Review request for Ambari, Sh

Re: Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

2016-09-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52038/#review149742 --- Ship it! Ship It! - Jayush Luniya On Sept. 19, 2016, 2:28

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

2016-09-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51890/#review149076 --- Ship it! Ship It! - Jayush Luniya On Sept. 15, 2016, 5:26

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

2016-09-14 Thread Jayush Luniya
/package/scripts/params_linux.py (line 694) <https://reviews.apache.org/r/51890/#comment216464> Why using stack_supports_ranger_kerberos? It sounds like a workaround for >= HDP-2.5+. - Jayush Luniya On Sept. 14, 2016, 4:32 p.m., Mugdha Varad

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Jayush Luniya
o a service definition in an extension is processed when the extension is linked and refreshed. NOTE: When backporting this patch to 2.4/2.5 branches, we will have conflicts as the patch for AMBARI-18325 is in trunk, but not in those branches. - Jayush Luniya On Sept. 13, 2016, 9:31 a.m., Balázs

Re: Review Request 51846: AMBARI-18375 Ranger Plugin configs is not generated for Hive interactive

2016-09-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51846/#review148768 --- Ship it! Ship It! - Jayush Luniya On Sept. 13, 2016, 1:39

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Jayush Luniya
- On Sept. 13, 2016, 1:22 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51838/ > --- > > (Updated Sept

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

2016-09-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51838/#review148753 --- Ship it! Ship It! - Jayush Luniya On Sept. 13, 2016, 1:22

Re: Review Request 51811: All classes recompiled due to Maven bug, even if none changed

2016-09-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51811/#review148513 --- Ship it! Ship It! - Jayush Luniya On Sept. 12, 2016, 3:56

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-08 Thread Jayush Luniya
/mpack.json (line 50) <https://reviews.apache.org/r/51725/#comment215723> If the service is in HDP-2.3 then by stack inheritance it will also be in 2.4 and 2.5 right? So do we need this change? - Jayush Luniya On Sept. 8, 2016, 2 p.m., Balázs Bence Sári

Re: Review Request 51570: Enable log search for NIFI_CA component

2016-09-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51570/#review148235 --- Ship it! Ship It! - Jayush Luniya On Sept. 1, 2016, 8:44

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-06 Thread Jayush Luniya
hing - then they just > > blew over ours)? > > > > You need to fix the code formatting so it's consistent and a bit easier to > > read. > > > > In general, I don't like the idea of using service name to tie a repo to a > > service. Maybe name

Re: Review Request 51527: Ambari server upgrade script deletes all .pyc files

2016-08-30 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51527/#review147307 --- Ship it! Ship It! - Jayush Luniya On Aug. 30, 2016, 3:32

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
/RepoUtil.java (line 24) <https://reviews.apache.org/r/51238/#comment214280> Explicit imports ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java (line 63) <https://reviews.apache.org/r/51238/#comment214281> Update params list in documentation. - Jayush

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51238/ > --- > &

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml (line 24) <https://reviews.apache.org/r/51238/#comment214279> Is it mandatory to have servicename and serviceversion when defining a repoinfo at service-level? If, so can we add validations for it? - Jayush Luniya On Aug. 26, 2016

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
/internal/VersionDefinitionResourceProvider.java (line 562) <https://reviews.apache.org/r/51238/#comment214278> Why do we need to change from serializeOperatingSystems to serializeRepositoryInfos? Thats odd - Jayush Luniya On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
cluster is already deployed. Can you also test this scenario i.e. if installing a new management pack will it add this new repository for the cluster? - Jayush Luniya On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári wrote: > > --- >

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Jayush Luniya
/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml (line 24) <https://reviews.apache.org/r/51238/#comment214275> A management pack can have one than one custom services. For example for HAWQ and PXF release artifacts for both the services are in the same repo. - Jayush Luniya On A

Re: Review Request 51304: Atlas file permissions of /var/lib/ambari-agent/tmp/atlas_hbase_setup.rb need to be ${hbase_user}:${hadoop_group} (submitted by Vitaly and tested by Alejandro)

2016-08-22 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51304/#review146450 --- Ship it! Ship It! - Jayush Luniya On Aug. 22, 2016, 10:20

Re: Review Request 51282: Zeppelin service check fails after enabling SSL for Zeppelin

2016-08-22 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51282/#review146383 --- Ship it! Ship It! - Jayush Luniya On Aug. 22, 2016, 6:54

Re: Review Request 51280: Ambari logo (and other images) missing in Chrome when SSL is enabled.

2016-08-22 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51280/#review146376 --- Ship it! Ship It! - Jayush Luniya On Aug. 22, 2016, 5:52

<    1   2   3   4   5   6   >