Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Alexandr Antonenko
> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks > > Zhe (Joe) Wang wrote: > Agree. That's why I use FE to set the initial value. > > Alexandr Antonenko

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Zhe (Joe) Wang
> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks > > Zhe (Joe) Wang wrote: > Agree. That's why I use FE to set the initial value. > > Alexandr Antonenko

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Alexandr Antonenko
> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks > > Zhe (Joe) Wang wrote: > Agree. That's why I use FE to set the initial value. This is pretty clear a

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Zhe (Joe) Wang
> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks Agree. That's why I use FE to set the initial value. - Zhe (Joe) ---

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130129 --- if we will ask BE and create task for them, this will mean move th

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Zhe (Joe) Wang
> On April 22, 2016, 4 p.m., Andrii Tkach wrote: > > ambari-web/app/controllers/wizard.js, line 749 > > > > > > I don't think that's good approach to set maintenance_state to not > > installed hosts, it may cause co

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130111 --- ambari-web/app/mixins/wizard/assign_master_components.js (line 97

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130109 --- ambari-web/app/controllers/wizard.js (line 749)

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-22 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130071 --- Ship it! Ship It! - Alexandr Antonenko On April 21, 2016, 6:

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-21 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/ --- (Updated April 21, 2016, 6:49 p.m.) Review request for Ambari, Alexandr Antonen

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-21 Thread Alexandr Antonenko
> On April 21, 2016, 11:23 a.m., Alexandr Antonenko wrote: > > ambari-web/app/mixins/wizard/assign_master_components.js, line 978 > > > > > > This check can be simplified, after you added: > > "(this.get('hosts'

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-21 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review129878 --- ambari-web/app/mixins/wizard/assign_master_components.js (line 96

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-20 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review129716 --- Ship it! Ship It! - Alexandr Antonenko On April 19, 2016, 8:

Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

2016-04-19 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/ --- Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Oleg Nechiporenko,