Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157758 --- Pushed to trunk and branch-2.5 - please close this review. - Jona

Re: Review Request 53943: Improve remoteIp in audit log

> On 十一月 29, 2016, 3:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 53-55 > > > > > > This would actually do indexOf twice in cases where t

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157255 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157239 --- Ship it! Ship It! - Attila Doroszlai On Nov. 29, 2016, 1:16

Re: Review Request 53943: Improve remoteIp in audit log

> On Nov. 29, 2016, 12:55 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > line 87 > > > > > > unnecessary space before `;` > > wang yaoxin wrote: >

Re: Review Request 53943: Improve remoteIp in audit log

> On 十一月 29, 2016, 11:55 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > line 87 > > > > > > unnecessary space before `;` Thanks Attila, I have mod

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 12:16 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157224 --- ambari-server/src/main/java/org/apache/ambari/server/utils/Reques

Re: Review Request 53943: Improve remoteIp in audit log

> On 十一月 28, 2016, 4:56 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 88-90 > > > > > > 255.255.255.255 - 15 characters. But this is still no

Re: Review Request 53943: Improve remoteIp in audit log

> On 十一月 28, 2016, 2:34 p.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 88-90 > > > > > > Why is this needed and where the 15 comes from? Tha

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 1:04 a.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 12:57 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157051 --- ambari-server/src/main/java/org/apache/ambari/server/utils/Reques

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157043 --- Ship it! Ship It! - Robert Levas On Nov. 25, 2016, 4:46 a.m.

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157029 --- Please add the results of the unit tests to the reviewboard. amb

Re: Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157027 --- Ship it! Ship It! - Oliver Szabo On Nov. 25, 2016, 9:46 a.m.

Review Request 53943: Improve remoteIp in audit log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and