Re: Review Request 49260: Update desired states in case of service restarts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139577 ---

Review Request 49268: Put logsearch log level filter into smartconfigs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49268/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 49268: Put logsearch log level filter into smartconfigs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49268/#review139587 --- Ship it! Ship It! - Robert Nettleton On June 27, 2016, 3:39

Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49267/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-17450

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49267/#review139580 --- Ship it! As I understand there was no issue with the logic

Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

> On June 28, 2016, 1:28 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1650 > > > > > > Should probably make a less generic name. Also,

Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49291/#review139711 ---

Review Request 49286: AmbariServer looks for ldap_url, container_dn in blueprint even for MIT security type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49286/ --- Review request for Ambari, Alejandro Fernandez, Denys Buzhor, Jonathan Hurley,

Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49291/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/#review139675 --- Ship it! Ship It! - Sebastian Toader On June 27, 2016, 4:01

Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

> On June 27, 2016, 6:28 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1650 > > > > > > Should probably make a less generic name. Also,

Re: Review Request 49249: AMBARI-17445: Storm metrics sink: expand metrics name to contain additional informations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49249/ --- (Updated 6 27, 2016, 11:02 오후) Review request for Ambari, Aravindan Vijayan,

Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49287/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-17358

Review Request 49282: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents process shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49282/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49188/ --- (Updated June 28, 2016, 12:37 a.m.) Review request for Ambari, Alejandro

Re: Review Request 49282: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents process shutdown

> On June 27, 2016, 11:16 p.m., Sid Wagle wrote: > > Ship It! The Jira title does not correctly describe the intended fix. - Sid --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/#review139611 ---

Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/#review139617 --- Ship it! Ship It! - Alejandro Fernandez On June 27, 2016,

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

> On June 27, 2016, 3:45 p.m., Alexandr Antonenko wrote: > > As I understand there was no issue with the logic that you changed? > > If that is so, than why do we need this changes ? > > > > p.s. patch looks good and can be committed. Hello Alex, Thx for the review. A feedback I got from

Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48628/#review139719 --- hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 Should also be

Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

> On June 28, 2016, 2:52 a.m., Sid Wagle wrote: > > hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 Should also be change to use > > the comma separated host:port field. Thank you for reviewing! I'll update the patch in a few days. - Masahiro

Re: Review Request 49204: Incorrect error message for invalid category in Host Combo Search Box

> On June 24, 2016, 5:07 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you help push it? done - Alexandr --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/#review139635 --- Ship it! Ship It! - Srimanth Gunturi On June 27, 2016,

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

> On June 27, 2016, 3:45 p.m., Alexandr Antonenko wrote: > > As I understand there was no issue with the logic that you changed? > > If that is so, than why do we need this changes ? > > > > p.s. patch looks good and can be committed. > > Di Li wrote: > Hello Alex, > > Thx for

Re: Review Request 49221: [PREVIEW] Smart configs for Atlas to setup authentication as either LDAP or AD

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49221/#review139636 --- Ship it! Ship It! - Swapan Shridhar On June 25, 2016, 12:08

Re: Review Request 49233: Remove superfluous Logfeeder codes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49233/#review139526 --- Ship it! Ship It! - Hayat Behlim On June 25, 2016, 11:49

Review Request 49249: AMBARI-17445: Storm metrics sink: expand metrics name to contain additional informations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49249/ --- Review request for Ambari, Aravindan Vijayan, Prajwal Rao, Sriharsha

Re: Review Request 49221: [PREVIEW] Smart configs for Atlas to setup authentication as either LDAP or AD

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49221/#review139559 --- Ship it! Ship It! - Robert Levas On June 24, 2016, 8:08

Re: Review Request 49260: Update desired states in case of service restarts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139563 --- Ship it! Ship It! - Daniel Gergely On jún. 27, 2016, 12:42

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 11:59 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139557 --- Ship it! Ship It! - Sandor Magyari On June 27, 2016, 11:59

Re: Review Request 49255: Upgrade Solr version to 5.5.2 and use apache archive repo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49255/#review139545 --- Ship it! Ship It! - Daniel Gergely On jún. 27, 2016, 9:43

Review Request 49260: Update desired states in case of service restarts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/ --- Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, and

Re: Review Request 49260: Update desired states in case of service restarts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/ --- (Updated June 27, 2016, 12:12 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139568 --- Ship it! Ship It! - Robert Levas On June 27, 2016, 9:36

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139560 --- Fix it, then Ship it! Ship It!

Re: Review Request 49260: Update desired states in case of service restarts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/ --- (Updated June 27, 2016, 12:42 p.m.) Review request for Ambari, Daniel Gergely,

Review Request 49265: When querying host role command entities, the number of parameters should be limited

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit

Re: Review Request 49260: Update desired states in case of service restarts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139565 --- Ship it! Ship It! - Sandor Magyari On June 27, 2016, 12:42

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

> On June 27, 2016, 12:42 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java, > > line 109 > > > > > > Why are we checking for

Review Request 49263: Datanode start fails with umask 027 on ambari-server node

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49263/ --- Review request for Ambari and Dmytro Sen. Bugs: AMBARI-17447

Re: Review Request 49263: Datanode start fails with umask 027 on ambari-server node

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49263/#review139562 --- Ship it! Ship It! - Dmytro Sen On Июнь 27, 2016, 12:42

Re: Review Request 49260: Update desired states in case of service restarts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139567 --- Ship it! Ship It! - Oliver Szabo On June 27, 2016, 12:42

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 1:36 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49233: Remove superfluous Logfeeder codes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49233/ --- (Updated June 27, 2016, 10:56 a.m.) Review request for Ambari, Don Bosco

Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/ --- (Updated June 27, 2016, 11:20 a.m.) Review request for Ambari, Alejandro

Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- Review request for Ambari, Daniel Gergely, Miklos Gergely, Robert Levas, and

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 9:47 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139544 --- Ship it!

Review Request 49255: Upgrade Solr version to 5.5.2 and use apache archive repo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49255/ --- Review request for Ambari, Daniel Gergely, Miklos Gergely, Sandor Magyari, and

Re: Review Request 49255: Upgrade Solr version to 5.5.2 and use apache archive repo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49255/#review139548 --- Ship it! Ship It! - Miklos Gergely On June 27, 2016, 9:43