Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/#review143111
---


Ship it!




Ship It!

- Jayush Luniya


On July 21, 2016, 10:19 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50287/
> ---
> 
> (Updated July 21, 2016, 10:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17830
> https://issues.apache.org/jira/browse/AMBARI-17830
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by: 
> org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: 
> Stack Advisor reported an error: KeyError: 'atlas.server.https.port'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 19753e5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
> 
> Diff: https://reviews.apache.org/r/50287/diff/
> 
> 
> Testing
> ---
> 
> Tested Atlas installation
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50305: Views in Ambari UI don't render when proxied by Knox - contrib views

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50305/#review143126
---


Ship it!




Ship It!

- Ashwin Rajeev


On July 21, 2016, 6:38 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50305/
> ---
> 
> (Updated July 21, 2016, 6:38 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Rohit Choudhary, Ashwin Rajeev, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-17295
> https://issues.apache.org/jira/browse/AMBARI-17295
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using Knox's AMBARIUI service to proxy the Ambari service's UI, the 
> various 'views' don't render. The rest of the UI around management of 
> services works correctly.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> 5c92ac7 
>   contrib/views/files/src/main/resources/ui/app/adapters/application.js 
> a7ccbf4 
>   contrib/views/files/src/main/resources/ui/app/index.html 51d1839 
>   contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 8bbcf01 
> 
> Diff: https://reviews.apache.org/r/50305/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

[Jayush Luniya]

> On July 21, 2016, 3:30 p.m., Jonathan Hurley wrote:
> > It would have been nice to break this type of server action out into 
> > something more generic for alert updates. That way, future changes like 
> > this won't need to worry about broadcasting events. However, it's not 
> > necessary for this release.

+1 with Jonathan. @Gautam can you file a follow up JIRA on this?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review143087
---


On July 21, 2016, 12:36 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 21, 2016, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb02cf24e64b16171c2cd13cb94f9518ada 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265b00240790ed96aadcaddff5b7b97d4b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Review Request 50306: UI does not allow to delete service is some host components are in INSTALLED_FAILED state

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50306/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-17841
https://issues.apache.org/jira/browse/AMBARI-17841


Repository: ambari


Description
---

*STR:*
# Deploy a service ad abort installation in the middle in a way such that some 
of its slave host components remains in INSTALLED_FAILED state but no all
# Try deleting service

*Expected Result:* UI should allow service deletion as API allows it in this 
scenario
*Actual Result:* UI shows a warning popup in green color and does not let user 
delete a service. screenshot attached


Diffs
-

  ambari-web/app/models/client_component.js 3902227 
  ambari-web/app/models/host_component.js 91642c9 
  ambari-web/app/models/service.js c648e93 
  ambari-web/test/models/service_test.js e527e1e 

Diff: https://reviews.apache.org/r/50306/diff/


Testing
---

Verified that the patch fixes the issue on a cluster
Verified that ambari-web unit tests passes with the patch
29219 tests complete (29 seconds)
154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50289/#review143112
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 21, 2016, 12:57 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50289/
> ---
> 
> (Updated July 21, 2016, 12:57 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17832
> https://issues.apache.org/jira/browse/AMBARI-17832
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Install HDP 2.4 with HDFS, ZK, MR, LogSearch, and Atlas (with requires either 
> internal or external HBASE)
> 
> Will fail because no HBASE was provided and it did not warn or show an error 
> about missing HBASE configs.
> 
> Deployment error:
> {code}
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 294, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'source 
> /etc/atlas/conf/atlas-env.sh ; 
> /usr/hdp/current/atlas-server/bin/atlas_start.py' returned 255. Exception: 
> ('Could not find hbase-site.xml in %s. Please set env var HBASE_CONF_DIR to 
> the hbase client conf dir', '/etc/hbase/conf')
> Traceback (most recent call last):
> File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 150, in 
> returncode = main()
> File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 93, in main
> raise Exception("Could not find hbase-site.xml in %s. Please set env var 
> HBASE_CONF_DIR to the hbase client conf dir", hbase_conf_dir)
> Exception: ('Could not find hbase-site.xml in %s. Please set env var 
> HBASE_CONF_DIR to the hbase client conf dir', '/etc/hbase/conf')
> {code}
> 
> UI did not prompt to select HBase when selecting Atlas.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 502d1a4 
> 
> Diff: https://reviews.apache.org/r/50289/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50256/#review143121
---




ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml (line 
744)


Why was this necessary in HDP 2.4 -> 2.4*?


- Alejandro Fernandez


On July 20, 2016, 6:46 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50256/
> ---
> 
> (Updated July 20, 2016, 6:46 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17798
> https://issues.apache.org/jira/browse/AMBARI-17798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support for fixing oozie admin user for Falcon when doing upgrades
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  a7383a2 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 85ffb8c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  00dbaa7 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 78d22ab 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 68e8fc2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50256/diff/
> 
> 
> Testing
> ---
> 
> Added UT and successfully executed it
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50306: UI does not allow to delete service is some host components are in INSTALLED_FAILED state

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50306/#review143135
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On July 21, 2016, 7:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50306/
> ---
> 
> (Updated July 21, 2016, 7:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17841
> https://issues.apache.org/jira/browse/AMBARI-17841
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR:*
> # Deploy a service ad abort installation in the middle in a way such that 
> some of its slave host components remains in INSTALLED_FAILED state but no all
> # Try deleting service
> 
> *Expected Result:* UI should allow service deletion as API allows it in this 
> scenario
> *Actual Result:* UI shows a warning popup in green color and does not let 
> user delete a service. screenshot attached
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/client_component.js 3902227 
>   ambari-web/app/models/host_component.js 91642c9 
>   ambari-web/app/models/service.js c648e93 
>   ambari-web/test/models/service_test.js e527e1e 
> 
> Diff: https://reviews.apache.org/r/50306/diff/
> 
> 
> Testing
> ---
> 
> Verified that the patch fixes the issue on a cluster
> Verified that ambari-web unit tests passes with the patch
> 29219 tests complete (29 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review143116
---




ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 (line 379)


We havent restarted RANGER on the new version at this point right? So we 
are setting alerts beforehand? Shouldnt we do this after RANGER is upgraded?

Also what about DOWNGRADE? If we go all the way to Finalize step and kick 
DOWNGRADE will old alerts be restored?


- Jayush Luniya


On July 21, 2016, 12:36 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 21, 2016, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb02cf24e64b16171c2cd13cb94f9518ada 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265b00240790ed96aadcaddff5b7b97d4b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 50305: Views in Ambari UI don't render when proxied by Knox - contrib views

[Rohit Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50305/#review143124
---


Ship it!




Ship It!

- Rohit Choudhary


On July 21, 2016, 6:27 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50305/
> ---
> 
> (Updated July 21, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Ashwin Rajeev, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17295
> https://issues.apache.org/jira/browse/AMBARI-17295
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using Knox's AMBARIUI service to proxy the Ambari service's UI, the 
> various 'views' don't render. The rest of the UI around management of 
> services works correctly.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> 5c92ac7 
>   contrib/views/files/src/main/resources/ui/app/adapters/application.js 
> a7ccbf4 
>   contrib/views/files/src/main/resources/ui/app/index.html 51d1839 
>   contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 8bbcf01 
> 
> Diff: https://reviews.apache.org/r/50305/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

[Anita Jebaraj]

> On July 21, 2016, 6:30 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java,
> >  line 242
> > 
> >
> > Why is 'SASL' hardcoded here?

When kerberos is enabled, the listeners protocol can be PLAINTEXTSASL or 
SASL_PLAINTEXT, in HDP PLAINTEXTSASL is used throughout, but the user can still 
customize the protocol as SASL_PLAINTEXT, so I thought checking for the text 
SASL would be a better approach to avoid this issue or I can add the value 
"SASL" as third argument to replace() function.


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review143119
---


On July 20, 2016, 10:01 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50047/
> ---
> 
> (Updated July 20, 2016, 10:01 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Levas.
> 
> 
> Bugs: AMBARI-17694
> https://issues.apache.org/jira/browse/AMBARI-17694
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the protocol for listeners in 
> /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, 
> even though the Ambari UI shows otherwise
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java
>  66be3bf 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  ac7b0ae 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  ee2a671 
> 
> Diff: https://reviews.apache.org/r/50047/diff/
> 
> 
> Testing
> ---
> 
> Added 1 new test case,
>  Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 50309: AMBARI-17823: Increase default interval between retries for oozie actions

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50309/#review143141
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 21, 2016, 8:50 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50309/
> ---
> 
> (Updated July 21, 2016, 8:50 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17823
> https://issues.apache.org/jira/browse/AMBARI-17823
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Increaes the default retry interval to 30
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/configuration/oozie-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50309/diff/
> 
> 
> Testing
> ---
> 
> Validated the config
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50302: EU POST Call Takes More Than 3 Minutes on 900 Node Cluster

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50302/
---

(Updated July 21, 2016, 5:10 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate Cole, 
and Sumit Mohanty.


Bugs: AMBARI-17836
https://issues.apache.org/jira/browse/AMBARI-17836


Repository: ambari


Description
---

During Mission Control testing, it was clear that we were making 1000's of 
database calls during the creation of the orchestration for upgrades. These 
mostly revolved around getting configuration tags which was silly since we were 
always refreshing them before executing the command. 

I decided that if you're specifying that the config tags shoudl be refreshed, 
then there's no need to do any of the work ahead of time to fetch them. This 
significantly reduced the number of hot methods during the orchestration of an 
upgrade.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1e7b1b6 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 205ef9f 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 ef12c3a 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 28de8ed 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 399f26c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 9c2db1c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 2174a64 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 c390f44 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 7a5f377 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
 115b518 

Diff: https://reviews.apache.org/r/50302/diff/


Testing (updated)
---

Existing test failures in trunk not related to my changes.

Results :

Failed tests:
  
ConfigUpgradeValidityTest.testConfigurationDefinitionsExist:152->assertIdDefinitionExists:189
 Missing hdp_2_3_0_0_kafka_broker_deprecate_port in upgrade from HDP-2.2 to 
HDP-2.3 (ROLLING)
Tests in error:
  ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:48 » Ambari File 
/Us...

Tests run: 4546, Failures: 1, Errors: 1, Skipped: 34

[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 41:10 min
[INFO] Finished at: 2016-07-21T16:42:51-04:00
[INFO] Final Memory: 36M/637M
[INFO] 


Thanks,

Jonathan Hurley

Review Request 50312: AMBARI-17844: Update the content of various llap log4j properties.

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50312/
---

Review request for Ambari, Sumit Mohanty and Siddharth Seth.


Bugs: AMBARI-17844
https://issues.apache.org/jira/browse/AMBARI-17844


Repository: ambari


Description
---

AMBARI-17844: Update the content of various llap log4j properties.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
 a28aab368a9fbe56fe6bfb667d4abbbc52d2dc42 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
 0abee63bfecdea0490715352b4657f5c903c413a 

Diff: https://reviews.apache.org/r/50312/diff/


Testing
---

** Manual Testing **

Replaced llap-cli-log4j2.xml and llap-daemon-log4j.xml on a VM with the latest 
trunk build and deployed hive. Verified that 
/etc/hive2/conf/llap-cli-log4j2.properties.template and 
/etc/hive2/conf/llap-daemon-log4j.properties.template are the new ones.


Thanks,

Nahappan Somasundaram

Re: Review Request 50312: AMBARI-17844: Update the content of various llap log4j properties.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50312/#review143152
---


Ship it!




Ship It!

- Sumit Mohanty


On July 21, 2016, 11 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50312/
> ---
> 
> (Updated July 21, 2016, 11 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Siddharth Seth.
> 
> 
> Bugs: AMBARI-17844
> https://issues.apache.org/jira/browse/AMBARI-17844
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-17844: Update the content of various llap log4j properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
>  a28aab368a9fbe56fe6bfb667d4abbbc52d2dc42 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  0abee63bfecdea0490715352b4657f5c903c413a 
> 
> Diff: https://reviews.apache.org/r/50312/diff/
> 
> 
> Testing
> ---
> 
> ** Manual Testing **
> 
> Replaced llap-cli-log4j2.xml and llap-daemon-log4j.xml on a VM with the 
> latest trunk build and deployed hive. Verified that 
> /etc/hive2/conf/llap-cli-log4j2.properties.template and 
> /etc/hive2/conf/llap-daemon-log4j.properties.template are the new ones.
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Review Request 50309: AMBARI-17823: Increase default interval between retries for oozie actions

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50309/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-17823
https://issues.apache.org/jira/browse/AMBARI-17823


Repository: ambari


Description
---

Increaes the default retry interval to 30


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/configuration/oozie-site.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50309/diff/


Testing
---

Validated the config


Thanks,

Venkat Ranganathan

Re: Review Request 49387: Support password type for custom properties

[Keta Patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49387/
---

(Updated July 21, 2016, 11:11 p.m.)


Review request for Ambari, Alexandr Antonenko, Di Li, Dmitro Lisnichenko, and 
Jonathan Hurley.


Bugs: AMBARI-17041
https://issues.apache.org/jira/browse/AMBARI-17041


Repository: ambari


Description
---

Currently, services can define properties in the XML configuration files that 
is flagged as type password:
  
my.special.password

PASSWORD
Password to be masked
 
and it will be masked properly in the UI as well as blueprint.

Custom property should also support this option so that password can be added 
as custom property and treat accordingly.


==
Proposed Design for the fix:
==
At present only the key-value information of the service properties is stored 
in the DB ("clusterconfig" table in the "config_data" column). 
The "config_attributes" column stores only certain attributes like "final" 
indicating the list of properties set with the Final flag = true. 
The information about the property-type (i.e PASSWORD, USER, GROUP, 
ADDITIONAL_USER_PROPERTY, VALUE_FROM_PROPERTY_FILE, NOT_MANAGED_HDFS_PATH, etc) 
is extracted from the corresponding service's property file (e.g. 
hive-site.xml, core-site.xml, webhcat-env.xml, etc). These files contain 
information of the existing properties only. Custom Properties added by ambari 
user have no provision to store their additional attributes. 

Since, for this Jira we are concerned with only  attribute for 
Custom Properties, we could add an additional field called "Property Type" in 
the "Add Property" pop-up which shows up on clicking "Add Property ..." in the 
Custom property section for a service. For now, only 2 options are shown in the 
drop-down list: NONE and PASSWORD .
A few sample test properties are created using the new "Add Property" pop-up as 
can be seen in the following attachments. 
Attachments: 
"add_property_pop_up.tiff"
"custom_property_password_type.tiff"
"custom_property_regular_type.tiff"
"custom_properties_after_save.tiff"

The  information for these Custom properties is stored in the DB 
in "clusterconfig" table, "config_attributes" column.
The schema for "clusterconfig" table can be seen in the attachment:
"schema_of_clusterconfig_table.tiff"

The content of the "config_attributes" column with the  
information from the new Custom properties can be seen in the attachment:
"cluster_config_with_password_type_in_config_attributes_column.tiff"


Note: The fix so far is performed only for new Custom properties. The 
 information for existing properties is extracted from the 
corresponding property xml files for the service.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 066acab 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java
 eef3474 
  
ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 
84f3109 
  ambari-web/app/messages.js 24c9cfa 
  ambari-web/app/mixins/common/configs/configs_saver.js 43a77ce 
  ambari-web/app/models/configs/objects/service_config_property.js 844806f 
  ambari-web/app/templates/common/configs/addPropertyWindow.hbs 659435c 
  ambari-web/app/utils/config.js 9bb977a 
  ambari-web/app/views/common/configs/service_configs_by_category_view.js 
964e193 
  ambari-web/test/mixins/common/configs/configs_saver_test.js 4baf303 

Diff: https://reviews.apache.org/r/49387/diff/


Testing (updated)
---

No new test cases are written in the patch apart from the fix required in 
"configs_saver_test.js" to avoid test failure of existing tests.
If the proposed solution is acceptable, I will create a new patch with the 
necessary new tests.

The existing ambari-web tests after applying the patch:

  28977 tests complete (37 seconds)
  154 tests pending
  
  
With the patch "AMBARI-17041-trunk-July08.patch" the following is result of 
ambari-web tests:

  29017 tests complete (48 seconds)
  154 tests pending
  
With the patch "AMBARI-17041-trunk-July13.patch" the following is the result of 
ambari-web tests:

  29021 tests complete (26 seconds)
  154 tests pending
  
With the patch "AMBARI-17041-trunk-July20.patch" the following is the result of 
ambari-web tests:
  29292 tests complete (42 seconds)
  154 tests pending
  
**With the latest patch "AMBARI-17041-July21-updated.patch" the following is 
the result of ambari-web tests:
  29343 tests complete (55 seconds)
  154 tests pending


File Attachments


AMBARI-17041-July21-ES6.patch
  
https://reviews.apache.org/media/uploaded/files/2016/07/21/866014d0-310d-4e05-8290-2f82de990824__AMBARI-17041-July21-ES6.patch


Thanks,

Keta Patel

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50256/#review143137
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 21, 2016, 8:29 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50256/
> ---
> 
> (Updated July 21, 2016, 8:29 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17798
> https://issues.apache.org/jira/browse/AMBARI-17798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support for fixing oozie admin user for Falcon when doing upgrades
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a19 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 315020b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50256/diff/
> 
> 
> Testing
> ---
> 
> Added UT and successfully executed it
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Venkat Ranganathan]

> On July 21, 2016, 8:56 a.m., Venkat Ranganathan wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 331
> > 
> >
> > Do we need this.  Isn't OOZIE added in HDP21StackAdvisor whose 
> > dictionary is merged in succeeding child classes?

I see that you are adding to child configuration.  I fixed the oozie 
recommender config.  Sorry about that.   Ranger does not need to send Oozie 
config.


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/#review143089
---


On July 21, 2016, 3:19 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50287/
> ---
> 
> (Updated July 21, 2016, 3:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17830
> https://issues.apache.org/jira/browse/AMBARI-17830
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by: 
> org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: 
> Stack Advisor reported an error: KeyError: 'atlas.server.https.port'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 19753e5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
> 
> Diff: https://reviews.apache.org/r/50287/diff/
> 
> 
> Testing
> ---
> 
> Tested Atlas installation
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49387: Support password type for custom properties

[Keta Patel]

> On July 20, 2016, 11:17 p.m., Alexandr Antonenko wrote:
> > ambari-web/app/utils/config.js, line 264
> > 
> >
> > I do not see FINAL populated anywhere. I think this code will trigger 
> > fatal error. Have you tested this part manually ? 
> > 
> > Also, there is no need to check attribute[0], you just created it, and 
> > anyway there will be one and more values in that array
> > 
> > In code : attributes[0][FINAL][index] && attributes[0][FINAL][index] 
> > === "true"
> > 
> > You can skip cheking attributes[0][FINAL][index], just check 
> > attributes[0][FINAL][index] === "true".
> > 
> > If property "attributes[0][FINAL][index]" does not exist 
> > attributes[0][FINAL][index] === "true" will not trigger any error

The updated patch "AMBARI-17041-July21-updated.patch" conatins this correction. 
I have kept the original statement with the name of the variable updated to 
"attributes[0][FINAL]".

Thank you!


> On July 20, 2016, 11:17 p.m., Alexandr Antonenko wrote:
> > ambari-web/app/utils/config.js, line 248
> > 
> >
> > FYI: this can be also simplified 
> > 
> > var attributes = [];
> > ['FINAL', 'PASSWORD', 'USER', 'GROUP', 'TEXT', 
> > 'ADDITIONAL_USER_PROPERTY', 'NOT_MANAGED_HDFS_PATH', 
> > 'VALUE_FROM_PROPERTY_FILE'].forEach(function (propertyName) {
> >attributes.push(
> >{
> > [propertyName] : Em.get(configJSON, 
> > 'properties_attributes.'+propertyName) || {}})
> > })

Hello Alexandr,
I tried using the optimized statements you've mentioned here. The file attached 
"AMBARI-17041-July21-ES6.patch" contains the patch using this optimized code. 
The build is successful and even the UI behaves as intended after deploying the 
build. However, the ambari-web tests fail for this patch. I get a Syntax Error 
as seen in attachment "ambari_web_failed_to_execute_test" on the Jira. The 
tests didn't give further information on where the error occurred, but I 
figured out that the square brackets used for "propertyName" in the code above, 
belongs to ECMAScript 6 standard. Somehow, the test framework is not able to 
accept this syntax as valid. On removing the square brackets (only for 
testing), the ambari-web tests ran successfully.

I have used a workaround for this issue by using another variable to store the 
json object and then pushing that json variable to "attributes". This code is 
present in "AMBARI-17041-July21-updated.patch" (updated diff). The ambari-web 
tests are successful. Please let me know if I was making any mistake earlier or 
if I could update the patch in some other way.

Thank you!


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49387/#review143024
---


On July 20, 2016, 9:05 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49387/
> ---
> 
> (Updated July 20, 2016, 9:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17041
> https://issues.apache.org/jira/browse/AMBARI-17041
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, services can define properties in the XML configuration files that 
> is flagged as type password:
>   
> my.special.password
> 
> PASSWORD
> Password to be masked
>  
> and it will be masked properly in the UI as well as blueprint.
> 
> Custom property should also support this option so that password can be added 
> as custom property and treat accordingly.
> 
> 
> ==
> Proposed Design for the fix:
> ==
> At present only the key-value information of the service properties is stored 
> in the DB ("clusterconfig" table in the "config_data" column). 
> The "config_attributes" column stores only certain attributes like "final" 
> indicating the list of properties set with the Final flag = true. 
> The information about the property-type (i.e PASSWORD, USER, GROUP, 
> ADDITIONAL_USER_PROPERTY, VALUE_FROM_PROPERTY_FILE, NOT_MANAGED_HDFS_PATH, 
> etc) is extracted from the corresponding service's property file (e.g. 
> hive-site.xml, core-site.xml, webhcat-env.xml, etc). These files contain 
> information of the existing properties only. Custom Properties added by 
> ambari user have no provision to store their additional attributes. 
> 
> Since, for this Jira we are concerned with only  attribute for 
> Custom Properties, we could add an additional field 

Re: Review Request 49387: Support password type for custom properties

[Keta Patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49387/
---

(Updated July 21, 2016, 11:05 p.m.)


Review request for Ambari, Alexandr Antonenko, Di Li, Dmitro Lisnichenko, and 
Jonathan Hurley.


Bugs: AMBARI-17041
https://issues.apache.org/jira/browse/AMBARI-17041


Repository: ambari


Description
---

Currently, services can define properties in the XML configuration files that 
is flagged as type password:
  
my.special.password

PASSWORD
Password to be masked
 
and it will be masked properly in the UI as well as blueprint.

Custom property should also support this option so that password can be added 
as custom property and treat accordingly.


==
Proposed Design for the fix:
==
At present only the key-value information of the service properties is stored 
in the DB ("clusterconfig" table in the "config_data" column). 
The "config_attributes" column stores only certain attributes like "final" 
indicating the list of properties set with the Final flag = true. 
The information about the property-type (i.e PASSWORD, USER, GROUP, 
ADDITIONAL_USER_PROPERTY, VALUE_FROM_PROPERTY_FILE, NOT_MANAGED_HDFS_PATH, etc) 
is extracted from the corresponding service's property file (e.g. 
hive-site.xml, core-site.xml, webhcat-env.xml, etc). These files contain 
information of the existing properties only. Custom Properties added by ambari 
user have no provision to store their additional attributes. 

Since, for this Jira we are concerned with only  attribute for 
Custom Properties, we could add an additional field called "Property Type" in 
the "Add Property" pop-up which shows up on clicking "Add Property ..." in the 
Custom property section for a service. For now, only 2 options are shown in the 
drop-down list: NONE and PASSWORD .
A few sample test properties are created using the new "Add Property" pop-up as 
can be seen in the following attachments. 
Attachments: 
"add_property_pop_up.tiff"
"custom_property_password_type.tiff"
"custom_property_regular_type.tiff"
"custom_properties_after_save.tiff"

The  information for these Custom properties is stored in the DB 
in "clusterconfig" table, "config_attributes" column.
The schema for "clusterconfig" table can be seen in the attachment:
"schema_of_clusterconfig_table.tiff"

The content of the "config_attributes" column with the  
information from the new Custom properties can be seen in the attachment:
"cluster_config_with_password_type_in_config_attributes_column.tiff"


Note: The fix so far is performed only for new Custom properties. The 
 information for existing properties is extracted from the 
corresponding property xml files for the service.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 066acab 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java
 eef3474 
  
ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 
84f3109 
  ambari-web/app/messages.js 24c9cfa 
  ambari-web/app/mixins/common/configs/configs_saver.js 43a77ce 
  ambari-web/app/models/configs/objects/service_config_property.js 844806f 
  ambari-web/app/templates/common/configs/addPropertyWindow.hbs 659435c 
  ambari-web/app/utils/config.js 9bb977a 
  ambari-web/app/views/common/configs/service_configs_by_category_view.js 
964e193 
  ambari-web/test/mixins/common/configs/configs_saver_test.js 4baf303 

Diff: https://reviews.apache.org/r/49387/diff/


Testing
---

No new test cases are written in the patch apart from the fix required in 
"configs_saver_test.js" to avoid test failure of existing tests.
If the proposed solution is acceptable, I will create a new patch with the 
necessary new tests.

The existing ambari-web tests after applying the patch:

  28977 tests complete (37 seconds)
  154 tests pending
  
  
With the new latest patch "AMBARI-17041-trunk-July08.patch" the following is 
result of ambari-web tests:

  29017 tests complete (48 seconds)
  154 tests pending
  
With the new patch "AMBARI-17041-trunk-July13.patch" the following is the 
result of ambari-web tests:

  29021 tests complete (26 seconds)
  154 tests pending
  
**With the new patch "AMBARI-17041-trunk-July20.patch" the following is the 
result of ambari-web tests:
  29292 tests complete (42 seconds)
  154 tests pending


File Attachments (updated)


AMBARI-17041-July21-ES6.patch
  
https://reviews.apache.org/media/uploaded/files/2016/07/21/866014d0-310d-4e05-8290-2f82de990824__AMBARI-17041-July21-ES6.patch


Thanks,

Keta Patel

Re: Review Request 50309: AMBARI-17823: Increase default interval between retries for oozie actions

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50309/#review143148
---


Ship it!




Ship It!

- Swapan Shridhar


On July 21, 2016, 8:50 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50309/
> ---
> 
> (Updated July 21, 2016, 8:50 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17823
> https://issues.apache.org/jira/browse/AMBARI-17823
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Increaes the default retry interval to 30
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/configuration/oozie-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50309/diff/
> 
> 
> Testing
> ---
> 
> Validated the config
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50314: Show existing views under relevant service page as tabs

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50314/#review143159
---




ambari-web/app/app.js (lines 292 - 299)


Lets remove this code if it is not being used in the code



ambari-web/app/messages.js (lines 2860 - 2864)


Lets remove this line if its not being used.



ambari-web/app/views/main/dashboard.js (lines 42 - 47)


Lets revert this change if it was unintentional


- Jaimin Jetly


On July 21, 2016, 11:53 p.m., Manasi Maheshwari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50314/
> ---
> 
> (Updated July 21, 2016, 11:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17824
> https://issues.apache.org/jira/browse/AMBARI-17824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following needs to be done as part of this work
> view instances needs to be shown under relevant service as tabs
> content of the view resources needs to be shown in iframe
> Quick links location needs to be adjusted so it does not collapse with view 
> tabs
> Left service menu on the service page needs to be removed to give more space 
> to view content
> Increase the span for the pages under service page for larger width
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java
>  189daef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  74de530 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java 
> b9efd74 
>   ambari-web/app/app.js 79493a1 
>   ambari-web/app/controllers/main/charts/heatmap.js 73d1800 
>   ambari-web/app/messages.js 24c9cfa 
>   ambari-web/app/models.js e0168a2 
>   ambari-web/app/models/stack_service.js 3e2d5b4 
>   ambari-web/app/models/view_instance.js PRE-CREATION 
>   ambari-web/app/routes/main.js ebf9cb3 
>   ambari-web/app/routes/views.js 1d19279 
>   ambari-web/app/styles/application.less 200c7be 
>   ambari-web/app/templates/main/service.hbs 3a4f786 
>   ambari-web/app/templates/main/service/item.hbs 43fb3dd 
>   ambari-web/app/views.js 904edb7 
>   ambari-web/app/views/common/widget/heatmap_widget_view.js 6c74420 
>   ambari-web/app/views/main/dashboard.js 9694774 
>   ambari-web/app/views/main/service/info/menu.js 3533a72 
>   ambari-web/app/views/main/service/item.js 02ac426 
>   ambari-web/app/views/main/views/details.js df1b19b 
>   ambari-web/test/views/main/service/info/menu_test.js 5caa5b0 
> 
> Diff: https://reviews.apache.org/r/50314/diff/
> 
> 
> Testing
> ---
> 
> I verified that the patch accomplishes the tasks written in the description.
> Verified that unit test passes with the patch
> 29343 tests complete (26 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Manasi Maheshwari
> 
>

Re: Review Request 50225: the history versions of config can't be showed in the screen fully

[wuhui]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50225/
---

(Updated 七月 22, 2016, 1:42 a.m.)


Review request for Ambari.


Bugs: AMBARI-17805
https://issues.apache.org/jira/browse/AMBARI-17805


Repository: ambari


Description
---

when the number of config version is more than twenty-one,type the button 'show 
more config history' then the configs list will beyond the screen so that  we 
can't be operate the config version over the screen.
the patch will offer page turning function for the issue,people can turn page 
to browse all versions of config.


Diffs
-

  ambari-web/app/styles/application.less 2819a08 
  ambari-web/app/templates/common/configs/config_history_flow.hbs 4f14920 
  ambari-web/app/views/common/configs/config_history_flow.js da748af 

Diff: https://reviews.apache.org/r/50225/diff/


Testing
---

done?


Thanks,

wuhui

Review Request 50314: Show existing views under relevant service page as tabs

[Manasi Maheshwari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50314/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.


Bugs: AMBARI-17824
https://issues.apache.org/jira/browse/AMBARI-17824


Repository: ambari


Description
---

Following needs to be done as part of this work
view instances needs to be shown under relevant service as tabs
content of the view resources needs to be shown in iframe
Quick links location needs to be adjusted so it does not collapse with view tabs
Left service menu on the service page needs to be removed to give more space to 
view content
Increase the span for the pages under service page for larger width


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java
 189daef 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
 74de530 
  ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java b9efd74 
  ambari-web/app/app.js 79493a1 
  ambari-web/app/controllers/main/charts/heatmap.js 73d1800 
  ambari-web/app/messages.js 24c9cfa 
  ambari-web/app/models.js e0168a2 
  ambari-web/app/models/stack_service.js 3e2d5b4 
  ambari-web/app/models/view_instance.js PRE-CREATION 
  ambari-web/app/routes/main.js ebf9cb3 
  ambari-web/app/routes/views.js 1d19279 
  ambari-web/app/styles/application.less 200c7be 
  ambari-web/app/templates/main/service.hbs 3a4f786 
  ambari-web/app/templates/main/service/item.hbs 43fb3dd 
  ambari-web/app/views.js 904edb7 
  ambari-web/app/views/common/widget/heatmap_widget_view.js 6c74420 
  ambari-web/app/views/main/dashboard.js 9694774 
  ambari-web/app/views/main/service/info/menu.js 3533a72 
  ambari-web/app/views/main/service/item.js 02ac426 
  ambari-web/app/views/main/views/details.js df1b19b 
  ambari-web/test/views/main/service/info/menu_test.js 5caa5b0 

Diff: https://reviews.apache.org/r/50314/diff/


Testing
---

I verified that the patch accomplishes the tasks written in the description.
Verified that unit test passes with the patch
29343 tests complete (26 seconds)
154 tests pending


Thanks,

Manasi Maheshwari

Re: Review Request 50314: Show existing views under relevant service page as tabs

[Manasi Maheshwari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50314/
---

(Updated July 21, 2016, 11:53 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.


Changes
---

Deleted unnecessary array


Bugs: AMBARI-17824
https://issues.apache.org/jira/browse/AMBARI-17824


Repository: ambari


Description
---

Following needs to be done as part of this work
view instances needs to be shown under relevant service as tabs
content of the view resources needs to be shown in iframe
Quick links location needs to be adjusted so it does not collapse with view tabs
Left service menu on the service page needs to be removed to give more space to 
view content
Increase the span for the pages under service page for larger width


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java
 189daef 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
 74de530 
  ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java b9efd74 
  ambari-web/app/app.js 79493a1 
  ambari-web/app/controllers/main/charts/heatmap.js 73d1800 
  ambari-web/app/messages.js 24c9cfa 
  ambari-web/app/models.js e0168a2 
  ambari-web/app/models/stack_service.js 3e2d5b4 
  ambari-web/app/models/view_instance.js PRE-CREATION 
  ambari-web/app/routes/main.js ebf9cb3 
  ambari-web/app/routes/views.js 1d19279 
  ambari-web/app/styles/application.less 200c7be 
  ambari-web/app/templates/main/service.hbs 3a4f786 
  ambari-web/app/templates/main/service/item.hbs 43fb3dd 
  ambari-web/app/views.js 904edb7 
  ambari-web/app/views/common/widget/heatmap_widget_view.js 6c74420 
  ambari-web/app/views/main/dashboard.js 9694774 
  ambari-web/app/views/main/service/info/menu.js 3533a72 
  ambari-web/app/views/main/service/item.js 02ac426 
  ambari-web/app/views/main/views/details.js df1b19b 
  ambari-web/test/views/main/service/info/menu_test.js 5caa5b0 

Diff: https://reviews.apache.org/r/50314/diff/


Testing
---

I verified that the patch accomplishes the tasks written in the description.
Verified that unit test passes with the patch
29343 tests complete (26 seconds)
154 tests pending


Thanks,

Manasi Maheshwari

Review Request 50294: AMBARI-17833 EU fails during restart of Ranger Admin at setup_ranger_audit_solr

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50294/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17833
https://issues.apache.org/jira/browse/AMBARI-17833


Repository: ambari


Description
---

Handling upgrade scenario for Ranger Admin from stack 2.4 to 2.5 with solrCloud 
enable.


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 f235ba8 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 d3a6acb 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 49527dc 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 dcd6f73 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 e7ae8ba 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 ea79ae1 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 7079626 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 5059595 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 21a70e6 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 fefc659 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 
53e26a6 

Diff: https://reviews.apache.org/r/50294/diff/


Testing
---

Tested Ranger upgrade from stack 2.4 to 2.5 with solrcloud enable in simple as 
well as secure env.


Running tests for stack:2.5 service:RANGER
test_configure_default (test_ranger_admin.TestRangerAdmin)
ok
test_configure_secured (test_ranger_admin.TestRangerAdmin) 
ok
test_start_default (test_ranger_admin.TestRangerAdmin) ... ok
test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok
test_stop_default (test_ranger_admin.TestRangerAdmin) 
ok
test_configure_default (test_ranger_usersync.TestRangerUsersync)
ok
test_configure_secured (test_ranger_usersync.TestRangerUsersync)
ok
test_start_default (test_ranger_usersync.TestRangerUsersync)
ok
test_stop_default (test_ranger_usersync.TestRangerUsersync) 
ok
test_configure_default (test_ranger_tagsync.TestRangerTagsync) 
ok
test_configure_secured (test_ranger_tagsync.TestRangerTagsync) 
ok
test_start_default (test_ranger_tagsync.TestRangerTagsync) 
ok
test_stop_default (test_ranger_tagsync.TestRangerTagsync)
ok

--
Ran 13 tests in 0.380s

OK


Thanks,

Mugdha Varadkar

Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

[Hemanth Yamijala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/
---

Review request for Ambari.


Bugs: AMBARI-17788
https://issues.apache.org/jira/browse/AMBARI-17788


Repository: ambari


Description
---

This patch extracts spooling functions outside OutputHDFSFile so that it can be 
used for AMBARI-17785. The patch allows callbacks to check the condition on 
which spool files should be rolled over and what to do on rollover.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
 9272636 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50297/diff/


Testing
---

* New unit tests.
* Have tested by installing new RPM on an existing Ambari installation and 
configuring the output for one of the services to write to HDFS. Tested that 
upload to HDFS, rollover is working correctly for this service.


Thanks,

Hemanth Yamijala

Re: Review Request 50239: Spark Livy should wait for ATS start for BP deployments

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50239/
---

(Updated Июль 21, 2016, 9:49 д.п.)


Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and Sumit 
Mohanty.


Bugs: AMBARI-17814
https://issues.apache.org/jira/browse/AMBARI-17814


Repository: ambari


Description
---

Spark Livy should wait for ATS start for BP deployments
We should do something like:

 if params.has_ats:
  Logger.info("Verifying DFS directories where ATS stores time line data 
for active and completed applications.")
  self.wait_for_dfs_directories_created(params.entity_groupfs_store_dir, 
params.entity_groupfs_active_dir)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
 1e859a8 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 61f73fb 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py ed331ea 

Diff: https://reviews.apache.org/r/50239/diff/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [3.566s]
[INFO] Apache Ambari Project POM . SUCCESS [0.038s]
[INFO] Ambari Views .. SUCCESS [3.311s]
[INFO] ambari-metrics  SUCCESS [0.469s]
[INFO] Ambari Metrics Common . SUCCESS [0.681s]
[INFO] Ambari Server . SUCCESS [1:06.033s]
[INFO] 
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen

Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17830
https://issues.apache.org/jira/browse/AMBARI-17830


Repository: ambari


Description
---

Caused by: 
org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: Stack 
Advisor reported an error: KeyError: 'atlas.server.https.port'


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
19753e5 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
5e380d8 

Diff: https://reviews.apache.org/r/50287/diff/


Testing
---

Tested Atlas installation


Thanks,

Mugdha Varadkar

Re: Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50289/#review143081
---


Ship it!




Ship It!

- Dmytro Sen


On Июль 21, 2016, 12:57 п.п., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50289/
> ---
> 
> (Updated Июль 21, 2016, 12:57 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17832
> https://issues.apache.org/jira/browse/AMBARI-17832
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Install HDP 2.4 with HDFS, ZK, MR, LogSearch, and Atlas (with requires either 
> internal or external HBASE)
> 
> Will fail because no HBASE was provided and it did not warn or show an error 
> about missing HBASE configs.
> 
> Deployment error:
> {code}
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 294, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'source 
> /etc/atlas/conf/atlas-env.sh ; 
> /usr/hdp/current/atlas-server/bin/atlas_start.py' returned 255. Exception: 
> ('Could not find hbase-site.xml in %s. Please set env var HBASE_CONF_DIR to 
> the hbase client conf dir', '/etc/hbase/conf')
> Traceback (most recent call last):
> File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 150, in 
> returncode = main()
> File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 93, in main
> raise Exception("Could not find hbase-site.xml in %s. Please set env var 
> HBASE_CONF_DIR to the hbase client conf dir", hbase_conf_dir)
> Exception: ('Could not find hbase-site.xml in %s. Please set env var 
> HBASE_CONF_DIR to the hbase client conf dir', '/etc/hbase/conf')
> {code}
> 
> UI did not prompt to select HBase when selecting Atlas.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 502d1a4 
> 
> Diff: https://reviews.apache.org/r/50289/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 50289: ATLAS should throw a validation error if HBase related configs are missing

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50289/
---

Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.


Bugs: AMBARI-17832
https://issues.apache.org/jira/browse/AMBARI-17832


Repository: ambari


Description
---

STR:
Install Ambari 2.4
Install HDP 2.4 with HDFS, ZK, MR, LogSearch, and Atlas (with requires either 
internal or external HBASE)

Will fail because no HBASE was provided and it did not warn or show an error 
about missing HBASE configs.

Deployment error:
{code}
File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
294, in _call
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'source 
/etc/atlas/conf/atlas-env.sh ; 
/usr/hdp/current/atlas-server/bin/atlas_start.py' returned 255. Exception: 
('Could not find hbase-site.xml in %s. Please set env var HBASE_CONF_DIR to the 
hbase client conf dir', '/etc/hbase/conf')
Traceback (most recent call last):
File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 150, in 
returncode = main()
File "/usr/hdp/current/atlas-server/bin/atlas_start.py", line 93, in main
raise Exception("Could not find hbase-site.xml in %s. Please set env var 
HBASE_CONF_DIR to the hbase client conf dir", hbase_conf_dir)
Exception: ('Could not find hbase-site.xml in %s. Please set env var 
HBASE_CONF_DIR to the hbase client conf dir', '/etc/hbase/conf')
{code}

UI did not prompt to select HBase when selecting Atlas.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
5e380d8 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 502d1a4 

Diff: https://reviews.apache.org/r/50289/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/#review143089
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
331)


Do we need this.  Isn't OOZIE added in HDP21StackAdvisor whose dictionary 
is merged in succeeding child classes?


- Venkat Ranganathan


On July 21, 2016, 3:19 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50287/
> ---
> 
> (Updated July 21, 2016, 3:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17830
> https://issues.apache.org/jira/browse/AMBARI-17830
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by: 
> org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: 
> Stack Advisor reported an error: KeyError: 'atlas.server.https.port'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 19753e5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
> 
> Diff: https://reviews.apache.org/r/50287/diff/
> 
> 
> Testing
> ---
> 
> Tested Atlas installation
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50300: AMBARI-17828 : Nimbus, Storm UI server stopped after disabling ranger plugins

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50300/#review143095
---


Ship it!




Ship It!

- Velmurugan Periasamy


On July 21, 2016, 4:14 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50300/
> ---
> 
> (Updated July 21, 2016, 4:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Sumit Mohanty, 
> Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17828
> https://issues.apache.org/jira/browse/AMBARI-17828
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Recommend the new class name of Storm 
> "org.apache.storm.security.auth.authorizer.SimpleACLAuthorizer" instead of 
> the old one.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 1bd820645b30da3b83935de89c82ecc8d78a82ec 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> f0a1c871c8595e8c59f1f0ea66076c7a2608005a 
> 
> Diff: https://reviews.apache.org/r/50300/diff/
> 
> 
> Testing
> ---
> 
> Tested storm on 3 node centos cluster.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review143087
---


Ship it!




It would have been nice to break this type of server action out into something 
more generic for alert updates. That way, future changes like this won't need 
to worry about broadcasting events. However, it's not necessary for this 
release.

- Jonathan Hurley


On July 21, 2016, 8:36 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 21, 2016, 8:36 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb02cf24e64b16171c2cd13cb94f9518ada 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265b00240790ed96aadcaddff5b7b97d4b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Review Request 50300: AMBARI-17828 : Nimbus, Storm UI server stopped after disabling ranger plugins

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50300/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Sumit Mohanty, 
Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17828
https://issues.apache.org/jira/browse/AMBARI-17828


Repository: ambari


Description
---

Recommend the new class name of Storm 
"org.apache.storm.security.auth.authorizer.SimpleACLAuthorizer" instead of the 
old one.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
1bd820645b30da3b83935de89c82ecc8d78a82ec 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
f0a1c871c8595e8c59f1f0ea66076c7a2608005a 

Diff: https://reviews.apache.org/r/50300/diff/


Testing
---

Tested storm on 3 node centos cluster.


Thanks,

Gautam Borad

Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50299/
---

Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.


Bugs: AMBARI-17835
https://issues.apache.org/jira/browse/AMBARI-17835


Repository: ambari


Description
---

STR
1) Set yarn.nodemanager.resource.memory-mb to be more than recommended default
2) click next


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 6f612af 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
1dd7a07 
  ambari-server/src/main/resources/stacks/stack_advisor.py 437fe4f 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
 25d634b 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 9d3ce4c 

Diff: https://reviews.apache.org/r/50299/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 50294: AMBARI-17833 EU fails during restart of Ranger Admin at setup_ranger_audit_solr

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50294/#review143093
---


Ship it!




Ship It!

- Gautam Borad


On July 21, 2016, 2:15 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50294/
> ---
> 
> (Updated July 21, 2016, 2:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17833
> https://issues.apache.org/jira/browse/AMBARI-17833
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Handling upgrade scenario for Ranger Admin from stack 2.4 to 2.5 with 
> solrCloud enable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  f235ba8 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  d3a6acb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  49527dc 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  dcd6f73 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  e7ae8ba 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  ea79ae1 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  7079626 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  5059595 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  21a70e6 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  fefc659 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 
> 53e26a6 
> 
> Diff: https://reviews.apache.org/r/50294/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5 with solrcloud enable in simple 
> as well as secure env.
> 
> 
> Running tests for stack:2.5 service:RANGER
> test_configure_default (test_ranger_admin.TestRangerAdmin)
> ok
> test_configure_secured (test_ranger_admin.TestRangerAdmin) 
> ok
> test_start_default (test_ranger_admin.TestRangerAdmin) ... ok
> test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok
> test_stop_default (test_ranger_admin.TestRangerAdmin) 
> ok
> test_configure_default (test_ranger_usersync.TestRangerUsersync)
> ok
> test_configure_secured (test_ranger_usersync.TestRangerUsersync)
> ok
> test_start_default (test_ranger_usersync.TestRangerUsersync)
> ok
> test_stop_default (test_ranger_usersync.TestRangerUsersync) 
> ok
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) 
> ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) 
> ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) 
> ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync)
> ok
> 
> --
> Ran 13 tests in 0.380s
> 
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50302: EU POST Call Takes More Than 3 Minutes on 900 Node Cluster

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50302/#review143096
---




ambari-agent/src/main/python/ambari_agent/ActionQueue.py 


Removed since they were never set in Java



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 (line 526)


When simply checking the command type, there's no need to fully deserialize 
the execution command.



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 (lines 115 - 125)


Biggest change was here; basically if refresh configs is set, then do that 
first. This way, it allows an empty set of tags to be passed in. Upgrades takes 
advantage of this by not having to lookup the config tags 1000's of times ahead 
of time.



ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 (lines 91 - 92)


It made no sense to break this out by config type. I can't imagine a reason 
for needing to only update 1 config out of 30 - just get them all. 

Also, it wasn't being used and was overly complicated.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 


This property was never used and was confusing, so we removed it.


- Jonathan Hurley


On July 21, 2016, 12:39 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50302/
> ---
> 
> (Updated July 21, 2016, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate 
> Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17836
> https://issues.apache.org/jira/browse/AMBARI-17836
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During Mission Control testing, it was clear that we were making 1000's of 
> database calls during the creation of the orchestration for upgrades. These 
> mostly revolved around getting configuration tags which was silly since we 
> were always refreshing them before executing the command. 
> 
> I decided that if you're specifying that the config tags shoudl be refreshed, 
> then there's no need to do any of the work ahead of time to fetch them. This 
> significantly reduced the number of hot methods during the orchestration of 
> an upgrade.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1e7b1b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  205ef9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  ef12c3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  28de8ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  399f26c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9c2db1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  2174a64 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  c390f44 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  7a5f377 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
>  115b518 
> 
> Diff: https://reviews.apache.org/r/50302/diff/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 50302: EU POST Call Takes More Than 3 Minutes on 900 Node Cluster

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50302/#review143098
---


Ship it!




Ship It!

- Nate Cole


On July 21, 2016, 12:39 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50302/
> ---
> 
> (Updated July 21, 2016, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate 
> Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17836
> https://issues.apache.org/jira/browse/AMBARI-17836
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During Mission Control testing, it was clear that we were making 1000's of 
> database calls during the creation of the orchestration for upgrades. These 
> mostly revolved around getting configuration tags which was silly since we 
> were always refreshing them before executing the command. 
> 
> I decided that if you're specifying that the config tags shoudl be refreshed, 
> then there's no need to do any of the work ahead of time to fetch them. This 
> significantly reduced the number of hot methods during the orchestration of 
> an upgrade.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1e7b1b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  205ef9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  ef12c3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  28de8ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  399f26c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9c2db1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  2174a64 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  c390f44 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  7a5f377 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
>  115b518 
> 
> Diff: https://reviews.apache.org/r/50302/diff/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

[Anita Jebaraj]

> On July 18, 2016, 10:58 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, 
> > line 18
> > 
> >
> > This is redundant...
> > 
> > `kafka-broker/listeners` = `kafka-broker/listeners`
> 
> Anita Jebaraj wrote:
> Hi Robert, I had to include the declaration for listeners in 
> kerberos.json since the value for listeners wont be displayed in the UI under 
> the kerberos configuration otherwise. There is a change in value for protocol 
> for listeners in specific cases (if the user hasn't added a listener with 
> PLAINTEXTSASL protocol) and I thought it would be appropriate to include it 
> in kerberos.json, even though the handling is done in the stack-advisor.py
> 
> Robert Levas wrote:
> In this case, maybe it is better to do
> 
> ```
> "listeners": ""
> ```
> 
> Else you may wind up with `kafka-broker/listeners` being set to 
> `${kafka-broker/listeners}` (literally).
> 
> Anita Jebaraj wrote:
> I am not sure if assigning an empty value for listeners in kerberos.json 
> is the right approach, I am thinking if using functions similar to each() in 
> templeton.hive.properties in VariableReplacementHelper.java would work out 
> for this scenario. May be creating a function replace() for listeners will 
> help, it can be {kafka-broker/listeners|replace()}. Please give me your 
> suggestion on this.
> 
> Robert Levas wrote:
> I think `replace()` will be ok.  Then it will be something like:
> 
> ```
> "listeners": "${kafka-broker/listeners|replace(PLAINTEXT, PLAINTEXTSASL)}"
> ```

Hi Robert, I have updated the patch based on your comments


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review142546
---


On July 20, 2016, 10:01 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50047/
> ---
> 
> (Updated July 20, 2016, 10:01 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Levas.
> 
> 
> Bugs: AMBARI-17694
> https://issues.apache.org/jira/browse/AMBARI-17694
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the protocol for listeners in 
> /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, 
> even though the Ambari UI shows otherwise
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java
>  66be3bf 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  ac7b0ae 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  ee2a671 
> 
> Diff: https://reviews.apache.org/r/50047/diff/
> 
> 
> Testing
> ---
> 
> Added 1 new test case,
>  Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50299/#review143105
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On July 21, 2016, 6:35 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50299/
> ---
> 
> (Updated July 21, 2016, 6:35 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17835
> https://issues.apache.org/jira/browse/AMBARI-17835
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR
> 1) Set yarn.nodemanager.resource.memory-mb to be more than recommended default
> 2) click next
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  6f612af 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 1dd7a07 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 437fe4f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
>  25d634b 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 9d3ce4c 
> 
> Diff: https://reviews.apache.org/r/50299/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50294: AMBARI-17833 EU fails during restart of Ranger Admin at setup_ranger_audit_solr

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50294/#review143101
---


Ship it!




Ship It!

- Jayush Luniya


On July 21, 2016, 2:15 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50294/
> ---
> 
> (Updated July 21, 2016, 2:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17833
> https://issues.apache.org/jira/browse/AMBARI-17833
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Handling upgrade scenario for Ranger Admin from stack 2.4 to 2.5 with 
> solrCloud enable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  f235ba8 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  d3a6acb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  49527dc 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  dcd6f73 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  e7ae8ba 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  ea79ae1 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  7079626 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  5059595 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  21a70e6 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  fefc659 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 
> 53e26a6 
> 
> Diff: https://reviews.apache.org/r/50294/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5 with solrcloud enable in simple 
> as well as secure env.
> 
> 
> Running tests for stack:2.5 service:RANGER
> test_configure_default (test_ranger_admin.TestRangerAdmin)
> ok
> test_configure_secured (test_ranger_admin.TestRangerAdmin) 
> ok
> test_start_default (test_ranger_admin.TestRangerAdmin) ... ok
> test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok
> test_stop_default (test_ranger_admin.TestRangerAdmin) 
> ok
> test_configure_default (test_ranger_usersync.TestRangerUsersync)
> ok
> test_configure_secured (test_ranger_usersync.TestRangerUsersync)
> ok
> test_start_default (test_ranger_usersync.TestRangerUsersync)
> ok
> test_stop_default (test_ranger_usersync.TestRangerUsersync) 
> ok
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) 
> ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) 
> ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) 
> ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync)
> ok
> 
> --
> Ran 13 tests in 0.380s
> 
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50299: Maximum validation failure for 'yarn.scheduler.maximum-allocation-mb' after dependency change

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50299/#review143106
---


Ship it!




Ship It!

- Dmytro Grinenko


On July 21, 2016, 3:35 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50299/
> ---
> 
> (Updated July 21, 2016, 3:35 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17835
> https://issues.apache.org/jira/browse/AMBARI-17835
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR
> 1) Set yarn.nodemanager.resource.memory-mb to be more than recommended default
> 2) click next
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  6f612af 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 1dd7a07 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 437fe4f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
>  25d634b 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 9d3ce4c 
> 
> Diff: https://reviews.apache.org/r/50299/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50300: AMBARI-17828 : Nimbus, Storm UI server stopped after disabling ranger plugins

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50300/#review143109
---


Ship it!




Ship It!

- Jayush Luniya


On July 21, 2016, 4:14 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50300/
> ---
> 
> (Updated July 21, 2016, 4:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Sumit Mohanty, 
> Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17828
> https://issues.apache.org/jira/browse/AMBARI-17828
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Recommend the new class name of Storm 
> "org.apache.storm.security.auth.authorizer.SimpleACLAuthorizer" instead of 
> the old one.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 1bd820645b30da3b83935de89c82ecc8d78a82ec 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> f0a1c871c8595e8c59f1f0ea66076c7a2608005a 
> 
> Diff: https://reviews.apache.org/r/50300/diff/
> 
> 
> Testing
> ---
> 
> Tested storm on 3 node centos cluster.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>