date:20160520


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47679/
---

Review request for Ambari, Alexandr Antonenko and Yusaku Sako.


Bugs: AMBARI-16670
https://issues.apache.org/jira/browse/AMBARI-16670


Repository: ambari


Description
---

PXF operations considers the agent status


Diffs
-

  ambari-web/app/controllers/main/service/item.js 77584ba 
  ambari-web/app/models/host_component.js 569879f 
  ambari-web/test/controllers/main/service/item_test.js 0830d63 
  ambari-web/test/views/main/service/item_test.js f612f2d 

Diff: https://reviews.apache.org/r/47679/diff/


Testing
---

Manually tested.

```
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building Ambari Web 2.0.0.0-SNAPSHOT
[INFO] 
[INFO] 

[92m [0m[32m 27833 tests complete[0m[90m (23 seconds)[0m
[36m [0m[36m 154 tests pending[0m

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 55.768 s
[INFO] Finished at: 2016-05-20T16:22:20-07:00
[INFO] Final Memory: 12M/310M
[INFO] 

```


Thanks,

Matt

Re: Review Request 47642: Add HAWQ Standby wizard should recommend HAWQSTANDBY correctly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47642/#review134212
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 56)


return list(ambariServerHost)


- Lav Jain


On May 20, 2016, 8:13 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47642/
> ---
> 
> (Updated May 20, 2016, 8:13 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16790
> https://issues.apache.org/jira/browse/AMBARI-16790
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On assign masters page of Add HAWQ Standby wizard, a best effort should be 
> made such that HAWQSTANDBY is not co-located with HAWQMASTER or AMBARI_SERVER.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  0590604 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 905d455 
> 
> Diff: https://reviews.apache.org/r/47642/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> Added unit tests:
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_sparkts_no_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is not installed ... ok
> test_getComponentLayoutValidations_sparkts_with_hive 
>

Re: Review Request 47673: Wrong memory conf in spark-env.xml

2016-05-20 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47673/#review134213
---


Ship it!




Ship It!

- Sumit Mohanty


On May 20, 2016, 10:15 p.m., Weiqing Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47673/
> ---
> 
> (Updated May 20, 2016, 10:15 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16715
> https://issues.apache.org/jira/browse/AMBARI-16715
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In spark-env.xml, the memory value should not have space and a extra "b" 
> character. "SPARK_DRIVER_MEMORY="512 Mb" #Memory for Master (e.g. 1000M, 2G) 
> (Default: 512 Mb)", by default this line is commented but in case user 
> uncommented it to change the memory settings then it will show a below error, 
> so it's better to change it in the default template.
> Error:
> ./bin/spark-shell
> Error: Could not find or load main class Mb
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  8a5117a 
> 
> Diff: https://reviews.apache.org/r/47673/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Weiqing Yang
> 
>

Review Request 47677: AMBARI-16804 - Refactor Move Master Wizard

2016-05-20 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47677/
---

Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-16804
https://issues.apache.org/jira/browse/AMBARI-16804


Repository: ambari


Description
---

Refactor Move Master wizard. Extract configurable texts and stack related 
definitions into a separate JS file.


Diffs
-

  ambari-web/app/controllers/main/service/reassign/step1_controller.js 9f30bb7 
  ambari-web/app/controllers/main/service/reassign/step4_controller.js d8f0394 
  ambari-web/app/controllers/main/service/reassign_controller.js 07d6e2c 
  ambari-web/app/data/wizards/move_master.js PRE-CREATION 
  ambari-web/app/routes/reassign_master_routes.js f079432 
  ambari-web/app/templates/main/service/reassign.hbs 2477229 
  ambari-web/app/templates/main/service/reassign/step1.hbs 9862cbe 
  ambari-web/app/templates/main/service/reassign/step3.hbs 1ffe989 
  ambari-web/app/views/main/service/reassign/step1_view.js ddabf14 
  ambari-web/app/views/main/service/reassign/step2_view.js 0eae84b 
  ambari-web/app/views/main/service/reassign/step4_view.js 4e1282a 
  ambari-web/app/views/main/service/reassign/step5_view.js 066b23b 
  ambari-web/app/views/main/service/reassign/step6_view.js 33f8851 
  ambari-web/app/views/main/service/reassign/step7_view.js 60b357a 
  ambari-web/test/controllers/main/service/reassign/step1_controller_test.js 
a43d91f 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
d6ef9dc 

Diff: https://reviews.apache.org/r/47677/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  27828 tests complete (28 seconds)
  154 tests pending


Thanks,

Richard Zang

Review Request 47676: Spark History Server heap size is not exposed (History Server crashed with OOM)

2016-05-20 Thread Weiqing Yang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47676/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-16757
https://issues.apache.org/jira/browse/AMBARI-16757


Repository: ambari


Description
---

Ambari is not exposing the heap size parameter for Spark History Server.
The workaround is to modify spark-env and add "SPARK_DAEMON_MEMORY=2g" for 
example.
The newer versions of Spark defaults this to 1g, but on the older versions, it 
was defaulting to 512m it seems, and it was causing OOM.
So in the patch, "SPARK_DAEMON_MEMORY=1G" is added in the spark-env template 
(default: 1G).


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
 8a5117a 

Diff: https://reviews.apache.org/r/47676/diff/


Testing
---

N/A


Thanks,

Weiqing Yang

Re: Review Request 47627: hawq_standby_address_host property should be removed from configuration if HAWQSTANDBY component does not exist in BP


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47627/#review134209
---


Ship it!




Ship It!

- Lav Jain


On May 20, 2016, 10:11 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47627/
> ---
> 
> (Updated May 20, 2016, 10:11 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Matt, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-16786
> https://issues.apache.org/jira/browse/AMBARI-16786
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> hawq_standby_address_host property should be removed from configuration if 
> HAWQSTANDBY component does not exist in BP
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1ddc4e1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  5c6aeaf 
> 
> Diff: https://reviews.apache.org/r/47627/diff/
> 
> 
> Testing
> ---
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 47673: Wrong memory conf in spark-env.xml

2016-05-20 Thread Weiqing Yang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47673/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-16715
https://issues.apache.org/jira/browse/AMBARI-16715


Repository: ambari


Description
---

In spark-env.xml, the memory value should not have space and a extra "b" 
character. "SPARK_DRIVER_MEMORY="512 Mb" #Memory for Master (e.g. 1000M, 2G) 
(Default: 512 Mb)", by default this line is commented but in case user 
uncommented it to change the memory settings then it will show a below error, 
so it's better to change it in the default template.
Error:
./bin/spark-shell
Error: Could not find or load main class Mb


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
 8a5117a 

Diff: https://reviews.apache.org/r/47673/diff/


Testing
---

N/A


Thanks,

Weiqing Yang

Re: Review Request 47627: hawq_standby_address_host property should be removed from configuration if HAWQSTANDBY component does not exist in BP


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47627/#review134208
---




ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 (line 7244)


hawqSite.containsKey("hawq_standby_address_host")


- Lav Jain


On May 20, 2016, 2:09 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47627/
> ---
> 
> (Updated May 20, 2016, 2:09 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Matt, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-16786
> https://issues.apache.org/jira/browse/AMBARI-16786
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> hawq_standby_address_host property should be removed from configuration if 
> HAWQSTANDBY component does not exist in BP
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1ddc4e1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  5c6aeaf 
> 
> Diff: https://reviews.apache.org/r/47627/diff/
> 
> 
> Testing
> ---
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47657: Hawq password to use !h flag to ensure that its only hidden and no special processing is done for it.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47657/#review134207
---


Ship it!




Ship It!

- Lav Jain


On May 20, 2016, 6:59 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47657/
> ---
> 
> (Updated May 20, 2016, 6:59 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16800
> https://issues.apache.org/jira/browse/AMBARI-16800
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hawq password to use !h flag to ensure that its only hidden and no special 
> processing is done for it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  b52b477 
> 
> Diff: https://reviews.apache.org/r/47657/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 47669: import missing check_process_status

2016-05-20 Thread Juanjo Marron


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47669/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-16362
https://issues.apache.org/jira/browse/AMBARI-16362


Repository: ambari


Description
---

Several import check_process_status were missed in previous cleanUp commits


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
 c045a91 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
 8735b2d 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor.py
 26f96c7 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server.py
 246b1d9 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
 f63886e 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
 3376ac9 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
 3421053 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 091997e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 08cb722 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_server.py
 7fe02ab 

Diff: https://reviews.apache.org/r/47669/diff/


Testing
---

Thanks to Alejandro comment on AMBARI-16362, several import  
check_process_status missing were found.

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py",
 line 151, in 
SNameNode().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 254, in execute
method(env)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 665, in restart
self.status(env)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py",
 line 61, in status
snamenode(action="status")
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py",
 line 52, in snamenode
check_process_status(status_params.snamenode_pid_file)
NameError: global name 'check_process_status' is not defined


It was not captured on the UTs, fresh installation and service_check tests


Thanks,

Juanjo  Marron

Re: Review Request 47631: 'Configure Ambari Identity' fails when enabling Kerberos on non-root Ambari server


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/#review134194
---


Ship it!




Ship It!

- Nate Cole


On May 20, 2016, 10:10 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47631/
> ---
> 
> (Updated May 20, 2016, 10:10 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16787
> https://issues.apache.org/jira/browse/AMBARI-16787
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configure Ambari Identity phase of Enable Kerberos Wizard fails since Ambari 
> does not have permission perform some root-level file system tasks like 
> chown. 
> 
> STR:
> 1. Install Ambari, executing as non-root
> 2. Create cluster (Zookeeper-only is fine)
> 3. Enable Kerberos (any KDC is fine)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  15bd2d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
>  bbc7246 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  b5d2b70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json c5ebe20 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  fc27eda 
> 
> Diff: https://reviews.apache.org/r/47631/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in cluster using UI and using Blueprints where Ambari was 
> executed as root and non-root users.
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:12:58.862s
> [INFO] Finished at: Thu May 19 23:23:12 EDT 2016
> [INFO] Final Memory: 59M/1410M
> [INFO] 
> 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

2016-05-20 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47643/#review134190
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 (line 50)


This need to be corrected.


- Sreenath Somarajapuram


On May 20, 2016, 9:57 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47643/
> ---
> 
> (Updated May 20, 2016, 9:57 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-16792
> https://issues.apache.org/jira/browse/AMBARI-16792
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Edit and validate queue name
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  02062a6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  69be18c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  89d0e89 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  a60d39d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  d57b2ba 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  c5c910a 
> 
> Diff: https://reviews.apache.org/r/47643/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-20 Thread Sriharsha Chintalapani


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/
---

(Updated May 20, 2016, 7:17 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-16648
https://issues.apache.org/jira/browse/AMBARI-16648


Repository: ambari


Description
---

Upgrade pack changes to work with Storm 1.0


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7873853 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1cd2ffa 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 7d67f8e 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
9c6a02d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a7dbba3 

Diff: https://reviews.apache.org/r/47332/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47657: Hawq password to use !h flag to ensure that its only hidden and no special processing is done for it.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47657/#review134186
---


Ship it!




Ship It!

- Matt


On May 20, 2016, 11:59 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47657/
> ---
> 
> (Updated May 20, 2016, 11:59 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16800
> https://issues.apache.org/jira/browse/AMBARI-16800
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hawq password to use !h flag to ensure that its only hidden and no special 
> processing is done for it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  b52b477 
> 
> Diff: https://reviews.apache.org/r/47657/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 47657: Hawq password to use !h flag to ensure that its only hidden and no special processing is done for it.

2016-05-20 Thread bhuvnesh chaudhary


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47657/
---

Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.


Bugs: AMBARI-16800
https://issues.apache.org/jira/browse/AMBARI-16800


Repository: ambari


Description
---

Hawq password to use !h flag to ensure that its only hidden and no special 
processing is done for it.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 b52b477 

Diff: https://reviews.apache.org/r/47657/diff/


Testing
---

yes.


Thanks,

bhuvnesh chaudhary

Re: Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-20 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47621/#review134185
---


Ship it!




Ship It!

- Sumit Mohanty


On May 20, 2016, 6:23 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47621/
> ---
> 
> (Updated May 20, 2016, 6:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16784
> https://issues.apache.org/jira/browse/AMBARI-16784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - As hive2/hive-site.xml only contains the new + the changed props compared 
> to hive/hive-site.xml, we merge hive/hive-site.xml and hive2/hive-site.xml 
> and store it in hive2/hive-site.xml.
> - Thus, as part of the merge, specifically for Hive2/hive-site.xml config 
> 'hive.exec.post.hooks', it gets the hook for Atlas from Hive1/hive-site.xml, 
> if Atlas is installed. As Atlas is not supported by Hive2, we need to remove 
> it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  8e49cf0 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ee93f9e 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 65ff8b3 
> 
> Diff: https://reviews.apache.org/r/47621/diff/
> 
> 
> Testing
> ---
> 
> -  Tested removal of 'org.apache.atlas.hive.hook.HiveHook' value from 
> 'hive.exec.post.hooks'.
> -  
> -  Added Unit Test.
> 
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-20 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/#review134178
---


Fix it, then Ship it!




Thanks for making this change. Ship It once you've tested it.


ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 (line 1051)


Don't need this manual message since will already display on the 
SUPERVISOR, which occurs first during a downgrade.


- Alejandro Fernandez


On May 20, 2016, 3:11 a.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47332/
> ---
> 
> (Updated May 20, 2016, 3:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upgrade pack changes to work with Storm 1.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7d67f8e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
> 
> Diff: https://reviews.apache.org/r/47332/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Re: Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-20 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47621/
---

(Updated May 20, 2016, 6:23 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated review with Test cases and debug statements.


Bugs: AMBARI-16784
https://issues.apache.org/jira/browse/AMBARI-16784


Repository: ambari


Description
---

- As hive2/hive-site.xml only contains the new + the changed props compared to 
hive/hive-site.xml, we merge hive/hive-site.xml and hive2/hive-site.xml and 
store it in hive2/hive-site.xml.
- Thus, as part of the merge, specifically for Hive2/hive-site.xml config 
'hive.exec.post.hooks', it gets the hook for Atlas from Hive1/hive-site.xml, if 
Atlas is installed. As Atlas is not supported by Hive2, we need to remove it.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 8e49cf0 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py ee93f9e 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 65ff8b3 

Diff: https://reviews.apache.org/r/47621/diff/


Testing (updated)
---

-  Tested removal of 'org.apache.atlas.hive.hook.HiveHook' value from 
'hive.exec.post.hooks'.
-  
-  Added Unit Test.

- Python UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-20 Thread Swapan Shridhar



> On May 20, 2016, 2:55 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py,
> >  line 97
> > 
> >
> > convert it to a function and remove it from the exclude list. Its seems 
> > odd in that list as this property is not being deleted.
> > 
> > You can add a unit test too - sample test attached to JIRA 16784

Updated Review as per comments.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47621/#review134085
---


On May 20, 2016, 6:23 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47621/
> ---
> 
> (Updated May 20, 2016, 6:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16784
> https://issues.apache.org/jira/browse/AMBARI-16784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - As hive2/hive-site.xml only contains the new + the changed props compared 
> to hive/hive-site.xml, we merge hive/hive-site.xml and hive2/hive-site.xml 
> and store it in hive2/hive-site.xml.
> - Thus, as part of the merge, specifically for Hive2/hive-site.xml config 
> 'hive.exec.post.hooks', it gets the hook for Atlas from Hive1/hive-site.xml, 
> if Atlas is installed. As Atlas is not supported by Hive2, we need to remove 
> it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  8e49cf0 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ee93f9e 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 65ff8b3 
> 
> Diff: https://reviews.apache.org/r/47621/diff/
> 
> 
> Testing
> ---
> 
> -  Tested removal of 'org.apache.atlas.hive.hook.HiveHook' value from 
> 'hive.exec.post.hooks'.
> -  
> -  Added Unit Test.
> 
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 47540: [Hive View]Unavailable Column Search should throw 'No Match' message

2016-05-20 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47540/
---

(Updated May 20, 2016, 6:21 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16738
https://issues.apache.org/jira/browse/AMBARI-16738


Repository: ambari


Description
---

Added a boolean variable for showing 'no columns match' alert.


Diffs (updated)
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js 
b76bca3 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
d2f6aaf 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-search-results.hbs
 007d9ca 

Diff: https://reviews.apache.org/r/47540/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-05-20 Thread Josh Elser


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/
---

(Updated May 20, 2016, 6:18 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.


Changes
---

Used StackId#compareTo(...) per Jonathan's recommendation.


Bugs: AMBARI-16171
https://issues.apache.org/jira/browse/AMBARI-16171


Repository: ambari


Description
---

The up-coming version of Phoenix will contain some new functionality to support 
Kerberos authentication of clients via SPNEGO with the Phoenix Query Server 
(PQS).

Presently, Ambari will configure PQS to use the hbase service keytab which will 
result in the SPNEGO authentication failing as the RFC requires that the 
"primary" component of the Kerberos principal for the server is "HTTP". Thus, 
we need to ensure that we switch PQS over to use the spnego.service.keytab as 
the keytab and "HTTP/_HOST@REALM" as the principal.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 2e857ed 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 41f538e 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json 
c9536f8 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 20fa50f 

Diff: https://reviews.apache.org/r/47428/diff/


Testing
---

Unit testing, verified upgrade from 2.2.2


Thanks,

Josh Elser

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-05-20 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47653/#review134175
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 20, 2016, 6:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47653/
> ---
> 
> (Updated May 20, 2016, 6:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16672
> https://issues.apache.org/jira/browse/AMBARI-16672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for OOzie service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  b3c6537 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  3060353 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
> 
> Diff: https://reviews.apache.org/r/47653/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> OOZIE fresh installation and service check
> 
> Hadoop QA added a comment - 4 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804552/AMBARI-16672.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-05-20 Thread Juanjo Marron


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47653/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16672
https://issues.apache.org/jira/browse/AMBARI-16672


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for OOzie service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
 b3c6537 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 3060353 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 75924c5 

Diff: https://reviews.apache.org/r/47653/diff/


Testing
---

Pass mvn clean test -DskipSurefireTests
OOZIE fresh installation and service check

Hadoop QA added a comment - 4 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12804552/AMBARI-16672.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names(for SmartSense)



> On Травень 18, 2016, 5:44 після полудня, Alejandro Fernandez wrote:
> > Which use cases were tested? E.g.,
> > 
> > 1. Add a host with name foo
> > 2. Attempt to readd a host with name FOO (should not allow this).
> > 3. Query the host components of a host with name Foo
> > 4. Delete a host with name fOO (should allow this)
> > 
> > For the deletion, can use two different APIs,
> > DELETE api/v1/clusters/$cluster_name/hosts/$name
> > DELETE api/v1/hosts/$name
> > 
> > I also remember that in MasterHostResolver.java we compared some hostnames, 
> > and it should be case-insensitive.
> 
> Vitalyi Brodetskyi wrote:
> Alejandro, the main goal of this jira was to make SmartSense work 
> correctly with ambari API. If you will take a look at description you will 
> see that i was asked to add "hostname lowercase" for API requests. For API 
> requests which contain hostname and API which has filter with hostname.
> 
> Alejandro Fernandez wrote:
> The Jira title implies that Ambari should support case-insensitive 
> hostnames in all cases. If this is only for SmartSense, then we should update 
> the Jira title accordingly and create another Jira to fix it for all 
> scenarios.

Agree. Changed jira title and now going to create jira for whole changes.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/#review133773
---


On Травень 20, 2016, 5:56 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47531/
> ---
> 
> (Updated Травень 20, 2016, 5:56 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari stores all hostnames in lower-case irrespective of the case in name 
> associated with the host. While this is OK for internal usage it causes 
> confusion to the users or the tools that look up hostname using standard 
> commands such as"hostname -f".
> The API should be modified to allow hostnames in case insensitive fashion. 
> E.g.
> api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
> calls that user filter where they specify hostnames should also allow case 
> insensitive comparison
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  3af90ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  9c864b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
>  90ad522 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
>  dfe8be7 
> 
> Diff: https://reviews.apache.org/r/47531/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names(for SmartSense)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/
---

(Updated Травень 20, 2016, 5:56 після полудня)


Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid Wagle.


Summary (updated)
-

Ambari APIs should allow using case insensitive host names(for SmartSense)


Repository: ambari


Description
---

Ambari stores all hostnames in lower-case irrespective of the case in name 
associated with the host. While this is OK for internal usage it causes 
confusion to the users or the tools that look up hostname using standard 
commands such as"hostname -f".
The API should be modified to allow hostnames in case insensitive fashion. E.g.
api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
calls that user filter where they specify hostnames should also allow case 
insensitive comparison


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
 3af90ba 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 9c864b6 
  
ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
 90ad522 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
 dfe8be7 

Diff: https://reviews.apache.org/r/47531/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names

2016-05-20 Thread Alejandro Fernandez



> On May 18, 2016, 5:44 p.m., Alejandro Fernandez wrote:
> > Which use cases were tested? E.g.,
> > 
> > 1. Add a host with name foo
> > 2. Attempt to readd a host with name FOO (should not allow this).
> > 3. Query the host components of a host with name Foo
> > 4. Delete a host with name fOO (should allow this)
> > 
> > For the deletion, can use two different APIs,
> > DELETE api/v1/clusters/$cluster_name/hosts/$name
> > DELETE api/v1/hosts/$name
> > 
> > I also remember that in MasterHostResolver.java we compared some hostnames, 
> > and it should be case-insensitive.
> 
> Vitalyi Brodetskyi wrote:
> Alejandro, the main goal of this jira was to make SmartSense work 
> correctly with ambari API. If you will take a look at description you will 
> see that i was asked to add "hostname lowercase" for API requests. For API 
> requests which contain hostname and API which has filter with hostname.

The Jira title implies that Ambari should support case-insensitive hostnames in 
all cases. If this is only for SmartSense, then we should update the Jira title 
accordingly and create another Jira to fix it for all scenarios.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/#review133773
---


On May 20, 2016, 3:27 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47531/
> ---
> 
> (Updated May 20, 2016, 3:27 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari stores all hostnames in lower-case irrespective of the case in name 
> associated with the host. While this is OK for internal usage it causes 
> confusion to the users or the tools that look up hostname using standard 
> commands such as"hostname -f".
> The API should be modified to allow hostnames in case insensitive fashion. 
> E.g.
> api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
> calls that user filter where they specify hostnames should also allow case 
> insensitive comparison
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  3af90ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  9c864b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
>  90ad522 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
>  dfe8be7 
> 
> Diff: https://reviews.apache.org/r/47531/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-05-20 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review134165
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (lines 2095 - 2101)


Could use StackId.compareTo() for this.


- Jonathan Hurley


On May 19, 2016, 10:06 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47428/
> ---
> 
> (Updated May 19, 2016, 10:06 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The up-coming version of Phoenix will contain some new functionality to 
> support Kerberos authentication of clients via SPNEGO with the Phoenix Query 
> Server (PQS).
> 
> Presently, Ambari will configure PQS to use the hbase service keytab which 
> will result in the SPNEGO authentication failing as the RFC requires that the 
> "primary" component of the Kerberos principal for the server is "HTTP". Thus, 
> we need to ensure that we switch PQS over to use the spnego.service.keytab as 
> the keytab and "HTTP/_HOST@REALM" as the principal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  2e857ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  41f538e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  c9536f8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  20fa50f 
> 
> Diff: https://reviews.apache.org/r/47428/diff/
> 
> 
> Testing
> ---
> 
> Unit testing, verified upgrade from 2.2.2
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/#review134164
---


Ship it!




Ship It!

- Dmytro Sen


On Май 20, 2016, 3:27 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47531/
> ---
> 
> (Updated Май 20, 2016, 3:27 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari stores all hostnames in lower-case irrespective of the case in name 
> associated with the host. While this is OK for internal usage it causes 
> confusion to the users or the tools that look up hostname using standard 
> commands such as"hostname -f".
> The API should be modified to allow hostnames in case insensitive fashion. 
> E.g.
> api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
> calls that user filter where they specify hostnames should also allow case 
> insensitive comparison
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  3af90ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  9c864b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
>  90ad522 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
>  dfe8be7 
> 
> Diff: https://reviews.apache.org/r/47531/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47651: Required empty config is present after Upgrade from 2.1.1 to 2.4.0.0 [HDFS: keyserver_port]


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47651/#review134162
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Травень 20, 2016, 4:56 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47651/
> ---
> 
> (Updated Травень 20, 2016, 4:56 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-16796
> https://issues.apache.org/jira/browse/AMBARI-16796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1) Install old version - 2.1.1 + try to enable AD sec.
> keyserver_port has empty value
> 2) Make ambari only Upgrade
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  729b577 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  20fa50f 
> 
> Diff: https://reviews.apache.org/r/47651/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 47651: Required empty config is present after Upgrade from 2.1.1 to 2.4.0.0 [HDFS: keyserver_port]


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47651/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-16796
https://issues.apache.org/jira/browse/AMBARI-16796


Repository: ambari


Description
---

STR:
1) Install old version - 2.1.1 + try to enable AD sec.
keyserver_port has empty value
2) Make ambari only Upgrade


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 729b577 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 20fa50f 

Diff: https://reviews.apache.org/r/47651/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names



> On Травень 18, 2016, 5:44 після полудня, Alejandro Fernandez wrote:
> > Which use cases were tested? E.g.,
> > 
> > 1. Add a host with name foo
> > 2. Attempt to readd a host with name FOO (should not allow this).
> > 3. Query the host components of a host with name Foo
> > 4. Delete a host with name fOO (should allow this)
> > 
> > For the deletion, can use two different APIs,
> > DELETE api/v1/clusters/$cluster_name/hosts/$name
> > DELETE api/v1/hosts/$name
> > 
> > I also remember that in MasterHostResolver.java we compared some hostnames, 
> > and it should be case-insensitive.

Alejandro, the main goal of this jira was to make SmartSense work correctly 
with ambari API. If you will take a look at description you will see that i was 
asked to add "hostname lowercase" for API requests. For API requests which 
contain hostname and API which has filter with hostname.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/#review133773
---


On Травень 20, 2016, 3:27 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47531/
> ---
> 
> (Updated Травень 20, 2016, 3:27 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari stores all hostnames in lower-case irrespective of the case in name 
> associated with the host. While this is OK for internal usage it causes 
> confusion to the users or the tools that look up hostname using standard 
> commands such as"hostname -f".
> The API should be modified to allow hostnames in case insensitive fashion. 
> E.g.
> api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
> calls that user filter where they specify hostnames should also allow case 
> insensitive comparison
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  3af90ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  9c864b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
>  90ad522 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
>  dfe8be7 
> 
> Diff: https://reviews.apache.org/r/47531/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Sandor Magyari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134151
---


Ship it!




Ship It!

- Sandor Magyari


On May 20, 2016, 8:01 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 20, 2016, 8:01 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names



> On Травень 19, 2016, 2:05 після полудня, Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java,
> >  lines 103-105
> > 
> >
> > What about any endpoint that takes host names embedded in json? Is that 
> > covered here?
> > 
> > A fundamental change like this requires several unit tests covering 
> > QueryParser and predicate processors.  Also add tests for the Request 
> > endpoint that take hostnames in the body (as opposed to the URL).

Nate. this code was added only for SmartSense needs. If you will take a look at 
description you will see that i was asked to add "hostname lowercase" for API 
requests. For API requests which contain hostname and API which has filter with 
hostname.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/#review133940
---


On Травень 20, 2016, 3:27 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47531/
> ---
> 
> (Updated Травень 20, 2016, 3:27 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari stores all hostnames in lower-case irrespective of the case in name 
> associated with the host. While this is OK for internal usage it causes 
> confusion to the users or the tools that look up hostname using standard 
> commands such as"hostname -f".
> The API should be modified to allow hostnames in case insensitive fashion. 
> E.g.
> api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
> calls that user filter where they specify hostnames should also allow case 
> insensitive comparison
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  3af90ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  9c864b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
>  90ad522 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
>  dfe8be7 
> 
> Diff: https://reviews.apache.org/r/47531/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/
---

(Updated Травень 20, 2016, 3:27 після полудня)


Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid Wagle.


Repository: ambari


Description
---

Ambari stores all hostnames in lower-case irrespective of the case in name 
associated with the host. While this is OK for internal usage it causes 
confusion to the users or the tools that look up hostname using standard 
commands such as"hostname -f".
The API should be modified to allow hostnames in case insensitive fashion. E.g.
api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
calls that user filter where they specify hostnames should also allow case 
insensitive comparison


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
 3af90ba 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 9c864b6 
  
ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
 90ad522 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java
 dfe8be7 

Diff: https://reviews.apache.org/r/47531/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Laszlo Puskas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134149
---


Ship it!




Ship It!

- Laszlo Puskas


On May 20, 2016, 8:01 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 20, 2016, 8:01 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134148
---


Ship it!




Ship It!

- Oliver Szabo


On May 20, 2016, 8:01 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 20, 2016, 8:01 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-05-20 Thread Josh Elser



> On May 20, 2016, 12:10 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  lines 1924-1938
> > 
> >
> > This is a bit rough on the eyes.  There's nothing wrong with 
> > shortcutting-when-null and really helps readability and indenting
> 
> Robert Levas wrote:
> I happen to like the explict checking for null.  What do you mean by 
> "shortcutting-when-null"?
> 
> Like this?
> 
> ```
> KerberosDescriptor kerberosDescriptor = new 
> KerberosDescriptorFactory().createInstance(data);
> KerberosServiceDescriptor serviceDescriptor = (kerberosDescriptor==null) 
> ? null : kerberosDescriptor.getService("HBASE");
> KerberosComponentDescriptor componentDescriptor = 
> (serviceDescriptor==null) ? null : 
> serviceDescriptor.getComponent("PHOENIX_QUERY_SERVER");
> ...
> ```

I was mostly following existing code-style in general that I've seen with 
UpgradeCatalog implementations. I'm happy to change it however you would prefer.


- Josh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review134136
---


On May 20, 2016, 2:06 a.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47428/
> ---
> 
> (Updated May 20, 2016, 2:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The up-coming version of Phoenix will contain some new functionality to 
> support Kerberos authentication of clients via SPNEGO with the Phoenix Query 
> Server (PQS).
> 
> Presently, Ambari will configure PQS to use the hbase service keytab which 
> will result in the SPNEGO authentication failing as the RFC requires that the 
> "primary" component of the Kerberos principal for the server is "HTTP". Thus, 
> we need to ensure that we switch PQS over to use the spnego.service.keytab as 
> the keytab and "HTTP/_HOST@REALM" as the principal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  2e857ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  41f538e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  c9536f8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  20fa50f 
> 
> Diff: https://reviews.apache.org/r/47428/diff/
> 
> 
> Testing
> ---
> 
> Unit testing, verified upgrade from 2.2.2
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 47644: All created views disappear after upgrade to 2.4.0.0

2016-05-20 Thread Ashwin Rajeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47644/#review134146
---


Ship it!




Ship It!

- Ashwin Rajeev


On May 20, 2016, 10:15 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47644/
> ---
> 
> (Updated May 20, 2016, 10:15 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16791
> https://issues.apache.org/jira/browse/AMBARI-16791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In permission_roleauthorization added VIEW.USE permission for administrator.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  53a22c8 
> 
> Diff: https://reviews.apache.org/r/47644/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47631: 'Configure Ambari Identity' fails when enabling Kerberos on non-root Ambari server


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/
---

(Updated May 20, 2016, 10:09 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and 
Sumit Mohanty.


Bugs: AMBARI-16787
https://issues.apache.org/jira/browse/AMBARI-16787


Repository: ambari


Description
---

Configure Ambari Identity phase of Enable Kerberos Wizard fails since Ambari 
does not have permission perform some root-level file system tasks like chown. 

STR:
1. Install Ambari, executing as non-root
2. Create cluster (Zookeeper-only is fine)
3. Enable Kerberos (any KDC is fine)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 15bd2d9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
 bbc7246 
  
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
 b5d2b70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json c5ebe20 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
 fc27eda 

Diff: https://reviews.apache.org/r/47631/diff/


Testing
---

Manually tested in cluster using UI and using Blueprints where Ambari was 
executed as root and non-root users.

# Local test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:12:58.862s
[INFO] Finished at: Thu May 19 23:23:12 EDT 2016
[INFO] Final Memory: 59M/1410M
[INFO] 


# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 47631: 'Configure Ambari Identity' fails when enabling Kerberos on non-root Ambari server


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/
---

(Updated May 20, 2016, 10:10 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and 
Sumit Mohanty.


Bugs: AMBARI-16787
https://issues.apache.org/jira/browse/AMBARI-16787


Repository: ambari


Description
---

Configure Ambari Identity phase of Enable Kerberos Wizard fails since Ambari 
does not have permission perform some root-level file system tasks like chown. 

STR:
1. Install Ambari, executing as non-root
2. Create cluster (Zookeeper-only is fine)
3. Enable Kerberos (any KDC is fine)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 15bd2d9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
 bbc7246 
  
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
 b5d2b70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json c5ebe20 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
 fc27eda 

Diff: https://reviews.apache.org/r/47631/diff/


Testing
---

Manually tested in cluster using UI and using Blueprints where Ambari was 
executed as root and non-root users.

# Local test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:12:58.862s
[INFO] Finished at: Thu May 19 23:23:12 EDT 2016
[INFO] Final Memory: 59M/1410M
[INFO] 


# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 47631: 'Configure Ambari Identity' fails when enabling Kerberos on non-root Ambari server



> On May 20, 2016, 7:57 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java,
> >  lines 207-209
> > 
> >
> > Should this be !WINDOWS?  -p works for Mac too
> 
> Robert Levas wrote:
> Good call.. I assumed we only have Linux and Windows options, but looking 
> at the code, we have Mac and Unix-like options...

Oh I see UNIX_LIKE now too - I guess that'll work too :)


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/#review134135
---


On May 19, 2016, 11:32 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47631/
> ---
> 
> (Updated May 19, 2016, 11:32 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16787
> https://issues.apache.org/jira/browse/AMBARI-16787
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configure Ambari Identity phase of Enable Kerberos Wizard fails since Ambari 
> does not have permission perform some root-level file system tasks like 
> chown. 
> 
> STR:
> 1. Install Ambari, executing as non-root
> 2. Create cluster (Zookeeper-only is fine)
> 3. Enable Kerberos (any KDC is fine)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  15bd2d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
>  bbc7246 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  b5d2b70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json c5ebe20 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  fc27eda 
> 
> Diff: https://reviews.apache.org/r/47631/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in cluster using UI and using Blueprints where Ambari was 
> executed as root and non-root users.
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:12:58.862s
> [INFO] Finished at: Thu May 19 23:23:12 EDT 2016
> [INFO] Final Memory: 59M/1410M
> [INFO] 
> 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration



> On May 20, 2016, 8:10 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 1967
> > 
> >
> > Is "/spnego" always correct?  Should/can this be from  
> > origIdentityDescriptor?

This is correct since we are building a reference entry to the identitiy named 
"/spnego".


> On May 20, 2016, 8:10 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  lines 1924-1938
> > 
> >
> > This is a bit rough on the eyes.  There's nothing wrong with 
> > shortcutting-when-null and really helps readability and indenting

I happen to like the explict checking for null.  What do you mean by 
"shortcutting-when-null"?

Like this?

```
KerberosDescriptor kerberosDescriptor = new 
KerberosDescriptorFactory().createInstance(data);
KerberosServiceDescriptor serviceDescriptor = (kerberosDescriptor==null) ? null 
: kerberosDescriptor.getService("HBASE");
KerberosComponentDescriptor componentDescriptor = (serviceDescriptor==null) ? 
null : serviceDescriptor.getComponent("PHOENIX_QUERY_SERVER");
...
```


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review134136
---


On May 19, 2016, 10:06 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47428/
> ---
> 
> (Updated May 19, 2016, 10:06 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The up-coming version of Phoenix will contain some new functionality to 
> support Kerberos authentication of clients via SPNEGO with the Phoenix Query 
> Server (PQS).
> 
> Presently, Ambari will configure PQS to use the hbase service keytab which 
> will result in the SPNEGO authentication failing as the RFC requires that the 
> "primary" component of the Kerberos principal for the server is "HTTP". Thus, 
> we need to ensure that we switch PQS over to use the spnego.service.keytab as 
> the keytab and "HTTP/_HOST@REALM" as the principal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  2e857ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  41f538e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  c9536f8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  20fa50f 
> 
> Diff: https://reviews.apache.org/r/47428/diff/
> 
> 
> Testing
> ---
> 
> Unit testing, verified upgrade from 2.2.2
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 47631: 'Configure Ambari Identity' fails when enabling Kerberos on non-root Ambari server



> On May 20, 2016, 7:57 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java,
> >  line 213
> > 
> >
> > just runCommand?

Its interesting that IntellJ didn't flag this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/#review134135
---


On May 19, 2016, 11:32 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47631/
> ---
> 
> (Updated May 19, 2016, 11:32 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16787
> https://issues.apache.org/jira/browse/AMBARI-16787
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configure Ambari Identity phase of Enable Kerberos Wizard fails since Ambari 
> does not have permission perform some root-level file system tasks like 
> chown. 
> 
> STR:
> 1. Install Ambari, executing as non-root
> 2. Create cluster (Zookeeper-only is fine)
> 3. Enable Kerberos (any KDC is fine)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  15bd2d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
>  bbc7246 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  b5d2b70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json c5ebe20 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  fc27eda 
> 
> Diff: https://reviews.apache.org/r/47631/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in cluster using UI and using Blueprints where Ambari was 
> executed as root and non-root users.
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:12:58.862s
> [INFO] Finished at: Thu May 19 23:23:12 EDT 2016
> [INFO] Final Memory: 59M/1410M
> [INFO] 
> 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47631: 'Configure Ambari Identity' fails when enabling Kerberos on non-root Ambari server



> On May 20, 2016, 7:57 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java,
> >  lines 207-209
> > 
> >
> > Should this be !WINDOWS?  -p works for Mac too

Good call.. I assumed we only have Linux and Windows options, but looking at 
the code, we have Mac and Unix-like options...


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/#review134135
---


On May 19, 2016, 11:32 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47631/
> ---
> 
> (Updated May 19, 2016, 11:32 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16787
> https://issues.apache.org/jira/browse/AMBARI-16787
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configure Ambari Identity phase of Enable Kerberos Wizard fails since Ambari 
> does not have permission perform some root-level file system tasks like 
> chown. 
> 
> STR:
> 1. Install Ambari, executing as non-root
> 2. Create cluster (Zookeeper-only is fine)
> 3. Enable Kerberos (any KDC is fine)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  15bd2d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
>  bbc7246 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  b5d2b70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json c5ebe20 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  fc27eda 
> 
> Diff: https://reviews.apache.org/r/47631/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in cluster using UI and using Blueprints where Ambari was 
> executed as root and non-root users.
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:12:58.862s
> [INFO] Finished at: Thu May 19 23:23:12 EDT 2016
> [INFO] Final Memory: 59M/1410M
> [INFO] 
> 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review134136
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (lines 1924 - 1938)


This is a bit rough on the eyes.  There's nothing wrong with 
shortcutting-when-null and really helps readability and indenting



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 1967)


Is "/spnego" always correct?  Should/can this be from  
origIdentityDescriptor?



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (lines 2112 - 2117)


Shortcutting for ease-of-reading


- Nate Cole


On May 19, 2016, 10:06 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47428/
> ---
> 
> (Updated May 19, 2016, 10:06 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The up-coming version of Phoenix will contain some new functionality to 
> support Kerberos authentication of clients via SPNEGO with the Phoenix Query 
> Server (PQS).
> 
> Presently, Ambari will configure PQS to use the hbase service keytab which 
> will result in the SPNEGO authentication failing as the RFC requires that the 
> "primary" component of the Kerberos principal for the server is "HTTP". Thus, 
> we need to ensure that we switch PQS over to use the spnego.service.keytab as 
> the keytab and "HTTP/_HOST@REALM" as the principal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  2e857ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  41f538e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  c9536f8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  20fa50f 
> 
> Diff: https://reviews.apache.org/r/47428/diff/
> 
> 
> Testing
> ---
> 
> Unit testing, verified upgrade from 2.2.2
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 47631: 'Configure Ambari Identity' fails when enabling Kerberos on non-root Ambari server


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/#review134135
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
 (lines 207 - 209)


Should this be !WINDOWS?  -p works for Mac too



ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
 (line 213)


just runCommand?


- Nate Cole


On May 19, 2016, 11:32 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47631/
> ---
> 
> (Updated May 19, 2016, 11:32 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16787
> https://issues.apache.org/jira/browse/AMBARI-16787
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configure Ambari Identity phase of Enable Kerberos Wizard fails since Ambari 
> does not have permission perform some root-level file system tasks like 
> chown. 
> 
> STR:
> 1. Install Ambari, executing as non-root
> 2. Create cluster (Zookeeper-only is fine)
> 3. Enable Kerberos (any KDC is fine)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  15bd2d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
>  bbc7246 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  b5d2b70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json c5ebe20 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  fc27eda 
> 
> Diff: https://reviews.apache.org/r/47631/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in cluster using UI and using Blueprints where Ambari was 
> executed as root and non-root users.
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:12:58.862s
> [INFO] Finished at: Thu May 19 23:23:12 EDT 2016
> [INFO] Final Memory: 59M/1410M
> [INFO] 
> 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47595/
---

(Updated Май 20, 2016, 11:47 д.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-16766
https://issues.apache.org/jira/browse/AMBARI-16766


Repository: ambari


Description
---

Check if there is performance boost after replacing insert operations with bulk 
loading. 
If yes, implement and provide switch property for enabling/disabling this 
feature.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 974f951 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricsCacheCommitterThread.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 52ab083 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 683e5d4 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
 290a98a 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java
 06c71c5 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 a7fd9c8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 8f369f7 

Diff: https://reviews.apache.org/r/47595/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase



> On Май 20, 2016, 4:21 д.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml,
> >  line 557
> > 
> >
> > Any reason for chosing 3 seconds vs 5 ?

No, but it's better to have delay between receiving metrics and committing as 
small as possible. For small clusters it doesn't matter, for large - metrics 
will be committed more frequently than 3-5 seconds, right after the cache is 
filled up.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47595/#review134093
---


On Май 19, 2016, 2:43 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47595/
> ---
> 
> (Updated Май 19, 2016, 2:43 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-16766
> https://issues.apache.org/jira/browse/AMBARI-16766
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check if there is performance boost after replacing insert operations with 
> bulk loading. 
> If yes, implement and provide switch property for enabling/disabling this 
> feature.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  974f951 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricsCacheCommitter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  52ab083 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  683e5d4 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
>  290a98a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java
>  06c71c5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  a7fd9c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  8f369f7 
> 
> Diff: https://reviews.apache.org/r/47595/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.

2016-05-20 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47527/#review134133
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 20, 2016, 6:58 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47527/
> ---
> 
> (Updated May 20, 2016, 6:58 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16418
> https://issues.apache.org/jira/browse/AMBARI-16418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : datatype of a column was decided based on maximum number of 
> occurence of a datatype, even if other values do not have same datatype.
> 
> In this patch : even if 1 of the value in the preview rows do not conform to 
> a datatype then it is rejected.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  b6b000a 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java
>  7eae679 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java
>  6056e73 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseUtils.java
>  a17346f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
>  1644c13 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java
>  56cff58 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/json/JSONParser.java
>  1d61798 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/xml/XMLParser.java
>  74bf272 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/CSVParserTest.java
>  fb4c4da 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java
>  99f758b 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java
>  79166bb 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java
>  4199257 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/JsonParserTest.java
>  38ed225 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/XMLParserTest.java
>  d048a62 
> 
> Diff: https://reviews.apache.org/r/47527/diff/
> 
> 
> Testing
> ---
> 
> extra test cases added for this algorithm of detection of datatype. existing 
> test cases changed to conform new algorithm.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47626: Atlas HA configuration Property Changed

2016-05-20 Thread Erik Bergenholtz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47626/#review134132
---


Ship it!




Ship It!

- Erik Bergenholtz


On May 20, 2016, 10:16 a.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47626/
> ---
> 
> (Updated May 20, 2016, 10:16 a.m.)
> 
> 
> Review request for Ambari, Erik Bergenholtz and John Speidel.
> 
> 
> Bugs: AMBARI-16781
> https://issues.apache.org/jira/browse/AMBARI-16781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Atlas HA properties to designate ha hosts has changed from:
> atlas.server.host.id to atlas.server.address.id this causes Atlas to not be 
> able to start in HA mode. The following changes need to be made:
> 
> - resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 
> - 
> resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
> 
> Also, fix new values of renamed lineage configs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  21bc0c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  53c1369 
> 
> Diff: https://reviews.apache.org/r/47626/diff/
> 
> 
> Testing
> ---
> 
> manual check Atlas HA - verify configs
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47599: Add validation for alert name edit

2016-05-20 Thread Sangeeta Ravindran



> On May 19, 2016, 4:08 p.m., Alexandr Antonenko wrote:
> > Ship It!

Hi Alexander, can you please help push the fix. Thank you.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47599/#review133961
---


On May 19, 2016, 4:02 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47599/
> ---
> 
> (Updated May 19, 2016, 4:02 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-16737
> https://issues.apache.org/jira/browse/AMBARI-16737
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, when you edit alert names, on the Ambari dashboard, there is no 
> validation and you can enter characters such as \, < etc.
> You can aslo enter more than 255 characters, the UI shows no indication of 
> error and accepts more than 255 characters. However, an exception is thrown 
> on the server side because the database column only allows 255 characters. 
> The UI should restrict this. The value in the UI gets reset to what it was 
> before you added more than 255 characters since the update failed.
>  
> Added UI validation to the alert name field.
> Also set the maxLength to 255 characters.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 74f918d 
>   ambari-web/app/styles/alerts.less 50246e6 
>   ambari-web/app/templates/main/alerts/definition_details.hbs cda1193 
>   ambari-web/app/utils/validator.js 2906749 
>   ambari-web/app/views/main/alerts/definition_details_view.js 656021c 
>   ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b 
> 
> Diff: https://reviews.apache.org/r/47599/diff/
> 
> 
> Testing
> ---
> 
> Added new test case in definition_details_view_test.js
> Also, tested manually.
> Ran ambari-web mvn test without errors.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47626: Atlas HA configuration Property Changed

2016-05-20 Thread Tom Beerbower


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47626/
---

(Updated May 20, 2016, 10:16 a.m.)


Review request for Ambari, Erik Bergenholtz and John Speidel.


Changes
---

updated diff


Bugs: AMBARI-16781
https://issues.apache.org/jira/browse/AMBARI-16781


Repository: ambari


Description (updated)
---

The Atlas HA properties to designate ha hosts has changed from:
atlas.server.host.id to atlas.server.address.id this causes Atlas to not be 
able to start in HA mode. The following changes need to be made:

- resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 
- 
resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml

Also, fix new values of renamed lineage configs.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 21bc0c5 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 53c1369 

Diff: https://reviews.apache.org/r/47626/diff/


Testing
---

manual check Atlas HA - verify configs

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 47525: Hive View : Upload table still shows file name after the upload is done

2016-05-20 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47525/
---

(Updated May 20, 2016, 10:16 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
---

removed the console.log statement.


Bugs: AMBARI-16726
https://issues.apache.org/jira/browse/AMBARI-16726


Repository: ambari


Description
---

Earlier : The UI does not get cleared properly after the upload. It still shows 
file name.

In this patch : the UI will no longer show the old file name if the upload is 
successfull.


Diffs (updated)
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js 
1cd05ae 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 f08aa18 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 0fffed4 

Diff: https://reviews.apache.org/r/47525/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Review Request 47644: All created views disappear after upgrade to 2.4.0.0

2016-05-20 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47644/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16791
https://issues.apache.org/jira/browse/AMBARI-16791


Repository: ambari


Description
---

In permission_roleauthorization added VIEW.USE permission for administrator.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 53a22c8 

Diff: https://reviews.apache.org/r/47644/diff/


Testing
---

Manually tested.


Thanks,

Gaurav Nagar

Review Request 47643: Capacity Scheduler View - Edit and validate queue name

2016-05-20 Thread Akhil PB


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47643/
---

Review request for Ambari and Sreenath Somarajapuram.


Bugs: AMBARI-16792
https://issues.apache.org/jira/browse/AMBARI-16792


Repository: ambari


Description
---

Capacity Scheduler View - Edit and validate queue name


Diffs
-

  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 02062a6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 69be18c 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 89d0e89 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 a60d39d 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 d57b2ba 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 c5c910a 

Diff: https://reviews.apache.org/r/47643/diff/


Testing
---

Manual Unit Testing


Thanks,

Akhil PB

Re: Review Request 47604: View URLs: UX edits #4

2016-05-20 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/#review134126
---


Ship it!




Ship It!

- Nitiraj Rathore


On May 20, 2016, 6:57 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47604/
> ---
> 
> (Updated May 20, 2016, 6:57 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16771
> https://issues.apache.org/jira/browse/AMBARI-16771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor UX changes for short URL
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  2b1fb3b 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 3ed2687 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> 3a69a50 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  2481d59 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
>  e0b8a4e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
> c98ec3e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 
> 9e0ef4c 
> 
> Diff: https://reviews.apache.org/r/47604/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134122
---


Ship it!




Ship It!

- Sebastian Toader


On May 20, 2016, 10:01 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 20, 2016, 10:01 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Review Request 47642: Add HAWQ Standby wizard should recommend HAWQSTANDBY correctly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47642/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.

Bugs: AMBARI-16790
https://issues.apache.org/jira/browse/AMBARI-16790

Repository: ambari

Description
---

On assign masters page of Add HAWQ Standby wizard, a best effort should be made
such that HAWQSTANDBY is not co-located with HAWQMASTER or AMBARI_SERVER.

Diffs
-

ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
0590604
ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 905d455

Diff: https://reviews.apache.org/r/47642/diff/

Testing
---

Manually tested.

Added unit tests:
test_createComponentLayoutRecommendations_hawq_1_Host
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_createComponentLayoutRecommendations_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when
HAWQ has already been installed ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard,
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_hawqsegment_cluster_install
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard,
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_no_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF does not get recommended during Add Service Wizard, when PXF has
already been installed ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Add Service Wizard, when PXF is
selected for installation ... ok
test_createComponentLayoutRecommendations_pxf_cluster_install
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Cluster Install Wizard, when
PXF is selected for installation ... ok
test_getComponentLayoutValidations_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test layout validations for HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode
(test_stack_advisor.TestHDP23StackAdvisor)
Test validation warning for HAWQ segment not colocated with DATANODE ... ok
test_getComponentLayoutValidations_nohawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE ... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE
... ok
test_getComponentLayoutValidations_sparkts_no_hive
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is not installed ... ok
test_getComponentLayoutValidations_sparkts_with_hive
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is installed ... ok
test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendFalconConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHBASEConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHiveConfigurations_with_atlas
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendKAFKAConfigurations

Re: Review Request 47639: Remove unused print from zeppelin service check

2016-05-20 Thread Renjith Kamath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47639/
---

(Updated May 20, 2016, 7:06 a.m.)


Review request for Ambari and Pallav Kulshreshtha.


Bugs: AMBARI-16789
https://issues.apache.org/jira/browse/AMBARI-16789


Repository: ambari


Description
---

removed unused print


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py
 2a88a2c 

Diff: https://reviews.apache.org/r/47639/diff/


Testing
---

manually tested


Thanks,

Renjith Kamath

Re: Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.

2016-05-20 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47527/
---

(Updated May 20, 2016, 6:58 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
---

implemented ashwins review comments.


Bugs: AMBARI-16418
https://issues.apache.org/jira/browse/AMBARI-16418


Repository: ambari


Description
---

Earlier : datatype of a column was decided based on maximum number of occurence 
of a datatype, even if other values do not have same datatype.

In this patch : even if 1 of the value in the preview rows do not conform to a 
datatype then it is rejected.


Diffs (updated)
-

  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
 b6b000a 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java
 7eae679 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java
 6056e73 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseUtils.java
 a17346f 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
 1644c13 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java
 56cff58 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/json/JSONParser.java
 1d61798 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/xml/XMLParser.java
 74bf272 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/CSVParserTest.java
 fb4c4da 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java
 99f758b 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java
 79166bb 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java
 4199257 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/JsonParserTest.java
 38ed225 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/XMLParserTest.java
 d048a62 

Diff: https://reviews.apache.org/r/47527/diff/


Testing
---

extra test cases added for this algorithm of detection of datatype. existing 
test cases changed to conform new algorithm.


Thanks,

Nitiraj Rathore

Re: Review Request 47619: clean up import * for MAHOUT service scripts in common-services