Re: Review Request 48081: Prefix command execution log lines in agent log

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48081/#review135767
---


Ship it!




Ship It!

- Sandor Magyari


On May 31, 2016, 7:29 p.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48081/
> ---
> 
> (Updated May 31, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16958
> https://issues.apache.org/jira/browse/AMBARI-16958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If parallel execution is enabled, log lines of different components may 
> interfere, especially if they are split in more lines, a prefix for each log 
> containing component ROLE, task ID would be useful to be able to co-relate 
> these.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 5c9189c 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 0fd3bff 
> 
> Diff: https://reviews.apache.org/r/48081/diff/
> 
> 
> Testing
> ---
> 
> Test run manually and also via hadoop-qa
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 47964: clean up import * for ZOOKEEPER service

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47964/#review135757
---


Ship it!




Ship It!

- Jayush Luniya


On May 27, 2016, 4:36 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47964/
> ---
> 
> (Updated May 27, 2016, 4:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16850
> https://issues.apache.org/jira/browse/AMBARI-16850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for ZOOKEEPER service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/params_windows.py
>  c36e152 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/service_check.py
>  622a5eb 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper.py
>  e0ba54b 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_client.py
>  de4d6e1 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_service.py
>  9f943d7 
> 
> Diff: https://reviews.apache.org/r/47964/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> ZOOKEEPER fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806418/AMBARI-16850.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7006//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7006//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47963: clean up import * for YARN service

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/#review135756
---


Ship it!




Ship It!

- Jayush Luniya


On May 27, 2016, 4:33 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47963/
> ---
> 
> (Updated May 27, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16849
> https://issues.apache.org/jira/browse/AMBARI-16849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for YARN service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  4ec6aa7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  34c683a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py
>  44015bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
>  13172ee 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  3ea3d75 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  7be49d5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py
>  1c886f9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
>  0f8ce73 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  b1179b9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  792a681 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  0e2c519 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  4d65a40 
> 
> Diff: https://reviews.apache.org/r/47963/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> YARN fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806423/AMBARI-16849.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//console
> This message is automatically generated.
> Reply
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47962: clean up import * for STORM, TEZ and ZEPPELIN services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47962/#review135755
---


Ship it!




Ship It!

- Jayush Luniya


On May 27, 2016, 4:28 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47962/
> ---
> 
> (Updated May 27, 2016, 4:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16848
> https://issues.apache.org/jira/browse/AMBARI-16848
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for PIG service 
> scripts in common-servicesPython code at at common-services level used 
> generic imports form resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for STORM, TEZ and 
> ZEPPELIN service scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_windows.py
>  88e6246 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
>  198674d 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py
>  5dfdcad 
> 
> Diff: https://reviews.apache.org/r/47962/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> STORM, TEZ and ZEPPELIN  fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806417/AMBARI-16848.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7000//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7000//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47923/#review135754
---



Patch doesnt apply cleanly. Can you rebase the patch?

- Jayush Luniya


On May 26, 2016, 11:04 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47923/
> ---
> 
> (Updated May 26, 2016, 11:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16797
> https://issues.apache.org/jira/browse/AMBARI-16797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SPARK service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py
>  bccd714 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py
>  eca8534 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
>  3838061 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py
>  9311454 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
> 
> Diff: https://reviews.apache.org/r/47923/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> PIG fresh installation and service check
> 
> Hadoop QA added a comment - 1 hour ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47934: clean up import * for SLIDER service scripts in common-services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47934/#review135752
---


Ship it!




Ship It!

- Jayush Luniya


On May 27, 2016, 12:20 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47934/
> ---
> 
> (Updated May 27, 2016, 12:20 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16744
> https://issues.apache.org/jira/browse/AMBARI-16744
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SLIDER service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_windows.py
>  fdb8160 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py
>  91e4959 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py
>  8d80700 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
>  13f7848 
> 
> Diff: https://reviews.apache.org/r/47934/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> SLIDER fresh installation and service check
> 
> Hadoop QA added a comment - 18 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12805250/AMBARI-16744.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6988//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6988//console
> This message is automatically generated.
> Reply
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47653/#review135750
---



Patch doesnt apply cleanly. Can you rebase the patch and resolve conflicts?

- Jayush Luniya


On May 20, 2016, 6:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47653/
> ---
> 
> (Updated May 20, 2016, 6:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16672
> https://issues.apache.org/jira/browse/AMBARI-16672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for OOzie service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  b3c6537 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  3060353 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
> 
> Diff: https://reviews.apache.org/r/47653/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> OOZIE fresh installation and service check
> 
> Hadoop QA added a comment - 4 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804552/AMBARI-16672.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47922: clean up import * for KNOX service scripts in common-services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47922/#review135749
---


Ship it!




Ship It!

- Jayush Luniya


On May 26, 2016, 10:59 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47922/
> ---
> 
> (Updated May 26, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16669
> https://issues.apache.org/jira/browse/AMBARI-16669
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for KNOX service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
>  fbd879f 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  1917369 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py
>  dee0154 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  5d454de 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
>  e7a3747 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py
>  5e9b89e 
> 
> Diff: https://reviews.apache.org/r/47922/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> KNOX fresh installation and service check
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12805363/AMBARI-16669.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6985//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6985//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 48106: HS2 Interactive not shown on summary page after enabling HS Interactive (Blueprint deployment)

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48106/#review135737
---


Ship it!




Ship It!

- Yusaku Sako


On June 1, 2016, 12:59 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48106/
> ---
> 
> (Updated June 1, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16975
> https://issues.apache.org/jira/browse/AMBARI-16975
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deploy cluster using Blueprint with Hive and existing mysql
> Enable HS interactive
> Verify on summary page HS interactive is present
> 
> Actual: HSInteractive was not present on summary page.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 6df3efe 
> 
> Diff: https://reviews.apache.org/r/48106/diff/
> 
> 
> Testing
> ---
> 
> Verified the patch to fix issue manually
> ambari-web unit tests passes successfully:
> 28447 tests complete (29 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 48106: HS2 Interactive not shown on summary page after enabling HS Interactive (Blueprint deployment)

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48106/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-16975
https://issues.apache.org/jira/browse/AMBARI-16975


Repository: ambari


Description
---

Deploy cluster using Blueprint with Hive and existing mysql
Enable HS interactive
Verify on summary page HS interactive is present

Actual: HSInteractive was not present on summary page.


Diffs
-

  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
6df3efe 

Diff: https://reviews.apache.org/r/48106/diff/


Testing
---

Verified the patch to fix issue manually
ambari-web unit tests passes successfully:
28447 tests complete (29 seconds)
154 tests pending


Thanks,

Jaimin Jetly

Review Request 48105: AMBARI-16977 VDF: couple UI bugs in Install Wiz

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48105/
---

Review request for Ambari, Jaimin Jetly, Oleg Nechiporenko, Richard Zang, 
Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-16977
https://issues.apache.org/jira/browse/AMBARI-16977


Repository: ambari


Description
---

Fix bugs in the case that public repo is unavailable.


Diffs
-

  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css a8539e8 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 6134535 
  ambari-web/app/controllers/wizard/step1_controller.js b648b82 
  ambari-web/app/messages.js 8bea8e8 
  ambari-web/app/styles/application.less 8a76dfb 
  ambari-web/app/templates/wizard/step1.hbs e076d66 
  ambari-web/test/controllers/wizard/step1_test.js 01344cb 

Diff: https://reviews.apache.org/r/48105/diff/


Testing
---

ambari-web:
28447 tests complete (24 seconds)
154 tests pending
ambari-admin:
Executed 71 of 71 SUCCESS (0.113 secs / 0.361 secs)
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 47984: Make storm.topology.submission.notifier.plugin.class property optional

[Srimanth Gunturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47984/#review135731
---


Ship it!




Ship It!

- Srimanth Gunturi


On May 28, 2016, 5:15 a.m., Sivaguru Chendamaraikannan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47984/
> ---
> 
> (Updated May 28, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Tom Beerbower.
> 
> 
> Bugs: AMBARI-16915
> https://issues.apache.org/jira/browse/AMBARI-16915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The commit, 
> https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a
>  which accidentally made the storm.topology.submission.notifier.plugin 
> property mandatory. If the storm defaults yaml config does not set the 
> property a " " value is set for the property. This causes storm startup to 
> fail with a Class Not Found exception when starting with Ambari. This change 
> fixes the stack advisor to not set the property when no value is specified 
> for it through command line or storm defaults.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 79314f5 
> 
> Diff: https://reviews.apache.org/r/47984/diff/
> 
> 
> Testing
> ---
> 
> mvn test
> 
> 
> Thanks,
> 
> Sivaguru Chendamaraikannan
> 
>

Re: Review Request 47884: Ambari install failure due to zeppelin service install bug

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47884/#review135703
---



Pushed to trunk, commit bc11f5f12e639fd76305b6d73cf6a1b0dd93faaf
branch-2.4, commit 2ed744dbb2d863c86c73ce51cfa6d9d1d2ba6642

- Alejandro Fernandez


On May 27, 2016, 4:03 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47884/
> ---
> 
> (Updated May 27, 2016, 4:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16893
> https://issues.apache.org/jira/browse/AMBARI-16893
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Service install fails on CentOS 6.6 due to zeppelin permission bug. Only 
> reproducible on 6.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  9cd1b1d 
> 
> Diff: https://reviews.apache.org/r/47884/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS 6.6 and 6.4
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43126/#review135701
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 31, 2016, 8:32 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43126/
> ---
> 
> (Updated May 31, 2016, 8:32 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16692
> https://issues.apache.org/jira/browse/AMBARI-16692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RCA Database tables is not used anymore. This older, un-necessary data causes 
> many Ambari DB queries to return more slowly than necessary. If the database 
> gets large enough, it can have significant impact on the way ambari-server 
> functions.
> The Ambari Server upgrade process should detect the presence of these older, 
> deprecated tables, and automate the process of cleaning up this data.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  d4272ba3760d5e5e0100f104159565bc28df02e5 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> 31dd8f23e4410da7ce65d7c746fb6eb740ee8536 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> 3c4f1caa5df407b1e4735238cd330db44f019271 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> f31af161b02fc44c398aa1371b639588b6c19c51 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> d1147b7d956c65992e78e2daacd8b94fab4fc082 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 5a7a6a58978d347a8d3d68813e68866e489ce9b1 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-DROP.sql 
> a5380433131038abd15f1df05db8750e5e64ae0c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 2dba3b70e1669bce368109ac89344d540640167d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> e769e5bd11230d8543ed82f80d4bb4be810b9385 
>   ambari-server/src/main/resources/AmbariRCA-DML-Oracle-CLEANUP.sql 
> 1f0f3c2b07a7d60be7c851b27dcde1777e5caa1f 
>   ambari-server/src/main/resources/AmbariRCA-DML-Postgres-CLEANUP.sql 
> 3f07096ddf5e27b13ab0c8cd9dcc9e91ad500bee 
>   
> ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Oracle-UPGRADE.sql 
> f4027683bc5a8fc7ba7973d6270fc5ff3c9a4d0f 
>   
> ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Postgres-UPGRADE.sql
>  d9a7a758ab2a87d8d1ce8c8544926f7bb2a241e7 
> 
> Diff: https://reviews.apache.org/r/43126/diff/
> 
> 
> Testing
> ---
> 
> manual testing
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 48098: Service config page is broken on kerberized cluster

[Mahadev Konar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48098/#review135696
---


Ship it!




Ship It!

- Mahadev Konar


On May 31, 2016, 10:26 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48098/
> ---
> 
> (Updated May 31, 2016, 10:26 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-16974
> https://issues.apache.org/jira/browse/AMBARI-16974
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This happens due to JS error: referencing to a string that is not defined
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/config.js 00e6abc 
> 
> Diff: https://reviews.apache.org/r/48098/diff/
> 
> 
> Testing
> ---
> 
> Verified manually that the patch fixes the issue:
> Verified that all ambari-web unit tests passes with this patch. 
> 28447 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 48098: Service config page is broken on kerberized cluster

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48098/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku 
Sako.


Bugs: AMBARI-16974
https://issues.apache.org/jira/browse/AMBARI-16974


Repository: ambari


Description
---

This happens due to JS error: referencing to a string that is not defined


Diffs
-

  ambari-web/app/utils/config.js 00e6abc 

Diff: https://reviews.apache.org/r/48098/diff/


Testing
---

Verified manually that the patch fixes the issue:
Verified that all ambari-web unit tests passes with this patch. 
28447 tests complete (28 seconds)
154 tests pending


Thanks,

Jaimin Jetly

Review Request 48096: AMBARI-16935: Retry and recover from component install failures

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48096/
---

Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and Sid 
Wagle.


Bugs: AMBARI-16935
https://issues.apache.org/jira/browse/AMBARI-16935


Repository: ambari


Description
---

AMBARI-16935: Retry and recover from component install failures

** Issue **

There are multiple instances where components end up in INSTALL_FAILED state 
during cluster setup. Ambari does not retry or recover from INSTALL_FAILED 
state. 

Ambari should retry and recover from installation failures.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 
4a843d840dafd96023ead8b929fef33efcb9fa41 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 
87d9483c634026897629396bb48ec0cbabfcfae6 
  ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py 
ed0fd2fd3cfd37f535fa14f52835ddefd376038b 

Diff: https://reviews.apache.org/r/48096/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [8.346s]
[INFO] Apache Ambari Project POM . SUCCESS [0.036s]
[INFO] Ambari Web  SUCCESS [24.196s]
[INFO] Ambari Views .. SUCCESS [1.370s]
[INFO] Ambari Admin View . SUCCESS [7.555s]
[INFO] ambari-metrics  SUCCESS [0.388s]
[INFO] Ambari Metrics Common . SUCCESS [14.289s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.879s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.951s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.085s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.354s]
[INFO] Ambari Metrics Collector .. SUCCESS [6.883s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.126s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.886s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:15.977s]
[INFO] Ambari Server . SUCCESS [3:06.681s]
[INFO] Ambari Functional Tests ... SUCCESS [1.430s]
[INFO] Ambari Agent .. SUCCESS [30.176s]
[INFO] Ambari Client . SUCCESS [0.052s]
[INFO] Ambari Python Client .. SUCCESS [1.129s]
[INFO] Ambari Groovy Client .. SUCCESS [2.394s]
[INFO] Ambari Shell .. SUCCESS [0.078s]
[INFO] Ambari Python Shell ... SUCCESS [0.858s]
[INFO] Ambari Groovy Shell ... SUCCESS [4.609s]
[INFO] ambari-logsearch .. SUCCESS [0.264s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.231s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [4.324s]
[INFO] Ambari Logsearch Portal ... SUCCESS [6.150s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.309s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.101s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:29.831s
[INFO] Finished at: Tue May 31 15:21:18 PDT 2016
[INFO] Final Memory: 294M/1039M
[INFO] 

** 2. mvn test -DskipSurefireTests **

--
Ran 261 tests in 6.695s

OK
--
Total run:1052
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 55.370s
[INFO] Finished at: Tue May 31 15:09:42 PDT 2016
[INFO] Final Memory: 57M/1010M
[INFO] 

** 3. Manual 

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43126/
---

(Updated May 31, 2016, 8:32 p.m.)


Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle.


Changes
---

Removed rca tables from *-CREATE.sql. 
Now cleanup runs as part of SchemaUpgradeHelper.


Bugs: AMBARI-16692
https://issues.apache.org/jira/browse/AMBARI-16692


Repository: ambari


Description
---

RCA Database tables is not used anymore. This older, un-necessary data causes 
many Ambari DB queries to return more slowly than necessary. If the database 
gets large enough, it can have significant impact on the way ambari-server 
functions.
The Ambari Server upgrade process should detect the presence of these older, 
deprecated tables, and automate the process of cleaning up this data.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 d4272ba3760d5e5e0100f104159565bc28df02e5 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
31dd8f23e4410da7ce65d7c746fb6eb740ee8536 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
3c4f1caa5df407b1e4735238cd330db44f019271 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
f31af161b02fc44c398aa1371b639588b6c19c51 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
d1147b7d956c65992e78e2daacd8b94fab4fc082 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
5a7a6a58978d347a8d3d68813e68866e489ce9b1 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-DROP.sql 
a5380433131038abd15f1df05db8750e5e64ae0c 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
2dba3b70e1669bce368109ac89344d540640167d 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
e769e5bd11230d8543ed82f80d4bb4be810b9385 
  ambari-server/src/main/resources/AmbariRCA-DML-Oracle-CLEANUP.sql 
1f0f3c2b07a7d60be7c851b27dcde1777e5caa1f 
  ambari-server/src/main/resources/AmbariRCA-DML-Postgres-CLEANUP.sql 
3f07096ddf5e27b13ab0c8cd9dcc9e91ad500bee 
  ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Oracle-UPGRADE.sql 
f4027683bc5a8fc7ba7973d6270fc5ff3c9a4d0f 
  
ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Postgres-UPGRADE.sql 
d9a7a758ab2a87d8d1ce8c8544926f7bb2a241e7 

Diff: https://reviews.apache.org/r/43126/diff/


Testing (updated)
---

manual testing


Thanks,

Ajit Kumar

Review Request 48091: Update derivation of hawq_rm_memory_limit_perseg

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48091/
---

Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.


Bugs: AMBARI-16970
https://issues.apache.org/jira/browse/AMBARI-16970


Repository: ambari


Description
---

Update derivation of hawq_rm_memory_limit_perseg. It should be calculated based 
on vm.overcommit_ratio, vm.overcommit_memory and the available system memory. 
It should also have a default value.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 b096702 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 2ec145f 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
a634062 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 1d6a85c 

Diff: https://reviews.apache.org/r/48091/diff/


Testing
---

yes test case updated.


Thanks,

bhuvnesh chaudhary

Re: Review Request 48081: Prefix command execution log lines in agent log

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48081/#review135682
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 31, 2016, 7:29 p.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48081/
> ---
> 
> (Updated May 31, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16958
> https://issues.apache.org/jira/browse/AMBARI-16958
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If parallel execution is enabled, log lines of different components may 
> interfere, especially if they are split in more lines, a prefix for each log 
> containing component ROLE, task ID would be useful to be able to co-relate 
> these.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 5c9189c 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 0fd3bff 
> 
> Diff: https://reviews.apache.org/r/48081/diff/
> 
> 
> Testing
> ---
> 
> Test run manually and also via hadoop-qa
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Review Request 48089: AMBARI-16972 Strange behavior of Add Version functionality

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48089/
---

Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Oleg 
Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-16972
https://issues.apache.org/jira/browse/AMBARI-16972


Repository: ambari


Description
---

STR:
1. Install cluster.
2. Go to Manage Ambari > Versions > Register Version.
3. Click Add Version for HDP-2.5, type URL for some version (for example 
http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-427/HDP-2.5.0.0-427.xml)
 and click Add Version Info.

As a result version from VDF file will be loaded as selected, but if you open 
select box you will see current installed version and HDP-2.5 (Default Version 
Definition) instead of version, that you typed. If you will add version with 
the same VDF file, it will be added. But what is HDP-2.5 (Default Version 
Definition) and why it appears in combo box after first version adding.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js
 0af7004 

Diff: https://reviews.apache.org/r/48089/diff/


Testing
---

ambari-admin:
Executed 71 of 71 SUCCESS (0.13 secs / 0.35 secs)
Manual testing done.


Thanks,

Zhe (Joe) Wang

Review Request 48088: Stack VDF should ignore unsupported OS

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48088/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
Luniya.


Bugs: AMBARI-16971
https://issues.apache.org/jira/browse/AMBARI-16971


Repository: ambari


Description
---

Stack VDF loaded via hdp_urlinfo.json may contain OS families that are not 
supported by the stack.  They should not be included in the merged Version 
Definition


Diffs
-

  ambari-common/src/main/python/ambari_commons/resources/os_family.json c7b38aa 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
 a332308 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 
e494c44 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
 9f7a90f 
  ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/hdp.json f80fc0a 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/version-2.2.0.4-124-suse11.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/48088/diff/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Review Request 48081: Prefix command execution log lines in agent log

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48081/
---

Review request for Ambari, Alejandro Fernandez and Sandor Magyari.


Bugs: AMBARI-16958
https://issues.apache.org/jira/browse/AMBARI-16958


Repository: ambari


Description
---

If parallel execution is enabled, log lines of different components may 
interfere, especially if they are split in more lines, a prefix for each log 
containing component ROLE, task ID would be useful to be able to co-relate 
these.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 5c9189c 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 0fd3bff 

Diff: https://reviews.apache.org/r/48081/diff/


Testing
---

Test run manually and also via hadoop-qa


Thanks,

Sumit Mohanty

Review Request 48087: AMBARI-16969 : Provide ability in AMS to filter tracked metrics through a whitelist metic file.

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48087/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-16969
https://issues.apache.org/jira/browse/AMBARI-16969


Repository: ambari


Description
---

The file should contain a list of metrics that will be the only metrics stored 
and aggregated in AMS.
Config to use for specifying metric file.
ams-site : timeline.metrics.whitelist.file

Have separate durability setting configs for precision and aggregate tables


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 ee3418c 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 47962cb 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 7e4cc50 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java
 ce79b6f 

Diff: https://reviews.apache.org/r/48087/diff/


Testing
---

Unit tests pass
Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 48079: Capture user based metrics for Namenode fair call queue.

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48079/#review135659
---


Ship it!




Ship It!

- Aravindan Vijayan


On May 31, 2016, 5:07 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48079/
> ---
> 
> (Updated May 31, 2016, 5:07 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16968
> https://issues.apache.org/jira/browse/AMBARI-16968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capture user based metrics for Namenode fair call queue.
> replace port number in metric name with
> {client, datanode or healthcheck}
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  8c4766f 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  3d4a929 
> 
> Diff: https://reviews.apache.org/r/48079/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed. + Manual testing
> 
> [INFO] 
> [INFO] ambari-metrics . SUCCESS [  1.075 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [ 12.799 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [  4.997 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  6.559 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.580 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.218 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [05:55 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  1.126 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [  7.048 
> s]
> [INFO] Ambari Metrics Assembly  SUCCESS [01:02 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review135657
---


Ship it!




Ship It!

- Jayush Luniya


On May 31, 2016, 12:53 p.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated May 31, 2016, 12:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  eba1abf 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9a3fa31 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  3f14955 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  99a3ade 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> d2e0d11 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 4a7c1d2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> d1129cd 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 48042: Allow setting log level, and java opts for hive interactive/llap

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48042/#review135655
---


Ship it!




Ship It!

- Swapan Shridhar


On May 30, 2016, 1:33 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48042/
> ---
> 
> (Updated May 30, 2016, 1:33 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16955
> https://issues.apache.org/jira/browse/AMBARI-16955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Users should be able to control the log level for the daemons, and java args 
> for the daemon.
> 
> Both of these are likely to be text input boxes, which feed into hive 
> --service llap. There's no explicit ocnfiguration in hive-site.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  2fb8f0b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  4d85d4b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  e5b532c 
> 
> Diff: https://reviews.apache.org/r/48042/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jayush Luniya]

> On May 18, 2016, 11:53 p.m., Jayush Luniya wrote:
> > @Jeff 
> > Can you verify that blueprint deployment of the cluster without Livy Server 
> > works? 
> > 
> > Guide on Blueprints
> > https://cwiki.apache.org/confluence/display/AMBARI/Blueprints
> 
> Jayush Luniya wrote:
> @Jeff whats the latest on this? Did you get the blueprint scenario 
> verified? Also can you update the patch with latest in trunk?
> 
> Jeff Zhang wrote:
> @Jayush, I have some issues when verifying blueprint, also ask for help 
> to ambari mail list, but still not progress yet, could you help on that ? 
> http://mail-archives.apache.org/mod_mbox/ambari-user/201605.mbox/%3CCAADy7x7ha6amOjmNFCQN2bKpMACGbLJr3uDxKjPCn=jph_7...@mail.gmail.com%3E
> 
> Jeff Zhang wrote:
> Ping @Jayush

Sorry Jeff was on vacation last few days. Since you were able to get the 
blueprint deployment verified with help from Sumit, I will go ahead with 
committing this patch.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review133841
---


On May 31, 2016, 12:53 p.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated May 31, 2016, 12:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  eba1abf 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9a3fa31 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  3f14955 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  99a3ade 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> d2e0d11 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 4a7c1d2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> d1129cd 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 48079: Capture user based metrics for Namenode fair call queue.

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48079/
---

(Updated Май 31, 2016, 5:07 п.п.)


Review request for Ambari, Aravindan Vijayan and Sumit Mohanty.


Bugs: AMBARI-16968
https://issues.apache.org/jira/browse/AMBARI-16968


Repository: ambari


Description
---

Capture user based metrics for Namenode fair call queue.
replace port number in metric name with
{client, datanode or healthcheck}


Diffs
-

  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 8c4766f 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 3d4a929 

Diff: https://reviews.apache.org/r/48079/diff/


Testing (updated)
---

Unit tests passed. + Manual testing

[INFO] 
[INFO] ambari-metrics . SUCCESS [  1.075 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 12.799 s]
[INFO] Ambari Metrics Hadoop Sink . SUCCESS [  4.997 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [  6.559 s]
[INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.580 s]
[INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.218 s]
[INFO] Ambari Metrics Collector ... SUCCESS [05:55 min]
[INFO] Ambari Metrics Monitor . SUCCESS [  1.126 s]
[INFO] Ambari Metrics Grafana . SUCCESS [  7.048 s]
[INFO] Ambari Metrics Assembly  SUCCESS [01:02 min]
[INFO] 
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen

Review Request 48079: Capture user based metrics for Namenode fair call queue.

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48079/
---

Review request for Ambari, Aravindan Vijayan and Sumit Mohanty.


Bugs: AMBARI-16968
https://issues.apache.org/jira/browse/AMBARI-16968


Repository: ambari


Description
---

Capture user based metrics for Namenode fair call queue.
replace port number in metric name with
{client, datanode or healthcheck}


Diffs
-

  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 8c4766f 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 3d4a929 

Diff: https://reviews.apache.org/r/48079/diff/


Testing
---

Unit tests passed. + Manual testing


Thanks,

Dmytro Sen

Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

[Sangeeta Ravindran]

> On May 30, 2016, 10:22 a.m., Andrii Tkach wrote:
> > Ship It!

Thank you.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/#review135491
---


On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47995/
> ---
> 
> (Updated May 28, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-16941
> https://issues.apache.org/jira/browse/AMBARI-16941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Open Cluster Install Wizard and select Knox as the only service to install.
> 2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on 
> Next and proceed because of an error in the javascript code.
> 3. The javascript error is as follows:
> 4. TypeError: h.warnMessages is undefined
>   
> app.js (line 38401, col 49)
> TypeError: h.warnMessages is undefined
>   
> 
> ...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 
> 0; })
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
>   ambari-web/test/controllers/wizard/step6_test.js 56b9e96 
> 
> Diff: https://reviews.apache.org/r/47995/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> Added testcases to test anyHostErrors and anyHostWarnings methods.
> mvn test ran clean
> 
>  27862 tests complete (44 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

[Sangeeta Ravindran]

> On May 30, 2016, 11:19 a.m., Alexandr Antonenko wrote:
> > committed to trunk and branch-2.4

Thank you!


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/#review135496
---


On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47995/
> ---
> 
> (Updated May 28, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-16941
> https://issues.apache.org/jira/browse/AMBARI-16941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Open Cluster Install Wizard and select Knox as the only service to install.
> 2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on 
> Next and proceed because of an error in the javascript code.
> 3. The javascript error is as follows:
> 4. TypeError: h.warnMessages is undefined
>   
> app.js (line 38401, col 49)
> TypeError: h.warnMessages is undefined
>   
> 
> ...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 
> 0; })
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
>   ambari-web/test/controllers/wizard/step6_test.js 56b9e96 
> 
> Diff: https://reviews.apache.org/r/47995/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> Added testcases to test anyHostErrors and anyHostWarnings methods.
> mvn test ran clean
> 
>  27862 tests complete (44 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 48035: Upgrade Log Search SOLR to 5.5.1

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48035/#review135645
---


Ship it!




Ship It!

- Sandor Magyari


On May 30, 2016, 12:04 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48035/
> ---
> 
> (Updated May 30, 2016, 12:04 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16951
> https://issues.apache.org/jira/browse/AMBARI-16951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upgrade SOLR version from 5.5.0 to 5.5.1 (contains some SOLR bug fixes)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/pom.xml ae108e3 
> 
> Diff: https://reviews.apache.org/r/48035/diff/
> 
> 
> Testing
> ---
> 
> In progress..
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47018: "ambari-server upgrade" shouldn't automatically add stack configs

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47018/#review135643
---


Ship it!




Ship It!

- Nate Cole


On May 26, 2016, 12:15 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47018/
> ---
> 
> (Updated May 26, 2016, 12:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16272
> https://issues.apache.org/jira/browse/AMBARI-16272
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, "ambari-server upgrade" will automatically add stack configs.
> However, it also causes problems when default properties or properties with 
> default value such as "localhost" end up being added.
> 
> This led to many bugs. E.g., cluster with NameNode HA shouldn't automatically 
> add dfs.namenode.secondary.http-address
> 
> This logic today will even add new config types. E.g., add ranger-env even 
> though Ranger is not installed. If the customer then upgrades the stack from 
> HDP 2.2 to 2.3, and then adds Ranger, they can get the wrong configs.
> If we change this behavior, it's good to do so in a major release such as 2.4
> 
> We add required xml tags/attributes to properties:
> 
>   prop_name
>   prop_val
>   
>   
> 
> 
> we are going to enforce developers to explicitly specify what to do during 
> ambari/stack upgrade when adding any new config property
> If any of stack configuration files does not pass XSD schema validation (that 
> contains this enforcement), then ambari-server unit tests will fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  fb3ae69 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> 8a352bd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> a36df7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 34b3ba1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  2e857ed 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml
>  260fe65 
>   ambari-server/src/main/resources/configuration-schema.xsd PRE-CREATION 
>   
> ambari-server/src/main/resources/scripts/configurations-set-default-update-policy.sh
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
>  a4a3108 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  8f53f6a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
>  b11c5d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServicePropertiesTest.java
>  PRE-CREATION 
>   script.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47018/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests. Tried ambari-upgrade and stack upgrade, seems to work well.
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47730/
---

(Updated Май 31, 2016, 2:54 п.п.)


Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-16821
https://issues.apache.org/jira/browse/AMBARI-16821


Repository: ambari


Description
---

The TimelineMetricsCache implementation in the metrics sink side is currently a 
ConcurrentSkipListMap. It is better to use pre built cache libraries like Guava 
that offer more support.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-common/pom.xml 41ba62e 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
 0bed7d0 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
 18d973c 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 3d4a929 
  ambari-project/pom.xml 2fbb1e1 
  ambari-server/pom.xml 20d3fab 

Diff: https://reviews.apache.org/r/47730/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 48027: Files View : Table row overlaps if group name is long

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48027/#review135640
---


Ship it!




Ship It!

- Nitiraj Rathore


On May 30, 2016, 6:57 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48027/
> ---
> 
> (Updated May 30, 2016, 6:57 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16947
> https://issues.apache.org/jira/browse/AMBARI-16947
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Restricted file group to 10 character and file owner to 20 character. It 
> will show the complete string on hover.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs
>  a631335 
> 
> Diff: https://reviews.apache.org/r/48027/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47978: VDF should use package-version for the os, not the release

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47978/
---

(Updated May 31, 2016, 9:20 a.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-16933
https://issues.apache.org/jira/browse/AMBARI-16933


Repository: ambari


Description
---

The aggregated VDF skips package-version as it is defined in the {{release}} 
element.  This is incorrect as it implies that information is consistent for 
all repositories in the VDF.  The element has been moved, so code needs to 
account for that when formulating commands to the agent.

Luckily, code already existed for sending down the package-version, so it was 
changing that code to pull for the correct osFamily.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 f4a615c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 532ab2f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
 4ee6670 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
 39b30e7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 f6863be 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
 69eb39d 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 237eed2 
  ambari-server/src/test/resources/hbase_version_test.xml 183da8c 

Diff: https://reviews.apache.org/r/47978/diff/


Testing (updated)
---

Manual.  Automated:

Tests run: 4370, Failures: 0, Errors: 0, Skipped: 34

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 46:24.103s
[INFO] Finished at: Fri May 27 18:08:19 EDT 2016
[INFO] Final Memory: 33M/672M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 48041: SERVICE_CHECK Upgrade pre-check does not throw error when its expected to

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48041/#review135637
---




ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 (lines 152 - 155)


I think we should add an error message for the case where NO service check 
was run, versus the message when no RECENT service check was run.  See how 
CLIENT_RETRY check works with a List of fail messages to see how to do it.


- Nate Cole


On May 30, 2016, 9:30 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48041/
> ---
> 
> (Updated May 30, 2016, 9:30 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-16954
> https://issues.apache.org/jira/browse/AMBARI-16954
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.4.0.0 cluster with Ambari 2.2.2
> # Upgrade Ambari to 2.4.0.0
> # Register HDP-2.5.0.0 version and install the bits
> # Modify configs for some of the service like HDFS, ZK, YARN
> # Start EU
> 
> *Result*:
> EU pre-check does *not* report below error for the three services whose 
> config was modified in step 4
> "The following service configurations have been updated and their Service 
> Checks should be run again:"
> 
> Upon further investigation found that the pre-check does not work if a 
> service check has never been run for a service at all AND reports success in 
> such cases
> In other words, the comparison between last config modification time and last 
> service check time succeeds if service check never ran at all and the output 
> of below query returns empty:
> {code}
> SELECT start_time FROM host_role_command where role = 'HDFS_SERVICE_CHECK' 
> AND status = 'COMPLETED' ORDER BY start_time DESC;
> {code}
> 
> In this case when I manually ran a service check for HDFS and retried EU, the 
> pre-check caught the mismatch and reported error
> 
> *Note*: I believe we do run service check as part of cluster install, but 
> looks like it does not get updated in the DB tables for all services.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  9abfa50 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  55429bd 
> 
> Diff: https://reviews.apache.org/r/48041/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 48036: Service name shown instead of Host name on popup

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48036/#review135636
---




ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
 (lines 102 - 103)


If this is getting changed to a HOST type, then the CheckDescription enum 
should be changed to PrereqCheckType.HOST.

Hmm, but this is really a service-based check (SNN must be deleted).  Maybe 
just make the host name where it was found to be informational rather than the 
getFailedOn().  And in fact, getFailedOn() would be HDFS, not SNN since it's a 
service and SNN is a component.

Either way, should make sure a test covers this appropriately.


- Nate Cole


On May 30, 2016, 9:18 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48036/
> ---
> 
> (Updated May 30, 2016, 9:18 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-16953
> https://issues.apache.org/jira/browse/AMBARI-16953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> # Deploy ambari with HDP2.2
> # Register and install HDP2.5
> # Click "Upgrade"
> # Look at the Rolling Upgrade checks
> Result: Service name SECONDARY_NAMENODE shown instead of Host name on popup
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  4893098 
> 
> Diff: https://reviews.apache.org/r/48036/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/
---

(Updated May 31, 2016, 12:53 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

rebase patch


Bugs: AMBARI-15612
https://issues.apache.org/jira/browse/AMBARI-15612


Repository: ambari


Description
---

Add Livy to HDP 2.5 as slave component of Spark.

Move the spark stack definiation to commoon-services and then


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 eba1abf 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9a3fa31 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 3f14955 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 86e7f7d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 99a3ade 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
d2e0d11 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
4a7c1d2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
d1129cd 

Diff: https://reviews.apache.org/r/46727/diff/


Testing
---

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Thanks,

Jeff Zhang

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/
---

(Updated May 31, 2016, 12:52 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

rebase patch


Bugs: AMBARI-15612
https://issues.apache.org/jira/browse/AMBARI-15612


Repository: ambari


Description
---

Add Livy to HDP 2.5 as slave component of Spark.

Move the spark stack definiation to commoon-services and then


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 eba1abf 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9a3fa31 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 3f14955 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 86e7f7d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 99a3ade 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
d2e0d11 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
4a7c1d2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
d1129cd 

Diff: https://reviews.apache.org/r/46727/diff/


Testing
---

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Thanks,

Jeff Zhang

Re: Review Request 47984: Make storm.topology.submission.notifier.plugin.class property optional

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47984/#review135635
---


Ship it!




Ship It!

- Tom Beerbower


On May 28, 2016, 5:15 a.m., Sivaguru Chendamaraikannan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47984/
> ---
> 
> (Updated May 28, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Tom Beerbower.
> 
> 
> Bugs: AMBARI-16915
> https://issues.apache.org/jira/browse/AMBARI-16915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The commit, 
> https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a
>  which accidentally made the storm.topology.submission.notifier.plugin 
> property mandatory. If the storm defaults yaml config does not set the 
> property a " " value is set for the property. This causes storm startup to 
> fail with a Class Not Found exception when starting with Ambari. This change 
> fixes the stack advisor to not set the property when no value is specified 
> for it through command line or storm defaults.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 79314f5 
> 
> Diff: https://reviews.apache.org/r/47984/diff/
> 
> 
> Testing
> ---
> 
> mvn test
> 
> 
> Thanks,
> 
> Sivaguru Chendamaraikannan
> 
>

Re: Review Request 48072: Upgrade Catalog 2.4 is not idempotent

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48072/#review135629
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Травень 31, 2016, 2:12 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48072/
> ---
> 
> (Updated Травень 31, 2016, 2:12 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-16964
> https://issues.apache.org/jira/browse/AMBARI-16964
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **STR:**  
> Run ambrai-server upgrade twice (a with metainfo change).  
> **Result:**
> 
> 
> 30 May 2016 14:21:20,392 ERROR [main] DBAccessorImpl:803 - Error 
> executing query: UPDATE viewinstance SET cluster_handle_dummy = 2 WHERE 
> cluster_handle = 'cl1'
> org.postgresql.util.PSQLException: ERROR: invalid input syntax for 
> integer: "cl1"
>   Position: 73
> at 
> org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
> at 
> org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
> at 
> org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:403)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:395)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:800)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:792)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog240.updateViewInstanceTable(UpgradeCatalog240.java:2352)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog240.executeDDLUpdates(UpgradeCatalog240.java:277)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:699)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:201)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:302)
> 30 May 2016 14:21:20,424 ERROR [main] SchemaUpgradeHelper:203 - Upgrade 
> failed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  b817a15 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  56e8a8a 
> 
> Diff: https://reviews.apache.org/r/48072/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 48073: Exception while detecting JMX protocol for HISTORYSERVER

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48073/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-16965
https://issues.apache.org/jira/browse/AMBARI-16965


Repository: ambari


Description
---

Secured cluster with HDP 2.5. (also installed Ranger but I'm not sure that it
influences on this)  
I see a lot of exception in ambari server logs:




25 May 2016 16:50:16,982  INFO [pool-7-thread-26] 
AbstractProviderModule:1184 - Defaulting JMX to HTTP protocol for  for 
clusterName = c1, componentName = HISTORYSERVERHISTORYSERVER
25 May 2016 16:50:23,617  INFO [pool-7-thread-28] 
AbstractProviderModule:1182 - Exception while detecting JMX protocol for 
clusterName = c1, componentName = HISTORYSERVER
java.lang.NullPointerException
at 
org.apache.ambari.server.controller.internal.AbstractProviderModule.getJMXProtocolString(AbstractProviderModule.java:1205)
at 
org.apache.ambari.server.controller.internal.AbstractProviderModule.getJMXProtocol(AbstractProviderModule.java:1175)
at 
org.apache.ambari.server.controller.jmx.JMXPropertyProvider.getJMXProtocol(JMXPropertyProvider.java:378)
at 
org.apache.ambari.server.controller.jmx.JMXPropertyProvider.populateResource(JMXPropertyProvider.java:194)
at 
org.apache.ambari.server.controller.metrics.ThreadPoolEnabledPropertyProvider$1.call(ThreadPoolEnabledPropertyProvider.java:185)
at 
org.apache.ambari.server.controller.metrics.ThreadPoolEnabledPropertyProvider$1.call(ThreadPoolEnabledPropertyProvider.java:183)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)


It appears every few seconds


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 d747961 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
 3e78c37 

Diff: https://reviews.apache.org/r/48073/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 48069: REmote cluster with non-URI safe chars cause problems

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48069/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16962
https://issues.apache.org/jira/browse/AMBARI-16962


Repository: ambari


Description
---

added a regular expession on create and edit remote clusters page


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersCreateCtrl.js
 e669c82 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
 ec2915e 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
 e3fbe9c 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/remoteClusterPage.html
 0f82360 

Diff: https://reviews.apache.org/r/48069/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

[Jungtaek Lim]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48065/
---

Review request for Ambari.


Bugs: AMBARI-16949
https://issues.apache.org/jira/browse/AMBARI-16949


Repository: ambari


Description
---

When we request '/ws/v1/timeline/metrics' with metric name which contains %25 
(escaped '%'), response for the API is json describing there's NPE.
And NPE is logged for ambari-metrics-collector log file.

```
2016-05-30 09:15:05,061 WARN 
org.apache.hadoop.yarn.webapp.GenericExceptionHandler: INTERNAL_SERVER_ERROR
java.lang.NullPointerException
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.PhoenixHBaseAccessor.appendAggregateMetricFromResultSet(PhoenixHBaseAccessor.java:810)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.PhoenixHBaseAccessor.getAggregateMetricRecords(PhoenixHBaseAccessor.java:772)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.HBaseTimelineMetricStore.getTimelineMetrics(HBaseTimelineMetricStore.java:178)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.webapp.TimelineWebServices.getTimelineMetrics(TimelineWebServices.java:372)
at sun.reflect.GeneratedMethodAccessor21.invoke(Unknown Source)
```

Reason of NPE: 

Metrics are properly fetched with wildcard. But when applying functions to 
result set, actual metric name is not exist from map of metric name to list of 
function.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 47962cb 

Diff: https://reviews.apache.org/r/48065/diff/


Testing
---

Test failed from local but it's occurred from another modules, which is not 
related to current modification.

```
Results :

Failed tests:
  PrivilegeEventCreatorTest.putTest:107 expected:<...), Roles(
Permission[2:
  Users: testuser2
Permission1:
  Users: testuser
  Groups: testgroup])> but was:<...), Roles(
Permission[1:
  Users: testuser
  Groups: testgroup
Permission2:
  Users: testuser2])>
  RepositoryVersionEventCreatorTest.postTest:70 expected:<...ating system: 
redhat[6
Repository ID(2), Repository name(MyRepo6), Base url(http://example6.com)
Operating system: redhat7
Repository ID(1), Repository name(MyRepo), Base url(http://example].com)
)> but was:<...ating system: redhat[7
Repository ID(1), Repository name(MyRepo), Base url(http://example.com)
Operating system: redhat6
Repository ID(2), Repository name(MyRepo6), Base url(http://example6].com)
)>
  RepositoryVersionEventCreatorTest.putTest:100 expected:<...ating system: 
redhat[6
Repository ID(2), Repository name(MyRepo6), Base url(http://example6.com)
Operating system: redhat7
Repository ID(1), Repository name(MyRepo), Base url(http://example].com)
)> but was:<...ating system: redhat[7
Repository ID(1), Repository name(MyRepo), Base url(http://example.com)
Operating system: redhat6
Repository ID(2), Repository name(MyRepo6), Base url(http://example6].com)
)>
  ViewPrivilegeEventCreatorTest.putTest:85 expected:<...tatus(200 OK), 
Type([MyView), Version(MyView), Name(MyView), Permissions(
Permission2:
  Users: testuser2
Permission1:
  Users: testuser
  Groups: testgroup])> but was:<...tatus(200 OK), Type([null), Version(null), 
Name(null), Permissions(
Permission1:
  Users: testuser
  Groups: testgroup
Permission2:
  Users: testuser2])>
  
ComponentResourceProviderTest.testGetResourcesAsAdministrator:190->testGetResources:296
 expected:<[tru]e> but was:<[fals]e>
  
ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:195->testGetResources:296
 expected:<[tru]e> but was:<[fals]e>
  
ComponentResourceProviderTest.testGetResourcesAsServiceAdministrator:200->testGetResources:296
 expected:<[tru]e> but was:<[fals]e>
  
AmbariLdapDataPopulatorTest.testSynchronizeExistingLdapGroups_removeDuringIteration:333
  Expectation failure on verify:
AmbariLdapDataPopulatorTestInstance.getLdapGroupByMemberAttr("group2"): 
expected: 1, actual: 0
  UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1107
  Unexpected method call 
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface 
org.apache.ambari.server.state.Cluster, EasyMock for interface 
org.apache.ambari.server.state.Service):
AmbariManagementController.getClusters(): expected: at least 0, actual: 1
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for 
interface org.apache.ambari.server.state.Cluster, EasyMock for interface 
org.apache.ambari.server.state.Service): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
expected

Re: Review Request 48063: Redundant info under config tab for falcon

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48063/#review135616
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Травень 31, 2016, 8:23 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48063/
> ---
> 
> (Updated Травень 31, 2016, 8:23 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16959
> https://issues.apache.org/jira/browse/AMBARI-16959
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While configuring Falcon, there is an option to set the store for the entity
> definition. This updates the property "*.config.store.uri". On the Ambari UI
> there is an option to set this property under "Falcon Startup Properties" and
> "Falcon Server". The later one has not effect on the config files and should
> be removed from here.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  408df4f 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  45cd9a7 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  6e2e678 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  8e666ac 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  56e8a8a 
>   ambari-web/app/data/HDP2/site_properties.js beb420d 
> 
> Diff: https://reviews.apache.org/r/48063/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 48063: Redundant info under config tab for falcon

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48063/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-16959
https://issues.apache.org/jira/browse/AMBARI-16959


Repository: ambari


Description
---

While configuring Falcon, there is an option to set the store for the entity
definition. This updates the property "*.config.store.uri". On the Ambari UI
there is an option to set this property under "Falcon Startup Properties" and
"Falcon Server". The later one has not effect on the config files and should
be removed from here.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 408df4f 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 45cd9a7 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 6e2e678 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 8e666ac 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 56e8a8a 
  ambari-web/app/data/HDP2/site_properties.js beb420d 

Diff: https://reviews.apache.org/r/48063/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47730/
---

(Updated Май 31, 2016, 7:03 д.п.)


Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-16821
https://issues.apache.org/jira/browse/AMBARI-16821


Repository: ambari


Description
---

The TimelineMetricsCache implementation in the metrics sink side is currently a 
ConcurrentSkipListMap. It is better to use pre built cache libraries like Guava 
that offer more support.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-common/pom.xml 41ba62e 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
 0bed7d0 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
 18d973c 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 3d4a929 
  ambari-server/pom.xml 20d3fab 

Diff: https://reviews.apache.org/r/47730/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen