date:20160608



> On June 8, 2016, 10:21 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java,
> >  line 98
> > 
> >
> > So I had thought that we decided to make these optional (which you did) 
> > but that if you didn't specify them at all, nothing would happen - they'd 
> > all be false. This would prevent localhost from being accidentally added.
> > 
> > Am I wrong? Seems like it's a good balance - we'll allow XML files with 
> > no upgrade behavior elements, but if you don't specify them, then they are 
> > all false. This would prevent the unintentional adding of properties (like 
> > localhost fields or fields which need to be calculated)

I think making this field false by default would not make a trick because Sumit 
wants existing customer stacks (that have no on-ambari-upgrade tags) to work as 
before patch. That's why we would have to make false a default


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48403/#review136681
---


On June 8, 2016, 1:06 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48403/
> ---
> 
> (Updated June 8, 2016, 1:06 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17112
> https://issues.apache.org/jira/browse/AMBARI-17112
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We decided to split changes to stack config xmls and processing of them into 
> few patches.
> Current patch changes validation rules and available fields
> 
> Splitted PropertyUpgradeBehavior into 2 classes.
> PropertyAmbariUpgradeBehavior - defines behavior for ambari upgrade.
> on-ambari-upgrade now has the same 3 attributes, but all are optional. 
> Default value for add is true, false for others.
> 
> PropertyStackUpgradeBehavior - defines behavior for stack upgrade.
> on-stack-upgrade now has one attribute - add, and it is required.
> 
> Modified property update script and xsd schema to satisfy new requirements.
> 
> If patch looks good, I'll modify all stack configs to comply with it and 
> commit both patches at the same time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> fba2daa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
>  de2e342 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
>  de2e342 
>   ambari-server/src/main/resources/configuration-schema.xsd d49cbf8 
>   
> ambari-server/src/main/resources/scripts/configurations-set-default-update-policy.sh
>  930f778 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
>  9a3d195 
> 
> Diff: https://reviews.apache.org/r/48403/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 48460: Ambari Views logs should include information of view instance

2016-06-08 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48460/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17135
https://issues.apache.org/jira/browse/AMBARI-17135


Repository: ambari


Description
---

added servlet filter and used Logging frameworks MDC feature to insert view 
related information from URL. Updated view log4j files for the same.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 961b6fe 
  
ambari-server/src/main/java/org/apache/ambari/server/view/AmbariViewsMDCLoggingFilter.java
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
32903d3 
  contrib/views/files/src/main/resources/view.log4j.properties 698947e 
  contrib/views/hive-next/src/main/resources/view.log4j.properties b1bd5f2 
  contrib/views/hive/src/main/resources/view.log4j.properties 16c2d0e 
  contrib/views/hueambarimigration/src/main/resources/view.log4j.properties 
3e959e7 
  contrib/views/jobs/src/main/resources/view.log4j.properties 86687d6 
  contrib/views/pig/src/main/resources/view.log4j.properties 5b23a48 
  contrib/views/slider/src/main/resources/view.log4j.properties 4737032 
  contrib/views/storm/src/main/resources/view.log4j.properties 309df8d 
  contrib/views/tez/src/main/resources/view.log4j.properties 08e00bd 
  contrib/views/zeppelin/src/main/resources/view.log4j.properties PRE-CREATION 

Diff: https://reviews.apache.org/r/48460/diff/


Testing
---

Manual testing done.


Thanks,

Nitiraj Rathore

Review Request 48454: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as it w

2016-06-08 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48454/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17040, AMBARI-17099 and AMBARI-17103
https://issues.apache.org/jira/browse/AMBARI-17040
https://issues.apache.org/jira/browse/AMBARI-17099
https://issues.apache.org/jira/browse/AMBARI-17103


Repository: ambari


Description
---

**Fixed the following :**


- AMBARI-17103. Incorporating the inheritance logic for 
"tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 
'hive.tez.java.opts' config from hive2/hive-site.xml as it would be got via 
inheritance from hive/hive-site.xml.

- As tez_hive2/tez-interactive-site.xml have only the new/change configs, 
we will do the inheritance for other Tez properties from tez/tez-site.xml.


- AMBARI-17040. Update tez-interactive-site for HDP stack 2.5.
- Trims down the file and updates the configs.



- AMBARI-17099. Update tez-site for HDP 2.5 stack version.
- Adds the file at 2.5 stack.



- Checking the bounds if 'llap' queue calculated minimum capacity is more than 
100% capacity of cluster, don't create/update the queue.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 b6b963b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 04d4533 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 62823a2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
 779f4d1 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/TEZ/configuration/tez-site.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
6b5e2a1 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 22b3c52 

Diff: https://reviews.apache.org/r/48454/diff/


Testing
---

Python UTs modified : Passes pertaining to current change.

- 3 Python UT fails and not related to current change:
  ERROR: test_validateYARNConfigurationsEnv 
(test_stack_advisor.TestHDP22StackAdvisor)
  ERROR: test_service_check_secured (test_yarn_service_check.TestServiceCheck)
  ERROR: test_service_check_default (test_yarn_service_check.TestServiceCheck)


Thanks,

Swapan Shridhar

Review Request 48454: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as it w

2016-06-08 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48454/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17040, AMBARI-17099 and AMBARI-17103
https://issues.apache.org/jira/browse/AMBARI-17040
https://issues.apache.org/jira/browse/AMBARI-17099
https://issues.apache.org/jira/browse/AMBARI-17103


Repository: ambari


Description
---

**Fixed the following :**


- AMBARI-17103. Incorporating the inheritance logic for 
"tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 
'hive.tez.java.opts' config from hive2/hive-site.xml as it would be got via 
inheritance from hive/hive-site.xml.

- As tez_hive2/tez-interactive-site.xml have only the new/change configs, 
we will do the inheritance for other Tez properties from tez/tez-site.xml.


- AMBARI-17040. Update tez-interactive-site for HDP stack 2.5.
- Trims down the file and updates the configs.



- AMBARI-17099. Update tez-site for HDP 2.5 stack version.
- Adds the file at 2.5 stack.



- Checking the bounds if 'llap' queue calculated minimum capacity is more than 
100% capacity of cluster, don't create/update the queue.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 b6b963b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 04d4533 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 62823a2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
 779f4d1 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/TEZ/configuration/tez-site.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
6b5e2a1 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 22b3c52 

Diff: https://reviews.apache.org/r/48454/diff/


Testing
---

Python UTs modified : Passes pertaining to current change.

- 3 Python UT fails and not related to current change:
  ERROR: test_validateYARNConfigurationsEnv 
(test_stack_advisor.TestHDP22StackAdvisor)
  ERROR: test_service_check_secured (test_yarn_service_check.TestServiceCheck)
  ERROR: test_service_check_default (test_yarn_service_check.TestServiceCheck)


Thanks,

Swapan Shridhar

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-08 Thread Jungtaek Lim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48030/
---

(Updated 6 9, 2016, 1:58 오전)


Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
Wagle.


Changes
---

Addressing AMBARI-17133: Replace underscore character from Storm metrics sink.

Since AMBARI-17133 should be built on top of AMBARI-16946 but it's tiny size I 
would like to let AMBARI-16946 containing AMBARI-17133.


Bugs: AMBARI-16946
https://issues.apache.org/jira/browse/AMBARI-16946


Repository: ambari


Description
---

There's a mismatch between TimelineMetricsCache and Storm metrics unit, while 
TimelineMetricsCache considers "metric name + timestamp" to be unique but Storm 
is not.

For example, assume that bolt B has task T1, T2 and B has registered metrics 
M1. It's possible for metrics sink to receive (T1, M1) and (T2, M1) with same 
timestamp TS1 (in TaskInfo, not current time), and received later will be 
discarded from TimelineMetricsCache.

If we want to have unique metric point of Storm, we should use "topology name + 
component name + task id + metric name" to metric name so that "metric name + 
timestamp" will be unique.

There're other issues I would like to address, too.

- Currently, hostname is written to hostname of the machine which runs metrics 
sink. Since TaskInfo has hostname of the machine which runs task, we're better 
to use this.
- Unit of timestamp of TaskInfo is second, while Storm Metrics Sink uses this 
as millisecond, resulting in timestamp flaw, and malfunction of cache eviction. 
It should be multiplied by 1000.
- 'component name' is not unique across the cluster, so it's not fit for app 
id. 'topology name' is unique so proper value of app id is topology name.

Consideration: Hostname for determining 'write shard' is set to hostname of the 
machine which runs metrics sink. Since I don't know read also be sharded, I'm 
not sure it's safe to use TaskInfo's hostname to hostname of TimelineMetric. 
Please review carefully regarding this.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 02f5598 
  
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 8171a4d 

Diff: https://reviews.apache.org/r/48030/diff/


Testing
---

I tested this only ambari-metrics module since changeset is not related on 
other modules.

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] ambari-metrics . SUCCESS [  0.896 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 13.386 s]
[INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.085 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [  6.827 s]
[INFO] Ambari Metrics Kafka Sink .. SUCCESS [  4.190 s]
[INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.384 s]
[INFO] Ambari Metrics Collector ... SUCCESS [04:06 min]
[INFO] Ambari Metrics Monitor . SUCCESS [  3.556 s]
[INFO] Ambari Metrics Grafana . SUCCESS [01:03 min]
[INFO] Ambari Metrics Assembly  SUCCESS [  3.567 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 05:48 min
[INFO] Finished at: 2016-05-30T16:46:07+09:00
[INFO] Final Memory: 78M/1038M
[INFO] 

In fact, I tried to run `mvn test` from ambari root directory but build is 
failing from ambari-web.

```
> fsevents@0.2.1 install 
> /Users/jlim/WorkArea/JavaProjects/ambari/ambari-web/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild
...
npm WARN install:fsevents fsevents@0.2.1 install: `node-gyp rebuild`
npm WARN install:fsevents Exit status 1
```

No luck on `npm install`, too.


Thanks,

Jungtaek Lim

Review Request 48456: AMBARI-17134 - Add support flag for user type 'JWT'

2016-06-08 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48456/
---

Review request for Ambari and Zhe (Joe) Wang.


Bugs: AMBARI-17134
https://issues.apache.org/jira/browse/AMBARI-17134


Repository: ambari


Description
---

Add support flag for user type 'JWT'


Diffs
-

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js 47b87c4 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js
 4eb3633 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js
 3c5e7b2 

Diff: https://reviews.apache.org/r/48456/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.

PhantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.12 secs / 0.368 secs)


Thanks,

Richard Zang

Re: Review Request 48451: AMBARI-17132 - Typing the whole component name vs selecting drop down filter in hosts page gives 2 different results

2016-06-08 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48451/#review136734
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On June 9, 2016, 12:09 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48451/
> ---
> 
> (Updated June 9, 2016, 12:09 a.m.)
> 
> 
> Review request for Ambari and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-17132
> https://issues.apache.org/jira/browse/AMBARI-17132
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add facet validation check before search
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 02da1f6 
>   ambari-web/app/templates/main/host/combo_search_box.hbs 6ff9640 
>   ambari-web/app/views/main/host/combo_search_box.js c6ac3bd 
> 
> Diff: https://reviews.apache.org/r/48451/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   28664 tests complete (27 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 48451: AMBARI-17132 - Typing the whole component name vs selecting drop down filter in hosts page gives 2 different results

2016-06-08 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48451/
---

Review request for Ambari and Zhe (Joe) Wang.


Bugs: AMBARI-17132
https://issues.apache.org/jira/browse/AMBARI-17132


Repository: ambari


Description
---

Add facet validation check before search


Diffs
-

  ambari-web/app/messages.js 02da1f6 
  ambari-web/app/templates/main/host/combo_search_box.hbs 6ff9640 
  ambari-web/app/views/main/host/combo_search_box.js c6ac3bd 

Diff: https://reviews.apache.org/r/48451/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  28664 tests complete (27 seconds)
  154 tests pending


Thanks,

Richard Zang

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-08 Thread Juanjo Marron



> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote:
> > Ship It!

I dont have privileges to commit. Could someone deliver it to trunk so I can 
mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as complete, 
please?
Thanks


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48184/#review136516
---


On June 7, 2016, 4:09 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48184/
> ---
> 
> (Updated June 7, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16916
> https://issues.apache.org/jira/browse/AMBARI-16916
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SPARK2 service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  b3720f0 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  3316f78 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  9316ba9 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  434b4b1 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  2eae3e7 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  be65986 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  4196638 
> 
> Diff: https://reviews.apache.org/r/48184/diff/
> 
> 
> Testing
> ---
> 
> added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 48440: Cluster operator and ServiceAdministrator able to enable/disable/edit alert definitions

2016-06-08 Thread Eugene Chekanskiy



> On June 8, 2016, 7:47 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java,
> >  lines 347-351
> > 
> >
> > If this is needed in UpgradeCatalog240, why is it being done in 
> > UpgradeCatalog230?
> 
> Eugene Chekanskiy wrote:
> it doesn't matter where to put this hack, just after data was added or in 
> the beginning of 240 upgrade catalogue, so maybe its better to keep 240 
> catalog clean?

also I think thats it's better to keep this kind of hacks close to data, for 
example 230 ambari upgrade to 240 upgrade doesn't need this hack at all(other 
thing - we don't have ambari 230 :))


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48440/#review136677
---


On June 8, 2016, 6:51 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48440/
> ---
> 
> (Updated June 8, 2016, 6:51 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-17128
> https://issues.apache.org/jira/browse/AMBARI-17128
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Login to cluster using credentials of a cluster operator/ServiceAdministrator.
> Try moving to alerts page. Alerts are editable by cluster operator when it 
> shouldn't have been.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  ec3d765 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  b0f4974 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e89c0f1 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f640bb6 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0057982 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6a98e84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> df8f315 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql caee4f6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql ffd2040 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  86d776d 
> 
> Diff: https://reviews.apache.org/r/48440/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 48440: Cluster operator and ServiceAdministrator able to enable/disable/edit alert definitions

2016-06-08 Thread Eugene Chekanskiy



> On June 8, 2016, 7:47 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java,
> >  lines 347-351
> > 
> >
> > If this is needed in UpgradeCatalog240, why is it being done in 
> > UpgradeCatalog230?

it doesn't matter where to put this hack, just after data was added or in the 
beginning of 240 upgrade catalogue, so maybe its better to keep 240 catalog 
clean?


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48440/#review136677
---


On June 8, 2016, 6:51 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48440/
> ---
> 
> (Updated June 8, 2016, 6:51 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-17128
> https://issues.apache.org/jira/browse/AMBARI-17128
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Login to cluster using credentials of a cluster operator/ServiceAdministrator.
> Try moving to alerts page. Alerts are editable by cluster operator when it 
> shouldn't have been.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  ec3d765 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  b0f4974 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e89c0f1 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f640bb6 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0057982 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6a98e84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> df8f315 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql caee4f6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql ffd2040 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  86d776d 
> 
> Diff: https://reviews.apache.org/r/48440/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 48439: App Timeline Server start fails on a kerberized cluster due to absence of hdfs keytab


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48439/#review136685
---


Ship it!




Ship It!

- Robert Levas


On June 8, 2016, 2:46 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48439/
> ---
> 
> (Updated June 8, 2016, 2:46 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-15871
> https://issues.apache.org/jira/browse/AMBARI-15871
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberizing a cluster with App timeline server (not collocated with 
> HDFS-client) fails to restart service since it fails to obtain hdfs headless 
> keytab. This is because the hdfs keytabs are generated on Namenodes and hdfs 
> client nodes but not on App Timeline Server nodes. A small fix in Yarn 
> kerberos.json can get rid off this.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> 9afe668 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> 240f61e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  9606b59 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> 22fed42 
> 
> Diff: https://reviews.apache.org/r/48439/diff/
> 
> 
> Testing
> ---
> 
> --
> Ran 261 tests in 8.144s
> 
> OK
> --
> Total run:1052
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 48440: Cluster operator and ServiceAdministrator able to enable/disable/edit alert definitions


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48440/#review136677
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 (lines 347 - 351)


If this is needed in UpgradeCatalog240, why is it being done in 
UpgradeCatalog230?


- Robert Levas


On June 8, 2016, 2:51 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48440/
> ---
> 
> (Updated June 8, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-17128
> https://issues.apache.org/jira/browse/AMBARI-17128
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Login to cluster using credentials of a cluster operator/ServiceAdministrator.
> Try moving to alerts page. Alerts are editable by cluster operator when it 
> shouldn't have been.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  ec3d765 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  b0f4974 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e89c0f1 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f640bb6 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0057982 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6a98e84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> df8f315 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql caee4f6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql ffd2040 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  86d776d 
> 
> Diff: https://reviews.apache.org/r/48440/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 48096: AMBARI-16935: Retry and recover from component install failures

2016-06-08 Thread Nahappan Somasundaram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48096/
---

(Updated June 8, 2016, 12:22 p.m.)


Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and Sid 
Wagle.


Changes
---

Removed pass statements.


Bugs: AMBARI-16935
https://issues.apache.org/jira/browse/AMBARI-16935


Repository: ambari


Description
---

AMBARI-16935: Retry and recover from component install failures

** Issue **

There are multiple instances where components end up in INSTALL_FAILED state 
during cluster setup. Ambari does not retry or recover from INSTALL_FAILED 
state. 

Ambari should retry and recover from installation failures.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 
4de53900309345c6812d33c5464a24608cde7d9a 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 
87d9483c634026897629396bb48ec0cbabfcfae6 
  ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py 
ed0fd2fd3cfd37f535fa14f52835ddefd376038b 

Diff: https://reviews.apache.org/r/48096/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [8.346s]
[INFO] Apache Ambari Project POM . SUCCESS [0.036s]
[INFO] Ambari Web  SUCCESS [24.196s]
[INFO] Ambari Views .. SUCCESS [1.370s]
[INFO] Ambari Admin View . SUCCESS [7.555s]
[INFO] ambari-metrics  SUCCESS [0.388s]
[INFO] Ambari Metrics Common . SUCCESS [14.289s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.879s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.951s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.085s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.354s]
[INFO] Ambari Metrics Collector .. SUCCESS [6.883s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.126s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.886s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:15.977s]
[INFO] Ambari Server . SUCCESS [3:06.681s]
[INFO] Ambari Functional Tests ... SUCCESS [1.430s]
[INFO] Ambari Agent .. SUCCESS [30.176s]
[INFO] Ambari Client . SUCCESS [0.052s]
[INFO] Ambari Python Client .. SUCCESS [1.129s]
[INFO] Ambari Groovy Client .. SUCCESS [2.394s]
[INFO] Ambari Shell .. SUCCESS [0.078s]
[INFO] Ambari Python Shell ... SUCCESS [0.858s]
[INFO] Ambari Groovy Shell ... SUCCESS [4.609s]
[INFO] ambari-logsearch .. SUCCESS [0.264s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.231s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [4.324s]
[INFO] Ambari Logsearch Portal ... SUCCESS [6.150s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.309s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.101s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:29.831s
[INFO] Finished at: Tue May 31 15:21:18 PDT 2016
[INFO] Final Memory: 294M/1039M
[INFO] 

** 2. mvn test -DskipSurefireTests **

--
Ran 261 tests in 6.695s

OK
--
Total run:1052
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 55.370s
[INFO] Finished at: Tue May 31 15:09:42 PDT 2016
[INFO] Final Memory: 57M/1010M
[INFO]

Re: Review Request 48096: AMBARI-16935: Retry and recover from component install failures

2016-06-08 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48096/#review136679
---


Fix it, then Ship it!





ambari-agent/src/main/python/ambari_agent/RecoveryManager.py (line 329)


remove pass



ambari-agent/src/main/python/ambari_agent/RecoveryManager.py (line 665)


remove pass


- Jonathan Hurley


On June 7, 2016, 11:51 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48096/
> ---
> 
> (Updated June 7, 2016, 11:51 a.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-16935
> https://issues.apache.org/jira/browse/AMBARI-16935
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16935: Retry and recover from component install failures
> 
> ** Issue **
> 
> There are multiple instances where components end up in INSTALL_FAILED state 
> during cluster setup. Ambari does not retry or recover from INSTALL_FAILED 
> state. 
> 
> Ambari should retry and recover from installation failures.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 
> fdda63251b3ddf96cec794037029e786a9c0bc91 
>   ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 
> 87d9483c634026897629396bb48ec0cbabfcfae6 
>   ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py 
> ed0fd2fd3cfd37f535fa14f52835ddefd376038b 
> 
> Diff: https://reviews.apache.org/r/48096/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [8.346s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.036s]
> [INFO] Ambari Web  SUCCESS [24.196s]
> [INFO] Ambari Views .. SUCCESS [1.370s]
> [INFO] Ambari Admin View . SUCCESS [7.555s]
> [INFO] ambari-metrics  SUCCESS [0.388s]
> [INFO] Ambari Metrics Common . SUCCESS [14.289s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.879s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.951s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.085s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [2.354s]
> [INFO] Ambari Metrics Collector .. SUCCESS [6.883s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.126s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.886s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:15.977s]
> [INFO] Ambari Server . SUCCESS [3:06.681s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.430s]
> [INFO] Ambari Agent .. SUCCESS [30.176s]
> [INFO] Ambari Client . SUCCESS [0.052s]
> [INFO] Ambari Python Client .. SUCCESS [1.129s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.394s]
> [INFO] Ambari Shell .. SUCCESS [0.078s]
> [INFO] Ambari Python Shell ... SUCCESS [0.858s]
> [INFO] Ambari Groovy Shell ... SUCCESS [4.609s]
> [INFO] ambari-logsearch .. SUCCESS [0.264s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.231s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [4.324s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [6.150s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.309s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.101s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:29.831s
> [INFO] Finished at: Tue May 31 15:21:18 PDT 2016
> [INFO] Final Memory: 294M/1039M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Ran 261 tests in 6.695s
> 
> OK
>

Review Request 48440: Cluster operator and ServiceAdministrator able to enable/disable/edit alert definitions


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48440/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-17128
https://issues.apache.org/jira/browse/AMBARI-17128


Repository: ambari


Description
---

Login to cluster using credentials of a cluster operator/ServiceAdministrator.
Try moving to alerts page. Alerts are editable by cluster operator when it 
shouldn't have been.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 ec3d765 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 b0f4974 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e89c0f1 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f640bb6 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0057982 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6a98e84 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
df8f315 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql caee4f6 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql ffd2040 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 86d776d 

Diff: https://reviews.apache.org/r/48440/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 48439: App Timeline Server start fails on a kerberized cluster due to absence of hdfs keytab


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48439/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-15871
https://issues.apache.org/jira/browse/AMBARI-15871


Repository: ambari


Description
---

Kerberizing a cluster with App timeline server (not collocated with 
HDFS-client) fails to restart service since it fails to obtain hdfs headless 
keytab. This is because the hdfs keytabs are generated on Namenodes and hdfs 
client nodes but not on App Timeline Server nodes. A small fix in Yarn 
kerberos.json can get rid off this.


Diffs
-

  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
9afe668 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
240f61e 
  
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 
9606b59 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
22fed42 

Diff: https://reviews.apache.org/r/48439/diff/


Testing
---

--
Ran 261 tests in 8.144s

OK
--
Total run:1052
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi

Re: Review Request 48332: Log search capability for Nifi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/
---

(Updated June 8, 2016, 5:53 p.m.)


Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
Sumit Mohanty.


Bugs: AMBARI-17086
https://issues.apache.org/jira/browse/AMBARI-17086


Repository: ambari


Description
---

Giving users the ability to deploy a service to their cluster to collect, 
index, and explore those log files is needed to improve the ease of 
administration for the operators.
Add Log search capability for NiFi


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 34583ba 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 54e08e4 

Diff: https://reviews.apache.org/r/48332/diff/


Testing
---

Log Seaerch was installed and logs were loaded fine on local cluster with NiFi


Thanks,

Miklos Gergely

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-08 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48403/#review136659
---




ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
(lines 53 - 54)


Is this being removed to focus only on Ambari Upgrade


- Nate Cole


On June 8, 2016, 6:06 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48403/
> ---
> 
> (Updated June 8, 2016, 6:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17112
> https://issues.apache.org/jira/browse/AMBARI-17112
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We decided to split changes to stack config xmls and processing of them into 
> few patches.
> Current patch changes validation rules and available fields
> 
> Splitted PropertyUpgradeBehavior into 2 classes.
> PropertyAmbariUpgradeBehavior - defines behavior for ambari upgrade.
> on-ambari-upgrade now has the same 3 attributes, but all are optional. 
> Default value for add is true, false for others.
> 
> PropertyStackUpgradeBehavior - defines behavior for stack upgrade.
> on-stack-upgrade now has one attribute - add, and it is required.
> 
> Modified property update script and xsd schema to satisfy new requirements.
> 
> If patch looks good, I'll modify all stack configs to comply with it and 
> commit both patches at the same time.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> fba2daa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
>  de2e342 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
>  de2e342 
>   ambari-server/src/main/resources/configuration-schema.xsd d49cbf8 
>   
> ambari-server/src/main/resources/scripts/configurations-set-default-update-policy.sh
>  930f778 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
>  9a3d195 
> 
> Diff: https://reviews.apache.org/r/48403/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 48419: Accumulo master start fails on non-root + umask 027


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48419/#review136657
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 8, 2016, 7:07 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48419/
> ---
> 
> (Updated June 8, 2016, 7:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17123
> https://issues.apache.org/jira/browse/AMBARI-17123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_master.py",
>  line 24, in 
> AccumuloScript('master').execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py",
>  line 81, in start
> self.configure(env) # for security
>   File 
> "/var/lib/ambari-agent/cache/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py",
>  line 75, in configure
> setup_conf_dir(name=self.component)
>   File 
> "/var/lib/ambari-agent/cache/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py",
>  line 218, in setup_conf_dir
> os.remove(passfile)
> OSError: [Errno 1] Operation not permitted: 
> '/var/lib/ambari-agent/tmp/pass'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
> 
> Diff: https://reviews.apache.org/r/48419/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 48419: Accumulo master start fails on non-root + umask 027


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48419/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17123
https://issues.apache.org/jira/browse/AMBARI-17123


Repository: ambari


Description
---

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_master.py",
 line 24, in 
AccumuloScript('master').execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 257, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py",
 line 81, in start
self.configure(env) # for security
  File 
"/var/lib/ambari-agent/cache/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py",
 line 75, in configure
setup_conf_dir(name=self.component)
  File 
"/var/lib/ambari-agent/cache/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py",
 line 218, in setup_conf_dir
os.remove(passfile)
OSError: [Errno 1] Operation not permitted: '/var/lib/ambari-agent/tmp/pass'


Diffs
-

  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
 09a3d90 

Diff: https://reviews.apache.org/r/48419/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin

2016-06-08 Thread Srimanth Gunturi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48273/#review136656
---


Ship it!




Ship It!

- Srimanth Gunturi


On June 6, 2016, 3:26 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48273/
> ---
> 
> (Updated June 6, 2016, 3:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17054
> https://issues.apache.org/jira/browse/AMBARI-17054
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains changes to support Ranger Atlas Plugin from Ambari.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  34d1a1a 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  1e9e7a7 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  a79a456 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  4db7f45 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json
>  0f7b0c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  8b669e8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  98cbc30 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 379c268 
> 
> Diff: https://reviews.apache.org/r/48273/diff/
> 
> 
> Testing
> ---
> 
> Verified : 
> 
> 1) Enable / disable actions for Ranger Atlas Plugin
> 2) Checked Ranger plugin comminication. 
> 3) Checked policy enforecements on Atlas based on Ranger's policies.
> 4) Verified stack advisor recommendations to chnange following properties : 
> 
> atlas.authorizer.impl=org.apache.ranger.authorization.atlas.authorizer.RangerAtlasAuthorizer
> ranger-atlas-plugin-enabled=yes
> 5) Verified Ranger service creation (while enabling Ranger Atlas Plugin)
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 48416: Ambari warns the user about a bunch of rpm packages that are installed on barebone CentOS 7


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48416/#review136646
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 8, 2016, 5:39 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48416/
> ---
> 
> (Updated June 8, 2016, 5:39 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17120
> https://issues.apache.org/jira/browse/AMBARI-17120
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Installed Ambari 2.4.0 dev build on a clean CentOS 7.0 VM (using ambari-
> vagrant).  
> After SSH bootstrap of the agent, Ambari showed 15 package warnings (see
> attached).
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 71ee23f 
>   ambari-agent/src/test/python/resource_management/TestPackagesAnalyzer.py 
> d9ddb38 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
>  d4b48ef 
>   ambari-server/src/main/resources/custom_actions/scripts/check_host.py 
> 46b8199 
> 
> Diff: https://reviews.apache.org/r/48416/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 48415: Authorizations given to role-based principals must be dereferenced upon user login

2016-06-08 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48415/#review136645
---


Ship it!




Ship It!

- Jonathan Hurley


On June 8, 2016, 9:53 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48415/
> ---
> 
> (Updated June 8, 2016, 9:53 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Nate Cole.
> 
> 
> Bugs: AMBARI-16247
> https://issues.apache.org/jira/browse/AMBARI-16247
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Authorizations given to role-based principals must be dereferenced upon user 
> login.  These authorizations are dynamically determined based on the user's 
> set of roles.  
> 
> In 
> `org.apache.ambari.server.security.authorization.AmbariLocalUserDetailsService#loadUserByUsername`,
>  the set of `GrantedAuthorities` the authenticated user is calculated.  
> During this process, using the set of `cluster-level roles` a user is 
> granted, any permissions given to matching role-based principals should be 
> given to the user. 
> 
> This essentially work like giving privileges to a group of users calculated 
> at runtime. 
> 
> A use-case to support the need for this is to assign access to a view to all 
> users with some specific role. Currently we can assign access to a view to a 
> specific user or group by assigning that user or group the `VIEW.USER` role 
> applied to the specific view.  To assign access a view to users who have a 
> specific role, a `role` will need to behave like a `principal`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  545095d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48415/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkinks test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 48416: Ambari warns the user about a bunch of rpm packages that are installed on barebone CentOS 7


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48416/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17120
https://issues.apache.org/jira/browse/AMBARI-17120


Repository: ambari


Description
---

Installed Ambari 2.4.0 dev build on a clean CentOS 7.0 VM (using ambari-
vagrant).  
After SSH bootstrap of the agent, Ambari showed 15 package warnings (see
attached).


Diffs
-

  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 71ee23f 
  ambari-agent/src/test/python/resource_management/TestPackagesAnalyzer.py 
d9ddb38 
  
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
 d4b48ef 
  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 46b8199 

Diff: https://reviews.apache.org/r/48416/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48415: Authorizations given to role-based principals must be dereferenced upon user login

2016-06-08 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48415/#review136644
---


Ship it!




Ship It!

- Nate Cole


On June 8, 2016, 9:53 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48415/
> ---
> 
> (Updated June 8, 2016, 9:53 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Nate Cole.
> 
> 
> Bugs: AMBARI-16247
> https://issues.apache.org/jira/browse/AMBARI-16247
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Authorizations given to role-based principals must be dereferenced upon user 
> login.  These authorizations are dynamically determined based on the user's 
> set of roles.  
> 
> In 
> `org.apache.ambari.server.security.authorization.AmbariLocalUserDetailsService#loadUserByUsername`,
>  the set of `GrantedAuthorities` the authenticated user is calculated.  
> During this process, using the set of `cluster-level roles` a user is 
> granted, any permissions given to matching role-based principals should be 
> given to the user. 
> 
> This essentially work like giving privileges to a group of users calculated 
> at runtime. 
> 
> A use-case to support the need for this is to assign access to a view to all 
> users with some specific role. Currently we can assign access to a view to a 
> specific user or group by assigning that user or group the `VIEW.USER` role 
> applied to the specific view.  To assign access a view to users who have a 
> specific role, a `role` will need to behave like a `principal`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  545095d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48415/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkinks test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 48413: Fix misnamed Zookeeper connect strings


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48413/
---

(Updated June 8, 2016, 2:14 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

test json updated too (not required, just for consistency)


Bugs: AMBARI-17117
https://issues.apache.org/jira/browse/AMBARI-17117


Repository: ambari


Description
---

Variables/properties holding zookeeper connect strings are misnamed as zk_host, 
or zk_hosts, which may be misleading. Variable / property names fixed.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 1f86dd0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 6fb0b0e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java
 200a603 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 
b6301ca 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
 076c09c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2
 a485600 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
 afbccca 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 03ff0ff 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 14125bc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 147e148 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 edf1dcc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java
 21c010f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2
 0a94186 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 a2da737 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 2805b0b 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 0813221 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java
 f814678 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 c382c14 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 6a52708 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 9ada5bf 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
 b31f39b 
  ambari-server/src/test/python/stacks/2.4/configs/default.json c3aecff 

Diff: https://reviews.apache.org/r/48413/diff/


Testing
---

Tested on local cluster

ambari-logsearch-logfeeder:
Tests run: 35, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Miklos Gergely

Review Request 48415: Authorizations given to role-based principals must be dereferenced upon user login

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48415/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Myroslav
Papirkovskyy, and Nate Cole.

Bugs: AMBARI-16247
https://issues.apache.org/jira/browse/AMBARI-16247

Repository: ambari

Description
---

Authorizations given to role-based principals must be dereferenced upon user
login. These authorizations are dynamically determined based on the user's set
of roles.

In
`org.apache.ambari.server.security.authorization.AmbariLocalUserDetailsService#loadUserByUsername`,
the set of `GrantedAuthorities` the authenticated user is calculated. During
this process, using the set of `cluster-level roles` a user is granted, any
permissions given to matching role-based principals should be given to the
user.

This essentially work like giving privileges to a group of users calculated at
runtime.

A use-case to support the need for this is to assign access to a view to all
users with some specific role. Currently we can assign access to a view to a
specific user or group by assigning that user or group the `VIEW.USER` role
applied to the specific view. To assign access a view to users who have a
specific role, a `role` will need to behave like a `principal`.

Diffs
-

ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
545095d

ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
PRE-CREATION

Diff: https://reviews.apache.org/r/48415/diff/

Testing
---

Manually tested

# Local test results: PENDING

# Jenkinks test results: PENDING

Thanks,

Robert Levas

Re: Review Request 48392: Deadlock While Updating Stale Configuration Cache During Upgrade


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48392/#review136637
---


Ship it!




Ship It!

- Robert Levas


On June 8, 2016, 8:44 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48392/
> ---
> 
> (Updated June 8, 2016, 8:44 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-17106
> https://issues.apache.org/jira/browse/AMBARI-17106
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is another case of an Ambari cache competing with a JPA transaction. 
> Consider these steps:
> - A new configuration is created within the context of a Transaction
> - Within that same Transaction, the stale configuration cache is told to 
> invalidate
> - After purging the old data, but before the Transaction is committed, 
> another thread tries to read from the cache. It ends up re-populating the old 
> data.
> 
> Sometimes the code works because the Transaction is able to committ before 
> the cache is re-populated by another thread. In theory, we should be locking 
> around reading the cache to ensure that there isn't a transaction writing to 
> it. However, this is what caused the deadlock since it interferes with our 
> wonder "cluster global lock of doom".
> 
> Instead, it's safer in this case to just invalidate the cache after the 
> Transaction completes. 
> - We do this invalidate on a separate thread to ensure we don't have issues 
> with the cluster global lock
> - Since the cache isn't needed within the context of the invalidation call, 
> it's OK to purge it asynchronously.
> 
> ```
> "Server Action Executor Worker 401" #225 prio=5 os_prio=0 
> tid=0x7fa07c03e800 nid=0x65df waiting on condition [0x7fa0737ef000]
>java.lang.Thread.State: WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0xa059d4f0> (a 
> java.util.concurrent.locks.ReentrantReadWriteLock$FairSync)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
>   at 
> java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(ReentrantReadWriteLock.java:943)
> 
>   --> @TransactionalLock(lockArea = LockArea.STALE_CONFIG_CACHE, lockType = 
> LockType.WRITE)
> 
>   at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.lockTransaction(AmbariJpaLocalTxnInterceptor.java:291)
>   at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:114)
>   at 
> com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
>   at 
> com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
>   at 
> org.apache.ambari.server.state.cluster.ClusterImpl$$EnhancerByGuice$$991b84fc.applyConfigs()
> 
>   --> clusterGlobalLock.writeLock().lock();
> 
>   at 
> org.apache.ambari.server.state.cluster.ClusterImpl.addDesiredConfig(ClusterImpl.java:2340)
>   at 
> org.apache.ambari.server.state.ConfigHelper.createConfigTypes(ConfigHelper.java:897)
>   at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider.applyStackAndProcessConfigurations(UpgradeResourceProvider.java:1174)
> ```
> 
> ```
> "ambari-hearbeat-monitor" #23 prio=5 os_prio=0 tid=0x7fa07476c000 
> nid=0x20ad waiting on condition [0x7fa07bbfb000]
>java.lang.Thread.State: WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0xa32d44a0> (a 
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(AbstractQueuedSynchronizer.java:967)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(AbstractQueuedSynchronizer.java:1283)
>   at 
> java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(ReentrantReadWriteLock.java:727)
>   at 
> org.apache.ambari.server.state.cluster.ClusterImpl.getDesiredStackVersion(ClusterImpl.java:1052)
>   at 
>

Review Request 48413: Fix misnamed Zookeeper connect strings


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48413/
---

Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-17117
https://issues.apache.org/jira/browse/AMBARI-17117


Repository: ambari


Description
---

Variables/properties holding zookeeper connect strings are misnamed as zk_host, 
or zk_hosts, which may be misleading. Variable / property names fixed.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 1f86dd0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 6fb0b0e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java
 200a603 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 
b6301ca 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
 076c09c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2
 a485600 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
 afbccca 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 03ff0ff 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 14125bc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 147e148 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 edf1dcc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java
 21c010f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2
 0a94186 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 a2da737 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 2805b0b 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 0813221 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java
 f814678 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 c382c14 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 6a52708 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 9ada5bf 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
 b31f39b 
  ambari-server/src/test/python/stacks/2.4/configs/default.json c3aecff 

Diff: https://reviews.apache.org/r/48413/diff/


Testing
---

Tested on local cluster

ambari-logsearch-logfeeder:
Tests run: 35, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Miklos Gergely

Re: Review Request 48410: Ambari-agent could not successfully restart on non-root after running as root


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48410/#review136626
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 8, 2016, 3:17 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48410/
> ---
> 
> (Updated June 8, 2016, 3:17 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17116
> https://issues.apache.org/jira/browse/AMBARI-17116
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The issue is caused by restarting ambari-agent and after it is stopped it
> cannot start with:
> 
> 
> 
> Restarting ambari-agent
> Verifying Python version compatibility...
> Using python  /usr/bin/python
> ambari-agent is not running. No PID found at 
> /var/run/ambari-agent/ambari-agent.pid
> Verifying Python version compatibility...
> Using python  /usr/bin/python
> Checking for previously running Ambari Agent...
> Starting ambari-agent
> /usr/sbin/ambari-agent: line 172: /var/log/ambari-agent/ambari-agent.out: 
> Permission denied
> Verifying ambari-agent process status...
> ERROR: ambari-agent start failed. For more details, see 
> /var/log/ambari-agent/ambari-agent.out:
> 
> tail: cannot open ‘/var/log/ambari-agent/ambari-agent.out’ for reading: 
> Permission denied
> 
> Agent out at: /var/log/ambari-agent/ambari-agent.out
> Agent log at: /var/log/ambari-agent/ambari-agent.log
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent 77b475b 
> 
> Diff: https://reviews.apache.org/r/48410/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 48410: Ambari-agent could not successfully restart on non-root after running as root


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48410/
---

(Updated June 8, 2016, 12:17 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17116
https://issues.apache.org/jira/browse/AMBARI-17116


Repository: ambari


Description
---

The issue is caused by restarting ambari-agent and after it is stopped it
cannot start with:



Restarting ambari-agent
Verifying Python version compatibility...
Using python  /usr/bin/python
ambari-agent is not running. No PID found at 
/var/run/ambari-agent/ambari-agent.pid
Verifying Python version compatibility...
Using python  /usr/bin/python
Checking for previously running Ambari Agent...
Starting ambari-agent
/usr/sbin/ambari-agent: line 172: /var/log/ambari-agent/ambari-agent.out: 
Permission denied
Verifying ambari-agent process status...
ERROR: ambari-agent start failed. For more details, see 
/var/log/ambari-agent/ambari-agent.out:

tail: cannot open ‘/var/log/ambari-agent/ambari-agent.out’ for reading: 
Permission denied

Agent out at: /var/log/ambari-agent/ambari-agent.out
Agent log at: /var/log/ambari-agent/ambari-agent.log


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent 77b475b 

Diff: https://reviews.apache.org/r/48410/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48410: Ambari-agent could not successfully restart on non-root after running as root


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48410/
---

(Updated June 8, 2016, 12:13 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17116
https://issues.apache.org/jira/browse/AMBARI-17116


Repository: ambari


Description (updated)
---

The issue is caused by restarting ambari-agent and after it is stopped it
cannot start with:



Restarting ambari-agent
Verifying Python version compatibility...
Using python  /usr/bin/python
ambari-agent is not running. No PID found at 
/var/run/ambari-agent/ambari-agent.pid
Verifying Python version compatibility...
Using python  /usr/bin/python
Checking for previously running Ambari Agent...
Starting ambari-agent
/usr/sbin/ambari-agent: line 172: /var/log/ambari-agent/ambari-agent.out: 
Permission denied
Verifying ambari-agent process status...
ERROR: ambari-agent start failed. For more details, see 
/var/log/ambari-agent/ambari-agent.out:

tail: cannot open ‘/var/log/ambari-agent/ambari-agent.out’ for reading: 
Permission denied

Agent out at: /var/log/ambari-agent/ambari-agent.out
Agent log at: /var/log/ambari-agent/ambari-agent.log


Diffs
-

  ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b 

Diff: https://reviews.apache.org/r/48410/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48410: Ambari-agent could not successfully restart on non-root after running as root


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48410/
---

(Updated June 8, 2016, 12:10 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Summary (updated)
-

Ambari-agent could not successfully restart on non-root after running as root


Bugs: AMBARI-17116
https://issues.apache.org/jira/browse/AMBARI-17116


Repository: ambari


Description (updated)
---

The issue is caused by QE restarting ambari-agent and after it is stopped it
cannot start with:



Restarting ambari-agent
Verifying Python version compatibility...
Using python  /usr/bin/python
ambari-agent is not running. No PID found at 
/var/run/ambari-agent/ambari-agent.pid
Verifying Python version compatibility...
Using python  /usr/bin/python
Checking for previously running Ambari Agent...
Starting ambari-agent
/usr/sbin/ambari-agent: line 172: /var/log/ambari-agent/ambari-agent.out: 
Permission denied
Verifying ambari-agent process status...
ERROR: ambari-agent start failed. For more details, see 
/var/log/ambari-agent/ambari-agent.out:

tail: cannot open ‘/var/log/ambari-agent/ambari-agent.out’ for reading: 
Permission denied

Agent out at: /var/log/ambari-agent/ambari-agent.out
Agent log at: /var/log/ambari-agent/ambari-agent.log


Diffs
-

  ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b 

Diff: https://reviews.apache.org/r/48410/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 48410: Heartbeat lost of ambari agent during install


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48410/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17116
https://issues.apache.org/jira/browse/AMBARI-17116


Repository: ambari


Description
---

The issue is caused by QE restarting ambari-agent and after it is stopped it
cannot start with:



Restarting ambari-agent
Verifying Python version compatibility...
Using python  /usr/bin/python
ambari-agent is not running. No PID found at 
/var/run/ambari-agent/ambari-agent.pid
Verifying Python version compatibility...
Using python  /usr/bin/python
Checking for previously running Ambari Agent...
Starting ambari-agent
/usr/sbin/ambari-agent: line 172: /var/log/ambari-agent/ambari-agent.out: 
Permission denied
Verifying ambari-agent process status...
ERROR: ambari-agent start failed. For more details, see 
/var/log/ambari-agent/ambari-agent.out:

tail: cannot open ‘/var/log/ambari-agent/ambari-agent.out’ for reading: 
Permission denied

Agent out at: /var/log/ambari-agent/ambari-agent.out
Agent log at: /var/log/ambari-agent/ambari-agent.log



Live cluster with the issue :  


For the agent machines :  
172.22.106.218 os-r7-sbhat-ambari-hosts-3-5.openstacklocal os-r7-sbhat-ambari-
hosts-3-5 os-r7-sbhat-ambari-hosts-3-5.openstacklocal.  
172.22.106.217 os-r7-sbhat-ambari-hosts-3-1.openstacklocal os-r7-sbhat-ambari-
hosts-3-1 os-r7-sbhat-ambari-hosts-3-1.openstacklocal.  
172.22.106.216 os-r7-sbhat-ambari-hosts-3-2.openstacklocal os-r7-sbhat-ambari-
hosts-3-2 os-r7-sbhat-ambari-hosts-3-2.openstacklocal.


Diffs
-

  ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b 

Diff: https://reviews.apache.org/r/48410/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48404: Add user home directory verification as part of Service Check

2016-06-08 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48404/#review136624
---


Ship it!




Ship It!

- Nitiraj Rathore


On June 8, 2016, 10:09 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48404/
> ---
> 
> (Updated June 8, 2016, 10:09 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-17113
> https://issues.apache.org/jira/browse/AMBARI-17113
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Leaverage the UserService of common to check the user's home directory.
> - Changed few labels
> 
> 
> Diffs
> -
> 
>   contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 4a45366 
>   contrib/views/hive/pom.xml 1c92f74 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
> 3a7f823 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java
>  ab2b933 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js 
> 5db93f7 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js 
> 05bcbcf 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs 
> 84c7a71 
>   contrib/views/pig/pom.xml 36fb59e 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java
>  40bc9a7 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/HelpService.java
>  eb363a0 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 
> f58d437 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 
> 1d848e3 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 
> d635a91 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/translations.js 072b5c7 
> 
> Diff: https://reviews.apache.org/r/48404/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 48147: Fix metric sink + rename misnamed zk-connect-string variables.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48147/
---

(Updated June 8, 2016, 11:09 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and 
Sid Wagle.


Changes
---

Removed zk-connect-string name fixes.


Bugs: AMBARI-16991
https://issues.apache.org/jira/browse/AMBARI-16991


Repository: ambari


Description (updated)
---

After a recent change the AbstractTimelineMetricsSink class has an abstract 
function called getZookeeperQuorum(). If the extending class is returning null, 
then the sink is not working (neither does it if it returns a valid zookeeper 
connection string). Fixed the first issue, now it is working without a 
zookeeper connect string.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 ca7ccea 

Diff: https://reviews.apache.org/r/48147/diff/


Testing (updated)
---

Tested on local cluster.

ambari-metrics-common:
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Miklos Gergely

Re: Review Request 48332: Log search capability for Nifi



> On June 7, 2016, 1:20 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py,
> >  line 233
> > 
> >
> > Is NiFi being added to Ambari in 2.4?  
> > 
> > If so, is there a patch for those changes being reviewed as well?
> 
> Robert Nettleton wrote:
> I'm dropping this issue, since Jayush explained that NiFi will be defined 
> in a separate management pack eventually. 
> 
> Thanks for the clarification.

It was suggested by Sumit and Jayush:
https://hortonworks.jira.com/browse/BUG-58446


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/#review136456
---


On June 7, 2016, 10:05 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48332/
> ---
> 
> (Updated June 7, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17086
> https://issues.apache.org/jira/browse/AMBARI-17086
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Giving users the ability to deploy a service to their cluster to collect, 
> index, and explore those log files is needed to improve the ease of 
> administration for the operators.
> Add Log search capability for NiFi
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  34583ba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48332/diff/
> 
> 
> Testing
> ---
> 
> Log Seaerch was installed and logs were loaded fine on local cluster with NiFi
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder on a newly installed cluster with log search


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48348/#review136622
---


Ship it!




Ship It!

- Miklos Gergely


On June 7, 2016, 4:06 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48348/
> ---
> 
> (Updated June 7, 2016, 4:06 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17089
> https://issues.apache.org/jira/browse/AMBARI-17089
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Change logfeeder process/files to use sudo user instead of 
> logfeeder/logfeeder user/group (to make sure logfeeder can read any kind of 
> the logs).
> - solr and logsearch user both moved to hadoop group
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  b099a1e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  47cedef 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  1d40ae1 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  46ac4c2 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  7943cd0 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  65dc378 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  73fecb6 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py
>  c0689f3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
>  2b5fdf7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py
>  d0ac389 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py
>  b55f3d6 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  34583ba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  5ca2bd5 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  58239c7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py
>  6e71334 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> c9a8de0 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 54e08e4 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> bfe6921 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 0590dca 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py fd75bf7 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 1015593 
>   ambari-web/app/data/HDP2/site_properties.js 794da25 
> 
> Diff: https://reviews.apache.org/r/48348/diff/
> 
> 
> Testing
> ---
> 
> lot of ambari-server python errors with global name 'is_empty' is nod defined 
> error, but it is not related with my change. logsearch related tests passed.
> 
> FT: tested locally with 4 node cluster.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 48405: [Log Search portal ]Date range on comparison tab are different from date range of selected logs for comparison

2016-06-08 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48405/#review136621
---


Ship it!




Ship It!

- Oliver Szabo


On June 8, 2016, 10:27 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48405/
> ---
> 
> (Updated June 8, 2016, 10:27 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17110
> https://issues.apache.org/jira/browse/AMBARI-17110
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Dates in comparison tab should be carry forwarded from Service logs tab.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/MainLayoutView.js
>  5b69650 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/styles/style.css 
> 4837e5f 
> 
> Diff: https://reviews.apache.org/r/48405/diff/
> 
> 
> Testing
> ---
> 
> Setup Logsearch on 1 node cluster and tested the above feature.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48284/#review136620
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 8, 2016, 10:32 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48284/
> ---
> 
> (Updated Червень 8, 2016, 10:32 до полудня)
> 
> 
> Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17063
> https://issues.apache.org/jira/browse/AMBARI-17063
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a follow-on jira of BUG-53459: when Ambari queries NameNode's HA
> states, currently it retrieves a group of metrics including some unnecessary
> ones that may compete for NameNode lock. It would be better for Ambari to only
> retrieve HA state metrics from NameNode.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
>  a315e5c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java
>  8819991 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
>  4adea20 
>   ambari-server/src/test/resources/hdfs_namenode_jmx_ha_only.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48284/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48284/
---

(Updated June 8, 2016, 10:32 a.m.)


Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.


Bugs: AMBARI-17063
https://issues.apache.org/jira/browse/AMBARI-17063


Repository: ambari


Description
---

This is a follow-on jira of BUG-53459: when Ambari queries NameNode's HA
states, currently it retrieves a group of metrics including some unnecessary
ones that may compete for NameNode lock. It would be better for Ambari to only
retrieve HA state metrics from NameNode.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
 a315e5c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java
 8819991 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
 4adea20 
  ambari-server/src/test/resources/hdfs_namenode_jmx_ha_only.json PRE-CREATION 

Diff: https://reviews.apache.org/r/48284/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48407: [Change log directory prefix for service FLUME] Flume service not starting after changing the log directory


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48407/#review136619
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Червень 8, 2016, 10:29 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48407/
> ---
> 
> (Updated Червень 8, 2016, 10:29 до полудня)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17115
> https://issues.apache.org/jira/browse/AMBARI-17115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Scenario** \- Modify log directory for FLUME (Key - Flume Log Dir)
> 
> Expected - Service Should start successfully  
> Output - Service Failed to start (New log folder was not created )
> 
> 
> 
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
>  line 126, in 
> FlumeHandler().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 681, in restart
> self.start(env, upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
>  line 54, in start
> self.configure(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
>  line 39, in configure
> flume(action='config')
>   File 
> "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, 
> in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py",
>  line 109, in flume
> mode=0755,
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 189, in action_create
> raise Fail("Applying %s failed, parent directory %s doesn't exist" % 
> (self.resource, dirname))
> resource_management.core.exceptions.Fail: Applying 
> Directory['/grid/0/_QE-7627_/_logRMP5891_/FLUME'] failed, parent directory 
> /grid/0/_QE-7627_/_logRMP5891_ doesn't exist
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  9df2ba6 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 964280d 
> 
> Diff: https://reviews.apache.org/r/48407/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 48407: [Change log directory prefix for service FLUME] Flume service not starting after changing the log directory


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48407/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17115
https://issues.apache.org/jira/browse/AMBARI-17115


Repository: ambari


Description
---

**Scenario** \- Modify log directory for FLUME (Key - Flume Log Dir)

Expected - Service Should start successfully  
Output - Service Failed to start (New log folder was not created )




Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
 line 126, in 
FlumeHandler().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 257, in execute
method(env)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 681, in restart
self.start(env, upgrade_type=upgrade_type)
  File 
"/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
 line 54, in start
self.configure(env)
  File 
"/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py",
 line 39, in configure
flume(action='config')
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py",
 line 109, in flume
mode=0755,
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 189, in action_create
raise Fail("Applying %s failed, parent directory %s doesn't exist" % 
(self.resource, dirname))
resource_management.core.exceptions.Fail: Applying 
Directory['/grid/0/_QE-7627_/_logRMP5891_/FLUME'] failed, parent directory 
/grid/0/_QE-7627_/_logRMP5891_ doesn't exist


Diffs
-

  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
 9df2ba6 
  ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 964280d 

Diff: https://reviews.apache.org/r/48407/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48325: Unit tests failing because of the order of hash sets/maps

2016-06-08 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48325/#review136618
---


Ship it!




Ship It!

- Oliver Szabo


On June 7, 2016, 1:02 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48325/
> ---
> 
> (Updated June 7, 2016, 1:02 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17004
> https://issues.apache.org/jira/browse/AMBARI-17004
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some unit tests are failing because they depend on the order elements are 
> returned by the iterator of a HashSet/HashMap. Usually they are small (2-3 
> entries), so they may easily produce good results. Still in other 
> environments they fail as the order the elements are returned from a 
> HashSet/HashMap may depend on the JVM used.
> 
> The issues are elaborated in the comments of the bug.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ChangeRepositoryVersionRequestAuditEvent.java
>  74e7267 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ClusterPrivilegeChangeRequestAuditEvent.java
>  cc59038 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java
>  2f09b74 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java
>  f7a6e36 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java
>  ff4abd6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java
>  ab2b068 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
>  d299fad 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  fbe233d 
> 
> Diff: https://reviews.apache.org/r/48325/diff/
> 
> 
> Testing
> ---
> 
> Tests are running fine now even on my computer which wasn't true before. They 
> failed some times on Jenkins too.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48406: DevDeploy: Ambari server is not started because of invalid config


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48406/#review136617
---


Ship it!




Ship It!

- Andrew Onischuk


On June 8, 2016, 10:12 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48406/
> ---
> 
> (Updated June 8, 2016, 10:12 a.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-17114
> https://issues.apache.org/jira/browse/AMBARI-17114
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ambari-server/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml was 
> broken, and introduced invalid structure:
> 
> ```
> ...
> 
> 
> 
> 
> 
> 
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 7161a48 
> 
> Diff: https://reviews.apache.org/r/48406/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48403/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, 
Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-17112
https://issues.apache.org/jira/browse/AMBARI-17112


Repository: ambari


Description
---

We decided to split changes to stack config xmls and processing of them into 
few patches.
Current patch changes validation rules and available fields

Splitted PropertyUpgradeBehavior into 2 classes.
PropertyAmbariUpgradeBehavior - defines behavior for ambari upgrade.
on-ambari-upgrade now has the same 3 attributes, but all are optional. Default 
value for add is true, false for others.

PropertyStackUpgradeBehavior - defines behavior for stack upgrade.
on-stack-upgrade now has one attribute - add, and it is required.

Modified property update script and xsd schema to satisfy new requirements.

If patch looks good, I'll modify all stack configs to comply with it and commit 
both patches at the same time.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
fba2daa 
  
ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
 de2e342 
  
ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
 de2e342 
  ambari-server/src/main/resources/configuration-schema.xsd d49cbf8 
  
ambari-server/src/main/resources/scripts/configurations-set-default-update-policy.sh
 930f778 
  
ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
 9a3d195 

Diff: https://reviews.apache.org/r/48403/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Review Request 48404: Add user home directory verification as part of Service Check

2016-06-08 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48404/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-17113
https://issues.apache.org/jira/browse/AMBARI-17113


Repository: ambari


Description
---

- Leaverage the UserService of common to check the user's home directory.
- Changed few labels


Diffs
-

  contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 4a45366 
  contrib/views/hive/pom.xml 1c92f74 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
3a7f823 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java
 ab2b933 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js 
5db93f7 
  contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js 
05bcbcf 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs 
84c7a71 
  contrib/views/pig/pom.xml 36fb59e 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java
 40bc9a7 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/HelpService.java
 eb363a0 
  contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 
f58d437 
  contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 1d848e3 
  contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 
d635a91 
  contrib/views/pig/src/main/resources/ui/pig-web/app/translations.js 072b5c7 

Diff: https://reviews.apache.org/r/48404/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136615
---




ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 129)


The tuple of one items should have trailing comma, or else python 
interprets as a single value.

>>> ('item')
'item'
>>> ('item',)
('item',)


- Andrew Onischuk


On June 7, 2016, 12:56 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated June 7, 2016, 12:56 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Daniel Gergely, Oliver Szabo, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installation related information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 48402: ATS needs a dynamic dependency on Tez and Spark