Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/ --- (Updated July 29, 2016, 10:38 p.m.) Review request for Ambari, Alejandro

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/#review144210 --- Ship it! Ship It! - Alejandro Fernandez On July 29, 2016,

Review Request 50616: Coverity Scan Security Vulnerability - SQL injection

2016-07-29 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50616/ --- Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated July 29, 2016, 1:14 p.m.) Review request for Ambari and Alejandro

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan
> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line > > 1132 > > > > > > What happens if the version changes? The version

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated July 29, 2016, 11:56 a.m.) Review request for Ambari and Alejandro

Re: Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing

2016-07-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50554/#review144141 --- Ship it! Ship It! - Alejandro Fernandez On July 28, 2016,

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/#review144139 ---

Re: Review Request 50612: Hive Ranger plug in broken after upgrade to HDP 2.4.0

2016-07-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50612/#review144138 --- Ship it! Ship It! - Alejandro Fernandez On July 29, 2016,

Re: Review Request 50612: Hive Ranger plug in broken after upgrade to HDP 2.4.0

2016-07-29 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50612/ --- (Updated July 29, 2016, 8:43 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 50612: Hive Ranger plug in broken after upgrade to HDP 2.4.0

2016-07-29 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50612/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Dmytro Grinenko
> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java, > > line 73 > > > > > > please use regexp, as > >

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review144131 --- Ship it! Nicely done - Alejandro Fernandez On July 29,

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50606/#review144130 --- Ship it! Ship It! - Alejandro Fernandez On July 29, 2016,

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/ --- (Updated July 29, 2016, 5:19 p.m.) Review request for Ambari, Alejandro

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50606/#review144127 --- Ship it! Ship It! - Dmytro Grinenko On July 29, 2016, 4:16

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Aravindan Vijayan
> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java, > > line 73 > > > > > > please use regexp, as > >

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50606/#review144117 --- Ship it! Ship It! - Dmitro Lisnichenko On July 29, 2016,

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50606/#review144116 --- Ship it! Ship It! - Vitalyi Brodetskyi On Липень 29, 2016,

Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50606/ --- Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Myroslav

Re: Review Request 50605: hadoop.security.* properties should not be set in hive-site.xml (hive-interactive-site)

2016-07-29 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50605/#review144114 --- Ship it! Ship It! - Vitalyi Brodetskyi On Липень 29, 2016,

Re: Review Request 50605: hadoop.security.* properties should not be set in hive-site.xml (hive-interactive-site)

2016-07-29 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50605/#review144113 --- Ship it! Ship It! - Dmytro Grinenko On July 29, 2016, 3:36

Review Request 50605: hadoop.security.* properties should not be set in hive-site.xml (hive-interactive-site)

2016-07-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50605/ --- Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review144098 --- Fix it, then Ship it!

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50532/#review144095 ---

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-29 Thread Mugdha Varadkar
> On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py, > > line 74 > > > > > > I don't think you need the

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-29 Thread Mugdha Varadkar
> On July 28, 2016, 8:10 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml, > > lines 659-665 > > > > > > I think you might be able to use the "modern" here: >

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-29 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/ --- (Updated July 29, 2016, 12:16 p.m.) Review request for Ambari, Alejandro

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Dmytro Grinenko
> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java, > > line 73 > > > > > > please use regexp, as > >

Re: Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing

2016-07-29 Thread Ashwin Rajeev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50554/#review144061 --- Ship it! Ship It! - Ashwin Rajeev On July 28, 2016, 11:37