Re: Review Request 53273: Not able to change the default port ambari server listens to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- (Updated Nov. 1, 2016, 5:39 a.m.) Review request for Ambari, Di Li, Tim

Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53283/ --- (Updated Oct. 31, 2016, 10:33 p.m.) Review request for Ambari, Alejandro

Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53334/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 53334: AMBARI-18758. Livy configuration change for upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53334/ --- (Updated Nov. 1, 2016, 1:52 a.m.) Review request for Ambari, Alejandro

Re: Review Request 53307: ambari-server upgrade fail (from 2.2.2.0/2.4.0.0/2.4.0.1/2.4.1.0 to 2.4.2.0 )

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53307/ --- (Updated Лис. 1, 2016, 1:19 до полудня) Review request for Ambari, Dmytro Sen,

Re: Review Request 53332: Improve wizard styles and apply on Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53332/ --- (Updated Oct. 31, 2016, 5:15 p.m.) Review request for Ambari, Zhe (Joe) Wang,

Re: Review Request 53332: Improve wizard styles and apply on Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53332/#review154351 --- Ship it! Ship It! - Zhe (Joe) Wang On Nov. 1, 2016, 12:04

Review Request 53332: Improve wizard styles and apply on Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53332/ --- Review request for Ambari, Zhe (Joe) Wang and Richard Zang. Repository: ambari

Re: Review Request 53329: DB configs consistency check failed after upgrade from 2.1.1 to 2.4.2 (stack 2.3)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53329/#review154344 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 31, 2016,

Review Request 53329: DB configs consistency check failed after upgrade from 2.1.1 to 2.4.2 (stack 2.3)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53329/ --- Review request for Ambari, Robert Levas, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 53273: Not able to change the default port ambari server listens to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- (Updated Oct. 31, 2016, 8:52 p.m.) Review request for Ambari, Di Li, Tim

Re: Review Request 53273: Not able to change the default port ambari server listens to

> On Oct. 31, 2016, 3:10 p.m., Di Li wrote: > > ambari-server/src/main/python/ambari_server/utils.py, line 150 > > > > > > Use constants and corresponding defaults instead of text > > client.api.port, api.ssl,

Re: Review Request 53312: Popover dialog displays raw html instead of rendering it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53312/#review154315 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 31, 2016, 7:27

Re: Review Request 53211: Ranger Audit Handler not working as expected as NN HA wizard does not set a few properties correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53211/#review154313 --- Ship it! Ship It! - Jaimin Jetly On Oct. 31, 2016, 6:56

Re: Review Request 53265: AMBARI-18729 - Add PDF version of stack, extension and service definitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53265/#review154310 --- Ship it! Ship It! - Di Li On Oct. 31, 2016, 8:10 p.m., Tim

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/ --- (Updated Oct. 31, 2016, 1:10 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53314: Perf: Create PERF stack with mix of HDP core services and dummy services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53314/#review154309 ---

Review Request 53314: Perf: Create PERF stack with mix of HDP core services and dummy services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53314/ --- Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, Sumit

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for HBase, Spark, Spark2, Zeppelin to AmbariPreupload script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53188/#review154304 --- Ship it! Ship It! - Jayush Luniya On Oct. 29, 2016, 4:36

Review Request 53312: Popover dialog displays raw html instead of rendering it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53312/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi Wang,

Re: Review Request 53182: Zeppelin fails to start after deployment due to timing issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53182/#review154303 ---

Re: Review Request 53211: Ranger Audit Handler not working as expected as NN HA wizard does not set a few properties correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53211/ --- (Updated Oct. 31, 2016, 6:56 p.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

> On Oct. 31, 2016, 2:03 p.m., Jonathan Hurley wrote: > > Ship It! Meant to make my comment above "Fix it, then ship it". Othan that that issue, LGTM. - Jonathan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/#review154290 ---

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/#review154294 --- Ship it! Ship It! - Jonathan Hurley On Oct. 31, 2016, 12:29

Re: Review Request 53276: AMBARI-18742: Ambari-server: Stack definition Object Model changes to support tag changes

> On Oct. 31, 2016, 5:47 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java, > > lines 35-39 > > > > > > This is the issue with split reviews. The other

Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53283/#review154286 ---

Re: Review Request 53276: AMBARI-18742: Ambari-server: Stack definition Object Model changes to support tag changes

> On Oct. 31, 2016, 8:47 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java, > > lines 35-39 > > > > > > This is the issue with split reviews. The other

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

> On Oct. 31, 2016, 7:07 a.m., DIPAYAN BHOWMICK wrote: > > Ship It! Thank you Dipayan. Can you please help push the fix. - Sangeeta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

> On Oct. 28, 2016, 4:04 a.m., Di Li wrote: > > Ship It! Thank you Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/#review154096

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review154278 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 28, 2016,

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/ --- (Updated Oct. 31, 2016, 9:29 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review154274 --- This seems dangerous. I think it would be a better option to

Re: Review Request 53307: ambari-server upgrade fail (from 2.2.2.0/2.4.0.0/2.4.0.1/2.4.1.0 to 2.4.2.0 )

> On Жов. 31, 2016, 4:06 після полудня, Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrincipalDAO.java, > > line 132 > > > > > > Why is a merge needed for the remove?

Re: Review Request 53307: ambari-server upgrade fail (from 2.2.2.0/2.4.0.0/2.4.0.1/2.4.1.0 to 2.4.2.0 )

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53307/#review154272 ---

Re: Review Request 53307: ambari-server upgrade fail (from 2.2.2.0/2.4.0.0/2.4.0.1/2.4.1.0 to 2.4.2.0 )

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53307/#review154271 --- Ship it! Ship It! - Robert Levas On Oct. 31, 2016, 11:20

Re: Review Request 53276: AMBARI-18742: Ambari-server: Stack definition Object Model changes to support tag changes

> On Oct. 31, 2016, 8:47 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java, > > lines 35-39 > > > > > > This is the issue with split reviews. The other

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review154268 --- Just a comment/question below about the filtering used here. I

Review Request 53307: ambari-server upgrade fail (from 2.2.2.0/2.4.0.0/2.4.0.1/2.4.1.0 to 2.4.2.0 )

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53307/ --- Review request for Ambari, Dmytro Sen, Robert Levas, and Sumit Mohanty. Bugs:

Re: Review Request 53273: Not able to change the default port ambari server listens to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154267 --- ambari-server/src/main/python/ambari_server/utils.py (line 150)

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

> On Oct. 29, 2016, 6:56 a.m., Jonathan Hurley wrote: > > What about the UpgradeCatalog changes which need to be made? (That's why I > > haven't +1'd yet) > > Nahappan Somasundaram wrote: > Yes, the upgrade catalog is a bug on its own. I'll submit a review for > that soon. > > Nate Cole

Re: Review Request 53276: AMBARI-18742: Ambari-server: Stack definition Object Model changes to support tag changes

> On Oct. 31, 2016, 5:47 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java, > > lines 35-39 > > > > > > This is the issue with split reviews. The other

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/#review154264 --- Ship it! Ship It! - Di Li On Oct. 27, 2016, 9:56 p.m.,

Re: Review Request 53273: Not able to change the default port ambari server listens to

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154262 --- Ship it! Ship It! - Tim Thorpe On Oct. 28, 2016, 9:46 p.m.,

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

> On Oct. 28, 2016, 4:04 a.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js, > > line 98 > > > > > > Will "No messages present" be displayed in the log textarea ? can

Re: Review Request 53300: Ambari Upgrade Failed from 2.4.1 to 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53300/#review154261 --- Ship it! Ship It! - Robert Nettleton On Oct. 31, 2016, 1:04

Re: Review Request 53300: Ambari Upgrade Failed from 2.4.1 to 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53300/#review154258 --- Ship it! Ship It! - Sumit Mohanty On Oct. 31, 2016, 1:04

Re: Review Request 53300: Ambari Upgrade Failed from 2.4.1 to 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53300/#review154257 --- Ship it! Ship It! - Robert Levas On Oct. 31, 2016, 9:04

Review Request 53300: Ambari Upgrade Failed from 2.4.1 to 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53300/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-18747

Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53283/#review154249 ---

Re: Review Request 53276: AMBARI-18742: Ambari-server: Stack definition Object Model changes to support tag changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53276/#review154251 ---

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

> On Oct. 29, 2016, 9:56 a.m., Jonathan Hurley wrote: > > What about the UpgradeCatalog changes which need to be made? (That's why I > > haven't +1'd yet) > > Nahappan Somasundaram wrote: > Yes, the upgrade catalog is a bug on its own. I'll submit a review for > that soon. But why? If

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/#review154241 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Oct. 27, 2016, 9:20