Re: Review Request 55615: Hive View 2.0: Show query logs

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55615/
---

(Updated Jan. 20, 2017, 7:44 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19582
https://issues.apache.org/jira/browse/AMBARI-19582


Repository: ambari


Description
---

UI changes for showing the logs and query results in separate tabs.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js a666b09 
  contrib/views/hive20/src/main/resources/ui/app/components/query-result-log.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 59395e6 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
606b71a 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 723953c 
  contrib/views/hive20/src/main/resources/ui/app/services/query.js 400f78b 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-log.hbs
 PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
2138356 

Diff: https://reviews.apache.org/r/55615/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 55729: Log Search: add snapshot feature to Tours

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55729/#review162391
---


Ship it!




Ship It!

- Miklos Gergely


On Jan. 19, 2017, 8:44 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55729/
> ---
> 
> (Updated Jan. 19, 2017, 8:44 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19634
> https://issues.apache.org/jira/browse/AMBARI-19634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added spnapshot description to tours.
> (also format file)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Tour.js
>  ea9fca0 
> 
> Diff: https://reviews.apache.org/r/55729/diff/
> 
> 
> Testing
> ---
> 
> done, manually.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55718/
---

(Updated Jan. 20, 2017, 5:55 a.m.)


Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19624
https://issues.apache.org/jira/browse/AMBARI-19624


Repository: ambari


Description
---

Added fields to support nofification message and upstream apps in the sla 
componenent and added the necessary mappings to handle the new fields while 
generating xml and importing xml.


Diffs (updated)
-

  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
4cc89ef 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
1929ddf 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
 28bdf15 

Diff: https://reviews.apache.org/r/55718/diff/


Testing
---

Manual


Thanks,

Padma Priya N

Re: Review Request 55733: AMBARI-19637 - No baseURL field on Register Version page if repoinfo.xml contains only one baseurl

[Xi Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55733/#review162380
---


Ship it!




Ship It!

- Xi Wang


On Jan. 19, 2017, 3:26 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55733/
> ---
> 
> (Updated Jan. 19, 2017, 3:26 p.m.)
> 
> 
> Review request for Ambari and Xi Wang.
> 
> 
> Bugs: AMBARI-19637
> https://issues.apache.org/jira/browse/AMBARI-19637
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stop assuming the is always 1 repo url + 1 util url.
> UI Adjustment for repo with any number of urls.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  82c1c40 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
>  ae9850b 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c81b789 
> 
> Diff: https://reviews.apache.org/r/55733/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
> PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.188 secs / 0.404 
> secs)
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55692/#review162379
---


Ship it!




Ship It!

- Jayush Luniya


On Jan. 19, 2017, 10:40 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55692/
> ---
> 
> (Updated Jan. 19, 2017, 10:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19616
> https://issues.apache.org/jira/browse/AMBARI-19616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> (1). Set 'metaspacesize' based on LLAP daemon size
> If LLAP DamoneSize <= 4GB
>  ---> Don't set metaspacesize
> else if LLAP DaemonsSize <=32GB
>  ---> Set to 256m
> else 
>  ---> Set to 1024m (current value)
> 
> (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.
> - Current code add it irrespective of HDP version '--slider-placement' is not 
> valid for option for HDP version less than 2.6.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  6895e34 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  8035be7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9185f78 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  6801d5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml
>  6a68335 
> 
> Diff: https://reviews.apache.org/r/55692/diff/
> 
> 
> Testing
> ---
> 
> Yes, on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 55739: AMBARI-19639. Remove the hardcoding for LLAP app name and read it from config 'llap_app_name'.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55739/#review162373
---


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 20, 2017, 1:01 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55739/
> ---
> 
> (Updated Jan. 20, 2017, 1:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19639
> https://issues.apache.org/jira/browse/AMBARI-19639
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove the hardcoding for LLAP app name and read it from config 
> 'llap_app_name'.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  8035be7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9185f78 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 6531750 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json 10d1d99 
> 
> Diff: https://reviews.apache.org/r/55739/diff/
> 
> 
> Testing
> ---
> 
> Tested on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 55739: AMBARI-19639. Remove the hardcoding for LLAP app name and read it from config 'llap_app_name'.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55739/
---

(Updated Jan. 20, 2017, 1:01 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated patch with Test case fix.


Bugs: AMBARI-19639
https://issues.apache.org/jira/browse/AMBARI-19639


Repository: ambari


Description
---

Remove the hardcoding for LLAP app name and read it from config 'llap_app_name'.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 8035be7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 9185f78 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 6531750 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json 10d1d99 

Diff: https://reviews.apache.org/r/55739/diff/


Testing
---

Tested on cluster.


Thanks,

Swapan Shridhar

Review Request 55739: AMBARI-19639. Remove the hardcoding for LLAP app name and read it from config 'llap_app_name'.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55739/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-19639
https://issues.apache.org/jira/browse/AMBARI-19639


Repository: ambari


Description
---

Remove the hardcoding for LLAP app name and read it from config 'llap_app_name'.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 8035be7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 9185f78 

Diff: https://reviews.apache.org/r/55739/diff/


Testing
---

Tested on cluster.


Thanks,

Swapan Shridhar

Re: Review Request 55737: Improve delete logging for topology artifacts

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55737/#review162370
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 20, 2017, 12:07 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55737/
> ---
> 
> (Updated Jan. 20, 2017, 12:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19638
> https://issues.apache.org/jira/browse/AMBARI-19638
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Very hard to find from Ambari log when a SCH was deleted. We print so much 
> log for all kinds of this, at a minimum all deleted need to be logged.
> 
> Scope: SC, SCH and Host. Make sure we have INFO level log for these.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  444cb85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  17924cd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  62a5bd4 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
> 850e1b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  3c2b582 
> 
> Diff: https://reviews.apache.org/r/55737/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 55737: Improve delete logging for topology artifacts

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55737/#review162369
---


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 20, 2017, 12:07 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55737/
> ---
> 
> (Updated Jan. 20, 2017, 12:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19638
> https://issues.apache.org/jira/browse/AMBARI-19638
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Very hard to find from Ambari log when a SCH was deleted. We print so much 
> log for all kinds of this, at a minimum all deleted need to be logged.
> 
> Scope: SC, SCH and Host. Make sure we have INFO level log for these.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  444cb85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  17924cd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  62a5bd4 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
> 850e1b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  3c2b582 
> 
> Diff: https://reviews.apache.org/r/55737/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

[Amruta Borkar]

> On Jan. 19, 2017, 11:49 p.m., Alejandro Fernandez wrote:
> > Ship It!

Thank you Alejandro, I don't have commit rights on trunk. Could you please help 
me push this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/#review162365
---


On Jan. 19, 2017, 6:16 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53213/
> ---
> 
> (Updated Jan. 19, 2017, 6:16 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert Levas, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18692
> https://issues.apache.org/jira/browse/AMBARI-18692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exporting blueprint from kerberos enabled cluster, exports hardcoded values 
> cluster name and realm in principal_name property.
> When the same blueprint is used to create another cluster with different 
> name, service start fail with following error:
> "resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt 
> /etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned 
> 1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] 
> while getting initial credentials"
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  737e8de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  16f75ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 01c8a89 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  1d330dd 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  d7ae236 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml
>  2be101b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  9efa4f9 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  0ded5d6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  2ab6aa0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  c2f37c1 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  24032fa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  e8a76b6 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  2e5a026 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  fb641a8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  a6f1502 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  47872ee 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  36ebc8c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  a0bd322 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml
>  d267b75 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
>  1bce4e6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
>  b85cf50 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  71a42f7 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  a5115af 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  b78fd79 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
>  5d0b2ff 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  e6c59d5 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml
>  696b28a 
>   ambari-server/src/main/resources/configuration-schema.xsd 17f7393 
> 
> Diff: https://reviews.apache.org/r/53213/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. Suitable keytabs are generated automatically when not 
> 

Review Request 55737: Improve delete logging for topology artifacts

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55737/
---

Review request for Ambari, Myroslav Papirkovskyy and Sumit Mohanty.


Bugs: AMBARI-19638
https://issues.apache.org/jira/browse/AMBARI-19638


Repository: ambari


Description
---

Very hard to find from Ambari log when a SCH was deleted. We print so much log 
for all kinds of this, at a minimum all deleted need to be logged.

Scope: SC, SCH and Host. Make sure we have INFO level log for these.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 444cb85 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 17924cd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 62a5bd4 
  ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
850e1b3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 3c2b582 

Diff: https://reviews.apache.org/r/55737/diff/


Testing
---


Thanks,

Sid Wagle

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55692/#review162367
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 19, 2017, 10:40 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55692/
> ---
> 
> (Updated Jan. 19, 2017, 10:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19616
> https://issues.apache.org/jira/browse/AMBARI-19616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> (1). Set 'metaspacesize' based on LLAP daemon size
> If LLAP DamoneSize <= 4GB
>  ---> Don't set metaspacesize
> else if LLAP DaemonsSize <=32GB
>  ---> Set to 256m
> else 
>  ---> Set to 1024m (current value)
> 
> (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.
> - Current code add it irrespective of HDP version '--slider-placement' is not 
> valid for option for HDP version less than 2.6.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  6895e34 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  8035be7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9185f78 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  6801d5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml
>  6a68335 
> 
> Diff: https://reviews.apache.org/r/55692/diff/
> 
> 
> Testing
> ---
> 
> Yes, on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/#review162365
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 19, 2017, 6:16 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53213/
> ---
> 
> (Updated Jan. 19, 2017, 6:16 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert Levas, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18692
> https://issues.apache.org/jira/browse/AMBARI-18692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exporting blueprint from kerberos enabled cluster, exports hardcoded values 
> cluster name and realm in principal_name property.
> When the same blueprint is used to create another cluster with different 
> name, service start fail with following error:
> "resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt 
> /etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned 
> 1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] 
> while getting initial credentials"
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  737e8de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  16f75ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 01c8a89 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  1d330dd 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  d7ae236 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml
>  2be101b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  9efa4f9 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  0ded5d6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  2ab6aa0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  c2f37c1 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  24032fa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  e8a76b6 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  2e5a026 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  fb641a8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  a6f1502 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  47872ee 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  36ebc8c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  a0bd322 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml
>  d267b75 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
>  1bce4e6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
>  b85cf50 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  71a42f7 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  a5115af 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  b78fd79 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
>  5d0b2ff 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  e6c59d5 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml
>  696b28a 
>   ambari-server/src/main/resources/configuration-schema.xsd 17f7393 
> 
> Diff: https://reviews.apache.org/r/53213/diff/
> 
> 
> Testing
> ---
> 
> Tested manually. Suitable keytabs are generated automatically when not 
> mentioned in blueprint. Service starts succeeded with a blueprint exported 
> with the code change. 
> Modified existing unit test cases.
> 
> 

Re: Review Request 55733: AMBARI-19637 - No baseURL field on Register Version page if repoinfo.xml contains only one baseurl

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55733/#review162364
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 19, 2017, 11:26 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55733/
> ---
> 
> (Updated Jan. 19, 2017, 11:26 p.m.)
> 
> 
> Review request for Ambari and Xi Wang.
> 
> 
> Bugs: AMBARI-19637
> https://issues.apache.org/jira/browse/AMBARI-19637
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stop assuming the is always 1 repo url + 1 util url.
> UI Adjustment for repo with any number of urls.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  82c1c40 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
>  ae9850b 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c81b789 
> 
> Diff: https://reviews.apache.org/r/55733/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
> PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.188 secs / 0.404 
> secs)
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 55733: AMBARI-19637 - No baseURL field on Register Version page if repoinfo.xml contains only one baseurl

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55733/
---

Review request for Ambari and Xi Wang.


Bugs: AMBARI-19637
https://issues.apache.org/jira/browse/AMBARI-19637


Repository: ambari


Description
---

Stop assuming the is always 1 repo url + 1 util url.
UI Adjustment for repo with any number of urls.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 82c1c40 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
 ae9850b 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c81b789 

Diff: https://reviews.apache.org/r/55733/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.188 secs / 0.404 secs)


Thanks,

Richard Zang

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55717/#review162358
---



The patches fix the problem with starting Zeppelin without Hive.

However, the [patch against 
trunk](https://issues.apache.org/jira/secure/attachment/12848330/AMBARI-19627-trunk-v2.patch)
 has problems with the unit tests.

1. The methods where `@patch` is added need an extra parameter declared for the 
mock object.

```
TypeError: assert_configure_default() takes exactly 1 argument (2 given)
TypeError: assert_configure_secured() takes exactly 1 argument (2 given)
```

2. Even after adding the missing parameters to the two methods, the unit tests 
fail:

```
FAIL: test_configure_secured (test_zeppelin_master.TestZeppelinMaster)
...
AssertionError: There were no more resources executed!

FAIL: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
...
AssertionError: There were no more resources executed!

FAIL: test_start_default (test_zeppelin_master.TestZeppelinMaster)
...
AssertionError: 'File' != 'Execute'

FAIL: test_start_secured (test_zeppelin_master.TestZeppelinMaster)
...
AssertionError: 'File' != 'Execute'
```

The tests pass after manually creating `/etc/spark/conf/hive-site.xml`.  It 
doesn't seem like the mocked `os.path.exists` check is working as expected.

- Attila Doroszlai


On Jan. 19, 2017, 4:58 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55717/
> ---
> 
> (Updated Jan. 19, 2017, 4:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19627
> https://issues.apache.org/jira/browse/AMBARI-19627
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive is a dependency only for Spark ThriftServer, not for other Spark 
> components or Zeppelin. Yet, Zeppelin fails to start if Hive is not installed:
> 
> Error:
> resource_management.core.exceptions.Fail: 
> StaticFile('/etc/spark/conf/hive-site.xml') Source file 
> /etc/spark/conf/hive-site.xml is not found
> 
> 
> This review is for branch-2.5 patch. There is a separate patch attached in 
> jira for trunk.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  ac56aa2 
> 
> Diff: https://reviews.apache.org/r/55717/diff/
> 
> 
> Testing
> ---
> 
> tested on CentOS and passed unit tests on trunk
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

[Amruta Borkar]

> On Jan. 19, 2017, 7:24 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml,
> >  line 75
> > 
> >
> > This is also needed in ZK 3.4.9

Hello Alejandro,
I am not seeing any configuration xml file in ZK 3.4.9 . I only see 
metainfo.xml and stack_advisor.py . There fore don't see any Kerberos principal 
name property. Is there anything I am missing?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/#review162335
---


On Jan. 19, 2017, 6:16 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53213/
> ---
> 
> (Updated Jan. 19, 2017, 6:16 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert Levas, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18692
> https://issues.apache.org/jira/browse/AMBARI-18692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exporting blueprint from kerberos enabled cluster, exports hardcoded values 
> cluster name and realm in principal_name property.
> When the same blueprint is used to create another cluster with different 
> name, service start fail with following error:
> "resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt 
> /etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned 
> 1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] 
> while getting initial credentials"
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  737e8de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  16f75ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 01c8a89 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  1d330dd 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  d7ae236 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml
>  2be101b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  9efa4f9 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  0ded5d6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  2ab6aa0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  c2f37c1 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  24032fa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  e8a76b6 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  2e5a026 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  fb641a8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  a6f1502 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  47872ee 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  36ebc8c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  a0bd322 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml
>  d267b75 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
>  1bce4e6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
>  b85cf50 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  71a42f7 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  a5115af 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  b78fd79 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
>  5d0b2ff 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  e6c59d5 
>   
> 

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

[Swapan Shridhar]

> On Jan. 19, 2017, 8:29 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 285
> > 
> >
> > Please don't hard code HDP version, add a stack feature instead (say 
> > hive_interactive_ga). 
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json

Done.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55692/#review162255
---


On Jan. 19, 2017, 10:40 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55692/
> ---
> 
> (Updated Jan. 19, 2017, 10:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19616
> https://issues.apache.org/jira/browse/AMBARI-19616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> (1). Set 'metaspacesize' based on LLAP daemon size
> If LLAP DamoneSize <= 4GB
>  ---> Don't set metaspacesize
> else if LLAP DaemonsSize <=32GB
>  ---> Set to 256m
> else 
>  ---> Set to 1024m (current value)
> 
> (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.
> - Current code add it irrespective of HDP version '--slider-placement' is not 
> valid for option for HDP version less than 2.6.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  6895e34 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  8035be7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9185f78 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  6801d5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml
>  6a68335 
> 
> Diff: https://reviews.apache.org/r/55692/diff/
> 
> 
> Testing
> ---
> 
> Yes, on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55692/
---

(Updated Jan. 19, 2017, 10:40 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Incorporated Jayush' suggestion.


Bugs: AMBARI-19616
https://issues.apache.org/jira/browse/AMBARI-19616


Repository: ambari


Description
---

(1). Set 'metaspacesize' based on LLAP daemon size
If LLAP DamoneSize <= 4GB
 ---> Don't set metaspacesize
else if LLAP DaemonsSize <=32GB
 ---> Set to 256m
else 
 ---> Set to 1024m (current value)

(2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.
- Current code add it irrespective of HDP version '--slider-placement' is not 
valid for option for HDP version less than 2.6.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 6895e34 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 8035be7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 9185f78 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 6801d5a 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml
 6a68335 

Diff: https://reviews.apache.org/r/55692/diff/


Testing
---

Yes, on cluster.


Thanks,

Swapan Shridhar

Re: Review Request 55700: Ranger load balancer url needs to be updated for dependent properties during HA

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55700/#review162348
---


Ship it!




Ship It!

- Jaimin Jetly


On Jan. 19, 2017, 2:39 a.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55700/
> ---
> 
> (Updated Jan. 19, 2017, 2:39 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19619
> https://issues.apache.org/jira/browse/AMBARI-19619
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger HA wizard should also update the Ranger load balancer url to dependent 
> plugin configs.
> 
> ranger.plugin.hdfs.policy.rest.url/ranger-hdfs-security
> ranger.plugin.yarn.policy.rest.url/ranger-yarn-security
> ranger.plugin.hbase.policy.rest.url/ranger-hbase-security
> ranger.plugin.hive.policy.rest.url/ranger-hive-security
> ranger.plugin.knox.policy.rest.url/ranger-knox-security
> ranger.plugin.kafka.policy.rest.url/ranger-kafka-security
> ranger.plugin.kms.policy.rest.url/ranger-kms-security
> ranger.plugin.storm.policy.rest.url/ranger-storm-security
> ranger.plugin.atlas.policy.rest.url/ranger-atlas-security
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js
>  b7818d9 
>   ambari-web/app/messages.js a2a2fbf 
> 
> Diff: https://reviews.apache.org/r/55700/diff/
> 
> 
> Testing
> ---
> 
> Verified Manually.
> Ambari-web unit tests pass.
> 30297 passing (24s)
> 157 pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 55729: Log Search: add snapshot feature to Tours

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55729/#review162345
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 19, 2017, 8:44 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55729/
> ---
> 
> (Updated Jan. 19, 2017, 8:44 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19634
> https://issues.apache.org/jira/browse/AMBARI-19634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added spnapshot description to tours.
> (also format file)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Tour.js
>  ea9fca0 
> 
> Diff: https://reviews.apache.org/r/55729/diff/
> 
> 
> Testing
> ---
> 
> done, manually.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 55729: Log Search: add snapshot feature to Tours

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55729/
---

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-19634
https://issues.apache.org/jira/browse/AMBARI-19634


Repository: ambari


Description
---

added spnapshot description to tours.
(also format file)


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Tour.js 
ea9fca0 

Diff: https://reviews.apache.org/r/55729/diff/


Testing
---

done, manually.


Thanks,

Oliver Szabo

Re: Review Request 55728: accordion classname missed on configs page

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55728/#review162343
---


Ship it!




Ship It!

- Denys Buzhor


On Jan. 19, 2017, 8:21 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55728/
> ---
> 
> (Updated Jan. 19, 2017, 8:21 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: AMBARI-19633
> https://issues.apache.org/jira/browse/AMBARI-19633
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> accordion classname missed on configs page
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/config_category_container_view.js 
> 73ded75 
> 
> Diff: https://reviews.apache.org/r/55728/diff/
> 
> 
> Testing
> ---
> 
> 20307 passing (28s)
>   153 pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Review Request 55728: accordion classname missed on configs page

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55728/
---

Review request for Ambari and Denys Buzhor.


Bugs: AMBARI-19633
https://issues.apache.org/jira/browse/AMBARI-19633


Repository: ambari


Description
---

accordion classname missed on configs page


Diffs
-

  ambari-web/app/views/common/configs/config_category_container_view.js 73ded75 

Diff: https://reviews.apache.org/r/55728/diff/


Testing
---

20307 passing (28s)
  153 pending


Thanks,

Aleksandr Kovalenko

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55698/#review162342
---


Ship it!




Ship It!

- Nate Cole


On Jan. 19, 2017, 2:03 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55698/
> ---
> 
> (Updated Jan. 19, 2017, 2:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19617
> https://issues.apache.org/jira/browse/AMBARI-19617
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While attempting to restart a component that has complicated upgrade logic, 
> the upgrade parameters are not sent to the agents. This can cause some 
> components to fails during a suspended upgrade restart. 
> 
> Example:
> 
> - Begin express upgrade from {{2.3.6.0-3796}} to {{2.5.3.0-37}}
> - {{HIVE_METASTORE}} couldn't start b/c of a missing Kerberos property:
> {code}
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'hive.server2.authentication.kerberos.principal' was not found in 
> configurations dictionary!
> {code}
> - Chose to {{Ignore and Proceed}} which means that none of the Metastore SQL 
> files ran. 
> - Paused the upgrade (presumably at Finalize) and try to start Metastore. It 
> fails to start because the new HDP 2.5 bits are using a non-upgraded 
> database. That causes the {{-info}} option to fail and makes Ambari think it 
> needs to run {{-initSchema}}. 
> 
> RCA: Metastore failed to start during upgrade and the admin chose to skip it. 
> This caused schema upgrade logic not to run. Ambari can examine the 
> {{upgrade_suspended}} property to determine if we need to run upgrade 
> commands while restarting Metastore during an upgrade. 
> 
> However, it might be more prudent to simply send along the suspended upgrade 
> properties so that any actions which might need to happen (such as invoking 
> an upgrade script during the restart) can happen when the upgrade is 
> suspended.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  ec0f7d0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  bdad015 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5e8c803 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  2ec43cf 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 4e37c92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  1d51b0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContextFactory.java
>  4b988e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  7b0b696 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  9693f98 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
>  5cce3fc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
>  fd96c8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
>  cc0f2b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  526e462 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  0d1a2fa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
>  f7f8325 
> 
> Diff: https://reviews.apache.org/r/55698/diff/
> 
> 
> Testing
> ---
> 
> Tested restarts during a suspended upgrade for Metastore.
> 
> Tests run: 4864, Failures: 0, Errors: 0, Skipped: 38
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:24 min
> [INFO] Finished at: 2017-01-19T10:53:14-05:00
> [INFO] Final Memory: 57M/678M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 55643: Blueprint installation should accept quick link profile

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55643/#review162341
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 19, 2017, 8:49 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55643/
> ---
> 
> (Updated Jan. 19, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, 
> Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19597
> https://issues.apache.org/jira/browse/AMBARI-19597
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Specifying the quick links profile should be supported in blueprint based 
> cluster installation. First implementation will address the possibility of 
> adding the profile to the cluster creation template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5e8c803 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  cb30f2d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a35da86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
>  d784a22 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
>  a1267df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
>  c551830 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
>  c9ac6b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java
>  26819e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
>  a3ae677 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
>  7724852 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  7db07a0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  2cf478a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java
>  8c723c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  7e6e5a3 
> 
> Diff: https://reviews.apache.org/r/55643/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run the unit test suite for ambari-server. No failures.
> - Covered the following cases by manual testing:
>-- Installing a cluster via blueprint, quick links profile in the cluster 
> creation template, profile saved the first time
>-- Installing a cluster via blueprint, quick links profile in the cluster 
> creation template, there was an existing quick links profile which was 
> overwritten during cluster installation
>-- Installing a cluster via blueprint, no quick links profile in the 
> cluster creation template
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 53686: Stage and Request status should be persisted in the database

[Jaimin Jetly]

On Dec. 15, 2016, 4:49 p.m., Jaimin Jetly wrote:
> > One thing I don't quite see here (and it could be due to the size of the 
> > patch) is what happens in these two cases:
> > - Something goes wrong when trying to store a task's status. How does the 
> > system recover and mark it completed?
> > - What about waiting until a request is HOLDING and then restarting Ambari 
> > - will the relevent maps get re-populated?
> 
> Jaimin Jetly wrote:
> >> - Something goes wrong when trying to store a task's status. How does 
> the system recover and mark it completed?
> 
> This work only adds logic to add/update stage and request status. The way 
> task status is being updated or the logic for system to recover from anything 
> that goes wrong when storing task status is not changed.
> This work ensures that task status update, respective stage status update 
> and respective request status update happens inside same transactional 
> boundary. Thus all three entities remains consistent in the status they show. 
> This work does not add any recovery logic and piggybacks on existing 
> failure recovery mechanism for updating task status. Thus if something goes 
> wrong storing task status then stage/request status will also be not store 
> and vice-versa. Next time when ambari-agent sends command reports again then 
> task update and respective stage/request status update should also also get 
> updated successfully. 
> 
> >> -  What about waiting until a request is HOLDING and then restarting 
> Ambari - will the relevent maps get re-populated?
> 
> Yes, everytime ambari-server starts, we check for all stages in 
> HostRoleStatus.IN_PROGRESS_STATUSES and publish an event with the tasks. 
> these will repopulate the maps. The patch adds that logic with 
> "publishInProgressTasks(stages)" method in ActionScheduler.java
> 
> I have tested that scenario of restarting ambari-server when a request is 
> ongoing with in progress tasks and validating that stages and requests status 
> is correctly updated
> 
> Sid Wagle wrote:
> The agent re-sending command reports are we generally fault tolerant in 
> that area? Sicne you are probably mostly up-to-date on that part of the code 
> can you shed some light on loss of task status scenario. Do we recover the 
> correct status?

Yes. Largely. 
Although There are following specific cases:
1) If persisting of "request, it's stages and it's host role commands" for the 
first time does not happen then the request will be completely missed and 
ambari-server will never log in the database or track it in anyways.
2) If "request, it's stages and it's host role commands" are persisted but 
subsequent updates and DB merge keeps failing then request will be eventually 
declared timeout and so will all hrcs

As far as DB merge from subsequent agent command reports is successfully 
committed to DB, earlier failures will be recovered.


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53686/#review159315
---


On Jan. 18, 2017, 10:33 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53686/
> ---
> 
> (Updated Jan. 18, 2017, 10:33 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-18868
> https://issues.apache.org/jira/browse/AMBARI-18868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stage and Request status should be persisted in the database.
> 
> upgrading to ambari-3.0.0 should add status for all present stages and 
> request for the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  7837a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  dabcb98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java
>  3656bfe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java
>  31e11c1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> 4a05b32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
>  3c415df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java
>  

Re: Review Request 55643: Blueprint installation should accept quick link profile

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55643/
---

(Updated Jan. 19, 2017, 7:49 p.m.)


Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, 
Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

Fixed imports


Bugs: AMBARI-19597
https://issues.apache.org/jira/browse/AMBARI-19597


Repository: ambari


Description
---

Specifying the quick links profile should be supported in blueprint based 
cluster installation. First implementation will address the possibility of 
adding the profile to the cluster creation template.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 5e8c803 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 cb30f2d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 a35da86 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
 d784a22 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
 a1267df 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
 c551830 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
 c9ac6b4 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java
 26819e1 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 a3ae677 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
 7724852 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 7db07a0 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 2cf478a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java
 8c723c9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 7e6e5a3 

Diff: https://reviews.apache.org/r/55643/diff/


Testing
---

- Wrote new unit tests
- Run the unit test suite for ambari-server. No failures.
- Covered the following cases by manual testing:
   -- Installing a cluster via blueprint, quick links profile in the cluster 
creation template, profile saved the first time
   -- Installing a cluster via blueprint, quick links profile in the cluster 
creation template, there was an existing quick links profile which was 
overwritten during cluster installation
   -- Installing a cluster via blueprint, no quick links profile in the cluster 
creation template


Thanks,

Balázs Bence Sári

Re: Review Request 55643: Blueprint installation should accept quick link profile

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55643/
---

(Updated Jan. 19, 2017, 7:43 p.m.)


Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, 
Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

Removed TimeSource


Bugs: AMBARI-19597
https://issues.apache.org/jira/browse/AMBARI-19597


Repository: ambari


Description
---

Specifying the quick links profile should be supported in blueprint based 
cluster installation. First implementation will address the possibility of 
adding the profile to the cluster creation template.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 5e8c803 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 cb30f2d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
 a35da86 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
 d784a22 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
 a1267df 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
 c551830 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
 c9ac6b4 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java
 26819e1 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 a3ae677 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
 7724852 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 7db07a0 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
 2cf478a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java
 8c723c9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 7e6e5a3 

Diff: https://reviews.apache.org/r/55643/diff/


Testing
---

- Wrote new unit tests
- Run the unit test suite for ambari-server. No failures.
- Covered the following cases by manual testing:
   -- Installing a cluster via blueprint, quick links profile in the cluster 
creation template, profile saved the first time
   -- Installing a cluster via blueprint, quick links profile in the cluster 
creation template, there was an existing quick links profile which was 
overwritten during cluster installation
   -- Installing a cluster via blueprint, no quick links profile in the cluster 
creation template


Thanks,

Balázs Bence Sári

Re: Review Request 55663: Add support for call context to the stack advisor

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55663/#review162336
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 18, 2017, 5:54 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55663/
> ---
> 
> (Updated Jan. 18, 2017, 5:54 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Swapan Shridhar, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19546
> https://issues.apache.org/jira/browse/AMBARI-19546
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add support for call context to the stack advisor. This is a limited 
> enhancements to differentiate between basic contenxts. Most importantly 
> cluster create vs config edit vs add service and calls to get only the 
> attributes.
> 
> Two key changes:
> Differentiate between recommendComponentLayout, validateComponentLayout, 
> recommendConfigurations, recommendConfigurationDependencies, and 
> validateConfigurations. The key ones to differentiate are 
> recommendConfigurations and recommendConfigurationDependencies. This change 
> is committed already.
> 
> Second is to distinguish between, clusterCreate, addService, and 
> computeAttribute. All three are recommendConfigurations calls. Why it 
> matters? During clusterCreate, stack advisor is free to compute any config 
> properties it can. However, during addService and computeAttributes it should 
> use supplied configs and then compute only what is needed.
> 
> The patch has changes for blueprint deployments and the infra for UI to add 
> the context as needed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
>  67dfded 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  b804c7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  6f612af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
>  0ad9126 
>   ambari-server/src/main/resources/properties.json b7e0988 
>   ambari-server/src/main/resources/scripts/stack_advisor.py 56bd34a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 968a94f 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 6b29bc3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
>  e3b89b8 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> f39703c 
> 
> Diff: https://reviews.apache.org/r/55663/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests (python and java locally)
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/#review162335
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml
 (line 75)


This is also needed in ZK 3.4.9


- Alejandro Fernandez


On Jan. 19, 2017, 6:16 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53213/
> ---
> 
> (Updated Jan. 19, 2017, 6:16 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert Levas, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18692
> https://issues.apache.org/jira/browse/AMBARI-18692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exporting blueprint from kerberos enabled cluster, exports hardcoded values 
> cluster name and realm in principal_name property.
> When the same blueprint is used to create another cluster with different 
> name, service start fail with following error:
> "resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt 
> /etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned 
> 1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] 
> while getting initial credentials"
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  737e8de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  16f75ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 01c8a89 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  1d330dd 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  d7ae236 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml
>  2be101b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  9efa4f9 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  0ded5d6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  2ab6aa0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  c2f37c1 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  24032fa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  e8a76b6 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  2e5a026 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  fb641a8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  a6f1502 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  47872ee 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  36ebc8c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  a0bd322 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml
>  d267b75 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
>  1bce4e6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
>  b85cf50 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  71a42f7 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  a5115af 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  b78fd79 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
>  5d0b2ff 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  e6c59d5 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml
>  696b28a 
>   ambari-server/src/main/resources/configuration-schema.xsd 17f7393 
> 
> Diff: https://reviews.apache.org/r/53213/diff/
> 
> 
> Testing
> ---
> 
> Tested 

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55698/#review162334
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 19, 2017, 7:03 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55698/
> ---
> 
> (Updated Jan. 19, 2017, 7:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19617
> https://issues.apache.org/jira/browse/AMBARI-19617
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While attempting to restart a component that has complicated upgrade logic, 
> the upgrade parameters are not sent to the agents. This can cause some 
> components to fails during a suspended upgrade restart. 
> 
> Example:
> 
> - Begin express upgrade from {{2.3.6.0-3796}} to {{2.5.3.0-37}}
> - {{HIVE_METASTORE}} couldn't start b/c of a missing Kerberos property:
> {code}
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'hive.server2.authentication.kerberos.principal' was not found in 
> configurations dictionary!
> {code}
> - Chose to {{Ignore and Proceed}} which means that none of the Metastore SQL 
> files ran. 
> - Paused the upgrade (presumably at Finalize) and try to start Metastore. It 
> fails to start because the new HDP 2.5 bits are using a non-upgraded 
> database. That causes the {{-info}} option to fail and makes Ambari think it 
> needs to run {{-initSchema}}. 
> 
> RCA: Metastore failed to start during upgrade and the admin chose to skip it. 
> This caused schema upgrade logic not to run. Ambari can examine the 
> {{upgrade_suspended}} property to determine if we need to run upgrade 
> commands while restarting Metastore during an upgrade. 
> 
> However, it might be more prudent to simply send along the suspended upgrade 
> properties so that any actions which might need to happen (such as invoking 
> an upgrade script during the restart) can happen when the upgrade is 
> suspended.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  ec0f7d0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  bdad015 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5e8c803 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  2ec43cf 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 4e37c92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  1d51b0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContextFactory.java
>  4b988e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  7b0b696 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  9693f98 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
>  5cce3fc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
>  fd96c8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
>  cc0f2b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  526e462 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  0d1a2fa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
>  f7f8325 
> 
> Diff: https://reviews.apache.org/r/55698/diff/
> 
> 
> Testing
> ---
> 
> Tested restarts during a suspended upgrade for Metastore.
> 
> Tests run: 4864, Failures: 0, Errors: 0, Skipped: 38
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:24 min
> [INFO] Finished at: 2017-01-19T10:53:14-05:00
> [INFO] Final Memory: 57M/678M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 55609: Add Livy session recovery configurations in Ambari

[bikas]

> On Jan. 18, 2017, 8:59 p.m., bikassaha wrote:
> > Should the URL for recovery be something like 
> > /apps/{livy|spark}/livy-recovery? Having /livy-recovery as a top level HDFS 
> > dir seems distracting.
> 
> Saisai Shao wrote:
> It will not be in the top level HDFS dirs. It will be in User livy's 
> current home directory, which is "/user/livy/livy-recovery".

My suggestion would be to change that to /apps/spark where such system data 
tends to go for other apps. That would be the convention. What do the Ambari 
folks think? Of course my understanding of existing convention might be wrong 
:) In which case /user/livy/ is also ok.


- bikassaha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55609/#review162240
---


On Jan. 17, 2017, 6:25 p.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55609/
> ---
> 
> (Updated Jan. 17, 2017, 6:25 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19577
> https://issues.apache.org/jira/browse/AMBARI-19577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy session recovery configurations in Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml
>  b7bfa73 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/livy2-conf.xml
>  457869d 
> 
> Diff: https://reviews.apache.org/r/55609/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55698/
---

(Updated Jan. 19, 2017, 2:03 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.


Bugs: AMBARI-19617
https://issues.apache.org/jira/browse/AMBARI-19617


Repository: ambari


Description
---

While attempting to restart a component that has complicated upgrade logic, the 
upgrade parameters are not sent to the agents. This can cause some components 
to fails during a suspended upgrade restart. 

Example:

- Begin express upgrade from {{2.3.6.0-3796}} to {{2.5.3.0-37}}
- {{HIVE_METASTORE}} couldn't start b/c of a missing Kerberos property:
{code}
resource_management.core.exceptions.Fail: Configuration parameter 
'hive.server2.authentication.kerberos.principal' was not found in 
configurations dictionary!
{code}
- Chose to {{Ignore and Proceed}} which means that none of the Metastore SQL 
files ran. 
- Paused the upgrade (presumably at Finalize) and try to start Metastore. It 
fails to start because the new HDP 2.5 bits are using a non-upgraded database. 
That causes the {{-info}} option to fail and makes Ambari think it needs to run 
{{-initSchema}}. 

RCA: Metastore failed to start during upgrade and the admin chose to skip it. 
This caused schema upgrade logic not to run. Ambari can examine the 
{{upgrade_suspended}} property to determine if we need to run upgrade commands 
while restarting Metastore during an upgrade. 

However, it might be more prudent to simply send along the suspended upgrade 
properties so that any actions which might need to happen (such as invoking an 
upgrade script during the restart) can happen when the upgrade is suspended.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 ec0f7d0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 bdad015 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 5e8c803 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 2ec43cf 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
4e37c92 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
1d51b0d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContextFactory.java
 4b988e8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 7b0b696 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 9693f98 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
 5cce3fc 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
 fd96c8e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 cc0f2b6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
 526e462 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 0d1a2fa 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
 f7f8325 

Diff: https://reviews.apache.org/r/55698/diff/


Testing
---

Tested restarts during a suspended upgrade for Metastore.

Tests run: 4864, Failures: 0, Errors: 0, Skipped: 38

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 26:24 min
[INFO] Finished at: 2017-01-19T10:53:14-05:00
[INFO] Final Memory: 57M/678M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/#review162329
---


Ship it!




Ship It!

- Alejandro Fernandez


On Jan. 19, 2017, 5:59 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55724/
> ---
> 
> (Updated Jan. 19, 2017, 5:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19629
> https://issues.apache.org/jira/browse/AMBARI-19629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Extract `create_metastore_schema()`, call it from `start()` instead of 
> `configure()`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  16273c77b2bf4affb4b53f33e5eb40f0e9a1122c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  d1ecd6593b4926fe39de11f81a101409ad14a13d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 0a98894bfe74eb53684c6aaef77511b950bb776d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> f9e910b8bfed478e0419a30230cbc60b71f12e0a 
> 
> Diff: https://reviews.apache.org/r/55724/diff/
> 
> 
> Testing
> ---
> 
> Manual test: install cluster via blueprint, verify Hive Metastore starts 
> successfully.
> 
> Unit tests:
> 
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] Ambari Server . SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/#review162328
---


Ship it!




Ship It!

- Jonathan Hurley


On Jan. 19, 2017, 12:59 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55724/
> ---
> 
> (Updated Jan. 19, 2017, 12:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19629
> https://issues.apache.org/jira/browse/AMBARI-19629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Extract `create_metastore_schema()`, call it from `start()` instead of 
> `configure()`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  16273c77b2bf4affb4b53f33e5eb40f0e9a1122c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  d1ecd6593b4926fe39de11f81a101409ad14a13d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 0a98894bfe74eb53684c6aaef77511b950bb776d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> f9e910b8bfed478e0419a30230cbc60b71f12e0a 
> 
> Diff: https://reviews.apache.org/r/55724/diff/
> 
> 
> Testing
> ---
> 
> Manual test: install cluster via blueprint, verify Hive Metastore starts 
> successfully.
> 
> Unit tests:
> 
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] Ambari Server . SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/#review162326
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 19, 2017, 6:59 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55724/
> ---
> 
> (Updated Jan. 19, 2017, 6:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19629
> https://issues.apache.org/jira/browse/AMBARI-19629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Extract `create_metastore_schema()`, call it from `start()` instead of 
> `configure()`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  16273c77b2bf4affb4b53f33e5eb40f0e9a1122c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  d1ecd6593b4926fe39de11f81a101409ad14a13d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 0a98894bfe74eb53684c6aaef77511b950bb776d 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> f9e910b8bfed478e0419a30230cbc60b71f12e0a 
> 
> Diff: https://reviews.apache.org/r/55724/diff/
> 
> 
> Testing
> ---
> 
> Manual test: install cluster via blueprint, verify Hive Metastore starts 
> successfully.
> 
> Unit tests:
> 
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] Ambari Server . SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

[Jonathan Hurley]

> On Jan. 19, 2017, 1:04 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
> >  lines 2456-2460
> > 
> >
> > This pattern is used at least 3 times - should we just get this from 
> > the cluster itself?  A method that goes with cluster.isUpgradeSuspended()?  
> > We also have a mix of upgradeContext.getInitializedCommandParams() and the 
> > key for suspended when they should just all be put on together.

Sure - I can refactor this to be reused.


> On Jan. 19, 2017, 1:04 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java,
> >  lines 283-286
> > 
> >
> > Can you mark this variable with 
> > @Experimental(ExperimentalFeature.PATCH_UPGRADES) ?  Will make it easier to 
> > find when we merge.

Will Do!


> On Jan. 19, 2017, 1:04 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java,
> >  lines 641-647
> > 
> >
> > These links don't exist anymore?

Hah! Right! I had moved them when I realized we need a central place. I'll 
update the doc.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55698/#review162322
---


On Jan. 19, 2017, 11:54 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55698/
> ---
> 
> (Updated Jan. 19, 2017, 11:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19617
> https://issues.apache.org/jira/browse/AMBARI-19617
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While attempting to restart a component that has complicated upgrade logic, 
> the upgrade parameters are not sent to the agents. This can cause some 
> components to fails during a suspended upgrade restart. 
> 
> Example:
> 
> - Begin express upgrade from {{2.3.6.0-3796}} to {{2.5.3.0-37}}
> - {{HIVE_METASTORE}} couldn't start b/c of a missing Kerberos property:
> {code}
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'hive.server2.authentication.kerberos.principal' was not found in 
> configurations dictionary!
> {code}
> - Chose to {{Ignore and Proceed}} which means that none of the Metastore SQL 
> files ran. 
> - Paused the upgrade (presumably at Finalize) and try to start Metastore. It 
> fails to start because the new HDP 2.5 bits are using a non-upgraded 
> database. That causes the {{-info}} option to fail and makes Ambari think it 
> needs to run {{-initSchema}}. 
> 
> RCA: Metastore failed to start during upgrade and the admin chose to skip it. 
> This caused schema upgrade logic not to run. Ambari can examine the 
> {{upgrade_suspended}} property to determine if we need to run upgrade 
> commands while restarting Metastore during an upgrade. 
> 
> However, it might be more prudent to simply send along the suspended upgrade 
> properties so that any actions which might need to happen (such as invoking 
> an upgrade script during the restart) can happen when the upgrade is 
> suspended.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  ec0f7d0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  bdad015 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5e8c803 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  2ec43cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  1d51b0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContextFactory.java
>  4b988e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  9693f98 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
>  5cce3fc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
>  fd96c8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
>  cc0f2b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  526e462 
>   
> 

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

[Amruta Borkar]

> On Jan. 18, 2017, 7:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml,
> >  line 238
> > 
> >
> > This annotation is missing in HDFS 3.0.0.3.0, YARN 3.0.0.3.0, and ZK 
> > 3.4.9

Hello Alejandro, 

Thank you for pointing that out. I missed HDFS 3.0.0.3.0. I could not find any 
Kerberos principal name property in YARN 3.0.0.3.0 and ZK 3.4.9. 
If you find everything ok, could you please help me push this to trunk? 

Thank you,


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/#review162157
---


On Jan. 19, 2017, 6:16 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53213/
> ---
> 
> (Updated Jan. 19, 2017, 6:16 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert Levas, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18692
> https://issues.apache.org/jira/browse/AMBARI-18692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exporting blueprint from kerberos enabled cluster, exports hardcoded values 
> cluster name and realm in principal_name property.
> When the same blueprint is used to create another cluster with different 
> name, service start fail with following error:
> "resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt 
> /etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned 
> 1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] 
> while getting initial credentials"
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  737e8de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
>  16f75ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 01c8a89 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
>  1d330dd 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
>  d7ae236 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml
>  2be101b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  9efa4f9 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  0ded5d6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  2ab6aa0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  c2f37c1 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  24032fa 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  e8a76b6 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
>  2e5a026 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  fb641a8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  a6f1502 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  47872ee 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  36ebc8c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  a0bd322 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml
>  d267b75 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
>  1bce4e6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
>  b85cf50 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  71a42f7 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  a5115af 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  b78fd79 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
>  5d0b2ff 
>   
> 

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/
---

(Updated Jan. 19, 2017, 6:16 p.m.)


Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert Levas, 
and Robert Nettleton.


Bugs: AMBARI-18692
https://issues.apache.org/jira/browse/AMBARI-18692


Repository: ambari


Description
---

Exporting blueprint from kerberos enabled cluster, exports hardcoded values 
cluster name and realm in principal_name property.
When the same blueprint is used to create another cluster with different name, 
service start fail with following error:
"resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt 
/etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned 
1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] while 
getting initial credentials"


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 737e8de 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
 16f75ee 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
01c8a89 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
 1d330dd 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml
 d7ae236 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml
 2be101b 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 9efa4f9 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 0ded5d6 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
 2ab6aa0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
 c2f37c1 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
 24032fa 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
 e8a76b6 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 7016437 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
 2e5a026 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 fb641a8 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 a6f1502 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
 47872ee 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 36ebc8c 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
 a0bd322 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml
 d267b75 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
 1bce4e6 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
 b85cf50 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
 71a42f7 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 a5115af 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 b78fd79 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
 5d0b2ff 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 e6c59d5 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml
 696b28a 
  ambari-server/src/main/resources/configuration-schema.xsd 17f7393 

Diff: https://reviews.apache.org/r/53213/diff/


Testing
---

Tested manually. Suitable keytabs are generated automatically when not 
mentioned in blueprint. Service starts succeeded with a blueprint exported with 
the code change. 
Modified existing unit test cases.


Thanks,

Amruta Borkar

Re: Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55515/#review162323
---


Ship it!




Ship It!

- Nate Cole


On Jan. 13, 2017, 2:03 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55515/
> ---
> 
> (Updated Jan. 13, 2017, 2:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18739
> https://issues.apache.org/jira/browse/AMBARI-18739
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Also includes code for AMBARI-18738. Perf: Allow components to report their 
> version using distro-select and change configs using conf-select
> 
> In order to run Rolling/Express Upgrade, will need to create the 
> Rolling/NonRolling Upgrade Packs and potentially config packs if we decide to 
> do it across major versions.
> 
> This means each service will need to support start commands with the 
> upgrade_type option, have symlinks already in distro-select, etc.
> 
> At first, this can be a handful of services.
> The goal is to simulate Rolling/Express Upgrade on the PERF stack.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py d75fc0cef2 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac8dd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  615a0cdcbc 
>   ambari-common/src/main/python/resource_management/libraries/script/dummy.py 
> 3dcece501d 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py 
> 4dec16f372 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> d70e87fb1e 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/distro-select.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-INSTALL/scripts/hook.py
>  9eca9ec724 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/metainfo.xml 45a63e5550 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml 
> c5137fb133 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/GRUMPY/metainfo.xml 
> 15c5cfddd2 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HAPPY/metainfo.xml 
> 53cc11b7eb 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HBASE/metainfo.xml 
> f1f4b7d1ac 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/metainfo.xml 
> 42edc8d493 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/datanode.py
>  6fc338b1da 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/journalnode.py
>  96be63060a 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/HDFS/package/scripts/namenode.py
>  c3488e8bcc 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/SLEEPY/metainfo.xml 
> 5b4dbd4a2d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/SNOW/metainfo.xml 
> 21e685ad80 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/metainfo.xml 
> bb2191b267 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/ZOOKEEPER/metainfo.xml
>  57667bb888 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/nonrolling-upgrade-2.0.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/upgrades/upgrade-2.0.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/install_packages.py 
> PRE-CREATION 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 8ba7e42e0b 
> 
> Diff: https://reviews.apache.org/r/55515/diff/
> 
> 
> Testing
> ---
> 
> Tested on my local 3-node cluster (both upgrade and downgrade). 
> Script for creating Perf cluster downloads Ambari code from Apache git, so 
> did not manage to test on gce, but script should work too (added required 
> code).
> 
> What works:
> - deploy of Perf 1.0 cluster
> - RU to 2.0 (upgrade and downgrade)
> - EU to 2.0 (upgrade and downgrade)
> 
> Issues:
> - Clean deploy of perf 2.0 stack (dummy component install scripts 

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55698/#review162322
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (lines 2447 - 2451)


This pattern is used at least 3 times - should we just get this from the 
cluster itself?  A method that goes with cluster.isUpgradeSuspended()?  We also 
have a mix of upgradeContext.getInitializedCommandParams() and the key for 
suspended when they should just all be put on together.



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
(lines 272 - 275)


Can you mark this variable with 
@Experimental(ExperimentalFeature.PATCH_UPGRADES) ?  Will make it easier to 
find when we merge.



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
(lines 622 - 628)


These links don't exist anymore?


- Nate Cole


On Jan. 19, 2017, 11:54 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55698/
> ---
> 
> (Updated Jan. 19, 2017, 11:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19617
> https://issues.apache.org/jira/browse/AMBARI-19617
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While attempting to restart a component that has complicated upgrade logic, 
> the upgrade parameters are not sent to the agents. This can cause some 
> components to fails during a suspended upgrade restart. 
> 
> Example:
> 
> - Begin express upgrade from {{2.3.6.0-3796}} to {{2.5.3.0-37}}
> - {{HIVE_METASTORE}} couldn't start b/c of a missing Kerberos property:
> {code}
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'hive.server2.authentication.kerberos.principal' was not found in 
> configurations dictionary!
> {code}
> - Chose to {{Ignore and Proceed}} which means that none of the Metastore SQL 
> files ran. 
> - Paused the upgrade (presumably at Finalize) and try to start Metastore. It 
> fails to start because the new HDP 2.5 bits are using a non-upgraded 
> database. That causes the {{-info}} option to fail and makes Ambari think it 
> needs to run {{-initSchema}}. 
> 
> RCA: Metastore failed to start during upgrade and the admin chose to skip it. 
> This caused schema upgrade logic not to run. Ambari can examine the 
> {{upgrade_suspended}} property to determine if we need to run upgrade 
> commands while restarting Metastore during an upgrade. 
> 
> However, it might be more prudent to simply send along the suspended upgrade 
> properties so that any actions which might need to happen (such as invoking 
> an upgrade script during the restart) can happen when the upgrade is 
> suspended.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  ec0f7d0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  bdad015 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5e8c803 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  2ec43cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  1d51b0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContextFactory.java
>  4b988e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  9693f98 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
>  5cce3fc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
>  fd96c8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
>  cc0f2b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  526e462 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  0d1a2fa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
>  f7f8325 
> 
> Diff: https://reviews.apache.org/r/55698/diff/
> 
> 
> Testing
> ---
> 
> Tested restarts during a suspended upgrade for Metastore.
> 
> Tests run: 4864, Failures: 0, Errors: 0, Skipped: 38
> 
> [INFO] 
> 

Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/
---

Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
Toader.


Bugs: AMBARI-19629
https://issues.apache.org/jira/browse/AMBARI-19629


Repository: ambari


Description
---

Extract `create_metastore_schema()`, call it from `start()` instead of 
`configure()`.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 16273c77b2bf4affb4b53f33e5eb40f0e9a1122c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 d1ecd6593b4926fe39de11f81a101409ad14a13d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
0a98894bfe74eb53684c6aaef77511b950bb776d 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
f9e910b8bfed478e0419a30230cbc60b71f12e0a 

Diff: https://reviews.apache.org/r/55724/diff/


Testing
---

Manual test: install cluster via blueprint, verify Hive Metastore starts 
successfully.

Unit tests:

```
$ mvn -am -pl ambari-server -DskipSurefireTests clean test
...
Total run:1159
Total errors:0
Total failures:0
OK
...
[INFO] Ambari Server . SUCCESS
```


Thanks,

Attila Doroszlai

Re: Review Request 55698: Restarting Some Components During a Suspended Upgrade Fails Due To Missing Upgrade Parameters

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55698/
---

(Updated Jan. 19, 2017, 11:54 a.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.


Bugs: AMBARI-19617
https://issues.apache.org/jira/browse/AMBARI-19617


Repository: ambari


Description
---

While attempting to restart a component that has complicated upgrade logic, the 
upgrade parameters are not sent to the agents. This can cause some components 
to fails during a suspended upgrade restart. 

Example:

- Begin express upgrade from {{2.3.6.0-3796}} to {{2.5.3.0-37}}
- {{HIVE_METASTORE}} couldn't start b/c of a missing Kerberos property:
{code}
resource_management.core.exceptions.Fail: Configuration parameter 
'hive.server2.authentication.kerberos.principal' was not found in 
configurations dictionary!
{code}
- Chose to {{Ignore and Proceed}} which means that none of the Metastore SQL 
files ran. 
- Paused the upgrade (presumably at Finalize) and try to start Metastore. It 
fails to start because the new HDP 2.5 bits are using a non-upgraded database. 
That causes the {{-info}} option to fail and makes Ambari think it needs to run 
{{-initSchema}}. 

RCA: Metastore failed to start during upgrade and the admin chose to skip it. 
This caused schema upgrade logic not to run. Ambari can examine the 
{{upgrade_suspended}} property to determine if we need to run upgrade commands 
while restarting Metastore during an upgrade. 

However, it might be more prudent to simply send along the suspended upgrade 
properties so that any actions which might need to happen (such as invoking an 
upgrade script during the restart) can happen when the upgrade is suspended.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 ec0f7d0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 bdad015 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 5e8c803 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 2ec43cf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
1d51b0d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContextFactory.java
 4b988e8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 9693f98 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
 5cce3fc 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
 fd96c8e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 cc0f2b6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
 526e462 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 0d1a2fa 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
 f7f8325 

Diff: https://reviews.apache.org/r/55698/diff/


Testing (updated)
---

Tested restarts during a suspended upgrade for Metastore.

Tests run: 4864, Failures: 0, Errors: 0, Skipped: 38

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 26:24 min
[INFO] Finished at: 2017-01-19T10:53:14-05:00
[INFO] Final Memory: 57M/678M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55717/
---

(Updated Jan. 19, 2017, 3:58 p.m.)


Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-19627
https://issues.apache.org/jira/browse/AMBARI-19627


Repository: ambari


Description
---

Hive is a dependency only for Spark ThriftServer, not for other Spark 
components or Zeppelin. Yet, Zeppelin fails to start if Hive is not installed:

Error:
resource_management.core.exceptions.Fail: 
StaticFile('/etc/spark/conf/hive-site.xml') Source file 
/etc/spark/conf/hive-site.xml is not found


This review is for branch-2.5 patch. There is a separate patch attached in jira 
for trunk.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 ac56aa2 

Diff: https://reviews.apache.org/r/55717/diff/


Testing
---

tested on CentOS and passed unit tests on trunk


Thanks,

Renjith Kamath

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

[Renjith Kamath]

> On Jan. 19, 2017, 1:35 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py,
> >  line 153
> > 
> >
> > Since the path is fixed (not a pattern), why is `glob.glob` needed?

removed


- Renjith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55717/#review162277
---


On Jan. 19, 2017, 3:58 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55717/
> ---
> 
> (Updated Jan. 19, 2017, 3:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19627
> https://issues.apache.org/jira/browse/AMBARI-19627
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive is a dependency only for Spark ThriftServer, not for other Spark 
> components or Zeppelin. Yet, Zeppelin fails to start if Hive is not installed:
> 
> Error:
> resource_management.core.exceptions.Fail: 
> StaticFile('/etc/spark/conf/hive-site.xml') Source file 
> /etc/spark/conf/hive-site.xml is not found
> 
> 
> This review is for branch-2.5 patch. There is a separate patch attached in 
> jira for trunk.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  ac56aa2 
> 
> Diff: https://reviews.apache.org/r/55717/diff/
> 
> 
> Testing
> ---
> 
> tested on CentOS and passed unit tests on trunk
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Review Request 55720: AMBARI-19615 clearer error messages for stack_select.py when a role doesn't have a select component name

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55720/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-19615
https://issues.apache.org/jira/browse/AMBARI-19615


Repository: ambari


Description
---

clearer error messages for stack_select.py when a role doesn't have a select 
component name


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 4f6ccd2 

Diff: https://reviews.apache.org/r/55720/diff/


Testing
---

existing unit test
patch trunk code build ambari rpms and install a trunk cluster


Thanks,

Di Li

Re: Review Request 55720: AMBARI-19615 clearer error messages for stack_select.py when a role doesn't have a select component name

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55720/#review162298
---


Ship it!




Ship It!

- Tim Thorpe


On Jan. 19, 2017, 3:46 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55720/
> ---
> 
> (Updated Jan. 19, 2017, 3:46 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19615
> https://issues.apache.org/jira/browse/AMBARI-19615
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> clearer error messages for stack_select.py when a role doesn't have a select 
> component name
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  4f6ccd2 
> 
> Diff: https://reviews.apache.org/r/55720/diff/
> 
> 
> Testing
> ---
> 
> existing unit test
> patch trunk code build ambari rpms and install a trunk cluster
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55680/#review162278
---


Ship it!




Ship It!

- Sebastian Toader


On Jan. 19, 2017, 1:39 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55680/
> ---
> 
> (Updated Jan. 19, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19613
> https://issues.apache.org/jira/browse/AMBARI-19613
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On secure namenode HA clusters the ZKFC component needs to access the 
> zookeeper securely.
> On enabling security appropriate settings are configured to secure this 
> connection.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
>  c2f37c1 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> f30c9e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  3270430 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  f1891a5 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  783f811 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml
>  5be2b74 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml
>  24e0193 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml
>  24e0193 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 9000e95 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py
>  f70c8e9 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hadoop-env.xml
>  e680c1b 
> 
> Diff: https://reviews.apache.org/r/55680/diff/
> 
> 
> Testing
> ---
> 
> Testing done manually:
> 
> Created an unsecure NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - doesn't exist
> * checked the hadoop-env.sh - doesn't contain the variable export 
> HADOOP_ZKFC_OPTS
> * checked the hdfs_jaas.conf - doesn't exist
> * connected to zookeeper, listed znode acls - no limitations set
> 
> Kerberized the NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - set to sasl:nn:cdrwa
> * checked the hadoop-env.sh - contains the variable export HADOOP_ZKFC_OPTS 
> with proper value, points to the correct jaas file
> * checked the hdfs_jaas.conf - OK
> * connected to zookeeper, listed znode acls - set as required 
> (/hadoop-ha/mycluster/ActiveStandbyElectorLock)
> 
> Disabled Kerberos on the NN HA cluster
> 
> * checked the configuration entry: ha.zookeeper.acl - removed
> * checked the hadoop-env.sh - doesn't contain the variable export 
> HADOOP_ZKFC_OPTS
> * connected to zookeeper, listed znode acls - set as required 
> (/hadoop-ha/mycluster/ActiveStandbyElectorLock)
> 
> Unit tests:
> Successfully ran on local machine / unrelated test failed though.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55717/#review162277
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 153)


Since the path is fixed (not a pattern), why is `glob.glob` needed?


- Attila Doroszlai


On Jan. 19, 2017, 1:41 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55717/
> ---
> 
> (Updated Jan. 19, 2017, 1:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19627
> https://issues.apache.org/jira/browse/AMBARI-19627
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive is a dependency only for Spark ThriftServer, not for other Spark 
> components or Zeppelin. Yet, Zeppelin fails to start if Hive is not installed:
> 
> Error:
> resource_management.core.exceptions.Fail: 
> StaticFile('/etc/spark/conf/hive-site.xml') Source file 
> /etc/spark/conf/hive-site.xml is not found
> 
> 
> This review is for branch-2.5 patch. There is a separate patch attached in 
> jira for trunk.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  ac56aa2 
> 
> Diff: https://reviews.apache.org/r/55717/diff/
> 
> 
> Testing
> ---
> 
> tested on CentOS and passed unit tests on trunk
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55429/
---

(Updated Jan. 19, 2017, 1:09 p.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

rebased


Bugs: AMBARI-19468
https://issues.apache.org/jira/browse/AMBARI-19468


Repository: ambari


Description
---

- added setAcl operation inside logsearch code
- added reload collection command (on schema or solrconfig change)
- removed logsearch solr client dependency
- refactor some methods to handlers in collection dao
- removed upload configurations call from ambari logsearch stack code.
- enable ACL security for Log Search / Infra Solr
- fixed jinja template generation in solr-client log4j config
- added global states (audit, service and config collection)
- added rest api filter based on global states
- create async upload config / check znode / collection creation / reloading / 
set acl commands
- removed collection dao and alias dao
- added status REST API for global states


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 2e48c6a 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 9d17fe4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
 4cd412b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ACLPropertiesSplitter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
 c0a7f32 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 c99a738 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 d270b13 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
 fb25a63 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
 82dd7df 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
 f80d6e5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrAuditLogsState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrCollectionState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrServiceLogsState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrUserConfigState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 309687d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 cf61163 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
 d78ff0da 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
 da76924 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 39b65ae 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
 e6a562e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 106bedc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 0fc9852 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ACLHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java
 PRE-CREATION 
  

Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

[Padma Priya N]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55718/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-19624
https://issues.apache.org/jira/browse/AMBARI-19624


Repository: ambari


Description
---

Added fields to support nofification message and upstream apps in the sla 
componenent and added the necessary mappings to handle the new fields while 
generating xml and importing xml.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
1929ddf 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs
 28bdf15 

Diff: https://reviews.apache.org/r/55718/diff/


Testing
---

Manual


Thanks,

Padma Priya N

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55429/#review162276
---


Ship it!




Ship It!

- Miklos Gergely


On Jan. 19, 2017, 12:52 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55429/
> ---
> 
> (Updated Jan. 19, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19468
> https://issues.apache.org/jira/browse/AMBARI-19468
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - added setAcl operation inside logsearch code
> - added reload collection command (on schema or solrconfig change)
> - removed logsearch solr client dependency
> - refactor some methods to handlers in collection dao
> - removed upload configurations call from ambari logsearch stack code.
> - enable ACL security for Log Search / Infra Solr
> - fixed jinja template generation in solr-client log4j config
> - added global states (audit, service and config collection)
> - added rest api filter based on global states
> - create async upload config / check znode / collection creation / reloading 
> / set acl commands
> - removed collection dao and alias dao
> - added status REST API for global states
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  2e48c6a 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 9d17fe4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
>  4cd412b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ACLPropertiesSplitter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
>  c0a7f32 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  c99a738 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
>  d270b13 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  fb25a63 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
>  82dd7df 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
>  f80d6e5 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrAuditLogsState.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrCollectionState.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrServiceLogsState.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrUserConfigState.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrConfigurer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
>  309687d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
>  cf61163 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
>  d78ff0da 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
>  da76924 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  39b65ae 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
>  e6a562e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  106bedc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  0fc9852 
>   
> 

Re: Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55717/#review162275
---


Ship it!




Ship It!

- Prabhjyot Singh


On Jan. 19, 2017, 12:41 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55717/
> ---
> 
> (Updated Jan. 19, 2017, 12:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19627
> https://issues.apache.org/jira/browse/AMBARI-19627
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive is a dependency only for Spark ThriftServer, not for other Spark 
> components or Zeppelin. Yet, Zeppelin fails to start if Hive is not installed:
> 
> Error:
> resource_management.core.exceptions.Fail: 
> StaticFile('/etc/spark/conf/hive-site.xml') Source file 
> /etc/spark/conf/hive-site.xml is not found
> 
> 
> This review is for branch-2.5 patch. There is a separate patch attached in 
> jira for trunk.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  ac56aa2 
> 
> Diff: https://reviews.apache.org/r/55717/diff/
> 
> 
> Testing
> ---
> 
> tested on CentOS and passed unit tests on trunk
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55429/
---

(Updated Jan. 19, 2017, 12:52 p.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

fixed type and remove console.log


Bugs: AMBARI-19468
https://issues.apache.org/jira/browse/AMBARI-19468


Repository: ambari


Description
---

- added setAcl operation inside logsearch code
- added reload collection command (on schema or solrconfig change)
- removed logsearch solr client dependency
- refactor some methods to handlers in collection dao
- removed upload configurations call from ambari logsearch stack code.
- enable ACL security for Log Search / Infra Solr
- fixed jinja template generation in solr-client log4j config
- added global states (audit, service and config collection)
- added rest api filter based on global states
- create async upload config / check znode / collection creation / reloading / 
set acl commands
- removed collection dao and alias dao
- added status REST API for global states


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 2e48c6a 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 9d17fe4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
 4cd412b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ACLPropertiesSplitter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
 c0a7f32 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 c99a738 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 d270b13 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
 fb25a63 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
 82dd7df 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
 f80d6e5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrAuditLogsState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrCollectionState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrServiceLogsState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrUserConfigState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 309687d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 cf61163 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
 d78ff0da 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
 da76924 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 39b65ae 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
 e6a562e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 106bedc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 0fc9852 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ACLHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java
 PRE-CREATION 
  

Review Request 55717: Cannot start Zeppelin notebook if Hive is not installed

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55717/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-19627
https://issues.apache.org/jira/browse/AMBARI-19627


Repository: ambari


Description
---

Hive is a dependency only for Spark ThriftServer, not for other Spark 
components or Zeppelin. Yet, Zeppelin fails to start if Hive is not installed:

Error:
resource_management.core.exceptions.Fail: 
StaticFile('/etc/spark/conf/hive-site.xml') Source file 
/etc/spark/conf/hive-site.xml is not found


This review is for branch-2.5 patch. There is a separate patch attached in jira 
for trunk.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 ac56aa2 

Diff: https://reviews.apache.org/r/55717/diff/


Testing
---

tested on CentOS and passed unit tests on trunk


Thanks,

Renjith Kamath

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55429/
---

(Updated Jan. 19, 2017, 12:41 p.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

fixed typos + improve UI error message


Bugs: AMBARI-19468
https://issues.apache.org/jira/browse/AMBARI-19468


Repository: ambari


Description
---

- added setAcl operation inside logsearch code
- added reload collection command (on schema or solrconfig change)
- removed logsearch solr client dependency
- refactor some methods to handlers in collection dao
- removed upload configurations call from ambari logsearch stack code.
- enable ACL security for Log Search / Infra Solr
- fixed jinja template generation in solr-client log4j config
- added global states (audit, service and config collection)
- added rest api filter based on global states
- create async upload config / check znode / collection creation / reloading / 
set acl commands
- removed collection dao and alias dao
- added status REST API for global states


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 2e48c6a 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 9d17fe4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
 4cd412b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ACLPropertiesSplitter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
 c0a7f32 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 c99a738 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 d270b13 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
 fb25a63 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
 82dd7df 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
 f80d6e5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrAuditLogsState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrCollectionState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrServiceLogsState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrUserConfigState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 309687d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 cf61163 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
 d78ff0da 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
 da76924 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 39b65ae 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
 e6a562e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 106bedc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 0fc9852 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ACLHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java
 PRE-CREATION 
  

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55680/
---

(Updated Jan. 19, 2017, 12:39 p.m.)


Review request for Ambari, Attila Magyar, Robert Levas, and Sebastian Toader.


Bugs: AMBARI-19613
https://issues.apache.org/jira/browse/AMBARI-19613


Repository: ambari


Description
---

On secure namenode HA clusters the ZKFC component needs to access the zookeeper 
securely.
On enabling security appropriate settings are configured to secure this 
connection.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
 c2f37c1 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
f30c9e4 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
 3270430 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 f1891a5 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 783f811 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml
 5be2b74 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml
 24e0193 
  
ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml
 24e0193 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
9000e95 
  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py
 f70c8e9 
  
ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hadoop-env.xml
 e680c1b 

Diff: https://reviews.apache.org/r/55680/diff/


Testing (updated)
---

Testing done manually:

Created an unsecure NN HA cluster

* checked the configuration entry: ha.zookeeper.acl - doesn't exist
* checked the hadoop-env.sh - doesn't contain the variable export 
HADOOP_ZKFC_OPTS
* checked the hdfs_jaas.conf - doesn't exist
* connected to zookeeper, listed znode acls - no limitations set

Kerberized the NN HA cluster

* checked the configuration entry: ha.zookeeper.acl - set to sasl:nn:cdrwa
* checked the hadoop-env.sh - contains the variable export HADOOP_ZKFC_OPTS 
with proper value, points to the correct jaas file
* checked the hdfs_jaas.conf - OK
* connected to zookeeper, listed znode acls - set as required 
(/hadoop-ha/mycluster/ActiveStandbyElectorLock)

Disabled Kerberos on the NN HA cluster

* checked the configuration entry: ha.zookeeper.acl - removed
* checked the hadoop-env.sh - doesn't contain the variable export 
HADOOP_ZKFC_OPTS
* connected to zookeeper, listed znode acls - set as required 
(/hadoop-ha/mycluster/ActiveStandbyElectorLock)

Unit tests:
Successfully ran on local machine / unrelated test failed though.


Thanks,

Laszlo Puskas

Re: Review Request 55716: LLAP Startup: slider dependencies are not deployed by Ambari

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55716/#review162273
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 19, 2017, 2:28 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55716/
> ---
> 
> (Updated Jan. 19, 2017, 2:28 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19626
> https://issues.apache.org/jira/browse/AMBARI-19626
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari slider install does not upload the dependencies as part of the client
> deploy.
> 
> 
> 
> 
> 2016-10-28 19:52:20,596 [main] INFO  tools.SliderUtils - Loading all 
> dependencies from /usr/hdp/2.5.0.0-1245/slider/lib
> 2016-10-28 19:52:34,812 [main] INFO  agent.AgentClientProvider - 
> Automatically uploading the agent tarball at 
> hdfs://cn105-10.l42scl.hortonworks.com:8020/user/gopal/.slider/cluster/llap0/tmp/application_1477340478603_0266/at
> 2016-10-28 19:52:35,118 [main] INFO  agent.AgentClientProvider - 
> Validating app definition .slider/package/LLAP/llap-29Sep2016.zip
> 2016-10-28 19:52:35,124 [main] INFO  tools.SliderUtils - For faster 
> submission of apps, upload dependencies using cmd dependency --upload
> 
> 
> 
> 
> sudo -u hdfs $(which slider) dependency --upload
> 
> 
> This would upload the slider packages once, so that they can be reused by
> every restart of LLAP instead of being uploaded for each restart & downloaded
> on each node again.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py bedf859 
> 
> Diff: https://reviews.apache.org/r/55716/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 55716: LLAP Startup: slider dependencies are not deployed by Ambari

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55716/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19626
https://issues.apache.org/jira/browse/AMBARI-19626


Repository: ambari


Description
---

Ambari slider install does not upload the dependencies as part of the client
deploy.




2016-10-28 19:52:20,596 [main] INFO  tools.SliderUtils - Loading all 
dependencies from /usr/hdp/2.5.0.0-1245/slider/lib
2016-10-28 19:52:34,812 [main] INFO  agent.AgentClientProvider - 
Automatically uploading the agent tarball at 
hdfs://cn105-10.l42scl.hortonworks.com:8020/user/gopal/.slider/cluster/llap0/tmp/application_1477340478603_0266/at
2016-10-28 19:52:35,118 [main] INFO  agent.AgentClientProvider - Validating 
app definition .slider/package/LLAP/llap-29Sep2016.zip
2016-10-28 19:52:35,124 [main] INFO  tools.SliderUtils - For faster 
submission of apps, upload dependencies using cmd dependency --upload




sudo -u hdfs $(which slider) dependency --upload


This would upload the slider packages once, so that they can be reused by
every restart of LLAP instead of being uploaded for each restart & downloaded
on each node again.


Diffs
-

  ambari-server/src/main/resources/scripts/Ambaripreupload.py bedf859 

Diff: https://reviews.apache.org/r/55716/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 55615: Hive View 2.0: Show query logs

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55615/#review162270
---




contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
197)


we should send next request only when first call returns.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
211)


you can check job failure as well in these situations


- Nitiraj Rathore


On Jan. 19, 2017, 11:24 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55615/
> ---
> 
> (Updated Jan. 19, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19582
> https://issues.apache.org/jira/browse/AMBARI-19582
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI changes for showing the logs and query results in separate tabs.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js a666b09 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/query-result-log.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 59395e6 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 606b71a 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 723953c 
>   contrib/views/hive20/src/main/resources/ui/app/services/query.js 400f78b 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-log.hbs
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 2138356 
> 
> Diff: https://reviews.apache.org/r/55615/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 55615: Hive View 2.0: Show query logs

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55615/
---

(Updated Jan. 19, 2017, 11:24 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-19582
https://issues.apache.org/jira/browse/AMBARI-19582


Repository: ambari


Description
---

UI changes for showing the logs and query results in separate tabs.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js a666b09 
  contrib/views/hive20/src/main/resources/ui/app/components/query-result-log.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 59395e6 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
606b71a 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 723953c 
  contrib/views/hive20/src/main/resources/ui/app/services/query.js 400f78b 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-log.hbs
 PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
2138356 

Diff: https://reviews.apache.org/r/55615/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 55711: Admin View: add spinners for tables in loading state

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55711/#review162268
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Jan. 19, 2017, 10:23 a.m., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55711/
> ---
> 
> (Updated Jan. 19, 2017, 10:23 a.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-19625
> https://issues.apache.org/jira/browse/AMBARI-19625
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Admin View: add spinners for tables in loading state
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js
>  e98801c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js
>  948b707 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js
>  dc3a120 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
>  34daa29 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js
>  bd2cec4 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c81b789 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  e03f035 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
>  82a4dec 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html 
> 6be6fdd 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html
>  7f525e8 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html
>  5ac78ca 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 
> 9e93032 
> 
> Diff: https://reviews.apache.org/r/55711/diff/
> 
> 
> Testing
> ---
> 
> PhantomJS 1.9.8 (Linux): Executed 86 of 86 SUCCESS (0.601 secs / 0.6 secs)
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Review Request 55711: Admin View: add spinners for tables in loading state

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55711/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-19625
https://issues.apache.org/jira/browse/AMBARI-19625


Repository: ambari


Description
---

Admin View: add spinners for tables in loading state


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js
 e98801c 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js
 948b707 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js
 dc3a120 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
 34daa29 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js
 bd2cec4 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c81b789 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 e03f035 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
 82a4dec 
  ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html 
6be6fdd 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html 
7f525e8 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html 
5ac78ca 
  ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 
9e93032 

Diff: https://reviews.apache.org/r/55711/diff/


Testing
---

PhantomJS 1.9.8 (Linux): Executed 86 of 86 SUCCESS (0.601 secs / 0.6 secs)


Thanks,

Andrii Tkach

Re: Review Request 55707: AMBARI-19622: Need abilities to add a custom action node and import a workflow xml with custom action

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55707/#review162262
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 19, 2017, 6:54 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55707/
> ---
> 
> (Updated Jan. 19, 2017, 6:54 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19622
> https://issues.apache.org/jira/browse/AMBARI-19622
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Added Custom as one of the options while creating action node.
> 2. Made changes to the action handlers to support addition of custom action 
> node and import of workflow with a custom action
> 3. Modified action editor to support edit of custom action node definition.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 8bbe831 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  8a3c7cf 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-actions.js
>  7c78eea 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/action-type-resolver.js
>  c25b953 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 4cc89ef 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 
> 6bc305a 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 05bdb5a 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  95c8c3b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs
>  b36578d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
>  6d672b4 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> e3be7da 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> fc20359 
> 
> Diff: https://reviews.apache.org/r/55707/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55516/#review162259
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 17, 2017, 9:45 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55516/
> ---
> 
> (Updated Jan. 17, 2017, 9:45 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore.
> 
> 
> Bugs: AMBARI-19475
> https://issues.apache.org/jira/browse/AMBARI-19475
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the Workflow Manager View, when there are no co-ordinator or bundle 
> records, the dashboard message says "Showing 1 to 0 of 0 records". This is 
> because the start record is set to 1 by default.
> 
> Fix is to set the start record to 0, if the total records is 0.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js
>  78bc1c9 
> 
> Diff: https://reviews.apache.org/r/55516/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 55692: AMBARI-19616. Hive Server Interactive : (1). Set 'metaspacesize' based on LLAP daemon size and (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55692/#review162255
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 285)


Please don't hard code HDP version, add a stack feature instead (say 
hive_interactive_ga). 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json


- Jayush Luniya


On Jan. 18, 2017, 11:46 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55692/
> ---
> 
> (Updated Jan. 18, 2017, 11:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19616
> https://issues.apache.org/jira/browse/AMBARI-19616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> (1). Set 'metaspacesize' based on LLAP daemon size
> If LLAP DamoneSize <= 4GB
>  ---> Don't set metaspacesize
> else if LLAP DaemonsSize <=32GB
>  ---> Set to 256m
> else 
>  ---> Set to 1024m (current value)
> 
> (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards.
> - Current code add it irrespective of HDP version '--slider-placement' is not 
> valid for option for HDP version less than 2.6.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  8035be7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9185f78 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml
>  6a68335 
> 
> Diff: https://reviews.apache.org/r/55692/diff/
> 
> 
> Testing
> ---
> 
> Yes, on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 55643: Blueprint installation should accept quick link profile

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55643/#review162254
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/utils/TimeSource.java 
(lines 1 - 30)


This abstraction doesn't seem to be necessary. You should be able to mock 
System.currentTimeMillis() in tests.


- Sebastian Toader


On Jan. 17, 2017, 10:30 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55643/
> ---
> 
> (Updated Jan. 17, 2017, 10:30 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, 
> Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19597
> https://issues.apache.org/jira/browse/AMBARI-19597
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Specifying the quick links profile should be supported in blueprint based 
> cluster installation. First implementation will address the possibility of 
> adding the profile to the cluster creation template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5e8c803 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  b7c9e85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  cb30f2d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  a35da86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
>  d784a22 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
>  a1267df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
>  c551830 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
>  c9ac6b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java
>  26819e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
>  a3ae677 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
>  7724852 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  7db07a0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/DefaultTimeSource.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/TimeSource.java 
> PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java
>  17b1e27 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  2cf478a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java
>  8c723c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  7e6e5a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
>  5c77831 
> 
> Diff: https://reviews.apache.org/r/55643/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run the unit test suite for ambari-server. No failures.
> - Covered the following cases by manual testing:
>-- Installing a cluster via blueprint, quick links profile in the cluster 
> creation template, profile saved the first time
>-- Installing a cluster via blueprint, quick links profile in the cluster 
> creation template, there was an existing quick links profile which was 
> overwritten during cluster installation
>-- Installing a cluster via blueprint, no quick links profile in the 
> cluster creation template
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>