Re: Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided

2017-03-22 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57858/#review169836 --- Ship it! Ship It! - Jaimin Jetly On March 22, 2017, 6:06 p.m

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

2017-03-22 Thread yao lei
> On 三月 22, 2017, 9:02 p.m., Alexandr Antonenko wrote: > > Ship It! Thanks for your review. Alexandr,Would you mind pushing them to where they want to go? - yao --- This is an automatically generated e-mail. To reply, visit: https://rev

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/ --- (Updated March 23, 2017, 1:22 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

2017-03-22 Thread yao lei
> On 三月 22, 2017, 6:12 p.m., Andrii Tkach wrote: > > Ship It! Thanks for your review - yao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57721/#review169754

Re: Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57863/#review169818 --- Ship it! Ship It! - Alejandro Fernandez On March 22, 2017, 1

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/ --- (Updated March 23, 2017, 12:31 a.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57809/#review169811 --- Pushed to trunk, commit ca2c83582e135bb5410b62775292a780e68757eb S

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/ --- (Updated March 23, 2017, 12:12 a.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
> On March 22, 2017, 2:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > > Lines 296 (patched) > > > > > > Doesn't this mean split the

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/ --- (Updated March 23, 2017, 12:08 a.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

2017-03-22 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57863/ --- (Updated March 22, 2017, 11:58 p.m.) Review request for Ambari, Alejandro Ferna

Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

2017-03-22 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57863/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohan

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
> On March 22, 2017, 2:17 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > > Lines 511-514 (patched) > > > > > > Not quite sure what your intent is here. Why

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
> On March 22, 2017, 2:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > > Lines 307 (patched) > > > > > > You're changing the behavior here to

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/ --- (Updated March 22, 2017, 11:26 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/#review169784 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

2017-03-22 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57721/#review169780 --- Ship it! Ship It! - Alexandr Antonenko On March 22, 2017, 1:

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

2017-03-22 Thread Alejandro Fernandez
> On March 22, 2017, 8:41 p.m., Alejandro Fernandez wrote: > > Ship It! Please add a comment to explain that use-case since it's not immediately obvious. - Alejandro --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57674/#review169777 --- Ship it! Ship It! - Alejandro Fernandez On March 16, 2017, 2

Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host

2017-03-22 Thread Robert Levas
> On March 22, 2017, 2:23 p.m., Jaimin Jetly wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > > Line 230 (original), 230 (patched) > > > > > > How wil

Re: Review Request 57834: Config is not shown on comparison mode if it doesn't exist in the latest version

2017-03-22 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57834/#review169759 --- Ship it! Ship It! - Jaimin Jetly On March 22, 2017, 9:46 a.m

Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host

2017-03-22 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57771/#review169757 --- ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ST

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

2017-03-22 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57721/#review169754 --- Ship it! Ship It! - Andrii Tkach On March 22, 2017, 1:48 a.m

Re: Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided

2017-03-22 Thread Andrii Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57858/#review169753 --- Ship it! Ship It! - Andrii Babiichuk On Березень 22, 2017, 6

Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided

2017-03-22 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57858/ --- Review request for Ambari, Andrii Babiichuk and Jaimin Jetly. Bugs: AMBARI-2053

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

2017-03-22 Thread Di Li
> On March 22, 2017, 5:50 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java > > Lines 267 (patched) > > > > > > I'm still unclear on the problem.

Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57809/#review169744 --- Ship it! Ambari 2.5 RC0 is in progress and any commits would in

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57674/#review169742 --- ambari-server/src/main/java/org/apache/ambari/server/upgrade/Upgr

Re: Review Request 57847: Ambari-server CLI to setup Database Options Broken

2017-03-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57847/#review169735 --- Ship it! Ship It! - Alejandro Fernandez On March 22, 2017, 4

Review Request 57847: Ambari-server CLI to setup Database Options Broken

2017-03-22 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57847/ --- Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Sid Wagle, and Vi

Re: Review Request 57811: Runtime filtering is not rendering properly

2017-03-22 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57811/#review169727 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 22, 2017, 4:02

Re: Review Request 57811: Runtime filtering is not rendering properly

2017-03-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57811/ --- (Updated March 22, 2017, 4:02 p.m.) Review request for Ambari, Abhishek Kumar,

Re: Review Request 57842: Tez view not loading in secure mode.

2017-03-22 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57842/#review169719 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 22, 2017, 1:40

Re: Review Request 57806: make home directory check as optional in hive20 view

2017-03-22 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57806/#review169709 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 21, 2017, 2:10

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/#review169706 --- ambari-server/src/main/java/org/apache/ambari/server/state/Upgrad

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

2017-03-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57792/#review169707 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 57842: Tez view not loading in secure mode.

2017-03-22 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57842/#review169705 --- Ship it! Ship It! - Gaurav Nagar On March 22, 2017, 1:40 p.m

Re: Review Request 57842: Tez view not loading in secure mode.

2017-03-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57842/ --- (Updated March 22, 2017, 1:40 p.m.) Review request for Ambari, Abhishek Kumar,

Review Request 57842: Tez view not loading in secure mode.

2017-03-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57842/ --- Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitir

Re: Review Request 57841: Make home directory check as optional in wfmanager view

2017-03-22 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57841/#review169702 --- Ship it! Ship It! - belliraj hb On March 22, 2017, 1:27 p.m.

Review Request 57841: Make home directory check as optional in wfmanager view

2017-03-22 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57841/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallavi Rao. Bugs: AM

Re: Review Request 57813: Service quick links not showing up in the UI

2017-03-22 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57813/#review169700 --- Ship it! Ship It! - Aleksandr Kovalenko On Март 22, 2017, 11

Re: Review Request 56708: Add delete endpoint for logsearch (service + audit logs)

2017-03-22 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56708/ --- (Updated March 22, 2017, 1:15 p.m.) Review request for Ambari, Miklos Gergely a

Re: Review Request 56930: Log Search: add global cluster filter for every query

2017-03-22 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56930/ --- (Updated March 22, 2017, 1:08 p.m.) Review request for Ambari, Miklos Gergely a

Re: Review Request 57461: Logfeeder: add de-duplication support

2017-03-22 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57461/ --- (Updated March 22, 2017, 1:07 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 57806: make home directory check as optional in hive20 view

2017-03-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57806/#review169694 --- Ship it! Ship It! - Pallav Kulshreshtha On March 21, 2017, 2

Re: Review Request 57831: make home directory check as optional in hive view 1.5

2017-03-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57831/#review169693 --- Ship it! Ship It! - Pallav Kulshreshtha On March 22, 2017, 7

Re: Review Request 57835: make home directory check as optional in Pig view

2017-03-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57835/#review169692 --- Ship it! Ship It! - Pallav Kulshreshtha On March 22, 2017, 1

Re: Review Request 57806: make home directory check as optional in hive20 view

2017-03-22 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57806/#review169690 --- Ship it! Ship It! - Gaurav Nagar On March 21, 2017, 2:10 p.m

Re: Review Request 57831: make home directory check as optional in hive view 1.5

2017-03-22 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57831/#review169688 --- Ship it! Ship It! - Gaurav Nagar On March 22, 2017, 7:32 a.m

Re: Review Request 57835: make home directory check as optional in Pig view

2017-03-22 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57835/#review169686 --- Ship it! Ship It! - Gaurav Nagar On March 22, 2017, 11:23 a.

Review Request 57835: make home directory check as optional in Pig view

2017-03-22 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57835/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 57813: Service quick links not showing up in the UI

2017-03-22 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57813/ --- (Updated March 22, 2017, 11:13 a.m.) Review request for Ambari, Aleksandr Koval