Re: Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57858/#review169836
---


Ship it!




Ship It!

- Jaimin Jetly


On March 22, 2017, 6:06 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57858/
> ---
> 
> (Updated March 22, 2017, 6:06 p.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20535
> https://issues.apache.org/jira/browse/AMBARI-20535
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Instead of having two different steps for "Configure Services" and "Configure 
> Identities", we should have configuring identities properties overlaid on 
> "Configure Services" page.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos.js 762f4d0 
>   ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f23814c 
>   ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 2f07e1f 
>   ambari-web/app/controllers/main/service/add_controller.js 0989f76 
>   ambari-web/app/controllers/wizard.js 7af9ab0 
>   ambari-web/app/controllers/wizard/step7_controller.js 0207e6b 
>   ambari-web/app/controllers/wizard/step8_controller.js efd8834 
>   ambari-web/app/mixins/wizard/addSecurityConfigs.js b5f3e6a 
>   ambari-web/app/routes/add_kerberos_routes.js f556acb 
>   ambari-web/app/routes/add_service_routes.js 9ff0b10 
>   ambari-web/app/templates/main/service/add.hbs 2873a87 
>   ambari-web/app/utils/ajax/ajax.js b63027e 
>   ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 
> 422ac26 
>   ambari-web/test/controllers/main/service/add_controller_test.js ffde1f7 
>   ambari-web/test/controllers/wizard/step7_test.js d5d157d 
>   ambari-web/test/controllers/wizard/step8_test.js bdc4f4c 
> 
> 
> Diff: https://reviews.apache.org/r/57858/diff/1/
> 
> 
> Testing
> ---
> 
> 20604 passing (24s)
>   128 pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

[yao lei]

> On 三月 22, 2017, 9:02 p.m., Alexandr Antonenko wrote:
> > Ship It!

Thanks for your review.
Alexandr,Would you mind pushing them to where they want to go?


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57721/#review169780
---


On 三月 22, 2017, 1:48 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57721/
> ---
> 
> (Updated 三月 22, 2017, 1:48 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Alexandr Antonenko, Andrii 
> Tkach, Denys Buzhor, Jaimin Jetly, Oleg Nechiporenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-20484
> https://issues.apache.org/jira/browse/AMBARI-20484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 1.Open Alerts / Actions / Manage Notifications
> 2.Click + buttion and save a new alert target with any custom properties like 
> (a1,b1) and (a2,b2)
> 3.Click + buttion again,at the bottom of popup, you will still find the 
> custom properties which belong to the last alert target.
> 
> Solution:
> We should reset custom proepertis before creating a new Alert Target.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  f470f08 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  15b4da3 
> 
> 
> Diff: https://reviews.apache.org/r/57721/diff/1/
> 
> 
> Testing
> ---
> 
> mvn test
> 20580 passing (36s)
> 153 pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/
---

(Updated March 23, 2017, 1:22 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Changes
---

Fixing more unit tests


Bugs: AMBARI-20490
https://issues.apache.org/jira/browse/AMBARI-20490


Repository: ambari


Description
---

On large-scale clusters over 1000 nodes, performance during Express Upgrade can 
be very slow and it takes more time to fix potential errors.
We can remedy these with the following fixes:

* "hdp-select set all" is currently ran in the ClusterGroup with a single stage 
instead of batching. This can cause Ambari Server to be the bottleneck when 
processing 1000+ requests. Allow the execute-stage inside a ClusterGroup to use 
batching.

* If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
will prevent the hosts from running "hdp-select versions". We can find these 
problematic hosts with an alert.

* There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
longer supported in Ambari 2.5).


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 20b4cbd 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
 8556436 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 ca9ce07 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
ee5451f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 c45ec24 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 8003223 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java
 6004a12 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
 669d50f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 3cf3f8b 
  ambari-server/src/main/resources/alerts.json 2559b3a 
  ambari-server/src/main/resources/host_scripts/alert_version_select.py 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 28ca939 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 9aff1a9 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 adccac0 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 3c0104b 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 cd63651 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 6f7fbd0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 063b362 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 4a641ec 
  ambari-server/src/main/resources/upgrade-pack.xsd 1f11aa1 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 f1af66f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 bf6c41a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 3e70989 
  
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
 cbc5e69 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 8e5ad0a 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
 fe387f3 


Diff: https://reviews.apache.org/r/57792/diff/7/

Changes: https://reviews.apache.org/r/57792/diff/6-7/


Testing
---

mvn clean test


Thanks,

Alejandro Fernandez

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

[yao lei]

> On 三月 22, 2017, 6:12 p.m., Andrii Tkach wrote:
> > Ship It!

Thanks for your review


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57721/#review169754
---


On 三月 22, 2017, 1:48 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57721/
> ---
> 
> (Updated 三月 22, 2017, 1:48 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Alexandr Antonenko, Andrii 
> Tkach, Denys Buzhor, Jaimin Jetly, Oleg Nechiporenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-20484
> https://issues.apache.org/jira/browse/AMBARI-20484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 1.Open Alerts / Actions / Manage Notifications
> 2.Click + buttion and save a new alert target with any custom properties like 
> (a1,b1) and (a2,b2)
> 3.Click + buttion again,at the bottom of popup, you will still find the 
> custom properties which belong to the last alert target.
> 
> Solution:
> We should reset custom proepertis before creating a new Alert Target.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  f470f08 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  15b4da3 
> 
> 
> Diff: https://reviews.apache.org/r/57721/diff/1/
> 
> 
> Testing
> ---
> 
> mvn test
> 20580 passing (36s)
> 153 pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57863/#review169818
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 22, 2017, 11:58 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57863/
> ---
> 
> (Updated March 22, 2017, 11:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20536
> https://issues.apache.org/jira/browse/AMBARI-20536
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> get_port_from_url function parses an port only address incorrectly.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 
> 48e0aa0 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py
>  7ff2a14 
> 
> 
> Diff: https://reviews.apache.org/r/57863/diff/2/
> 
> 
> Testing
> ---
> 
> Reproduced with the alert being shown as "Connection refused for 
> http://:80/node/info
> With the fix, the alert did not appear.
> 
> Ran python tests.
> Also checked for an empty hive.metastore.uri property and it allowed the 
> value as per the fix for AMBARI-20427
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/
---

(Updated March 23, 2017, 12:31 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Changes
---

ReviewBoard isn't showing all of my changed files, so trying one more time.


Bugs: AMBARI-20490
https://issues.apache.org/jira/browse/AMBARI-20490


Repository: ambari


Description
---

On large-scale clusters over 1000 nodes, performance during Express Upgrade can 
be very slow and it takes more time to fix potential errors.
We can remedy these with the following fixes:

* "hdp-select set all" is currently ran in the ClusterGroup with a single stage 
instead of batching. This can cause Ambari Server to be the bottleneck when 
processing 1000+ requests. Allow the execute-stage inside a ClusterGroup to use 
batching.

* If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
will prevent the hosts from running "hdp-select versions". We can find these 
problematic hosts with an alert.

* There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
longer supported in Ambari 2.5).


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 20b4cbd 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
 8556436 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 ca9ce07 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
ee5451f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 c45ec24 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 8003223 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java
 6004a12 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
 669d50f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 3cf3f8b 
  ambari-server/src/main/resources/alerts.json 2559b3a 
  ambari-server/src/main/resources/host_scripts/alert_version_select.py 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 28ca939 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 9aff1a9 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 adccac0 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 3c0104b 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 cd63651 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 6f7fbd0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 063b362 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 4a641ec 
  ambari-server/src/main/resources/upgrade-pack.xsd 1f11aa1 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 f1af66f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 bf6c41a 
  
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
 cbc5e69 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 8e5ad0a 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
 fe387f3 


Diff: https://reviews.apache.org/r/57792/diff/6/

Changes: https://reviews.apache.org/r/57792/diff/5-6/


Testing
---

mvn clean test


Thanks,

Alejandro Fernandez

Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/#review169811
---



Pushed to trunk, commit ca2c83582e135bb5410b62775292a780e68757eb
STILL NEED TO COMMIT TO branch-2.5 after the RC candidate is done and the 2.5 
release is done. Leave the Jira open until then.

- Alejandro Fernandez


On March 22, 2017, 6:22 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57809/
> ---
> 
> (Updated March 22, 2017, 6:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20505
> https://issues.apache.org/jira/browse/AMBARI-20505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently zookeeper connect/session timeout values for atlas are set to 
> 200/400 ms respectively which are very low and not practical/recommended 
> values. Due to this atlas startup fails more frequently.Below are recommended 
> configurations.
> 
> For Atlas:
> atlas.kafka.zookeeper.connection.timeout.ms=3
> atlas.kafka.zookeeper.session.timeout.ms=6
> atlas.audit.zookeeper.session.timeout.ms=6
> 
> 
> As fresh installation scenario have already been fixed in AMBARI-19623, This 
> patch is to handle the EU and RU scenarios.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> c13724b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  39cb0dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  57a5203 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> b5b45cb 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 44d0a2a 
> 
> 
> Diff: https://reviews.apache.org/r/57809/diff/2/
> 
> 
> Testing
> ---
> 
> Verified install and upgrade on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/
---

(Updated March 23, 2017, 12:12 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Bugs: AMBARI-20490
https://issues.apache.org/jira/browse/AMBARI-20490


Repository: ambari


Description
---

On large-scale clusters over 1000 nodes, performance during Express Upgrade can 
be very slow and it takes more time to fix potential errors.
We can remedy these with the following fixes:

* "hdp-select set all" is currently ran in the ClusterGroup with a single stage 
instead of batching. This can cause Ambari Server to be the bottleneck when 
processing 1000+ requests. Allow the execute-stage inside a ClusterGroup to use 
batching.

* If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
will prevent the hosts from running "hdp-select versions". We can find these 
problematic hosts with an alert.

* There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
longer supported in Ambari 2.5).


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
 8556436 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 ca9ce07 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
ee5451f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 c45ec24 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 8003223 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java
 6004a12 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
 669d50f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 3cf3f8b 
  ambari-server/src/main/resources/alerts.json 2559b3a 
  ambari-server/src/main/resources/host_scripts/alert_version_select.py 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 28ca939 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 9aff1a9 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 adccac0 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 3c0104b 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 cd63651 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 39cb0dc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 57a5203 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 4a641ec 
  ambari-server/src/main/resources/upgrade-pack.xsd 1f11aa1 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 f1af66f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 bf6c41a 
  
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
 cbc5e69 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 8e5ad0a 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
 fe387f3 


Diff: https://reviews.apache.org/r/57792/diff/5/

Changes: https://reviews.apache.org/r/57792/diff/4-5/


Testing
---

mvn clean test


Thanks,

Alejandro Fernandez

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

> On March 22, 2017, 2:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
> > Lines 296 (patched)
> > 
> >
> > Doesn't this mean split the original set into subsets of 1 each? When 
> > `numHostsPerBatch` is 0, then you should have a single set of all hosts, 
> > right? Why not just use a Collections.singleontList(hostNames)

You're right, should run in parallel by adding the existing hostnames set into 
the list.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/#review169707
---


On March 23, 2017, 12:08 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57792/
> ---
> 
> (Updated March 23, 2017, 12:08 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20490
> https://issues.apache.org/jira/browse/AMBARI-20490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On large-scale clusters over 1000 nodes, performance during Express Upgrade 
> can be very slow and it takes more time to fix potential errors.
> We can remedy these with the following fixes:
> 
> * "hdp-select set all" is currently ran in the ClusterGroup with a single 
> stage instead of batching. This can cause Ambari Server to be the bottleneck 
> when processing 1000+ requests. Allow the execute-stage inside a ClusterGroup 
> to use batching.
> 
> * If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
> will prevent the hosts from running "hdp-select versions". We can find these 
> problematic hosts with an alert.
> 
> * There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
> 2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
> longer supported in Ambari 2.5).
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  513ceac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  8556436 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  d37e32b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 3a2dc89 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  80bb26c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  be1f469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java
>  6004a12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
>  86a8f55 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  ec7279c 
>   ambari-server/src/main/resources/alerts.json 9c5 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 0f5f48e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
>  46f0fee 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  a741722 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  933183b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.5.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  90f62dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  ecfc4d7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  68fb1d4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  2e5c60e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  4e49097 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  3107bf3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  538fa48 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  1ea9407 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
>  f5ce11e 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml
>  PRE-CREATION 
>   
> 

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/
---

(Updated March 23, 2017, 12:08 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Bugs: AMBARI-20490
https://issues.apache.org/jira/browse/AMBARI-20490


Repository: ambari


Description
---

On large-scale clusters over 1000 nodes, performance during Express Upgrade can 
be very slow and it takes more time to fix potential errors.
We can remedy these with the following fixes:

* "hdp-select set all" is currently ran in the ClusterGroup with a single stage 
instead of batching. This can cause Ambari Server to be the bottleneck when 
processing 1000+ requests. Allow the execute-stage inside a ClusterGroup to use 
batching.

* If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
will prevent the hosts from running "hdp-select versions". We can find these 
problematic hosts with an alert.

* There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
longer supported in Ambari 2.5).


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 513ceac 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
 8556436 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 d37e32b 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
3a2dc89 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 80bb26c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 be1f469 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java
 6004a12 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
 86a8f55 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 ec7279c 
  ambari-server/src/main/resources/alerts.json 9c5 
  ambari-server/src/main/resources/host_scripts/alert_version_select.py 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
0f5f48e 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
 46f0fee 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 a741722 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 933183b 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.5.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 90f62dc 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 ecfc4d7 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 68fb1d4 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 2e5c60e 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 4e49097 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 3107bf3 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 538fa48 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 1ea9407 
  
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
 f5ce11e 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
 bfd994e 


Diff: https://reviews.apache.org/r/57792/diff/4/

Changes: https://reviews.apache.org/r/57792/diff/3-4/


Testing
---

mvn clean test


Thanks,

Alejandro Fernandez

Re: Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57863/
---

(Updated March 22, 2017, 11:58 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
Mohanty.


Bugs: AMBARI-20536
https://issues.apache.org/jira/browse/AMBARI-20536


Repository: ambari


Description
---

get_port_from_url function parses an port only address incorrectly.


Diffs (updated)
-

  ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 
48e0aa0 
  
ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py
 7ff2a14 


Diff: https://reviews.apache.org/r/57863/diff/2/

Changes: https://reviews.apache.org/r/57863/diff/1-2/


Testing
---

Reproduced with the alert being shown as "Connection refused for 
http://:80/node/info
With the fix, the alert did not appear.

Ran python tests.
Also checked for an empty hive.metastore.uri property and it allowed the value 
as per the fix for AMBARI-20427


Thanks,

Madhuvanthi Radhakrishnan

Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57863/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
Mohanty.


Bugs: AMBARI-20536
https://issues.apache.org/jira/browse/AMBARI-20536


Repository: ambari


Description
---

get_port_from_url function parses an port only address incorrectly.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py
 7ff2a14 


Diff: https://reviews.apache.org/r/57863/diff/1/


Testing
---

Reproduced with the alert being shown as "Connection refused for 
http://:80/node/info
With the fix, the alert did not appear.

Ran python tests.
Also checked for an empty hive.metastore.uri property and it allowed the value 
as per the fix for AMBARI-20427


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

> On March 22, 2017, 2:17 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
> > Lines 511-514 (patched)
> > 
> >
> > Not quite sure what your intent is here.  Why change a stage's text 
> > like this?

Still need to do dynamic variable substitution, but not append things like 
"(Batch x out of y)"


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/#review169706
---


On March 22, 2017, 11:26 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57792/
> ---
> 
> (Updated March 22, 2017, 11:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20490
> https://issues.apache.org/jira/browse/AMBARI-20490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On large-scale clusters over 1000 nodes, performance during Express Upgrade 
> can be very slow and it takes more time to fix potential errors.
> We can remedy these with the following fixes:
> 
> * "hdp-select set all" is currently ran in the ClusterGroup with a single 
> stage instead of batching. This can cause Ambari Server to be the bottleneck 
> when processing 1000+ requests. Allow the execute-stage inside a ClusterGroup 
> to use batching.
> 
> * If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
> will prevent the hosts from running "hdp-select versions". We can find these 
> problematic hosts with an alert.
> 
> * There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
> 2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
> longer supported in Ambari 2.5).
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  20b4cbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  8556436 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  ca9ce07 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> ee5451f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  c45ec24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  8003223 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java
>  6004a12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
>  669d50f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  3cf3f8b 
>   ambari-server/src/main/resources/alerts.json 2559b3a 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  28ca939 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9aff1a9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  adccac0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  3c0104b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  cd63651 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  39cb0dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  57a5203 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  4a641ec 
>   ambari-server/src/main/resources/upgrade-pack.xsd 1f11aa1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  f1af66f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  bf6c41a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
>  cbc5e69 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  8e5ad0a 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
>  fe387f3 
> 
> 
> Diff: https://reviews.apache.org/r/57792/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

> On March 22, 2017, 2:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
> > Lines 307 (patched)
> > 
> >
> > You're changing the behavior here to batch this by 100's ... is this 
> > what we want in an express upgrade?

Yes, this is what works for large clusters. Most users on less than 500 hosts 
should not be impacted.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/#review169707
---


On March 22, 2017, 11:26 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57792/
> ---
> 
> (Updated March 22, 2017, 11:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20490
> https://issues.apache.org/jira/browse/AMBARI-20490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On large-scale clusters over 1000 nodes, performance during Express Upgrade 
> can be very slow and it takes more time to fix potential errors.
> We can remedy these with the following fixes:
> 
> * "hdp-select set all" is currently ran in the ClusterGroup with a single 
> stage instead of batching. This can cause Ambari Server to be the bottleneck 
> when processing 1000+ requests. Allow the execute-stage inside a ClusterGroup 
> to use batching.
> 
> * If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
> will prevent the hosts from running "hdp-select versions". We can find these 
> problematic hosts with an alert.
> 
> * There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
> 2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
> longer supported in Ambari 2.5).
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  20b4cbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  8556436 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  ca9ce07 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> ee5451f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  c45ec24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  8003223 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java
>  6004a12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
>  669d50f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  3cf3f8b 
>   ambari-server/src/main/resources/alerts.json 2559b3a 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  28ca939 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9aff1a9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  adccac0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  3c0104b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  cd63651 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  39cb0dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  57a5203 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  4a641ec 
>   ambari-server/src/main/resources/upgrade-pack.xsd 1f11aa1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  f1af66f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  bf6c41a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
>  cbc5e69 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  8e5ad0a 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
>  fe387f3 
> 
> 
> Diff: https://reviews.apache.org/r/57792/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/
---

(Updated March 22, 2017, 11:26 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Changes
---

Addressed comments.


Bugs: AMBARI-20490
https://issues.apache.org/jira/browse/AMBARI-20490


Repository: ambari


Description
---

On large-scale clusters over 1000 nodes, performance during Express Upgrade can 
be very slow and it takes more time to fix potential errors.
We can remedy these with the following fixes:

* "hdp-select set all" is currently ran in the ClusterGroup with a single stage 
instead of batching. This can cause Ambari Server to be the bottleneck when 
processing 1000+ requests. Allow the execute-stage inside a ClusterGroup to use 
batching.

* If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
will prevent the hosts from running "hdp-select versions". We can find these 
problematic hosts with an alert.

* There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
longer supported in Ambari 2.5).


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 20b4cbd 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
 8556436 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 ca9ce07 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
ee5451f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 c45ec24 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 8003223 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ParallelScheduler.java
 6004a12 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
 669d50f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
 3cf3f8b 
  ambari-server/src/main/resources/alerts.json 2559b3a 
  ambari-server/src/main/resources/host_scripts/alert_version_select.py 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 28ca939 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 9aff1a9 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 adccac0 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 3c0104b 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 cd63651 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 39cb0dc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 57a5203 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 4a641ec 
  ambari-server/src/main/resources/upgrade-pack.xsd 1f11aa1 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 f1af66f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 bf6c41a 
  
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
 cbc5e69 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 8e5ad0a 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_batch.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
 fe387f3 


Diff: https://reviews.apache.org/r/57792/diff/3/

Changes: https://reviews.apache.org/r/57792/diff/2-3/


Testing
---

mvn clean test


Thanks,

Alejandro Fernandez

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/#review169784
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
Line 1357 (original), 1357 (patched)


For any tasks in the ClusterGroup, the current text is pretty generic and 
the user has to click the link in order to find out the hostname.

RestartGroup already has the hostname if scoped to 1 host, but not 
ClusterGroup.



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
Lines 511-514 (patched)


The text of a stage goes through 2 edits.
1. Replace dynamic variables like %direction
2. Append the batch number (Batch x of y)

When a stage has multiple hosts, I actually want to append "on host foo" on 
the original text + edit #1.

So I have to keep track of both strings.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
Lines 311-314 (original), 290-312 (patched)


Good idea.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
Lines 41-42 (patched)


Only one override is happening to replace dynamic variables.



ambari-server/src/main/resources/host_scripts/alert_version_select.py
Lines 72-73 (patched)


Will fix.



ambari-server/src/main/resources/host_scripts/alert_version_select.py
Lines 82-83 (patched)


Will fix.


- Alejandro Fernandez


On March 21, 2017, 12:49 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57792/
> ---
> 
> (Updated March 21, 2017, 12:49 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20490
> https://issues.apache.org/jira/browse/AMBARI-20490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On large-scale clusters over 1000 nodes, performance during Express Upgrade 
> can be very slow and it takes more time to fix potential errors.
> We can remedy these with the following fixes:
> 
> * "hdp-select set all" is currently ran in the ClusterGroup with a single 
> stage instead of batching. This can cause Ambari Server to be the bottleneck 
> when processing 1000+ requests. Allow the execute-stage inside a ClusterGroup 
> to use batching.
> 
> * If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
> will prevent the hosts from running "hdp-select versions". We can find these 
> problematic hosts with an alert.
> 
> * There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
> 2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
> longer supported in Ambari 2.5).
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  20b4cbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  8556436 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  ca9ce07 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> ee5451f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  c45ec24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  8003223 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
>  669d50f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  3cf3f8b 
>   ambari-server/src/main/resources/alerts.json 2559b3a 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  28ca939 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9aff1a9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  adccac0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  3c0104b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  cd63651 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  39cb0dc 
> 

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57721/#review169780
---


Ship it!




Ship It!

- Alexandr Antonenko


On March 22, 2017, 1:48 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57721/
> ---
> 
> (Updated March 22, 2017, 1:48 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Alexandr Antonenko, Andrii 
> Tkach, Denys Buzhor, Jaimin Jetly, Oleg Nechiporenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-20484
> https://issues.apache.org/jira/browse/AMBARI-20484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 1.Open Alerts / Actions / Manage Notifications
> 2.Click + buttion and save a new alert target with any custom properties like 
> (a1,b1) and (a2,b2)
> 3.Click + buttion again,at the bottom of popup, you will still find the 
> custom properties which belong to the last alert target.
> 
> Solution:
> We should reset custom proepertis before creating a new Alert Target.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  f470f08 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  15b4da3 
> 
> 
> Diff: https://reviews.apache.org/r/57721/diff/1/
> 
> 
> Testing
> ---
> 
> mvn test
> 20580 passing (36s)
> 153 pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

[Alejandro Fernandez]

> On March 22, 2017, 8:41 p.m., Alejandro Fernandez wrote:
> > Ship It!

Please add a comment to explain that use-case since it's not immediately 
obvious.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57674/#review169777
---


On March 16, 2017, 2:15 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57674/
> ---
> 
> (Updated March 16, 2017, 2:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20461
> https://issues.apache.org/jira/browse/AMBARI-20461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is an issue specifically for custom stacks that may not have 
> override_hbase_uid property in hbase-env.xml. In this case, override_uid is 
> currently set to true by Ambari's auto merge logic. it should be set to false 
> when upgrading Ambari 2.1 to 2.2 or newer with custom stacks in order to 
> respect the existing UID customers already set on their clusters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
>  499c726 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
>  3f7bcc8 
> 
> 
> Diff: https://reviews.apache.org/r/57674/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests. install an Ambari 2.1 cluster with my custom stack where HBase 
> does not have override_hbase_uid property. build Ambari rpm from trunk code, 
> run ambari upgrade, verify override_uid is set to false in cluster-env, so 
> that UIDs that I already set on my cluster are respected.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57674/#review169777
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 16, 2017, 2:15 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57674/
> ---
> 
> (Updated March 16, 2017, 2:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20461
> https://issues.apache.org/jira/browse/AMBARI-20461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is an issue specifically for custom stacks that may not have 
> override_hbase_uid property in hbase-env.xml. In this case, override_uid is 
> currently set to true by Ambari's auto merge logic. it should be set to false 
> when upgrading Ambari 2.1 to 2.2 or newer with custom stacks in order to 
> respect the existing UID customers already set on their clusters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
>  499c726 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
>  3f7bcc8 
> 
> 
> Diff: https://reviews.apache.org/r/57674/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests. install an Ambari 2.1 cluster with my custom stack where HBase 
> does not have override_hbase_uid property. build Ambari rpm from trunk code, 
> run ambari upgrade, verify override_uid is set to false in cluster-env, so 
> that UIDs that I already set on my cluster are respected.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host

[Robert Levas]

> On March 22, 2017, 2:23 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
> > Line 230 (original), 230 (patched)
> > 
> >
> > How will user interface behave when jce policy is not required ? 
> > Instead of host resource rest api exposing a boolean, does it makes 
> > sense to have enum "INSTALLED", "NOT_INSTALLED" and "NOT_REQUIRED"?

I think there are a few different usages here.  

1) The code in shared_initialization.py is used to contionally install the 
unlimited JCE policy if required.  Logic in the Ambari server determines 
whether it is required or not based on service metadata and whether Kerberos is 
enabled or not.   This was handled in 
https://issues.apache.org/jira/browse/AMBARI-20196.  Attila needed to update 
the class used to invoke the utility that is used to determine when the 
unlimited key JCE policy was installed or not. 

2) The task at hand is to collect information from each host in the cluster to 
know whether the unlimited key JCE policy has been installed or not - 
regardless of whether it is required or not.  This is for informational 
purposes only to make it easier for a user to get more info about the hosts.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57771/#review169757
---


On March 22, 2017, 5:44 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57771/
> ---
> 
> (Updated March 22, 2017, 5:44 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20525
> https://issues.apache.org/jira/browse/AMBARI-20525
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In many cases support engineers want to look at if Unlimited Strength Java 
> Cryptography Extension is installed on all hosts quickly and easily.
> 
> This information is now visible on the host summary page, and can be accessed 
> via api call: /api/v1/hosts?fields=Hosts/last_agent_env.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 7f041eb 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 67294e0 
>   
> ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
>  a4e4f6e 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/AgentEnv.java 
> 64d0865 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  20431f6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  3c36962 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/shared_initialization.py
>  71161e0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java
>  3f62366 
>   ambari-web/app/controllers/global/update_controller.js 59eaf3e 
>   ambari-web/app/mappers/hosts_mapper.js e4dd08f 
>   ambari-web/app/messages.js c9926e6 
>   ambari-web/app/models/host.js 1b7b326 
>   ambari-web/app/templates/main/host/summary.hbs 5d0b09c 
> 
> 
> Diff: https://reviews.apache.org/r/57771/diff/2/
> 
> 
> Testing
> ---
> 
> added new unittests, tested the UI manually
> 
> existing tests ran successfully with one irrelevant exception:
> 
> ==
> FAIL: test_get_params_from_filesystem 
> (TestSecurityCommons.TestSecurityCommons)
> --
> Traceback (most recent call last):
>   File 
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/Users/amagyar/development/ambari/ambari-agent/src/test/python/resource_management/TestSecurityCommons.py",
>  line 203, in test_get_params_from_filesystem
> et_parser_mock.assert_called_with(conf_dir + os.sep + "config.xml")
>   File 
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 829, in assert_called_with
> raise AssertionError('Expected call: %s\nNot called' % (expected,))
> AssertionError: Expected call: 
> parse('/var/folders/hp/5rnr2yx14q7csg8xbtp_mkr8gn/T/config.xml')
> Not called
> 
> --
> Ran 465 tests in 16.659s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57834: Config is not shown on comparison mode if it doesn't exist in the latest version

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57834/#review169759
---


Ship it!




Ship It!

- Jaimin Jetly


On March 22, 2017, 9:46 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57834/
> ---
> 
> (Updated March 22, 2017, 9:46 a.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20526
> https://issues.apache.org/jira/browse/AMBARI-20526
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Add custom config and save configs
> * Remove this custom config and save configs
> * Compare this to config versions 
> 
> *ER* Config is shown as "Undefined"
> *AR* Config is not shown
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/common/configs/configs_comparator.js e9fb942 
>   ambari-web/test/mappers/configs/service_config_version_mapper_test.js 
> d99864a 
>   ambari-web/test/mappers/configs/themes_mapper_test.js b869109 
>   ambari-web/test/mixins/common/configs/configs_comparator_test.js dc7534c 
> 
> 
> Diff: https://reviews.apache.org/r/57834/diff/1/
> 
> 
> Testing
> ---
> 
> 20620 passing (21s)
>   128 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57771/#review169757
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
Line 230 (original), 230 (patched)


How will user interface behave when jce policy is not required ? 
Instead of host resource rest api exposing a boolean, does it makes sense 
to have enum "INSTALLED", "NOT_INSTALLED" and "NOT_REQUIRED"?


- Jaimin Jetly


On March 22, 2017, 9:44 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57771/
> ---
> 
> (Updated March 22, 2017, 9:44 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Robert Levas, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20525
> https://issues.apache.org/jira/browse/AMBARI-20525
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In many cases support engineers want to look at if Unlimited Strength Java 
> Cryptography Extension is installed on all hosts quickly and easily.
> 
> This information is now visible on the host summary page, and can be accessed 
> via api call: /api/v1/hosts?fields=Hosts/last_agent_env.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 7f041eb 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 67294e0 
>   
> ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
>  a4e4f6e 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/AgentEnv.java 
> 64d0865 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  20431f6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  3c36962 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/shared_initialization.py
>  71161e0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java
>  3f62366 
>   ambari-web/app/controllers/global/update_controller.js 59eaf3e 
>   ambari-web/app/mappers/hosts_mapper.js e4dd08f 
>   ambari-web/app/messages.js c9926e6 
>   ambari-web/app/models/host.js 1b7b326 
>   ambari-web/app/templates/main/host/summary.hbs 5d0b09c 
> 
> 
> Diff: https://reviews.apache.org/r/57771/diff/2/
> 
> 
> Testing
> ---
> 
> added new unittests, tested the UI manually
> 
> existing tests ran successfully with one irrelevant exception:
> 
> ==
> FAIL: test_get_params_from_filesystem 
> (TestSecurityCommons.TestSecurityCommons)
> --
> Traceback (most recent call last):
>   File 
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/Users/amagyar/development/ambari/ambari-agent/src/test/python/resource_management/TestSecurityCommons.py",
>  line 203, in test_get_params_from_filesystem
> et_parser_mock.assert_called_with(conf_dir + os.sep + "config.xml")
>   File 
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
>  line 829, in assert_called_with
> raise AssertionError('Expected call: %s\nNot called' % (expected,))
> AssertionError: Expected call: 
> parse('/var/folders/hp/5rnr2yx14q7csg8xbtp_mkr8gn/T/config.xml')
> Not called
> 
> --
> Ran 465 tests in 16.659s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57721/#review169754
---


Ship it!




Ship It!

- Andrii Tkach


On March 22, 2017, 1:48 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57721/
> ---
> 
> (Updated March 22, 2017, 1:48 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Alexandr Antonenko, Andrii 
> Tkach, Denys Buzhor, Jaimin Jetly, Oleg Nechiporenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-20484
> https://issues.apache.org/jira/browse/AMBARI-20484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 1.Open Alerts / Actions / Manage Notifications
> 2.Click + buttion and save a new alert target with any custom properties like 
> (a1,b1) and (a2,b2)
> 3.Click + buttion again,at the bottom of popup, you will still find the 
> custom properties which belong to the last alert target.
> 
> Solution:
> We should reset custom proepertis before creating a new Alert Target.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  f470f08 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  15b4da3 
> 
> 
> Diff: https://reviews.apache.org/r/57721/diff/1/
> 
> 
> Testing
> ---
> 
> mvn test
> 20580 passing (36s)
> 153 pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57858/#review169753
---


Ship it!




Ship It!

- Andrii Babiichuk


On Березень 22, 2017, 6:06 після полудня, Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57858/
> ---
> 
> (Updated Березень 22, 2017, 6:06 після полудня)
> 
> 
> Review request for Ambari, Andrii Babiichuk and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20535
> https://issues.apache.org/jira/browse/AMBARI-20535
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Instead of having two different steps for "Configure Services" and "Configure 
> Identities", we should have configuring identities properties overlaid on 
> "Configure Services" page.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos.js 762f4d0 
>   ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f23814c 
>   ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 2f07e1f 
>   ambari-web/app/controllers/main/service/add_controller.js 0989f76 
>   ambari-web/app/controllers/wizard.js 7af9ab0 
>   ambari-web/app/controllers/wizard/step7_controller.js 0207e6b 
>   ambari-web/app/controllers/wizard/step8_controller.js efd8834 
>   ambari-web/app/mixins/wizard/addSecurityConfigs.js b5f3e6a 
>   ambari-web/app/routes/add_kerberos_routes.js f556acb 
>   ambari-web/app/routes/add_service_routes.js 9ff0b10 
>   ambari-web/app/templates/main/service/add.hbs 2873a87 
>   ambari-web/app/utils/ajax/ajax.js b63027e 
>   ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 
> 422ac26 
>   ambari-web/test/controllers/main/service/add_controller_test.js ffde1f7 
>   ambari-web/test/controllers/wizard/step7_test.js d5d157d 
>   ambari-web/test/controllers/wizard/step8_test.js bdc4f4c 
> 
> 
> Diff: https://reviews.apache.org/r/57858/diff/1/
> 
> 
> Testing
> ---
> 
> 20604 passing (24s)
>   128 pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57858/
---

Review request for Ambari, Andrii Babiichuk and Jaimin Jetly.


Bugs: AMBARI-20535
https://issues.apache.org/jira/browse/AMBARI-20535


Repository: ambari


Description
---

Instead of having two different steps for "Configure Services" and "Configure 
Identities", we should have configuring identities properties overlaid on 
"Configure Services" page.


Diffs
-

  ambari-web/app/controllers/main/admin/kerberos.js 762f4d0 
  ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f23814c 
  ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 2f07e1f 
  ambari-web/app/controllers/main/service/add_controller.js 0989f76 
  ambari-web/app/controllers/wizard.js 7af9ab0 
  ambari-web/app/controllers/wizard/step7_controller.js 0207e6b 
  ambari-web/app/controllers/wizard/step8_controller.js efd8834 
  ambari-web/app/mixins/wizard/addSecurityConfigs.js b5f3e6a 
  ambari-web/app/routes/add_kerberos_routes.js f556acb 
  ambari-web/app/routes/add_service_routes.js 9ff0b10 
  ambari-web/app/templates/main/service/add.hbs 2873a87 
  ambari-web/app/utils/ajax/ajax.js b63027e 
  ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 
422ac26 
  ambari-web/test/controllers/main/service/add_controller_test.js ffde1f7 
  ambari-web/test/controllers/wizard/step7_test.js d5d157d 
  ambari-web/test/controllers/wizard/step8_test.js bdc4f4c 


Diff: https://reviews.apache.org/r/57858/diff/1/


Testing
---

20604 passing (24s)
  128 pending


Thanks,

Aleksandr Kovalenko

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

[Di Li]

> On March 22, 2017, 5:50 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
> > Lines 267 (patched)
> > 
> >
> > I'm still unclear on the problem.
> > In Ambari Upgrade Catalog 212,
> > override_hbase_uid should be removed from hbase-env
> > since instead it is now controlled by override_uid in cluster-env.
> > 
> > Looks like your logic may even change cluster-env's override_uid from 
> > true to false, so changing the behavior on existing clusters.
> > 
> > Can you elaborate more?
> > 
> > Also, this is going into trunk, so the chances of someone upgrading 
> > from Ambari 2.0 to 2.1 or higher usingn this version are extremely unlikely.

Hello Alejandro,

This is for upgrading a third party Ambari/stack distribution from Ambari 
version 2.1.0 to Ambari trunk. HDP stacks do not have this issue.

The HBase in my own stack did not have 'override_hbase_uid' when I released it 
with AMbari 2.1.0. Current code (without my change) will merge override_uid 
with default value true (defined in cluster-env) when I upgrade Ambari to 
trunk. For clusters that used UID less than 1000, override_uid=true causes 
Ambari to update the UIDs, and servers will fail to restart. 

My code change is in UpgradeCatalog212 and only runs if "override_hbase_uid" 
does not exist (either it doesn;t exist, or the entire hbase-env doesn;t 
exist). This means that my code change only affects old Ambari 2.1.0 or Ambari 
2.1.1 when upgrading them to Ambari trunk. If a cluster has Ambari 2.2.x 
(override_uid was added in Ambari 2.1.2), UpgradeCatalog212 does not run, so my 
logic does not run, respecting whatever override_uid the cluster always uses. 
If a cluster is with HDP stacks and on Ambari 2.1.0, the current logic in 
UpgradeCatalog212 runs, so my logic still doesn;t affect it.

Thanks.

Di


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57674/#review169742
---


On March 16, 2017, 2:15 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57674/
> ---
> 
> (Updated March 16, 2017, 2:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20461
> https://issues.apache.org/jira/browse/AMBARI-20461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is an issue specifically for custom stacks that may not have 
> override_hbase_uid property in hbase-env.xml. In this case, override_uid is 
> currently set to true by Ambari's auto merge logic. it should be set to false 
> when upgrading Ambari 2.1 to 2.2 or newer with custom stacks in order to 
> respect the existing UID customers already set on their clusters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
>  499c726 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
>  3f7bcc8 
> 
> 
> Diff: https://reviews.apache.org/r/57674/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests. install an Ambari 2.1 cluster with my custom stack where HBase 
> does not have override_hbase_uid property. build Ambari rpm from trunk code, 
> run ambari upgrade, verify override_uid is set to false in cluster-env, so 
> that UIDs that I already set on my cluster are respected.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/#review169744
---


Ship it!




Ambari 2.5 RC0 is in progress and any commits would invalidate the release 
candidate. If this is a blocker, please let me know. Otherwise, I can commit to 
trunk now, and after 2.5 is released commit it to that branch and then close 
the Jira.

- Alejandro Fernandez


On March 22, 2017, 6:22 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57809/
> ---
> 
> (Updated March 22, 2017, 6:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20505
> https://issues.apache.org/jira/browse/AMBARI-20505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently zookeeper connect/session timeout values for atlas are set to 
> 200/400 ms respectively which are very low and not practical/recommended 
> values. Due to this atlas startup fails more frequently.Below are recommended 
> configurations.
> 
> For Atlas:
> atlas.kafka.zookeeper.connection.timeout.ms=3
> atlas.kafka.zookeeper.session.timeout.ms=6
> atlas.audit.zookeeper.session.timeout.ms=6
> 
> 
> As fresh installation scenario have already been fixed in AMBARI-19623, This 
> patch is to handle the EU and RU scenarios.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> c13724b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  39cb0dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  57a5203 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> b5b45cb 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 44d0a2a 
> 
> 
> Diff: https://reviews.apache.org/r/57809/diff/2/
> 
> 
> Testing
> ---
> 
> Verified install and upgrade on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57674/#review169742
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
Lines 267 (patched)


I'm still unclear on the problem.
In Ambari Upgrade Catalog 212,
override_hbase_uid should be removed from hbase-env
since instead it is now controlled by override_uid in cluster-env.

Looks like your logic may even change cluster-env's override_uid from true 
to false, so changing the behavior on existing clusters.

Can you elaborate more?

Also, this is going into trunk, so the chances of someone upgrading from 
Ambari 2.0 to 2.1 or higher usingn this version are extremely unlikely.


- Alejandro Fernandez


On March 16, 2017, 2:15 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57674/
> ---
> 
> (Updated March 16, 2017, 2:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20461
> https://issues.apache.org/jira/browse/AMBARI-20461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is an issue specifically for custom stacks that may not have 
> override_hbase_uid property in hbase-env.xml. In this case, override_uid is 
> currently set to true by Ambari's auto merge logic. it should be set to false 
> when upgrading Ambari 2.1 to 2.2 or newer with custom stacks in order to 
> respect the existing UID customers already set on their clusters.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
>  499c726 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
>  3f7bcc8 
> 
> 
> Diff: https://reviews.apache.org/r/57674/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests. install an Ambari 2.1 cluster with my custom stack where HBase 
> does not have override_hbase_uid property. build Ambari rpm from trunk code, 
> run ambari upgrade, verify override_uid is set to false in cluster-env, so 
> that UIDs that I already set on my cluster are respected.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 57847: Ambari-server CLI to setup Database Options Broken

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57847/#review169735
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 22, 2017, 4:44 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57847/
> ---
> 
> (Updated March 22, 2017, 4:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20532
> https://issues.apache.org/jira/browse/AMBARI-20532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When trying to automate the configuration of Ambari through the 
> 'ambari-server setup' with options to setup the database and JDK, the return 
> claims success but fails to make adjustments to 'ambari.properties' and 
> 'password.dat' files.
> Example CLI Call:
> /usr/sbin/ambari-server setup --java-home=/usr/java/default --database=mysql 
> --databasehost="db.hdp.local" --databaseport=3306 --databasename=ambari 
> --databaseusername=ambari --databasepassword=hortonworks 
> --jdbc-driver=/usr/share/java/mysql-connector-java.jar --jdbc-db=mysql 
> --master-key=hortonworks --master-key-persist=true --truststore-type=jceks 
> --truststore-path=/etc/ambari-server/conf/password.jceks 
> --truststore-password=hortonworks -v -g
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari-server.py c985d65 
> 
> 
> Diff: https://reviews.apache.org/r/57847/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 57847: Ambari-server CLI to setup Database Options Broken

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57847/
---

Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20532
https://issues.apache.org/jira/browse/AMBARI-20532


Repository: ambari


Description
---

When trying to automate the configuration of Ambari through the 'ambari-server 
setup' with options to setup the database and JDK, the return claims success 
but fails to make adjustments to 'ambari.properties' and 'password.dat' files.
Example CLI Call:
/usr/sbin/ambari-server setup --java-home=/usr/java/default --database=mysql 
--databasehost="db.hdp.local" --databaseport=3306 --databasename=ambari 
--databaseusername=ambari --databasepassword=hortonworks 
--jdbc-driver=/usr/share/java/mysql-connector-java.jar --jdbc-db=mysql 
--master-key=hortonworks --master-key-persist=true --truststore-type=jceks 
--truststore-path=/etc/ambari-server/conf/password.jceks 
--truststore-password=hortonworks -v -g


Diffs
-

  ambari-server/src/main/python/ambari-server.py c985d65 


Diff: https://reviews.apache.org/r/57847/diff/1/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 57811: Runtime filtering is not rendering properly

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57811/#review169727
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 22, 2017, 4:02 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57811/
> ---
> 
> (Updated March 22, 2017, 4:02 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20519
> https://issues.apache.org/jira/browse/AMBARI-20519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Found Pattern Group By -> Reduce -> Group By -> Broadcast and club them in a 
> single node 'Build Bloom Filter'
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  f6d3704 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  ac592ec 
> 
> 
> Diff: https://reviews.apache.org/r/57811/diff/2/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57811: Runtime filtering is not rendering properly

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57811/
---

(Updated March 22, 2017, 4:02 p.m.)


Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20519
https://issues.apache.org/jira/browse/AMBARI-20519


Repository: ambari


Description
---

Found Pattern Group By -> Reduce -> Group By -> Broadcast and club them in a 
single node 'Build Bloom Filter'


Diffs (updated)
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
 f6d3704 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
 ac592ec 


Diff: https://reviews.apache.org/r/57811/diff/2/

Changes: https://reviews.apache.org/r/57811/diff/1-2/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 57842: Tez view not loading in secure mode.

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57842/#review169719
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 22, 2017, 1:40 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57842/
> ---
> 
> (Updated March 22, 2017, 1:40 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20530
> https://issues.apache.org/jira/browse/AMBARI-20530
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a check in ENV, setting it empty if not found.
> 
> 
> Diffs
> -
> 
>   contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 0e0bdee 
> 
> 
> Diff: https://reviews.apache.org/r/57842/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57806: make home directory check as optional in hive20 view

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57806/#review169709
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 21, 2017, 2:10 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57806/
> ---
> 
> (Updated March 21, 2017, 2:10 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20517
> https://issues.apache.org/jira/browse/AMBARI-20517
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added property
>  views.skip.home-directory-check.file-system.list to skip home directory
>  checks in hive20 view
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/Constants.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java
>  8adac24 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/ServiceCheck.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/SystemService.java
>  dd5bb06 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/service-check.js 
> 22bf1b6 
>   
> contrib/views/hive20/src/main/resources/ui/app/configs/service-check-status.js
>  2810e80 
>   contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js 
> 10552ea 
>   contrib/views/hive20/src/main/resources/ui/app/routes/service-check.js 
> 83111cd 
>   contrib/views/hive20/src/main/resources/ui/app/services/service-check.js 
> a5a4755 
>   contrib/views/hive20/src/main/resources/ui/app/templates/service-check.hbs 
> 2a867aa 
> 
> 
> Diff: https://reviews.apache.org/r/57806/diff/1/
> 
> 
> Testing
> ---
> 
> tested cases where no property is present or no filesystem is present in the 
> property.
> also tested cases where no service checks are done or odd number of service 
> checks are done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/#review169706
---




ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
Lines 511-514 (patched)


Not quite sure what your intent is here.  Why change a stage's text like 
this?



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
Lines 311-314 (original), 290-312 (patched)


This code looks like a straight copy/paste out of 
Grouping.addTasksToStageInBatches().  It would be convenient to have a method 
in ParallelScheduler itself to do this work or abstract it some other way.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
Lines 40 (patched)


"...belong in this stage"



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
Lines 41-42 (patched)


Can always formulate the HRC text based on the actual text, I don't see a 
need for the original text, since you're overwriting it anyway. It's not really 
the "original text" anymore.



ambari-server/src/main/resources/host_scripts/alert_version_select.py
Lines 72-73 (patched)


Nit: %s format is deprecated



ambari-server/src/main/resources/host_scripts/alert_version_select.py
Lines 82-83 (patched)


Nit: formatting



ambari-server/src/main/resources/upgrade-pack.xsd
Line 180 (original), 180-186 (patched)


This is a copy/paste.  Make it it's own type and reference it in both 
places.



ambari-server/src/main/resources/upgrade-pack.xsd
Lines 187 (patched)


The code is one task per ExecuteStage, it's not a list.  And it shouldn't 
be!  There is more thought that has to be made before we make ExecuteStage 
support more than one task.


- Nate Cole


On March 20, 2017, 8:49 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57792/
> ---
> 
> (Updated March 20, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20490
> https://issues.apache.org/jira/browse/AMBARI-20490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On large-scale clusters over 1000 nodes, performance during Express Upgrade 
> can be very slow and it takes more time to fix potential errors.
> We can remedy these with the following fixes:
> 
> * "hdp-select set all" is currently ran in the ClusterGroup with a single 
> stage instead of batching. This can cause Ambari Server to be the bottleneck 
> when processing 1000+ requests. Allow the execute-stage inside a ClusterGroup 
> to use batching.
> 
> * If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
> will prevent the hosts from running "hdp-select versions". We can find these 
> problematic hosts with an alert.
> 
> * There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
> 2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
> longer supported in Ambari 2.5).
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  20b4cbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  8556436 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  ca9ce07 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> ee5451f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  c45ec24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  8003223 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
>  669d50f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  3cf3f8b 
>   ambari-server/src/main/resources/alerts.json 2559b3a 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  28ca939 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9aff1a9 
>  

Re: Review Request 57792: Fixes for Express Upgrade on large-scale clusters: batch execute-stage for hdp-select set all, alert for hdp-select versions, EU from HDP 2.2 to 2.5

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57792/#review169707
---




ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
Lines 296 (patched)


be -> by



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
Line 1357 (original), 1357 (patched)


Why do you want to include the host name on the command - the command is 
scoped to a host already.



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
Lines 511 (patched)


isBlank instead?



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
Lines 296 (patched)


Doesn't this mean split the original set into subsets of 1 each? When 
`numHostsPerBatch` is 0, then you should have a single set of all hosts, right? 
Why not just use a Collections.singleontList(hostNames)



ambari-server/src/main/resources/alerts.json
Lines 184 (patched)


prefix with ambari_agent to be consistent



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
Lines 307 (patched)


You're changing the behavior here to batch this by 100's ... is this what 
we want in an express upgrade?


- Jonathan Hurley


On March 20, 2017, 8:49 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57792/
> ---
> 
> (Updated March 20, 2017, 8:49 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20490
> https://issues.apache.org/jira/browse/AMBARI-20490
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On large-scale clusters over 1000 nodes, performance during Express Upgrade 
> can be very slow and it takes more time to fix potential errors.
> We can remedy these with the following fixes:
> 
> * "hdp-select set all" is currently ran in the ClusterGroup with a single 
> stage instead of batching. This can cause Ambari Server to be the bottleneck 
> when processing 1000+ requests. Allow the execute-stage inside a ClusterGroup 
> to use batching.
> 
> * If some hosts have symlinks or dirs that don't belong in /usr/hdp/ then it 
> will prevent the hosts from running "hdp-select versions". We can find these 
> problematic hosts with an alert.
> 
> * There is currently no upgrade path from HDP 2.2 directly to 2.5. Doing a 
> 2-step upgrade is very time consuming (only for branch 2.4 since HDP 2.2 no 
> longer supported in Ambari 2.5).
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  20b4cbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java
>  8556436 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  ca9ce07 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> ee5451f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  c45ec24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  8003223 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
>  669d50f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
>  3cf3f8b 
>   ambari-server/src/main/resources/alerts.json 2559b3a 
>   ambari-server/src/main/resources/host_scripts/alert_version_select.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  28ca939 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9aff1a9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  adccac0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  3c0104b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  cd63651 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  39cb0dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  57a5203 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  

Re: Review Request 57842: Tez view not loading in secure mode.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57842/#review169705
---


Ship it!




Ship It!

- Gaurav Nagar


On March 22, 2017, 1:40 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57842/
> ---
> 
> (Updated March 22, 2017, 1:40 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20530
> https://issues.apache.org/jira/browse/AMBARI-20530
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added a check in ENV, setting it empty if not found.
> 
> 
> Diffs
> -
> 
>   contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 0e0bdee 
> 
> 
> Diff: https://reviews.apache.org/r/57842/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 57842: Tez view not loading in secure mode.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57842/
---

(Updated March 22, 2017, 1:40 p.m.)


Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20530
https://issues.apache.org/jira/browse/AMBARI-20530


Repository: ambari


Description
---

Added a check in ENV, setting it empty if not found.


Diffs
-

  contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 0e0bdee 


Diff: https://reviews.apache.org/r/57842/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Review Request 57842: Tez view not loading in secure mode.

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57842/
---

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Repository: ambari


Description
---

Added a check in ENV, setting it empty if not found.


Diffs
-

  contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 0e0bdee 


Diff: https://reviews.apache.org/r/57842/diff/1/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 57841: Make home directory check as optional in wfmanager view

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57841/#review169702
---


Ship it!




Ship It!

- belliraj hb


On March 22, 2017, 1:27 p.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57841/
> ---
> 
> (Updated March 22, 2017, 1:27 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallavi Rao.
> 
> 
> Bugs: AMBARI-20529
> https://issues.apache.org/jira/browse/AMBARI-20529
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added property(views.skip.home-directory-check.file-system.list) to skip home 
> directory check
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
>  d06eb07 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  d82f928 
>   contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js 
> f4d93ea 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 316ec0e 
> 
> 
> Diff: https://reviews.apache.org/r/57841/diff/1/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 57841: Make home directory check as optional in wfmanager view

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57841/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallavi Rao.


Bugs: AMBARI-20529
https://issues.apache.org/jira/browse/AMBARI-20529


Repository: ambari


Description
---

Added property(views.skip.home-directory-check.file-system.list) to skip home 
directory check


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
 d06eb07 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
 d82f928 
  contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js 
f4d93ea 
  contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 316ec0e 


Diff: https://reviews.apache.org/r/57841/diff/1/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 57813: Service quick links not showing up in the UI

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/#review169700
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Март 22, 2017, 11:13 д.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57813/
> ---
> 
> (Updated Март 22, 2017, 11:13 д.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20521
> https://issues.apache.org/jira/browse/AMBARI-20521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with 
> master components hosted on 64 separate hosts)
> Navigate to any service on ambari-web that has quicklinks
> Actual Result: Quick links are incorrectly absent
> Expected Result: Quick links should be shown
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/ajax/ajax.js b856e44 
>   ambari-web/test/utils/ajax/ajax_test.js 35de05f 
> 
> 
> Diff: https://reviews.apache.org/r/57813/diff/2/
> 
> 
> Testing
> ---
> 
> 30380 passing (38s)
> 157 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 56708: Add delete endpoint for logsearch (service + audit logs)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56708/
---

(Updated March 22, 2017, 1:15 p.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

removed branch


Bugs: AMBARI-20023
https://issues.apache.org/jira/browse/AMBARI-20023


Repository: ambari


Description
---

add delete endpoint for logsearch.
the actual queries can be used for that just with DELETE command.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/StatusMessage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 4a8fdea 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 0568fd7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 713c9f6 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 2dc0ef7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 f960250 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
 d5b6525 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
 40247a8 


Diff: https://reviews.apache.org/r/56708/diff/2/


Testing
---

testing done.


Thanks,

Oliver Szabo

Re: Review Request 56930: Log Search: add global cluster filter for every query

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56930/
---

(Updated March 22, 2017, 1:08 p.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
---

removed branch


Bugs: AMBARI-20117
https://issues.apache.org/jira/browse/AMBARI-20117


Repository: ambari


Description
---

add global cluster filter for every Log Search query.

On Log Search side the query is: ?clusters=cl1,cl2

On Solr side, its converted to: ?fq=cluster:cl1 or ?fq=cluster:(cl1 OR cl2)


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 a260ed0 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java
 b377968 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestQueryConverter.java
 9b7c9d2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractOperationHolderConverter.java
 b4c6943 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditBarGraphRequestQueryConverter.java
 897bb64 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/HostLogFilesRequestQueryConverter.java
 d9d9121 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogLevelDateRangeRequestQueryConverter.java
 b91a67d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/UserConfigRequestQueryConverter.java
 fc75a17 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 713c9f6 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 f960250 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/ClustersParamDefinition.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/SearchRequest.java
 0015c09 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/impl/CommonSearchRequest.java
 2617c51 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/impl/HostLogFilesRequest.java
 1c0c068 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
 40247a8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 a3824de 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/AbstractRequestConverterTest.java
 04bd1af 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/AuditBarGraphRequestQueryConverterTest.java
 ef12f71 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/AuditComponentRequestQueryConverterTest.java
 0c6e975 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/AuditLogRequestConverterTest.java
 1aae82a 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/AuditServiceLoadRequestQueryConverterTest.java
 2b629e5 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/BaseServiceLogRequestQueryConverterTest.java
 89f8eba 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/FieldAuditLogRequestQueryConverterTest.java
 1428276 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/ServiceLogAnyGraphRequestConverterTest.java
 5d15166 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/ServiceLogComponentLevelRequestQueryConverterTest.java
 4378a64 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/ServiceLogComponentRequestFacetQueryConverterTest.java
 ce9cdcc 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/ServiceLogLevelCountRequestQueryConverterTest.java
 f6beb3d 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/ServiceLogLevelDateRangeRequestQueryConverterTest.java
 b941437 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/ServiceLogTreeRequestFacetQueryConverterTest.java
 a140e19 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/converter/ServiceLogTruncatedRequestQueryConverterTest.java
 

Re: Review Request 57461: Logfeeder: add de-duplication support

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57461/
---

(Updated March 22, 2017, 1:07 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
and Sebastian Toader.


Changes
---

removed branch


Bugs: AMBARI-20378
https://issues.apache.org/jira/browse/AMBARI-20378


Repository: ambari


Description
---

Added de-duplication support on log feeder side.

For that I used an custom LRU cache. If it reaches maximum size, the least 
recently element will be removed.
Also because we often get the MRU element of the cache as well (to filter out 
if we want to setup to filter out the last message if that repeated too much), 
we store the MRU element in the cache. Its cheaper then get the name from the 
LinkedMap beause we will need to iterate over the map until the last element in 
the map (every time).


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
 d1e7fba 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterJSON.java
 ba63c61 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
 e13d9bd 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/cache/LRUCache.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
 eb3ae01 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputLineFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
 86b5c57 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterJSONTest.java
 06d8db2 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/cache/LRUCacheTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/mapper/MapperDateTest.java
 08680f6 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputLineFilterTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputManagerTest.java
 a080fa8 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 879b786 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
 122a9e1 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
 2acb57e 


Diff: https://reviews.apache.org/r/57461/diff/4/


Testing
---

unit test added and updated. 
done.

logfeeder test output:
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 13.074s
[INFO] Finished at: Thu Mar 09 14:40:44 CET 2017
[INFO] Final Memory: 28M/324M
[INFO] 


Thanks,

Oliver Szabo

Re: Review Request 57806: make home directory check as optional in hive20 view

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57806/#review169694
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 21, 2017, 2:10 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57806/
> ---
> 
> (Updated March 21, 2017, 2:10 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20517
> https://issues.apache.org/jira/browse/AMBARI-20517
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added property
>  views.skip.home-directory-check.file-system.list to skip home directory
>  checks in hive20 view
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/Constants.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/HdfsApiSupplier.java
>  8adac24 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/ServiceCheck.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/system/SystemService.java
>  dd5bb06 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/service-check.js 
> 22bf1b6 
>   
> contrib/views/hive20/src/main/resources/ui/app/configs/service-check-status.js
>  2810e80 
>   contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js 
> 10552ea 
>   contrib/views/hive20/src/main/resources/ui/app/routes/service-check.js 
> 83111cd 
>   contrib/views/hive20/src/main/resources/ui/app/services/service-check.js 
> a5a4755 
>   contrib/views/hive20/src/main/resources/ui/app/templates/service-check.hbs 
> 2a867aa 
> 
> 
> Diff: https://reviews.apache.org/r/57806/diff/1/
> 
> 
> Testing
> ---
> 
> tested cases where no property is present or no filesystem is present in the 
> property.
> also tested cases where no service checks are done or odd number of service 
> checks are done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57831: make home directory check as optional in hive view 1.5

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57831/#review169693
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 22, 2017, 7:32 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57831/
> ---
> 
> (Updated March 22, 2017, 7:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Ashwin 
> Rajeev.
> 
> 
> Bugs: AMBARI-20523
> https://issues.apache.org/jira/browse/AMBARI-20523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> used the property views.skip.home-directory-check.file-system.list in 
> ambari-server.properties to exclude home directory test when connecting to 
> those filesystems.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/HelpService.java
>  afc2939 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/Constants.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/ServiceCheck.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/service-check.js
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/splash.js
>  1bf6d42 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js 
> 179a912 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/splash.hbs
>  5612542 
> 
> 
> Diff: https://reviews.apache.org/r/57831/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57835: make home directory check as optional in Pig view

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57835/#review169692
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On March 22, 2017, 11:23 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57835/
> ---
> 
> (Updated March 22, 2017, 11:23 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Renjith Kamath.
> 
> 
> Bugs: AMBARI-20527
> https://issues.apache.org/jira/browse/AMBARI-20527
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> used property views.skip.home-directory-check.file-system.list in 
> ambari.properties to skip home directory test based on the filesystem set in 
> fs.defaultFS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties 5866fe7 
>   ambari-server/conf/windows/ambari.properties c1c0a99 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/HelpService.java
>  a67bfc5 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/Constants.java
>  PRE-CREATION 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceCheck.java
>  PRE-CREATION 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 
> d1b571d 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 
> b30552d 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 
> c97d724 
> 
> 
> Diff: https://reviews.apache.org/r/57835/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57831: make home directory check as optional in hive view 1.5

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57831/#review169688
---


Ship it!




Ship It!

- Gaurav Nagar


On March 22, 2017, 7:32 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57831/
> ---
> 
> (Updated March 22, 2017, 7:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Ashwin 
> Rajeev.
> 
> 
> Bugs: AMBARI-20523
> https://issues.apache.org/jira/browse/AMBARI-20523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> used the property views.skip.home-directory-check.file-system.list in 
> ambari-server.properties to exclude home directory test when connecting to 
> those filesystems.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/HelpService.java
>  afc2939 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/Constants.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/utils/ServiceCheck.java
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/service-check.js
>  PRE-CREATION 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/splash.js
>  1bf6d42 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js 
> 179a912 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/splash.hbs
>  5612542 
> 
> 
> Diff: https://reviews.apache.org/r/57831/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57835: make home directory check as optional in Pig view

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57835/#review169686
---


Ship it!




Ship It!

- Gaurav Nagar


On March 22, 2017, 11:23 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57835/
> ---
> 
> (Updated March 22, 2017, 11:23 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Renjith Kamath.
> 
> 
> Bugs: AMBARI-20527
> https://issues.apache.org/jira/browse/AMBARI-20527
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> used property views.skip.home-directory-check.file-system.list in 
> ambari.properties to skip home directory test based on the filesystem set in 
> fs.defaultFS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties 5866fe7 
>   ambari-server/conf/windows/ambari.properties c1c0a99 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/HelpService.java
>  a67bfc5 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/Constants.java
>  PRE-CREATION 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceCheck.java
>  PRE-CREATION 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 
> d1b571d 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 
> b30552d 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 
> c97d724 
> 
> 
> Diff: https://reviews.apache.org/r/57835/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 57835: make home directory check as optional in Pig view

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57835/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Prabhjyot Singh, Rohit Choudhary, and Renjith Kamath.


Bugs: AMBARI-20527
https://issues.apache.org/jira/browse/AMBARI-20527


Repository: ambari


Description
---

used property views.skip.home-directory-check.file-system.list in 
ambari.properties to skip home directory test based on the filesystem set in 
fs.defaultFS


Diffs
-

  ambari-server/conf/unix/ambari.properties 5866fe7 
  ambari-server/conf/windows/ambari.properties c1c0a99 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/HelpService.java
 a67bfc5 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/Constants.java 
PRE-CREATION 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceCheck.java
 PRE-CREATION 
  contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 
d1b571d 
  contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js b30552d 
  contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 
c97d724 


Diff: https://reviews.apache.org/r/57835/diff/1/


Testing
---

Manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 57813: Service quick links not showing up in the UI

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/
---

(Updated March 22, 2017, 11:13 a.m.)


Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.


Bugs: AMBARI-20521
https://issues.apache.org/jira/browse/AMBARI-20521


Repository: ambari


Description
---

STR:
Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with 
master components hosted on 64 separate hosts)
Navigate to any service on ambari-web that has quicklinks
Actual Result: Quick links are incorrectly absent
Expected Result: Quick links should be shown


Diffs (updated)
-

  ambari-web/app/utils/ajax/ajax.js b856e44 
  ambari-web/test/utils/ajax/ajax_test.js 35de05f 


Diff: https://reviews.apache.org/r/57813/diff/2/

Changes: https://reviews.apache.org/r/57813/diff/1-2/


Testing
---

30380 passing (38s)
157 pending


Thanks,

Andrii Tkach

Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

[Vishal Suvagia via Review Board]

> On March 21, 2017, 8:06 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
> > Line 164 (original), 164 (patched)
> > 
> >
> > Is this meant to affect existing installs that just upgrade Ambari, or 
> > clusters that upgrade their stack to a specific version?

the patch is updated to change configurations when doing HDP upgrade.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/#review169605
---


On March 21, 2017, 3:23 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57809/
> ---
> 
> (Updated March 21, 2017, 3:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20505
> https://issues.apache.org/jira/browse/AMBARI-20505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently zookeeper connect/session timeout values for atlas are set to 
> 200/400 ms respectively which are very low and not practical/recommended 
> values. Due to this atlas startup fails more frequently.Below are recommended 
> configurations.
> 
> For Atlas:
> atlas.kafka.zookeeper.connection.timeout.ms=3
> atlas.kafka.zookeeper.session.timeout.ms=6
> atlas.audit.zookeeper.session.timeout.ms=6
> 
> For Zookeeper:
> tickTime=3000
> 
> As fresh installation scenario have already been fixed in AMBARI-19623, This 
> patch is to handle the EU and RU scenarios.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  e4fc3de 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  70af02c 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zoo.cfg.xml
>  5877877 
> 
> 
> Diff: https://reviews.apache.org/r/57809/diff/1/
> 
> 
> Testing
> ---
> 
> Verified install and upgrade on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

[Vishal Suvagia via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/
---

(Updated March 22, 2017, 6:22 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.


Changes
---

Updating patch to change configurations on HDP upgrades.
Seperate patch for branch-2.5 is attached to Apache JIRA.


Bugs: AMBARI-20505
https://issues.apache.org/jira/browse/AMBARI-20505


Repository: ambari


Description (updated)
---

Currently zookeeper connect/session timeout values for atlas are set to 200/400 
ms respectively which are very low and not practical/recommended values. Due to 
this atlas startup fails more frequently.Below are recommended configurations.

For Atlas:
atlas.kafka.zookeeper.connection.timeout.ms=3
atlas.kafka.zookeeper.session.timeout.ms=6
atlas.audit.zookeeper.session.timeout.ms=6


As fresh installation scenario have already been fixed in AMBARI-19623, This 
patch is to handle the EU and RU scenarios.


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
c13724b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 39cb0dc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 57a5203 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
b5b45cb 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
44d0a2a 


Diff: https://reviews.apache.org/r/57809/diff/2/

Changes: https://reviews.apache.org/r/57809/diff/1-2/


Testing
---

Verified install and upgrade on CentOS-6.


Thanks,

Vishal Suvagia