Re: Review Request 64989: AMBARI-22740 : Fix integration test for HBase in branch-3.0-ams due to UUID changes

2018-01-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64989/#review194921 --- Ship it! Ship It! - Sid Wagle On Jan. 5, 2018, 11:19 p.m.,

Re: Review Request 64989: AMBARI-22740 : Fix integration test for HBase in branch-3.0-ams due to UUID changes

2018-01-05 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64989/ --- (Updated Jan. 5, 2018, 11:19 p.m.) Review request for Ambari, Dmytro Sen and

Re: Review Request 64985: AMBARI-22244. Use service type instead of service name - addendum

2018-01-05 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64985/#review194906 --- Ship it! Are we using serviceType because for 3.0, we will

Re: Review Request 64990: Add event for changes in upgrade

2018-01-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64990/#review194903 --- Fix it, then Ship it!

Re: Review Request 64989: AMBARI-22740 : Fix integration test for HBase in branch-3.0-ams due to UUID changes

2018-01-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64989/#review194902 --- Ship it! Ship It! - Sid Wagle On Jan. 5, 2018, 8:16 p.m.,

Re: Review Request 64991: Fix issues with webapp deployment with new Hadoop common changes

2018-01-05 Thread Sid Wagle
> On Jan. 5, 2018, 9:04 p.m., Aravindan Vijayan wrote: > > ambari-metrics/pom.xml > > Line 44 (original), 44 (patched) > > > > > > Extra ' character at the end. Great catch, thanks. - Sid

Re: Review Request 64991: Fix issues with webapp deployment with new Hadoop common changes

2018-01-05 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64991/#review194898 --- Fix it, then Ship it! ambari-metrics/pom.xml Line 44

Review Request 64991: Fix issues with webapp deployment with new Hadoop common changes

2018-01-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64991/ --- Review request for Ambari and Aravindan Vijayan. Bugs: AMBARI-22744

Re: Review Request 64989: AMBARI-22740 : Fix integration test for HBase in branch-3.0-ams due to UUID changes

2018-01-05 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64989/ --- (Updated Jan. 5, 2018, 8:16 p.m.) Review request for Ambari, Dmytro Sen and

Review Request 64989: AMBARI-22740 : Fix integration test for HBase in branch-3.0-ams due to UUID changes

2018-01-05 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64989/ --- Review request for Ambari, Dmytro Sen and Sid Wagle. Bugs: AMBARI-22740

Review Request 64990: Add event for changes in upgrade

2018-01-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64990/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy,

Re: Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.

2018-01-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64984/#review194894 --- Ship it! Makes sense, can you please open a refactor Jira so

Review Request 64987: Add event for changes in alert groups.

2018-01-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64987/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy,

Re: Review Request 64988: Log Search UI: implement graph for access logs

2018-01-05 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64988/#review194892 --- Ship it! Ship It! - Denys Buzhor On Jan. 5, 2018, 7:34

Review Request 64988: Log Search UI: implement graph for access logs

2018-01-05 Thread Andrii Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64988/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-22741

Re: Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.

2018-01-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64984/#review194890 ---

Re: Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.

2018-01-05 Thread Myroslav Papirkovskyy
> On Січ. 5, 2018, 9:23 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > > Lines 480 (patched) > > > > > > Why is this needed to be done on HB

Re: Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.

2018-01-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64984/#review194888 ---

Review Request 64985: AMBARI-22244. Use service type instead of service name - addendum

2018-01-05 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64985/ --- Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi

Review Request 64984: /events/hostcomponents topic should react on maintenance and stale configs events.

2018-01-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64984/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy,

Re: Review Request 64983: Setup heartbeat for api endpoint.

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64983/#review194880 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 5:44

Re: Review Request 64983: Setup heartbeat for api endpoint.

2018-01-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64983/#review194879 --- Ship it! Ship It! - Sid Wagle On Jan. 5, 2018, 5:44 p.m.,

Review Request 64983: Setup heartbeat for api endpoint.

2018-01-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64983/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy,

Re: Review Request 64981: alert_definitions topic doesn't emit any events to client.

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64981/#review194876 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 4:55

Re: Review Request 64979: Delete host event doesn't have hostName property.

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64979/#review194871 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 3:57

Review Request 64981: alert_definitions topic doesn't emit any events to client.

2018-01-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64981/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy,

Re: Review Request 64976: Ambari Infra Manager: hdfs upload support

2018-01-05 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64976/#review194865 --- Ship it!

Review Request 64979: Delete host event doesn't have hostName property.

2018-01-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64979/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy,

Re: Review Request 64974: Setup fast-hdfs-resource.jar for OneFS

2018-01-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64974/#review194869 --- Ship it! Ship It! - Nate Cole On Jan. 5, 2018, 5:50 a.m.,

Re: Review Request 64977: UI receives a topology event when turning on/off maintenance mode for the host

2018-01-05 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64977/#review194868 --- Ship it! Ship It! - Eugene Chekanskiy On Січ. 5, 2018, 3:01

Re: Review Request 64977: UI receives a topology event when turning on/off maintenance mode for the host

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64977/#review194867 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 3:01

Review Request 64977: UI receives a topology event when turning on/off maintenance mode for the host

2018-01-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64977/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene Chekanskiy,

Review Request 64976: Ambari Infra Manager: hdfs upload support

2018-01-05 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64976/ --- Review request for Ambari, Attila Doroszlai, Oliver Szabo, and Sid Wagle.

Re: Review Request 64974: Setup fast-hdfs-resource.jar for OneFS

2018-01-05 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64974/#review194858 --- Ship it! Ship It! - Robert Levas On Jan. 5, 2018, 5:50

Re: Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception

2018-01-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64951/#review194857 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 5, 2018, 1:20

Re: Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception

2018-01-05 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64951/ --- (Updated Січ. 5, 2018, 1:20 після полудня) Review request for Ambari, Andrew

Re: Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

2018-01-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64956/#review194855 --- Ship it! Ship It! - Dmitro Lisnichenko On Jan. 4, 2018,

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-05 Thread Sonia Garudi
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 968-972 (patched) > > > > > > Should not rely on the name for the id. The API should be giving you

Review Request 64974: Setup fast-hdfs-resource.jar for OneFS

2018-01-05 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64974/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-22121

Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes

2018-01-05 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64971/ --- Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya,