---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51189/#review146073
---
Ship it!
Ship It!
- Di Li
On Aug. 18, 2016, 5:45 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52397/#review151039
---
Ship it!
Ship It!
- Di Li
On Sept. 29, 2016, 4:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52457/#review151169
---
Ship it!
Ship It!
- Di Li
On Sept. 30, 2016, 11:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52456/#review151168
---
Ship it!
Ship It!
- Di Li
On Sept. 30, 2016, 10:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review151191
---
Ship it!
Ship It!
- Di Li
On Sept. 30, 2016, 12:39 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151215
---
Ship it!
Ship It!
- Di Li
On Oct. 3, 2016, 6:43 p.m
operations, but download=true is set in stone and you will have no othe options
but to introduce more URL query parameters for new operations.
- Di Li
On Oct. 3, 2016, 6:13 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatic
e only diff is the ?format=json parameter. so I also wonder - Can
{queryId} support such parameter like if it's ?format=txt, then it means to
download ?
- Di Li
On Sept. 30, 2016, 4:42 p.m., Anita Jebaraj wrote:
>
> ---
> This is a
/controllers/queries.js
(line 107)
<https://reviews.apache.org/r/52430/#comment219180>
what can the file name be? is it the same as the query id ?
- Di Li
On Sept. 30, 2016, 4:42 p.m., Anita Jebaraj
/hive2/resources/savedQueries/SavedQueryService.java
(line 117)
<https://reviews.apache.org/r/52430/#comment219182>
Does this store the entire query result in the memory ? can it be streamed
for better performance ?
- Di Li
On Sept. 30, 2016, 4:42 p.m., Anita Jebaraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52223/#review150399
---
Ship it!
Ship It!
- Di Li
On Sept. 23, 2016, 7:59 p.m., Tim
on service and HDP 2.5 level (2.5
level has the correct bulkcommand section), see the error messages for HDP
2.0.6 up to HDP 2.4, no error in HDP 2.5 (as it has the correct bulkcommand
section)
Thanks,
Di Li
/
Testing
---
1. existing hostcleanup python unit tests
2. patch a trunk cluster feed the HostCleanup.py with the required two .ini
files and run the clean up.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53144/#review153826
---
Ship it!
Ship It!
- Di Li
On Oct. 24, 2016, 5:20 p.m
-us.apache.org/repos/asf?p=ambari.git;a=commit;h=352fe85181d81cf23f82953f05bc66a7c88d639b
Please provide a patch rebased for branch-2.5, AMBARI-18741-Nov7.patch does not
apply to branch-2.5
- Di Li
On Nov. 7, 2016, 6:11 p.m., Anita Jebaraj wrote
> On Nov. 8, 2016, 4:40 p.m., Di Li wrote:
> > Hello Anita,
> >
> > I pushed the change to trunk as
> > https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=352fe85181d81cf23f82953f05bc66a7c88d639b
> >
> > Please provide a patch rebased for b
you please
rebase and provide a new patch ?
- Di Li
On Nov. 2, 2016, 6:31 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/ambari-agent.ini 9a0b537
ambari-agent/conf/windows/ambari-agent.ini b7a0a4d
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 6e4d74a
Diff: https://reviews.apache.org/r/53649/diff/
Testing
---
existing unit tests for Ambari Agent
Thanks,
Di Li
/org/apache/ambari/server/controller/internal/URLStreamProvider.java
c176ceb
Diff: https://reviews.apache.org/r/52876/diff/
Testing
---
1. existing unit testing
2. patch a cluster with the change
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52964/#review153083
---
Ship it!
Ship It!
- Di Li
On Oct. 18, 2016, 12:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53143/#review153743
---
Ship it!
Ship It!
- Di Li
On Oct. 24, 2016, 6:32 p.m
/components/job-details.hbs
(line 55)
<https://reviews.apache.org/r/53144/#comment223154>
can this be externalized to a i18n file instead of hardcoding it at the UI
level ?
- Di Li
On Oct. 24, 2016, 5:20 p.m., Sangeeta Ravindran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53126/#review153739
---
Ship it!
Ship It!
- Di Li
On Oct. 24, 2016, 1:33 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53086/#review153594
---
Ship it!
Ship It!
- Di Li
On Oct. 21, 2016, 6:39 p.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53075/#review153564
---
Ship it!
Ship It!
- Di Li
On Oct. 20, 2016, 8:41 p.m
d of an exact null ?
contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js
(line 30)
<https://reviews.apache.org/r/53075/#comment222776>
Should this one be checking for falsy instead of an exact null ?
- Di Li
On Oct. 20, 2016, 8:41 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53086/#review153544
---
Ship it!
Ship It!
- Di Li
On Oct. 21, 2016, 12:45 p.m., Tim
-agent/src/test/python/ambari_agent/TestHostCleanup.py 165c5f0
Diff: https://reviews.apache.org/r/53673/diff/
Testing
---
unit test
patched a 2.5 cluster with the changes and run host cleanup with two .ini files
I created.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53678/#review155813
---
Ship it!
Ship It!
- Di Li
On Nov. 11, 2016, 8:46 p.m., Tim
it to Ambari trunk cluster, update
upgrade xml files with the new service check, then run upgrade, verify it fails
prechecks accordingly.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53958/#review156502
---
Ship it!
Ship It!
- Di Li
On Nov. 21, 2016, 6:53 p.m., Tim
://reviews.apache.org/r/54028/diff/
Testing
---
existing unit tests still cover the code change.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53984/#review156573
---
Ship it!
Ship It!
- Di Li
On Nov. 22, 2016, 2 p.m., Tim
/54028/diff/
Testing (updated)
---
existing unit tests still cover the code change
patch a cluster with the new script.py, run service restart, verify the install
check still passes.
Thanks,
Di Li
e "HDP.2.6." prefix label and the text field align
properly and does not protrude the border.
Thanks,
Di Li
cluster with the change, resize web browsers to various sizes,
verify the "Name:" label, the "HDP.2.6." prefix label and the text field align
properly and does not protrude the border.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157036
---
Ship it!
Ship It!
- Di Li
On Nov. 28, 2016, 12:59 p.m
the "Bugs:" field ?
- Di Li
On Nov. 28, 2016, 12:59 p.m., Weiwei Yang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
/custom_actions/scripts/install_packages.py
0e31310
Diff: https://reviews.apache.org/r/54028/diff/
Testing
---
existing unit tests still cover the code change
patch a cluster with the new script.py, run service restart, verify the install
check still passes.
Thanks,
Di Li
d e-mail. To reply, visit:
https://reviews.apache.org/r/54086/#review157142
-------
On Nov. 25, 2016, 6:49 p.m., Di Li wrote:
>
> ---
> This is an a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53808/#review156061
---
Ship it!
Ship It!
- Di Li
On Nov. 16, 2016, 1:16 p.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53678/#review155970
---
Ship it!
Ship It!
- Di Li
On Nov. 15, 2016, 4:16 p.m., Tim
/TestHostCleanup.py 165c5f0
Diff: https://reviews.apache.org/r/53673/diff/
Testing
---
unit test
patched a 2.5 cluster with the changes and run host cleanup with two .ini files
I created.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53788/#review155981
---
Ship it!
Ship It!
- Di Li
On Nov. 15, 2016, 5:05 p.m
/TimelineMetricStore.java
15644ed
Diff: https://reviews.apache.org/r/53798/diff/
Testing
---
typo is in javadoc, no unit tests required.
Thanks,
Di Li
-agent/src/test/python/ambari_agent/TestHostCleanup.py 165c5f0
Diff: https://reviews.apache.org/r/53673/diff/
Testing
---
unit test
patched a 2.5 cluster with the changes and run host cleanup with two .ini files
I created.
Thanks,
Di Li
> On Nov. 4, 2016, 3:03 p.m., Di Li wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Hi Di,
>
> Can you please help commit this patch? I haven't pushed changed to trunk
> before and would appreciate your help. Thanks.
Hello Sangeeta,
Could you rebas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53273/#review154392
---
Ship it!
Ship It!
- Di Li
On Nov. 1, 2016, 5:39 a.m., Anita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53265/#review154310
---
Ship it!
Ship It!
- Di Li
On Oct. 31, 2016, 8:10 p.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53346/#review154436
---
Ship it!
Ship It!
- Di Li
On Nov. 1, 2016, 6:47 p.m., Tim
-details.js
(line 98)
<https://reviews.apache.org/r/53103/#comment223599>
Will "No messages present" be displayed in the log textarea ? can it be
more of an error notification ?
- Di Li
On Oct. 27, 2016, 9:56 p.m., Sangeeta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53200/#review154094
---
Ship it!
Ship It!
- Di Li
On Oct. 26, 2016, 6:27 p.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53104/#review154096
---
Ship it!
Ship It!
- Di Li
On Oct. 27, 2016, 9:20 p.m
SL_API, DEFAULT_SSL_API_PORT, SSL_API_PORT
- Di Li
On Oct. 28, 2016, 9:46 p.m., Anita Jebaraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53103/#review154264
---
Ship it!
Ship It!
- Di Li
On Oct. 27, 2016, 9:56 p.m
> On Oct. 28, 2016, 4:04 a.m., Di Li wrote:
> > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js,
> > line 98
> > <https://reviews.apache.org/r/53103/diff/1/?file=1543254#file1543254line98>
> >
> > Will "No messages pre
Diffs
-
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
df418f0
Diff: https://reviews.apache.org/r/53416/diff/
Testing
---
manually patch a trunk cluster for the test
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52455/#review154910
---
Ship it!
Ship It!
- Di Li
On Nov. 4, 2016, 9:23 a.m
> On Oct. 28, 2016, 4:04 a.m., Di Li wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Thank you Di.
pushed to trunk as
https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=d48b4639aa6a484353e01b43797c7
> On Oct. 28, 2016, 4:04 a.m., Di Li wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Thank you Di.
>
> Di Li wrote:
> pushed to trunk as
> https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=d48b4639aa6a484353e01b43797c7e304c36857d
pushed
>
> > In addition, you should be adding more than one reviewer (and get more than
> > one Ship It) before pushing code like this.
>
> Di Li wrote:
> It will not cause failure as the check compares services installed on the
> cluster instead of the full stack servic
of the full stack service list.
- Di
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54086/#review157246
-------
O
> >
> > Why not return an empty list instead of null?
fixed.
- Di
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54086/#review157159
----------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54171/#review157321
---
Ship it!
Ship It!
- Di Li
On Nov. 29, 2016, 7 p.m., Tim
it to Ambari trunk cluster, update
upgrade xml files with the new service check, then run upgrade, verify it fails
prechecks accordingly.
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54276/#review158348
---
Ship it!
Ship It!
- Di Li
On Dec. 2, 2016, 8:19 p.m
is resolved now.
- Di Li
On Nov. 29, 2016, 3:56 a.m., Weiwei Yang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
.apache.org/r/54543/diff/
Testing
---
build Ambari RPMs, install a trunk cluster with my own RPMs, verify the double
"/"s are trimmed now.
Thanks,
Di Li
preinstall.sh 524fea8
Diff: https://reviews.apache.org/r/54543/diff/
Testing
---
build Ambari RPMs, install a trunk cluster with my own RPMs, verify the double
"/"s are trimmed now.
Thanks,
Di Li
es, update new stack to remove Spark ( leaving
only Spark 2), run Install Packages, verify it didn't fail with the "Cannot
enumerate services" error.
Thanks,
Di Li
a valid service, while both Spark2
and Spark (via inheritance) are marked as deleted.
- Di
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54665/#review158892
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54815/#review159467
---
Ship it!
Ship It!
- Di Li
On Dec. 16, 2016, 5:42 p.m
committed ?
- Di Li
On Dec. 5, 2016, 9:09 p.m., Jesus Alvarez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
new stack to remove Spark ( leaving
only Spark 2), run Install Packages, verify it didn't fail with the "Cannot
enumerate services" error.
Thanks,
Di Li
a trunk cluster with the change, run HostCleanup.py
Thanks,
Di Li
preinstall.sh 524fea8
Diff: https://reviews.apache.org/r/54543/diff/
Testing
---
build Ambari RPMs, install a trunk cluster with my own RPMs, verify the double
"/"s are trimmed now.
Thanks,
Di Li
ec 5 11:27 resource_management ->
> //usr/lib/ambari-server/lib/resource_management
> drwxr-xr-x 5 ams hadoop 83 Dec 6 09:26 resource_monitoring
>
>
> Diffs
> -
>
> ambari-server/conf/unix/install-helper.sh 34ec0e9
> ambari-server/src/main/package/rpm/posttrans_server.sh a719cae
> ambari-server/src/main/package/rpm/preinstall.sh 524fea8
>
> Diff: https://reviews.apache.org/r/54543/diff/
>
>
> Testing
> ---
>
> build Ambari RPMs, install a trunk cluster with my own RPMs, verify the
> double "/"s are trimmed now.
>
>
> Thanks,
>
> Di Li
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55522/#review161599
---
Ship it!
Ship It!
- Di Li
On Jan. 13, 2017, 9:35 p.m
> > -1. If the config doesn't exist at all, that's a problem and we
> > shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing
> > knoxsso-topology?
> >
> > I want to understand the root cause first.
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55518/#review161597
---
Ship it!
Ship It!
- Di Li
On Jan. 13, 2017, 7:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55460/#review161381
---
Ship it!
Ship It!
- Di Li
On Jan. 12, 2017, 1:28 p.m., Tim
> On Jan. 3, 2017, 4:09 p.m., Di Li wrote:
> > Ship It!
>
> ping wang wrote:
> Hi Di, could you please help commit the code? Thanks!
Done. Please close this RB request.
- Di
---
This is an automatically generate
/
Testing
---
existing unit test
build Ambari RPMS off trunk code and install a cluster.
Thanks,
Di Li
g
unnecessary properties to existing configuration xml files.
- Di
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
----------
/upgrade_history_view.js (line 294)
<https://reviews.apache.org/r/54224/#comment228048>
var displayName = type ? type.get('displayName') :
record.get('upgradeType');
Should still try to normalize the name, so that "FUTURE_UPGRADE_TYPE" can
be converted to "Future Upgrade Type&qu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/#review157599
---
Ship it!
Ship It!
- Di Li
On Dec. 1, 2016, 10:13 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54145/#review157600
---
Ship it!
Ship It!
- Di Li
On Nov. 30, 2016, 11:54 p.m
it?
- Di Li
On Dec. 2, 2016, 12:29 a.m., Vishal Ghugare wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54314/#review157794
---
Ship it!
Ship It!
- Di Li
On Dec. 2, 2016, 6:18 p.m., Jesus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54259/#review157793
---
Ship it!
Ship It!
- Di Li
On Dec. 2, 2016, 5:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160392
---
Ship it!
Ship It!
- Di Li
On Dec. 24, 2016, 7:12 a.m., ping
://reviews.apache.org/r/55345/diff/
Testing
---
existing unit test
patch trunk cluster run installation
Thanks,
Di Li
4cdd280
Diff: https://reviews.apache.org/r/55344/diff/
Testing
---
existing unit test
patch trunk cluster run installation
Thanks,
Di Li
. Verify hdfs restart
finishes successfully without errotd. ambari-server.log has error messages
about unable to find the property within the given config type for the
particular configuration version tag.
Thanks,
Di Li
errotd. ambari-server.log has error messages
about unable to find
Thanks,
Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54908/#review159741
---
Ship it!
Ship It!
- Di Li
On Dec. 20, 2016, 5:51 p.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54911/#review159806
---
Ship it!
Ship It!
- Di Li
On Dec. 20, 2016, 8:53 p.m
/stacks/HDP/3.0/hooks/before-START/scripts/params.py
d838211
Diff: https://reviews.apache.org/r/54872/diff/
Testing
---
exsiting unit tests
Patch a 2.4 cluster (Ambari upgraded to trunk build) with the changes, run EU,
then run downgrade once it reaches the Finalize step.
Thanks,
Di Li
/package/scripts/params_linux.py
(line 70)
<https://reviews.apache.org/r/54970/#comment231082>
I don't think spark_home is being used by Oozie Python script. Can this be
shorten to spark_conf = format("{stack_root}/current/spark-client/conf")
- Di Li
On Dec. 23, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55009/#review160090
---
Ship it!
Ship It!
- Di Li
On Dec. 23, 2016, 7:14 a.m
101 - 200 of 409 matches
Mail list logo
