Re: Review Request 48850: Views in Ambari UI don't render when proxied by Knox

2016-06-17 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48850/#review138216 --- Ship it! Ship It! - Oleg Nechiporenko On June 17, 2016, 1

Review Request 56160: 'num_llap_nodes' should show up as non-editable property when non-ambari managed queue is selected

2017-02-01 Thread Oleg Nechiporenko
Thanks, Oleg Nechiporenko

Review Request 56325: Confirmation for deleting services show serviceName and not displayName

2017-02-06 Thread Oleg Nechiporenko
3 ambari-web/test/controllers/main/service/item_test.js b582e86 Diff: https://reviews.apache.org/r/56325/diff/ Testing --- 20327 passing (21s) 153 pending Thanks, Oleg Nechiporenko

Review Request 56381: A lot of warning messages after opening "Upgrade to ..."-popup

2017-02-07 Thread Oleg Nechiporenko
26 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Review Request 56441: Js errors appear when user try to delete widgets from dashboard

2017-02-08 Thread Oleg Nechiporenko
test/views/main/dashboard/widget_test.js 8582ad0 ambari-web/test/views/main/dashboard/widgets_test.js b2d154b Diff: https://reviews.apache.org/r/56441/diff/ Testing --- 20338 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Re: Review Request 56445: Ranger Admin HA Wizard should show all configuration changes on Review step

2017-02-08 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56445/#review164680 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 8, 2017, 1:41

Review Request 56321: Popup with alerts on the Service summary doesn't have arrows for alerts with state "None"

2017-02-06 Thread Oleg Nechiporenko
Thanks, Oleg Nechiporenko

Review Request 56273: JS error on host configs page

2017-02-03 Thread Oleg Nechiporenko
mainView.columns').someProperty('selected')) ||}} Diffs - ambari-web/app/views/common/configs/service_configs_by_category_view.js d9b4409 Diff: https://reviews.apache.org/r/56273/diff/ Testing --- 30313 passing (23s) 157 pending Thanks, Oleg Nechiporenko

Review Request 55838: Alert Popup doesn't execute callback if it's closed without click on "Primary"

2017-01-23 Thread Oleg Nechiporenko
ews/common/modal_popups/alert_popup.js 413d33c Diff: https://reviews.apache.org/r/55838/diff/ Testing --- 20467 tests complete (31 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 55919: "Add Config Property" causes JS-error

2017-01-25 Thread Oleg Nechiporenko
configs/service_configs_by_category_view.js 4148197 Diff: https://reviews.apache.org/r/55919/diff/ Testing --- 20474 tests complete (30 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 55918: Move HS2 does not install dependent components on the target host

2017-01-25 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55918/#review162936 --- Ship it! Ship It! - Oleg Nechiporenko On Jan. 25, 2017, 9

Review Request 55979: Wizard modals are closed before confirmation popup appears

2017-01-26 Thread Oleg Nechiporenko
trap Modal has its own Esc-press handler. It should be disabled Diffs - ambari-web/app/views/common/modal_popup.js 47b7d61 Diff: https://reviews.apache.org/r/55979/diff/ Testing --- 20476 tests complete (32 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 56923: Add polyfills for Array.includes and String.includes

2017-02-22 Thread Oleg Nechiporenko
df64cbe Diff: https://reviews.apache.org/r/56923/diff/ Testing --- 20421 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Review Request 56891: Password fields are not disabled when should be

2017-02-21 Thread Oleg Nechiporenko
) 153 pending Thanks, Oleg Nechiporenko

Review Request 57022: After disabling security page is not refreshed

2017-02-24 Thread Oleg Nechiporenko
24s) 153 pending Thanks, Oleg Nechiporenko

Review Request 57034: Handle on UI error on services API while trying to start all services with atleast one component in INSTALL_FAILED state

2017-02-24 Thread Oleg Nechiporenko
) 153 pending Thanks, Oleg Nechiporenko

Re: Review Request 57037: Manage Configuration Group Hosts popup is way too small to be useful when it is needed

2017-02-24 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57037/#review166703 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 24, 2017, 1

Re: Review Request 56957: Click feedback/disable toggle is missing for transition buttons in Kerberos Wizard - prone to various failures

2017-02-23 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56957/#review166494 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 23, 2017, 8

Review Request 56653: UI on Admin page-> Auto Start tab is not consistent

2017-02-14 Thread Oleg Nechiporenko
Testing --- 20345 passing (21s) 153 pending Thanks, Oleg Nechiporenko

Review Request 56485: Confusing Auto Start settings page behavior when loading and API takes a while

2017-02-09 Thread Oleg Nechiporenko
ambari-web/app/templates/main/admin/service_auto_start.hbs 87fc915 ambari-web/app/views/main/admin/service_auto_start.js be928ed Diff: https://reviews.apache.org/r/56485/diff/ Testing --- 30312 passing (22s) 157 pending Thanks, Oleg Nechiporenko

Review Request 56664: JS error in the "Supervisors Live" widget

2017-02-14 Thread Oleg Nechiporenko
(24s) 153 pending Thanks, Oleg Nechiporenko

Review Request 56597: Externalize the logic for making navigation bar interactive

2017-02-13 Thread Oleg Nechiporenko
/scripts/theme/bootstrap-ambari.js PRE-CREATION Diff: https://reviews.apache.org/r/56597/diff/ Testing --- 20325 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Re: Review Request 56495: Service Config pages load very slowly

2017-02-09 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56495/#review164918 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 9, 2017, 1:16

Review Request 56750: Don't rerender all widgets when on of them is changed

2017-02-16 Thread Oleg Nechiporenko
/edit_dashboard_widget_popup_test.js PRE-CREATION ambari-web/test/views/main/dashboard/widget_test.js a504c6d ambari-web/test/views/main/dashboard/widgets_test.js 5d1ddb2 Diff: https://reviews.apache.org/r/56750/diff/ Testing --- 20372 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Re: Review Request 56714: Override property popup: Redundant scrollbars in config groups list

2017-02-15 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56714/#review165720 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 15, 2017, 4

Review Request 55673: Add UI UT for alerts

2017-01-18 Thread Oleg Nechiporenko
/alert_config_test.js 74a91f4 ambari-web/test/models/alerts/alert_group_test.js 036a32d ambari-web/test/models/alerts/alert_notification_test.js PRE-CREATION Diff: https://reviews.apache.org/r/55673/diff/ Testing --- 20454 tests complete (32 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 55711: Admin View: add spinners for tables in loading state

2017-01-19 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55711/#review162268 --- Ship it! Ship It! - Oleg Nechiporenko On Jan. 19, 2017, 10

Review Request 55560: Timezone for timestamps in Upgrade History not consistent with Background Operations

2017-01-16 Thread Oleg Nechiporenko
://reviews.apache.org/r/55560/diff/ Testing --- 20389 tests complete (31 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 55618: Ranger Admin HA Wizard should display configs changes explicitly

2017-01-17 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55618/#review161862 --- Ship it! Ship It! - Oleg Nechiporenko On Jan. 17, 2017, 1

Review Request 55752: Not completed Upgrade History items show End Time as "Not started"

2017-01-20 Thread Oleg Nechiporenko
js c82a02e ambari-web/test/views/main/admin/stack_upgrade/upgrade_history_view_test.js cecf98f Diff: https://reviews.apache.org/r/55752/diff/ Testing --- 20460 tests complete (32 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 57081: Not able to delete custom property

2017-02-27 Thread Oleg Nechiporenko
he.org/r/57081/diff/ Testing --- 20490 passing (23s) 153 pending Thanks, Oleg Nechiporenko

Review Request 57138: Don't recalculate side-menu content when moving to the views

2017-02-28 Thread Oleg Nechiporenko
, Oleg Nechiporenko

Re: Review Request 53650: Stack Versions page: fix styles

2016-11-10 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53650/#review155604 --- Ship it! Ship It! - Oleg Nechiporenko On Nov. 10, 2016, 4

Re: Review Request 54063: typeahead was lost while bootstrap 2 to bootstrap3 mirgation

2016-11-24 Thread Oleg Nechiporenko
) 154 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 53846: Kerberos wizard: Show recommendation API failure message in a popup

2016-11-17 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53846/#review156201 --- Ship it! Ship It! - Oleg Nechiporenko On Nov. 17, 2016, 2

Review Request 54734: BG operations modal windows are too small to show the content (in certain scenarios) [Chrome]

2016-12-14 Thread Oleg Nechiporenko
Diffs - ambari-web/app/views/common/modal_popup.js a643b23 ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js f3f05a4 Diff: https://reviews.apache.org/r/54734/diff/ Testing --- 19878 tests complete (40 seconds) 155 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 54742: Turning OFF maintenance mode shows a popup on all hosts

2016-12-14 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54742/#review159147 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 14, 2016, 1

Re: Review Request 54780: Restore styles of remove repository icon

2016-12-15 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54780/#review159291 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 15, 2016, 1

Review Request 54786: DataNodes Live widget can't be edited

2016-12-15 Thread Oleg Nechiporenko
js 563e31d ambari-web/app/views/main/dashboard/widgets/pxf_live.js a002fe3 ambari-web/test/controllers/main/admin/highAvailability_controller_test.js f5a144b Diff: https://reviews.apache.org/r/54786/diff/ Testing --- 19882 tests complete (25 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 54779: SMTP Username and SMTP Password are not highlighted

2016-12-15 Thread Oleg Nechiporenko
ed Diffs - ambari-web/app/templates/common/configs/notifications_configs.hbs 2dd71aa Diff: https://reviews.apache.org/r/54779/diff/ Testing --- 19879 tests complete (33 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 55426: JS error when user click Alert Link in the popup on the service summary page

2017-01-11 Thread Oleg Nechiporenko
/controllers/main/service/info/summary.js fc423fe Diff: https://reviews.apache.org/r/55426/diff/ Testing --- 20389 tests complete (33 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 55484: Two SelectBoxes don't have class `form-control`

2017-01-13 Thread Oleg Nechiporenko
/select_groups_popup.hbs c7da8a4 ambari-web/app/templates/main/service/add_host_popup.hbs 7431080 Diff: https://reviews.apache.org/r/55484/diff/ Testing --- 20389 tests complete (32 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 55415: Screen stuck when no suitable OS is detected

2017-01-11 Thread Oleg Nechiporenko
apache.org/r/55415/diff/ Testing --- 20389 tests complete (36 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 54162: Fix markup for widgets browser

2016-11-29 Thread Oleg Nechiporenko
/chosen_plugin.js 95f6c1e ambari-web/app/views/common/controls_view.js 37d7165 ambari-web/app/views/main/service/widgets/create/step2_view.js dbc5bc7 Diff: https://reviews.apache.org/r/54162/diff/ Testing --- 19935 tests complete (31 seconds) 154 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 54155: Fix input height in filters with dropdown

2016-11-29 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54155/#review157225 --- Ship it! Ship It! - Oleg Nechiporenko On Nov. 29, 2016, 11

Review Request 54203: Manage JournalNode tweaks

2016-11-30 Thread Oleg Nechiporenko
. Diffs - ambari-web/app/messages.js aa43687 ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 547d364 Diff: https://reviews.apache.org/r/54203/diff/ Testing --- 20020 tests complete (31 seconds) 155 tests pending Thanks, Oleg Nechiporenko

Review Request 54369: JS error on "User RedHat Satellite" click on step1 installer

2016-12-05 Thread Oleg Nechiporenko
07087a Diff: https://reviews.apache.org/r/54369/diff/ Testing --- 19917 tests complete (28 seconds) 155 tests pending Thanks, Oleg Nechiporenko

Review Request 54253: Select Versions page: 'Remove' tooltip does not disappear

2016-12-01 Thread Oleg Nechiporenko
/54253/diff/ Testing --- 20020 tests complete (30 seconds) 155 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 55212: When deleting services UI shows a lot of configs to be changing but none changes

2017-01-05 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55212/#review160588 --- Ship it! Ship It! - Oleg Nechiporenko On Янв. 5, 2017, 2:49

Re: Review Request 55102: Install Wizard cannot proceed beyond Select Services page

2016-12-30 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55102/#review160297 --- Ship it! Ship It! - Oleg Nechiporenko On Дек. 30, 2016, 1

Review Request 55101: Install Wizard needs to scroll back up to top on step transitions

2016-12-30 Thread Oleg Nechiporenko
. This is quite annoying. Diffs - ambari-web/app/routes/installer.js b4aa799 ambari-web/app/utils/ember_reopen.js 4fd7cd4 Diff: https://reviews.apache.org/r/55101/diff/ Testing --- 19991 tests complete (27 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 55210: Config Groups: Save button not enabled while trying to overwrite configs

2017-01-05 Thread Oleg Nechiporenko
Diff: https://reviews.apache.org/r/55210/diff/ Testing --- 20126 tests complete (25 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 55086: Recommended configs changes are displayed twice before adding or deleting Nimbus

2016-12-29 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55086/#review160277 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 29, 2016, 4

Review Request 55081: Adding custom property should trim white spaces in the prefix and suffix of the key names

2016-12-29 Thread Oleg Nechiporenko
, Oleg Nechiporenko

Review Request 55380: Add macros `existsInByKey` and `notExistsInByKey`

2017-01-10 Thread Oleg Nechiporenko
tests pending Thanks, Oleg Nechiporenko

Re: Review Request 55376: Ambari should add warning when LogSearch selected without Ambari-Infra

2017-01-10 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55376/#review161057 --- Ship it! Ship It! - Oleg Nechiporenko On Jan. 10, 2017, 11

Review Request 54934: NN HA Namespace input "jumps" when invalid value provided

2016-12-21 Thread Oleg Nechiporenko
-web/app/templates/main/admin/highAvailability/nameNode/step1.hbs f5087f9 ambari-web/test/controllers/main/host/details_test.js 4203644 Diff: https://reviews.apache.org/r/54934/diff/ Testing --- 19866 tests complete (24 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 55015: Background Operations popup: no name for operations

2016-12-23 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55015/#review160093 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 23, 2016, 4

Review Request 55070: UI should validate Ranger user password be more than 8 chars

2016-12-28 Thread Oleg Nechiporenko
/service_config_property_test.js ef0bd61 Diff: https://reviews.apache.org/r/55070/diff/ Testing --- 19984 tests complete (27 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 54971: AHW Configurations page looks not like any other wizard page

2016-12-22 Thread Oleg Nechiporenko
--- 19866 tests complete (30 seconds) 153 tests pending Thanks, Oleg Nechiporenko

Review Request 54482: Tooltip is not hidden on host alerts page

2016-12-07 Thread Oleg Nechiporenko
/host_alerts_view.js 34a2a3e ambari-web/test/views/main/host/host_alerts_view_test.js 2c0d59a Diff: https://reviews.apache.org/r/54482/diff/ Testing --- 19926 tests complete (26 seconds) 155 tests pending Thanks, Oleg Nechiporenko

Re: Review Request 57907: Versions page: unable to set 'Skip Repository Base URL validation' option

2017-03-24 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57907/#review17 --- Ship it! Ship It! - Oleg Nechiporenko On March 24, 2017, 11

Review Request 57985: Comparison for configs with list of hostNames doesn't show all hosts correctly

2017-03-28 Thread Oleg Nechiporenko
nt_hosts.hbs 802b970 ambari-web/app/views/common/controls_view.js 120ca9a ambari-web/test/views/common/controls_view_test.js 3ff5253 Diff: https://reviews.apache.org/r/57985/diff/1/ Testing --- 20606 passing (23s) 128 pending Thanks, Oleg Nechiporenko

Review Request 57943: Not all config groups are shown in the config history table

2017-03-27 Thread Oleg Nechiporenko
-web/test/views/main/dashboard/config_history_view_test.js d799c44 Diff: https://reviews.apache.org/r/57943/diff/1/ Testing --- 20606 passing (21s) 128 pending Thanks, Oleg Nechiporenko

Review Request 57637: Few breadcrumbs are missing

2017-03-15 Thread Oleg Nechiporenko
://reviews.apache.org/r/57637/diff/1/ Testing --- 20578 passing (21s) 153 pending Thanks, Oleg Nechiporenko

Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-16 Thread Oleg Nechiporenko
://reviews.apache.org/r/57507/diff/2/ Changes: https://reviews.apache.org/r/57507/diff/1-2/ Testing --- 20559 passing (23s) 153 pending Thanks, Oleg Nechiporenko

Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-17 Thread Oleg Nechiporenko
pared. IDK what UX impact it may do. - Oleg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/#review169207 --- On March 16, 2017, 12:4

Review Request 57688: Start/Stop Service command may silently fail without any reporting for user

2017-03-16 Thread Oleg Nechiporenko
-- ambari-web/app/controllers/main/service/item.js 5169564 ambari-web/test/controllers/main/service/item_test.js c4a50ea Diff: https://reviews.apache.org/r/57688/diff/1/ Testing --- 20580 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Re: Review Request 58300: Remove singleNodeInstall flag from ambari-web code

2017-04-10 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58300/#review171442 --- Ship it! Ship It! - Oleg Nechiporenko On April 10, 2017, 1

Review Request 58345: Remove duplicate condition from route

2017-04-11 Thread Oleg Nechiporenko
ambari-web/test/init_test.js db72744 Diff: https://reviews.apache.org/r/58345/diff/1/ Testing --- 20663 passing (23s) 128 pending Thanks, Oleg Nechiporenko

Re: Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches

2017-03-09 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57268/#review168466 --- Ship it! Ship It! - Oleg Nechiporenko On Март 8, 2017, 12

Re: Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches

2017-03-09 Thread Oleg Nechiporenko
--- > > (Updated March 8, 2017, 12:39 a.m.) > > > Review request for Ambari, Andrii Babiichuk, Jaimin Jetly, Oleg Nechiporenko, > and Yusaku Sako. > > > Bugs: AMBARI-20287 > https://issues.apache.org/jira/browse/AMBARI-20287 > > >

Review Request 57457: Remove duplicate code from wizard menu

2017-03-09 Thread Oleg Nechiporenko
4adbf11 Diff: https://reviews.apache.org/r/57457/diff/1/ Testing --- 20573 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Review Request 57554: JS error when filtering config history table

2017-03-13 Thread Oleg Nechiporenko
/table_server_view_mixin.js d44a09e ambari-web/app/views/main/dashboard/config_history_view.js 7bd9e4a ambari-web/test/mixins/common/table_server_view_mixin_test.js ae750de Diff: https://reviews.apache.org/r/57554/diff/1/ Testing --- 20559 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Review Request 57591: Alert Definition "Last Changed" field is shown incorrect if alert wan't triggered any time

2017-03-14 Thread Oleg Nechiporenko
ng --- 20562 passing (21s) 153 pending Thanks, Oleg Nechiporenko

Re: Review Request 57600: Services actions menu is not fully displayed under some circumstances

2017-03-14 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57600/#review168900 --- Ship it! Ship It! - Oleg Nechiporenko On March 14, 2017, 2

Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-10 Thread Oleg Nechiporenko
9890525 Diff: https://reviews.apache.org/r/57507/diff/1/ Testing --- 20559 passing (23s) 153 pending Thanks, Oleg Nechiporenko

Review Request 57367: Alert Definition Name with brackets marked as invalid

2017-03-07 Thread Oleg Nechiporenko
ri-web/app/messages.js 44bf13e ambari-web/app/utils/validator.js 5173702 ambari-web/test/utils/validator_test.js 8565b3d Diff: https://reviews.apache.org/r/57367/diff/1/ Testing --- 20575 passing (23s) 153 pending Thanks, Oleg Nechiporenko

Review Request 57280: While Comparing versions, value in latest version is not shown for custom property

2017-03-03 Thread Oleg Nechiporenko
--- 20574 passing (22s) 153 pending Thanks, Oleg Nechiporenko

Review Request 57286: Popup "Save changed" appears when user switches config versions

2017-03-03 Thread Oleg Nechiporenko
- ambari-web/app/views/common/configs/config_history_flow.js 0cd6b7f Diff: https://reviews.apache.org/r/57286/diff/1/ Testing --- 30365 passing (22s) 157 pending Thanks, Oleg Nechiporenko

Re: Review Request 58207: Select Version step of installer: repo URL validation message issues

2017-04-05 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58207/#review171115 --- Ship it! Ship It! - Oleg Nechiporenko On April 5, 2017, 12

Re: Review Request 61373: Alerts list not sorted by status even though header displayed as sorted

2017-08-02 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61373/#review181953 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 2, 2017, 9:20

Re: Review Request 61710: Log Search UI: implement multiple options select for filters

2017-08-17 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61710/#review183115 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 17, 2017, 10

Re: Review Request 61549: Log Search UI: implement histogram for service logs

2017-08-10 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61549/#review182568 --- Ship it! Ship It! - Oleg Nechiporenko On Авг. 10, 2017, 10

Re: Review Request 60650: Log Search UI: production build issues

2017-07-05 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60650/#review179620 --- Ship it! Ship It! - Oleg Nechiporenko On July 5, 2017, 11

Re: Review Request 61424: Stack selection page does not load the HDP stacks

2017-08-04 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61424/#review182200 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 4, 2017, 12

Re: Review Request 61425: Services are not started for the correct count of nodes selected in the Hosts list

2017-08-04 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61425/#review182205 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 4, 2017, 1:44

Re: Review Request 61718: Log Search UI: implement histogram filtering by all possible criterias

2017-08-17 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61718/#review183143 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 17, 2017, 4

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

2017-09-14 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/#review185407 --- Ship it! Ship It! - Oleg Nechiporenko On Sept. 13, 2017, 6

Re: Review Request 62497: Log Search UI: host filter should be performed using hostList parameter

2017-09-22 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62497/#review185958 --- Ship it! Ship It! - Oleg Nechiporenko On Сен. 22, 2017, 8

Re: Review Request 62766: Log Search UI: add event bars for Components list item

2017-10-04 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62766/#review187082 --- Ship it! Ship It! - Oleg Nechiporenko On Окт. 4, 2017, 11

Re: Review Request 62184: Log Search UI: unit tests setup

2017-09-08 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62184/#review184966 --- Ship it! Ship It! - Oleg Nechiporenko On Сен. 8, 2017, 11

Re: Review Request 62689: Log Search UI: implement service logs actions functionality

2017-09-29 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62689/#review186665 --- Ship it! Ship It! - Oleg Nechiporenko On Сен. 29, 2017, 12

Re: Review Request 63587: Log Search UI: move top menu down

2017-11-06 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63587/#review190181 --- Ship it! Ship It! - Oleg Nechiporenko On Ноя. 6, 2017, 5:16

Re: Review Request 64446: Log Search UI: improve histogram display

2017-12-08 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64446/#review193241 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 8, 2017, 11