---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64989/
---
(Updated Jan. 5, 2018, 11:19 p.m.)
Review request for Ambari, Dmytro Sen and Si
(original), 44 (patched)
<https://reviews.apache.org/r/64991/#comment273981>
Extra ' character at the end.
- Aravindan Vijayan
On Jan. 5, 2018, 8:16 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-m
]
Thanks,
Aravindan Vijayan
/applicationhistoryservice/metrics/timeline/aggregators/ITMetricAggregator.java
1890819
ambari-metrics/pom.xml 6541cec
Diff: https://reviews.apache.org/r/64989/diff/1/
Testing
---
Unit testing.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64836/#review194562
---
Ship it!
Ship It!
- Aravindan Vijayan
On Dec. 25, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64837/#review194561
---
Ship it!
Ship It!
- Aravindan Vijayan
On Dec. 25, 2017, 4
/resources/common-services/STORM/1.0.1.3.0/service_advisor.py
as well.
- Aravindan Vijayan
On Dec. 25, 2017, 4:38 a.m., Jungtaek Lim wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
<https://reviews.apache.org/r/64789/#comment273131>
Change grep expression to new class name.
- Aravindan Vijayan
On Dec. 21, 2017, 10:36 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To
sit:
https://reviews.apache.org/r/64393/#review193087
---
On Dec. 8, 2017, 9:27 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To re
Diff: https://reviews.apache.org/r/64393/diff/2/
Changes: https://reviews.apache.org/r/64393/diff/1-2/
Testing
---
Manually tested.
Current unit tests pass.
New Unit tests being worked on...
Thanks,
Aravindan Vijayan
e work on EMA application. For this patch, I used EMA
as a simple example job.
- Aravindan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64393/#review193087
--------
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64393/#review193087
---
On Dec. 6, 2017, 10:52 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an
/diff/1/
Testing
---
Manually tested.
Current unit tests pass.
New Unit tests being worked on...
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64309/#review192726
---
Ship it!
Ship It!
- Aravindan Vijayan
On Dec. 4, 2017, 6:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64305/#review192724
---
Ship it!
Ship It!
- Aravindan Vijayan
On Dec. 4, 2017, 5:02
/params.py
b7004b8
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
c01b368
Diff: https://reviews.apache.org/r/64221/diff/3/
Changes: https://reviews.apache.org/r/64221/diff/2-3/
Testing
---
Manually tested.
Thanks,
Aravindan Vijayan
-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
c01b368
Diff: https://reviews.apache.org/r/64221/diff/2/
Changes: https://reviews.apache.org/r/64221/diff/1-2/
Testing
---
Manually tested.
Thanks,
Aravindan Vijayan
/scripts/params.py
b7004b8
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
c01b368
Diff: https://reviews.apache.org/r/64221/diff/1/
Testing
---
Manually tested.
Thanks,
Aravindan Vijayan
/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
30c5c23
Diff: https://reviews.apache.org/r/64088/diff/2/
Changes: https://reviews.apache.org/r/64088/diff/1-2/
Testing
---
Manually tested.
Unit tests pass.
Thanks,
Aravindan Vijayan
/HadoopTimelineMetricsSinkTest.java
30c5c23
ambari-metrics/pom.xml a14b8fd
Diff: https://reviews.apache.org/r/64088/diff/1/
Testing
---
Manually tested.
Unit tests pass.
Thanks,
Aravindan Vijayan
/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
32cc813
Diff: https://reviews.apache.org/r/63935/diff/2/
Changes: https://reviews.apache.org/r/63935/diff/1-2/
Testing
---
Unit testing and manual testing.
Thanks,
Aravindan Vijayan
/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
32cc813
Diff: https://reviews.apache.org/r/63935/diff/1/
Testing
---
Unit testing and manual testing.
Thanks,
Aravindan Vijayan
Tested.
Relevant unit tests pass.
Thanks,
Aravindan Vijayan
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63787/#review190921
-------
On Nov. 14, 2017, 6:16 a.m., Aravindan Vijayan wrote:
>
> -
/configs/default.json 43c184c
ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json
eaaeeb5
Diff: https://reviews.apache.org/r/63787/diff/1/
Testing
---
Manually Tested.
Relevant unit tests pass.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63542/#review190051
---
Ship it!
Ship It!
- Aravindan Vijayan
On Nov. 3, 2017, 5:07
://reviews.apache.org/r/63524/diff/1/
Testing
---
Unit testing.
(Apache JIRA seems to be unreachable. Will create jira once it is up.)
Thanks,
Aravindan Vijayan
create jira once it is up.)
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63477/#review189837
---
On Nov. 1, 2017, 10:37 p.m., Aravindan Vijayan wrote:
>
>
://reviews.apache.org/r/63477/diff/3/
Changes: https://reviews.apache.org/r/63477/diff/2-3/
Testing
---
Unit Testing.
Thanks,
Aravindan Vijayan
/63477/diff/1-2/
Testing
---
Unit Testing.
Thanks,
Aravindan Vijayan
-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
12bd463
Diff: https://reviews.apache.org/r/63477/diff/1/
Testing
---
Unit Testing.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63440/#review189753
---
Ship it!
Ship It!
- Aravindan Vijayan
On Oct. 31, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63449/#review189752
---
Ship it!
Ship It!
- Aravindan Vijayan
On Oct. 31, 2017, 6
a708384
Diff: https://reviews.apache.org/r/62989/diff/1/
Testing
---
mvn clean test.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62941/#review187849
---
Ship it!
Ship It!
- Aravindan Vijayan
On Oct. 12, 2017, 7
/scala/org/apache/ambari/metrics/adservice/resource/RootResource.scala
Lines 33 (patched)
<https://reviews.apache.org/r/62941/#comment264881>
Can we change this to something AD specific ?
- Aravindan Vijayan
On Oct. 12, 2017, 6:09 p.m., Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62756/#review186999
---
Ship it!
Ship It!
- Aravindan Vijayan
On Oct. 3, 2017, 7:48
NFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 08:21 min
[INFO] Finished at: 2017-09-27T11:57:06-07:00
[INFO] Final Memory: 149M/1616M
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/#review185920
---
Ship it!
Ship It!
- Aravindan Vijayan
On Sept. 21, 2017, 7
s/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
Line 789 (original), 803 (patched)
<https://reviews.apache.org/r/62474/#comment262250>
Unrelated query, but shouldnt this be in ams-env? We would ideally need
restart of metrics collector and monitors for this change.
-
--
On Sept. 13, 2017, 7:49 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62292/
>
views.apache.org/media/uploaded/files/2017/09/13/ce769beb-f026-4d9e-9530-3218327584be__Screen_Shot_2017-09-13_at_12.13.24_PM.png
Thanks,
Aravindan Vijayan
tacks/2.2/common/test_stack_advisor.py 9c6bef1
Diff: https://reviews.apache.org/r/62292/diff/1/
Testing
---
Manually tested.
Python unit tests passed.
Thanks,
Aravindan Vijayan
ces/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
071882b
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
db6ebc1
Diff: https://reviews.apache.org/r/62125/diff/2/
Testing (updated)
---
Manually tested.
python unit tests pass.
ests pass.
Thanks,
Aravindan Vijayan
.apache.org/r/62125/diff/1-2/
Testing
---
Manually tested.
python unit tests pass.
Thanks,
Aravindan Vijayan
stack widget definition files.
- Aravindan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62250/#review185215
-------
On Sept.
Diff: https://reviews.apache.org/r/62250/diff/1/
Testing
---
Manually tested.
UpgradeCatalog260 test added.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61998/#review184933
---
Ship it!
Ship It!
- Aravindan Vijayan
On Sept. 5, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62169/#review184877
---
Ship it!
Ship It!
- Aravindan Vijayan
On Sept. 7, 2017, 7
9a31ade
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
6975bec
Diff: https://reviews.apache.org/r/62125/diff/1/
Testing
---
Manually tested.
python unit tests pass.
Thanks,
Aravindan Vijayan
/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-regionservers.json
3184357
Diff: https://reviews.apache.org/r/62097/diff/1/
Testing
---
Manually tested.
Thanks,
Aravindan Vijayan
/
Testing
---
Manually tested.
mvn clean test on ambari-server.
Thanks,
Aravindan Vijayan
/HBaseTimelineMetricsService.java
98904fd
Diff: https://reviews.apache.org/r/61510/diff/1/
Testing
---
mvn clean test.
Manually tested.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61481/#review182339
---
Ship it!
Ship It!
- Aravindan Vijayan
On Aug. 7, 2017, 10
che.org/r/61386/#review182033
---
On Aug. 2, 2017, 8:20 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
Nifi-Hosts)
Thanks,
Aravindan Vijayan
/datasource.js
Line 300 (original), 300 (patched)
<https://reviews.apache.org/r/61248/#comment257601>
Can you check if this issue exists in HBase-Users, HBase-Tables, HDFS-Users
etc as well? If yes, please fix the issue for those dashboards also.
- Aravindan Vijayan
On July 31, 2017, 6:32 a.m
.
Thanks,
Aravindan Vijayan
hed)
> > <https://reviews.apache.org/r/61203/diff/1/?file=1785078#file1785078line127>
> >
> > What was the reason, both instances failed?
>
> Aravindan Vijayan wrote:
> It is because of the code which deleted and recreated the znode whenever
> a sub path
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61203/#review181646
-------
On July 28, 2017, 4:50 a.m., Aravindan Vijayan wrote:
>
> ---
> This
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/61203/#review181647
-------
On July 28, 2017, 4:50 a.m., Aravindan Vijayan wrote:
>
> ---
> This is an au
ps://reviews.apache.org/r/61203/#review181646
-------
On July 28, 2017, 4:50 a.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail.
/yarn/server/applicationhistoryservice/metrics/timeline/availability/MetricCollectorHAController.java
53e6304
Diff: https://reviews.apache.org/r/61203/diff/1/
Testing
---
Manually tested.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60198/#review180140
---
Ship it!
Ship It!
- Aravindan Vijayan
On July 10, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60424/#review178904
---
Ship it!
Ship It!
- Aravindan Vijayan
On June 26, 2017, 10
dbb51cf
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
d7d905c
Diff: https://reviews.apache.org/r/60399/diff/1/
Testing
---
Manually tested.
mvn clean test passed.
Thanks,
Aravindan Vijayan
nges: https://reviews.apache.org/r/60201/diff/1-2/
Testing
---
Manually tested.
mvn clean test on ambari-metrics.
Thanks,
Aravindan Vijayan
nd is an internal name. It is not exposed to consumers.
- Aravindan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60201/#review178479
-------
Richard Zang) to the
review?
- Aravindan Vijayan
On June 21, 2017, 12:35 p.m., Jay SenSharma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60077/#review178428
---
Ship it!
Ship It!
- Aravindan Vijayan
On June 20, 2017, 12
c4d976307c8a9b60
Diff: https://reviews.apache.org/r/60201/diff/1/
Testing
---
Manually tested.
mvn clean test on ambari-metrics.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60113/#review178107
---
Ship it!
Ship It!
- Aravindan Vijayan
On June 16, 2017, 2
/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
Lines 241 (patched)
<https://reviews.apache.org/r/60098/#comment251830>
Can we rename this method to something more appropriate? Like
'getReturnStatus'
- Aravindan Vijayan
On June 14, 2017, 9:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60131/#review178045
---
Ship it!
Ship It!
- Aravindan Vijayan
On June 15, 2017, 7
SUCCESS
[INFO]
[INFO] Total time: 06:55 min
[INFO] Finished at: 2017-06-09T11:40:33-07:00
[INFO] Final Memory: 134M/1333M
[INFO]
Thanks,
Aravindan
tricname,appId but
different instanceIds are different.
- Aravindan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59951/#review177514
----------
ng library here? This is only removing
> > special chars. Wouldn't it increase entropy?
Stemming library does not support this explicitly. Also, the stem function is
quite simple and specific for us.
- Aravindan
-------
This is an
SUCCESS
[INFO]
[INFO] Total time: 06:55 min
[INFO] Finished at: 2017-06-09T11:40:33-07:00
[INFO] Final Memory: 134M/1333M
[INFO]
Thanks,
Aravindan Vijayan
]
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59574/#review177335
---
Ship it!
Ship It!
- Aravindan Vijayan
On May 26, 2017, 1:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59149/#review177245
---
Ship it!
Ship It!
- Aravindan Vijayan
On June 1, 2017, 6:52
n/core/aggregator.py
Line 46 (original), 47 (patched)
<https://reviews.apache.org/r/59574/#comment249739>
FYI, This means there is no Zk fallback for getting collector hosts in the
AggregatorApplication. (Like metric monitors).
- Aravindan Vijayan
On May 26, 2017, 1:03 p.m., Dmyt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59418/#review176010
---
Ship it!
Ship It!
- Aravindan Vijayan
On May 19, 2017, 8:43
d send as a
Singleton List.
- Aravindan Vijayan
On May 19, 2017, 8:43 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
Manually tested 2.5.0 to 2.5.1 upgrade.
mvn clean test on Ambari Metrics.
Thanks,
Aravindan Vijayan
aggregator thread empties the cache everytime it
runs? The Cache expiry is still ok, since without that, it can lead to metric
bloat.
- Aravindan Vijayan
On April 28, 2017, 4:41 p.m., Dmytro Sen wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58963/#review173733
---
Ship it!
Ship It!
- Aravindan Vijayan
On May 3, 2017, 1:08
> On April 28, 2017, 6:35 p.m., Aravindan Vijayan wrote:
> > Ship It!
>
> Masahiro Tanaka wrote:
> Thank you! Could you commit it?
Done. Please close the review and the jira.
- Aravindan
---
This is an automat
ggregators/ITClusterAggregator.java
590f82a
Diff: https://reviews.apache.org/r/58933/diff/1/
Testing
---
mvn clean test on ambari-metrics
Manually tested.
Thanks,
Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173361
---
Ship it!
Ship It!
- Aravindan Vijayan
On April 20, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58620/#review173060
---
Ship it!
Ship It!
- Aravindan Vijayan
On April 26, 2017, 4
es 175 (patched)
<https://reviews.apache.org/r/58620/#comment246133>
I believe this ams-site config is no longer present. Can we use the
external metrics collector config instead?
- Aravindan Vijayan
On April 26, 2017, 10:03 a.m., Dmyt
oryservice/metrics/timeline/discovery/TestMetadataSync.java
5eab903
Diff: https://reviews.apache.org/r/58490/diff/2/
Changes: https://reviews.apache.org/r/58490/diff/1-2/
Testing
---
Manually tested.
Added unit tests.
Thanks,
Aravindan Vijayan
d)) {
return;
}
- Aravindan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58490/#review172252
---
On April 18, 20
/discovery/TestMetadataSync.java
5eab903
Diff: https://reviews.apache.org/r/58490/diff/1/
Testing
---
Manually tested.
Added unit tests.
Thanks,
Aravindan Vijayan
n some host, and
part of the metrics will need to be aggregated at the collecor side and part of
them have already been aggregated and written to METRIC_RECORD_MINUTE?
- Aravindan Vijayan
On April 13, 2017, 4:54 p.m., Dmytro Sen
/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
Line 498 (original), 498 (patched)
<https://reviews.apache.org/r/58424/#comment244894>
Yes I agree. 'localhost' can be the default first option added to the set
of configured hosts.
- Aravindan Vijayan
On April 13
0/configuration/ams-env.xml
81fa4c7
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
26b3502
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
3276cc1
Diff: https://reviews.apache.org/r/57902/diff/1/
Testing
---
Manually tested.
Python unit tests pass.
Thanks,
Aravindan Vijayan
1 - 100 of 405 matches
Mail list logo
