Re: Review Request 64989: AMBARI-22740 : Fix integration test for HBase in branch-3.0-ams due to UUID changes

2018-01-05 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64989/ --- (Updated Jan. 5, 2018, 11:19 p.m.) Review request for Ambari, Dmytro Sen and Si

Re: Review Request 64991: Fix issues with webapp deployment with new Hadoop common changes

2018-01-05 Thread Aravindan Vijayan
(original), 44 (patched) <https://reviews.apache.org/r/64991/#comment273981> Extra ' character at the end. - Aravindan Vijayan On Jan. 5, 2018, 8:16 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-m

Re: Review Request 64989: AMBARI-22740 : Fix integration test for HBase in branch-3.0-ams due to UUID changes

2018-01-05 Thread Aravindan Vijayan
] Thanks, Aravindan Vijayan

Review Request 64989: AMBARI-22740 : Fix integration test for HBase in branch-3.0-ams due to UUID changes

2018-01-05 Thread Aravindan Vijayan
/applicationhistoryservice/metrics/timeline/aggregators/ITMetricAggregator.java 1890819 ambari-metrics/pom.xml 6541cec Diff: https://reviews.apache.org/r/64989/diff/1/ Testing --- Unit testing. Thanks, Aravindan Vijayan

Re: Review Request 64836: AMBARI-22696 Whitelist execute latency from Storm Ambari metrics (trunk)

2017-12-27 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64836/#review194562 --- Ship it! Ship It! - Aravindan Vijayan On Dec. 25, 2017, 4

Re: Review Request 64837: AMBARI-22696 Whitelist execute latency from Storm Ambari metrics (branch-2.6)

2017-12-27 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64837/#review194561 --- Ship it! Ship It! - Aravindan Vijayan On Dec. 25, 2017, 4

Re: Review Request 64837: AMBARI-22696 Whitelist execute latency from Storm Ambari metrics (branch-2.6)

2017-12-27 Thread Aravindan Vijayan
/resources/common-services/STORM/1.0.1.3.0/service_advisor.py as well. - Aravindan Vijayan On Dec. 25, 2017, 4:38 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 64789: Fix AMS compilation issues and unit test with hbase, hadoop and phoenix upgraded

2017-12-21 Thread Aravindan Vijayan
<https://reviews.apache.org/r/64789/#comment273131> Change grep expression to new class name. - Aravindan Vijayan On Dec. 21, 2017, 10:36 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 64393: AMBARI-22607 : Design and implement an AD job scheduler.

2017-12-08 Thread Aravindan Vijayan
sit: https://reviews.apache.org/r/64393/#review193087 --- On Dec. 8, 2017, 9:27 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 64393: AMBARI-22607 : Design and implement an AD job scheduler.

2017-12-08 Thread Aravindan Vijayan
Diff: https://reviews.apache.org/r/64393/diff/2/ Changes: https://reviews.apache.org/r/64393/diff/1-2/ Testing --- Manually tested. Current unit tests pass. New Unit tests being worked on... Thanks, Aravindan Vijayan

Re: Review Request 64393: AMBARI-22607 : Design and implement an AD job scheduler.

2017-12-06 Thread Aravindan Vijayan
e work on EMA application. For this patch, I used EMA as a simple example job. - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64393/#review193087 --------

Re: Review Request 64393: AMBARI-22607 : Design and implement an AD job scheduler.

2017-12-06 Thread Aravindan Vijayan
utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64393/#review193087 --- On Dec. 6, 2017, 10:52 p.m., Aravindan Vijayan wrote: > > --- > This is an

Review Request 64393: AMBARI-22607 : Design and implement an AD job scheduler.

2017-12-06 Thread Aravindan Vijayan
/diff/1/ Testing --- Manually tested. Current unit tests pass. New Unit tests being worked on... Thanks, Aravindan Vijayan

Re: Review Request 64309: Fix the wording on IPA integration requirements in the Enable Kerberos Wizard

2017-12-04 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64309/#review192726 --- Ship it! Ship It! - Aravindan Vijayan On Dec. 4, 2017, 6:09

Re: Review Request 64305: Ambari should not force accounts created in IPA to be added a user named 'ambari-managed-principals'

2017-12-04 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64305/#review192724 --- Ship it! Ship It! - Aravindan Vijayan On Dec. 4, 2017, 5:02

Re: Review Request 64221: AMBARI-22567 : Integrate Spark lifecycle management into AMS AD Manager.

2017-11-30 Thread Aravindan Vijayan
/params.py b7004b8 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py c01b368 Diff: https://reviews.apache.org/r/64221/diff/3/ Changes: https://reviews.apache.org/r/64221/diff/2-3/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 64221: AMBARI-22567 : Integrate Spark lifecycle management into AMS AD Manager.

2017-11-30 Thread Aravindan Vijayan
-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py c01b368 Diff: https://reviews.apache.org/r/64221/diff/2/ Changes: https://reviews.apache.org/r/64221/diff/1-2/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Review Request 64221: AMBARI-22567 : Integrate Spark lifecycle management into AMS AD Manager.

2017-11-30 Thread Aravindan Vijayan
/scripts/params.py b7004b8 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py c01b368 Diff: https://reviews.apache.org/r/64221/diff/1/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 64088: AMBARI-22524 : Journal Node start failing when AMS is installed during BP deploy

2017-11-27 Thread Aravindan Vijayan
/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 30c5c23 Diff: https://reviews.apache.org/r/64088/diff/2/ Changes: https://reviews.apache.org/r/64088/diff/1-2/ Testing --- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Review Request 64088: AMBARI-22524 : Journal Node start failing when AMS is installed during BP deploy

2017-11-27 Thread Aravindan Vijayan
/HadoopTimelineMetricsSinkTest.java 30c5c23 ambari-metrics/pom.xml a14b8fd Diff: https://reviews.apache.org/r/64088/diff/1/ Testing --- Manually tested. Unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 63935: AMBARI-22470 : Refine Metric Definition Service and AD Query service.

2017-11-20 Thread Aravindan Vijayan
/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java 32cc813 Diff: https://reviews.apache.org/r/63935/diff/2/ Changes: https://reviews.apache.org/r/63935/diff/1-2/ Testing --- Unit testing and manual testing. Thanks, Aravindan Vijayan

Review Request 63935: AMBARI-22470 : Refine Metric Definition Service and AD Query service.

2017-11-17 Thread Aravindan Vijayan
/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java 32cc813 Diff: https://reviews.apache.org/r/63935/diff/1/ Testing --- Unit testing and manual testing. Thanks, Aravindan Vijayan

Re: Review Request 63787: AMBARI-22437 : Create an 'AD Manager' component in Ambari Metrics Service stack side.

2017-11-14 Thread Aravindan Vijayan
Tested. Relevant unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 63787: AMBARI-22437 : Create an 'AD Manager' component in Ambari Metrics Service stack side.

2017-11-14 Thread Aravindan Vijayan
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63787/#review190921 ------- On Nov. 14, 2017, 6:16 a.m., Aravindan Vijayan wrote: > > -

Review Request 63787: AMBARI-22437 : Create an 'AD Manager' component in Ambari Metrics Service stack side.

2017-11-13 Thread Aravindan Vijayan
/configs/default.json 43c184c ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json eaaeeb5 Diff: https://reviews.apache.org/r/63787/diff/1/ Testing --- Manually Tested. Relevant unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 63542: Add storage support for storing metric definitions using LevelDB

2017-11-03 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63542/#review190051 --- Ship it! Ship It! - Aravindan Vijayan On Nov. 3, 2017, 5:07

Re: Review Request 63524: Fix Serialization issues in Metric Definition Service

2017-11-02 Thread Aravindan Vijayan
://reviews.apache.org/r/63524/diff/1/ Testing --- Unit testing. (Apache JIRA seems to be unreachable. Will create jira once it is up.) Thanks, Aravindan Vijayan

Review Request 63524: Fix Serialization issues in Metric Definition Service

2017-11-02 Thread Aravindan Vijayan
create jira once it is up.) Thanks, Aravindan Vijayan

Re: Review Request 63477: AMBARI-22348 : Metric Definition Service V1 Implementation.

2017-11-01 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63477/#review189837 --- On Nov. 1, 2017, 10:37 p.m., Aravindan Vijayan wrote: > >

Re: Review Request 63477: AMBARI-22348 : Metric Definition Service V1 Implementation.

2017-11-01 Thread Aravindan Vijayan
://reviews.apache.org/r/63477/diff/3/ Changes: https://reviews.apache.org/r/63477/diff/2-3/ Testing --- Unit Testing. Thanks, Aravindan Vijayan

Re: Review Request 63477: AMBARI-22348 : Metric Definition Service V1 Implementation.

2017-11-01 Thread Aravindan Vijayan
/63477/diff/1-2/ Testing --- Unit Testing. Thanks, Aravindan Vijayan

Review Request 63477: AMBARI-22348 : Metric Definition Service V1 Implementation.

2017-11-01 Thread Aravindan Vijayan
-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java 12bd463 Diff: https://reviews.apache.org/r/63477/diff/1/ Testing --- Unit Testing. Thanks, Aravindan Vijayan

Re: Review Request 63440: Metrics for OneFS mpack

2017-10-31 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63440/#review189753 --- Ship it! Ship It! - Aravindan Vijayan On Oct. 31, 2017, 4

Re: Review Request 63449: Add ability in AMS to tee metrics to a set of configured Kafka brokers + Other changes

2017-10-31 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63449/#review189752 --- Ship it! Ship It! - Aravindan Vijayan On Oct. 31, 2017, 6

Review Request 62989: AMBARI-22238 : Maven cleanup of ambari utility, logsearch and ambari metrics modules

2017-10-13 Thread Aravindan Vijayan
a708384 Diff: https://reviews.apache.org/r/62989/diff/1/ Testing --- mvn clean test. Thanks, Aravindan Vijayan

Re: Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

2017-10-12 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62941/#review187849 --- Ship it! Ship It! - Aravindan Vijayan On Oct. 12, 2017, 7

Re: Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

2017-10-12 Thread Aravindan Vijayan
/scala/org/apache/ambari/metrics/adservice/resource/RootResource.scala Lines 33 (patched) <https://reviews.apache.org/r/62941/#comment264881> Can we change this to something AD specific ? - Aravindan Vijayan On Oct. 12, 2017, 6:09 p.m., Sid Wagle

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

2017-10-03 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/#review186999 --- Ship it! Ship It! - Aravindan Vijayan On Oct. 3, 2017, 7:48

Review Request 62624: AMBARI-22077: Create maven module and package structure for the anomaly detection engine

2017-09-27 Thread Aravindan Vijayan
NFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 08:21 min [INFO] Finished at: 2017-09-27T11:57:06-07:00 [INFO] Final Memory: 149M/1616M Thanks, Aravindan Vijayan

Re: Review Request 62474: AMS: Add smart configs support for service

2017-09-21 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62474/#review185920 --- Ship it! Ship It! - Aravindan Vijayan On Sept. 21, 2017, 7

Re: Review Request 62474: AMS: Add smart configs support for service

2017-09-21 Thread Aravindan Vijayan
s/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml Line 789 (original), 803 (patched) <https://reviews.apache.org/r/62474/#comment262250> Unrelated query, but shouldnt this be in ams-env? We would ideally need restart of metrics collector and monitors for this change. -

Re: Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

2017-09-13 Thread Aravindan Vijayan
-- On Sept. 13, 2017, 7:49 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62292/ >

Re: Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

2017-09-13 Thread Aravindan Vijayan
views.apache.org/media/uploaded/files/2017/09/13/ce769beb-f026-4d9e-9530-3218327584be__Screen_Shot_2017-09-13_at_12.13.24_PM.png Thanks, Aravindan Vijayan

Review Request 62292: AMBARI-21952 : Refine AMS heap recommendations in stack advisor.

2017-09-13 Thread Aravindan Vijayan
tacks/2.2/common/test_stack_advisor.py 9c6bef1 Diff: https://reviews.apache.org/r/62292/diff/1/ Testing --- Manually tested. Python unit tests passed. Thanks, Aravindan Vijayan

Re: Review Request 62125: AMBARI-21893 : NameNode Heap Usage (Daily) metric alert status flips to UNKNOWN intermittently when AMS HTTPS is enabled.

2017-09-12 Thread Aravindan Vijayan
ces/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 071882b ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java db6ebc1 Diff: https://reviews.apache.org/r/62125/diff/2/ Testing (updated) --- Manually tested. python unit tests pass.

Re: Review Request 62125: AMBARI-21893 : NameNode Heap Usage (Daily) metric alert status flips to UNKNOWN intermittently when AMS HTTPS is enabled.

2017-09-12 Thread Aravindan Vijayan
ests pass. Thanks, Aravindan Vijayan

Re: Review Request 62125: AMBARI-21893 : NameNode Heap Usage (Daily) metric alert status flips to UNKNOWN intermittently when AMS HTTPS is enabled.

2017-09-12 Thread Aravindan Vijayan
.apache.org/r/62125/diff/1-2/ Testing --- Manually tested. python unit tests pass. Thanks, Aravindan Vijayan

Re: Review Request 62250: AMBARI-21939 : Ambari HDFS Heatmaps are not showing data (Not Applicable) for bytes read, bytes written & DataNode Process Network I/O Utilization

2017-09-12 Thread Aravindan Vijayan
stack widget definition files. - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62250/#review185215 ------- On Sept.

Review Request 62250: AMBARI-21939 : Ambari HDFS Heatmaps are not showing data (Not Applicable) for bytes read, bytes written & DataNode Process Network I/O Utilization

2017-09-12 Thread Aravindan Vijayan
Diff: https://reviews.apache.org/r/62250/diff/1/ Testing --- Manually tested. UpgradeCatalog260 test added. Thanks, Aravindan Vijayan

Re: Review Request 61998: Update Ambari Metrics service check to support HTTP SPNEGO authentication

2017-09-07 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61998/#review184933 --- Ship it! Ship It! - Aravindan Vijayan On Sept. 5, 2017, 7

Re: Review Request 62169: Server returns 500 error for create config group request

2017-09-07 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62169/#review184877 --- Ship it! Ship It! - Aravindan Vijayan On Sept. 7, 2017, 7

Review Request 62125: AMBARI-21893 : NameNode Heap Usage (Daily) metric alert status flips to UNKNOWN intermittently when AMS HTTPS is enabled.

2017-09-06 Thread Aravindan Vijayan
9a31ade ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 6975bec Diff: https://reviews.apache.org/r/62125/diff/1/ Testing --- Manually tested. python unit tests pass. Thanks, Aravindan Vijayan

Review Request 62097: AMBARI-21871 : Add new graphs to HBase RegionServer dashboard in Grafana

2017-09-05 Thread Aravindan Vijayan
/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hbase-regionservers.json 3184357 Diff: https://reviews.apache.org/r/62097/diff/1/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Review Request 61587: AMBARI-21706 : Fix exception messages whenever empty host list is passed in predicate.

2017-08-10 Thread Aravindan Vijayan
/ Testing --- Manually tested. mvn clean test on ambari-server. Thanks, Aravindan Vijayan

Review Request 61510: AMBARI-21686 : Implement a test driver that provides a set of metric series with different kinds of metric behavior

2017-08-08 Thread Aravindan Vijayan
/HBaseTimelineMetricsService.java 98904fd Diff: https://reviews.apache.org/r/61510/diff/1/ Testing --- mvn clean test. Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

2017-08-07 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61481/#review182339 --- Ship it! Ship It! - Aravindan Vijayan On Aug. 7, 2017, 10

Re: Review Request 61386: AMBARI-21640 : Certain templated Grafana dashboards not showing data.

2017-08-03 Thread Aravindan Vijayan
che.org/r/61386/#review182033 --- On Aug. 2, 2017, 8:20 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Review Request 61386: AMBARI-21640 : Certain templated Grafana dashboards not showing data.

2017-08-02 Thread Aravindan Vijayan
Nifi-Hosts) Thanks, Aravindan Vijayan

Re: Review Request 61248: Grafana Kafka-Topic dashboard is forming incorrect url 'NaNundefined' appended

2017-07-31 Thread Aravindan Vijayan
/datasource.js Line 300 (original), 300 (patched) <https://reviews.apache.org/r/61248/#comment257601> Can you check if this issue exists in HBase-Users, HBase-Tables, HDFS-Users etc as well? If yes, please fix the issue for those dashboards also. - Aravindan Vijayan On July 31, 2017, 6:32 a.m

Re: Review Request 61203: AMBARI-21593 : AMS stopped after RU [AMS distributed mode with 2 collectors]

2017-07-31 Thread Aravindan Vijayan
. Thanks, Aravindan Vijayan

Re: Review Request 61203: AMBARI-21593 : AMS stopped after RU [AMS distributed mode with 2 collectors]

2017-07-28 Thread Aravindan Vijayan
hed) > > <https://reviews.apache.org/r/61203/diff/1/?file=1785078#file1785078line127> > > > > What was the reason, both instances failed? > > Aravindan Vijayan wrote: > It is because of the code which deleted and recreated the znode whenever > a sub path

Re: Review Request 61203: AMBARI-21593 : AMS stopped after RU [AMS distributed mode with 2 collectors]

2017-07-28 Thread Aravindan Vijayan
is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61203/#review181646 ------- On July 28, 2017, 4:50 a.m., Aravindan Vijayan wrote: > > --- > This

Re: Review Request 61203: AMBARI-21593 : AMS stopped after RU [AMS distributed mode with 2 collectors]

2017-07-28 Thread Aravindan Vijayan
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/61203/#review181647 ------- On July 28, 2017, 4:50 a.m., Aravindan Vijayan wrote: > > --- > This is an au

Re: Review Request 61203: AMBARI-21593 : AMS stopped after RU [AMS distributed mode with 2 collectors]

2017-07-28 Thread Aravindan Vijayan
ps://reviews.apache.org/r/61203/#review181646 ------- On July 28, 2017, 4:50 a.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail.

Review Request 61203: AMBARI-21593 : AMS stopped after RU [AMS distributed mode with 2 collectors]

2017-07-27 Thread Aravindan Vijayan
/yarn/server/applicationhistoryservice/metrics/timeline/availability/MetricCollectorHAController.java 53e6304 Diff: https://reviews.apache.org/r/61203/diff/1/ Testing --- Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 60198: Handle scenario when host in-memory aggregation is not working

2017-07-10 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60198/#review180140 --- Ship it! Ship It! - Aravindan Vijayan On July 10, 2017, 4

Re: Review Request 60424: Ability to disable Container metrics in AMS

2017-06-26 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60424/#review178904 --- Ship it! Ship It! - Aravindan Vijayan On June 26, 2017, 10

Review Request 60399: AMBARI-21329 : No data on templated Grafana dashboards on HDF cluster.

2017-06-23 Thread Aravindan Vijayan
dbb51cf ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java d7d905c Diff: https://reviews.apache.org/r/60399/diff/1/ Testing --- Manually tested. mvn clean test passed. Thanks, Aravindan Vijayan

Re: Review Request 60201: AMBARI-17382 : Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint

2017-06-21 Thread Aravindan Vijayan
nges: https://reviews.apache.org/r/60201/diff/1-2/ Testing --- Manually tested. mvn clean test on ambari-metrics. Thanks, Aravindan Vijayan

Re: Review Request 60201: AMBARI-17382 : Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint

2017-06-21 Thread Aravindan Vijayan
nd is an internal name. It is not exposed to consumers. - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60201/#review178479 -------

Re: Review Request 60265: Grafana Yarn Queue dashboard is not working due to incorrect startTime.

2017-06-21 Thread Aravindan Vijayan
Richard Zang) to the review? - Aravindan Vijayan On June 21, 2017, 12:35 p.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 60077: Add https support to local metrics aggregator application

2017-06-20 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60077/#review178428 --- Ship it! Ship It! - Aravindan Vijayan On June 20, 2017, 12

Review Request 60201: AMBARI-17382 : Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint

2017-06-19 Thread Aravindan Vijayan
c4d976307c8a9b60 Diff: https://reviews.apache.org/r/60201/diff/1/ Testing --- Manually tested. mvn clean test on ambari-metrics. Thanks, Aravindan Vijayan

Re: Review Request 60113: Exception needs to be handled properly for mail alert

2017-06-16 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60113/#review178107 --- Ship it! Ship It! - Aravindan Vijayan On June 16, 2017, 2

Re: Review Request 60098: Add Kerberos HTTP SPNEGO authentication support to Accumulo

2017-06-15 Thread Aravindan Vijayan
/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java Lines 241 (patched) <https://reviews.apache.org/r/60098/#comment251830> Can we rename this method to something more appropriate? Like 'getReturnStatus' - Aravindan Vijayan On June 14, 2017, 9:24 p.m

Re: Review Request 60131: update yarn-env.xml in HDP2.6 for YARN sinks' HTTP SPNEGO Authentication

2017-06-15 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60131/#review178045 --- Ship it! Ship It! - Aravindan Vijayan On June 15, 2017, 7

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-14 Thread Aravindan Vijayan
SUCCESS [INFO] [INFO] Total time: 06:55 min [INFO] Finished at: 2017-06-09T11:40:33-07:00 [INFO] Final Memory: 134M/1333M [INFO] Thanks, Aravindan

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-12 Thread Aravindan Vijayan
tricname,appId but different instanceIds are different. - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59951/#review177514 ----------

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-12 Thread Aravindan Vijayan
ng library here? This is only removing > > special chars. Wouldn't it increase entropy? Stemming library does not support this explicitly. Also, the stem function is quite simple and specific for us. - Aravindan ------- This is an

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-09 Thread Aravindan Vijayan
SUCCESS [INFO] [INFO] Total time: 06:55 min [INFO] Finished at: 2017-06-09T11:40:33-07:00 [INFO] Final Memory: 134M/1333M [INFO] Thanks, Aravindan Vijayan

Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-09 Thread Aravindan Vijayan
] Thanks, Aravindan Vijayan

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-06-08 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59574/#review177335 --- Ship it! Ship It! - Aravindan Vijayan On May 26, 2017, 1:03

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-06-07 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59149/#review177245 --- Ship it! Ship It! - Aravindan Vijayan On June 1, 2017, 6:52

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-05-30 Thread Aravindan Vijayan
n/core/aggregator.py Line 46 (original), 47 (patched) <https://reviews.apache.org/r/59574/#comment249739> FYI, This means there is no Zk fallback for getting collector hosts in the AggregatorApplication. (Like metric monitors). - Aravindan Vijayan On May 26, 2017, 1:03 p.m., Dmyt

Re: Review Request 59418: Add ability to sink Raw metrics to external system via Http

2017-05-24 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59418/#review176010 --- Ship it! Ship It! - Aravindan Vijayan On May 19, 2017, 8:43

Re: Review Request 59418: Add ability to sink Raw metrics to external system via Http

2017-05-24 Thread Aravindan Vijayan
d send as a Singleton List. - Aravindan Vijayan On May 19, 2017, 8:43 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 59416: AMBARI-21068 : Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

2017-05-19 Thread Aravindan Vijayan
--- Manually tested 2.5.0 to 2.5.1 upgrade. mvn clean test on Ambari Metrics. Thanks, Aravindan Vijayan

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-05-15 Thread Aravindan Vijayan
aggregator thread empties the cache everytime it runs? The Cache expiry is still ok, since without that, it can lead to metric bloat. - Aravindan Vijayan On April 28, 2017, 4:41 p.m., Dmytro Sen wrote: > > --- > This is an automati

Re: Review Request 58963: AMBARI-20918. AmbariServer Metrics service cannot be disabled

2017-05-03 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58963/#review173733 --- Ship it! Ship It! - Aravindan Vijayan On May 3, 2017, 1:08

Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT

2017-05-02 Thread Aravindan Vijayan
> On April 28, 2017, 6:35 p.m., Aravindan Vijayan wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! Could you commit it? Done. Please close the review and the jira. - Aravindan --- This is an automat

Review Request 58933: AMBARI-20913 : Grafana LLAP overview dashboard showing incorrect metrics

2017-05-02 Thread Aravindan Vijayan
ggregators/ITClusterAggregator.java 590f82a Diff: https://reviews.apache.org/r/58933/diff/1/ Testing --- mvn clean test on ambari-metrics Manually tested. Thanks, Aravindan Vijayan

Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT

2017-04-28 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58575/#review173361 --- Ship it! Ship It! - Aravindan Vijayan On April 20, 2017, 2

Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-26 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58620/#review173060 --- Ship it! Ship It! - Aravindan Vijayan On April 26, 2017, 4

Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-26 Thread Aravindan Vijayan
es 175 (patched) <https://reviews.apache.org/r/58620/#comment246133> I believe this ams-site config is no longer present. Can we use the external metrics collector config instead? - Aravindan Vijayan On April 26, 2017, 10:03 a.m., Dmyt

Re: Review Request 58490: AMBARI-20777 : AMS changes to use instanceId for cluster based segregation of data

2017-04-18 Thread Aravindan Vijayan
oryservice/metrics/timeline/discovery/TestMetadataSync.java 5eab903 Diff: https://reviews.apache.org/r/58490/diff/2/ Changes: https://reviews.apache.org/r/58490/diff/1-2/ Testing --- Manually tested. Added unit tests. Thanks, Aravindan Vijayan

Re: Review Request 58490: AMBARI-20777 : AMS changes to use instanceId for cluster based segregation of data

2017-04-18 Thread Aravindan Vijayan
d)) { return; } - Aravindan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58490/#review172252 --- On April 18, 20

Review Request 58490: AMBARI-20777 : AMS changes to use instanceId for cluster based segregation of data

2017-04-17 Thread Aravindan Vijayan
/discovery/TestMetadataSync.java 5eab903 Diff: https://reviews.apache.org/r/58490/diff/1/ Testing --- Manually tested. Added unit tests. Thanks, Aravindan Vijayan

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Aravindan Vijayan
n some host, and part of the metrics will need to be aggregated at the collecor side and part of them have already been aggregated and written to METRIC_RECORD_MINUTE? - Aravindan Vijayan On April 13, 2017, 4:54 p.m., Dmytro Sen

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Aravindan Vijayan
/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java Line 498 (original), 498 (patched) <https://reviews.apache.org/r/58424/#comment244894> Yes I agree. 'localhost' can be the default first option added to the set of configured hosts. - Aravindan Vijayan On April 13

Review Request 57902: AMBARI-20553 : Ambari script error for ams-hbase while writing to Amazon s3 on a cluster with no HDFS.

2017-03-29 Thread Aravindan Vijayan
0/configuration/ams-env.xml 81fa4c7 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py 26b3502 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 3276cc1 Diff: https://reviews.apache.org/r/57902/diff/1/ Testing --- Manually tested. Python unit tests pass. Thanks, Aravindan Vijayan

  1   2   3   4   5   >