Re: Review Request 64111: AMBARI-22527: Error while viewing topology details - Storm View

2017-11-28 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64111/#review192100
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On Nov. 28, 2017, 8:30 a.m., Sanket Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64111/
> ---
> 
> (Updated Nov. 28, 2017, 8:30 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Sumit Mohanty, Sriharsha 
> Chintalapani, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22527
> https://issues.apache.org/jira/browse/AMBARI-22527
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the latest build, due to few npm packages being updated dynamically, Storm 
> view is running into below mentioned error:
> 
> ```
> Uncaught Error: Minified React error #130; visit 
> http://facebook.github.io/react/docs/error-decoder.html?invariant=130[]=object[]=%20Check%20the%20render%20method%20of%20%60e%60.
>  for the full message or use the non-minified dev environment for full errors 
> and additional helpful warnings.
> at n (vendor.bundle.js:4)
> at a (vendor.bundle.js:6)
> at Object.updateChildren (vendor.bundle.js:2)
> at v._reconcilerUpdateChildren (vendor.bundle.js:3)
> at v._updateChildren (vendor.bundle.js:3)
> at v.updateChildren (vendor.bundle.js:3)
> at v._updateDOMChildren (vendor.bundle.js:2)
> at v.updateComponent (vendor.bundle.js:2)
> at v.receiveComponent (vendor.bundle.js:2)
> at Object.receiveComponent (vendor.bundle.js:2)
> ```
> 
> 
> Diffs
> -
> 
>   
> contrib/views/storm/src/main/resources/ui/app/scripts/containers/ComponentDetailView.jsx
>  2b3ed69 
>   contrib/views/storm/src/main/resources/ui/package.json f9e029b 
> 
> 
> Diff: https://reviews.apache.org/r/64111/diff/1/
> 
> 
> Testing
> ---
> 
> Manually ran the mvn clean install and created storm view jar.
> Successfully deployed the jar and verified working of storm view.
> Clicked on a topology and verified the working of the page since that was the 
> one throwing above error.
> 
> 
> Thanks,
> 
> Sanket Shah
> 
>

Re: Review Request 62801: AMBARI-21955: Update React version to 15.6.2 to get MIT license

2017-10-09 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62801/#review187474
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On Oct. 6, 2017, 5 a.m., Sanket Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62801/
> ---
> 
> (Updated Oct. 6, 2017, 5 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-21955
> https://issues.apache.org/jira/browse/AMBARI-21955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Apache Software Foundation Legal Affairs Committee has announced that the 
> so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a 
> direct dependency in Apache projects.
> Facebook has relicensed React with MIT license in their latest (15.6.2 & 16) 
> versions.
> 
> Since Storm View is using React.js which is under the same Facebook's 
> BSD+Patents license, need to update the version to get MIT license.
> 
> 
> Diffs
> -
> 
>   .gitignore a40e61a 
>   contrib/views/storm/pom.xml cd92658 
>   contrib/views/storm/src/main/resources/images/icon-bolt.png  
>   contrib/views/storm/src/main/resources/images/icon-spout.png  
>   contrib/views/storm/src/main/resources/images/loader.gif  
>   contrib/views/storm/src/main/resources/index.html df94a76 
>   
> contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js
>  d8ccc65 
>   contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css
>  50543a7 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css
>  d30595c 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css
>  c63cfe2 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css 
> 5a77806 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg
>  94fb549 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2
>   
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png 
> 580b52a5be8a644f826def0c7ed6a13f90c0915c 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif 
> 5b33f7e54f4e55b6b8774d86d96895db9af044b4 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js
>  b786a84 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js
>  01e7f30 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js
>  e61cd83 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js
>  9849658 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js 
> e79c065 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css
>  d0603cb 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf
>  3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot
>  9b6afaedc0fd7aaf927a07f82da9c11022251b8b 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg
>  d05688e 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf
>  26dea7951a73079223b50653c455c5adf46a4648 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff
>  dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2
>  500e5172534171f678e01f7569d66f9257036a09 
>   contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js 
> dfd89b2 
>   contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js 
> 0dc0cbd 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3-tip.min.js 4767cc0 
>   contrib/views/storm/src/main/resource

Re: Review Request 62801: AMBARI-21955: Update React version to 15.6.2 to get MIT license

2017-10-09 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62801/#review187475
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On Oct. 6, 2017, 5 a.m., Sanket Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62801/
> ---
> 
> (Updated Oct. 6, 2017, 5 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-21955
> https://issues.apache.org/jira/browse/AMBARI-21955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Apache Software Foundation Legal Affairs Committee has announced that the 
> so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a 
> direct dependency in Apache projects.
> Facebook has relicensed React with MIT license in their latest (15.6.2 & 16) 
> versions.
> 
> Since Storm View is using React.js which is under the same Facebook's 
> BSD+Patents license, need to update the version to get MIT license.
> 
> 
> Diffs
> -
> 
>   .gitignore a40e61a 
>   contrib/views/storm/pom.xml cd92658 
>   contrib/views/storm/src/main/resources/images/icon-bolt.png  
>   contrib/views/storm/src/main/resources/images/icon-spout.png  
>   contrib/views/storm/src/main/resources/images/loader.gif  
>   contrib/views/storm/src/main/resources/index.html df94a76 
>   
> contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js
>  d8ccc65 
>   contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css
>  50543a7 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css
>  d30595c 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css
>  c63cfe2 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css 
> 5a77806 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg
>  94fb549 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2
>   
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png 
> 580b52a5be8a644f826def0c7ed6a13f90c0915c 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif 
> 5b33f7e54f4e55b6b8774d86d96895db9af044b4 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js
>  b786a84 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js
>  01e7f30 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js
>  e61cd83 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js
>  9849658 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js 
> e79c065 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css
>  d0603cb 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf
>  3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot
>  9b6afaedc0fd7aaf927a07f82da9c11022251b8b 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg
>  d05688e 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf
>  26dea7951a73079223b50653c455c5adf46a4648 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff
>  dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2
>  500e5172534171f678e01f7569d66f9257036a09 
>   contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js 
> dfd89b2 
>   contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js 
> 0dc0cbd 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3-tip.min.js 4767cc0 
>   contrib/views/storm/src/main/resource

Re: Review Request 62324: AMBARI-21955: Port Storm View from React.js to Vue.js

2017-09-19 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62324/#review185716
---


Ship it!




Looks good. Tested by installing in Ambari along with Storm.

- Sriharsha Chintalapani


On Sept. 14, 2017, 7:11 a.m., Sanket Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62324/
> ---
> 
> (Updated Sept. 14, 2017, 7:11 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Sumit Mohanty, and Sriharsha 
> Chintalapani.
> 
> 
> Bugs: AMBARI-21955
> https://issues.apache.org/jira/browse/AMBARI-21955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Apache Software Foundation Legal Affairs Committee has announced that the 
> so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a 
> direct dependency in Apache projects.
> 
> Since Storm View is using React.js which is under the same Facebook's 
> license, needs to get rid of and use Vue.js instead.
> 
> 
> Diffs
> -
> 
>   .gitignore a40e61a 
>   contrib/views/storm/pom.xml cd92658 
>   contrib/views/storm/src/main/resources/images/icon-bolt.png  
>   contrib/views/storm/src/main/resources/images/icon-spout.png  
>   contrib/views/storm/src/main/resources/images/loader.gif  
>   contrib/views/storm/src/main/resources/index.html df94a76 
>   
> contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js
>  d8ccc65 
>   contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css
>  50543a7 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css
>  d30595c 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css
>  c63cfe2 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css 
> 5a77806 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot
>  b93a4953fff68df523aa7656497ee339d6026d64 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg
>  94fb549 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf
>  1413fc609ab6f21774de0cb7e01360095584f65b 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff
>  9e612858f802245ddcbf59788a0db942224bab35 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2
>  64539b54c3751a6d9adb44c8e3a45ba5a73b77f0 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png 
> 580b52a5be8a644f826def0c7ed6a13f90c0915c 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif 
> 5b33f7e54f4e55b6b8774d86d96895db9af044b4 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js
>  b786a84 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js
>  01e7f30 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js
>  e61cd83 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js
>  9849658 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js 
> e79c065 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css
>  d0603cb 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf
>  3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot
>  9b6afaedc0fd7aaf927a07f82da9c11022251b8b 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg
>  d05688e 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf
>  26dea7951a73079223b50653c455c5adf46a4648 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff
>  dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2
>  500e5172534171f678e01f7569d66f9257036a09 
>   contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js 
> dfd89b2 
>   contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js 
> 0dc0cb

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-07-05 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60249/#review179667
---




ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
Lines 117 (patched)
<https://reviews.apache.org/r/60249/#comment254481>

how are we co-relating the host and the all_racks array here?
Are we expecting the hosts to be sorted and all_racks to match with 
all_racks index to pick the config.
This might break if the user later adds another broker.



ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
Lines 121 (patched)
<https://reviews.apache.org/r/60249/#comment254478>

This will add the broker.rack to all the versions. Can we make sure we only 
add this 0.10.x onwards


- Sriharsha Chintalapani


On July 4, 2017, 6:53 p.m., Ambud Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60249/
> ---
> 
> (Updated July 4, 2017, 6:53 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari rack awareness for Kafka. 
> https://issues.apache.org/jira/browse/AMBARI-21234
> 
> As an operations person it would be nice to manage Kafka rack awareness via 
> Ambari. Ambari allows node rack information to be configured and this 
> information can then be pulled in the Kafka stack and populated in the 
> server.properties file for Kafka.
> Design:
> This stack change uses the /clusterHostInfo/all_hosts and 
> /clusterHostInfo/all_racks paths and materializes them to a variable. Then it 
> uses linear search to find this node in the list of all hosts and it's 
> corresponding rack id. This information is then stored in a variable called 
> rack and which is materialized during the configure method of the broker 
> scripts.
> This stack change relies on the node rack information stored in Ambari 
> therefore will enable both Ambari UI and Blueprints to be used for setting up 
> Kafka broker rack information.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
> d322adc47b 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  1327090aa7 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  c36a10ff28 
> 
> 
> Diff: https://reviews.apache.org/r/60249/diff/5/
> 
> 
> Testing
> ---
> 
> Manually deployed Kafka cluster and verified the broker.rack property is 
> correctly populated.
> 
> 
> Thanks,
> 
> Ambud Sharma
> 
>

Review Request 59612: AMBARI-21136: Upgrading Ambari to 2.5.1 stops Storm's nimbus in secure mode.

2017-05-26 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59612/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-21136
https://issues.apache.org/jira/browse/AMBARI-21136


Repository: ambari


Description
---

AMBARI-21136: Upgrading Ambari to 2.5.1 stops Storm's nimbus in secure mode.


Diffs
-

  ambari-server/src/main/resources/common-services/STORM/1.1.0/kerberos.json 
643cfd38e2 


Diff: https://reviews.apache.org/r/59612/diff/1/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

2017-05-23 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
---

(Updated May 23, 2017, 11:14 p.m.)


Review request for Ambari and Alejandro Fernandez.


Repository: ambari


Description
---

AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
 40fafb21a87bf01fce7088ce43d06ab8af809522 
  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml
 1a5dde9c16defc04377a8c171d6081a757f99a36 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
d8e2d7d7532b90df3ee9f65d13f6a90fe78da9cc 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 ca3c19358a66ea64659f8b57cb88be8eb093cfc2 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
cf2c2574da078d03ad0e29bb059a8446dea5f493 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
83a0a1eddf11ca20a066a1a8b9fdb4f9ebe16f39 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 6e899ee18f13ede38b60a920788acfe7f10c51dd 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
4e14e83bd653499339e64d430a20bebdca2951af 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
483a19497a956f7683bb17c0dd5e38b9e0f53f97 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 befc38bd078b719cb517a3ee7a885d6dddf9f9b7 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca30c19b6a46060fb30d8852f0af4f854fcc 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
9cd4acffe68b5a2fe17a1074574e9d7e7091038c 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1610bb5580b5f17c0d642d74caf0f9e04a0d8b8b 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 1cdd18452902b911dd24971e00885f53a05e4bd6 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
3e7e3d7f14f6333b4bbf2b71738bf683bde8122c 
  ambari-server/src/main/resources/stacks/stack_advisor.py 
e393b9cbd9747330a7a8cab8acc40268e1fd6607 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java
 862ab6e46d38a07032ee69381f4f4dd300819706 


Diff: https://reviews.apache.org/r/59459/diff/9/

Changes: https://reviews.apache.org/r/59459/diff/8-9/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

2017-05-23 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
---

(Updated May 23, 2017, 9:16 p.m.)


Review request for Ambari and Alejandro Fernandez.


Repository: ambari


Description
---

AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
 9255daf76b 
  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml
 1a5dde9c16 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
8b5c07dc90 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 5aa08c5369 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d98bb53a2a 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
b3d19d42e1 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 4a2a502a20 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
1eb9836abb 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a29f74b668 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8c659ee469 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca30c1 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
488562bf11 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1610bb5580 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 1cdd184529 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
3e7e3d7f14 
  ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 


Diff: https://reviews.apache.org/r/59459/diff/8/

Changes: https://reviews.apache.org/r/59459/diff/7-8/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

2017-05-23 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
---

(Updated May 23, 2017, 4:58 p.m.)


Review request for Ambari and Alejandro Fernandez.


Repository: ambari


Description
---

AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml
 1a5dde9c16 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
8b5c07dc90 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 5aa08c5369 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d98bb53a2a 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
b3d19d42e1 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 4a2a502a20 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
1eb9836abb 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a29f74b668 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8c659ee469 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca30c1 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
488562bf11 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1610bb5580 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 1cdd184529 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
3e7e3d7f14 
  ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 


Diff: https://reviews.apache.org/r/59459/diff/6/

Changes: https://reviews.apache.org/r/59459/diff/5-6/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

2017-05-23 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
---

(Updated May 23, 2017, 4:49 p.m.)


Review request for Ambari and Alejandro Fernandez.


Repository: ambari


Description
---

AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml
 1a5dde9c16 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
8b5c07dc90 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 5aa08c5369 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d98bb53a2a 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
b3d19d42e1 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 4a2a502a20 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
1eb9836abb 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a29f74b668 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8c659ee469 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca30c1 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
488562bf11 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1610bb5580 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 1cdd184529 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
3e7e3d7f14 
  ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 


Diff: https://reviews.apache.org/r/59459/diff/5/

Changes: https://reviews.apache.org/r/59459/diff/4-5/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

2017-05-22 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
---

(Updated May 22, 2017, 8:51 p.m.)


Review request for Ambari and Alejandro Fernandez.


Repository: ambari


Description
---

AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml
 1a5dde9c16 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
8b5c07dc90 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 5aa08c5369 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d98bb53a2a 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
b3d19d42e1 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 4a2a502a20 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
1eb9836abb 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a29f74b668 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 8c659ee469 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
3054ca30c1 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
488562bf11 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
1610bb5580 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 1cdd184529 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
3e7e3d7f14 
  ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 


Diff: https://reviews.apache.org/r/59459/diff/3/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

2017-03-02 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167793
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On March 2, 2017, 10:52 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> ---
> 
> (Updated March 2, 2017, 10:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding dependency of kafka broker's listeners config to populate accurate 
> port for Atlas atlas.kafka.bootstrap.servers property.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  15cc73b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> a450d4d 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 2d7bcd3 
> 
> 
> Diff: https://reviews.apache.org/r/57139/diff/3/
> 
> 
> Testing
> ---
> 
> Verified dependency of : listeners propert for following cases: 
> 
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:
> 
> 2) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:
> 
> 3) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:
> 
> 4) Kerberos environment with listener's value as : 
> PLAINTEXT://localhost: :: in this case it will pickup the port given 
> for PLAINTEXT protocol only (as SASL port is not specified).
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

2017-03-01 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167513
---


Ship it!




This looks good. I suggest you to add one more test or test manually if the 
protocol is SASL_PLAINTEXT. As per the code it looks like handling it but good 
to test this part.

- Sriharsha Chintalapani


On March 1, 2017, 12:36 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> ---
> 
> (Updated March 1, 2017, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding dependency of kafka broker's listeners config to populate accurate 
> port for Atlas atlas.kafka.bootstrap.servers property.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  15cc73b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 6f3dfa7 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> cf1c0ee 
> 
> 
> Diff: https://reviews.apache.org/r/57139/diff/2/
> 
> 
> Testing
> ---
> 
> Verified dependency of : listeners propert for following cases: 
> 
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:
> 
> 2) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:
> 
> 3) Kerberos environment with listener's value as : 
> PLAINTEXTSASL://localhost:,PLAINTEXT://localhost:
> 
> 4) Kerberos environment with listener's value as : 
> PLAINTEXT://localhost: :: in this case it will pickup the port given 
> for PLAINTEXT protocol only (as SASL port is not specified).
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

2016-11-14 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53597/#review155880
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On Nov. 15, 2016, 1:57 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53597/
> ---
> 
> (Updated Nov. 15, 2016, 1:57 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sriharsha Chintalapani, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-18829
> https://issues.apache.org/jira/browse/AMBARI-18829
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow Ambari to manage Kafka's Custom JAAS Config.
> Move the existing j2 templates (kafka_jaas.conf.j2 and 
> kafka_client_jaas.conf.j2) into config properties.
> 
> I intentionally left the j2 templates and logic to fall back to j2 template 
> for now. They will be removed later.
> 
> Thanks Alejandro for pointing out the earlier patch being too large - I think 
> I diffed against the wrong branch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
> 8630c87 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  6b4579c 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  6fe438d 
> 
> Diff: https://reviews.apache.org/r/53597/diff/
> 
> 
> Testing
> ---
> 
> Manually ran unit tests on dev machine.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

2016-11-14 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53597/#review155875
---




ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
 (line 34)
<https://reviews.apache.org/r/53597/#comment225978>

we don't need client section here for kafka_client_jaas


- Sriharsha Chintalapani


On Nov. 9, 2016, 6:22 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53597/
> ---
> 
> (Updated Nov. 9, 2016, 6:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sriharsha Chintalapani, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-18829
> https://issues.apache.org/jira/browse/AMBARI-18829
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow Ambari to manage Kafka's Custom JAAS Config.
> Move the existing j2 templates (kafka_jaas.conf.j2 and 
> kafka_client_jaas.conf.j2) into config properties.
> 
> I intentionally left the j2 templates and logic to fall back to j2 template 
> for now. They will be removed later.
> 
> Thanks Alejandro for pointing out the earlier patch being too large - I think 
> I diffed against the wrong branch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_client_jaas_conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml 
> 8630c87 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  ac7b0ae 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  6fe438d 
> 
> Diff: https://reviews.apache.org/r/53597/diff/
> 
> 
> Testing
> ---
> 
> Manually ran unit tests on dev machine.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 50529: Kafka brokers went down after Ambari upgrade due to IllegalArgumentException

2016-07-27 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50529/#review143796
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On July 27, 2016, 7:40 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50529/
> ---
> 
> (Updated July 27, 2016, 7:40 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sumit Mohanty, and Sriharsha 
> Chintalapani.
> 
> 
> Bugs: AMBARI-17929
> https://issues.apache.org/jira/browse/AMBARI-17929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Steps*
> # Deploy HDP-2.4.2 cluster with Ambari 2.2.2.0
> # Upgrade Ambari to 2.4.0.0
> # Observe the status of Kafka brokers
> 
> *Result*
> All brokers report down
> Logs indicate below:
> {code}
> [2016-07-27 05:48:26,535] INFO Initializing Kafka Timeline Metrics Sink 
> (org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter)
> [2016-07-27 05:48:26,571] INFO Started Kafka Timeline metrics reporter with 
> polling period 10 seconds 
> (org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter)
> [2016-07-27 05:48:26,716] INFO KafkaConfig values:
>   request.timeout.ms = 3
>   log.roll.hours = 168
>   inter.broker.protocol.version = 0.9.0.X
>   log.preallocate = false
>   security.inter.broker.protocol = PLAINTEXTSASL
>   controller.socket.timeout.ms = 3
>   broker.id.generation.enable = true
>   ssl.keymanager.algorithm = SunX509
>   ssl.key.password = [hidden]
>   log.cleaner.enable = true
>   ssl.provider = null
>   num.recovery.threads.per.data.dir = 1
>   background.threads = 10
>   unclean.leader.election.enable = true
>   sasl.kerberos.kinit.cmd = /usr/bin/kinit
>   replica.lag.time.max.ms = 1
>   ssl.endpoint.identification.algorithm = null
>   auto.create.topics.enable = true
>   zookeeper.sync.time.ms = 2000
>   ssl.client.auth = none
>   ssl.keystore.password = [hidden]
>   log.cleaner.io.buffer.load.factor = 0.9
>   offsets.topic.compression.codec = 0
>   log.retention.hours = 168
>   log.dirs = /kafka-logs
>   ssl.protocol = TLS
>   log.index.size.max.bytes = 10485760
>   sasl.kerberos.min.time.before.relogin = 6
>   log.retention.minutes = null
>   connections.max.idle.ms = 60
>   ssl.trustmanager.algorithm = PKIX
>   offsets.retention.minutes = 8640
>   max.connections.per.ip = 2147483647
>   replica.fetch.wait.max.ms = 500
>   metrics.num.samples = 2
>   port = 6667
>   offsets.retention.check.interval.ms = 60
>   log.cleaner.dedupe.buffer.size = 134217728
>   log.segment.bytes = 1073741824
>   group.min.session.timeout.ms = 6000
>   producer.purgatory.purge.interval.requests = 1
>   min.insync.replicas = 1
>   ssl.truststore.password = [hidden]
>   log.flush.scheduler.interval.ms = 9223372036854775807
>   socket.receive.buffer.bytes = 102400
>   leader.imbalance.per.broker.percentage = 10
>   num.io.threads = 8
>   zookeeper.connect = 
> nats11-36-alzs-dgm10toeriedwngdha-s11-3.openstacklocal:2181,nats11-36-alzs-dgm10toeriedwngdha-s11-4.openstacklocal:2181,nats11-36-alzs-dgm10toeriedwngdha-s11-1.openstacklocal:2181
>   queued.max.requests = 500
>   offsets.topic.replication.factor = 3
>   replica.socket.timeout.ms = 3
>   offsets.topic.segment.bytes = 104857600
>   replica.high.watermark.checkpoint.interval.ms = 5000
>   broker.id = -1
>   ssl.keystore.location = /etc/security/serverKeys/keystore.jks
>   listeners = 
> PLAINTEXT://nats11-36-alzs-dgm10toeriedwngdha-s11-1.openstacklocal:6667,SSL://nats11-36-alzs-dgm10toeriedwngdha-s11-1.openstacklocal:
>   log.flush.interval.messages = 9223372036854775807
>   principal.builder.class = class 
> org.apache.kafka.common.security.auth.DefaultPrincipalBuilder
>   log.retention.ms = null
>   offsets.commit.required.acks = -1
>   sasl.kerberos.principal.to.local.rules = [DEFAULT]
>   group.max.session.timeout.ms = 3
>   num.replica.fetchers = 1
>   advertised.listeners = 
> PLAINTEXT://nats11-36-alzs-dgm10toeriedwngdha-s11-1.openstacklocal:6667,SSL://nats11-36-alzs-dgm10toeriedwngdha-s11-1.openstacklocal:
>   replica.socket.receive.buffer.bytes = 65536
>   delete.

Re: Review Request 50479: AMBARI-17909 AMS Storm Sink: apply change of Storm metrics improvement - worker level aggregation

2016-07-27 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50479/#review143768
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On July 27, 2016, 2:52 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50479/
> ---
> 
> (Updated July 27, 2016, 2:52 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17909
> https://issues.apache.org/jira/browse/AMBARI-17909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Abstraction:
> This issue is for following up changes on STORM-2006: Storm metrics feature 
> improvement: support per-worker level metrics aggregation.
> 
> Details:
> With recent patches for AMS and AMS Storm sink, AMS stores task level metrics 
> from Storm, and relevant dashboards can be configured via Grafana.
> But we found that it incurs too many kinds of metrics and also too many data 
> points published to AMS because even a topology can have lots of tasks.
> In order to reduce this, I addressed STORM-2006, but it also needs AMS Storm 
> sink and relevant Storm configurations to be changed.
> 
> Note:
> We're moving some properties so STORM-2006 must be go on together in order to 
> make metrics filter working properly. But AMS Storm sink itself is backward 
> compatible.
> I don't modify legacy AMS Storm sink since STORM-2006 will not be ported back 
> to 0.10.x or lower.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  3a4289b 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  fadb00c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  280fc42 
> 
> Diff: https://reviews.apache.org/r/50479/diff/
> 
> 
> Testing
> ---
> 
> - Build succeed (build passed with 2.4 branch without Ignore annotation)
> - Tested manually with STORM-2006 pre-applied cluster
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 50479: AMBARI-17909 AMS Storm Sink: apply change of Storm metrics improvement - worker level aggregation

2016-07-26 Thread Sriharsha Chintalapani 


> On July 27, 2016, 2:31 a.m., Jungtaek Lim wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> >  line 54
> > <https://reviews.apache.org/r/50479/diff/1/?file=1454635#file1454635line54>
> >
> > To tell the truth I don't understand how this tag works.
> > Could you elaborate how on-ambari-upgrade works, and also could you 
> > check all the properties in this pom? 
> > Other properties (even outside of the patch in this pom) seems to be in 
> > the same line.

basically that property determines if we want to add this setting for new 
upgrades. we should make that true on  rest of settings as well.


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50479/#review143655
---


On July 27, 2016, 1:58 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50479/
> ---
> 
> (Updated July 27, 2016, 1:58 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17909
> https://issues.apache.org/jira/browse/AMBARI-17909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Abstraction:
> This issue is for following up changes on STORM-2006: Storm metrics feature 
> improvement: support per-worker level metrics aggregation.
> 
> Details:
> With recent patches for AMS and AMS Storm sink, AMS stores task level metrics 
> from Storm, and relevant dashboards can be configured via Grafana.
> But we found that it incurs too many kinds of metrics and also too many data 
> points published to AMS because even a topology can have lots of tasks.
> In order to reduce this, I addressed STORM-2006, but it also needs AMS Storm 
> sink and relevant Storm configurations to be changed.
> 
> Note:
> We're moving some properties so STORM-2006 must be go on together in order to 
> make metrics filter working properly. But AMS Storm sink itself is backward 
> compatible.
> I don't modify legacy AMS Storm sink since STORM-2006 will not be ported back 
> to 0.10.x or lower.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  3a4289b 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  fadb00c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  280fc42 
> 
> Diff: https://reviews.apache.org/r/50479/diff/
> 
> 
> Testing
> ---
> 
> - Build succeed (build passed with 2.4 branch without Ignore annotation)
> - Tested manually with STORM-2006 pre-applied cluster
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 50063: AMBARI-17725: AMS Storm Sink: Storm topology level metrics should have prefix to distinguish cluster level metrics

2016-07-20 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50063/#review142955
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On July 15, 2016, 4:56 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50063/
> ---
> 
> (Updated July 15, 2016, 4:56 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17725
> https://issues.apache.org/jira/browse/AMBARI-17725
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since Ambari 2.4.0 we have two kinds of Storm metrics into AMS which one is 
> cluster level and another one is topology level.
> Currently we don't add prefix on them which makes them hard to distinguish, 
> which should be needed to create topology level dashboard in Grafana.
> 
> To resolve this we should add the prefix to Storm topology level metrics.
> 
> This patch adds 'topology.' as prefix of topology level metrics so that it 
> can be distinguished.
> 
> Also shows warning message to user (in Storm worker) to notice period ('.') 
> in topology name is not recommended for AMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  9e6cc98 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  271c11f 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  dcc3192 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c76197b 
> 
> Diff: https://reviews.apache.org/r/50063/diff/
> 
> 
> Testing
> ---
> 
> Build OK via `mvn clean install` for both of storm-sink and storm-sink-legacy.
> Tested manually.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 50220: AMBARI-17724 AMS Storm sink: Set metrics filter to reduce large amount of built-in Storm metrics

2016-07-20 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50220/#review142954
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On July 20, 2016, 3:49 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50220/
> ---
> 
> (Updated July 20, 2016, 3:49 a.m.)
> 
> 
> Review request for Ambari, Prajwal Rao and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-17724
> https://issues.apache.org/jira/browse/AMBARI-17724
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since Storm built-in metrics are provided to each task, topology with high 
> parallelism incurs lots of metrics pushed to AMS. 
> 
> Since we intend to provide Storm dashboards with AMS (working in progress), 
> we can filter out metrics not used for dashboards to reduce overall metrics 
> count.
> 
> The parameters I'm adding are just ignored from Storm side if Storm doesn't 
> support that parameters. So it could work well with previous version of Storm.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  b4350fc 
> 
> Diff: https://reviews.apache.org/r/50220/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with Storm 1.1.0 SNAPSHOT and Ambari branch 2.4.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

2016-07-19 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/#review142848
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On July 19, 2016, 6:41 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50180/
> ---
> 
> (Updated July 19, 2016, 6:41 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17784
> https://issues.apache.org/jira/browse/AMBARI-17784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is follow-up issue for AMBARI-17725.
> 
> After AMBARI-17725, we can distinguish cluster metrics and topology metrics, 
> which makes us possible to topology name and component name as variables for 
> templatized dashboard.
> 
> But kafkaOffset metrics still have kafka topic and partition information to 
> middle of metric name which make us hard to pick. Since worker host and 
> worker port, and task id is not needed for kafkaOffset metrics, we can get 
> rid of those things from only kafkaOffset metrics.
> 
> > topology level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/totalSpoutLag
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.totalSpoutLag
> 
> > partition level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/partition-5/earliestTimeOffset
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.partition-5.earliestTimeOffset
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  9e6cc98 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  271c11f 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  dcc3192 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c76197b 
> 
> Diff: https://reviews.apache.org/r/50180/diff/
> 
> 
> Testing
> ---
> 
> * Unit test succeed (@ignore is added for trunk. it succeed for branch 2.4)
> * Tested manually
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

2016-07-19 Thread Sriharsha Chintalapani 


> On July 19, 2016, 7:29 p.m., Aravindan Vijayan wrote:
> > Jungtaek, Is the metricName generation logic same for both the legacy and 
> > current version of Storm?

Aravindan, Given that all these metrics coming in HDP-2.5 storm why are we 
worried about legacy version. We are not even storing topology level metrics in 
previous version of storm and I am sure we are not even storing the cluster 
level.


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/#review142812
---


On July 19, 2016, 6:41 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50180/
> ---
> 
> (Updated July 19, 2016, 6:41 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17784
> https://issues.apache.org/jira/browse/AMBARI-17784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is follow-up issue for AMBARI-17725.
> 
> After AMBARI-17725, we can distinguish cluster metrics and topology metrics, 
> which makes us possible to topology name and component name as variables for 
> templatized dashboard.
> 
> But kafkaOffset metrics still have kafka topic and partition information to 
> middle of metric name which make us hard to pick. Since worker host and 
> worker port, and task id is not needed for kafkaOffset metrics, we can get 
> rid of those things from only kafkaOffset metrics.
> 
> > topology level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/totalSpoutLag
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.totalSpoutLag
> 
> > partition level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/partition-5/earliestTimeOffset
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.partition-5.earliestTimeOffset
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  9e6cc98 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  271c11f 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  dcc3192 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c76197b 
> 
> Diff: https://reviews.apache.org/r/50180/diff/
> 
> 
> Testing
> ---
> 
> * Unit test succeed (@ignore is added for trunk. it succeed for branch 2.4)
> * Tested manually
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 48973: AMBARI-17324. kafka should set zookeeper.set.acl to true when kerberos enabled

2016-07-06 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48973/
---

(Updated July 6, 2016, 9:27 p.m.)


Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-17324
https://issues.apache.org/jira/browse/AMBARI-17324


Repository: ambari


Description
---

kafka should set zookeeper.set.acl to true when kerberos enabled


Diffs
-

  ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
eaa3d9d 

Diff: https://reviews.apache.org/r/48973/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 48973: AMBARI-17324. kafka should set zookeeper.set.acl to true when kerberos enabled

2016-07-06 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48973/
---

(Updated July 6, 2016, 9:27 p.m.)


Review request for Ambari and Alejandro Fernandez.


Summary (updated)
-

AMBARI-17324. kafka should set zookeeper.set.acl to true when kerberos enabled


Bugs: AMBARI-17234
https://issues.apache.org/jira/browse/AMBARI-17234


Repository: ambari


Description
---

kafka should set zookeeper.set.acl to true when kerberos enabled


Diffs
-

  ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
eaa3d9d 

Diff: https://reviews.apache.org/r/48973/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 48973: AMBARI-17234. kafka should set zookeeper.set.acl to true when kerberos enabled

2016-07-06 Thread Sriharsha Chintalapani 


> On July 5, 2016, 7:32 p.m., Robert Levas wrote:
> > Ship It!

is this merged?


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48973/#review140857
---


On June 20, 2016, 10:47 p.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48973/
> ---
> 
> (Updated June 20, 2016, 10:47 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17234
> https://issues.apache.org/jira/browse/AMBARI-17234
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> kafka should set zookeeper.set.acl to true when kerberos enabled
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> eaa3d9d 
> 
> Diff: https://reviews.apache.org/r/48973/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-01 Thread Sriharsha Chintalapani 


> On July 1, 2016, 5:09 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> >  line 40
> > 
> >
> > Does the parallelism = 1, mean 1 bolt getting all metric reports in a 
> > topology. Is it counter-intuitive for performance, something we should 
> > check with storm group.
> 
> Jungtaek Lim wrote:
> Its default value has been 1, so setting it explicitly means letting 
> users to modify it easily.

this is tricky config. We should expose this in ambari config page otherwise 
most users wouldn't notice that a metrics bolt running and can cause perf 
degradation if they go with 1 parallelism to prod.


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140384
---


On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated July 1, 2016, 3:32 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 48973: AMBARI-17234. kafka should set zookeeper.set.acl to true when kerberos enabled

2016-06-20 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48973/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-17234
https://issues.apache.org/jira/browse/AMBARI-17234


Repository: ambari


Description
---

kafka should set zookeeper.set.acl to true when kerberos enabled


Diffs
-

  ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
eaa3d9d 

Diff: https://reviews.apache.org/r/48973/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 48735: Storm service check failed after Ambari upgrade

2016-06-15 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48735/#review137810
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On June 15, 2016, 4:59 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48735/
> ---
> 
> (Updated June 15, 2016, 4:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-17258
> https://issues.apache.org/jira/browse/AMBARI-17258
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ambari-server-2.4.0.0-665.x86_64
> ambari-server --hash
> 
> *Steps*
> # Deploy HDP-2.3.2.0 cluster with Ambari 2.1.2 (secure, non-HA cluster)
> # Upgrade Ambari to 2.4.0.0-665
> # Stop and Start all services
> # Run service check for Storm
> 
> *Result*
> Failure as below:
> {code}
> stderr:   /var/lib/ambari-agent/data/errors-729.txt
> 
> Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1/package/scripts/service_check.py",
>  line 79, in 
> ServiceCheck().execute()
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
> File 
> "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1/package/scripts/service_check.py",
>  line 70, in service_check
> user=params.storm_user
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
> File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
> File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
> File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 273, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
> line 293, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'storm jar 
> /tmp/wordCount.jar storm.starter.WordCountTopology 
> WordCountid16ac396c_date241516' returned 1. 951  [main] INFO  b.s.u.Utils - 
> Using defaults.yaml from resources
> 1088 [main] INFO  b.s.u.Utils - Using storm.yaml from resources
> 1184 [main] INFO  b.s.u.Utils - Using defaults.yaml from resources
> 1240 [main] INFO  b.s.u.Utils - Using storm.yaml from resources
> 1285 [main] INFO  b.s.StormSubmitter - Generated ZooKeeper secret payload for 
> MD5-digest: -7463484230184273671:-7128399429695564111
> 1287 [main] INFO  b.s.s.a.AuthUtils - Got AutoCreds []
> 1292 [main] WARN  b.s.u.NimbusClient - Using deprecated config nimbus.host 
> for backward compatibility. Please update your storm.yaml so it only has 
> config nimbus.seeds
> 1352 [main] INFO  b.s.u.StormBoundedExponentialBackoffRetry - The 
> baseSleepTimeMs [2000] the maxSleepTimeMs [6] the maxRetries [5]
> 1615 [main] INFO  o.a.s.z.Login - successfully logged in.
> 1650 [main] ERROR o.a.t.t.TSaslTransport - SASL negotiation failure
> javax.security.sasl.SaslException: GSS initiate failed
> at 
> com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:212)
>  ~[?:1.7.0_67]
> at 
> org.apache.thrift7.transport.TSaslClientTransport.handleSaslStartMessage(TSaslClientTransport.java:94)
>  ~[storm-core-0.10.0.2.3.2.0-2950.jar:0.10.0.2.3.2.0-2950]
> at org.apache.thrift7.transport.TSaslTransport.open(TSaslTransport.java:271) 
> [storm-core-0.10.0.2.3.2.0-2950.jar:0.10.0.2.3.2.0-2950]
> at 
> org.apache.thrift7.transport.TSaslClientTransport.open(TSaslClientTransport.java:37)
>  [storm-core-0.10.0.2.3.2.0-2950.jar:0.10.0.2.3.2.0-2950]
> at 
> backtype.storm.security.auth.kerberos.KerberosSaslTransportPlu

Review Request 48532: AMBARI-17157 Storm 1.0 log4j config update

2016-06-09 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48532/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17157
https://issues.apache.org/jira/browse/AMBARI-17157


Repository: ambari


Description
---

AMBARI-17157  Storm 1.0 log4j config update


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/48532/diff/


Testing
---

Installed storm 1.0 using Ambari. Tested if the logs are being written in new 
format.


Thanks,

Sriharsha Chintalapani

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Sriharsha Chintalapani 


> On June 7, 2016, 6:07 a.m., Sid Wagle wrote:
> > Changes look good, only thing to consider is the changes to the metric 
> > name. Cluster Aggregation will not occur at topology level since appId = 
> > topologyName for metrics with the same metric name. Is the metric name to 
> > fine grained? Only thing to consider is whether we need task metrics to be 
> > aggregated across topology? If yes, taskId cannot be part of the metric 
> > name. 
> > 
> > Could you also add Aravindan Vijayan to the reviewers? Thanks.
> 
> Sid Wagle wrote:
> Rephrase: Cluster Aggregation will *now* occur at topology level
> 
> Jungtaek Lim wrote:
> > Only thing to consider is whether we need task metrics to be aggregated 
> across topology? If yes, taskId cannot be part of the metric name. 
> 
> It depends on users, but most cases I don't think user will aggregate 
> metrics across topologies.
> 
> And like what I was saying, technically there're no way to aggregate 
> metrics on sink side since parallelism of sink can be set to more than 1 (I 
> mean, we could have multiple aggregation points which breaks aggregation.)
> So we need to push task level metrics into AMS, and task id should be 
> included as metric name for making it unique.
> 
> Based on that, we need `series aggregation` to aggregate task level 
> metrics by higher level. (I'm trying to address this via AMBARI-17027)
> 
> The only thing which affects aggregation is appId.
> 
> - When we set appId to 'component name' (current), same component (Spout, 
> Bolt) name across topologies can be queried together.
> - When we set appId to 'topology name', same metric name (for Storm's 
> view) from different components in topology can be queried together.
> - When we set appId to 'Storm', all metrics can be queried together. 
> (metric name should also include topology name as well)
> 
> I'm not familiar with structure of metrics so I'm not sure how they 
> affects performance while storing / querying. So I'd like to hear opinions on 
> reviewers.
> 
> For reference, below is how storm-graphite composes prefix of metric 
> name. It uses topology name, component name, worker host, worker port, task 
> id.
> 
> https://github.com/verisign/storm-graphite/blob/master/src/main/java/com/verisign/storm/metrics/GraphiteMetricsConsumer.java#L278
> 
> When querying metrics from Graphite users can query with wildcards & 
> series function to aggregate metrics into one and Grafana can show that. 
> That's what I want to address to AMS.
> 
> Aravindan Vijayan wrote:
> Jungtaek, there is also another level of classification called 
> "instancedId" Every appId can have multiple instanceIds. You should find that 
> in the TimelineMetric object. Perhaps, we can use that here.
> 
> Sriharsha Chintalapani wrote:
> @Jungtaek what Sid was saying is we won't be able to see the aggregated 
> metrics for a single topology if we use taskId. Lets say if I want to see how 
> many tuples are processed in last hour for that topology that aggregation 
> won't be possible using taskId.
> 
> Jungtaek Lim wrote:
> @Aravindan
> Yeah, actually I was trying to use instanceId for the first time, but 
> TimelineMetricCache (TimelineMetricHolder) only checks metric name as unique 
> key while putting so that's what I described. Furthermore, I would want to 
> aggregate task level metrics into component level metrics but there's no 
> wildcard support on instanceId. So there seems to much effort to use 
> instanceId for taskId, and having taskId as metric name is easier way to 
> achieve aggregation for now.
> But I'm open to use instanceId, and support wildcard & aggregation on 
> this. Please let me know we would want to use instanceId. @Sid @Sriharsha
> 
> @Sriharsha
> I guess what Sid was saying is opposite to what you're saying. Let's 
> pretend cluster aggregation is occurred.
> 
> A. current
> 
> appId is component name and metric name is just metric name so there's no 
> distinction between topologies. (topology name is not placed anywhere now) So 
> cluster aggregation will aggregate metrics across topologies, and we can't 
> query last 1 hours of Topology T1, Bolt B1, Metric M1. There're no way to 
> query within Topology T1 regardless of aggregation.
> 
> B. after patch
> 
> appId is topology name and metric name is component name + task id + 
> metric name so metrics are classified as topology name. So cluster 
> aggregation will aggregate metrics for each topology, and we can't query last 
> 1 hours of all topologies, Bolt

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48030/#review136767
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On June 9, 2016, 1:58 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48030/
> ---
> 
> (Updated June 9, 2016, 1:58 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-16946
> https://issues.apache.org/jira/browse/AMBARI-16946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There's a mismatch between TimelineMetricsCache and Storm metrics unit, while 
> TimelineMetricsCache considers "metric name + timestamp" to be unique but 
> Storm is not.
> 
> For example, assume that bolt B has task T1, T2 and B has registered metrics 
> M1. It's possible for metrics sink to receive (T1, M1) and (T2, M1) with same 
> timestamp TS1 (in TaskInfo, not current time), and received later will be 
> discarded from TimelineMetricsCache.
> 
> If we want to have unique metric point of Storm, we should use "topology name 
> + component name + task id + metric name" to metric name so that "metric name 
> + timestamp" will be unique.
> 
> There're other issues I would like to address, too.
> 
> - Currently, hostname is written to hostname of the machine which runs 
> metrics sink. Since TaskInfo has hostname of the machine which runs task, 
> we're better to use this.
> - Unit of timestamp of TaskInfo is second, while Storm Metrics Sink uses this 
> as millisecond, resulting in timestamp flaw, and malfunction of cache 
> eviction. It should be multiplied by 1000.
> - 'component name' is not unique across the cluster, so it's not fit for app 
> id. 'topology name' is unique so proper value of app id is topology name.
> 
> Consideration: Hostname for determining 'write shard' is set to hostname of 
> the machine which runs metrics sink. Since I don't know read also be sharded, 
> I'm not sure it's safe to use TaskInfo's hostname to hostname of 
> TimelineMetric. Please review carefully regarding this.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  02f5598 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  8171a4d 
> 
> Diff: https://reviews.apache.org/r/48030/diff/
> 
> 
> Testing
> ---
> 
> I tested this only ambari-metrics module since changeset is not related on 
> other modules.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ambari-metrics . SUCCESS [  0.896 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [ 13.386 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.085 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  6.827 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  4.190 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.384 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [04:06 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  3.556 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [01:03 
> min]
> [INFO] Ambari Metrics Assembly  SUCCESS [  3.567 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 05:48 min
> [INFO] Finished at: 2016-05-30T16:46:07+09:00
> [INFO] Final Memory: 78M/1038M
> [INFO] 
> 
> 
> In fact, I tried to run `mvn test` from ambari root directory but build is 
> failing from ambari-web.
> 
> ```
> > fsevents@0.2.1 install 
> > /Users/jlim/WorkArea/JavaProjects/ambari/ambari-web/node_modules/chokidar/node_modules/fsevents
> > node-gyp rebuild
> ...
> npm WARN install:fsevents fsevents@0.2.1 install: `node-gyp rebuild`
> npm WARN install:fsevents Exit status 1
> ```
> 
> No luck on `npm install`, too.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 48379: EU - HDP 2.4 to 2.5 fails restarting DRPC server on a kerberized cluster, need to use org.apache.storm.security.auth.KerberosPrincipalToLocal

2016-06-07 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48379/#review136560
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On June 7, 2016, 10:55 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48379/
> ---
> 
> (Updated June 7, 2016, 10:55 p.m.)
> 
> 
> Review request for Ambari and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-17100
> https://issues.apache.org/jira/browse/AMBARI-17100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> * Install Ambari 2.4
> * Install HDP 2.4
> * Kerberize the cluster
> * Perform EU to HDP 2.5
> 
> The config packs have
>  find="backtype.storm.security.auth.KerberosPrincipalToLocal"
>  
> replace-with="org.apache.storm.security.auth.KerberosPrincipalToLocal" />
> 
> However, storm.yaml still has storm.principal.tolocal : 
> 'backtype.storm.security.auth.KerberosPrincipalToLocal'
> 
> I replaced that property as well and it started working.
> Storm 1.0.1 already has its kerberos.json file using 
> "storm.principal.tolocal": 
> "org.apache.storm.security.auth.KerberosPrincipalToLocal", and stack HDP 2.5 
> uses that version of Storm, so EU/RU should set the property if it exists, 
> meaning the cluster is kerberized.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 9df0663 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> f559031 
> 
> Diff: https://reviews.apache.org/r/48379/diff/
> 
> 
> Testing
> ---
> 
> Verified during EU from HDP 2.4 to 2.5 on a Kerberized cluster with Storm.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-07 Thread Sriharsha Chintalapani 


> On June 7, 2016, 6:07 a.m., Sid Wagle wrote:
> > Changes look good, only thing to consider is the changes to the metric 
> > name. Cluster Aggregation will not occur at topology level since appId = 
> > topologyName for metrics with the same metric name. Is the metric name to 
> > fine grained? Only thing to consider is whether we need task metrics to be 
> > aggregated across topology? If yes, taskId cannot be part of the metric 
> > name. 
> > 
> > Could you also add Aravindan Vijayan to the reviewers? Thanks.
> 
> Sid Wagle wrote:
> Rephrase: Cluster Aggregation will *now* occur at topology level
> 
> Jungtaek Lim wrote:
> > Only thing to consider is whether we need task metrics to be aggregated 
> across topology? If yes, taskId cannot be part of the metric name. 
> 
> It depends on users, but most cases I don't think user will aggregate 
> metrics across topologies.
> 
> And like what I was saying, technically there're no way to aggregate 
> metrics on sink side since parallelism of sink can be set to more than 1 (I 
> mean, we could have multiple aggregation points which breaks aggregation.)
> So we need to push task level metrics into AMS, and task id should be 
> included as metric name for making it unique.
> 
> Based on that, we need `series aggregation` to aggregate task level 
> metrics by higher level. (I'm trying to address this via AMBARI-17027)
> 
> The only thing which affects aggregation is appId.
> 
> - When we set appId to 'component name' (current), same component (Spout, 
> Bolt) name across topologies can be queried together.
> - When we set appId to 'topology name', same metric name (for Storm's 
> view) from different components in topology can be queried together.
> - When we set appId to 'Storm', all metrics can be queried together. 
> (metric name should also include topology name as well)
> 
> I'm not familiar with structure of metrics so I'm not sure how they 
> affects performance while storing / querying. So I'd like to hear opinions on 
> reviewers.
> 
> For reference, below is how storm-graphite composes prefix of metric 
> name. It uses topology name, component name, worker host, worker port, task 
> id.
> 
> https://github.com/verisign/storm-graphite/blob/master/src/main/java/com/verisign/storm/metrics/GraphiteMetricsConsumer.java#L278
> 
> When querying metrics from Graphite users can query with wildcards & 
> series function to aggregate metrics into one and Grafana can show that. 
> That's what I want to address to AMS.
> 
> Aravindan Vijayan wrote:
> Jungtaek, there is also another level of classification called 
> "instancedId" Every appId can have multiple instanceIds. You should find that 
> in the TimelineMetric object. Perhaps, we can use that here.

@Jungtaek what Sid was saying is we won't be able to see the aggregated metrics 
for a single topology if we use taskId. Lets say if I want to see how many 
tuples are processed in last hour for that topology that aggregation won't be 
possible using taskId.


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48030/#review136411
---


On June 7, 2016, 6:14 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48030/
> ---
> 
> (Updated June 7, 2016, 6:14 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-16946
> https://issues.apache.org/jira/browse/AMBARI-16946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There's a mismatch between TimelineMetricsCache and Storm metrics unit, while 
> TimelineMetricsCache considers "metric name + timestamp" to be unique but 
> Storm is not.
> 
> For example, assume that bolt B has task T1, T2 and B has registered metrics 
> M1. It's possible for metrics sink to receive (T1, M1) and (T2, M1) with same 
> timestamp TS1 (in TaskInfo, not current time), and received later will be 
> discarded from TimelineMetricsCache.
> 
> If we want to have unique metric point of Storm, we should use "topology name 
> + component name + task id + metric name" to metric name so that "metric name 
> + timestamp" will be unique.
> 
> There're other issues I would like to address, too.
> 
> - Currently, hostn

Re: Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

2016-06-06 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48065/#review136402
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On June 3, 2016, 12:43 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48065/
> ---
> 
> (Updated June 3, 2016, 12:43 a.m.)
> 
> 
> Review request for Ambari, Sriharsha Chintalapani and Sid Wagle.
> 
> 
> Bugs: AMBARI-16949
> https://issues.apache.org/jira/browse/AMBARI-16949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When we request '/ws/v1/timeline/metrics' with metric name which contains %25 
> (escaped '%'), response for the API is json describing there's NPE.
> And NPE is logged for ambari-metrics-collector log file.
> 
> ```
> 2016-05-30 09:15:05,061 WARN 
> org.apache.hadoop.yarn.webapp.GenericExceptionHandler: INTERNAL_SERVER_ERROR
> java.lang.NullPointerException
>   at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.PhoenixHBaseAccessor.appendAggregateMetricFromResultSet(PhoenixHBaseAccessor.java:810)
>   at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.PhoenixHBaseAccessor.getAggregateMetricRecords(PhoenixHBaseAccessor.java:772)
>   at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.HBaseTimelineMetricStore.getTimelineMetrics(HBaseTimelineMetricStore.java:178)
>   at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.webapp.TimelineWebServices.getTimelineMetrics(TimelineWebServices.java:372)
>   at sun.reflect.GeneratedMethodAccessor21.invoke(Unknown Source)
> ```
> 
> Reason of NPE: 
> 
> Metrics are properly fetched with wildcard. But when applying functions to 
> result set, actual metric name is not exist from map of metric name to list 
> of function.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  47962cb 
> 
> Diff: https://reviews.apache.org/r/48065/diff/
> 
> 
> Testing
> ---
> 
> Test failed from local but it's occurred from another modules, which is not 
> related to current modification.
> 
> ```
> Results :
> 
> Failed tests:
>   PrivilegeEventCreatorTest.putTest:107 expected:<...), Roles(
> Permission[2:
>   Users: testuser2
> Permission1:
>   Users: testuser
>   Groups: testgroup])> but was:<...), Roles(
> Permission[1:
>   Users: testuser
>   Groups: testgroup
> Permission2:
>   Users: testuser2])>
>   RepositoryVersionEventCreatorTest.postTest:70 expected:<...ating system: 
> redhat[6
> Repository ID(2), Repository name(MyRepo6), Base url(http://example6.com)
> Operating system: redhat7
> Repository ID(1), Repository name(MyRepo), Base url(http://example].com)
> )> but was:<...ating system: redhat[7
> Repository ID(1), Repository name(MyRepo), Base url(http://example.com)
> Operating system: redhat6
> Repository ID(2), Repository name(MyRepo6), Base url(http://example6].com)
> )>
>   RepositoryVersionEventCreatorTest.putTest:100 expected:<...ating system: 
> redhat[6
> Repository ID(2), Repository name(MyRepo6), Base url(http://example6.com)
> Operating system: redhat7
> Repository ID(1), Repository name(MyRepo), Base url(http://example].com)
> )> but was:<...ating system: redhat[7
> Repository ID(1), Repository name(MyRepo), Base url(http://example.com)
> Operating system: redhat6
> Repository ID(2), Repository name(MyRepo6), Base url(http://example6].com)
> )>
>   ViewPrivilegeEventCreatorTest.putTest:85 expected:<...tatus(200 OK), 
> Type([MyView), Version(MyView), Name(MyView), Permissions(
> Permission2:
>   Users: testuser2
> Permission1:
>   Users: testuser
>   Groups: testgroup])> but was:<...tatus(200 OK), Type([null), Version(null), 
> Name(null), Permissions(
> Permission1:
>   Users: testuser
>   Groups: testgroup
> Permission2:
>   Users: testuser2])>
>   
> ComponentResourceProviderTest.testGetResourcesAsAdministrator:190->testGetResources:296
>  expected:<[tru]e> but was:<[fals]e>
>   
> ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:195->testGetResources:296
>  expected:<[tru]e> but was:<[fals]e>
>   
> ComponentResourceProvi

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-06 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48030/#review136400
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On May 30, 2016, 8:21 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48030/
> ---
> 
> (Updated May 30, 2016, 8:21 a.m.)
> 
> 
> Review request for Ambari, Sriharsha Chintalapani and Sid Wagle.
> 
> 
> Bugs: AMBARI-16946
> https://issues.apache.org/jira/browse/AMBARI-16946
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There's a mismatch between TimelineMetricsCache and Storm metrics unit, while 
> TimelineMetricsCache considers "metric name + timestamp" to be unique but 
> Storm is not.
> 
> For example, assume that bolt B has task T1, T2 and B has registered metrics 
> M1. It's possible for metrics sink to receive (T1, M1) and (T2, M1) with same 
> timestamp TS1 (in TaskInfo, not current time), and received later will be 
> discarded from TimelineMetricsCache.
> 
> If we want to have unique metric point of Storm, we should use "topology name 
> + component name + task id + metric name" to metric name so that "metric name 
> + timestamp" will be unique.
> 
> There're other issues I would like to address, too.
> 
> - Currently, hostname is written to hostname of the machine which runs 
> metrics sink. Since TaskInfo has hostname of the machine which runs task, 
> we're better to use this.
> - Unit of timestamp of TaskInfo is second, while Storm Metrics Sink uses this 
> as millisecond, resulting in timestamp flaw, and malfunction of cache 
> eviction. It should be multiplied by 1000.
> - 'component name' is not unique across the cluster, so it's not fit for app 
> id. 'topology name' is unique so proper value of app id is topology name.
> 
> Consideration: Hostname for determining 'write shard' is set to hostname of 
> the machine which runs metrics sink. Since I don't know read also be sharded, 
> I'm not sure it's safe to use TaskInfo's hostname to hostname of 
> TimelineMetric. Please review carefully regarding this.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  02f5598 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  8171a4d 
> 
> Diff: https://reviews.apache.org/r/48030/diff/
> 
> 
> Testing
> ---
> 
> I tested this only ambari-metrics module since changeset is not related on 
> other modules.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ambari-metrics . SUCCESS [  0.896 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [ 13.386 
> s]
> [INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.085 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  6.827 
> s]
> [INFO] Ambari Metrics Kafka Sink .. SUCCESS [  4.190 
> s]
> [INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.384 
> s]
> [INFO] Ambari Metrics Collector ... SUCCESS [04:06 
> min]
> [INFO] Ambari Metrics Monitor . SUCCESS [  3.556 
> s]
> [INFO] Ambari Metrics Grafana . SUCCESS [01:03 
> min]
> [INFO] Ambari Metrics Assembly  SUCCESS [  3.567 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 05:48 min
> [INFO] Finished at: 2016-05-30T16:46:07+09:00
> [INFO] Final Memory: 78M/1038M
> [INFO] 
> 
> 
> In fact, I tried to run `mvn test` from ambari root directory but build is 
> failing from ambari-web.
> 
> ```
> > fsevents@0.2.1 install 
> > /Users/jlim/WorkArea/JavaProjects/ambari/ambari-web/node_modules/chokidar/node_modules/fsevents
> > node-gyp rebuild
> ...
> npm WARN install:fsevents fsevents@0.2.1 install: `node-gyp rebuild`
> npm WARN install:fsevents Exit status 1
> ```
> 
> No luck on `npm install`, too.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-25 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/#review134848
---




ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (line 
916)
<https://reviews.apache.org/r/47332/#comment199783>

same as drpc



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (line 
927)
<https://reviews.apache.org/r/47332/#comment199782>

Thats how we are doing it other upgrades as well and its intentional.


- Sriharsha Chintalapani


On May 20, 2016, 7:17 p.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47332/
> ---
> 
> (Updated May 20, 2016, 7:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upgrade pack changes to work with Storm 1.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7d67f8e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
> 
> Diff: https://reviews.apache.org/r/47332/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-25 Thread Sriharsha Chintalapani 


> On May 25, 2016, 9:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml, 
> > line 887
> > <https://reviews.apache.org/r/47332/diff/3/?file=1389382#file1389382line887>
> >
> > Why was STORM_REST_API deleted?

We don't need this service any more. Its been this way since HDP 2.3


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/#review134841
---


On May 20, 2016, 7:17 p.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47332/
> ---
> 
> (Updated May 20, 2016, 7:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upgrade pack changes to work with Storm 1.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7873853 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1cd2ffa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7d67f8e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 9c6a02d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> a7dbba3 
> 
> Diff: https://reviews.apache.org/r/47332/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-20 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/
---

(Updated May 20, 2016, 7:17 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-16648
https://issues.apache.org/jira/browse/AMBARI-16648


Repository: ambari


Description
---

Upgrade pack changes to work with Storm 1.0


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7873853 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1cd2ffa 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 7d67f8e 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
9c6a02d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a7dbba3 

Diff: https://reviews.apache.org/r/47332/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-19 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/
---

(Updated May 20, 2016, 3:11 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-16648
https://issues.apache.org/jira/browse/AMBARI-16648


Repository: ambari


Description
---

Upgrade pack changes to work with Storm 1.0


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7873853 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1cd2ffa 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 7d67f8e 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
9c6a02d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a7dbba3 

Diff: https://reviews.apache.org/r/47332/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47288: AMBARI-16225. Storm Ambari view should work with Firefox 25

2016-05-16 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47288/
---

(Updated May 17, 2016, 5:51 a.m.)


Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-16225
https://issues.apache.org/jira/browse/AMBARI-16225


Repository: ambari


Description
---

Storm Ambari view should work with Firefox 25


Diffs
-

  contrib/views/storm/src/main/resources/scripts/collections/BaseCollection.js 
29b1ce9 
  contrib/views/storm/src/main/resources/scripts/components/Breadcrumbs.jsx 
75c2fa9 
  contrib/views/storm/src/main/resources/scripts/components/Modal.jsx e37b734 
  contrib/views/storm/src/main/resources/scripts/components/RadialChart.jsx 
f28b08a 
  contrib/views/storm/src/main/resources/scripts/components/SpoutGraph.jsx 
cec4c85 
  contrib/views/storm/src/main/resources/scripts/components/Table.jsx 3b0ad50 
  contrib/views/storm/src/main/resources/scripts/components/TopologyGraph.jsx 
e74a251 
  contrib/views/storm/src/main/resources/scripts/containers/NimbusSummary.jsx 
ee901b9 
  
contrib/views/storm/src/main/resources/scripts/containers/SupervisorSummary.jsx 
e403b86 
  
contrib/views/storm/src/main/resources/scripts/containers/TopologyConfiguration.jsx
 dd2ad64 
  
contrib/views/storm/src/main/resources/scripts/containers/TopologyDetailGraph.jsx
 64fdee1 
  contrib/views/storm/src/main/resources/scripts/containers/TopologyListing.jsx 
9ce19f0 
  contrib/views/storm/src/main/resources/scripts/modules/Table/Pagination.jsx 
41a763c 
  contrib/views/storm/src/main/resources/scripts/router/Router.js 24fc1e0 
  contrib/views/storm/src/main/resources/scripts/views/ComponentDetailView.jsx 
14f7527 
  contrib/views/storm/src/main/resources/scripts/views/ProfilingView.jsx 
eb9d0d1 
  contrib/views/storm/src/main/resources/scripts/views/RebalanceView.jsx 
96f01a6 
  contrib/views/storm/src/main/resources/scripts/views/TopologyDetailView.jsx 
bf66903 

Diff: https://reviews.apache.org/r/47288/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-13 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/
---

(Updated May 13, 2016, 3:56 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-16648
https://issues.apache.org/jira/browse/AMBARI-16648


Repository: ambari


Description
---

Upgrade pack changes to work with Storm 1.0


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a7dbba3 

Diff: https://reviews.apache.org/r/47332/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47153: Storm - When kerberos enabled storm.thrift.transport is being set to wrong config

2016-05-09 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47153/
---

(Updated May 10, 2016, 3:59 a.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-16416
https://issues.apache.org/jira/browse/AMBARI-16416


Repository: ambari


Description
---

Storm - When kerberos enabled storm.thrift.transport is being set to wrong 
config


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
 19d4961 

Diff: https://reviews.apache.org/r/47153/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 46927: AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.

2016-05-04 Thread Sriharsha Chintalapani 


> On May 5, 2016, 12:26 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/pacemaker.py,
> >  line 40
> > <https://reviews.apache.org/r/46927/diff/1/?file=1369609#file1369609line40>
> >
> > Shouldnt return "storm-client"

thats what we do for drpc as well. We can't keep adding storm-drpc , 
storm-nimbus in rpm dirs. Instead we rely on storm-client on everything else


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46927/#review131767
---


On May 5, 2016, 12:32 a.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46927/
> ---
> 
> (Updated May 5, 2016, 12:32 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
>  5a3901a 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py
>  d0b717f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/metainfo.xml 
> a296bfa 
> 
> Diff: https://reviews.apache.org/r/46927/diff/
> 
> 
> Testing
> ---
> 
> Deployed a 3 node cluster and ran sample topologies. Also kerbeorized the 
> cluster.
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Re: Review Request 46927: AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.

2016-05-04 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46927/
---

(Updated May 5, 2016, 12:32 a.m.)


Review request for Ambari, Jaimin Jetly and Sumit Mohanty.


Repository: ambari


Description
---

AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
 5a3901a 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py
 d0b717f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/metainfo.xml 
a296bfa 

Diff: https://reviews.apache.org/r/46927/diff/


Testing
---

Deployed a 3 node cluster and ran sample topologies. Also kerbeorized the 
cluster.


Thanks,

Sriharsha Chintalapani

Re: Review Request 46976: AMBARI-16250: Create STORM service versions in common-services

2016-05-04 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46976/#review131759
---



Lets wait till AMBARI-16210 gets merged in. Since we are shipping 1.0 with 
Ambari 2.4 that needs to be part of this patch as well.

- Sriharsha Chintalapani


On May 4, 2016, 11:21 p.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46976/
> ---
> 
> (Updated May 4, 2016, 11:21 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-16250
> https://issues.apache.org/jira/browse/AMBARI-16250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create common-services/STORM/0.9.1 common-services/SOTRM/0.9.3 and 
> common-services/SOTRM/0.10.0 service versions and update HDP stack 
> inheritance to extend these service definitions
> 
> - Moved common-services/STORM/0.9.1.2.1 -> common-services/STORM/0.9.1
> - Moved stacks/HDP/2.2/services/STORM -> common-services/STORM/0.9.3
> - Moved stacks/HDP/2.3/services/STORM -> common-services/STORM/0.10.0
> - Moved stacks/HDP/2.5/services/STORM -> common-services/STORM/1.0.1
> - Updating service versioning and inheritance hierarchy
> - Only kept hdp-specific config overrides in stacks/HDP and updated 
> corresponding config properties in common-services to default Apache values 
> (example: storm-site/nimbus.childopts)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a94f1e6984af9276c26f302cd0995e20639 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5c8556f7fd121023d68e01f56f14c6ea27a6dc60 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/widgets.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/alerts.json 
> ae03617477f98e1bc84ac80484e106716931f5e9 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml
>  75b080ac59251faa1bb3176eea81383b2d225ec8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
>  01b3f4e85b08031bdbd0ce907861536158ae7ab8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/kerberos.json
>  fcfe524f6293470792404bc9296c85ab5c965c05 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metainfo.xml 
> acb4a57bce5e3196aeab2e0810552ed7c2d7029f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metrics.json 
> 08c2b50f8141fe0b990a6e78d670901dac2f666c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/alerts/check_supervisor_process_win.py
>  a698415f460b65416fd5fbd0a1644bf1c3b22a4d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/files/wordCount.jar
>  aed64beed95e77e708e477c686a672b2163d2260 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
>  b156578781286447214358167c438cc3aaf32015 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
>  b2148a560f99b4a61c8781bd312a315ffc599f34 
>   
> ambari-server/src/main/resou

Review Request 46068: Kafka tools-log4j template missing when upgraded

2016-04-11 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46068/
---

Review request for Ambari, Alejandro Fernandez and Sumit Gupta.


Bugs: AMBARI-15819
https://issues.apache.org/jira/browse/AMBARI-15819


Repository: ambari


Description
---

Kafka tools-log4j template missing when upgraded


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-tools-log4j.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/metainfo.xml 
c2cb8f5 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py
 33275f9 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
 8d483dc 

Diff: https://reviews.apache.org/r/46068/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

2016-04-07 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45835/
---

(Updated April 7, 2016, 5:54 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Repository: ambari


Description
---

AMBARI-15635. Storm & Kafka should've default nproc ,nofile values.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml
 3b910bb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml
 e9f4b28 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
 4b4e776 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm.conf.j2
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45835/diff/


Testing
---

Deployed Storm & Kafka with the above changes and noticed the nofiles and 
noproc values change.


Thanks,

Sriharsha Chintalapani

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

2016-04-06 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45837/
---

(Updated April 7, 2016, 12:41 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Repository: ambari


Description
---

AMBARI-15747. Kafka jaas files are not generated on a Kafa upgrade if 
security.inter.broker.protocol is set to SASL_PLAINTEXT


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
 b18e62d 

Diff: https://reviews.apache.org/r/45837/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

2016-04-06 Thread Sriharsha Chintalapani 


> On April 6, 2016, 10:37 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py,
> >  line 143
> > <https://reviews.apache.org/r/45837/diff/1/?file=1328886#file1328886line143>
> >
> > @Sriharsha
> > 
> > There is a typo here that we missed in the CR. Missing ')'
> > Can you fix it?

Thanks for the catch.


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45837/#review127481
-------


On April 6, 2016, 9:12 p.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45837/
> ---
> 
> (Updated April 6, 2016, 9:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15747. Kafka jaas files are not generated on a Kafa upgrade if 
> security.inter.broker.protocol is set to SASL_PLAINTEXT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
>  b18e62d 
> 
> Diff: https://reviews.apache.org/r/45837/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

2016-04-06 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45835/
---

(Updated April 6, 2016, 9:12 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Repository: ambari


Description
---

AMBARI-15635. Storm & Kafka should've default nproc ,nofile values.


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml
 3b910bb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml
 e9f4b28 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
 4b4e776 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm.conf.j2
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45835/diff/


Testing
---

Deployed Storm & Kafka with the above changes and noticed the nofiles and 
noproc values change.


Thanks,

Sriharsha Chintalapani

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

2016-04-06 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45837/
---

(Updated April 6, 2016, 9:12 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Repository: ambari


Description (updated)
---

AMBARI-15747. Kafka jaas files are not generated on a Kafa upgrade if 
security.inter.broker.protocol is set to SASL_PLAINTEXT


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
 b18e62d 

Diff: https://reviews.apache.org/r/45837/diff/


Testing
---


Thanks,

Sriharsha Chintalapani