Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152451 --- Ship it! Master (1b3b7f5) is green with this patch. ./build-s

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/ --- (Updated Oct. 12, 2016, 9:41 p.m.) Review request for Aurora, George Sirois, Jo

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 10, 2016, 7:44 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java, > > line 40 > > > > > > .setVolumes(volumes) ? > > Zameer Manji wrote:

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152440 --- Ship it! Master (1b3b7f5) is green with this patch. ./build-s

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

> On Oct. 11, 2016, 12:16 p.m., Stephan Erb wrote: > > docs/features/containers.md, line 77 > > > > > > either `/vagrant` or `aurora` but not `/aurora` :-) Fixed. > On Oct. 11, 2016, 12:16 p.m., Stephan Erb wrote:

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

> On Oct. 11, 2016, 2:06 p.m., Zameer Manji wrote: > > 3rdparty/python/requirements.txt, line 25 > > > > > > Can you peel this off to a different commit? > > > > It will make it easier to bisect. Done. > O

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

> On Oct. 11, 2016, 2:30 p.m., Joshua Cohen wrote: > > docs/features/containers.md, line 71 > > > > > > "Starting with the 0.17.0 release, ..." Done. > On Oct. 11, 2016, 2:30 p.m., Joshua Cohen wrote: > > docs/feat

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/ --- (Updated Oct. 12, 2016, 6:52 p.m.) Review request for Aurora, George Sirois, Jo

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

> On Oct. 12, 2016, 8:32 a.m., George Sirois wrote: > > RELEASE-NOTES.md, line 14 > > > > > > s/specufied/specified Fixed. > On Oct. 12, 2016, 8:32 a.m., George Sirois wrote: > > src/main/python/apache/aurora/clien

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 10, 2016, 7:44 p.m., Santhosh Kumar Shanmugham wrote: > > docs/reference/scheduler-configuration.md, line 46 > > > > > > Is there anyother place (or item) where we describe the 'privilege > > escalation thr

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 12:40 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > lines 246-248 > > > > > > I believe this is not true. Mesos is ignoring th

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152429 --- src/main/python/apache/aurora/executor/thermos_task_runner.py (li

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review152428 --- Dmitriy, can you please re-review this? I have no objections, but

Re: Review Request 52806: Revert "Add min_consecutive_health_checks in HealthCheckConfig"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52806/#review152426 --- Ship it! Retroactive ship it. I gave offline confirmation to D

Re: Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52766/#review152423 --- We reverted the related code so I marked this diff as discarded.

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- (Updated Oct. 12, 2016, 4:17 p.m.) Review request for Aurora, Dmitriy Shirchenk

Re: Review Request 52806: Revert "Add min_consecutive_health_checks in HealthCheckConfig"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52806/#review152411 --- Ship it! Ship It! - Kai Huang On Oct. 12, 2016, 9:09 p.m., D

Re: Review Request 52806: Revert "Add min_consecutive_health_checks in HealthCheckConfig"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52806/#review152403 --- Ship it! Master (03eff28) is green with this patch. ./build-s

Re: Review Request 52806: Revert "Add min_consecutive_health_checks in HealthCheckConfig"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52806/#review152402 --- Ship it! Ship It! - Joshua Cohen On Oct. 12, 2016, 9:09 p.m.

Review Request 52806: Revert "Add min_consecutive_health_checks in HealthCheckConfig"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52806/ --- Review request for Aurora, Joshua Cohen, Kai Huang, and Zameer Manji. Bugs: AUR

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

> On Oct. 12, 2016, 7:48 p.m., David McLaughlin wrote: > > Thanks for doing this! > > > > Could you add a test for this? Looking in test_task_runner.py, it looks > > like unfortunately the provider class lacks any sort of coverage. A minimal > > test here could be to just test the path throug

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152386 --- Master (03eff28) is green with this patch. ./build-support/jenki

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152385 --- Thanks for doing this! Could you add a test for this? Looking in

Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: https://issues.

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/ --- (Updated Oct. 12, 2016, 12:42 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/#review152371 --- Ship it! Ship It! - Zameer Manji On Oct. 12, 2016, 1:46 a.m.

Re: Review Request 52790: Upgrade pystachio to 0.8.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152361 --- Ship it! This is now on master. - Zameer Manji On Oct. 12, 2

Re: Review Request 52790: Upgrade pystachio to 0.8.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152354 --- Ship it! Master (e9abb22) is green with this patch. ./build-s

Re: Review Request 52790: Upgrade pystachio to 0.8.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152350 --- Ship it! Ship It! - Joshua Cohen On Oct. 12, 2016, 5:28 p.m.

Re: Review Request 52790: Upgrade pystachio to 0.8.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152349 --- Ship it! Ship It! - John Sirois On Oct. 12, 2016, 11:28 a.m.

Review Request 52790: Upgrade pystachio to 0.8.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/ --- Review request for Aurora, George Sirois, Joshua Cohen, and Zameer Manji. Repos

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/#review152338 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/aop/

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

> On Oct. 11, 2016, 9:30 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/docker/docker_client.py, line 68 > > > > > > Any reason you went with this capitalization? The canonical > > capitalization

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152313 --- RELEASE-NOTES.md (line 14)

Re: Review Request 52777: Use Gradle installDist task rather than installApp.

> On Oct. 12, 2016, 4:41 a.m., John Sirois wrote: > > Your testing done says this is enough on the aurora-packaging side, but on > > the [aurora > > side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the > > installed plugin probably also needs to be changed from from 'applic

Re: Review Request 52777: Use Gradle installDist task rather than installApp.

> On Oct. 12, 2016, 12:41 p.m., John Sirois wrote: > > Your testing done says this is enough on the aurora-packaging side, but on > > the [aurora > > side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the > > installed plugin probably also needs to be changed from from 'appli

Re: Review Request 52777: Use Gradle installDist task rather than installApp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/#review152291 --- Ship it! Your testing done says this is enough on the aurora-pa

Review Request 52777: Use Gradle installDist task rather than installApp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/ --- Review request for Aurora and John Sirois. Repository: aurora-packaging Descr

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/#review152285 --- Master (e9abb22) is green with this patch. ./build-support/jenki

Review Request 52776: Blank out executor config in startJobUpdate log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --