Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

ure returned offer comes back Making sure offer is unreserved Thanks, Dmitriy Shirchenko

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

://reviews.apache.org/r/57487/diff/6-7/ Testing --- Tested on local vagrant for following scenarios: Reserving a task Making sure returned offer comes back Making sure offer is unreserved Thanks, Dmitriy Shirchenko

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

/57487/diff/6/ Changes: https://reviews.apache.org/r/57487/diff/5-6/ Testing --- Tested on local vagrant for following scenarios: Reserving a task Making sure returned offer comes back Making sure offer is unreserved Thanks, Dmitriy Shirchenko

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

sure offer is unreserved Thanks, Dmitriy Shirchenko

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

ly expired if offer is unused. To collect them, we can bring back the `OfferReconciler` if the complexity warrants it. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57487/#review170659 --

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

scenarios: Reserving a task Making sure returned offer comes back Making sure offer is unreserved Thanks, Dmitriy Shirchenko

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

scenarios: Reserving a task Making sure returned offer comes back Making sure offer is unreserved Thanks, Dmitriy Shirchenko

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

://reviews.apache.org/r/57487/diff/1-2/ Testing --- Tested on local vagrant for following scenarios: Reserving a task Making sure returned offer comes back Making sure offer is unreserved Thanks, Dmitriy Shirchenko

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777 Diff: https://reviews.apache.org/r/57487/diff/1/ Testing --- Tested on local vagrant for following scenarios: Reserving a task Making sure returned offer comes back Making sure offer is unreserved Thanks, Dmitriy Shirchenko

Review Request 57487: merge

--- Tested on local vagrant for following scenarios: Reserving a task Making sure returned offer comes back Making sure offer is unreserved Thanks, Dmitriy Shirchenko

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

://reviews.apache.org/r/56690/diff/5/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

e04f6113c43eca4555ee0719f8208d7c4ebb8d61 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777 Diff: https://reviews.apache.org/r/56690/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

49d4e82cc03144b80292fe43066a6cc4d7aed88f src/test/java/org/apache/aurora/scheduler/offers/OfferReconcilerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56691/diff/ Testing (updated) --- Tested locally and a devel cluster. Thanks, Dmitriy Shirchenko

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

/ Testing --- Ran locally on vagrant. Thanks, Dmitriy Shirchenko

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

he `offerAdded` event handler handle the exception instead of > > letting it go up to the `EventBus`? We could log an errror and increment an > > metric. Done. - Dmitriy --- This is an automatically generated e-ma

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777 Diff: https://reviews.apache.org/r/56690/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

to become private. Done. > On Feb. 24, 2017, 9 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/TierManager.java, line 105 > > <https://reviews.apache.org/r/56690/diff/3/?file=1646597#file1646597line105> > > > > In line with my comment

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

/resources/ResourceTestUtil.java e04f6113c43eca4555ee0719f8208d7c4ebb8d61 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java cf2d25ec2e407df7159e0021ddb44adf937e1777 Diff: https://reviews.apache.org/r/56690/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

> > might come with a performance tax. > > > > `getTier` is on a hot code path and I therefore recently rewrote the > > `checkArgument` here to only construct the String if the argument is > > invalid. This yielded a significant perf improvemen

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166450 --- @ReviewBot retry - Dmitriy Shirchenko On Feb. 22, 2017, 10:35

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166434 --- @ReviewBot retry - Dmitriy Shirchenko On Feb. 22, 2017, 10:35

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f src/test/java/org/apache/aurora/scheduler/offers/OfferReconcilerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56691/diff/ Testing --- Ran locally on vagrant. Thanks, Dmitriy Shirchenko

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f src/test/java/org/apache/aurora/scheduler/offers/OfferReconcilerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56691/diff/ Testing --- Ran locally on vagrant. Thanks, Dmitriy Shirchenko

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

/OfferManagerImplTest.java 49d4e82cc03144b80292fe43066a6cc4d7aed88f src/test/java/org/apache/aurora/scheduler/offers/OfferReconcilerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56691/diff/ Testing --- Ran locally on vagrant. Thanks, Dmitriy Shirchenko

Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

5e570b6341c55be8ef27469077932d1ea8378b55 src/test/java/org/apache/aurora/scheduler/offers/OfferReconcilerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56691/diff/ Testing --- Ran locally on vagrant. Thanks, Dmitriy Shirchenko

Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

7dc8c179736fab93ca03e174b16e104ba0118127 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java f8bb25b612ae42748205901dd4b8cfcdedf5b136 Diff: https://reviews.apache.org/r/56690/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163004 --- @ReviewBot retry - Dmitriy Shirchenko On Jan. 25, 2017, 6:47

Re: Review Request 55902: Capture health check output

attached. File Attachments Updated screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png Thanks, Dmitriy Shirchenko

Re: Review Request 55902: Capture health check output

attached. File Attachments Updated screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png Thanks, Dmitriy Shirchenko

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162894 --- @ReviewBot retry - Dmitriy Shirchenko On Jan. 25, 2017, 1:34

Re: Review Request 55902: Capture health check output

unit tests e2e tests screenshot attached. File Attachments (updated) Updated screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png Thanks, Dmitriy Shirchenko

Re: Review Request 55902: Capture health check output

-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png Thanks, Dmitriy Shirchenko

Review Request 55902: Capture health check output

Screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/c4e69424-71ad-4d71-b1f4-895bc6a7821e__Screen_Shot_2017-01-24_at_5.03.06_PM.png Thanks, Dmitriy Shirchenko

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

e rest of the code base. - Dmitriy Shirchenko On Dec. 30, 2016, 9:18 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review154818 --- Ship it! Ship It! - Dmitriy Shirchenko On Oct. 12, 2016, 11

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review151091 --- Ship it! Ship It! - Dmitriy Shirchenko On Sept. 30, 2016, 7

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

tps://reviews.apache.org/r/52437/#comment219178> For my own curiousity: is the step of adding gpg keys strictly necessary? Why does ubuntu need it but not debian? - Dmitriy Shirchenko On Sept. 30, 2016, 7:23 p.m., Renan DelValle

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

: https://reviews.apache.org/r/52276/diff/ Testing --- Verified in vagrant + added unit tests. Thanks, Dmitriy Shirchenko

Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

--- Verified in vagrant + added unit tests. Thanks, Dmitriy Shirchenko

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

t; also needs to be documented. - Dmitriy Shirchenko On Sept. 20, 2016, 7:43 p.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 52074: switching from launchTask to acceptOffers

a739bce1226d9435fa7d0b18e411064a4e78e49e Diff: https://reviews.apache.org/r/52074/diff/ Testing --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Dmitriy Shirchenko

Re: Review Request 52074: switching from launchTask to acceptOffers

a739bce1226d9435fa7d0b18e411064a4e78e49e Diff: https://reviews.apache.org/r/52074/diff/ Testing --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Dmitriy Shirchenko

Re: Review Request 52074: switching from launchTask to acceptOffers

a739bce1226d9435fa7d0b18e411064a4e78e49e Diff: https://reviews.apache.org/r/52074/diff/ Testing --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Dmitriy Shirchenko

Re: Review Request 52074: switching from launchTask to acceptOffers

/OfferManagerImplTest.java (lines 50 - 54) <https://reviews.apache.org/r/52074/#comment217606> Agreed. I have been told that Aurora's philosophy is convention first, so I'm following what has been set. - Dmitriy Shirchenko On Sept. 20, 2016, 7:14 p.m., Dmitriy Shirchenko

Re: Review Request 52074: switching from launchTask to acceptOffers

n first, so I'm following what has been set. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149714 -----------

Re: Review Request 52074: switching from launchTask to acceptOffers

24> > > > > nit: add newline above Done. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149862 --------

Re: Review Request 52074: switching from launchTask to acceptOffers

a739bce1226d9435fa7d0b18e411064a4e78e49e Diff: https://reviews.apache.org/r/52074/diff/ Testing --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Dmitriy Shirchenko

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52087/#review149707 --- Ship it! Ship It! - Dmitriy Shirchenko On Sept. 20, 2016, 6

Re: Review Request 52074: switching from launchTask to acceptOffers

a739bce1226d9435fa7d0b18e411064a4e78e49e Diff: https://reviews.apache.org/r/52074/diff/ Testing --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Dmitriy Shirchenko

Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.

s_leader_redirect = True? - Dmitriy Shirchenko On Sept. 20, 2016, 5:32 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 52074: switching from launchTask to acceptOffers

925c025d21bf1d44e0c1d319f6653ecfa8899481 src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java a739bce1226d9435fa7d0b18e411064a4e78e49e Diff: https://reviews.apache.org/r/52074/diff/ Testing --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Dmitriy Shirchenko

Re: Review Request 51980: Refactor of Webhook and no longer posting entire task state via webhook on scheduler restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51980/#review149530 --- @ReviewBot retry - Dmitriy Shirchenko On Sept. 19, 2016, 6:28

Re: Review Request 52049: Clarifying documentation for new contributors by adding a step for them to ask for their JIRA id to get whitelisted

/ Testing --- Thanks, Dmitriy Shirchenko

Review Request 52049: Clarifying documentation for new contributors by adding a step for them to ask for their JIRA id to get whitelisted

. Repository: aurora Description --- Due to spam bots, JIRA accounts need to be whitelisted before they can self-assign tasks. Diffs - CONTRIBUTING.md 13ebbe4be281f869d276ebe97bfae75123899cfb Diff: https://reviews.apache.org/r/52049/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 51980: Refactor of Webhook and no longer posting entire task state via webhook on scheduler restart

is to allow easier testing so cleaner unit tests were added with more code coverage. Thanks, Dmitriy Shirchenko

Re: Review Request 51980: Refactor of Webhook and no longer posting entire task state via webhook on scheduler restart

testing so cleaner unit tests were added with more code coverage. Thanks, Dmitriy Shirchenko

Re: Review Request 50826: Populate the source field of ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50826/#review144853 --- Ship it! plz add a test and then LGTM - Dmitriy Shirchenko

Re: Review Request 50685: Support TBinaryProtocol over HTTP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144653 --- Ship it! Ship It! - Dmitriy Shirchenko On Aug. 3, 2016, 12

Re: Review Request 50478: Improve `executorLost` error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50478/#review143764 --- Ship it! Ship It! - Dmitriy Shirchenko On July 27, 2016, 1

Re: Review Request 50052: AURORA-1736 Display reservations and persistent volumes in /offers debug http endpoint

ke one of them is not necessary. ```json reservation: { labels: { labels: [ { key: "job", value: "devcluster/www-data/prod/hello" } ] } } ``` - Dmitriy Shirchenko On July 19, 2016, 2:12 a.m.,

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

to the docs, `getErrorStream` _may_ return `null`, so we need > > a guard here. > > https://docs.oracle.com/javase/7/docs/api/java/net/HttpURLConnection.html#getErrorStream() Good call. Done. - Dmitriy --- This is an automatical

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

/WebhookModule.java PRE-CREATION src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

/WebhookModule.java PRE-CREATION src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

he.org/r/47440/#review135233 --- On June 3, 2016, 10:17 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

, lines 73-74 > > <https://reviews.apache.org/r/47440/diff/8/?file=1395852#file1395852line73> > > > > -4 spaces Done. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https:

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

PRE-CREATION src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

PRE-CREATION src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

;https://reviews.apache.org/r/47440/#comment199788> Done. src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java (line 75) <https://reviews.apache.org/r/47440/#comment199789> Done, - Dmitriy Shirchenko On May 25, 2016,

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

gt; > > > > Would it make sense to move this into WebhookInfo instead? Done. - Dmitriy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review134392 -----

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

's not mixed in with the code. src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java (line 73) <https://reviews.apache.org/r/47440/#comment199485> Done. - Dmitriy Shirchenko On May 22, 2016, 1:29 p.m., Dmitriy Shirchenko w

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

here to a deprecation cycle. It might therefore make > > sense to establish an explicit schema. Good point. Essentially these are IScheduledTask objects which I believe already require a deprecation cycle. Is this correct? - Dmitriy --------

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 30 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line30> > > > > Missing javadoc for class and public methods. Done. > On May 17, 2016, 5:09 p.m., Maxim Khu

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

nother thread or added to a queue for > > future delivery? AFAICT the distribution of events is synchronous, so it > > seems like operations that might block for any significant amount of time > > could cause issues. > > Dmitriy Shirchenko wrote: > Yea, I'm not sure. Do you have

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

/org/apache/aurora/scheduler/webhook.json PRE-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

ically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133482 ------- On May 17, 2016, 2:10 a.m., Dmitriy Shirchenko wrote: > > --- &g

Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

-CREATION src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47440/diff/ Testing --- Need to fix tests. Thanks, Dmitriy Shirchenko

Review Request 46361: deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.

: https://reviews.apache.org/r/46361/diff/ Testing --- Thanks, Dmitriy Shirchenko

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

/health_checker.py d8675beb8f16ebdd2d6946367784411fe84a5cfc src/test/python/apache/aurora/executor/common/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy

Re: Review Request 46290: adding --setuid-health-checks to not demote health check user:group to role

ws.apache.org/r/46290/#review129401 --- On April 18, 2016, 6:34 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 46290: adding --setuid-health-checks to not demote health check user:group to role

4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding --setuid-health-checks to not demote health check user:group to role

d8675beb8f16ebdd2d6946367784411fe84a5cfc src/test/python/apache/aurora/executor/common/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

/test_health_checker.py 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

Diff: https://reviews.apache.org/r/46290/diff/ Testing --- - end to end tests - added unit tests Thanks, Dmitriy Shirchenko

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126443 --- Ship it! Ship It! - Dmitriy Shirchenko On March 31, 2016, 8

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 4:20 p.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 66 > > <https://reviews.apache.org/r/45506/diff/2/?file=1320188#file1320188line66> > > > > why are you doing a sepa

Re: Review Request 45506: Execute shell-based health checks as the task user.

On March 31, 2016, 6:38 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45506/ > ------

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 4:20 p.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 60 > > <https://reviews.apache.org/r/45506/diff/2/?file=1320188#file1320188line60> > > > > why did you get rid of .format?

Re: Review Request 45506: Execute shell-based health checks as the task user.

n, my bad. thanks for catching this! - Dmitriy Shirchenko On March 30, 2016, 11:41 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 44827: Do not split the shell command string passed into shell health check script

Diff: https://reviews.apache.org/r/44827/diff/ Testing --- Unit tests + end_to_end test. Thanks, Dmitriy Shirchenko

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing --- Unit and end to end test. Thanks, Dmitriy Shirchenko

  1   2   >