Re: Review Request 39532: Always set SessionKey to empty in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103618 --- @reviewbot retry - Kevin Sweeney On Oct. 22, 2015, 10:36 a.m

Re: Review Request 39532: Always set SessionKey to empty in the client.

/:: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney

Re: Review Request 39532: Always set SessionKey to empty in the client.

mply be dropped on the floor. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39532/#review103612 --- On Oct. 22

Re: Review Request 39563: Ignore serverInfo on the client side.

there are no compatibility guarantees whatsoever. IMO `ServerInfo` should be much more like HTTP's `Server` header - additional information the server can provide about itself. - Kevin Sweeney On Oct. 22, 2015, 2:35 p.m., Kevin Sweeney wrote

Re: Review Request 39563: Ignore serverInfo on the client side.

> On Oct. 22, 2015, 2:41 p.m., Kevin Sweeney wrote: > > Elaborating - as far as I can see it the only sensible implementation of > > this feature would be for the client to set the version in the *request* > > and for the scheduler to check it and decide whether it support

Re: Review Request 39563: Ignore serverInfo on the client side.

://reviews.apache.org/r/39563/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 39563: Ignore serverInfo on the client side.

/test_scheduler_client.py 60d222f49e594fd7e5363da445fc57ddf8dc4aba Diff: https://reviews.apache.org/r/39563/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 39563: Ignore serverInfo on the client side.

Diff: https://reviews.apache.org/r/39563/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 39525: Ignore all SessionKeys.

eTest.java b940e82644365fae613d577ba5b8779077f115d4 src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java 1bb3eae224de287d0ed83534f1c933ddd72298bb Diff: https://reviews.apache.org/r/39525/diff/ Testing --- ./graldew -Pq clean build Thanks, Kevin Sweeney

Review Request 39532: Always set SessionKey to empty in the client.

/39532/diff/ Testing --- ./pants test.pytest --no-fast src/test/python/:: Awaiting e2e test results. Thanks, Kevin Sweeney

Re: Review Request 39532: Always set SessionKey to empty in the client.

/test_updater.py 87935553d37db8f0a1d03d3c370cf717b5277d74 Diff: https://reviews.apache.org/r/39532/diff/ Testing --- ./pants test.pytest --no-fast src/test/python/:: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney

Re: Review Request 39057: "aurora config read" command

) <https://reviews.apache.org/r/39057/#comment159944> Missing error handling - what if this is an invalid config / path? - Kevin Sweeney On Oct. 6, 2015, 11:43 a.m., Brian Wickman wrote: > > --- > This is an automatica

Re: Review Request 37851: Use "Mesos Agent" instead of "Mesos Slave" in docs.

c docs/vagrant.md 3bc201f17977dbc402eeac307500db5cc9d6bb27 Diff: https://reviews.apache.org/r/37851/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

) <https://reviews.apache.org/r/39150/#comment159598> Please rename this to deprecatedInstanceIds. - Kevin Sweeney On Oct. 8, 2015, 6:32 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

> On Oct. 9, 2015, 10:12 a.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 351 > > <https://reviews.apache.org/r/39150/diff/2/?file=1093460#file1093460line351> > > > > Please rename this to deprecatedInstanceIds. >

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

tring should be an invalid cron schedule here - can you use `isSetCronSchedule` here instead? - Kevin Sweeney On Oct. 9, 2015, 5:41 a.m., Brice Arnould wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 38906: Use Shiro to generate audit messages when available.

/SchedulerThriftInterfaceTest.java ac89618332926d5a25fe7ab7da3b270b4d42c723 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 4bd8b12996cbfc7d75a994033551374b32909511 Diff: https://reviews.apache.org/r/38906/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 38332: Convert all of our servlet implementations to jax-rs endpoints.

views.apache.org/r/38332/#comment155542> This feels like a DRY violation to me - consider adding `public static final String PATH = "/api"` etc to each resource and referencing them in both the `@Path` annotation and here. - Kevin Sweene

Re: Review Request 38086: Add test environments for RPMs and debs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38086/#review98272 --- Ship it! LGTM once comments are addressed - Kevin Sweeney

Re: Review Request 38014: Remove StartupRegistry.

Consider subclassing AbstractScheduledService instead - Kevin Sweeney On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98111 --- Ship it! Ship It! - Kevin Sweeney On Sept. 8, 2015, 3:47 p.m

Re: Review Request 38111: Disable mimetype guessing in the observer chroot browser.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38111/#review97762 --- Ship it! Ship It! - Kevin Sweeney On Sept. 3, 2015, 3:15 p.m

Re: Review Request 38111: Disable mimetype guessing in the observer chroot browser.

in the unmodified file with `content-encoding: application/gzip`. See this stackoverflow post: [1] [1] http://stackoverflow.com/questions/11641923/transfer-encoding-gzip-vs-content-encoding-gzip - Kevin Sweeney On Sept. 3, 2015, 3:15 p.m., Zameer Manji wrote

Review Request 38080: Remove openjdk runtime requirement.

' jvm_prop_java_vendor Oracle Corporation [vagrant@localhost ~]$ ``` Thanks, Kevin Sweeney

Review Request 38084: Builder should run createrepo

Description --- Builder should run createrepo Diffs - builder/rpm/centos-7/build.sh 912f7c788be648f8f3a11ec868a56d2994c62117 Diff: https://reviews.apache.org/r/38084/diff/ Testing --- Tested on 0.9.x branch Thanks, Kevin Sweeney

Re: Review Request 38080: Remove openjdk runtime requirement.

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/38080/#review97573 --- On Sept. 2, 2015, 4:36 p.m., Kevin Sweeney wrote: > > --- > This is an automaticall

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote: > > examples/vagrant/executors-config.json, lines 4-7 > > > > > > The code later converts this array into a single command string. I > > suggest we just make this a

Re: Review Request 38014: Remove StartupRegistry.

usage. src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java <https://reviews.apache.org/r/38014/#comment153172> Is this shutdown timeout preserved anywhere? Seems this should move to a `Listener` on the below providers. - Kevin Sweeney On Sept. 1, 2015, 11:5

Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

and /agents in vagrant. Thanks, Kevin Sweeney

Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37847/#review96710 --- On Aug. 27, 2015, 10:37 a.m., Kevin Sweeney wrote

Re: Review Request 37847: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

d0bd897524a4c763d11a601898b663fec672e979 src/main/resources/scheduler/assets/js/filters.js bf6aef86fd50ba38b64f5d9f481d6915c38881f7 Diff: https://reviews.apache.org/r/37847/diff/ Testing --- Tested /slaves and /agents in vagrant. Thanks, Kevin Sweeney

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

On Aug. 26, 2015, 3:27 p.m., Kevin Sweeney wrote: examples/vagrant/executors-config-new.json, line 18 https://reviews.apache.org/r/37818/diff/1/?file=1055421#file1055421line18 this isn't a global property - can it be pushed into a custom configuration object? Renan DelValle

Re: Review Request 37825: Adding minimal implementation of the external tier config.

On Aug. 27, 2015, 10:23 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 70 https://reviews.apache.org/r/37825/diff/1/?file=100#file100line70 +@CanRead That will cause loading to fail when the argument is null. - Kevin

Review Request 37851: Use Mesos Agent instead of Mesos Slave in docs.

--- Thanks, Kevin Sweeney

Review Request 37855: Rename slave to agent in scheduler src/main/java.

/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 4d4e752088f7dca99675cc66782ae046bbd516d6 Diff: https://reviews.apache.org/r/37855/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Review Request 37859: Rename slave to agent in src/main/python.

/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 37860: Rpm: fix install dep on daemonize, be permissive with newer mesos versions.

linker issue. If a user is convinced that we're wrong here they can always override with `--nodeps`. - Kevin Sweeney On Aug. 27, 2015, 3:50 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 37861: Add a convenience to build all artifacts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37861/#review96786 --- Ship it! Ship It! - Kevin Sweeney On Aug. 27, 2015, 4:05 p.m

Re: Review Request 37861: Add a convenience to build all artifacts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37861/#review96785 --- Ship it! Ship It! - Kevin Sweeney On Aug. 27, 2015, 4:05 p.m

Re: Review Request 37862: Rpm: remove daemonize dep for rhel =7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37862/#review96787 --- Ship it! Ship It! - Kevin Sweeney On Aug. 27, 2015, 4:08 p.m

Re: Review Request 37788: Deb: Clean up changelog generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37788/#review96555 --- Ship it! Ship It! - Kevin Sweeney On Aug. 26, 2015, 10:01 a.m

Re: Review Request 37789: Refer to shared task_configs table for job updates.

/storage/db/DbJobUpdateStore.java (line 160) https://reviews.apache.org/r/37789/#comment152067 Inline this method reference. - Kevin Sweeney On Aug. 25, 2015, 11:41 p.m., Bill Farner wrote: --- This is an automatically generated e-mail

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

/#comment152191 delete this file? It looks like it has been superceded by the new format below src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java (line 114) https://reviews.apache.org/r/37818/#comment152196 drop redundant use of `this`, here and below. - Kevin

Re: Review Request 37772: Fix RPM building.

/37772/#comment151814 This is weird as a user will never be able to upgrade from a release version to a nightly. - Kevin Sweeney On Aug. 25, 2015, 2:13 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 37731: Parameterize artifact version in builders.

/37731/#comment151543 For the RPM spec consider making this argument an explicit command-line flag (with `--define`) rather than an environment variable. - Kevin Sweeney On Aug. 24, 2015, 3:02 p.m., Bill Farner wrote

Re: Review Request 37727: Deb: Remove defunct default argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37727/#review96197 --- Ship it! Ship It! - Kevin Sweeney On Aug. 24, 2015, 1:10 p.m

Re: Review Request 37666: Import of Twitter Commons.

/37666/#comment151583 kill newline - Kevin Sweeney On Aug. 24, 2015, 4:54 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666

Re: Review Request 37731: Parameterize artifact version in builders.

On Aug. 24, 2015, 3:07 p.m., Kevin Sweeney wrote: build-artifact.sh, line 30 https://reviews.apache.org/r/37731/diff/1/?file=1048757#file1048757line30 For the RPM spec consider making this argument an explicit command-line flag (with `--define`) rather than an environment

Re: Review Request 37743: Replace realpath to get build working on jenkins.

- Kevin Sweeney On Aug. 24, 2015, 7:27 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37743/ --- (Updated Aug

Re: Review Request 37666: Import of Twitter Commons.

Missing license header. Consider tooling to automated adding the standard apache one and removing the twitter one. commons-args/src/main/java/com/twitter/common/args/VerifierFor.java (line 1) https://reviews.apache.org/r/37666/#comment151242 Missing license header - Kevin Sweeney On Aug. 20

Re: Review Request 36289: Custom executor support for Scheduler

of a config change. I think you need to add logic to make sure that every task has an executor that's acceptible to the system at startup. - Kevin Sweeney On Aug. 17, 2015, 11:10 p.m., Renan DelValle wrote: --- This is an automatically

Re: Review Request 37379: Updating to Mesos 0.23.0.

On Aug. 13, 2015, 4:53 p.m., Kevin Sweeney wrote: build-support/python/make-mesos-native-egg, line 119 https://reviews.apache.org/r/37379/diff/1/?file=1038066#file1038066line119 HTTPS? Maxim Khutornenko wrote: No htts endpoint exists. This hangs forever

Re: Review Request 37379: Updating to Mesos 0.23.0.

reference a blob-link just reference docs/getting-started.md - the NEWS file is in the same repo. - Kevin Sweeney On Aug. 17, 2015, 11:37 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 37379: Updating to Mesos 0.23.0.

On Aug. 13, 2015, 4:53 p.m., Kevin Sweeney wrote: src/test/sh/org/apache/aurora/e2e/Dockerfile, line 18 https://reviews.apache.org/r/37379/diff/1/?file=1038072#file1038072line18 Is this documented upstream or just because we use libcurl4-nss-dev in the egg builder script? Either

Re: Review Request 37379: Updating to Mesos 0.23.0.

upstream or just because we use libcurl4-nss-dev in the egg builder script? Either way you can install just libcurl4-nss rather than the -dev version of the package. - Kevin Sweeney On Aug. 11, 2015, 9:58 p.m., Maxim Khutornenko wrote

Re: Review Request 37447: Making scheduler loop continue after mismatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37447/#review95332 --- Ship it! Ship It! - Kevin Sweeney On Aug. 13, 2015, 2:25 p.m

Re: Review Request 36972: One python_library per exported setup.py project

?) should contain aurora executor, thermos cli, thermos observer and thermos runner. Kevin Sweeney wrote: I like this suggestion and would like to refactor the code to fit it into this framework. Would you accept that in a follow-up review? Specifically there would then be 3 top

Re: Review Request 36972: One python_library per exported setup.py project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93731 --- On July 31, 2015, 11:03 a.m., Kevin Sweeney wrote

Re: Review Request 36972: One python_library per exported setup.py project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93722 --- On July 31, 2015, 10:56 a.m., Kevin Sweeney wrote

Re: Review Request 36972: One python_library per exported setup.py project

environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

--- On July 31, 2015, 10:56 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972

Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

/test_kerberos_end_to_end.sh 760997c8420e9e430912de406cef494a9118897a Diff: https://reviews.apache.org/r/36998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

/ as appropriate. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93793 --- On July 31, 2015, 3:30 p.m., Kevin Sweeney wrote

Re: Review Request 36972: One python_library per exported setup.py project

status` works. I don't have a test environment for the debian package or the spec file. Documentation pushed to https://github.com/kevints/aurora/blob/36972/docs/build-system.md Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93805 --- On July 31, 2015, 4:18 p.m., Kevin Sweeney wrote

Re: Review Request 36972: One python_library per exported setup.py project

. Documentation pushed to https://github.com/kevints/aurora/blob/36972/docs/build-system.md Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

--no-fast src/test/python:: ./build-support/python/make-python-sdists ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Manually checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

that `thermos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Review Request 36972: One python_library per exported setup.py project

Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

) --- ./pants test.pytest --no-fast src/test/python:: ./build-support/python/make-python-sdists E2E test gets as far as it usually does. Manually checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36945: Use the correct (aurora-specific) python build targets in RPM and deb scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36945/#review93615 --- Ship it! Ship It! - Kevin Sweeney On July 30, 2015, 9:13 a.m

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

. They're only useful for when you install the sdists via pip or pex directly. Instead we always build pex binaries using pants which delegates to the python_binary target. Kevin Sweeney wrote: I answered someone's question in IRC with a gist ~2yrs ago https://gist.github.com/kevints

Re: Review Request 36700: Remove references to binary build targets that are not currently for general consumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review93209 --- Ship it! Ship It! - Kevin Sweeney On July 27, 2015, 5:58 p.m

Review Request 36874: Fix typo in the scheduler deployment documentation

Description --- Fix typo in scheduler deployment documentation The command should be run on schedulers, not masters. Diffs - docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d Diff: https://reviews.apache.org/r/36874/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

binaries using pants which delegates to the python_binary target. Kevin Sweeney wrote: I answered someone's question in IRC with a gist ~2yrs ago https://gist.github.com/kevints/8361414 so it does seem likely these are used in practice. Okay with removing them but a NEWS entry would

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review92997 --- @ReviewBot retry - Kevin Sweeney On July 24, 2015, 2:38 p.m

Re: Review Request 36711: Remove all public static com.google.common.base.Functions

/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 0d0ee9499476d84e5e6f937f8ce7320185b02a7a Diff: https://reviews.apache.org/r/36711/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

://reviews.apache.org/r/36700/#comment146861 Can you delete the code these targets reference as well, as presumably there are now source files without BUILD file owners in our tree - Kevin Sweeney On July 22, 2015, 11:50 a.m., Bill Farner wrote

Review Request 36709: Remove generated FROM_BUILDER and TO_BUILDER methods.

/thrift_wrapper_codegen.py f3d92884dc1d35d576bbe84f70be6e46278444ed src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java 05b31c2f75da9df53ab66007a1e907900ed90cd0 Diff: https://reviews.apache.org/r/36709/diff/ Testing --- ./gradlew -Pq clean build Thanks, Kevin

Re: Review Request 36703: Replace Guava Joiner with String::join where simpler

://reviews.apache.org/r/36703/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 36709: Remove generated FROM_BUILDER and TO_BUILDER methods.

/36709/diff/ Testing --- ./gradlew -Pq clean build Thanks, Kevin Sweeney

Re: Review Request 36561: Use the application-level storage lock to prevent DB-level deadlock when GCing rows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36561/#review91995 --- Ship it! Ship It! - Kevin Sweeney On July 16, 2015, 4:59 p.m

Re: Review Request 36490: Use ProviderOptionalSubject instead of optional injection for Shiro audit logging.

generated e-mail. To reply, visit: https://reviews.apache.org/r/36490/#review91745 --- On July 14, 2015, 4:48 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail

Re: Review Request 36490: Use ProviderOptionalSubject instead of optional injection for Shiro audit logging.

src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 36490: Use ProviderOptionalSubject instead of optional injection for Shiro audit logging.

63917363f392e6d970fb7e0cb91b840ca5db173e src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 36289: Custom executor support for Scheduler

On July 15, 2015, 12:08 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, lines 87-115 https://reviews.apache.org/r/36289/diff/2/?file=1011920#file1011920line87 In this change, we cannot remove these arguments as it breaks

Review Request 36526: Use HTTPS for Twitter Maven repository.

--- Use HTTPS for Twitter Maven repository. Diffs - build.gradle 87a809f0fd0ee63cae84cc0269dfa5431b7e893f Diff: https://reviews.apache.org/r/36526/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew assemble Thanks, Kevin Sweeney

Re: Review Request 36490: Use ProviderOptionalSubject instead of optional injection for Shiro audit logging.

/aurora/auth/UnsecureSessionContextTest.java 63917363f392e6d970fb7e0cb91b840ca5db173e src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Review Request 36490: wip

6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 36490: Use ProviderOptionalSubject instead of optional injection for Shiro audit logging.

src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

to use slaveID instead of hostName as the canonical identifier for mesos slaves within aurora? - Kevin Sweeney On July 1, 2015, 1:01 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36220: Change docs to use a working git repo URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36220/#review90580 --- Ship it! Ship It! - Kevin Sweeney On July 6, 2015, 2:37 p.m

Re: Review Request 36064: Perform leader redirect using HTTP status code 307

/LeaderRedirectFilter.java (line 46) https://reviews.apache.org/r/36064/#comment143178 Use the `HttpHeaders.LOCATION` constant here instead. - Kevin Sweeney On June 30, 2015, 1:44 p.m., Stephan Erb wrote: --- This is an automatically

Review Request 36015: Fix terminology in cron docs.

--- Fix terminology in cron docs. Diffs - docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 Diff: https://reviews.apache.org/r/36015/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 35932: Remove unnecessary uses of type witness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35932/#review89531 --- Ship it! Ship It! - Kevin Sweeney On June 26, 2015, 10:50 a.m

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89257 --- On June 24, 2015, 2:52 p.m., Kevin Sweeney wrote

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

/GuavaCollectorsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/35842/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965 Diff: https://reviews.apache.org/r/35842/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

  1   2   >