---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63443/#review189886
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 31, 2017, 9:17 a.m
to be a clever
way of fixing this problem and far better than my previous approach.
- Zameer Manji
On Aug. 21, 2017, 5:38 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
support this
idea however, it is probably far better than the `/proc` approach we have today.
- Zameer Manji
On July 11, 2017, 1:12 p.m., Reza Motamedi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
t this change until we root cause it.
>
> Zameer Manji wrote:
> This change caused less lost tasks when deployed to production for me.
> Have you isolated it 100% to this change? What do you see for the
> `offer_cancel_failures` metric?
>
> David McLaughlin wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60437/#review178910
---
Ship it!
Ship It!
- Zameer Manji
On June 26, 2017, 10:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60350/#review178606
---
Ship it!
Ship It!
- Zameer Manji
On June 21, 2017, 5:16 p.m
method
instead of duplicating it here.
- Zameer Manji
On June 21, 2017, 2:37 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60264/#review178498
---
Ship it!
Ship It!
- Zameer Manji
On June 20, 2017, 11:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60133/#review178057
---
Ship it!
Ship It!
- Zameer Manji
On June 15, 2017, 3:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177521
---
@ReviewBot retry
- Zameer Manji
On June 9, 2017, 3:14 p.m
/diff/2/
Changes: https://reviews.apache.org/r/59957/diff/1-2/
Testing
---
Thanks,
Zameer Manji
/thrift/SchedulerThriftInterface.java
059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
016859ca3bf83f64d2576b4c7109729770f9e25c
Diff: https://reviews.apache.org/r/59957/diff/1/
Testing
---
Thanks,
Zameer Manji
97febf25cea2024e0ca43366b3d4578e67734884
Diff: https://reviews.apache.org/r/59853/diff/1/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59733/#review177092
---
Ship it!
Ship It!
- Zameer Manji
On June 6, 2017, 1:02 p.m
97febf25cea2024e0ca43366b3d4578e67734884
Diff: https://reviews.apache.org/r/59853/diff/1/
Testing
---
Thanks,
Zameer Manji
/1/
Testing
---
Thanks,
Zameer Manji
> On June 2, 2017, 10:28 a.m., Zameer Manji wrote:
> > I don't have comment access on the doc, so I will leave my questions here:
> >
> > 1. Should operators (via executor flags) be able to cap this value? That is
> > should `STOP_TIMEOUT` be an operator flag?
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59699/#review176827
---
Ship it!
Ship It!
- Zameer Manji
On June 1, 2017, 5:01 p.m
, as it just retries kills. If a user puts a large value here, I'm not
sure tasks will actually termiante. Please add an e2e test here to confirm/deny.
- Zameer Manji
On June 1, 2017, 4:48 p.m., Jordan Ly wrote
tps://reviews.apache.org/r/59703/#comment249996>
I don't see the code use netty, so why do we need this?
- Zameer Manji
On May 31, 2017, 11:33 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e
this diff due to time constraints.
- Zameer Manji
On May 30, 2017, 2:21 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59565/#review176102
---
Ship it!
Ship It!
- Zameer Manji
On May 24, 2017, 7:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59539/#review176005
---
Ship it!
Ship It!
- Zameer Manji
On May 24, 2017, 1:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59478/#review175822
---
Ship it!
Ship It!
- Zameer Manji
On May 22, 2017, 9:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59417/#review175569
---
Ship it!
Ship It!
- Zameer Manji
On May 19, 2017, 1:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58863/#review173516
---
Ship it!
Ship It!
- Zameer Manji
On April 28, 2017, 4:15
tination):
> safe_mkdir(os.path.dirname(destination))
> touch(destination)
> else:
> safe_mkdir(destination)
>
>
> https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/common/sandbox.py#L284-L290
>
>
isit:
> https://reviews.apache.org/r/58611/
> ---
>
> (Updated April 21, 2017, 3:36 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> It is not very common th
it to 30s as well.
- Zameer Manji
On April 21, 2017, 3:36 a.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
(I haven't looked into the code yet, but maybe you can clarify before I do).
>
> Santhosh Kumar Shanmugham wrote:
> That was the intent initially. However we risk delaying all updates
> without any changes to `watch_secs`. That is the main concern here. Let me
> know if this w
8524/
> ---
>
> (Updated April 19, 2017, 9:18 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Tas
moves to RUNNING
extending the update time."
I thought this was intentional. One can use this parameter to naturally slow
down update speed. I was under the impression that `watch_secs` should be set
to `0` if you want purely health check driven updates.
- Zameer Manji
On April 19, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58467/#review172093
---
Ship it!
Ship It!
- Zameer Manji
On April 15, 2017, 3:44
://reviews.apache.org/r/58066/diff/2-3/
Testing
---
Thanks,
Zameer Manji
/2/
Changes: https://reviews.apache.org/r/58066/diff/1-2/
Testing
---
Thanks,
Zameer Manji
t feeld weird to me that we are checkin for `image` when deciding if
> > we should fill the (from a datastructure perspective) unrelated field
> > `volumes`.
> >
> > Would it be incorrect that we always populate the volumes?
>
> Zameer Manji wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58167/#review171100
---
Ship it!
Ship It!
- Zameer Manji
On April 4, 2017, 12:11
/VersionedMesosSchedulerImplTest.java
756d0d9e30a447f9fba75c1c60f2f2f3c610399b
Diff: https://reviews.apache.org/r/58053/diff/4/
Changes: https://reviews.apache.org/r/58053/diff/3-4/
Testing
---
Thanks,
Zameer Manji
/VersionedMesosSchedulerImplTest.java
756d0d9e30a447f9fba75c1c60f2f2f3c610399b
Diff: https://reviews.apache.org/r/58053/diff/3/
Changes: https://reviews.apache.org/r/58053/diff/2-3/
Testing
---
Thanks,
Zameer Manji
ly, visit:
https://reviews.apache.org/r/58053/#review170655
---
On March 30, 2017, 11:37 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail.
Does the Mesos docs say anything about simultanous `SUBSCRIBE` calls?
> >
> > If the backoff time is still pretty low we might end up sending another
> > subscribe before we have received an answer for the previous one.
>
> Zameer Manji wrote:
> From what I
/VersionedMesosSchedulerImplTest.java
756d0d9e30a447f9fba75c1c60f2f2f3c610399b
Diff: https://reviews.apache.org/r/58053/diff/2/
Changes: https://reviews.apache.org/r/58053/diff/1-2/
Testing
---
Thanks,
Zameer Manji
`INVERSE_OFFERS`, etc.
I put it in here for the same kind of errors are the unversioned driver.
Technically we could put it everywhere. I'm not opposed if you think we should
do it.
- Zameer
---
This is an automatically
1cf3c8b2aec32fe93a2030
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
> ff1623acddf2ca2d59b5f987955005fe1e5d2bfd
>
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
> 80be33969d697ab7821eb0ef7cb5f7a7cb9ba61f
> src/test/sh/org/apache/aurora/e2e/http/http_example.aurora
> be43a099109d73b5dc34d8a66d2ca9782e025b0b
>
>
> Diff: https://reviews.apache.org/r/58066/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Zameer Manji
>
>
ng tests and e2e tests
I also added a new enum value to `JobUpdateStatus` and observed it was
correctly loaded in.
Thanks,
Zameer Manji
special manner.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58036/#review170525
---
On March 29, 2017, 4:
/diff_formatter.py
Line 55 (original), 55 (patched)
<https://reviews.apache.org/r/58054/#comment243369>
Please leave a comment that we are sorting sets here for consistency.
- Zameer Manji
On March 29, 2017, 8:29 p.m., Santhosh Kumar Shanmugham
/AbstractTaskStoreTest.java
80be33969d697ab7821eb0ef7cb5f7a7cb9ba61f
src/test/sh/org/apache/aurora/e2e/http/http_example.aurora
be43a099109d73b5dc34d8a66d2ca9782e025b0b
Diff: https://reviews.apache.org/r/58066/diff/1/
Testing
---
Thanks,
Zameer Manji
://reviews.apache.org/r/58053/diff/1/
Testing
---
Thanks,
Zameer Manji
correctly loaded in.
Thanks,
Zameer Manji
f/1/
Testing
---
Thanks,
Zameer Manji
ll need to be updated
> > to have their FK relations fixed)?
>
> Zameer Manji wrote:
> Yes, exactly. Dropping an enum value requires removing other tables. I
> presume we will just never use enums instead of actually deleting them.
>
> Joshua Cohen wrote:
> Mig
e2e tests
I also added a new enum value to `JobUpdateStatus` and observed it was
correctly loaded in.
Thanks,
Zameer Manji
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58036/#review170456
---
On March 29, 2017, 12:21 p.m., Zameer Manji wrote:
>
> ---
> This is an automatical
ora/scheduler/SchedulerLifecycleTest.java
051c520b4cb4cc1046dc316dfc8e1c968fc4e8e4
src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java
52041b5bc6e7b89616f5ce501eb22c58a12eaf26
Diff: https://reviews.apache.org/r/58017/diff/1/
Testing
---
Thanks,
Zameer Manji
s/custom-executors.md
Should my reasoning above be accepted, I will make these changes.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review168709
---
On March 13, 2017, 9:36 a.m., Zameer Manji
tination):
> safe_mkdir(os.path.dirname(destination))
> touch(destination)
> else:
> safe_mkdir(destination)
>
>
> https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/common/sandbox.py#L284-L290
>
>
: https://reviews.apache.org/r/57717/diff/3-4/
Testing
---
e2e tests
Thanks,
Zameer Manji
generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57757/
> ---
>
> (Updated March 20, 2017, 1:41 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji.
>
>
> Bugs: AURORA-1907
> https://issues.apache.org/jira/brows
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57757/#review169501
---
Ship it!
Ship It!
- Zameer Manji
On March 20, 2017, 1:41
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57757/#review169497
---
Ship it!
Ship It!
- Zameer Manji
On March 20, 2017, 1:41
://reviews.apache.org/media/uploaded/files/2017/03/16/1e989156-ea88-4e63-be72-bcca1e45b24e__Screen_Shot_2017-03-16_at_3.41.04_PM.png
Thanks,
Zameer Manji
tions, as `serverset_endpoint_name`
> > indicates I can put everything in there.
Done.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57708/#review169288
-----
/r/57708/diff/1-2/
Testing
---
e2e tests.
File Attachments
Screenshot
https://reviews.apache.org/media/uploaded/files/2017/03/16/1e989156-ea88-4e63-be72-bcca1e45b24e__Screen_Shot_2017-03-16_at_3.41.04_PM.png
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57717/#review169335
---
@ReviewBot retry
- Zameer Manji
On March 17, 2017, 3:05 p.m
: https://reviews.apache.org/r/57717/diff/2-3/
Testing
---
e2e tests
Thanks,
Zameer Manji
://reviews.apache.org/r/57717/diff/1-2/
Testing
---
e2e tests
Thanks,
Zameer Manji
; > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> > Lines 227-236 (patched)
> > <https://reviews.apache.org/r/57717/diff/1/?file=150#file150line227>
> >
> > The test using this helper will be waiting for over 2.5min. Would be
&
in the psutil changelog,
this seems fine to me. Nice find!
- Zameer Manji
On March 17, 2017, 9:38 a.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/http_example.aurora
de8179228d9359900eadf4084355ea257bea45ba
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
80b4c54774a02fdc2ee0e36d26f81aedd2e0055e
Diff: https://reviews.apache.org/r/57717/diff/1/
Testing
---
e2e tests
Thanks,
Zameer Manji
,
Zameer Manji
/
Testing
---
e2e tests.
File Attachments (updated)
Screenshot
https://reviews.apache.org/media/uploaded/files/2017/03/16/1e989156-ea88-4e63-be72-bcca1e45b24e__Screen_Shot_2017-03-16_at_3.41.04_PM.png
Thanks,
Zameer Manji
I see that I have been unclear here. I will take some time to better document
the problem to explain why I think this is necesssary.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review168
/aurora/scheduler/mesos/TestExecutorSettings.java
e1cd81e6fbd98f23046e6e775be268be4310c62a
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
93cc34cf8393f969087cd0fd6f577228c00170e9
Diff: https://reviews.apache.org/r/57524/diff/1/
Testing
---
Thanks,
Zameer
apache.org/r/57433/
> ---
>
> (Updated March 8, 2017, 1:25 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1895
> https://issues.apache.org/jira/browse/AURORA-1895
>
>
> Repository: aurora
>
>
> Descript
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/#review168331
---
@ReviewBot retry
- Zameer Manji
On March 7, 2017, 6:05 p.m
---
Thanks,
Zameer Manji
-
src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
9f39aeb1106d5ec29949280b5cf1fe3413e055d4
Diff: https://reviews.apache.org/r/57404/diff/1/
Testing
---
Thanks,
Zameer Manji
/VersionedSchedulerDriverService.java
9f39aeb1106d5ec29949280b5cf1fe3413e055d4
Diff: https://reviews.apache.org/r/57404/diff/1/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57357/#review168090
---
@ReviewBot retry
- Zameer Manji
On March 6, 2017, 6:42 p.m
/main/java/org/apache/aurora/common/util/Clock.java
87afb4ee0072d9a95c79c128042bc63cfafa74e2
Diff: https://reviews.apache.org/r/57357/diff/2/
Changes: https://reviews.apache.org/r/57357/diff/1-2/
Testing
---
Thanks,
Zameer Manji
://reviews.apache.org/r/57357/diff/1/
Testing
---
Thanks,
Zameer Manji
Consider augmenting `checkState()` with an error message.
Done.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57061/#review167579
-
://reviews.apache.org/r/57061/diff/13/
Changes: https://reviews.apache.org/r/57061/diff/12-13/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57061/#review167612
---
@ReviewBot retry
- Zameer Manji
On March 1, 2017, 11:14 a.m
erated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review166430
---
On Feb. 28, 2017, 1:25 p.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews
f2275c757ebfa52179e31b95bf0c02b6753fb7e3
Diff: https://reviews.apache.org/r/57061/diff/12/
Changes: https://reviews.apache.org/r/57061/diff/11-12/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
/57061/diff/11/
Changes: https://reviews.apache.org/r/57061/diff/10-11/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57061/#review167217
---
@ReviewBot retry
- Zameer Manji
On Feb. 28, 2017, 10:46 p.m
/ThriftIT.java
f2275c757ebfa52179e31b95bf0c02b6753fb7e3
Diff: https://reviews.apache.org/r/57061/diff/10/
Changes: https://reviews.apache.org/r/57061/diff/9-10/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
t;
> > Can we avoid repeating this in each method?
>
> Zameer Manji wrote:
> I tried but not really. This is why:
> 1. `ensureRunning` ensures the Guava service is running before we do
> anything. It is a good sanity check.
> 2. `blockUntilRegistered` force
/scheduler/thrift/ThriftIT.java
f2275c757ebfa52179e31b95bf0c02b6753fb7e3
Diff: https://reviews.apache.org/r/57061/diff/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
/thrift/ThriftIT.java
f2275c757ebfa52179e31b95bf0c02b6753fb7e3
Diff: https://reviews.apache.org/r/57061/diff/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
/scheduler/thrift/ThriftIT.java
f2275c757ebfa52179e31b95bf0c02b6753fb7e3
Diff: https://reviews.apache.org/r/57061/diff/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
f2275c757ebfa52179e31b95bf0c02b6753fb7e3
Diff: https://reviews.apache.org/r/57061/diff/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
: https://reviews.apache.org/r/57061/diff/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
production and give some feedback on performance? It would be good to know
> > if we can get rid of the old native driver or we're going to have to carry
> > the different implementations around for a while. We could also try and run
> > this patch in our scale test cluster.
t:
https://reviews.apache.org/r/57061/#review166983
-------
On Feb. 27, 2017, 4:43 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57061/
> ---
: https://reviews.apache.org/r/57061/diff/
Testing
---
The e2e test has been run three times, each time with a different driver option.
Thanks,
Zameer Manji
I feel that the logging should be here, but I'm unsure on how
to deduplicate it cleanly.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57061/#review166958
---
1 - 100 of 731 matches
Mail list logo
