Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Dec. 17, 2015, 5:22 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review111023 --- Master (c912c34) is red with this patch.

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Dec. 17, 2015, 9:45 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review111069 --- Ship it! Ship It! - Bill Farner On Dec. 17, 2015, 12:38 p.m.,

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review110697 --- Ship it! Master (fb8155d) is green with this patch. true I

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review110710 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review109957 --- src/main/python/apache/thermos/core/runner.py (line 718)

Re: Review Request 30695: Implements log rotation in the Thermos runner.

> On Dec. 11, 2015, 1:20 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/runner.py, line 718 > > > > > > I am not sure if it is a good idea to always enforce the gloabal > > settings, instead of

Re: Review Request 30695: Implements log rotation in the Thermos runner.

> On Dec. 11, 2015, 5:20 a.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/runner.py, line 718 > > > > > > I am not sure if it is a good idea to always enforce the gloabal > > settings, instead of

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review109834 --- LGTM mod some top-level ergonomics. Happy to ship once we resolve

Re: Review Request 30695: Implements log rotation in the Thermos runner.

> On Dec. 10, 2015, 11:12 a.m., Bill Farner wrote: > > docs/deploying-aurora-scheduler.md, line 182 > > > > > > This has diverged from the actual arg in the code. > > George Sirois wrote: > Yeah, see my comment

Re: Review Request 30695: Implements log rotation in the Thermos runner.

> On Dec. 10, 2015, 7:12 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line > > 110 > > > > > > What is the unit? FWIW i'm typically fond when the arg calls out

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review109767 --- I've manually tested patch on running mesos/aurora cluster. Mesos

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review108025 --- Ship it! Master (8524dbf) is green with this patch.

Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Nov. 25, 2015, 5 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 30695: Implements log rotation in the Thermos runner.

> On Feb. 6, 2015, 7:52 p.m., Brian Wickman wrote: > > This is super rad. Thanks for taking this on. > > > > Before I do a deeper dive, what do you think about making the logrotate > > policy be specified by the user instead of the framework owner, with a > > sensible default? For example,