Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-28 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130886 --- @ReviewBot retry - Stephan Erb On April 28, 2016, 12:44 a.m.,

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
> On April 28, 2016, 3:54 p.m., Maxim Khutornenko wrote: > > build-support/packer/build.sh, line 37 > > > > > > What about the `java2-runtime-headless` proposed in that pull request? > > Did you find it redundant?

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130929 --- build-support/packer/build.sh (line 37)

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130923 --- Ship it! Ship It! - Stephan Erb On April 28, 2016, 5:48

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130930 --- Ship it! Master (e817eb1) is green with this patch.

Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/ --- Review request for Aurora, John Sirois and Stephan Erb. Repository: aurora

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130924 --- build-support/packer/build.sh (line 37)

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
> On April 28, 2016, 10:02 a.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
> On April 28, 2016, 10:02 a.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
> On April 28, 2016, 10:02 a.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/ --- (Updated April 28, 2016, 5:08 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
> On April 28, 2016, 4:02 p.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in the

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130948 --- Ship it! Master (e817eb1) is green with this patch.

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131007 --- Master (450d881) is green with this patch.

Re: Review Request 46795: Fixing e2e tests.

2016-04-28 Thread Joshua Cohen
> On April 28, 2016, 6:31 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V005_CreateQuotaResourceTable.java, > > line 39 > > > > > > What is value in the case of ports?

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
> On April 28, 2016, 10:02 a.m., John Sirois wrote: > > build-support/packer/build.sh, line 44 > > > > > > I'm missing how this is needed too. > > Joshua Cohen wrote: > If I remove this we don't have a jdk in

Re: Review Request 46795: Fixing e2e tests.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46795/#review130964 --- Ship it! lgtm assuming the question below is not an issue.

Re: Review Request 46795: Fixing e2e tests.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46795/#review130965 --- Ship it! Master (e817eb1) is green with this patch.

Review Request 46810: Generalizing port resource management.

2016-04-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46810/ --- Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131025 --- Is there ever a case where we wouldn't want to show the tier?

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131026 --- Ship it! Ship It! - Joshua Cohen On April 28, 2016, 11:09

Re: Review Request 46810: Generalizing port resource management.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46810/#review131029 --- Ship it! Master (450d881) is green with this patch.

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131028 --- src/main/resources/scheduler/assets/js/controllers.js (line 139)

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Amol Deshmukh
> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/ --- (Updated April 28, 2016, 7:54 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/ --- (Updated April 28, 2016, 7:37 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

2016-04-28 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130980 --- Ship it! Ship It! - John Sirois On April 28, 2016, 1:37

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46803/#review131042 --- Master (450d881) is green with this patch.

Re: Review Request 46810: Generalizing port resource management.

2016-04-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46810/#review131044 ---

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Joshua Cohen
> On April 29, 2016, 1:20 a.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

2016-04-28 Thread Bill Farner
> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most