date:20160119

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Zameer Manji



> On Jan. 19, 2016, 8:34 a.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java, 
> > line 67
> > 
> >
> > The defaults aren't applied consistently here, not sometimes at all in 
> > the Params interfaces above.  Its not important to get this right until the 
> > RB that takes away the Arg fields though, so I'm fine with reading this 
> > change as providing some examples of how this will work.  My takeaway , 
> > based on optional options being - hopefully - the norm, is that The Params 
> > methods should either return Optional and have no default implementation or 
> > else have a default implementation.  Non-Optional pure abstract Params 
> > should be viewed with mild suspicion.
> 
> Bill Farner wrote:
> I was sleep-deprived on a plane when writing this, but i believe my 
> rationale was to use `default` methods minimally in this change.  I intended 
> to use them solely in places where tests would otherwise be forced to supply 
> a default (at risk of diverging from the true default).
> 
> You are right, though, all defaults will be applied this way in the 
> follow-up.  The `Optional`/`default` decision will be an interesting one, 
> though, so hold on to that thought!

+1 to the follow up change and I had the same concern about `Optional/default`.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115175
---


On Jan. 19, 2016, 9:49 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> ---
> 
> (Updated Jan. 19, 2016, 9:49 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 5daafa9234d20dfcfd9a6cc81508836efe39f1f0 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  7de8f4cebcda51953e00322caec6ad278951f6b1 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 23d1c120657d5cb9d294a80c63e8a04512d361ca 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
>

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115250
---


Master (317aa4d) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 19, 2016, 5:49 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> ---
> 
> (Updated Jan. 19, 2016, 5:49 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 5daafa9234d20dfcfd9a6cc81508836efe39f1f0 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  7de8f4cebcda51953e00322caec6ad278951f6b1 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 23d1c120657d5cb9d294a80c63e8a04512d361ca 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
> 735199ac1ab343c24471890aa330d6635c26 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
>  cccee083fc2e5f204c91a9d397beb451d4d9df40 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 577edcbf362493d577e2f12c876f1dbb9387ad79 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> d569241a59f169eaa9982c3bba7003aa4942f50f 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> 08eb6d6c722950f6bc75c97ce12380eca16e704d 
>   src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
> 4767ef12e6a3c9d7b2d4a2b5be27786518b5b612 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
> cded40ba4981e0ae287b6a24e49523f40674bef9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 2b3ee7bf6f7801c140f921b25f78daf6d320098a 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> ed63a7471d654dcefd2ff24e2e462974883541f2 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 
> 1b491f977cf3a81e61f1333082be0547420306d4 
>   
>

Re: Review Request 42445: Upgrade pants to 0.0.68.

2016-01-19 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42445/#review115233
---


I'm going to patch this in presently, but wave hellow to Joe!

- John Sirois


On Jan. 17, 2016, 4:42 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42445/
> ---
> 
> (Updated Jan. 17, 2016, 4:42 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is the regular weekly release/upgrade.
> The CHANGELOG can be read here:
>   http://pantsbuild.github.io/changelog.html
> 
> Of interest for Aurora is graceful error handling when running
> py.test with `--coverage` enabled.
> 
>  pants.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   pants.ini a5fbfba81e1444ddf144db33dd3321aa06365385 
> 
> Diff: https://reviews.apache.org/r/42445/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 42445: Upgrade pants to 0.0.68.

2016-01-19 Thread Joe Smith



> On Jan. 19, 2016, 1:06 p.m., John Sirois wrote:
> > I'm going to patch this in presently, but wave hellow to Joe!

/wave


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42445/#review115233
---


On Jan. 17, 2016, 3:42 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42445/
> ---
> 
> (Updated Jan. 17, 2016, 3:42 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is the regular weekly release/upgrade.
> The CHANGELOG can be read here:
>   http://pantsbuild.github.io/changelog.html
> 
> Of interest for Aurora is graceful error handling when running
> py.test with `--coverage` enabled.
> 
>  pants.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   pants.ini a5fbfba81e1444ddf144db33dd3321aa06365385 
> 
> Diff: https://reviews.apache.org/r/42445/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

2016-01-19 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115236
---

Ship it!


Ship It!

- Bill Farner


On Jan. 19, 2016, 10:46 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> ---
> 
> (Updated Jan. 19, 2016, 10:46 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill 
> Farner.
> 
> 
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is how I tested changes in https://reviews.apache.org/r/42176/.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 8120ff7706f0ad0810ec9018c55d0d065066cbc5 
>   examples/vagrant/upstart/mesos-master.conf 
> 9d7491c08e14e3951b2fd2f74291a2009883c379 
>   examples/vagrant/upstart/mesos-slave.conf 
> 1ef059b17d16d4f1594a19ff6422ea653a413359 
> 
> Diff: https://reviews.apache.org/r/42177/diff/
> 
> 
> Testing
> ---
> 
> Integration test script.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115244
---

Ship it!


Looking forward to the followup change that collapses some of the code by using 
`default` methods.

- Zameer Manji


On Jan. 19, 2016, 9:49 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> ---
> 
> (Updated Jan. 19, 2016, 9:49 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 5daafa9234d20dfcfd9a6cc81508836efe39f1f0 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  7de8f4cebcda51953e00322caec6ad278951f6b1 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 23d1c120657d5cb9d294a80c63e8a04512d361ca 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
> 735199ac1ab343c24471890aa330d6635c26 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
>  cccee083fc2e5f204c91a9d397beb451d4d9df40 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 577edcbf362493d577e2f12c876f1dbb9387ad79 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> d569241a59f169eaa9982c3bba7003aa4942f50f 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> 08eb6d6c722950f6bc75c97ce12380eca16e704d 
>   src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
> 4767ef12e6a3c9d7b2d4a2b5be27786518b5b612 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
> cded40ba4981e0ae287b6a24e49523f40674bef9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 2b3ee7bf6f7801c140f921b25f78daf6d320098a 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> ed63a7471d654dcefd2ff24e2e462974883541f2 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 
> 1b491f977cf3a81e61f1333082be0547420306d4 
>   
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java
>  5b59d55b8e58d0231a18da9813045a9d1dd70be3 
>

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

2016-01-19 Thread Zhitao Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/
---

(Updated Jan. 19, 2016, 6:46 p.m.)


Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill 
Farner.


Changes
---

Revert change to log location and rebase with master.


Bugs: AURORA-1109
https://issues.apache.org/jira/browse/AURORA-1109


Repository: aurora


Description
---

This is how I tested changes in https://reviews.apache.org/r/42176/.


Diffs (updated)
-

  examples/vagrant/upstart/aurora-scheduler.conf 
8120ff7706f0ad0810ec9018c55d0d065066cbc5 
  examples/vagrant/upstart/mesos-master.conf 
9d7491c08e14e3951b2fd2f74291a2009883c379 
  examples/vagrant/upstart/mesos-slave.conf 
1ef059b17d16d4f1594a19ff6422ea653a413359 

Diff: https://reviews.apache.org/r/42177/diff/


Testing
---

Integration test script.


Thanks,

Zhitao Li

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

2016-01-19 Thread Bill Farner



> On Jan. 19, 2016, 10:39 a.m., Maxim Khutornenko wrote:
> > examples/vagrant/upstart/mesos-master.conf, line 27
> > 
> >
> > Is this really needed? All logs are currently dumped under 
> > /var/log/upstart if I remember it right.
> 
> Zhitao Li wrote:
> You are indeed right. I added this before findout out Mesos logs is in 
> the other location. I'll rebase this review request and remove this log line 
> change.
> 
> This review mostly exists to show how I performed integration tests when 
> working on previous diff. If anyone feels that we do not want to change the 
> default mode of integration test, I don't feel strong to check this in anyway.

I'm a big proponent of having this covered in the integration tests, so I'm 
happy to see this patch.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115204
---


On Jan. 12, 2016, 8:04 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> ---
> 
> (Updated Jan. 12, 2016, 8:04 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill 
> Farner.
> 
> 
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is how I tested changes in https://reviews.apache.org/r/42176/.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 4033184451f36cb5f0233ea96e3dceaae6741275 
>   examples/vagrant/upstart/mesos-master.conf 
> 9d7491c08e14e3951b2fd2f74291a2009883c379 
>   examples/vagrant/upstart/mesos-slave.conf 
> 1ef059b17d16d4f1594a19ff6422ea653a413359 
> 
> Diff: https://reviews.apache.org/r/42177/diff/
> 
> 
> Testing
> ---
> 
> Integration test script.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/
---

(Updated Jan. 19, 2016, 9:49 a.m.)


Review request for Aurora, John Sirois and Zameer Manji.


Repository: aurora


Description
---

This begins to define a proposed replacement args API, from the perspective of 
the code consuming args.  Args will be defined in interfaces, which the 
eventual arg system will be responsible for implementing on the fly (mechanism 
TBD).  So while what is seen here is a large net increase in code, the eventual 
conclusion will be roughly equivalent in terms of lines of code in `Module`s.

This begins to enact work described here: 
http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E


Diffs (updated)
-

  config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
45ab76b9331a79699979c6386c93bbc763f64e2e 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
ddc0d0500b8788bc2c9dd67abb62a412465488b4 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
0659c358479283756179c2cabebc8416730cc3e3 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
da07df66b06cef6223119854032b4ca1c57a0859 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 949c299bdbc54f976db994266fb97f3099256f13 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
155d702d68367b247dd066f773c662407f0e3b5b 
  src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
01d6b5de0079d6f5709c29fe9a72829fbc8501de 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
  src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
cd5adf9655dc3368dbe06bfee15c65182176be2e 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
 e32862034a1ad47dae8fff89cb04deb34ccd90e2 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
 43c38dcffd8e68c018217681cc5a3073d9fb1437 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
 0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
  src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
5daafa9234d20dfcfd9a6cc81508836efe39f1f0 
  
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
 7de8f4cebcda51953e00322caec6ad278951f6b1 
  src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
  src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
23d1c120657d5cb9d294a80c63e8a04512d361ca 
  src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
735199ac1ab343c24471890aa330d6635c26 
  
src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
 cccee083fc2e5f204c91a9d397beb451d4d9df40 
  src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
577edcbf362493d577e2f12c876f1dbb9387ad79 
  src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
d569241a59f169eaa9982c3bba7003aa4942f50f 
  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
08eb6d6c722950f6bc75c97ce12380eca16e704d 
  src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
4767ef12e6a3c9d7b2d4a2b5be27786518b5b612 
  src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
cded40ba4981e0ae287b6a24e49523f40674bef9 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
2b3ee7bf6f7801c140f921b25f78daf6d320098a 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
ed63a7471d654dcefd2ff24e2e462974883541f2 
  src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 
1b491f977cf3a81e61f1333082be0547420306d4 
  
src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java
 5b59d55b8e58d0231a18da9813045a9d1dd70be3 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
9fb8aad5d1c0412efc6d1176e543321ebe503e03 
  src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
4716b66307bad16ecf29ec977e033e31f090fc9d 
  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
19c8a1fe06a24022da11f74d7c96b2942587 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 
3e811a4f4d2c82892217ca1f950ac792303fbcf3 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
2c3e5f32c774be07a5fa28c8bcf3b9a5d88059a1

Re: Review Request 42475: Fixup broken jmh benchmarks.

2016-01-19 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42475/#review115203
---

Ship it!


Ship It!

- Maxim Khutornenko


On Jan. 18, 2016, 10:37 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42475/
> ---
> 
> (Updated Jan. 18, 2016, 10:37 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The `TierConfig` binding fix for the `SchedulingBenchmarks` in
> https://reviews.apache.org/r/42073 was also needed for the
> `StatusUpdateBenchmarks` and a binding for `ConfigurationManager` was
> missing for the `ThriftApiBenchmarks` as-of 
> https://reviews.apache.org/r/41711/.
> 
> While debugging these failures I noticed a new version of jmh had been
> released recently, so also upgraded to that.  No changes of import, but
> the changelog can be read here:
>   http://hg.openjdk.java.net/code-tools/jmh/
> 
>  build.gradle| 4 ++--
>  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java | 8 
> 
>  src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java   | 6 
> ++
>  3 files changed, 12 insertions(+), 6 deletions(-)
> 
> 
> Diffs
> -
> 
>   build.gradle 169fb2535c6faddd0546d12d070cbaab1830c832 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 3898596f6a657a6908d4f6fb9fde952186827aa7 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> fd182aa60b90a26fc073cd5821c64b7129439741 
> 
> Diff: https://reviews.apache.org/r/42475/diff/
> 
> 
> Testing
> ---
> 
> Both of these now work on master:
> `./gradlew jmh -Pbenchmarks='StatusUpdateBenchmark.*'`
> `./gradlew jmh -Pbenchmarks='ThriftApiBenchmark.*'`
> 
> I also checked that a full run of `./gradlew jmh` was now green for
> all benchmarks.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

2016-01-19 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115210
---

Ship it!


Ship It!

- Maxim Khutornenko


On Jan. 19, 2016, 6:46 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> ---
> 
> (Updated Jan. 19, 2016, 6:46 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill 
> Farner.
> 
> 
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is how I tested changes in https://reviews.apache.org/r/42176/.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 8120ff7706f0ad0810ec9018c55d0d065066cbc5 
>   examples/vagrant/upstart/mesos-master.conf 
> 9d7491c08e14e3951b2fd2f74291a2009883c379 
>   examples/vagrant/upstart/mesos-slave.conf 
> 1ef059b17d16d4f1594a19ff6422ea653a413359 
> 
> Diff: https://reviews.apache.org/r/42177/diff/
> 
> 
> Testing
> ---
> 
> Integration test script.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-19 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42077/#review115223
---


George, there's a merge conflict in NEWS, can you rebase and post an updated 
review? Then I'll commit this change.

- Joshua Cohen


On Jan. 12, 2016, 7:58 p.m., George Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42077/
> ---
> 
> (Updated Jan. 12, 2016, 7:58 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1575
> https://issues.apache.org/jira/browse/AURORA-1575
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This flag allows cluster administrators to set arbitrary
> Docker parameters which will apply to all jobs.
> 
> Also cleans up some of the existing unit tests around task config.
> 
> 
> Diffs
> -
> 
>   NEWS 83a1213e2ea4ab6b3706cd70c015ba9f16735520 
>   README.md f3b23247cf3f7e550c1714b4fb8227a2baab3b41 
>   
> commons/src/main/java/org/apache/aurora/common/args/parsers/MultimapParser.java
>  PRE-CREATION 
>   docs/deploying-aurora-scheduler.md 8a1e68e5d54e9b8b66139bfc731563668584fa77 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 4eee8e31a4ccd25ba4a5bcb60b67c79979c3b9b0 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> d7f3c60d383cf10afb0c0fcf4fe29972b183458c 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  05e8b714043dea89039ce9a1fc4b32c65ab15fe4 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
> 
> Diff: https://reviews.apache.org/r/42077/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> George Sirois
> 
>

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115197
---

Ship it!


Ship It!

- John Sirois


On Jan. 19, 2016, 10:49 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> ---
> 
> (Updated Jan. 19, 2016, 10:49 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 5daafa9234d20dfcfd9a6cc81508836efe39f1f0 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  7de8f4cebcda51953e00322caec6ad278951f6b1 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 23d1c120657d5cb9d294a80c63e8a04512d361ca 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
> 735199ac1ab343c24471890aa330d6635c26 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
>  cccee083fc2e5f204c91a9d397beb451d4d9df40 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 577edcbf362493d577e2f12c876f1dbb9387ad79 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> d569241a59f169eaa9982c3bba7003aa4942f50f 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> 08eb6d6c722950f6bc75c97ce12380eca16e704d 
>   src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
> 4767ef12e6a3c9d7b2d4a2b5be27786518b5b612 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
> cded40ba4981e0ae287b6a24e49523f40674bef9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 2b3ee7bf6f7801c140f921b25f78daf6d320098a 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> ed63a7471d654dcefd2ff24e2e462974883541f2 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 
> 1b491f977cf3a81e61f1333082be0547420306d4 
>   
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java
>  5b59d55b8e58d0231a18da9813045a9d1dd70be3 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 9fb8aad5d1c0412efc6d1176e543321ebe503e03 
>

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

2016-01-19 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115204
---



examples/vagrant/upstart/mesos-master.conf (line 27)


Is this really needed? All logs are currently dumped under /var/log/upstart 
if I remember it right.


- Maxim Khutornenko


On Jan. 13, 2016, 4:04 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> ---
> 
> (Updated Jan. 13, 2016, 4:04 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill 
> Farner.
> 
> 
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is how I tested changes in https://reviews.apache.org/r/42176/.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 4033184451f36cb5f0233ea96e3dceaae6741275 
>   examples/vagrant/upstart/mesos-master.conf 
> 9d7491c08e14e3951b2fd2f74291a2009883c379 
>   examples/vagrant/upstart/mesos-slave.conf 
> 1ef059b17d16d4f1594a19ff6422ea653a413359 
> 
> Diff: https://reviews.apache.org/r/42177/diff/
> 
> 
> Testing
> ---
> 
> Integration test script.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

2016-01-19 Thread Maxim Khutornenko



> On Jan. 19, 2016, 6:39 p.m., Maxim Khutornenko wrote:
> > examples/vagrant/upstart/mesos-master.conf, line 27
> > 
> >
> > Is this really needed? All logs are currently dumped under 
> > /var/log/upstart if I remember it right.
> 
> Zhitao Li wrote:
> You are indeed right. I added this before findout out Mesos logs is in 
> the other location. I'll rebase this review request and remove this log line 
> change.
> 
> This review mostly exists to show how I performed integration tests when 
> working on previous diff. If anyone feels that we do not want to change the 
> default mode of integration test, I don't feel strong to check this in anyway.
> 
> Bill Farner wrote:
> I'm a big proponent of having this covered in the integration tests, so 
> I'm happy to see this patch.

+1.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115204
---


On Jan. 19, 2016, 6:46 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> ---
> 
> (Updated Jan. 19, 2016, 6:46 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill 
> Farner.
> 
> 
> Bugs: AURORA-1109
> https://issues.apache.org/jira/browse/AURORA-1109
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is how I tested changes in https://reviews.apache.org/r/42176/.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 8120ff7706f0ad0810ec9018c55d0d065066cbc5 
>   examples/vagrant/upstart/mesos-master.conf 
> 9d7491c08e14e3951b2fd2f74291a2009883c379 
>   examples/vagrant/upstart/mesos-slave.conf 
> 1ef059b17d16d4f1594a19ff6422ea653a413359 
> 
> Diff: https://reviews.apache.org/r/42177/diff/
> 
> 
> Testing
> ---
> 
> Integration test script.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-19 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42077/#review115222
---

Ship it!


Ship It!

- Joshua Cohen


On Jan. 12, 2016, 7:58 p.m., George Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42077/
> ---
> 
> (Updated Jan. 12, 2016, 7:58 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1575
> https://issues.apache.org/jira/browse/AURORA-1575
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This flag allows cluster administrators to set arbitrary
> Docker parameters which will apply to all jobs.
> 
> Also cleans up some of the existing unit tests around task config.
> 
> 
> Diffs
> -
> 
>   NEWS 83a1213e2ea4ab6b3706cd70c015ba9f16735520 
>   README.md f3b23247cf3f7e550c1714b4fb8227a2baab3b41 
>   
> commons/src/main/java/org/apache/aurora/common/args/parsers/MultimapParser.java
>  PRE-CREATION 
>   docs/deploying-aurora-scheduler.md 8a1e68e5d54e9b8b66139bfc731563668584fa77 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 4eee8e31a4ccd25ba4a5bcb60b67c79979c3b9b0 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> d7f3c60d383cf10afb0c0fcf4fe29972b183458c 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  05e8b714043dea89039ce9a1fc4b32c65ab15fe4 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  f3b62cc957186bc9673060830572bc1cc073ac49 
> 
> Diff: https://reviews.apache.org/r/42077/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> George Sirois
> 
>

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/
---

(Updated Jan. 20, 2016, 12:04 a.m.)


Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.


Repository: aurora-packaging


Description
---

Adding debian jessie packaging with a test.


Diffs (updated)
-

  build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
  builder/deb/debian-jessie/Dockerfile PRE-CREATION 
  builder/deb/debian-jessie/build.sh PRE-CREATION 
  builder/deb/debian-jessie/pants.ini PRE-CREATION 
  specs/debian/aurora-executor.thermos.init 
e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
  specs/debian/aurora-executor.thermos.service PRE-CREATION 
  specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
  specs/debian/aurora-scheduler.postinst 
0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
  specs/debian/aurora-scheduler.service PRE-CREATION 
  specs/debian/aurora-scheduler.upstart 
1ceb7042485efedcf7136b51737107aada4c4e96 
  specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
  test/deb/debian-jessie/README.md PRE-CREATION 
  test/deb/debian-jessie/Vagrantfile PRE-CREATION 
  test/deb/debian-jessie/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42387/diff/


Testing
---

New build with a test that starts a Vagrant and following README should lead to 
a successful job.


Thanks,

Dmitriy Shirchenko

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko



> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-scheduler.postinst, line 38
> > 
> >
> > `specs/debian/aurora-scheduler.init` uses 
> > `PIDFILE=/var/run/aurora-scheduler.pid` - who uses `/var/run/aurora/`?

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-executor.thermos.init, line 54
> > 
> >
> > Not sure the with $ARGS makes much sense for stop, it might even be a 
> > lie when stopping an older deploy.

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > builder/deb/debian-jessie/Dockerfile, line 38
> > 
> >
> > Its not exactly clear to me how this is any better than downloading 
> > gradle from gradle.  Since this is only used for the builder it seems to me 
> > the only relevant details is - not a standard package install - aka a 
> > ~random internet download.  If the plan is that benley's work here makes it 
> > upstream to a standard debian deb repo I think its worth a comment pointing 
> > that expected future out.  As it stands w/o that comment and forgetting we 
> > know and trust benley, this looks on the face decidedly worse than going 
> > straight to the gradle source.

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-executor.thermos.init, line 22
> > 
> >
> > This is admittedly all over the place across our packages and OSs 
> > already before your change, but for the deb scheduler we have 
> > `/var/run/aurora-scheduler.pid` - how about `/var/run/aurora-observer.pid` 
> > or `/var/run/thermos-observer.pid`, some consistency here would be useful I 
> > think for discovery purposes.

Done.


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115281
---


On Jan. 20, 2016, 12:59 a.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 20, 2016, 12:59 a.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Review Request 42532: Revert "Shim interfaces to preface args system overhaul."

2016-01-19 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42532/
---

Review request for Aurora and John Sirois.


Repository: aurora


Description
---

This reverts commit fe13e4ed52d4dc0a35f9e50b5e49c6e705f64579.

I'd like to back out this change until i overcome some hurdles with the 
follow-up args replacement patch.  I don't want the code to sit i this 
intermediate phase, so i'd rather revert.


Diffs
-

  config/legacy_untested_classes.txt 30d4b13223edf2ce9f23bda5bebacc686cbb0261 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
3ce266a7025b1851c092c3f699eba861547e5315 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
83e90603488a0be02b8178b31a9bd2a64e47c010 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
58026e1a442c9371c7dab7194a24998e138b3009 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
0861c4e9adc6dfb991aa3debc0e32b617cc7544d 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
d30786169c31598f81b959011d440e3cd1d21fce 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 8c58c5ba9454c9b75746beb6fa1ba4f1816decac 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
c16531753ed9280046e918f2228c8837b0f24bca 
  src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
f96516198f5547e75b9e1b6539689ec3f677664b 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
33e3cd8b20cb75ce2ee03b917e0b101fce4c3046 
  src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
b37278bdae003719166968152eba3ff4399ea397 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
 d305112f7e85fe9be82aa73bb72aad9db0e970b0 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
 209a7140f2cfc6cc0eaf7a5e3233f24659d889e4 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
 0090567a1c465e18548def578d738cf8ebc48d6b 
  src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
9482d7487fa42082d2f48ffad579d5efe0dc1c39 
  
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
 4c41576fa625811e431078ce8dbfc06f95b05246 
  src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
39b4ab189b2a7757292843b6f59ac1783e7a2873 
  src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
e58688ac7b6c4addf64545bfc943e00551deab52 
  src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
be10bff5a2080ebcc93fdcc7cf55319523a409ab 
  
src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
 b8e2c0a8f136c3ff2ab34cf8e1e6392df4ff4e60 
  src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
150c654841b4f66dbbcff9c541f4ee733d47bc15 
  src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
159a88456297f43a38480d4b1738ac2f6d48cd0e 
  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
e8d1e14bf3f79d298892be70e2e2a11d566c2af4 
  src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
c56ff3c9264d731994212c4e32b4f44da5fe61aa 
  src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
38bf1aa0183df25e07492563f39a8423dde75a10 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
b4deef0a397690e2ce4b36fb03d794781f82e7f6 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
07ec54cd6ec542075ff78ffe3a80d792cae12314 
  src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 
8909833cadc0baffe11d4b50842eacadd537f34e 
  
src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java
 483829365ba63a21e490f415bacb7211b45d2729 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
35292a2bca9eb26455d48b8605ad2a86354d3e80 
  src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
650cde6bcded5178f1e427b034f819393e1b0f59 
  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
9c40aaf0e69d4b9239e81d965516f77c81e3eb1b 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 
0c9d4f6af9ac64e3ad4b57f46e6f38217d95df53 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
0bbb687e7b6e63e8a6333cabc752686a51f0e81e 
  src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
fe8c28260c801142319834cd25a8e813dd14ab95 

Diff: https://reviews.apache.org/r/42532/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko



> On Jan. 17, 2016, 10:54 a.m., Stephan Erb wrote:
> > specs/debian/aurora-scheduler.init, line 73
> > 
> >
> > IIRC the `start-stop-daemon` does not restart failed processes. How 
> > does this interact with Aurora commiting suicide at least onces a day?

Thanks. I added .service file which will respawn failed processes.


> On Jan. 17, 2016, 10:54 a.m., Stephan Erb wrote:
> > builder/deb/debian-jessie/build.sh, line 32
> > 
> >
> > Given that the packages should become official, it might be worthwhile 
> > to change this one here.

Done.


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review114903
---


On Jan. 19, 2016, 11:23 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 11:23 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.postinst 
> 0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/
---

(Updated Jan. 20, 2016, 12:59 a.m.)


Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.


Repository: aurora-packaging


Description
---

Adding debian jessie packaging with a test.


Diffs (updated)
-

  build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
  builder/deb/debian-jessie/Dockerfile PRE-CREATION 
  builder/deb/debian-jessie/build.sh PRE-CREATION 
  builder/deb/debian-jessie/pants.ini PRE-CREATION 
  specs/debian/aurora-executor.thermos.init 
e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
  specs/debian/aurora-executor.thermos.service PRE-CREATION 
  specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
  specs/debian/aurora-scheduler.service PRE-CREATION 
  specs/debian/aurora-scheduler.upstart 
1ceb7042485efedcf7136b51737107aada4c4e96 
  specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
  test/deb/debian-jessie/README.md PRE-CREATION 
  test/deb/debian-jessie/Vagrantfile PRE-CREATION 
  test/deb/debian-jessie/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42387/diff/


Testing
---

New build with a test that starts a Vagrant and following README should lead to 
a successful job.


Thanks,

Dmitriy Shirchenko

Re: Review Request 42532: Revert "Shim interfaces to preface args system overhaul."

2016-01-19 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42532/#review115313
---


Master (fe13e4e) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 20, 2016, 1:28 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42532/
> ---
> 
> (Updated Jan. 20, 2016, 1:28 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This reverts commit fe13e4ed52d4dc0a35f9e50b5e49c6e705f64579.
> 
> I'd like to back out this change until i overcome some hurdles with the 
> follow-up args replacement patch.  I don't want the code to sit i this 
> intermediate phase, so i'd rather revert.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 30d4b13223edf2ce9f23bda5bebacc686cbb0261 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 3ce266a7025b1851c092c3f699eba861547e5315 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 83e90603488a0be02b8178b31a9bd2a64e47c010 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 58026e1a442c9371c7dab7194a24998e138b3009 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0861c4e9adc6dfb991aa3debc0e32b617cc7544d 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> d30786169c31598f81b959011d440e3cd1d21fce 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  8c58c5ba9454c9b75746beb6fa1ba4f1816decac 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> c16531753ed9280046e918f2228c8837b0f24bca 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> f96516198f5547e75b9e1b6539689ec3f677664b 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 33e3cd8b20cb75ce2ee03b917e0b101fce4c3046 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> b37278bdae003719166968152eba3ff4399ea397 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  d305112f7e85fe9be82aa73bb72aad9db0e970b0 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  209a7140f2cfc6cc0eaf7a5e3233f24659d889e4 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0090567a1c465e18548def578d738cf8ebc48d6b 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 9482d7487fa42082d2f48ffad579d5efe0dc1c39 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  4c41576fa625811e431078ce8dbfc06f95b05246 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 39b4ab189b2a7757292843b6f59ac1783e7a2873 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> e58688ac7b6c4addf64545bfc943e00551deab52 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
> be10bff5a2080ebcc93fdcc7cf55319523a409ab 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
>  b8e2c0a8f136c3ff2ab34cf8e1e6392df4ff4e60 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 150c654841b4f66dbbcff9c541f4ee733d47bc15 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 159a88456297f43a38480d4b1738ac2f6d48cd0e 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> e8d1e14bf3f79d298892be70e2e2a11d566c2af4 
>   src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
> c56ff3c9264d731994212c4e32b4f44da5fe61aa 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
> 38bf1aa0183df25e07492563f39a8423dde75a10 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> b4deef0a397690e2ce4b36fb03d794781f82e7f6 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 07ec54cd6ec542075ff78ffe3a80d792cae12314 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 
> 8909833cadc0baffe11d4b50842eacadd537f34e 
>   
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java
>  483829365ba63a21e490f415bacb7211b45d2729 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 35292a2bca9eb26455d48b8605ad2a86354d3e80 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 650cde6bcded5178f1e427b034f819393e1b0f59 
>

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115281
---

I'm running through a test presently - will report back.

specs/debian/aurora-executor.thermos.init (line 54)

Not sure the with $ARGS makes much sense for stop, it might even be a lie 
when stopping an older deploy.

builder/deb/debian-jessie/Dockerfile (line 38)

Its not exactly clear to me how this is any better than downloading gradle 
from gradle.  Since this is only used for the builder it seems to me the only 
relevant details is - not a standard package install - aka a ~random internet 
download.  If the plan is that benley's work here makes it upstream to a 
standard debian deb repo I think its worth a comment pointing that expected 
future out.  As it stands w/o that comment and forgetting we know and trust 
benley, this looks on the face decidedly worse than going straight to the 
gradle source.

specs/debian/aurora-executor.thermos.init (line 22)

This is admittedly all over the place across our packages and OSs already 
before your change, but for the deb scheduler we have 
`/var/run/aurora-scheduler.pid` - how about `/var/run/aurora-observer.pid` or 
`/var/run/thermos-observer.pid`, some consistency here would be useful I think 
for discovery purposes.

specs/debian/aurora-scheduler.postinst (line 38)

`specs/debian/aurora-scheduler.init` uses 
`PIDFILE=/var/run/aurora-scheduler.pid` - who uses `/var/run/aurora/`?

- John Sirois

On Jan. 19, 2016, 5:04 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 5:04 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.postinst 
> 0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 
> 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko



> On Jan. 17, 2016, 10:59 p.m., John Sirois wrote:
> > This built fine for me, and installed fine as well, but the resulting 
> > scheduler has stdout and stderr attached to /dev/null which needs to be 
> > fixed (no logs).  I had a harder time than I might resoning through things 
> > since this setup re-uses the ubuntu init arrangement, but under systemd.  
> > This means systemd generates a unit file on the fly to bridge the sysv 
> > init.  Had you thought about this extra indirection?  It seems like it 
> > would be easier to deal with a direct systemd setup / unit file like the 
> > centos builder has.

Yup, talked offline and now you can see the logs via 'journalctl -u 
aurora-scheduler'. 1,2 fds are no longer going to /dev/null. 

java31858 aurora1u  unix 0x880036c01bc0  0t0 140592 socket
java31858 aurora2u  unix 0x880036c01bc0  0t0 140592 socket

For record keeping, this was done via --no-close option to stop-start-daemon


> On Jan. 17, 2016, 10:59 p.m., John Sirois wrote:
> > builder/deb/debian-jessie/build.sh, line 40
> > 
> >
> > What's this? Cruft to kill?

Done.


- Dmitriy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review114872
---


On Jan. 19, 2016, 11:23 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> ---
> 
> (Updated Jan. 19, 2016, 11:23 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init 
> e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.postinst 
> 0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> ---
> 
> New build with a test that starts a Vagrant and following README should lead 
> to a successful job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/
---

(Updated Jan. 19, 2016, 11:23 p.m.)


Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.


Repository: aurora-packaging


Description
---

Adding debian jessie packaging with a test.


Diffs (updated)
-

  build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
  builder/deb/debian-jessie/Dockerfile PRE-CREATION 
  builder/deb/debian-jessie/build.sh PRE-CREATION 
  builder/deb/debian-jessie/pants.ini PRE-CREATION 
  specs/debian/aurora-executor.thermos.init 
e5c940147f5f0a1842d15be9bb9c44e838bc9af0 
  specs/debian/aurora-executor.thermos.service PRE-CREATION 
  specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
  specs/debian/aurora-scheduler.postinst 
0d019b6ecace73c69c833ff2267fe95e11cf2f8d 
  specs/debian/aurora-scheduler.service PRE-CREATION 
  test/deb/debian-jessie/README.md PRE-CREATION 
  test/deb/debian-jessie/Vagrantfile PRE-CREATION 
  test/deb/debian-jessie/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42387/diff/


Testing
---

New build with a test that starts a Vagrant and following README should lead to 
a successful job.


Thanks,

Dmitriy Shirchenko

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115175
---

Ship it!



src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
(line 178)


This will need some adjustment to keep the improved failure mode introduced 
in https://reviews.apache.org/r/42375/ alive.



src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java (line 47)


Odd blank line whitespace in this interface.



src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java (line 
67)


The defaults aren't applied consistently here, not sometimes at all in the 
Params interfaces above.  Its not important to get this right until the RB that 
takes away the Arg fields though, so I'm fine with reading this change as 
providing some examples of how this will work.  My takeaway , based on optional 
options being - hopefully - the norm, is that The Params methods should either 
return Optional and have no default implementation or else have a default 
implementation.  Non-Optional pure abstract Params should be viewed with mild 
suspicion.


- John Sirois


On Jan. 18, 2016, 5:26 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> ---
> 
> (Updated Jan. 18, 2016, 5:26 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 906b3494ab35e70397927ec13f3d9a814059575c 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  7de8f4cebcda51953e00322caec6ad278951f6b1 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 23d1c120657d5cb9d294a80c63e8a04512d361ca 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
> 735199ac1ab343c24471890aa330d6635c26 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
>  cccee083fc2e5f204c91a9d397beb451d4d9df40 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
>

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Bill Farner



> On Jan. 19, 2016, 8:34 a.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java,
> >  line 178
> > 
> >
> > This will need some adjustment to keep the improved failure mode 
> > introduced in https://reviews.apache.org/r/42375/ alive.

Thanks, rebased and handled.


> On Jan. 19, 2016, 8:34 a.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java, line 47
> > 
> >
> > Odd blank line whitespace in this interface.

Thanks, fixed.


> On Jan. 19, 2016, 8:34 a.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java, 
> > line 67
> > 
> >
> > The defaults aren't applied consistently here, not sometimes at all in 
> > the Params interfaces above.  Its not important to get this right until the 
> > RB that takes away the Arg fields though, so I'm fine with reading this 
> > change as providing some examples of how this will work.  My takeaway , 
> > based on optional options being - hopefully - the norm, is that The Params 
> > methods should either return Optional and have no default implementation or 
> > else have a default implementation.  Non-Optional pure abstract Params 
> > should be viewed with mild suspicion.

I was sleep-deprived on a plane when writing this, but i believe my rationale 
was to use `default` methods minimally in this change.  I intended to use them 
solely in places where tests would otherwise be forced to supply a default (at 
risk of diverging from the true default).

You are right, though, all defaults will be applied this way in the follow-up.  
The `Optional`/`default` decision will be an interesting one, though, so hold 
on to that thought!


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115175
---


On Jan. 18, 2016, 4:26 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> ---
> 
> (Updated Jan. 18, 2016, 4:26 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
>

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115191
---

Ship it!



src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
(line 168)


The comment can go now that this is wrapped in a present Optional which 
guards null.



src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
(line 199)


Refactor flub


- John Sirois


On Jan. 19, 2016, 10:31 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> ---
> 
> (Updated Jan. 19, 2016, 10:31 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 5daafa9234d20dfcfd9a6cc81508836efe39f1f0 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  7de8f4cebcda51953e00322caec6ad278951f6b1 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 23d1c120657d5cb9d294a80c63e8a04512d361ca 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
> 735199ac1ab343c24471890aa330d6635c26 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
>  cccee083fc2e5f204c91a9d397beb451d4d9df40 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 577edcbf362493d577e2f12c876f1dbb9387ad79 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> d569241a59f169eaa9982c3bba7003aa4942f50f 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> 08eb6d6c722950f6bc75c97ce12380eca16e704d 
>   src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
> 4767ef12e6a3c9d7b2d4a2b5be27786518b5b612 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
> cded40ba4981e0ae287b6a24e49523f40674bef9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 2b3ee7bf6f7801c140f921b25f78daf6d320098a 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> ed63a7471d654dcefd2ff24e2e462974883541f2 
>   
>

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

2016-01-19 Thread Bill Farner



> On Jan. 19, 2016, 9:36 a.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java,
> >  line 168
> > 
> >
> > The comment can go now that this is wrapped in a present Optional which 
> > guards null.

Removed.


> On Jan. 19, 2016, 9:36 a.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java,
> >  line 201
> > 
> >
> > Refactor flub

Yeesh, thanks.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115191
---


On Jan. 19, 2016, 9:31 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> ---
> 
> (Updated Jan. 19, 2016, 9:31 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 5daafa9234d20dfcfd9a6cc81508836efe39f1f0 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  7de8f4cebcda51953e00322caec6ad278951f6b1 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 23d1c120657d5cb9d294a80c63e8a04512d361ca 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
> 735199ac1ab343c24471890aa330d6635c26 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
>  cccee083fc2e5f204c91a9d397beb451d4d9df40 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 577edcbf362493d577e2f12c876f1dbb9387ad79 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> d569241a59f169eaa9982c3bba7003aa4942f50f 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> 08eb6d6c722950f6bc75c97ce12380eca16e704d 
>   src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
> 4767ef12e6a3c9d7b2d4a2b5be27786518b5b612 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
> cded40ba4981e0ae287b6a24e49523f40674bef9 
>

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

Re: Review Request 42445: Upgrade pants to 0.0.68.

Re: Review Request 42445: Upgrade pants to 0.0.68.

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

Re: Review Request 42475: Fixup broken jmh benchmarks.

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

Re: Review Request 42387: working version of jessie builds

Re: Review Request 42387: working version of jessie builds

Review Request 42532: Revert "Shim interfaces to preface args system overhaul."

Re: Review Request 42387: working version of jessie builds

Re: Review Request 42387: working version of jessie builds

Re: Review Request 42532: Revert "Shim interfaces to preface args system overhaul."

Re: Review Request 42387: working version of jessie builds

Re: Review Request 42387: working version of jessie builds

Re: Review Request 42387: working version of jessie builds

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

29 matches

Site Navigation

Mail list logo

Footer information