Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-20 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review124044
---



Master (6537581) is red with this patch.
  ./build-support/jenkins/build.sh

   proxy_driver = ProxyDriver()
   with temporary_dir() as checkpoint_root:
 te = AuroraExecutor(
 >   
runner_provider=make_provider(checkpoint_root),
 
sandbox_provider=DefaultTestSandboxProvider())
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:580: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in 
make_provider
 pex_location=thermos_runner_path(),
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 build = True
 
 def thermos_runner_path(build=True):
   if not build:
 return getattr(thermos_runner_path, 'value', 
None)
 
   if not hasattr(thermos_runner_path, 'value'):
 pex_dir = safe_mkdtemp()
 >   assert subprocess.call(["./pants", 
"--pants-distdir=%s" % pex_dir, "binary",
   
"src/main/python/apache/thermos/runner:thermos_runner"]) == 0
 E   assert 1 == 0
 E+  where 1 = (['./pants', '--pants-distdir=/tmp/user/10021/tmpTpBwdT', 
'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
 E+where  = subprocess.call
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: 
AssertionError
 -- Captured stderr call --
 Traceback (most recent call last):
   File 
"/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", 
line 7, in 
 from pants.bin.pants_exe import main
 ImportError: No module named pants.bin.pants_exe
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  16 failed, 640 passed, 5 skipped, 1 warnings, 8 
error in 229.33 seconds 
 
FAILURE


16:58:52 04:53   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 17, 2016, 4:32 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 17, 2016, 4:32 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123965
---


Fix it, then Ship it!




Just one nit from me, otherwise LGTM!


src/main/python/apache/aurora/executor/common/announcer.py (line 60)


This pre-dates your change in this file, but the double underscore for 
'private' fields doesn't match the convention in the rest of the project.  
Please change to single underscore (same for 
`self.__allow_custom_serverset_path`).


- Bill Farner


On March 16, 2016, 12:43 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 16, 2016, 12:43 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/
---

(Updated March 16, 2016, 7:43 p.m.)


Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.


Repository: aurora


Description
---

Allow overriding hostname before announcing 
(https://issues.apache.org/jira/browse/AURORA-1611)


Diffs (updated)
-

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f82858c528808d2a9e77bb56f16e897cfb5bbe73 
  src/main/python/apache/aurora/executor/common/announcer.py 
34e36e0a59093468a8934f58bacb68512949347c 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
f4032c7302f4733ab5670322b1905102c200f1c9 

Diff: https://reviews.apache.org/r/44532/diff/


Testing
---

Tested on vagrant with a wrapper for the executor


Thanks,

Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/
---

(Updated March 18, 2016, 7:04 p.m.)


Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.


Repository: aurora


Description
---

Allow overriding hostname before announcing 
(https://issues.apache.org/jira/browse/AURORA-1611)


Diffs (updated)
-

  RELEASE-NOTES.md 42bb340c492f25286c8c785885132abcbe455296 
  docs/configuration-reference.md e043c4886c6d0fd96646f4687865d1c715cd1c58 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f82858c528808d2a9e77bb56f16e897cfb5bbe73 
  src/main/python/apache/aurora/executor/common/announcer.py 
34e36e0a59093468a8934f58bacb68512949347c 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
f4032c7302f4733ab5670322b1905102c200f1c9 

Diff: https://reviews.apache.org/r/44532/diff/


Testing
---

Tested on vagrant with a wrapper for the executor


Thanks,

Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review124244
---




docs/configuration-reference.md (line 472)


That sounds a little bit like "ip" is a valid value. Using `` 
might make this more clear.


- Stephan Erb


On March 18, 2016, 7:18 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 18, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 42bb340c492f25286c8c785885132abcbe455296 
>   docs/configuration-reference.md e043c4886c6d0fd96646f4687865d1c715cd1c58 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review124076
---


Ship it!




Master (6537581) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 17, 2016, 6:04 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 17, 2016, 6:04 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-18 Thread Bill Farner 


> On March 16, 2016, 6:33 p.m., Bill Farner wrote:
> > Just one nit from me, otherwise LGTM!

Oh, nearly forgot - please add docs!

- Add a small section and blurb here describing how this would be used (i.e. 
write the doc you wish you had read before contributing the patch)
   
https://github.com/apache/aurora/blob/master/docs/configuration-reference.md#announcer-objects
- Add a line to `RELEASE_NOTES.md` about the arg being added, and link to the 
doc section above


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123965
---


On March 16, 2016, 12:43 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 16, 2016, 12:43 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-18 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review124258
---


Ship it!




Master (12be6fb) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 18, 2016, 7:04 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 18, 2016, 7:04 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 42bb340c492f25286c8c785885132abcbe455296 
>   docs/configuration-reference.md e043c4886c6d0fd96646f4687865d1c715cd1c58 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123775
---


Fix it, then Ship it!




Patch looks good, thanks for your patience! Minor nitpick below.


src/test/python/apache/aurora/executor/common/test_announcer.py (line 341)


Those asserts a risky. If you have a typo like `assert_any_callz()` your 
test will pass. 

Could you try to write that one as an explicit assertion using `assert`? 
For example, this could be done via 
https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.mock_calls


- Stephan Erb


On March 15, 2016, 7:31 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 15, 2016, 7:31 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing 
> (https://issues.apache.org/jira/browse/AURORA-1611)
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> f4032c7302f4733ab5670322b1905102c200f1c9 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> Tested on vagrant with a wrapper for the executor
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Kunal Thakar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/
---

(Updated March 15, 2016, 6:31 p.m.)


Review request for Aurora, John Sirois, Stephan Erb, and Bill Farner.


Changes
---

Adding reviewers


Repository: aurora


Description (updated)
---

Allow overriding hostname before announcing 
(https://issues.apache.org/jira/browse/AURORA-1611)


Diffs
-

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f82858c528808d2a9e77bb56f16e897cfb5bbe73 
  src/main/python/apache/aurora/executor/common/announcer.py 
34e36e0a59093468a8934f58bacb68512949347c 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
f4032c7302f4733ab5670322b1905102c200f1c9 

Diff: https://reviews.apache.org/r/44532/diff/


Testing (updated)
---

Tested on vagrant with a wrapper for the executor


Thanks,

Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-15 Thread Kunal Thakar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/
---

(Updated March 15, 2016, 6:29 p.m.)


Review request for Aurora.


Changes
---

Updated as per recommendations to allow overriding hostname without shelling 
out in the executor


Repository: aurora


Description
---

Allow overriding hostname before announcing


Diffs (updated)
-

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f82858c528808d2a9e77bb56f16e897cfb5bbe73 
  src/main/python/apache/aurora/executor/common/announcer.py 
34e36e0a59093468a8934f58bacb68512949347c 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
f4032c7302f4733ab5670322b1905102c200f1c9 

Diff: https://reviews.apache.org/r/44532/diff/


Testing
---


Thanks,

Kunal Thakar

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-14 Thread Bill Farner 


> On March 10, 2016, 2:04 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95
> > 
> >
> > Specifying the command here feels kind of weird. All other options  we 
> > have take the value directly.
> 
> Kunal Thakar wrote:
> Executor arguments are set in stone after starting the scheduler as they 
> are passed to the scheduler through -thermos_executor_flags, so we have to do 
> it this way.
> 
> Stephan Erb wrote:
> Another way to do it would be if you use a wrapper script to launch your 
> Thermos executor. If necessary, you can copy this into the sandbox using the 
> `-thermos_executor_resources` flag. 
> 
> Personally, I would perfer such a solution:
> 
> * It can be used for all options.
> * Thermos does not need to handle the case if the command fails. It is up 
> to the operator writing the wrapper script to handle that case.

+1, a wrapper script superior here as it enables more broad customization 
without the need for piecemeal plumbing from the scheduler.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123011
---


On March 8, 2016, 2:33 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 8, 2016, 2:33 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-13 Thread Stephan Erb 


> On March 10, 2016, 11:04 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95
> > 
> >
> > Specifying the command here feels kind of weird. All other options  we 
> > have take the value directly.
> 
> Kunal Thakar wrote:
> Executor arguments are set in stone after starting the scheduler as they 
> are passed to the scheduler through -thermos_executor_flags, so we have to do 
> it this way.

Another way to do it would be if you use a wrapper script to launch your 
Thermos executor. If necessary, you can copy this into the sandbox using the 
`-thermos_executor_resources` flag. 

Personally, I would perfer such a solution:

* It can be used for all options.
* Thermos does not need to handle the case if the command fails. It is up to 
the operator writing the wrapper script to handle that case.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123011
---


On March 8, 2016, 11:33 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 8, 2016, 11:33 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-10 Thread Kunal Thakar 


> On March 10, 2016, 10:04 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95
> > 
> >
> > Specifying the command here feels kind of weird. All other options  we 
> > have take the value directly.

Executor arguments are set in stone after starting the scheduler as they are 
passed to the scheduler through -thermos_executor_flags, so we have to do it 
this way.


- Kunal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123011
---


On March 8, 2016, 10:33 p.m., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated March 8, 2016, 10:33 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-10 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/#review123011
---




src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 95)


Specifying the command here feels kind of weird. All other options  we have 
take the value directly.


- Stephan Erb


On März 8, 2016, 11:33 nachm., Kunal Thakar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44532/
> ---
> 
> (Updated März 8, 2016, 11:33 nachm.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow overriding hostname before announcing
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> f82858c528808d2a9e77bb56f16e897cfb5bbe73 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 34e36e0a59093468a8934f58bacb68512949347c 
> 
> Diff: https://reviews.apache.org/r/44532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>

Review Request 44532: Allow overriding hostname before announcing

2016-03-08 Thread Kunal Thakar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/
---

Review request for Aurora.


Repository: aurora


Description
---

Allow overriding hostname before announcing


Diffs
-

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
f82858c528808d2a9e77bb56f16e897cfb5bbe73 
  src/main/python/apache/aurora/executor/common/announcer.py 
34e36e0a59093468a8934f58bacb68512949347c 

Diff: https://reviews.apache.org/r/44532/diff/


Testing
---


Thanks,

Kunal Thakar