Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 29, 2015, 1:37 p.m., Stephan Erb wrote: > > Looks like the 3.4 client also requires a 3.4 ZK server [1]. So, would it > > be possible to get a deprecation cycle for that change (i.e., announce in > > 0.12 and bump in 0.13)? > > > > Unfortunately, we are still running our masters on a

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 29, 2015, 12:37 p.m., Stephan Erb wrote: > > Looks like the 3.4 client also requires a 3.4 ZK server [1]. So, would it > > be possible to get a deprecation cycle for that change (i.e., announce in > > 0.12 and bump in 0.13)? > > > > Unfortunately, we are still running our masters on

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/ --- (Updated Jan. 3, 2016, 8:55 p.m.) Review request for Aurora, John Sirois and Za

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/ --- (Updated Jan. 3, 2016, 8:52 p.m.) Review request for Aurora, John Sirois and Za

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112361 --- Ship it! Ship It! - Zameer Manji On Dec. 29, 2015, 9:09 a.m., B

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 29, 2015, 1:37 p.m., Stephan Erb wrote: > > Looks like the 3.4 client also requires a 3.4 ZK server [1]. So, would it > > be possible to get a deprecation cycle for that change (i.e., announce in > > 0.12 and bump in 0.13)? > > > > Unfortunately, we are still running our masters on a

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112193 --- Ship it! Master (80ae5e8) is green with this patch. ./build-supp

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112191 --- Ship it! Meant to mark ship since the code lgtm and my experiments

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 29, 2015, 9:15 a.m., John Sirois wrote: > > The code itself LGTM. It would be great to get another test in that 3.4.2+ > > clients can read and write to 3.3.x servers from folks in the field with > > production zk setups. +1 this would be great data for release notes - Bill

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 29, 2015, 4:37 a.m., Stephan Erb wrote: > > Looks like the 3.4 client also requires a 3.4 ZK server [1]. So, would it > > be possible to get a deprecation cycle for that change (i.e., announce in > > 0.12 and bump in 0.13)? > > > > Unfortunately, we are still running our masters on a

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112187 --- The code itself LGTM. It would be great to get another test in tha

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/ --- (Updated Dec. 29, 2015, 9:09 a.m.) Review request for Aurora, John Sirois and Z

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 28, 2015, 8:12 p.m., Bill Farner wrote: > > > > John Sirois wrote: > I found that by upgrading all the way to 3.4.7 the krb issues go away in > the unit tests (`./gradlew -Pq build`), although e2e krb fails (digging). > Presuming I can find a fix for that (we'll need to upgrade

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 28, 2015, 7:12 p.m., Bill Farner wrote: > > > > John Sirois wrote: > I found that by upgrading all the way to 3.4.7 the krb issues go away in > the unit tests (`./gradlew -Pq build`), although e2e krb fails (digging). > Presuming I can find a fix for that (we'll need to upgrade

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 29, 2015, 8:43 a.m., John Sirois wrote: > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java, > > line 83 > > > > > > '..., max 60 conections is ...' would be an eve

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112169 --- commons/src/main/java/org/apache/aurora/common/zookeeper/testing/Z

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 28, 2015, 8:12 p.m., Bill Farner wrote: > > I found that by upgrading all the way to 3.4.7 the krb issues go away in the unit tests (`./gradlew -Pq build`), although e2e krb fails (digging). Presuming I can find a fix for that (we'll need to upgrade someday) you get a natural state

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

> On Dec. 29, 2015, 5:37 a.m., Stephan Erb wrote: > > Looks like the 3.4 client also requires a 3.4 ZK server [1]. So, would it > > be possible to get a deprecation cycle for that change (i.e., announce in > > 0.12 and bump in 0.13)? > > > > Unfortunately, we are still running our masters on a

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112163 --- Looks like the 3.4 client also requires a 3.4 ZK server [1]. So, wo

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112117 --- Ship it! Master (41c71d9) is green with this patch. ./build-supp

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112116 --- commons/src/main/java/org/apache/aurora/common/zookeeper/testing/Z

Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora D