Re: Review Request 28486: Move sandbox initialization into try block.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63417 --- Can you add test coverage? - Joshua Cohen On Nov. 26, 2014,

Re: Review Request 28486: Move sandbox initialization into try block.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63421 --- src/main/python/apache/aurora/executor/aurora_executor.py

Re: Review Request 28486: Move sandbox initialization into try block.

On Dec. 1, 2014, 11:40 a.m., Kevin Sweeney wrote: src/main/python/apache/aurora/executor/aurora_executor.py, line 132 https://reviews.apache.org/r/28486/diff/2/?file=777033#file777033line132 Should an uncaught Exception be TASK_LOST? presumably specific exceptions from user input

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/ --- (Updated Dec. 1, 2014, 7:46 p.m.) Review request for Aurora, Joshua Cohen and

Review Request 28571: Reject jobs containing an empty cron schedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28571/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs:

Re: Review Request 28449: Fix some URLs and text in release emails to include -incubating where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28449/#review63426 --- Jake - ping? - Bill Farner On Nov. 25, 2014, 9 p.m., Bill Farner

Re: Review Request 28571: Reject jobs containing an empty cron schedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28571/#review63430 --- Ship it! Master (88baad6) is green with this patch.

Re: Review Request 28486: Move sandbox initialization into try block.

On Dec. 1, 2014, 11:40 a.m., Kevin Sweeney wrote: src/main/python/apache/aurora/executor/aurora_executor.py, line 132 https://reviews.apache.org/r/28486/diff/2/?file=777033#file777033line132 Should an uncaught Exception be TASK_LOST? presumably specific exceptions from user input

Review Request 28572: Minimize the state consumed when collecting preemption victims.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-121

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63436 --- Ship it! Master (88baad6) is green with this patch.

Re: Review Request 28486: Move sandbox initialization into try block.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/ --- (Updated Dec. 1, 2014, 2:24 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63446 --- Ship it! Ship It! - Zameer Manji On Dec. 1, 2014, 12:32 p.m.,

Re: Review Request 28486: Move sandbox initialization into try block.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63448 --- Ship it! Master (88baad6) is green with this patch.

Re: Review Request 28486: Move sandbox initialization into try block.

On Dec. 1, 2014, 2:34 p.m., Joshua Cohen wrote: src/main/python/apache/aurora/executor/aurora_executor.py, line 131 https://reviews.apache.org/r/28486/diff/2-3/?file=777033#file777033line131 Outside of tests, what's actually raising this? This exception allows for other

Re: Review Request 28486: Move sandbox initialization into try block.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63450 --- Ship it! Ship It! - Joshua Cohen On Dec. 1, 2014, 10:24 p.m.,

Re: Review Request 28486: Move sandbox initialization into try block.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63452 --- src/main/python/apache/aurora/executor/aurora_executor.py

Re: Review Request 28486: Move sandbox initialization into try block.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/#review63453 --- src/main/python/apache/aurora/executor/aurora_executor.py

Re: Review Request 28486: Move sandbox initialization into try block.

On Dec. 1, 2014, 2:50 p.m., Zameer Manji wrote: src/main/python/apache/aurora/executor/aurora_executor.py, line 131 https://reviews.apache.org/r/28486/diff/3/?file=779344#file779344line131 This makes the code inconsistent with line 141: except

Re: Review Request 28486: Move sandbox initialization into try block.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28486/ --- (Updated Dec. 1, 2014, 3:18 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 28571: Reject jobs containing an empty cron schedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28571/#review63487 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 1, 2014, 8:07

Re: Review Request 28572: Minimize the state consumed when collecting preemption victims.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28572/#review63489 --- Ship it!