Re: Review Request 31418: Add admin port support in mname.

2015-02-25 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/ --- (Updated Feb. 25, 2015, 5:48 p.m.) Review request for Aurora and Bill Farner.

Review Request 31418: Add admin port support in Mname.

2015-02-25 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/ --- Review request for Aurora. Repository: aurora Description --- Add admin

Re: Review Request 31421: Handle TASK_ERROR and TASK_STAGING states.

2015-02-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31421/#review74068 --- Ship it! Master (81641a1) is green with this patch.

Re: Review Request 31418: Add admin port support in mname.

2015-02-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/#review74047 --- Ship it! Ship It! - Bill Farner On Feb. 25, 2015, 5:48 p.m.,

Re: Review Request 31389: Remove LiveClusterState, make CachedClusterState (now ClusterStateImpl) default.

2015-02-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31389/#review74061 --- Ship it! Ship It! - Joshua Cohen On Feb. 25, 2015, 12:01 a.m.,

Re: Review Request 31421: Handle TASK_ERROR and TASK_STAGING states.

2015-02-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31421/#review74055 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 25, 2015, 6:48

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74087 --- Master (895d03b) is green with this patch.

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 8:37 p.m.) Review request for Aurora, Maxim

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74092 --- Master (895d03b) is red with this patch.

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74102 --- @ReviewBot retry The last reply was not for the latest diff. -

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74100 --- Ship it! I think it is logical to shut down the status checkers

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74103 --- lgtm minus a few nits...

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-25 Thread Steve Niemitz
On Feb. 25, 2015, 10:06 p.m., Joshua Cohen wrote: src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java, lines 44-45 https://reviews.apache.org/r/31338/diff/2/?file=876074#file876074line44 this should be unnecessary, we will have thrown on the previous line?

Re: Review Request 31456: Only fetch host attributes once per preemption round.

2015-02-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31456/#review74198 --- Master (9442e08) is green with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-25 Thread Zameer Manji
On Feb. 25, 2015, 5:44 p.m., Brian Wickman wrote: src/main/python/apache/thermos/observer/task_observer.py, line 592 https://reviews.apache.org/r/31451/diff/1/?file=877050#file877050line592 fix this. Brian Wickman wrote: You should definitely be concerned about the current

Re: Review Request 31453: Run python style checks before unit tests in build.sh.

2015-02-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31453/#review74197 --- Ship it! Ship It! - Zameer Manji On Feb. 25, 2015, 5:41 p.m.,

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-25 Thread Steve Niemitz
On Feb. 26, 2015, 3:38 a.m., Joshua Cohen wrote: src/test/python/apache/aurora/executor/test_thermos_executor.py, lines 384-386 https://reviews.apache.org/r/31423/diff/2/?file=877156#file877156line384 You should be able to use contextlib.nested for this: with

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74154 --- Ship it! Master (9442e08) is green with this patch.

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-25 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 25, 2015, 10:35 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Bill Farner
On Feb. 25, 2015, 11:27 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, line 219 https://reviews.apache.org/r/31388/diff/5/?file=876605#file876605line219 Will this be addresed as apart of this effort? It actually is, this

Re: Review Request 31406: Adding possiblity to define the port where the health checker should run on

2015-02-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31406/#review74016 --- Master (4d5885b) is red with this patch.