Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74206 --- src/main/python/apache/thermos/bin/thermos.py

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

> On Feb. 26, 2015, 3:38 a.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/executor/test_thermos_executor.py, lines > > 384-386 > > > > > > You should be able to use contextlib.nested for this: > > > >

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

> On Feb. 26, 2015, 3:38 a.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/executor/test_thermos_executor.py, lines > > 384-386 > > > > > > You should be able to use contextlib.nested for this: > > > >

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74202 --- src/test/python/apache/aurora/executor/test_thermos_executor.py

Re: Review Request 31451: Port thermos observer to the path detector interface

> On Feb. 26, 2015, 1:44 a.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/task_observer.py, line 592 > > > > > > fix this. > > Brian Wickman wrote: > You should definitely be concerned about

Re: Review Request 31456: Only fetch host attributes once per preemption round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31456/#review74198 --- Master (9442e08) is green with this patch. ./build-support/jenkins

Re: Review Request 31453: Run python style checks before unit tests in build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31453/#review74197 --- Ship it! Ship It! - Zameer Manji On Feb. 25, 2015, 5:41 p.m., Bi

Re: Review Request 31451: Port thermos observer to the path detector interface

> On Feb. 25, 2015, 5:44 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/task_observer.py, line 592 > > > > > > fix this. > > Brian Wickman wrote: > You should definitely be concerned about

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74193 --- Ship it! Ship It! - Zameer Manji On Feb. 25, 2015, 5:39 p.m., Bi

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74191 --- Master (9442e08) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74190 --- Ship it! Master (9442e08) is green with this patch. ./build-suppo

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/ --- (Updated Feb. 26, 2015, 2:14 a.m.) Review request for Aurora, Brian Wickman and

Re: Review Request 31456: Only fetch host attributes once per preemption round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31456/#review74189 --- Ship it! Ship It! - Kevin Sweeney On Feb. 25, 2015, 6 p.m., Bill

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74188 --- Master (9442e08) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31456: Only fetch host attributes once per preemption round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31456/#review74187 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 26, 2015, 2 a.m.,

Review Request 31456: Only fetch host attributes once per preemption round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31456/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-11

Re: Review Request 31453: Run python style checks before unit tests in build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31453/#review74186 --- Ship it! Master (9442e08) is green with this patch. ./build-suppo

Re: Review Request 31451: Port thermos observer to the path detector interface

> On Feb. 26, 2015, 1:44 a.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/task_observer.py, line 592 > > > > > > fix this. You should definitely be concerned about the current state of the observ

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated Feb. 26, 2015, 1:50 a.m.) Review request for Aurora, Joe Smith and Zam

Re: Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74184 --- src/main/python/apache/thermos/observer/task_observer.py

Review Request 31453: Run python style checks before unit tests in build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31453/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --

Review Request 31451: Port thermos observer to the path detector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- Review request for Aurora, Joe Smith and Zameer Manji. Bugs: AURORA-1026 ht

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 26, 2015, 1:39 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

> On Feb. 25, 2015, 11:27 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 219 > > > > > > Will this be addresed as apart of this effort? It actuall

Re: Review Request 31445: Expose more details about the tasks the preemptor is working for.

> On Feb. 25, 2015, 10:54 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java, > > line 92 > > > > > > I think some JavaDoc explaining which stats are exported wou

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74154 --- Ship it! Master (9442e08) is green with this patch. ./build-suppo

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

> On Feb. 25, 2015, 11:01 p.m., Maxim Khutornenko wrote: > > This does not seem to address js invocations of the job update APIs. E.g: > > > > https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279 > > https://github.com/apache/incubator

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74142 --- src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStore

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74138 --- Ship it! Master (9442e08) is green with this patch. ./build-suppo

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74134 --- @ReviewBot retry - Steve Niemitz On Feb. 25, 2015, 10:35 p.m., St

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

> On Feb. 25, 2015, 11:01 p.m., Maxim Khutornenko wrote: > > This does not seem to address js invocations of the job update APIs. E.g: > > > > https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279 > > https://github.com/apache/incubator

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 11:04 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74131 --- Master (9442e08) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74129 --- This does not seem to address js invocations of the job update APIs.

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 10:59 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 31445: Expose more details about the tasks the preemptor is working for.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31445/#review74126 --- Ship it! Master (9442e08) is green with this patch. ./build-suppo

Re: Review Request 31445: Expose more details about the tasks the preemptor is working for.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31445/#review74122 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/preemptor

Review Request 31445: Expose more details about the tasks the preemptor is working for.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31445/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-524

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 25, 2015, 10:35 p.m.) Review request for Aurora, Jay Buffington a

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74111 --- Ship it! Looks good to me! I'll let someone a little bit more famil

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74110 --- Master (9442e08) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 25, 2015, 10:30 p.m.) Review request for Aurora, Jay Buffington a

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

> On Feb. 25, 2015, 2:15 p.m., Joshua Cohen wrote: > > Is it worth adding test coverage for this shutdown ordering? I don't think mock allows us to test for order. Steve can you take a quick look and tell us if it is possible? - Zameer ---

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74106 --- Master (9442e08) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 25, 2015, 10:06 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java, lines > > 44-45 > > > > > > this should be unnecessary, we will have thrown on the previous l

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74104 --- Is it worth adding test coverage for this shutdown ordering? - Josh

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74103 --- lgtm minus a few nits... src/test/java/org/apache/aurora/scheduler

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74100 --- Ship it! I think it is logical to shut down the status checkers bef

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74102 --- @ReviewBot retry The last reply was not for the latest diff. - Bil

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/ --- (Updated Feb. 25, 2015, 9:22 p.m.) Review request for Aurora, Brian Wickman and

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/ --- (Updated Feb. 25, 2015, 9:16 p.m.) Review request for Aurora, Brian Wickman and

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74092 --- Master (895d03b) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 8:58 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 25, 2015, 8:37 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74087 --- Master (895d03b) is green with this patch. ./build-support/jenkins

Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/ --- Review request for Aurora. Repository: aurora Description --- Stop the a

Re: Review Request 31421: Handle TASK_ERROR and TASK_STAGING states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31421/#review74068 --- Ship it! Master (81641a1) is green with this patch. ./build-suppo

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74066 --- Ship it! Master (81641a1) is green with this patch. ./build-suppo

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 25, 2015, 7:15 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 31389: Remove LiveClusterState, make CachedClusterState (now ClusterStateImpl) default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31389/#review74061 --- Ship it! Ship It! - Joshua Cohen On Feb. 25, 2015, 12:01 a.m., B

Re: Review Request 31421: Handle TASK_ERROR and TASK_STAGING states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31421/#review74056 --- Ship it! Ship It! - Kevin Sweeney On Feb. 25, 2015, 10:48 a.m.,

Re: Review Request 31421: Handle TASK_ERROR and TASK_STAGING states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31421/#review74055 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 25, 2015, 6:48 p.m

Review Request 31421: Handle TASK_ERROR and TASK_STAGING states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31421/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-10

Re: Review Request 31418: Add admin port support in mname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/#review74047 --- Ship it! Ship It! - Bill Farner On Feb. 25, 2015, 5:48 p.m., Ton

Re: Review Request 31418: Add admin port support in Mname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/#review74039 --- Ship it! Master (4d5885b) is green with this patch. ./build-suppo

Re: Review Request 31418: Add admin port support in mname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/ --- (Updated Feb. 25, 2015, 5:48 p.m.) Review request for Aurora and Bill Farner.

Review Request 31418: Add admin port support in Mname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31418/ --- Review request for Aurora. Repository: aurora Description --- Add admin

Re: Review Request 31406: Adding possiblity to define the port where the health checker should run on

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31406/#review74016 --- Master (4d5885b) is red with this patch. ./build-support/jenkins/b

Review Request 31406: Adding possiblity to define the port where the health checker should run on

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31406/ --- Review request for Aurora. Bugs: AURORA-321 https://issues.apache.org/jira/