Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/#review76692 --- Master (2f99106) is red with this patch.

Re: Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32131/#review76665 --- Master (1b2a343) is green with this patch.

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76667 --- This patch does not apply cleanly on master (1b2a343), do you need

Re: Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32131/#review76684 --- src/main/python/apache/thermos/bin/BUILD

Re: Review Request 32077: Rename beta-update subcommand to update.

2015-03-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32077/ --- (Updated March 17, 2015, 2:24 a.m.) Review request for Aurora, Maxim

Re: Review Request 32106: Changed the updater to not update an instance if only the job owner changes

2015-03-16 Thread Bill Farner
On March 16, 2015, 4:30 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, line 159 https://reviews.apache.org/r/32106/diff/1/?file=895820#file895820line159 There is actually a better place to do this type of action [1]. If not

Re: Review Request 32077: Rename beta-update subcommand to update.

2015-03-16 Thread Bill Farner
On March 16, 2015, 6:22 p.m., Zameer Manji wrote: Pending e2e test results. FYI end-to-end tests pass with this change, _in a fresh vagrant environment_. Existing envorinments will be broken, see details and proposed improvement in AURORA-1204. I will e-mail the dev@ list after

Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32141/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1187

Re: Review Request 32106: Changed the updater to not update an instance if only the job owner changes

2015-03-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32106/#review76568 ---

Re: Review Request 32106: Changed the updater to not update an instance if only the job owner changes

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32106/#review76560 --- Ship it! Master (e11ed5b) is green with this patch.

Review Request 32106: Changed the updater to not update an instance if only the job owner changes

2015-03-16 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32106/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1200

Review Request 32078: Remove the populatedDEPRECATED thrift field.

2015-03-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32078/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Review Request 32077: Rename beta-update subcommand to update.

2015-03-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32077/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs:

Review Request 32114: Fix building on Windows

2015-03-16 Thread Matias Lahti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32114/ --- Review request for Aurora. Repository: aurora Description --- Fix

Re: Review Request 32114: Fix building on Windows

2015-03-16 Thread Matias Lahti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32114/ --- (Updated March 16, 2015, 10:25 a.m.) Review request for Aurora and Bill

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76586 --- @ReviewBot retry - Brian Wickman On March 13, 2015, 7:38 p.m.,

Re: Review Request 32106: Changed the updater to not update an instance if only the job owner changes

2015-03-16 Thread Bill Farner
On March 16, 2015, 4:30 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java, line 159 https://reviews.apache.org/r/32106/diff/1/?file=895820#file895820line159 There is actually a better place to do this type of action [1]. If not

Re: Review Request 32078: Remove the populatedDEPRECATED thrift field.

2015-03-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32078/#review76594 --- Ship it! Ship It! - Joshua Cohen On March 16, 2015, 5:39 p.m.,

Re: Review Request 32077: Rename beta-update subcommand to update.

2015-03-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32077/ --- (Updated March 16, 2015, 5:57 p.m.) Review request for Aurora, Maxim

Re: Review Request 32077: Rename beta-update subcommand to update.

2015-03-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32077/#review76599 --- Ship it! Pending e2e test results. - Zameer Manji On March 16,

Re: Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32131/#review76713 --- Ship it! Ship It! - Joe Smith On March 16, 2015, 3:18 p.m.,

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- (Updated March 16, 2015, 9:47 p.m.) Review request for Aurora, Joe Smith and

Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32131/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-1174

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76658 --- Master (1b2a343) is red with this patch.

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- (Updated March 16, 2015, 10:37 p.m.) Review request for Aurora, Joe Smith and

Review Request 32118: Move creation of auth_module into ThriftAuthModule.

2015-03-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32118/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1201

Re: Review Request 32118: Move creation of auth_module into ThriftAuthModule.

2015-03-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32118/#review76613 --- Ship it! Ship It! - Bill Farner On March 16, 2015, 6:54 p.m.,

Re: Review Request 32078: Remove the populatedDEPRECATED thrift field.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32078/#review76617 --- Ship it! Master (e11ed5b) is green with this patch.

Re: Review Request 32114: Fix building on Windows

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32114/#review76626 --- Ship it! Master (e11ed5b) is green with this patch.

Re: Review Request 32077: Rename beta-update subcommand to update.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32077/#review76608 --- Ship it! Master (e11ed5b) is green with this patch.

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76623 --- Ship it! Master (e11ed5b) is green with this patch.

Re: Review Request 32118: Move creation of auth_module into ThriftAuthModule.

2015-03-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32118/#review76629 --- Ship it! Ship It! - Joshua Cohen On March 16, 2015, 6:54 p.m.,

Re: Review Request 32118: Move creation of auth_module into ThriftAuthModule.

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32118/#review76628 --- Ship it! Master (e11ed5b) is green with this patch.

Re: Review Request 32078: Remove the populatedDEPRECATED thrift field.

2015-03-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32078/#review76632 --- Ship it! Ship It! - Maxim Khutornenko On March 16, 2015, 5:39

Re: Review Request 32077: Rename beta-update subcommand to update.

2015-03-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32077/#review76636 --- Ship it! Ship It! - Maxim Khutornenko On March 16, 2015, 5:57