---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27935/#review61108
---
Ship it!
Ship It!
- Bill Farner
On Nov. 12, 2014, 10:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27902/#review61124
---
@ReviewBot retry
- Bill Farner
On Nov. 12, 2014, 10:38 p.m
d59818e8492869a0f3d7bf94727eba69e1b28033
Diff: https://reviews.apache.org/r/27941/diff/
Testing (updated)
---
Ran locally and it's now picking up reviews needing to be built.
Thanks,
Bill Farner
: https://reviews.apache.org/r/27941/diff/
Testing
---
Thanks,
Bill Farner
this to be an
empty file.
- Bill Farner
On Nov. 13, 2014, 12:01 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27942
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27698/#review61142
---
Ship it!
Ship It!
- Bill Farner
On Nov. 7, 2014, 9:17 p.m
On Nov. 13, 2014, 12:46 a.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/api/scheduler_client.py, line 74
https://reviews.apache.org/r/27698/diff/3/?file=754744#file754744line74
Suggestion (other reviewers feel free to chime in here): instead of
calling the
(),
...
- Bill Farner
On Nov. 13, 2014, 1:12 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/
---
(Updated
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/
---
(Updated Nov. 13, 2014, 1:12 a.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-926
On Nov. 13, 2014, 2:07 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java,
line 93
https://reviews.apache.org/r/27947/diff/1/?file=760831#file760831line93
Given that we're moving from an effective same thread executor to
async, i
ab0d501aac0c187d8fb9791ad43ef586b3aed5e7
Diff: https://reviews.apache.org/r/27828/diff/
Testing
---
Thanks,
Bill Farner
/SnapshotStoreImplTest.java
ab0d501aac0c187d8fb9791ad43ef586b3aed5e7
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
792c9fe58c0990180e4f7cac06f793778164b2fe
Diff: https://reviews.apache.org/r/27828/diff/
Testing
---
Thanks,
Bill Farner
On Nov. 11, 2014, 10:04 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java,
line 283
https://reviews.apache.org/r/27705/diff/1/?file=753245#file753245line283
Can you do this in a SchedulingFilter decorator instead? That way you
/java/org/apache/aurora/scheduler/async/AsyncModule.java
https://reviews.apache.org/r/27757/#comment102286
revert
src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java
https://reviews.apache.org/r/27757/#comment102287
remove
- Bill Farner
On Nov. 8, 2014, 12:06 a.m
like the relevant changes would be in:
src/main/python/apache/aurora/client/cli/standalone_client.py
src/main/python/apache/aurora/client/cli/client.py
- Bill Farner
On Nov. 11, 2014, 2:50 a.m., Zameer Manji wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/#review60886
---
On Nov. 11, 2014, 10:42 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27894/#review60908
---
Ship it!
Ship It!
- Bill Farner
On Nov. 12, 2014, 12:26 a.m
https://reviews.apache.org/r/27848/#comment102299
Is this going to produce some redundant output?
- Bill Farner
On Nov. 11, 2014, 12:58 a.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60918
---
Ship it!
Thanks!
- Bill Farner
On Nov. 11, 2014, 11:11 p.m
--abbrev-commit
commit 148f427
Author: Zameer Manji zma...@twopensource.com
Date: Tue Nov 11 17:29:41 2014 -0800
Bump commons version.
Reviewed at https://reviews.apache.org/r/27894/
```
- Bill Farner
On Nov. 12, 2014, 12:26 a.m., Zameer Manji wrote
://reviews.apache.org/r/27830/diff/
Testing
---
Thanks,
Bill Farner
---
Thanks,
Bill Farner
/27657/
- Bill Farner
On Nov. 6, 2014, 9:28 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27657
p.m.)
Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
Bugs: AURORA-896
https://issues.apache.org/jira/browse/AURORA-896
Repository: aurora
Description
---
Remove stracktrace redirection.
Diffs
-
src/main/python/apache/aurora/client
--abbrev-commit
commit 5b3b751
Author: Zameer Manji zma...@twopensource.com
Date: Mon Nov 10 17:10:41 2014 -0800
Remove stracktrace redirection.
Bugs closed: AURORA-896
Reviewed at https://reviews.apache.org/r/27710/
- Bill Farner
On Nov. 10
78f5f04507d7fe080a1ed5ddda692e52f66cc18d
Diff: https://reviews.apache.org/r/27778/diff/
Testing
---
Thanks,
Bill Farner
-
build-support/python/make-pycharm-virtualenv
0e7b97ef6b0dbb57d38cb991d220806564e6e792
Diff: https://reviews.apache.org/r/27779/diff/
Testing
---
Ran locally.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review60349
---
Ship it!
Ship It!
- Bill Farner
On Nov. 5, 2014, 1:23 a.m
including a
response message when it is necessary allows us to have a client that is not
overly-chatty.
- Bill Farner
On Nov. 7, 2014, 12:30 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/apache/aurora/scheduler/updater/JobUpdaterIT.java
88319ea869589323c4662d4f62b46b2bc964268b
Diff: https://reviews.apache.org/r/27746/diff/
Testing
---
./gradlew build -Pq
./gradlew run
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60404
---
Ship it!
Ship It!
- Bill Farner
On Nov. 6, 2014, 11:40 p.m
---
On Nov. 7, 2014, 10:03 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27746/
---
(Updated Nov. 7, 2014, 10:03 p.m
Thanks,
Bill Farner
Thanks,
Bill Farner
On Nov. 7, 2014, 10:39 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java, line 123
https://reviews.apache.org/r/27746/diff/1/?file=754888#file754888line123
LOG.info(Retrying for ... in ...)
Bill Farner wrote:
Done.
Kevin
/PubsubEventModule.java
https://reviews.apache.org/r/27762/#comment101841
Just to make tests a _bit_ closer to production, consider using
AsyncEventBus with a same-thread executor in this branch.
- Bill Farner
On Nov. 8, 2014, 12:39 a.m., Kevin Sweeney wrote
locally to trigger a build here: https://reviews.apache.org/r/27710/
Thanks,
Bill Farner
/aurora/scheduler/mesos/SchedulerDriverServiceTest.java
11f59c96a3676bd1ed7843ba0b99e7b196a4c98c
Diff: https://reviews.apache.org/r/27772/diff/
Testing
---
Thanks,
Bill Farner
---
Thanks,
Bill Farner
to be printed
twice to
stderr.
Bugs closed: AURORA-793
Reviewed at https://reviews.apache.org/r/27650/
- Bill Farner
On Nov. 6, 2014, 12:02 a.m., Zameer Manji wrote
/27630/
- Bill Farner
On Nov. 5, 2014, 6:16 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27630
On Nov. 4, 2014, 7:54 p.m., Bill Farner wrote:
Ship It!
Thanks! This is now on master:
$ git log -1 origin/master
commit 5250a94da3b8f7ea72f6014fb586a1c06ecd83c1
Author: Joshua Cohen jco...@twopensource.com
Date: Thu Nov 6 12:49:52 2014 -0800
Replace
generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/
---
(Updated Nov. 5, 2014, 1:23 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-825
https://issues.apache.org/jira/browse
---
On Nov. 5, 2014, 6:04 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542
/27542/diff/
Testing
---
Thanks,
Bill Farner
src/test/python/apache/thermos/core/test_helper.py
fe368ff4ecb22f1d99024117c6b944c64f86b8ff
Diff: https://reviews.apache.org/r/27628/diff/
Testing
---
Thanks,
Bill Farner
., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/
---
(Updated Nov. 3, 2014, 10:11 p.m.)
Review request
/log/WriteAheadStorageTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/27542/diff/
Testing
---
Thanks,
Bill Farner
/27591/
- Bill Farner
On Nov. 5, 2014, 2:52 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27591
/r/27628/#review5
---
On Nov. 5, 2014, 5:58 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27628
/27586/
- Bill Farner
On Nov. 5, 2014, 3:34 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586
8a0d48bd45e2a77d4024e66ae20d64213df72227
src/test/python/apache/thermos/core/test_helper.py
fe368ff4ecb22f1d99024117c6b944c64f86b8ff
Diff: https://reviews.apache.org/r/27628/diff/
Testing
---
Thanks,
Bill Farner
/test_status_manager.py
8a0d48bd45e2a77d4024e66ae20d64213df72227
src/test/python/apache/thermos/core/test_helper.py
fe368ff4ecb22f1d99024117c6b944c64f86b8ff
Diff: https://reviews.apache.org/r/27628/diff/
Testing
---
Thanks,
Bill Farner
/test_status_manager.py
8a0d48bd45e2a77d4024e66ae20d64213df72227
src/test/python/apache/thermos/core/test_helper.py
fe368ff4ecb22f1d99024117c6b944c64f86b8ff
Diff: https://reviews.apache.org/r/27628/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27598/#review60081
---
Ship it!
Ship It!
- Bill Farner
On Nov. 5, 2014, 1:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27545/#review59814
---
Ship it!
Ship It!
- Bill Farner
On Nov. 3, 2014, 11:09 p.m
://reviews.apache.org/r/27467/#review59680
---
On Nov. 3, 2014, 10:46 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
bot? Stinks
that we still have to do this, but it's good to shoot for a green reply.
- Bill Farner
On Nov. 4, 2014, 9:39 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
will no longer
catch missing case coverage, and we have to expose the internal detail of this
map. Instead, the unit test should self-check to make sure that it is
exercising all transaction operation types.
- Bill Farner
On Nov. 4, 2014, 11:10 p.m., Maxim Khutornenko wrote
On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote:
I'm not a fan of the refactor. For one, static analysis tools will no
longer catch missing case coverage, and we have to expose the internal
detail of this map. Instead, the unit test should self-check to make sure
/
---
(Updated Nov. 5, 2014, 2:52 a.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-854
https://issues.apache.org/jira/browse/AURORA-854
Repository: aurora
Description
---
Remove --bind-var for cron deschedule.
Diffs
Description
---
Optionally ignore unknown transaction operations.
Diffs
-
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
ec9ccfd37ad6f4b8b478498d30e0e5a9e9b8576e
Diff: https://reviews.apache.org/r/27538/diff/
Testing
---
Working on a test now.
Thanks,
Bill
/KillRetryTest.java
PRE-CREATION
src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java
1688a339a1a9c4072d7f834963cb5ccad6fe0736
Diff: https://reviews.apache.org/r/27467/diff/
Testing
---
Thanks,
Bill Farner
after committing.
- Bill Farner
On Nov. 3, 2014, 9:59 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27541
094d1c66e1f464687e0416bc652dba4b1bda0f7e
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/27542/diff/
Testing
---
Thanks,
Bill Farner
/scheduler/storage/log/WriteAheadStorage.java
094d1c66e1f464687e0416bc652dba4b1bda0f7e
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/27542/diff/
Testing
---
Thanks,
Bill Farner
/KillRetryTest.java
PRE-CREATION
src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java
1688a339a1a9c4072d7f834963cb5ccad6fe0736
Diff: https://reviews.apache.org/r/27467/diff/
Testing
---
Thanks,
Bill Farner
---
On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371
. 30, 2014, 5:09 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/
---
(Updated Oct. 30, 2014, 5:09 a.m
, 2014, 5:09 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/
---
(Updated Oct. 30, 2014, 5:09 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27375/#review59237
---
On Oct. 30, 2014, 6:02 a.m., Bill Farner wrote
/diff/
Testing
---
Thanks,
Bill Farner
958f60c9d804af4c915a53ccdaf489a91ee284c7
src/main/java/org/apache/aurora/scheduler/http/QuitCallback.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/QuitCallbackTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/27375/diff/
Testing
---
Thanks,
Bill Farner
://reviews.apache.org/r/27364/#comment100486
Double-check the license header, we don't include the year.
- Bill Farner
On Oct. 30, 2014, 1:06 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit
.
AFAICT you'll get to remove some private helpers from this class, and this
loop becomes more concise:
```java
Resources sum = Resources.NONE; // Need to create this
for (..) {
sum = Resources.sum(sum, Resources.from(task));
}
```
- Bill Farner
On Oct. 29, 2014, 12
--abbrev-commit
commit 6b30cf7
Author: Zameer Manji zma...@twopensource.com
Date: Wed Oct 29 14:56:43 2014 -0700
Make executor overhead configurable via CLI.
Bugs closed: AURORA-830
Reviewed at https://reviews.apache.org/r/27309/
- Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27352/#review59067
---
Ship it!
Ship It!
- Bill Farner
On Oct. 29, 2014, 10:21 p.m
://reviews.apache.org/r/27357/diff/
Testing
---
Rendered at
https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_binary_files/docs/test-resource-generation.md
Thanks,
Bill Farner
,
Bill Farner
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java
90c8c065adc4329894e99946a8f494ac3e35629b
src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java
PRE-CREATION
Diff: https://reviews.apache.org/r/27365/diff/
Testing
---
Thanks,
Bill Farner
/scheduler/testing/FakeStatsProvider.java
273129eb1f00ed8e116fba405e5db6a5a6170a8b
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
61b6b8e872120a0106141f9fd7527d71d282624d
Diff: https://reviews.apache.org/r/27371/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27266/#review58822
---
Ship it!
Ship It!
- Bill Farner
On Oct. 28, 2014, 3:23 a.m
/
---
(Updated Oct. 28, 2014, 1:43 a.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-899
https://issues.apache.org/jira/browse/AURORA-899
Repository: aurora
Description
---
Adding missing JobConfiguration
/StorageBackfill.java
https://reviews.apache.org/r/27262/#comment99984
Is the cargo cult of the code below necessary?
- Bill Farner
On Oct. 28, 2014, 1:43 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
/StorageBackfill.java
https://reviews.apache.org/r/27262/#comment99987
Can you fully centralize the backfill and the counter increment?
void populateJobKey(TaskConfig config) {
if job key is valid:
fill job key
increment counter
}
- Bill Farner
On Oct
On Oct. 28, 2014, 5:30 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java,
line 129
https://reviews.apache.org/r/27262/diff/2/?file=735497#file735497line129
Can you fully centralize the backfill and the counter increment
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/#review58851
---
Ship it!
Ship It!
- Bill Farner
On Oct. 28, 2014, 5:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27262/#review58861
---
Ship it!
- Bill Farner
On Oct. 28, 2014, 8:26 p.m., Maxim
https://reviews.apache.org/r/27289/#comment100014
What is the deprecation? Can you point to a ticket?
- Bill Farner
On Oct. 28, 2014, 8:41 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review58896
---
Ship it!
Ship It!
- Bill Farner
On Oct. 28, 2014, 8:57 p.m
, 8:57 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-830
https://issues.apache.org/jira/browse/AURORA-830
Repository: aurora
Description
---
Make executor overhead configurable via CLI.
Diffs
-
src/main/java/org/apache/aurora/scheduler
---
Fix minor discrepancies in RC script.
Diffs
-
build-support/release/release-candidate
02223362d31485c43cbad6fd66b6cfd10aa02c7b
Diff: https://reviews.apache.org/r/27316/diff/
Testing
---
Thanks,
Bill Farner
Sweeney.
Repository: aurora
Description
---
Fix minor discrepancies in RC script.
Diffs (updated)
-
build-support/release/release-candidate
02223362d31485c43cbad6fd66b6cfd10aa02c7b
Diff: https://reviews.apache.org/r/27316/diff/
Testing
---
Thanks,
Bill Farner
.
Thanks,
Bill Farner
---
Thanks,
Bill Farner
---
On Oct. 27, 2014, 9:55 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27249
---
Thanks,
Bill Farner
On Oct. 22, 2014, 10:07 p.m., Bill Farner wrote:
config/legacy_untested_classes.txt, line 9
https://reviews.apache.org/r/27044/diff/1/?file=728771#file728771line9
In the interest of this file being delete only, can you bite the bullet
and create a unit test to cover
/ResourceSlotFactory.java
https://reviews.apache.org/r/27044/#comment99888
newline above
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java
https://reviews.apache.org/r/27044/#comment99889
fits on one line
- Bill Farner
On Oct. 27, 2014, 11:03 p.m., Zameer Manji wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58299
---
On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote
501 - 600 of 1375 matches
Mail list logo
