Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55349 --- Ship it! Great catch! The is_set got lost there via multiple

Re: Review Request 26300: Don't kill GC Executor after period of inactivity

2014-10-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26300/#review55350 --- Ship it! Ship It! - Brian Wickman On Oct. 3, 2014, 1:59 a.m.,

Re: Review Request 26269: Remove UI from page titles.

2014-10-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26269/#review55351 --- David - ping? - Bill Farner On Oct. 2, 2014, 3:48 p.m., Bill

Re: Review Request 26098: Fix checkstyle and add checkstyle back to jenkins.

2014-10-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26098/#review55352 --- Ship it! Thanks! - Bill Farner On Oct. 3, 2014, 4:38 p.m.,

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review55353 --- Anything left to do here before Kevin commits? - Bill Farner On

Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-780

Re: Review Request 26298: Use a less broad retry loop for RPCs.

2014-10-03 Thread Bill Farner
On Oct. 3, 2014, 12:21 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/scheduler_client.py, line 286 https://reviews.apache.org/r/26298/diff/1/?file=713279#file713279line286 Why not just add a break into the Exception catcher instead? Maxim Khutornenko

Re: Review Request 26298: Use a less broad retry loop for RPCs.

2014-10-03 Thread Bill Farner
On Oct. 3, 2014, 12:21 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/scheduler_client.py, line 286 https://reviews.apache.org/r/26298/diff/1/?file=713279#file713279line286 Why not just add a break into the Exception catcher instead? Maxim Khutornenko

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-10-03 Thread Joshua Cohen
On Oct. 3, 2014, 4:43 p.m., Bill Farner wrote: Anything left to do here before Kevin commits? Nope, he tried to commit but was blocked by checkstyle flagging 3rdparty python (https://issues.apache.org/jira/browse/AURORA-780). I sent a review out to address that this morning, so once that

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 5:55 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55371 --- Looks great- thanks!

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55370 --- Ship it! src/main/python/apache/thermos/core/helper.py

Review Request 26324: Increase timeout for PyPI HTTP fetches.

2014-10-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 26328: Add aurora update list and aurora update status commands.

2014-10-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 3, 2014, 4:47 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 26328: Add aurora update list and aurora update status commands.

2014-10-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55390 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 26328: Add aurora update list and aurora update status commands.

2014-10-03 Thread Zameer Manji
On Oct. 3, 2014, 1:56 p.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 434 https://reviews.apache.org/r/26328/diff/1/?file=713687#file713687line434 I think we should put an ISO formatted date like

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

2014-10-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55402 --- Pinging Kevin for final ship it and commit. - Zameer Manji On

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55404 --- Kevin, Mark - ping? - Bill Farner On Oct. 3, 2014, 4:52 a.m.,

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55405 --- src/test/python/apache/aurora/client/cli/test_api_from_cli.py

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Brian Wickman
On Oct. 3, 2014, 6:17 p.m., Joe Smith wrote: src/test/python/apache/thermos/core/test_helper.py, line 33 https://reviews.apache.org/r/25972/diff/2/?file=713532#file713532line33 from psutil._common import puids Looks like I wasn't using this at all, so dropped entirely. - Brian

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Brian Wickman
On Oct. 3, 2014, 6:18 p.m., Kevin Sweeney wrote: src/main/python/apache/thermos/core/helper.py, line 157 https://reviews.apache.org/r/25972/diff/2/?file=713528#file713528line157 Should we log.debug on the absence of uid from the checkpoint record? Sure, won't hurt. - Brian

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 10:16 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55410 --- Ship it! Ship It! - Joe Smith On Oct. 3, 2014, 3:16 p.m., Brian

Review Request 26333: Add exit status contract between thermos runner and aurora executor.

2014-10-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/ --- Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175

Re: Review Request 26333: Add exit status contract between thermos runner and aurora executor.

2014-10-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/#review55413 --- Hmm, I might have prematurely sent this review. I think this will

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 3, 2014, 11:25 p.m.) Review request for Aurora, Kevin Sweeney