Re: Review Request 26328: Add aurora update list and aurora update status commands.

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55493 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Oct. 6, 2014, 9:16 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

2014-10-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review55511 --- *ping* Kevin. - Joshua Cohen On Oct. 3, 2014, 4:51 p.m., Joshua

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review55512 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 26137: Fix help for new update command.

2014-10-06 Thread Joe Smith
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote: src/main/python/apache/aurora/client/cli/update.py, line 45 https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45 Could you update a test case to catch accessing these as properties to catch accidental regressions?

Review Request 26372: Update as property

2014-10-06 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/ --- Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer Manji.

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review55520 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 7:57 a.m.,

Re: Review Request 26372: Update as property

2014-10-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55521 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 9:55 a.m.,

Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output

2014-10-06 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/ --- (Updated Oct. 6, 2014, 9:58 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55522 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55527 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 6, 2014, 12:58

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Maxim Khutornenko
On Oct. 6, 2014, 5:12 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/context.py, line 131 https://reviews.apache.org/r/26288/diff/1/?file=712783#file712783line131 When I wrote code that did that check, Bill specifically told me to remove it, because

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55531 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55537 --- thanks, build-support/jenkins/build.sh passed, going to merge to

Re: Review Request 26333: Add exit status contract between thermos runner and aurora executor.

2014-10-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/ --- (Updated Oct. 6, 2014, 6:12 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output

2014-10-06 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55540 --- Ship it! Ship It! - David McLaughlin On Oct. 6, 2014, 4:58

Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output

2014-10-06 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55542 --- Ship it! Ship It! - David McLaughlin On Oct. 6, 2014, 4:58

Re: Review Request 26328: Improve handling of unknown errors in the aurora client.

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 6, 2014, 2:54 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 26328: Improve handling of unknown errors in the aurora client.

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 6, 2014, 2:55 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.

2014-10-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/#review55548 --- Ship it! build-support/jenkins/build.sh

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-06 Thread Mark Chu-Carroll
On Sept. 24, 2014, 6:28 p.m., David McLaughlin wrote: What was the rationale for hiding update IDs from the user and making job key the parameter for update status? It's nice you can quickly see if a job key has an update in progress.. but what happens if you're wanting to see a

Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.

2014-10-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- (Updated Oct. 6, 2014, 12:02 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-06 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review2 --- src/test/python/apache/aurora/client/cli/test_supdate.py

Re: Review Request 26375: Disable flaky test

2014-10-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26375/ --- (Updated Oct. 6, 2014, 12:04 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 26328: Improve handling of unknown errors in the aurora client.

2014-10-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review3 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 11:55 a.m.,

Review Request 26375: Disable flaky test

2014-10-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26375/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.

2014-10-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/#review5 --- Ship it! Ship It! - Kevin Sweeney On Oct. 6, 2014, 12:02 p.m.,

Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/ --- Review request for Aurora. Bugs: AURORA-774

Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/ --- (Updated Oct. 6, 2014, 7:10 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Oct. 6, 2014, 3:30 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-06 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review55564 --- Ship it! Ship It! - David McLaughlin On Oct. 6, 2014, 7:30

Review Request 26378: Upgrade to pants 0.0.24

2014-10-06 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/ --- Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.

Re: Review Request 26378: Upgrade to pants 0.0.24

2014-10-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/#review55566 --- Ship it! The big win we are getting from this is the repo wide

Re: Review Request 26378: Upgrade to pants 0.0.24

2014-10-06 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/ --- (Updated Oct. 6, 2014, 12:53 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 26375: Disable flaky test

2014-10-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26375/#review55569 --- Ship it! Ship It! - Bill Farner On Oct. 6, 2014, 7:04 p.m.,

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55570 --- Kevin, Mark - ping? - Bill Farner On Oct. 4, 2014, 5:55 p.m.,

Review Request 26383: Health Check Disabler

2014-10-06 Thread David Pan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji.

Review Request 26388: Build break fix.

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26388/ --- Review request for Aurora. Repository: aurora Description --- The

Re: Review Request 26388: Build break fix.

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26388/ --- (Updated Oct. 6, 2014, 10:01 p.m.) Review request for Aurora and Mark

Re: Review Request 26383: Health Check Disabler

2014-10-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55592 --- docs/configuration-reference.md

Re: Review Request 26378: Upgrade to pants 0.0.24

2014-10-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/#review55595 --- Ship it! Ship It! - Joshua Cohen On Oct. 6, 2014, 7:53 p.m.,

Re: Review Request 26388: Build break fix.

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26388/#review55602 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 6, 2014, 6:01

Review Request 26391: Remove special casing of 'rack' attribute.

2014-10-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26391/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-662

Re: Review Request 26391: Remove special casing of 'rack' attribute.

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26391/#review55606 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 6, 2014, 11:21

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 6, 2014, 11:40 p.m.) Review request for Aurora and Mark

Review Request 26394: Deprecating Identity struct (renaming fields).

2014-10-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26394/ --- Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Bill Farner.

Re: Review Request 26378: Upgrade to pants 0.0.24

2014-10-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/#review55613 --- Ship it! Ship It! - Brian Wickman On Oct. 6, 2014, 7:53 p.m.,