---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62573
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 21, 2014, 5:20 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62574
---
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/#review62577
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/
---
(Updated Nov. 21, 2014, 6:28 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/#review62585
---
Master (ada97bd) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62575
---
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62589
---
Bill, since you were the last commiter to give a shipit can you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/#review62590
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review62591
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 20, 2014, 11:43 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/#review62596
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 21, 2014, 10:28 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/#review62594
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 21, 2014, 6:28 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review62604
---
update or discard?
- Kevin Sweeney
On Oct. 24, 2014, 5:12 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28306/#review62606
---
Does this code have test coverage? I can't see any tests that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28272/#review62607
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 21, 2014, 1:29
On Nov. 21, 2014, 11:34 a.m., David McLaughlin wrote:
Does this code have test coverage? I can't see any tests that validate
chunking is performing in the intended way.
Existing test coverage in LogManagerTest validates the on-disk chunked format
is the same. This is only a refactor to
On Nov. 21, 2014, 10:10 a.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
lines 407-414
https://reviews.apache.org/r/28193/diff/2/?file=772028#file772028line407
Inline this?
Inlining causes the constructor call to be unreadable.
On Nov. 21, 2014, 7:34 p.m., David McLaughlin wrote:
Does this code have test coverage? I can't see any tests that validate
chunking is performing in the intended way.
Kevin Sweeney wrote:
Existing test coverage in LogManagerTest validates the on-disk chunked
format is the same.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/
---
(Updated Nov. 21, 2014, 7:42 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/#review62613
---
This patch does not apply cleanly on master (b6217df), do you need
On Nov. 21, 2014, 10:10 a.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 170-171
https://reviews.apache.org/r/28193/diff/2/?file=772029#file772029line170
It doesn't look like there's a test case for this scenario, can you add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/
---
Review request for Aurora, Bhuvan Arumugam, Joshua Cohen, and Maxim Khutornenko.
On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
line 196
https://reviews.apache.org/r/28193/diff/2/?file=772028#file772028line196
This is only used in tests outside of this class. Consider reverting to
On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
line 406
https://reviews.apache.org/r/28193/diff/2/?file=772028#file772028line406
+1 on moving it closer to its only consumer. That's a general guideline
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/#review62620
---
Master (b6217df) is red with this patch.
On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line
94
https://reviews.apache.org/r/28193/diff/2/?file=772029#file772029line94
Why not MIN_EXECUTOR_RESOURCES? We normally abstract out from the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62623
---
examples/docker/Dockerfile
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---
(Updated Nov. 21, 2014, 12:28 p.m.)
Review request for Aurora, Maxim
On Nov. 21, 2014, 6:48 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/async/Preemptor.java, line 301
https://reviews.apache.org/r/28310/diff/3/?file=772285#file772285line301
newline?
Bill Farner wrote:
Not sure what you're requesting here. Where
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/#review62629
---
While you're doing this reshuffle, we really should move
On Nov. 21, 2014, 6:48 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/async/Preemptor.java, line 301
https://reviews.apache.org/r/28310/diff/3/?file=772285#file772285line301
newline?
Bill Farner wrote:
Not sure what you're requesting here. Where
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---
(Updated Nov. 21, 2014, 12:34 p.m.)
Review request for Aurora, Maxim
On Nov. 21, 2014, 6:41 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
line 196
https://reviews.apache.org/r/28193/diff/2/?file=772028#file772028line196
This is only used in tests outside of this class. Consider reverting to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62634
---
Master (b6217df) is red with this patch.
On Nov. 21, 2014, 7:34 p.m., David McLaughlin wrote:
Does this code have test coverage? I can't see any tests that validate
chunking is performing in the intended way.
Kevin Sweeney wrote:
Existing test coverage in LogManagerTest validates the on-disk chunked
format is the same.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/#review62636
---
Ship it!
lgtm pending green build.
- Joshua Cohen
On Nov. 21,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/#review62637
---
Ship it!
it also makes thermos_runner.pex 566k instead of 70MB -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28306/#review62639
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 21, 2014, 1:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/
---
(Updated Nov. 21, 2014, 9:09 p.m.)
Review request for Aurora, Maxim
On Nov. 19, 2014, 10:32 a.m., Zameer Manji wrote:
examples/docker/Dockerfile, line 13
https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line13
Since we are not checking out a specific version this will break once
aurora updates to a new version of mesos and the
On Nov. 21, 2014, 8:30 p.m., Bill Farner wrote:
While you're doing this reshuffle, we really should move apache.thermos.*
to apache.aurora.thermos.*.
Care to elaborate? Why this approach vs the other extreme of just pulling it
out entirely.
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/#review62645
---
@ReviewBot retry
- Brian Wickman
On Nov. 21, 2014, 7:52 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27492/#review62646
---
Looks like master has drifted from this patch, please update or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/#review62648
---
Master (6f92724) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/
---
(Updated Nov. 21, 2014, 10:10 p.m.)
Review request for Aurora, Bhuvan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62658
---
On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java,
line 406
https://reviews.apache.org/r/28193/diff/2/?file=772028#file772028line406
+1 on moving it closer to its only consumer. That's a general guideline
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---
(Updated Nov. 21, 2014, 2:16 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28345/#review62664
---
Ship it!
Master (91accd6) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62666
---
Master (91accd6) is red with this patch.
On Nov. 21, 2014, 12:30 p.m., Bill Farner wrote:
While you're doing this reshuffle, we really should move apache.thermos.*
to apache.aurora.thermos.*.
Brian Wickman wrote:
Care to elaborate? Why this approach vs the other extreme of just
pulling it out entirely.
Presumably
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62673
---
Ship it!
Master (ecc3fbc) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/
---
Review request for Aurora, David McLaughlin and Bill Farner.
Bugs: AURORA-921
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/#review62676
---
docs/cron-jobs.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/#review62675
---
docs/cron-jobs.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/#review62679
---
src/test/python/apache/aurora/client/cli/test_cron.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62681
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 21, 2014, 10:50 p.m.,
On Nov. 21, 2014, 11:26 p.m., Kevin Sweeney wrote:
docs/cron-jobs.md, line 89
https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89
Hold on a sec - why do we have this and cron schedule (see above)?
The cron replace is an atomic convenience command for cron
On Nov. 21, 2014, 11:34 p.m., David McLaughlin wrote:
src/test/python/apache/aurora/client/cli/test_cron.py, lines 199-215
https://reviews.apache.org/r/28350/diff/1/?file=772866#file772866line199
This is an integration test. Can we replace this with a more
fine-grained unit test
On Nov. 21, 2014, 11:32 p.m., Bill Farner wrote:
src/test/python/apache/aurora/client/cli/test_cron.py, lines 218-227
https://reviews.apache.org/r/28350/diff/1/?file=772866#file772866line218
This block is repeated ~verbatim 4x in this file. Cleaning up the
underlying code to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/
---
(Updated Nov. 22, 2014, 12:54 a.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/#review62693
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 22, 2014, 12:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62694
---
Ship it!
Ship It!
- Maxim Khutornenko
On Nov. 21, 2014, 10:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62696
---
On master now.
- Maxim Khutornenko
On Nov. 21, 2014, 10:50 p.m.,
On Nov. 21, 2014, 3:26 p.m., Kevin Sweeney wrote:
docs/cron-jobs.md, line 89
https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89
Hold on a sec - why do we have this and cron schedule (see above)?
Maxim Khutornenko wrote:
The cron replace is an atomic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/#review62700
---
Ship it!
Master (a431b1d) is green with this patch.
On Nov. 21, 2014, 11:26 p.m., Kevin Sweeney wrote:
docs/cron-jobs.md, line 89
https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89
Hold on a sec - why do we have this and cron schedule (see above)?
Maxim Khutornenko wrote:
The cron replace is an atomic
On Nov. 21, 2014, 11:26 p.m., Kevin Sweeney wrote:
docs/cron-jobs.md, line 89
https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89
Hold on a sec - why do we have this and cron schedule (see above)?
Maxim Khutornenko wrote:
The cron replace is an atomic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28360/
---
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/
---
Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62716
---
This patch does not apply cleanly on master (a431b1d), do you need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28360/#review62717
---
Ship it!
Master (a431b1d) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62718
---
build-support/thrift/thriftw
72 matches
Mail list logo
