Review Request 29940: Paginate when necessary in review bot.

2015-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/ --- Review request for Aurora and Steve Niemitz. Bugs: AURORA-1018

Re: Review Request 29940: Paginate when necessary in review bot.

2015-01-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/#review68291 --- Ship it! Any reason why the times in the output seem to be off by

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68267 --- Master (a350982) is red with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68260 --- Master (a350982) is red with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68247 --- Master (a350982) is red with this patch.

Re: Review Request 29940: Paginate when necessary in review bot.

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/#review68298 --- Ship it! Master (a350982) is green with this patch.

Re: Review Request 29873: Fixing batched kill task filtering.

2015-01-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/ --- (Updated Jan. 15, 2015, 7:44 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 29940: Paginate when necessary in review bot.

2015-01-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/#review68299 --- Ship it! Ship It! - Zameer Manji On Jan. 15, 2015, 11:21 a.m.,

Re: Review Request 29873: Fixing batched kill task filtering.

2015-01-15 Thread Maxim Khutornenko
On Jan. 14, 2015, 7:27 p.m., Bill Farner wrote: src/test/python/apache/aurora/client/cli/test_kill.py, line 146 https://reviews.apache.org/r/29873/diff/1/?file=820323#file820323line146 While you're in here, can you take a stab at renaming `create_mock_task` to `create_task`, and

Re: Review Request 29915: Ensure TaskStateChange event emitted by StateManagerImpl has valid data.

2015-01-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29915/ --- (Updated Jan. 15, 2015, 1:32 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 29940: Paginate when necessary in review bot.

2015-01-15 Thread Bill Farner
On Jan. 15, 2015, 6:55 p.m., Joshua Cohen wrote: Any reason why the times in the output seem to be off by 2 minutes? (i.e. it says last diff was at 20:18, but looking at the review it was actually at 20:20?) Great question. These are two different timestamps. One is for the diff

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 15, 2015, 8:24 p.m.) Review request for Aurora, Jay Buffington,

Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68328 --- Ship it! Since git maintenance is currently underway, i cannot

Re: Review Request 29940: Paginate when necessary in review bot.

2015-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/ --- (Updated Jan. 15, 2015, 7:21 p.m.) Review request for Aurora, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68301 --- Ship it! Master (a350982) is green with this patch.

Re: Review Request 29915: Ensure TaskStateChange event emitted by StateManagerImpl has valid data.

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29915/#review68349 --- Ship it! Master (1acb428) is green with this patch.

Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-15 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/ --- (Updated Jan. 15, 2015, 11:36 p.m.) Review request for Aurora and Kevin

Re: Review Request 29873: Fixing batched kill task filtering.

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/#review68344 --- Ship it! Master (1acb428) is green with this patch.

Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68345 --- This patch does not apply cleanly on master (1acb428), do you need

Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Joshua Cohen
On Jan. 15, 2015, 11:59 p.m., Aurora ReviewBot wrote: This patch does not apply cleanly on master (b75ed0f), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry I don't know what your deal is ReviewBot, it applied cleanly for

Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-15 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/ --- (Updated Jan. 16, 2015, 12:11 a.m.) Review request for Aurora and Kevin

Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/#review68368 --- Mind adding another committer with more recent mock experience to

Re: Review Request 29873: Fixing batched kill task filtering.

2015-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/#review68329 --- Ship it! src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68350 --- Master (1acb428) is red with this patch.

Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:58 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/#review68364 --- Master (b75ed0f) is red with this patch.

Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68365 --- This patch does not apply cleanly on master (b75ed0f), do you need

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 16, 2015, 12:08 a.m.) Review request for Aurora, Jay Buffington,

Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-15 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/ --- (Updated Jan. 16, 2015, 12:51 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/#review68378 --- Ship it! Master (b75ed0f) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68237 --- Ship it! Master (a350982) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68232 --- Ship it! Master (a350982) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68223 --- Master (a350982) is red with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68239 --- Master (a350982) is red with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68241 --- Ship it! Master (a350982) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68245 --- Ship it! Master (a350982) is green with this patch.

Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68307 --- Ship it! Ship It! - Kevin Sweeney On Jan. 15, 2015, 11:56 a.m.,

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68377 --- Ship it! Master (b75ed0f) is green with this patch.