Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

2015-01-26 Thread Bill Farner
On Jan. 26, 2015, 5:29 p.m., Dave Lester wrote: Were you able to test this patch on GitHub? I just tried applying this to my own GitHub account's Aurora repo (https://github.com/davelester/incubator-aurora) and used a second GH account to simulate this interaction, but never saw the

Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

2015-01-26 Thread Jeffrey Schroeder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/ --- (Updated Jan. 26, 2015, 6:53 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30204: Upgrade to rbt=0.7.0.

2015-01-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30204/#review69653 --- Ship it! Ship It! - Kevin Sweeney On Jan. 22, 2015, 6:11 p.m.,

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review69663 --- src/main/python/apache/aurora/common/clusters.py

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Bill Farner
On Jan. 26, 2015, 8:16 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/common/clusters.py, line 42 https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42 For the purposes of sheparding this review along would you consider moving this to another change?

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

2015-01-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30203/ --- (Updated Jan. 26, 2015, 8:18 p.m.) Review request for Aurora, Maxim

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

2015-01-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30203/#review69666 --- Master (7ba6226) is red with this patch.

Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

2015-01-26 Thread Bill Farner
On Jan. 26, 2015, 5:29 p.m., Dave Lester wrote: Were you able to test this patch on GitHub? I just tried applying this to my own GitHub account's Aurora repo (https://github.com/davelester/incubator-aurora) and used a second GH account to simulate this interaction, but never saw the

Re: Review Request 30248: Fix a markdown syntax error in the deployment docs

2015-01-26 Thread Dave Lester
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30248/#review69620 --- docs/deploying-aurora-scheduler.md

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Bill Farner
On Jan. 26, 2015, 10:14 a.m., Aurora ReviewBot wrote: Master (7ba6226) is red with this patch. ./build-support/jenkins/build.sh :assemble :compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less

Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

2015-01-26 Thread Jeffrey Schroeder
On Jan. 26, 2015, 5:29 p.m., Dave Lester wrote: Were you able to test this patch on GitHub? I just tried applying this to my own GitHub account's Aurora repo (https://github.com/davelester/incubator-aurora) and used a second GH account to simulate this interaction, but never saw the

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review69668 --- src/main/python/apache/aurora/common/clusters.py

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Kevin Sweeney
On Jan. 26, 2015, 12:16 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/common/clusters.py, line 42 https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42 For the purposes of sheparding this review along would you consider moving this to another change?

Re: Review Request 30286: Raise .auroraversion to 0.7.0-SNAPSHOT

2015-01-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30286/#review69686 --- Ship it! Ship It! - Bill Farner On Jan. 26, 2015, 9:27 p.m.,

Re: Review Request 30285: Add Protobufs anonymous class back to untested classes list.

2015-01-26 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30285/#review69682 --- Ship it! Ship It! - David McLaughlin On Jan. 26, 2015, 9:05

Re: Review Request 30207: Simplify AuroraCommandContext

2015-01-26 Thread Bill Farner
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote: I am not convinced there is enough value in this diff to risk possible regression. Besides, the majority of what this diff touches will die out along with the client updater. Zameer Manji wrote: Is there an ETA for the

Review Request 30285: Add Protobufs anonymous class back to untested classes list.

2015-01-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30285/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description

Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

2015-01-26 Thread Jeffrey Schroeder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/ --- (Updated Jan. 27, 2015, 4:27 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

2015-01-26 Thread Jeffrey Schroeder
On Jan. 26, 2015, 5:29 p.m., Dave Lester wrote: Were you able to test this patch on GitHub? I just tried applying this to my own GitHub account's Aurora repo (https://github.com/davelester/incubator-aurora) and used a second GH account to simulate this interaction, but never saw the

Review Request 30302: Updating release publishing script to work with linked .auroraversion

2015-01-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30302/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Florian Pfeiffer
On Jan. 26, 2015, 11:19 nachm., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, line 413 https://reviews.apache.org/r/30010/diff/6/?file=833613#file833613line413 s/public // Feeling kind of stupid here, I somehow thought this

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69724 --- Master (0cb40d1) is red with this patch.

Review Request 30293: Updating release script to work with linked .auroraversion

2015-01-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30293/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 30293: Updating release script to work with linked .auroraversion

2015-01-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30293/#review69705 --- Ship it! Ship It! - Kevin Sweeney On Jan. 26, 2015, 4:03 p.m.,

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 27, 2015, 1:08 vorm.) Review request for Aurora, Bill Farner and

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69594 --- Master (7ba6226) is red with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69688 --- Looks great to me, thanks for retaining the legacy behavior! I'm

Re: Review Request 30286: Raise .auroraversion to 0.7.0-SNAPSHOT

2015-01-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30286/#review69694 --- This patch does not apply cleanly on master (ff8cdcf), do you need

Re: Review Request 30178: Avoid performing RPC authentication while holding the write lock.

2015-01-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30178/ --- (Updated Jan. 26, 2015, 11:42 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30293: Updating release script to work with linked .auroraversion

2015-01-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30293/ --- (Updated Jan. 27, 2015, 12:10 a.m.) Review request for Aurora and Kevin

Re: Review Request 30285: Add Protobufs anonymous class back to untested classes list.

2015-01-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30285/ --- (Updated Jan. 26, 2015, 9:05 p.m.) Review request for Aurora and Zameer Manji.

Review Request 30286: Raise .auroraversion to 0.7.0-SNAPSHOT

2015-01-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30286/ --- Review request for Aurora and Bill Farner. Repository: aurora Description