Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository:

Review Request 21848: Fix command typo

2014-05-22 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21848/ --- Review request for Aurora and Mark Chu-Carroll. Repository: aurora Descriptio

Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-425

Re: Review Request 21440: Implementing parallel updater

2014-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated May 23, 2014, 1:19 a.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 21741: Adding grouping for the sla commands.

2014-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/ --- (Updated May 23, 2014, 1:12 a.m.) Review request for Aurora, Joe Smith, Mark Ch

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread Suman Karumuri
> On May 22, 2014, 7:33 p.m., David McLaughlin wrote: > > I would have to object to the amount of new files added with this review. > > Is there any way to tell bower to only install the files defined in main? > > The vast majority of these new files are superfluous. > > Suman Karumuri wrote:

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43801 --- Ship it! Looks great; thanks for doing this so quickly! - Mark Chu

Re: Review Request 21597: Return empty list instead of failing.

2014-05-22 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/#review43799 --- Ship it! Ship It! - Brian Wickman On May 21, 2014, 4:05 p.m., Ma

Re: Review Request 21781: Removing --groups_per_batch option.

2014-05-22 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21781/#review43798 --- Ship it! Ship It! - Brian Wickman On May 21, 2014, 6:13 p.m., Ma

Re: Review Request 21781: Removing --groups_per_batch option.

2014-05-22 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21781/#review43797 --- Ship it! Ship It! - Joe Smith On May 21, 2014, 11:13 a.m., Maxim

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43796 --- This will not pass python tests as we reference resp.message in quit

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/#review43794 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/cs

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread David McLaughlin
> On May 22, 2014, 7:33 p.m., David McLaughlin wrote: > > I would have to object to the amount of new files added with this review. > > Is there any way to tell bower to only install the files defined in main? > > The vast majority of these new files are superfluous. > > Suman Karumuri wrote:

Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim Khutorn

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread Suman Karumuri
> On May 22, 2014, 7:33 p.m., David McLaughlin wrote: > > I would have to object to the amount of new files added with this review. > > Is there any way to tell bower to only install the files defined in main? > > The vast majority of these new files are superfluous. AFAICT, there is no way to

Re: Review Request 21828: Use asynchronous transport in Thrift.js client

2014-05-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21828/#review43781 --- Ship it! Ship It! - Bill Farner On May 22, 2014, 9:31 p.m., Davi

Review Request 21828: Use asynchronous transport in Thrift.js client

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21828/ --- Review request for Aurora, Suman Karumuri and Bill Farner. Bugs: AURORA-463

Re: Review Request 21455: Opt-in for code quality checks to speed up development iteration.

2014-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21455/#review43769 --- Ship it! Ship It! - Maxim Khutornenko On May 22, 2014, 7:46 p.m.

Re: Review Request 21455: Opt-in for code quality checks to speed up development iteration.

2014-05-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21455/ --- (Updated May 22, 2014, 7:46 p.m.) Review request for Aurora and Maxim Khutornen

Re: Review Request 21455: Opt-in for code quality checks to speed up development iteration.

2014-05-22 Thread Bill Farner
> On May 15, 2014, 11:04 p.m., Maxim Khutornenko wrote: > > build.gradle, line 235 > > > > > > How about a custom target instead? Having something like "gradle > > build_cq" would be easier to remember for use outside

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/#review43760 --- I would have to object to the amount of new files added with this re

Re: Review Request 21741: Adding grouping for the sla commands.

2014-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/ --- (Updated May 22, 2014, 7:23 p.m.) Review request for Aurora, Joe Smith, Mark Ch

Re: Review Request 21741: Adding grouping for the sla commands.

2014-05-22 Thread Maxim Khutornenko
> On May 22, 2014, 4:22 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/base.py, line 118 > > > > > > can you also add register_grouping() that associates a name with a > > function? this way it's

Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-449

Re: Review Request 21791: Do not show instance range when there is only one in group

2014-05-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21791/#review43758 --- Ship it! Ship It! - Bill Farner On May 21, 2014, 10:35 p.m., Dav

Re: Review Request 21791: Do not show instance range when there is only one in group

2014-05-22 Thread Bill Farner
> On May 21, 2014, 10:42 p.m., Bill Farner wrote: > > I agree with the wording on the ticket more than what's done here. Having > > the range displayed when there's one group is still useful to see the > > instance count quickly. It also verifies that there are not instances > > 'missing' (e

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
> On May 22, 2014, 6:06 p.m., Henry Saputra wrote: > > Could you describe a bit details on what changes submitted with the patch? > > Maybe it makes sense to internal folks at Twitter but not useful for new/ > > external people > > Kevin Sweeney wrote: > This is the byproduct of a mailing

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 22, 2014, 6:26 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21791: Do not show instance range when there is only one in group

2014-05-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21791/#review43750 --- Ship it! Ship It! - Suman Karumuri On May 21, 2014, 10:35 p.m.,

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread Henry Saputra
> On May 22, 2014, 6:06 p.m., Henry Saputra wrote: > > Could you describe a bit details on what changes submitted with the patch? > > Maybe it makes sense to internal folks at Twitter but not useful for new/ > > external people > > Kevin Sweeney wrote: > This is the byproduct of a mailing

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread Kevin Sweeney
> On May 22, 2014, 11:06 a.m., Henry Saputra wrote: > > Could you describe a bit details on what changes submitted with the patch? > > Maybe it makes sense to internal folks at Twitter but not useful for new/ > > external people This is the byproduct of a mailing list discussion here: https:/

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review43743 --- Could you describe a bit details on what changes submitted with the

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 22, 2014, 6 p.m.) Review request for Aurora, Kevin Sweeney and Max

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 22, 2014, 6 p.m.) Review request for Aurora, Kevin Sweeney and Max

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
> On May 21, 2014, 7:06 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line > > 35 > > > > > > relational Fixed. > On May 21, 2014, 7:06 p.m., Kevin Sweeney wro

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 22, 2014, 5:59 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21812: auroraUI needs to be global.

2014-05-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21812/#review43740 --- Ship it! Ship It! - Bill Farner On May 22, 2014, 5:52 p.m., Davi

Re: Review Request 21812: auroraUI needs to be global.

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21812/ --- (Updated May 22, 2014, 5:52 p.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 21741: Adding grouping for the sla commands.

2014-05-22 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/#review43728 --- Ship it! src/main/python/apache/aurora/client/base.py

Re: Review Request 21741: Adding grouping for the sla commands.

2014-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/#review43724 --- Ping. - Maxim Khutornenko On May 21, 2014, 12:24 a.m., Maxim Khut

Re: Review Request 21812: auroraUI needs to be global.

2014-05-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21812/#review43715 --- Ship it! Ship It! - Mark Chu-Carroll On May 22, 2014, 10:31 a.m.

Review Request 21812: auroraUI needs to be global.

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21812/ --- Review request for Aurora, Suman Karumuri and Mark Chu-Carroll. Bugs: AURORA-45