Re: Review Request 22280: Implement a TRequestsClient as a prelude to kerberization.

2014-06-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22280/ --- (Updated June 9, 2014, 6:42 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 22280: Implement a TRequestsClient as a prelude to kerberization.

2014-06-09 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22280/#review45108 --- Ship it! Approach looks good to me. - Mark Chu-Carroll On June

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45109 --- src/main/python/apache/aurora/admin/admin_util.py

Re: Review Request 21943: Accept a job key for config loading.

2014-06-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21943/#review45111 --- Ship it! ef yeah! - Brian Wickman On May 29, 2014, 6:21 p.m.,

Re: Review Request 22243: Variety of help fixes.

2014-06-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22243/#review45112 --- Ship it! modulo checkstyle nit

Re: Review Request 22334: Fixing quota check for non-prod/prod job transition.

2014-06-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22334/#review45113 --- Ship it! Ship It! - Brian Wickman On June 6, 2014, 11:32 p.m.,

Re: Review Request 22280: Implement a TRequestsClient as a prelude to kerberization.

2014-06-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22280/#review45110 --- src/main/python/apache/aurora/common/transport.py

Re: Review Request 22243: Variety of help fixes.

2014-06-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22243/#review45114 --- Ship it! Ship It! - David McLaughlin On June 4, 2014, 6:39

Re: Review Request 22281: Fixing broken increase_quota command.

2014-06-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22281/#review45122 --- Ship it! Ship It! - Kevin Sweeney On June 6, 2014, 11:01 a.m.,

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Maxim Khutornenko
On June 9, 2014, 7:17 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/admin/admin_util.py, line 14 https://reviews.apache.org/r/22167/diff/3/?file=603310#file603310line14 Are you sure you uploaded the correct diff? In your reply to the review, you said you'd added

Re: Review Request 22280: Implement a TRequestsClient as a prelude to kerberization.

2014-06-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22280/ --- (Updated June 9, 2014, 8:56 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 22280: Implement a TRequestsClient as a prelude to kerberization.

2014-06-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22280/#review45138 --- Ship it! Ship It! - Kevin Sweeney On June 9, 2014, 1:56 p.m.,

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Maxim Khutornenko
On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/admin/admin_util.py, line 88 https://reviews.apache.org/r/22167/diff/3/?file=603310#file603310line88 You've got parse_hosts, parst_host_file, parse_hosts_optional, and parse_host_list. I have no

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- (Updated June 9, 2014, 10:08 p.m.) Review request for Aurora, Joe Smith, Mark

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45164 --- Ship it! Ship It! - Mark Chu-Carroll On June 9, 2014, 6:08

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Mark Chu-Carroll
On June 9, 2014, 4:43 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/commands/maintenance.py, line 72 https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72 This help line is unclear: what does time interval for the percentage of up tasks

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- (Updated June 9, 2014, 11:10 p.m.) Review request for Aurora, Joe Smith, Mark

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Maxim Khutornenko
On June 9, 2014, 8:43 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/commands/maintenance.py, line 72 https://reviews.apache.org/r/22167/diff/3/?file=603316#file603316line72 This help line is unclear: what does time interval for the percentage of up tasks

Re: Review Request 22280: Implement a TRequestsClient as a prelude to kerberization.

2014-06-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22280/#review45174 --- Ship it! Ship It! - Kevin Sweeney On June 9, 2014, 4:42 p.m.,

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/#review45175 --- Ping, Brian/Joe. - Maxim Khutornenko On June 9, 2014, 11:10

Review Request 22407: Add transport to common package.

2014-06-09 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22407/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 22407: Add transport to common package.

2014-06-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22407/#review45187 --- Ship it! Ship It! - Kevin Sweeney On June 9, 2014, 6:23 p.m.,

Review Request 22408: Log SlaveID without newline.

2014-06-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22408/ --- Review request for Aurora, Maxim Khutornenko and Brian Wickman. Repository:

Re: Review Request 22408: Log SlaveID without newline.

2014-06-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22408/ --- (Updated June 9, 2014, 6:45 p.m.) Review request for Aurora, Maxim Khutornenko