Re: Review Request 25259: Add update information to the scheduler UI

[David McLaughlin]

> On Sept. 9, 2014, 11:42 p.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 81
> > 
> >
> > s/is this/if this

D'oh. Fixed.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review52801
---


On Sept. 9, 2014, 11:50 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25259/
> ---
> 
> (Updated Sept. 9, 2014, 11:50 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-614
> https://issues.apache.org/jira/browse/AURORA-614
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds update history to the job page. Adds an update details page. 
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> de49a1c5497e32ee4db944412e5c87807c742d3c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
> c780b0fe98863b5421824a9652a7202da9f4302a 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> 2a752313cb8ae404605a9458b33237a911eec061 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> e21dee015897eee62ade8f74e26f042b8e2be734 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> fb3b5b12121a6e8a30dbf6fe069557f69a563408 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 3477b7e667459665af9d9dc9d2456793822bc7f7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 7f05a552f3786adb115ff9648f4fadce968230e9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> df2806481fc1c2f263d3afd9b21247e97a18ed57 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> bfd360de45c75441743c8ba24a5c445f4146dba6 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
> PRE-CREATION 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 2b376d663b3bc9264965db58ef89de59b10169ad 
> 
> Diff: https://reviews.apache.org/r/25259/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jsHint
> 
> 
> File Attachments
> 
> 
> job page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
> update page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 25259: Add update information to the scheduler UI

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/
---

(Updated Sept. 9, 2014, 11:50 p.m.)


Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.


Changes
---

Fixed typo. 


Bugs: AURORA-614
https://issues.apache.org/jira/browse/AURORA-614


Repository: aurora


Description
---

Adds update history to the job page. Adds an update details page. 


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
de49a1c5497e32ee4db944412e5c87807c742d3c 
  src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
c780b0fe98863b5421824a9652a7202da9f4302a 
  src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
2a752313cb8ae404605a9458b33237a911eec061 
  src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
e21dee015897eee62ade8f74e26f042b8e2be734 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
fb3b5b12121a6e8a30dbf6fe069557f69a563408 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
3477b7e667459665af9d9dc9d2456793822bc7f7 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
7f05a552f3786adb115ff9648f4fadce968230e9 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
df2806481fc1c2f263d3afd9b21247e97a18ed57 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
bfd360de45c75441743c8ba24a5c445f4146dba6 
  src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
PRE-CREATION 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
2b376d663b3bc9264965db58ef89de59b10169ad 

Diff: https://reviews.apache.org/r/25259/diff/


Testing
---

./gradlew jsHint


File Attachments


job page
  
https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
update page
  
https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png


Thanks,

David McLaughlin

Re: Review Request 25259: Add update information to the scheduler UI

[David McLaughlin]

> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 277
> > 
> >
> > This seems to be too short to make any visual difference but could be a 
> > perf hit. How about 10-15sec instead?
> > 
> > Also, is there any visual cue that the progress is auto-updated?
> 
> Maxim Khutornenko wrote:
> Also, will the auto-update get suspended when the page is out of focus 
> (e.g. user switches to another tab or hides the browser)? Would be great if 
> it does.
> 
> David McLaughlin wrote:
> No visual cue that it's auto-updated. It could be something to add in the 
> future, or do you see it as a blocker for this? I picked 3s off the top of my 
> head. 10s sounds like a good alternative. 
> 
> 
> Auto-update being suspended when the page is out of focus doesn't seem 
> like a desired feature. When I come back to the tab the page is always in the 
> same state as I last saw it. There is definitely a use case of tabbing in and 
> out to see how an update is going.
> 
> Maxim Khutornenko wrote:
> | When I come back to the tab the page is always in the same state as I 
> last saw it.
> Is it possible to suspend auto-update on lost focus and resume on 
> re-acquiring it? Not sure if there is a high level event available for it but 
> would be great to avoid wasted expensive queries on the scheduler if no one 
> is watching the page.

The problem with tabs/windows is they can be inactive but still visible in your 
screen. e.g. there's no way to know if the inactive window is hidden behind 
another window or still visible on a second screen.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 411
> > 
> >
> > Same here.

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 31
> > 
> >
> > Missing period.

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 32
> > 
> >
> > s/Instances/Instance

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 41
> > 
> >
> > Missing period.

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 61
> > 
> >
> > s/to watch to watch/to watch
> > 
> > Just realized it's copied from api.thrift. Mind fixing it there as well?

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 62
> > 
> >
> > Suggest renaming to "Min Waiting Time In Running" to better reflect on 
> > the setting.

Fixed.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html, 
> > line 81
> > 
> >
> > s/set/subset?
> > 
> > Also, suggest adding: "All instances will be affected if this is not 
> > set."

Fixed.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review52661
---


On Sept. 9, 2014, 11:32 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25259/
> ---
> 
> (Updated Sept. 9, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-614
> https://issues.apache.org/jira/browse/AURORA-614
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds update history to the job page. Adds an update details page. 
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> de49a1c5497e32ee4db944412e5c87807c742d3c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
> c780b0fe98863b5421824a9652a7202da9f4302a 

Re: Review Request 25259: Add update information to the scheduler UI

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review52801
---



src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html


s/is this/if this


- Maxim Khutornenko


On Sept. 9, 2014, 11:32 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25259/
> ---
> 
> (Updated Sept. 9, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-614
> https://issues.apache.org/jira/browse/AURORA-614
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds update history to the job page. Adds an update details page. 
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> de49a1c5497e32ee4db944412e5c87807c742d3c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
> c780b0fe98863b5421824a9652a7202da9f4302a 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> 2a752313cb8ae404605a9458b33237a911eec061 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> e21dee015897eee62ade8f74e26f042b8e2be734 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> fb3b5b12121a6e8a30dbf6fe069557f69a563408 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 3477b7e667459665af9d9dc9d2456793822bc7f7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 7f05a552f3786adb115ff9648f4fadce968230e9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> df2806481fc1c2f263d3afd9b21247e97a18ed57 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> bfd360de45c75441743c8ba24a5c445f4146dba6 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
> PRE-CREATION 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 2b376d663b3bc9264965db58ef89de59b10169ad 
> 
> Diff: https://reviews.apache.org/r/25259/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jsHint
> 
> 
> File Attachments
> 
> 
> job page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
> update page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 25259: Add update information to the scheduler UI

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/
---

(Updated Sept. 9, 2014, 11:32 p.m.)


Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.


Changes
---

rb feedback.


Bugs: AURORA-614
https://issues.apache.org/jira/browse/AURORA-614


Repository: aurora


Description
---

Adds update history to the job page. Adds an update details page. 


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
de49a1c5497e32ee4db944412e5c87807c742d3c 
  src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
c780b0fe98863b5421824a9652a7202da9f4302a 
  src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
2a752313cb8ae404605a9458b33237a911eec061 
  src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
e21dee015897eee62ade8f74e26f042b8e2be734 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
fb3b5b12121a6e8a30dbf6fe069557f69a563408 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
3477b7e667459665af9d9dc9d2456793822bc7f7 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
7f05a552f3786adb115ff9648f4fadce968230e9 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
df2806481fc1c2f263d3afd9b21247e97a18ed57 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
bfd360de45c75441743c8ba24a5c445f4146dba6 
  src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
PRE-CREATION 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
2b376d663b3bc9264965db58ef89de59b10169ad 

Diff: https://reviews.apache.org/r/25259/diff/


Testing
---

./gradlew jsHint


File Attachments


job page
  
https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
update page
  
https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png


Thanks,

David McLaughlin

Re: Review Request 25259: Add update information to the scheduler UI

[David McLaughlin]

> On Sept. 9, 2014, 6:43 p.m., Kevin Sweeney wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 277
> > 
> >
> > Extract this as a configuration variable?

Fixed.


> On Sept. 9, 2014, 6:43 p.m., Kevin Sweeney wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 411
> > 
> >
> > DRY

Fixed.


> On Sept. 9, 2014, 6:43 p.m., Kevin Sweeney wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 
> > 156
> > 
> >
> > Since this has no dependencies you can make it .constant

This is defined how taskUtil is for consistency.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review52665
---


On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25259/
> ---
> 
> (Updated Sept. 9, 2014, 1:05 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-614
> https://issues.apache.org/jira/browse/AURORA-614
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds update history to the job page. Adds an update details page. 
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> de49a1c5497e32ee4db944412e5c87807c742d3c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
> c780b0fe98863b5421824a9652a7202da9f4302a 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> 2a752313cb8ae404605a9458b33237a911eec061 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> e21dee015897eee62ade8f74e26f042b8e2be734 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> fb3b5b12121a6e8a30dbf6fe069557f69a563408 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 3477b7e667459665af9d9dc9d2456793822bc7f7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 7f05a552f3786adb115ff9648f4fadce968230e9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> df2806481fc1c2f263d3afd9b21247e97a18ed57 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> bfd360de45c75441743c8ba24a5c445f4146dba6 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25259/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jsHint
> 
> 
> File Attachments
> 
> 
> job page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
> update page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 25483: Transaction all SQL under MemStorage

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/#review52798
---

Ship it!


Ship It!

- Maxim Khutornenko


On Sept. 9, 2014, 9:05 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25483/
> ---
> 
> (Updated Sept. 9, 2014, 9:05 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-694
> https://issues.apache.org/jira/browse/AURORA-694
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit ensures all delegated tables are accessed via a transaction via 
> MemStorage.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> d7d350ee85510e75804322ebf6a877e35bf8d0d3 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> a042fa9abe23ad102c54615eebc007964fb053da 
> 
> Diff: https://reviews.apache.org/r/25483/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 25483: Transaction all SQL under MemStorage

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/#review52797
---

Ship it!


Ship It!

- Bill Farner


On Sept. 9, 2014, 9:05 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25483/
> ---
> 
> (Updated Sept. 9, 2014, 9:05 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-694
> https://issues.apache.org/jira/browse/AURORA-694
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit ensures all delegated tables are accessed via a transaction via 
> MemStorage.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> d7d350ee85510e75804322ebf6a877e35bf8d0d3 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> a042fa9abe23ad102c54615eebc007964fb053da 
> 
> Diff: https://reviews.apache.org/r/25483/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 25259: Add update information to the scheduler UI

[Maxim Khutornenko]

> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 277
> > 
> >
> > This seems to be too short to make any visual difference but could be a 
> > perf hit. How about 10-15sec instead?
> > 
> > Also, is there any visual cue that the progress is auto-updated?
> 
> Maxim Khutornenko wrote:
> Also, will the auto-update get suspended when the page is out of focus 
> (e.g. user switches to another tab or hides the browser)? Would be great if 
> it does.
> 
> David McLaughlin wrote:
> No visual cue that it's auto-updated. It could be something to add in the 
> future, or do you see it as a blocker for this? I picked 3s off the top of my 
> head. 10s sounds like a good alternative. 
> 
> 
> Auto-update being suspended when the page is out of focus doesn't seem 
> like a desired feature. When I come back to the tab the page is always in the 
> same state as I last saw it. There is definitely a use case of tabbing in and 
> out to see how an update is going.

| When I come back to the tab the page is always in the same state as I last 
saw it.
Is it possible to suspend auto-update on lost focus and resume on re-acquiring 
it? Not sure if there is a high level event available for it but would be great 
to avoid wasted expensive queries on the scheduler if no one is watching the 
page.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review52661
---


On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25259/
> ---
> 
> (Updated Sept. 9, 2014, 1:05 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-614
> https://issues.apache.org/jira/browse/AURORA-614
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds update history to the job page. Adds an update details page. 
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> de49a1c5497e32ee4db944412e5c87807c742d3c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
> c780b0fe98863b5421824a9652a7202da9f4302a 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> 2a752313cb8ae404605a9458b33237a911eec061 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> e21dee015897eee62ade8f74e26f042b8e2be734 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> fb3b5b12121a6e8a30dbf6fe069557f69a563408 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 3477b7e667459665af9d9dc9d2456793822bc7f7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 7f05a552f3786adb115ff9648f4fadce968230e9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> df2806481fc1c2f263d3afd9b21247e97a18ed57 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> bfd360de45c75441743c8ba24a5c445f4146dba6 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25259/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jsHint
> 
> 
> File Attachments
> 
> 
> job page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
> update page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 25483: Transaction all SQL under MemStorage

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/#review52790
---



src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java


after this, fail() (within the try block)



src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java


// Expected



src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java


assertEquals(ImmutableMap.<..>of(), fetchQuotas());

In this case it's not _that_ helpful, but this pattern results in generally 
more useful output from junit (expected vs actual).


- Bill Farner


On Sept. 9, 2014, 9:05 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25483/
> ---
> 
> (Updated Sept. 9, 2014, 9:05 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-694
> https://issues.apache.org/jira/browse/AURORA-694
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This commit ensures all delegated tables are accessed via a transaction via 
> MemStorage.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> d7d350ee85510e75804322ebf6a877e35bf8d0d3 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> a042fa9abe23ad102c54615eebc007964fb053da 
> 
> Diff: https://reviews.apache.org/r/25483/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 25259: Add update information to the scheduler UI

[David McLaughlin]

> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 277
> > 
> >
> > This seems to be too short to make any visual difference but could be a 
> > perf hit. How about 10-15sec instead?
> > 
> > Also, is there any visual cue that the progress is auto-updated?
> 
> Maxim Khutornenko wrote:
> Also, will the auto-update get suspended when the page is out of focus 
> (e.g. user switches to another tab or hides the browser)? Would be great if 
> it does.

No visual cue that it's auto-updated. It could be something to add in the 
future, or do you see it as a blocker for this? I picked 3s off the top of my 
head. 10s sounds like a good alternative. 


Auto-update being suspended when the page is out of focus doesn't seem like a 
desired feature. When I come back to the tab the page is always in the same 
state as I last saw it. There is definitely a use case of tabbing in and out to 
see how an update is going.


> On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line 
> > 54
> > 
> >
> > Should not this be ROLL BACK PAUSED instead?

I figured the user didn't really care about what type of pause it was, and the 
previous state is right there in the status history. Thoughts?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review52661
---


On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25259/
> ---
> 
> (Updated Sept. 9, 2014, 1:05 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-614
> https://issues.apache.org/jira/browse/AURORA-614
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds update history to the job page. Adds an update details page. 
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> de49a1c5497e32ee4db944412e5c87807c742d3c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
> c780b0fe98863b5421824a9652a7202da9f4302a 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> 2a752313cb8ae404605a9458b33237a911eec061 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> e21dee015897eee62ade8f74e26f042b8e2be734 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> fb3b5b12121a6e8a30dbf6fe069557f69a563408 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 3477b7e667459665af9d9dc9d2456793822bc7f7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 7f05a552f3786adb115ff9648f4fadce968230e9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> df2806481fc1c2f263d3afd9b21247e97a18ed57 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> bfd360de45c75441743c8ba24a5c445f4146dba6 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25259/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jsHint
> 
> 
> File Attachments
> 
> 
> job page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
> update page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Review Request 25483: Transaction all SQL under MemStorage

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/
---

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Summary (updated)
-

Transaction all SQL under MemStorage


Bugs: AURORA-694
https://issues.apache.org/jira/browse/AURORA-694


Repository: aurora


Description (updated)
---

This commit ensures all delegated tables are accessed via a transaction via 
MemStorage.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
d7d350ee85510e75804322ebf6a877e35bf8d0d3 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
a042fa9abe23ad102c54615eebc007964fb053da 

Diff: https://reviews.apache.org/r/25483/diff/


Testing (updated)
---

./gradlew build -Pq


Thanks,

Zameer Manji

Re: Review Request 25450: Fix broken "large update" warning.

[David McLaughlin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25450/#review52777
---

Ship it!


Ship It!

- David McLaughlin


On Sept. 9, 2014, 7:43 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25450/
> ---
> 
> (Updated Sept. 9, 2014, 7:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-5860
> https://issues.apache.org/jira/browse/aurora-5860
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> At some point, the "large update" warning logic was revised so that the
> warning shows whenever you do an update that either:
> - the updated config had more than 4x as many instances as the running one; or
> - the updated config had less than 4x as many instances as the running one.
> 
> (Seriously: either local >= 4 * remote or local <= 4 * remote". And running 
> git blame says it's all my fault.)
> 
> This fixes it: the correct logic is:
> - the updated config has more than 4x as many as running; or
> - the updated config has less than 1/4th as many as running.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 8b7d11202b35deb09a248cfe0a96458fb70c 
>   src/test/python/apache/aurora/client/cli/util.py 
> 95a2123e127c9811fd2305e71cfc5c7c4376f904 
> 
> Diff: https://reviews.apache.org/r/25450/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25450: Fix broken "large update" warning.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25450/#review52776
---

Ship it!


Ship It!

- Maxim Khutornenko


On Sept. 9, 2014, 7:43 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25450/
> ---
> 
> (Updated Sept. 9, 2014, 7:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-5860
> https://issues.apache.org/jira/browse/aurora-5860
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> At some point, the "large update" warning logic was revised so that the
> warning shows whenever you do an update that either:
> - the updated config had more than 4x as many instances as the running one; or
> - the updated config had less than 4x as many instances as the running one.
> 
> (Seriously: either local >= 4 * remote or local <= 4 * remote". And running 
> git blame says it's all my fault.)
> 
> This fixes it: the correct logic is:
> - the updated config has more than 4x as many as running; or
> - the updated config has less than 1/4th as many as running.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 8b7d11202b35deb09a248cfe0a96458fb70c 
>   src/test/python/apache/aurora/client/cli/util.py 
> 95a2123e127c9811fd2305e71cfc5c7c4376f904 
> 
> Diff: https://reviews.apache.org/r/25450/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Review Request 25481: Adding JobUpdateRequest validation.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25481/
---

Review request for Aurora, Bill Farner and Zameer Manji.


Bugs: AURORA-649
https://issues.apache.org/jira/browse/AURORA-649


Repository: aurora


Description
---

Adding JobUpdateRequest validation.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
a43e5d7748c22d60f56f03a8a3d52949faebeff2 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 0d51f7dc367081f72090736e36605bf363f3395e 

Diff: https://reviews.apache.org/r/25481/diff/


Testing
---

gradle -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 25450: Fix broken "large update" warning.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25450/
---

(Updated Sept. 9, 2014, 3:43 p.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Changes
---

Fixed time delay in test runs;
Adjusted logging output.


Bugs: aurora-5860
https://issues.apache.org/jira/browse/aurora-5860


Repository: aurora


Description
---

At some point, the "large update" warning logic was revised so that the
warning shows whenever you do an update that either:
- the updated config had more than 4x as many instances as the running one; or
- the updated config had less than 4x as many instances as the running one.

(Seriously: either local >= 4 * remote or local <= 4 * remote". And running git 
blame says it's all my fault.)

This fixes it: the correct logic is:
- the updated config has more than 4x as many as running; or
- the updated config has less than 1/4th as many as running.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/jobs.py 
8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
  src/test/python/apache/aurora/client/cli/test_update.py 
8b7d11202b35deb09a248cfe0a96458fb70c 
  src/test/python/apache/aurora/client/cli/util.py 
95a2123e127c9811fd2305e71cfc5c7c4376f904 

Diff: https://reviews.apache.org/r/25450/diff/


Testing
---

Added new unit tests.


Thanks,

Mark Chu-Carroll

Re: Review Request 25450: Fix broken "large update" warning.

[Mark Chu-Carroll]

> On Sept. 8, 2014, 4:31 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 655
> > 
> >
> > This feels redundant. Current output already has success message(s):
> > 
> > ...
> > log(info): Killed: 8
> > log(info): Instance 0 has been up and healthy for at least 45 seconds
> > log(info): Instance 1 has been up and healthy for at least 45 seconds
> > log(info): Update successful
> > log(info): Command terminated successfully
> 
> Mark Chu-Carroll wrote:
> Current output has those messages on logs - which are optional.  I think 
> that making sure there's some feedback to the user is worthwhile.

(For what it's worth, the "command terminated successfully" was intended to put 
a status line into loggie. I've switched it to TRANSCRIPT level, so it goes to 
loggie, but the user won't see it; that way, the user won't see duplicates, but 
they'll definitely see feedback when the command completes.)


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25450/#review52624
---


On Sept. 8, 2014, 2:37 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25450/
> ---
> 
> (Updated Sept. 8, 2014, 2:37 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-5860
> https://issues.apache.org/jira/browse/aurora-5860
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> At some point, the "large update" warning logic was revised so that the
> warning shows whenever you do an update that either:
> - the updated config had more than 4x as many instances as the running one; or
> - the updated config had less than 4x as many instances as the running one.
> 
> (Seriously: either local >= 4 * remote or local <= 4 * remote". And running 
> git blame says it's all my fault.)
> 
> This fixes it: the correct logic is:
> - the updated config has more than 4x as many as running; or
> - the updated config has less than 1/4th as many as running.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 8b7d11202b35deb09a248cfe0a96458fb70c 
>   src/test/python/apache/aurora/client/cli/util.py 
> 95a2123e127c9811fd2305e71cfc5c7c4376f904 
> 
> Diff: https://reviews.apache.org/r/25450/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25450: Fix broken "large update" warning.

[Mark Chu-Carroll]

> On Sept. 8, 2014, 4:31 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, line 655
> > 
> >
> > This feels redundant. Current output already has success message(s):
> > 
> > ...
> > log(info): Killed: 8
> > log(info): Instance 0 has been up and healthy for at least 45 seconds
> > log(info): Instance 1 has been up and healthy for at least 45 seconds
> > log(info): Update successful
> > log(info): Command terminated successfully

Current output has those messages on logs - which are optional.  I think that 
making sure there's some feedback to the user is worthwhile.


> On Sept. 8, 2014, 4:31 p.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/cli/test_update.py, line 251
> > 
> >
> > This patching not appear to work in the current version of tests where 
> > a 5 seconds timeout is always waited on. Any chance it could be fixed 
> > before piling up more test cases like this?

I'll look, and see if I can figure out where that's coming from.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25450/#review52624
---


On Sept. 8, 2014, 2:37 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25450/
> ---
> 
> (Updated Sept. 8, 2014, 2:37 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-5860
> https://issues.apache.org/jira/browse/aurora-5860
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> At some point, the "large update" warning logic was revised so that the
> warning shows whenever you do an update that either:
> - the updated config had more than 4x as many instances as the running one; or
> - the updated config had less than 4x as many instances as the running one.
> 
> (Seriously: either local >= 4 * remote or local <= 4 * remote". And running 
> git blame says it's all my fault.)
> 
> This fixes it: the correct logic is:
> - the updated config has more than 4x as many as running; or
> - the updated config has less than 1/4th as many as running.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 8b7d11202b35deb09a248cfe0a96458fb70c 
>   src/test/python/apache/aurora/client/cli/util.py 
> 95a2123e127c9811fd2305e71cfc5c7c4376f904 
> 
> Diff: https://reviews.apache.org/r/25450/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25259: Add update information to the scheduler UI

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25259/#review52665
---



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js


Extract this as a configuration variable?



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js


DRY



src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js


Since this has no dependencies you can make it .constant


- Kevin Sweeney


On Sept. 8, 2014, 6:05 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25259/
> ---
> 
> (Updated Sept. 8, 2014, 6:05 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-614
> https://issues.apache.org/jira/browse/AURORA-614
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds update history to the job page. Adds an update details page. 
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> de49a1c5497e32ee4db944412e5c87807c742d3c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
> c780b0fe98863b5421824a9652a7202da9f4302a 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> 2a752313cb8ae404605a9458b33237a911eec061 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 
> e21dee015897eee62ade8f74e26f042b8e2be734 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> fb3b5b12121a6e8a30dbf6fe069557f69a563408 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 3477b7e667459665af9d9dc9d2456793822bc7f7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 7f05a552f3786adb115ff9648f4fadce968230e9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> df2806481fc1c2f263d3afd9b21247e97a18ed57 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> bfd360de45c75441743c8ba24a5c445f4146dba6 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/update.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25259/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jsHint
> 
> 
> File Attachments
> 
> 
> job page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png
> update page
>   
> https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/
---

(Updated Sept. 9, 2014, 6:38 p.m.)


Review request for Aurora, Joe Smith and Kevin Sweeney.


Changes
---

Address Kevin's feedback.


Bugs: AURORA-412
https://issues.apache.org/jira/browse/AURORA-412


Repository: aurora


Description
---

Upgrade Aurora to psutil 2.1.1


Diffs (updated)
-

  3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
  src/main/python/apache/aurora/executor/executor_vars.py 
7665a77ca13bbbc337e345356b70f12357692f3d 
  src/main/python/apache/aurora/executor/gc_executor.py 
572c106038602b795a5b6bf08b2b85cf4b6bfec6 
  src/main/python/apache/thermos/core/helper.py 
9e4a8fb70df984d175129cb49025b3c222a64679 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
298459bab01d2c01bef1d69c1150ff2d5737ebbf 
  src/test/python/apache/thermos/core/test_helper.py 
58096119e1b412afa36a09da5759c5223a5b5d75 

Diff: https://reviews.apache.org/r/25466/diff/


Testing
---

Ran tests on OS X but not yet on Linux.  There is adequate coverage.

==edit, Linux test output==

src.test.python.apache.thermos.bin.test_thermos 
.   SUCCESS
src.test.python.apache.thermos.common.test_pathspec 
.   SUCCESS
src.test.python.apache.thermos.common.test_planner  
.   SUCCESS
src.test.python.apache.thermos.common.test_task_planner 
.   SUCCESS
src.test.python.apache.thermos.config.test_schema   
.   SUCCESS
src.test.python.apache.thermos.core.test_angry  
.   SUCCESS
src.test.python.apache.thermos.core.test_ephemerals 
.   SUCCESS
src.test.python.apache.thermos.core.test_failing_runner 
.   SUCCESS
src.test.python.apache.thermos.core.test_failure_limit  
.   SUCCESS
src.test.python.apache.thermos.core.test_finalization   
.   SUCCESS
src.test.python.apache.thermos.core.test_helper 
.   SUCCESS
src.test.python.apache.thermos.core.test_process
.   SUCCESS
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
src.test.python.apache.thermos.core.test_staged_kill
.   SUCCESS
src.test.python.apache.thermos.monitoring.test_disk 
.   SUCCESS
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS
src.test.python.apache.aurora.client.api.api
.   SUCCESS
src.test.python.apache.aurora.client.api.disambiguator  
.   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher   
.   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
.   SUCCESS
src.test.python.apache.aurora.client.api.mux
.   SUCCESS
src.test.python.apache.aurora.client.api.quota_check
.   SUCCESS
src.test.python.apache.aurora.client.api.restarter  
.   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client   
.   SUCCESS
src.test.python.apache.aurora.client.api.sla
.   SUCCESS
src.test.python.apache.aurora.client.api.updater
.   SUCCESS
src.test.python.apache.aurora.client.api.updater_util   
.   SUCCESS
src.test.python.apache.aurora.client.binding_helper 
.   SUCCESS
src.test.python.apache.aurora.client.cli.api
.   SUCCESS
src.test.python.apache.aurora.client.cli.bridge 
.   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks  
.   SUCCESS
src.test.python.apache.aurora.client.cli.config 
.   SUCCESS
src.test.python.apache.aurora.client.cli.cron   
.   SUCCESS
src.test.python.apache.aurora.client.cli.help   
.   SUCCESS
src.test.python.apache.aurora.client.cli.inspect
.   SUCCESS
src.test.python.apache.aurora.client.cli.job
.   SUCCESS
src.test.python.apache.aurora.client.cli.logging
.   SUCCESS
src.test.python.apache.aurora.client.cli.plugins   

Re: Review Request 25398: Make the offer hold jitter window configurable.

[Joshua Cohen]

> On Sept. 9, 2014, 4:45 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java,
> >  line 53
> > 
> >
> > Consider using the mock throughout.  You get a little extra bit of 
> > verification that it is not invoked.

Updated.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25398/#review52735
---


On Sept. 9, 2014, 4:54 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25398/
> ---
> 
> (Updated Sept. 9, 2014, 4:54 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-313
> https://issues.apache.org/jira/browse/AURORA-313
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make the offer hold jitter window configurable.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 5a38a1f69ac5dbe68af3bfe175899ddee392880b 
>   
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25398/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 25398: Make the offer hold jitter window configurable.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25398/
---

(Updated Sept. 9, 2014, 4:54 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Use mock random for all tests.


Bugs: AURORA-313
https://issues.apache.org/jira/browse/AURORA-313


Repository: aurora


Description
---

Make the offer hold jitter window configurable.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
5a38a1f69ac5dbe68af3bfe175899ddee392880b 
  src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/25398/diff/


Testing
---

gradle -Pq build


Thanks,

Joshua Cohen

Re: Review Request 25398: Make the offer hold jitter window configurable.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25398/#review52735
---



src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java


Consider using the mock throughout.  You get a little extra bit of 
verification that it is not invoked.


- Bill Farner


On Sept. 8, 2014, 9:09 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25398/
> ---
> 
> (Updated Sept. 8, 2014, 9:09 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-313
> https://issues.apache.org/jira/browse/AURORA-313
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Make the offer hold jitter window configurable.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 5a38a1f69ac5dbe68af3bfe175899ddee392880b 
>   
> src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelayTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25398/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 22457: Improve aurora "job diff" command.

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/
---

(Updated Sept. 9, 2014, 10:07 a.m.)


Review request for Aurora, Maxim Khutornenko and Brian Wickman.


Changes
---

Tried modifying the test, to see if that fixes the jenkins build issue.


Bugs: aurora-520
https://issues.apache.org/jira/browse/aurora-520


Repository: aurora


Description (updated)
---

Add a new diff method, which uses field-by-field comparison of JSON trees for 
comparing running job configurations to potentially updated configs.

- Allow exclusion of semantically irrelevant fields.
- Provide a clearer list of the differences between configs.
- Provide a scripting-friendly alternative JSON syntax for diffs.

The old diff behavior is still available under the "--use-shell-diff" option.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
  src/main/python/apache/aurora/client/cli/jobs.py 
8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
  src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
  src/test/python/apache/aurora/client/cli/test_diff.py 
38629b63c082cf81cb891dace2a70d9e8f418e18 
  src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22457/diff/


Testing
---

New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests 
of the new functionality.
All tests pass.


Thanks,

Mark Chu-Carroll