Re: Review Request 26004: Add aurora update list and aurora update status commands.
On Sept. 24, 2014, 6:28 p.m., David McLaughlin wrote: What was the rationale for hiding update IDs from the user and making job key the parameter for update status? It's nice you can quickly see if a job key has an update in progress.. but what happens if you're wanting to see a recent deploy that is already finished or see further back? I think update list should return the update ids and update status should accept an update id. Well maybe not update status.. but update show or something? Something which is consistent with the job verbs would be great. I was following the pattern that I saw in the API implementation. In early iterations, it exposed updated ids; in later ones, the IDs were removed from the user-level API. We don't use those identifiers for pausing or resuming an active update; why would we use them for checking on the status of an update? That would become a very awkward interface for users: start an update? use the jobkey. Pause an update? User the jobkey. Abort an update? Use the jobkey. Check the status of an update? Use some other identifier that you don't know without running another command. I can certainly add the updateID to the list command, and add a command (or alternative parameter) for checking on a job by update-ID, but I don't think that making it the normal parameter to status is a good design for the command-line. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review54466 --- On Sept. 24, 2014, 4:24 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Sept. 24, 2014, 4:24 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-742 https://issues.apache.org/jira/browse/aurora-742 Repository: aurora Description --- Add support for commands to query and display active updates being managed by the scheduler. Two commands are added: * aurora update list, which shows all active updates that are being processed by the server. * aurora update status, which shows detailed status information about an update in-progress on the server. Diffs - src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28 src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f src/main/python/apache/aurora/client/cli/update.py c6cb98fe6aa42310090167796c971856d3dc177f src/test/python/apache/aurora/client/cli/test_supdate.py 4fb1623e497b9741ae2a350deb20030dd4036506 src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Review Request 26137: Fix help for new update command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-748 https://issues.apache.org/jira/browse/aurora-748 Repository: aurora Description --- Fix help for new update command. Diffs - src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 Diff: https://reviews.apache.org/r/26137/diff/ Testing --- manual testing. Thanks, Mark Chu-Carroll
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54825 --- I've got an updated diff for this, but reviewboard is choking when I try to publish it. In the meantime I set up a branch at githib that should make these changes easier to review: https://github.com/jcohen/incubator-aurora/commits/jcohen/static-assets The first two commits contain all the renames (the initial mass-rename and the subsequent smaller rename for assets that were added mid-development). The third commit is us forking the graphview resources from twitter commons The fourth/final commit is the bulk of the actual code changes to get everything working. - Joshua Cohen On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
Re: Review Request 26095: Fix instance summary visualisation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54829 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 29, 2014, 4:11 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/ --- (Updated Sept. 29, 2014, 4:11 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-755 https://issues.apache.org/jira/browse/AURORA-755 Repository: aurora Description --- See JIRA ticket. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 92c78c28020d36b978f1a098202174015ace1316 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8ed95737ea69112d4ee04b687281d06a21d6abf6 Diff: https://reviews.apache.org/r/26095/diff/ Testing --- File Attachments Growing a job shows correct instance ids https://reviews.apache.org/media/uploaded/files/2014/09/26/246430ff-cf02-4701-9254-6f8e42f95b2a__Screen_Shot_2014-09-26_at_12.47.45_PM.png Instances removed are identified when shrinking job from 5 instances to 1 https://reviews.apache.org/media/uploaded/files/2014/09/26/b01c5d23-080e-4433-804b-c868215c0bcb__Screen_Shot_2014-09-26_at_12.47.56_PM.png Thanks, David McLaughlin
Re: Review Request 26095: Fix instance summary visualisation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54830 --- Ship it! Ship It! - Bill Farner On Sept. 29, 2014, 4:11 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/ --- (Updated Sept. 29, 2014, 4:11 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-755 https://issues.apache.org/jira/browse/AURORA-755 Repository: aurora Description --- See JIRA ticket. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 92c78c28020d36b978f1a098202174015ace1316 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8ed95737ea69112d4ee04b687281d06a21d6abf6 Diff: https://reviews.apache.org/r/26095/diff/ Testing --- File Attachments Growing a job shows correct instance ids https://reviews.apache.org/media/uploaded/files/2014/09/26/246430ff-cf02-4701-9254-6f8e42f95b2a__Screen_Shot_2014-09-26_at_12.47.45_PM.png Instances removed are identified when shrinking job from 5 instances to 1 https://reviews.apache.org/media/uploaded/files/2014/09/26/b01c5d23-080e-4433-804b-c868215c0bcb__Screen_Shot_2014-09-26_at_12.47.56_PM.png Thanks, David McLaughlin
Re: Review Request 26095: Fix instance summary visualisation.
On Sept. 26, 2014, 8:19 p.m., Joshua Cohen wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 440 https://reviews.apache.org/r/26095/diff/1/?file=706256#file706256line440 As far as I can see, allInstances is only used here to get the length, can we just make this: var totalInstancesToBeUpdated = Object.keys(updateUtil.getAllInstanceIds(details.update).allIds).length David McLaughlin wrote: Right. Did it this way because that one-liner exceeds 100 characters. I know in java we'd prefer to just inline and do a continuation indent rather than extract a separate var. Does that seem reasonable for js as well? - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54716 --- On Sept. 29, 2014, 4:11 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/ --- (Updated Sept. 29, 2014, 4:11 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-755 https://issues.apache.org/jira/browse/AURORA-755 Repository: aurora Description --- See JIRA ticket. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 92c78c28020d36b978f1a098202174015ace1316 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8ed95737ea69112d4ee04b687281d06a21d6abf6 Diff: https://reviews.apache.org/r/26095/diff/ Testing --- File Attachments Growing a job shows correct instance ids https://reviews.apache.org/media/uploaded/files/2014/09/26/246430ff-cf02-4701-9254-6f8e42f95b2a__Screen_Shot_2014-09-26_at_12.47.45_PM.png Instances removed are identified when shrinking job from 5 instances to 1 https://reviews.apache.org/media/uploaded/files/2014/09/26/b01c5d23-080e-4433-804b-c868215c0bcb__Screen_Shot_2014-09-26_at_12.47.56_PM.png Thanks, David McLaughlin
Re: Review Request 26095: Fix instance summary visualisation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54833 --- Ship it! Looks good to me. - Joshua Cohen On Sept. 29, 2014, 4:11 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/ --- (Updated Sept. 29, 2014, 4:11 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-755 https://issues.apache.org/jira/browse/AURORA-755 Repository: aurora Description --- See JIRA ticket. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 92c78c28020d36b978f1a098202174015ace1316 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8ed95737ea69112d4ee04b687281d06a21d6abf6 Diff: https://reviews.apache.org/r/26095/diff/ Testing --- File Attachments Growing a job shows correct instance ids https://reviews.apache.org/media/uploaded/files/2014/09/26/246430ff-cf02-4701-9254-6f8e42f95b2a__Screen_Shot_2014-09-26_at_12.47.45_PM.png Instances removed are identified when shrinking job from 5 instances to 1 https://reviews.apache.org/media/uploaded/files/2014/09/26/b01c5d23-080e-4433-804b-c868215c0bcb__Screen_Shot_2014-09-26_at_12.47.56_PM.png Thanks, David McLaughlin
Re: Review Request 23330: replace 143 kB favicon with 318 byte version
On Sept. 29, 2014, 4:31 p.m., Brian Wickman wrote: david -- could you publish a remote branch somewhere that i can use to merge this to master? the reviewboard diff does not contain the .ico and ./rbt patch does not support binary diffs. https://github.com/zxvdr/incubator-aurora/tree/favicon - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review54819 --- On July 31, 2014, 12:13 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/ --- (Updated July 31, 2014, 12:13 a.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-577 https://issues.apache.org/jira/browse/AURORA-577 Repository: aurora Description --- replace 143 kB favicon with 318 byte version. $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201 $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 143K Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 318 Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico Diffs - src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23330/diff/ Testing --- Thanks, David Robinson
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54854 --- Ship it! Ship It! - David McLaughlin On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54859 --- Ship it! Ship It! - Bill Farner On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js
Re: Review Request 26102: Dropping assert on empty desired instances set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 29, 2014, 8:04 p.m.) Review request for Aurora and Bill Farner. Changes --- Updated thrift layer to correctly populate IJobUpdate in case of empty desired state. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26123: Fail the build on lack of test coverage.
On Sept. 28, 2014, 4:05 a.m., Joshua Cohen wrote: build.gradle, line 571 https://reviews.apache.org/r/26123/diff/1/?file=707768#file707768line571 This seems like a potentially harsh penalty for good behavior if someone has to go from 0 to $MIN_COVERAGE in one go... I can imagine it encouraging the opposite of the desired behavior for someone adding new code to a legacy class but not adding code coverage because it means writing tests for the entire class as part of their change. I think you might have a different idea of how this diff behaves (and perhaps the message should be updated to reflect as much - please advise). This assertion will trip if there is _any_ test coverage added to one of these legacy classes. When you encounter this message, you should pat yourself on the back and remove the class from the legacy list. It's a provision to prevent the list itself from becoming stale. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54772 --- On Sept. 27, 2014, 11:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 27, 2014, 11:25 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26123: Fail the build on lack of test coverage.
On Sept. 27, 2014, 11:38 p.m., Zameer Manji wrote: Once this is commited, please make tickets for adding tests to these classes. I'm not sure how to best do this without either creating a ton of tickets that are bound to be forgotten, or a monster ticket that is difficult to track. Any bright ideas? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54771 --- On Sept. 27, 2014, 11:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 27, 2014, 11:25 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26123: Fail the build on lack of test coverage.
On Sept. 27, 2014, 4:38 p.m., Zameer Manji wrote: Once this is commited, please make tickets for adding tests to these classes. Bill Farner wrote: I'm not sure how to best do this without either creating a ton of tickets that are bound to be forgotten, or a monster ticket that is difficult to track. Any bright ideas? I have no ideas. In that case feel free to ignore my request for tickets. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54771 --- On Sept. 27, 2014, 4:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 27, 2014, 4:25 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 29, 2014, 9:10 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs (updated) - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54885 --- Ship it! src/main/python/apache/aurora/executor/aurora_executor.py https://reviews.apache.org/r/25974/#comment95208 TASK_FAILED in the message is redundant. - Bill Farner On Sept. 26, 2014, 9:24 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 26, 2014, 9:24 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 26113: Upgrade to gradle 2.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26113/#review54889 --- Ship it! build.gradle https://reviews.apache.org/r/26113/#comment95220 I think since this is groovy you can do it.name != 'compileGeneratedJava' instead? - Kevin Sweeney On Sept. 26, 2014, 11:57 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26113/ --- (Updated Sept. 26, 2014, 11:57 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- www.gradle.org/docs/2.1/release-notes.html www.gradle.org/docs/2.0/release-notes.html Distillation of major features that might help us: 2.1: - Easier use of community plugins - Incremental Java compilation - Use of HTTPS for mavenCentral() and jcenter() dependency repositories - PMD Console Output 2.0: - Support for Java 8 Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 gradle/wrapper/gradle-wrapper.jar 0087cd3b18659b5577cf6ad3ef61f8eb9416ebba gradle/wrapper/gradle-wrapper.properties 72018bc493792fe24592daa606f51dd5fca7897a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 212ba122acb539a2934690215bbcce095602d702 src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c8f73bb51e2f7d2aabd8e34480811cb8ed617cfa Diff: https://reviews.apache.org/r/26113/diff/ Testing --- git clean -fdx ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54890 --- Pinging Brian and Kevin to this review. - Zameer Manji On Sept. 29, 2014, 2:46 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 2:46 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 2:46 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Bill's Feedback Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54892 --- src/main/python/apache/aurora/executor/common/announcer.py https://reviews.apache.org/r/25974/#comment95226 Some context for the error would be helpful here - e.g. log.error(Initial connection to ZooKeeper timed out: %s % e). - Kevin Sweeney On Sept. 29, 2014, 2:46 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 2:46 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 26137: Fix help for new update command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/#review54894 --- Ship it! Ship It! - Zameer Manji On Sept. 29, 2014, 8:05 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/ --- (Updated Sept. 29, 2014, 8:05 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-748 https://issues.apache.org/jira/browse/aurora-748 Repository: aurora Description --- Fix help for new update command. Diffs - src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 Diff: https://reviews.apache.org/r/26137/diff/ Testing --- manual testing. Thanks, Mark Chu-Carroll
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54895 --- src/main/python/apache/aurora/executor/common/announcer.py https://reviews.apache.org/r/25974/#comment95228 Do you need input sanitization here? Could this logic be hidden behind an abstraction? It's unclear to me why the serverset connection code needs live with the executor data parsing code. - Kevin Sweeney On Sept. 29, 2014, 2:46 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 2:46 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review54896 --- Discarding this since Gradle 2.1 uses HTTPS - Kevin Sweeney On July 29, 2014, 12:14 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/ --- (Updated July 29, 2014, 12:14 p.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-620 https://issues.apache.org/jira/browse/AURORA-620 Repository: aurora Description --- Use JCenter over HTTPS instead of Maven Central Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb Diff: https://reviews.apache.org/r/24063/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 26154: Stop sending and receiving DeletedTasks framework message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/#review54898 --- Ship it! src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java https://reviews.apache.org/r/26154/#comment95229 Prefer http://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html From https://code.google.com/p/guava-libraries/wiki/StringsExplained (Note: If you're using JDK7, you should use the constants in StandardCharsets instead!) - Kevin Sweeney On Sept. 29, 2014, 3:12 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/ --- (Updated Sept. 29, 2014, 3:12 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: AURORA-764 https://issues.apache.org/jira/browse/AURORA-764 Repository: aurora Description --- Stop sending and receiving DeletedTasks framework message. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405 src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8 Diff: https://reviews.apache.org/r/26154/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 26113: Upgrade to gradle 2.1
On Sept. 29, 2014, 9:46 p.m., Kevin Sweeney wrote: build.gradle, line 58 https://reviews.apache.org/r/26113/diff/1/?file=707643#file707643line58 I think since this is groovy you can do it.name != 'compileGeneratedJava' instead? Fixed. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26113/#review54889 --- On Sept. 27, 2014, 6:57 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26113/ --- (Updated Sept. 27, 2014, 6:57 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- www.gradle.org/docs/2.1/release-notes.html www.gradle.org/docs/2.0/release-notes.html Distillation of major features that might help us: 2.1: - Easier use of community plugins - Incremental Java compilation - Use of HTTPS for mavenCentral() and jcenter() dependency repositories - PMD Console Output 2.0: - Support for Java 8 Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 gradle/wrapper/gradle-wrapper.jar 0087cd3b18659b5577cf6ad3ef61f8eb9416ebba gradle/wrapper/gradle-wrapper.properties 72018bc493792fe24592daa606f51dd5fca7897a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 212ba122acb539a2934690215bbcce095602d702 src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c8f73bb51e2f7d2aabd8e34480811cb8ed617cfa Diff: https://reviews.apache.org/r/26113/diff/ Testing --- git clean -fdx ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26113: Upgrade to gradle 2.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26113/ --- (Updated Sept. 29, 2014, 10:33 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- www.gradle.org/docs/2.1/release-notes.html www.gradle.org/docs/2.0/release-notes.html Distillation of major features that might help us: 2.1: - Easier use of community plugins - Incremental Java compilation - Use of HTTPS for mavenCentral() and jcenter() dependency repositories - PMD Console Output 2.0: - Support for Java 8 Diffs (updated) - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 gradle/wrapper/gradle-wrapper.jar 0087cd3b18659b5577cf6ad3ef61f8eb9416ebba gradle/wrapper/gradle-wrapper.properties 72018bc493792fe24592daa606f51dd5fca7897a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 212ba122acb539a2934690215bbcce095602d702 src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c8f73bb51e2f7d2aabd8e34480811cb8ed617cfa Diff: https://reviews.apache.org/r/26113/diff/ Testing --- git clean -fdx ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54902 --- Ship it! Ship It! - Kevin Sweeney On Sept. 29, 2014, 2:10 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 29, 2014, 2:10 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26154: Stop sending and receiving DeletedTasks framework message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/#review54903 --- src/main/python/apache/aurora/executor/gc_executor.py https://reviews.apache.org/r/26154/#comment95235 Should the reconcile_states() be adjusted as well to not return remote_gc set? Seems like a logical cleanup to do here. - Maxim Khutornenko On Sept. 29, 2014, 10:12 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/ --- (Updated Sept. 29, 2014, 10:12 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: AURORA-764 https://issues.apache.org/jira/browse/AURORA-764 Repository: aurora Description --- Stop sending and receiving DeletedTasks framework message. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405 src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8 Diff: https://reviews.apache.org/r/26154/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 26102: Dropping assert on empty desired instances set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 29, 2014, 10:57 p.m.) Review request for Aurora and Bill Farner. Changes --- CR comments. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664 src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924 src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54908 --- Ship it! Thanks for clarifying the assert message. - Joshua Cohen On Sept. 29, 2014, 9:10 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 29, 2014, 9:10 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26102: Dropping assert on empty desired instances set.
On Sept. 29, 2014, 8:12 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java, line 88 https://reviews.apache.org/r/26102/diff/2/?file=708338#file708338line88 Your call on whether this makes things more readable, but i could imagine some cleanup here: Function.., .. toResources; IResourceAggregate desired = desiredState.transform(TO_RESOURCES).or(EMPTY); Sure, why not. On Sept. 29, 2014, 8:12 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1357 https://reviews.apache.org/r/26102/diff/2/?file=708339#file708339line1357 @Nullable, though i wouldn't mind seeing Optional here and orNull() below. Done. On Sept. 29, 2014, 8:12 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java, line 736 https://reviews.apache.org/r/26102/diff/2/?file=708343#file708343line736 Would still like to see the test case for update behavior when instanceCount is reduced, and TaskConfig is unchanged. Thanks, added and fixed a few more issues. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/#review54861 --- On Sept. 29, 2014, 8:04 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 29, 2014, 8:04 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26102: Dropping assert on empty desired instances set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/#review54911 --- Ship it! src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java https://reviews.apache.org/r/26102/#comment95243 Comment lacks context. This should suffice: // Desired state is assumed to be non-null when AddTask is used. src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java https://reviews.apache.org/r/26102/#comment95244 Adding optional here seems circuitous. Why not avoid calling `asMap` if `config` is null? instructions.isSetDesiredState() ? asMap(..) : ImmutableMap.of() This matches the approach you used in `UpdateFactory`. src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java https://reviews.apache.org/r/26102/#comment95245 s/DoesNotThrow// - Bill Farner On Sept. 29, 2014, 10:57 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 29, 2014, 10:57 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664 src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924 src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54915 --- Ship it! Ship It! - Kevin Sweeney On Sept. 19, 2014, 2:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 2:39 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js
Re: Review Request 26102: Dropping assert on empty desired instances set.
On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java, line 197 https://reviews.apache.org/r/26102/diff/3/?file=708816#file708816line197 Adding optional here seems circuitous. Why not avoid calling `asMap` if `config` is null? instructions.isSetDesiredState() ? asMap(..) : ImmutableMap.of() This matches the approach you used in `UpdateFactory`. I guess if it does not have to be public I agree. Changed it to private and dropped Optional. On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java, line 57 https://reviews.apache.org/r/26102/diff/3/?file=708815#file708815line57 Comment lacks context. This should suffice: // Desired state is assumed to be non-null when AddTask is used. Done. On Sept. 29, 2014, 11:10 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java, line 377 https://reviews.apache.org/r/26102/diff/3/?file=708818#file708818line377 s/DoesNotThrow// Done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/#review54911 --- On Sept. 29, 2014, 10:57 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 29, 2014, 10:57 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664 src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924 src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26102: Dropping assert on empty desired instances set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 29, 2014, 11:32 p.m.) Review request for Aurora and Bill Farner. Changes --- CR comments. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664 src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924 src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 62d08ad141f271ffb2627df138a5ef445f8f88d7 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4934cbbc55e14756c7719be1bd7bb8dc1f31592f Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 29, 2014, 11:33 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Changes --- - change to using instruction instead of line coverage, since this is more prominently displayed in the HTML report - fixed coverage computation to match HTML report - pulled function call out of assertion to make a failed assertion show the resulting double value Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs (updated) - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26102: Dropping assert on empty desired instances set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/#review54919 --- Ship it! src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java https://reviews.apache.org/r/26102/#comment95255 rejigger this so the ImmutableMap.copyOf doesn't wrap the ImmutableMap.of - Bill Farner On Sept. 29, 2014, 11:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26102/ --- (Updated Sept. 29, 2014, 11:32 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-756 https://issues.apache.org/jira/browse/AURORA-756 Repository: aurora Description --- Dropping assert on empty desired instances set. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java ea6b7d93b39fbe4797f253d08bbd9fb2b99fb664 src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java 105426f35c5d1dd6841d844d4e223dbb40f28215 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fa54d5b7898c6460f1889f698e8f2f687b64c924 src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java b271697976e67b8727c461b94697195539439ad5 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java bc0b830491303574a186ee958b8e0ad6a2495427 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 62d08ad141f271ffb2627df138a5ef445f8f88d7 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 11cc2f6fd47e316a42cb2f241344e356eaae4920 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 83630a350f488d002a653dd31c170a1e918e49b7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4934cbbc55e14756c7719be1bd7bb8dc1f31592f Diff: https://reviews.apache.org/r/26102/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54916 --- src/main/python/apache/aurora/executor/common/announcer.py https://reviews.apache.org/r/25974/#comment95251 this data is available within the mesos_task struct created in from_assigned_task. you should be getting the information from there as it may contain default values not required to be populated in the executorConfig json (in which case you'd be getting KeyErrors from make_serverset.) src/main/python/apache/aurora/executor/common/announcer.py https://reviews.apache.org/r/25974/#comment95257 i feel like we should be calling start_async instead, though this complicates implementation slightly. we want the creation of all the status managers to be non-blocking since the executor will be in a transient (TASK_STARTING) state, which can possibly timeout and go to TASK_LOST, which is less preferable than TASK_FAILED. client.create_async returns a threading.Event. we'd want (in a separate thread) to event.wait(timeout=timeout) and if not event.is_set(), set the .healthy property on the Announcer to StatusResult(..., mesos_pb2.TASK_FAILED) alternately, you could ignore the threading.Event from create_async and bake that logic into the contract between Announcer-ServerSetJoinThread. i'm not sure which is simpler or cleaner. - Brian Wickman On Sept. 29, 2014, 9:46 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 9:46 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 5:54 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Brian's Feedback except for calling start_async() Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
On Sept. 29, 2014, 4:43 p.m., Brian Wickman wrote: src/main/python/apache/aurora/executor/common/announcer.py, lines 112-116 https://reviews.apache.org/r/25974/diff/4/?file=708538#file708538line112 this data is available within the mesos_task struct created in from_assigned_task. you should be getting the information from there as it may contain default values not required to be populated in the executorConfig json (in which case you'd be getting KeyErrors from make_serverset.) done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54916 --- On Sept. 29, 2014, 5:54 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 5:54 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-769 https://issues.apache.org/jira/browse/AURORA-769 Repository: aurora Description --- Perform job update no-op detection in SchedulerThriftInterface. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2847bdbb773f4d5a7f31b52ceb806880e736a259 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java f37fbef4c50cfc2d98bc1fd89376a210f4fa8643 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 97bc1dfbbd83d30d6e94b70902f225f2c92acb77 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 12b19fd333a95d0d3d1864bac629d011c271ee52 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 7254588b55df9a12217c8ec172abc5976892497e Diff: https://reviews.apache.org/r/26158/diff/ Testing --- ./gradlew build -Pq Ran a no-op update in vagrant and saw expected behavior. Thanks, Bill Farner
Re: Review Request 23330: replace 143 kB favicon with 318 byte version
On Sept. 29, 2014, 4:31 p.m., Brian Wickman wrote: david -- could you publish a remote branch somewhere that i can use to merge this to master? the reviewboard diff does not contain the .ico and ./rbt patch does not support binary diffs. David Robinson wrote: https://github.com/zxvdr/incubator-aurora/tree/favicon pushed amended commit commit 25b7b3cc87ae31793bd0c1bb69515418feedb2e8 Author: David Robinson drobin...@twitter.com Date: Mon Sep 29 11:28:21 2014 -0700 replace 143 kB favicon with 2 kB version. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review54819 --- On July 31, 2014, 12:13 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/ --- (Updated July 31, 2014, 12:13 a.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-577 https://issues.apache.org/jira/browse/AURORA-577 Repository: aurora Description --- replace 143 kB favicon with 318 byte version. $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201 $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 143K Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 318 Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico Diffs - src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23330/diff/ Testing --- Thanks, David Robinson
Re: Review Request 23330: replace 143 kB favicon with 318 byte version
On Sept. 29, 2014, 4:31 p.m., Brian Wickman wrote: david -- could you publish a remote branch somewhere that i can use to merge this to master? the reviewboard diff does not contain the .ico and ./rbt patch does not support binary diffs. David Robinson wrote: https://github.com/zxvdr/incubator-aurora/tree/favicon Brian Wickman wrote: pushed amended commit commit 25b7b3cc87ae31793bd0c1bb69515418feedb2e8 Author: David Robinson drobin...@twitter.com Date: Mon Sep 29 11:28:21 2014 -0700 replace 143 kB favicon with 2 kB version. argh forgot to add 'Reviewed at' link...my bad. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review54819 --- On July 31, 2014, 12:13 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/ --- (Updated July 31, 2014, 12:13 a.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-577 https://issues.apache.org/jira/browse/AURORA-577 Repository: aurora Description --- replace 143 kB favicon with 318 byte version. $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201 $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 143K Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 318 Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico Diffs - src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23330/diff/ Testing --- Thanks, David Robinson
Review Request 26160: Fixing consumption double counting in quota checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26160/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-768 https://issues.apache.org/jira/browse/AURORA-768 Repository: aurora Description --- Accounting for both initial and desired states when filtering out non updating tasks. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java a0da417623ac6c3c592fe22cc7c897d74151bfe1 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f961494adafce0e815175f59a7dd4037bec52559 Diff: https://reviews.apache.org/r/26160/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/#review54934 --- Not quite obvious from the diff: why was not it enough to check the noop condition in the controller only? - Maxim Khutornenko On Sept. 30, 2014, 12:59 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/ --- (Updated Sept. 30, 2014, 12:59 a.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-769 https://issues.apache.org/jira/browse/AURORA-769 Repository: aurora Description --- Perform job update no-op detection in SchedulerThriftInterface. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2847bdbb773f4d5a7f31b52ceb806880e736a259 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java f37fbef4c50cfc2d98bc1fd89376a210f4fa8643 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 97bc1dfbbd83d30d6e94b70902f225f2c92acb77 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 12b19fd333a95d0d3d1864bac629d011c271ee52 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 7254588b55df9a12217c8ec172abc5976892497e Diff: https://reviews.apache.org/r/26158/diff/ Testing --- ./gradlew build -Pq Ran a no-op update in vagrant and saw expected behavior. Thanks, Bill Farner
Re: Review Request 26154: Stop sending and receiving DeletedTasks framework message.
On Sept. 29, 2014, 10:51 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/executor/gc_executor.py, line 439 https://reviews.apache.org/r/26154/diff/1/?file=708560#file708560line439 Should the reconcile_states() be adjusted as well to not return remote_gc set? Seems like a logical cleanup to do here. I looked into this early on, but backed away because `reconcile_states` is directly called in unit tests so i stopped short. My approach on this is also influenced by the impending sunsetting of the GC executor, so i would like to avoid unnecessary churn. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/#review54903 --- On Sept. 29, 2014, 10:12 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/ --- (Updated Sept. 29, 2014, 10:12 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: AURORA-764 https://issues.apache.org/jira/browse/AURORA-764 Repository: aurora Description --- Stop sending and receiving DeletedTasks framework message. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405 src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8 Diff: https://reviews.apache.org/r/26154/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 26160: Fixing consumption double counting in quota checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26160/#review54945 --- Ship it! src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java https://reviews.apache.org/r/26160/#comment95268 method name is no longer correct src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java https://reviews.apache.org/r/26160/#comment95267 can you rephrease this in terms of what it _does_ rather than does _not_ do? ditto for the test case below - Bill Farner On Sept. 30, 2014, 1:32 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26160/ --- (Updated Sept. 30, 2014, 1:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-768 https://issues.apache.org/jira/browse/AURORA-768 Repository: aurora Description --- Accounting for both initial and desired states when filtering out non updating tasks. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java a0da417623ac6c3c592fe22cc7c897d74151bfe1 src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f961494adafce0e815175f59a7dd4037bec52559 Diff: https://reviews.apache.org/r/26160/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26154: Stop sending and receiving DeletedTasks framework message.
On Sept. 29, 2014, 10:26 p.m., Kevin Sweeney wrote: src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java, line 21 https://reviews.apache.org/r/26154/diff/1/?file=708562#file708562line21 Prefer http://docs.oracle.com/javase/7/docs/api/java/nio/charset/StandardCharsets.html From https://code.google.com/p/guava-libraries/wiki/StringsExplained (Note: If you're using JDK7, you should use the constants in StandardCharsets instead!) Thanks! Done throughout the project. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/#review54898 --- On Sept. 29, 2014, 10:12 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/ --- (Updated Sept. 29, 2014, 10:12 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: AURORA-764 https://issues.apache.org/jira/browse/AURORA-764 Repository: aurora Description --- Stop sending and receiving DeletedTasks framework message. Diffs - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405 src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8 Diff: https://reviews.apache.org/r/26154/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
Re: Review Request 26154: Stop sending and receiving DeletedTasks framework message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26154/ --- (Updated Sept. 30, 2014, 3:36 a.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: AURORA-764 https://issues.apache.org/jira/browse/AURORA-764 Repository: aurora Description --- Stop sending and receiving DeletedTasks framework message. Diffs (updated) - build.gradle 325a50e628ec0e2e21e812ef1daba98fc99a43d4 src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java 2b96427b795227bf92c9866a7df808786efbd93c src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java 826c0adb17ec8d5fec481bae28f5bf7f17d5c5c2 src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 71bc4c903aa389cf8a4c90d2ad07af062ed81829 src/main/python/apache/aurora/executor/gc_executor.py 6701caa34ca70225d2d286c1b2912933eb3ba405 src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 842b011049018724b114898ace3d870f51ccfab4 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 src/test/java/org/apache/aurora/scheduler/cron/ExpectedPrediction.java ccfbecb6fed2ae3ce01ba712dee932454bb6127b src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java ec467aa9a916ff8bcfc5d7fdc1ee6d85a0650157 src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 35ccd14ea65fb3421b3fcdb1840175d4f724e6b6 src/test/python/apache/aurora/executor/test_gc_executor.py e9bc7eb3b586c49e718804cbd630a871318caef8 Diff: https://reviews.apache.org/r/26154/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Bill Farner
