Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55349 --- Ship it! Great catch! The is_set got lost there via multiple conflict resolutions while the parallel updater was under construction. - Maxim Khutornenko On Oct. 3, 2014, 4:52 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 3, 2014, 4:52 a.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Repository: aurora Description --- Fixes two problems: - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 Diff: https://reviews.apache.org/r/26308/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 26300: Don't kill GC Executor after period of inactivity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26300/#review55350 --- Ship it! Ship It! - Brian Wickman On Oct. 3, 2014, 1:59 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26300/ --- (Updated Oct. 3, 2014, 1:59 a.m.) Review request for Aurora, Ben Mahler, Vinod Kone, and Brian Wickman. Bugs: AURORA-788 https://issues.apache.org/jira/browse/AURORA-788 Repository: aurora Description --- The GC executor is configured to exit after 15 minutes of inactivity. This leads to a race where the mesos slave gets a launchTask message for a GC executor just as the executor has exited, causing TASK_LOST noise. This also increases the risk that a slave will lose its GC executor due to the scheduler not being able to find a slot for it (since GC executors will have a higher churn rate). Cluster operators will still be able to deploy new versions of the GC executor as the 24-hour max lifetime limit is still in place. This patch only removes the inactivity limit. Diffs - src/main/python/apache/aurora/executor/gc_executor.py 44eb0da984a126536f0d277da3da128089201a47 src/test/python/apache/aurora/executor/test_gc_executor.py 774c9ba0d5c31fc4c46dbe257579e013460fa943 Diff: https://reviews.apache.org/r/26300/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:gc_executor Thanks, Kevin Sweeney
Re: Review Request 26269: Remove UI from page titles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26269/#review55351 --- David - ping? - Bill Farner On Oct. 2, 2014, 3:48 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26269/ --- (Updated Oct. 2, 2014, 3:48 p.m.) Review request for Aurora and David McLaughlin. Repository: aurora Description --- Aurora UI is a weird thing to call a website. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 40617aa5f84170abe8e2a2b8bc06913f90ae8eb0 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 3a07ce7927e936d2d30b8e19b2362a073372ad7b Diff: https://reviews.apache.org/r/26269/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 26098: Fix checkstyle and add checkstyle back to jenkins.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26098/#review55352 --- Ship it! Thanks! - Bill Farner On Oct. 3, 2014, 4:38 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26098/ --- (Updated Oct. 3, 2014, 4:38 p.m.) Review request for Aurora, Mark Chu-Carroll and Bill Farner. Repository: aurora Description --- Fix checkstyle and add checkstyle back to jenkins. Diffs - build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3 src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654 src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/main/python/apache/aurora/client/api/updater_util.py 9bfc27da17f457218878cf3bdf378d38a99dd4cb src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5 src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9 src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69 src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1 src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5 src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e7b1fbbdb7a3cdefa7bfe6a src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9 src/main/python/apache/aurora/executor/gc_executor.py 44eb0da984a126536f0d277da3da128089201a47 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19 src/test/python/apache/aurora/client/api/test_api.py 43370d8b83e03b66f72a2fe540c82740231422aa src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898 src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22 src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4 src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f src/test/python/apache/aurora/executor/test_gc_executor.py 774c9ba0d5c31fc4c46dbe257579e013460fa943 Diff: https://reviews.apache.org/r/26098/diff/ Testing --- Running build.sh now. Thanks, Brian Wickman
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review55353 --- Anything left to do here before Kevin commits? - Bill Farner On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js
Review Request 26320: Skip checkstyle on python file in 3rdparty.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-780 https://issues.apache.org/jira/browse/AURORA-780 Repository: aurora Description --- Skip checkstyle on python file in 3rdparty. Diffs - 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b Diff: https://reviews.apache.org/r/26320/diff/ Testing --- Committed file w/ precommit hook in place. Thanks, Joshua Cohen
Re: Review Request 26298: Use a less broad retry loop for RPCs.
On Oct. 3, 2014, 12:21 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/scheduler_client.py, line 286 https://reviews.apache.org/r/26298/diff/1/?file=713279#file713279line286 Why not just add a break into the Exception catcher instead? Maxim Khutornenko wrote: Actually, we are throwing there already. Wait, how is the exception is trapped in that loop? Bill Farner wrote: I scratched my head at this for a while, and wound up with this review: https://reviews.apache.org/r/26308/ AFAICT `threading.Event` does not override `__bool__`, so those branches are never entered, and we loop until the timer is up. Maxim Khutornenko wrote: I am assuming this patch will be revisited then? Yup. I'm going to open a new review to introduce the sleep between transient error retries, though. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26298/#review55295 --- On Oct. 3, 2014, 12:18 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26298/ --- (Updated Oct. 3, 2014, 12:18 a.m.) Review request for Aurora, Mark Chu-Carroll and Maxim Khutornenko. Repository: aurora Description --- A few times when making changes, i've found myself confused at a stalled test and spiked CPU, only to find that my test should have failed, but an exception is trapped in this retry loop. The key change here is that unknown exceptions will break the loop. Making this change pointed out what should have been a test failure in `test_transient_error`, where an exception caused by an unexpected call to `getVersion` was swallowed. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 Diff: https://reviews.apache.org/r/26298/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 26298: Use a less broad retry loop for RPCs.
On Oct. 3, 2014, 12:21 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/scheduler_client.py, line 286 https://reviews.apache.org/r/26298/diff/1/?file=713279#file713279line286 Why not just add a break into the Exception catcher instead? Maxim Khutornenko wrote: Actually, we are throwing there already. Wait, how is the exception is trapped in that loop? Bill Farner wrote: I scratched my head at this for a while, and wound up with this review: https://reviews.apache.org/r/26308/ AFAICT `threading.Event` does not override `__bool__`, so those branches are never entered, and we loop until the timer is up. Maxim Khutornenko wrote: I am assuming this patch will be revisited then? Bill Farner wrote: Yup. I'm going to open a new review to introduce the sleep between transient error retries, though. Scratch that - didn't notice the local raise-catch on TransientError. Closing. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26298/#review55295 --- On Oct. 3, 2014, 12:18 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26298/ --- (Updated Oct. 3, 2014, 12:18 a.m.) Review request for Aurora, Mark Chu-Carroll and Maxim Khutornenko. Repository: aurora Description --- A few times when making changes, i've found myself confused at a stalled test and spiked CPU, only to find that my test should have failed, but an exception is trapped in this retry loop. The key change here is that unknown exceptions will break the loop. Making this change pointed out what should have been a test failure in `test_transient_error`, where an exception caused by an unexpected call to `getVersion` was swallowed. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 Diff: https://reviews.apache.org/r/26298/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
On Oct. 3, 2014, 4:43 p.m., Bill Farner wrote: Anything left to do here before Kevin commits? Nope, he tried to commit but was blocked by checkstyle flagging 3rdparty python (https://issues.apache.org/jira/browse/AURORA-780). I sent a review out to address that this morning, so once that ships he should be able to merge this. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review55353 --- On Sept. 19, 2014, 9:39 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bugs: AURORA-678 https://issues.apache.org/jira/browse/AURORA-678 Repository: aurora Description --- Serve HTTP assets out of a standard claspath root. There's a lot of moved files in this diff, so apologies for it being essentially unreadable. ReviewBoard actually seems to choke about half the time just loading the individual pages. For the sake of convenience/sanity, the actual meat of the changes can be found in: build.gradle: https://reviews.apache.org/r/25835/diff/#336 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java: https://reviews.apache.org/r/25835/diff/1/?page=17#338 src/main/resources/scheduler/assets/index.html: https://reviews.apache.org/r/25835/diff/1/?page=18#363 Everything else is just a rename/move. Diffs - 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json 3rdparty/javascript/bower_components/angular-bootstrap/bower.json 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js 3rdparty/javascript/bower_components/angular-route/.bower.json 3rdparty/javascript/bower_components/angular-route/README.md 3rdparty/javascript/bower_components/angular-route/angular-route.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map 3rdparty/javascript/bower_components/angular-route/bower.json 3rdparty/javascript/bower_components/angular/.bower.json 3rdparty/javascript/bower_components/angular/README.md 3rdparty/javascript/bower_components/angular/angular-csp.css 3rdparty/javascript/bower_components/angular/angular.js 3rdparty/javascript/bower_components/angular/angular.min.js 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 3rdparty/javascript/bower_components/angular/angular.min.js.map 3rdparty/javascript/bower_components/angular/bower.json 3rdparty/javascript/bower_components/bootstrap/.bower.json 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js 3rdparty/javascript/bower_components/bootstrap/LICENSE 3rdparty/javascript/bower_components/bootstrap/README.md 3rdparty/javascript/bower_components/bootstrap/bower.json 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
Re: Review Request 25972: Make thermos more cognizant of user deletions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 5:55 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Changes --- Address Kevin's feedback Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos. This change allows a process in the Thermos state machine to go directly from WAITING - FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames. Diffs (updated) - src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068 src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0 src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512 src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 Diff: https://reviews.apache.org/r/25972/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 25972: Make thermos more cognizant of user deletions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55371 --- Looks great- thanks! src/test/python/apache/thermos/core/test_helper.py https://reviews.apache.org/r/25972/#comment95731 from psutil._common import puids - Joe Smith On Oct. 3, 2014, 10:55 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 10:55 a.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos. This change allows a process in the Thermos state machine to go directly from WAITING - FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames. Diffs - src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068 src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0 src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512 src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 Diff: https://reviews.apache.org/r/25972/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 25972: Make thermos more cognizant of user deletions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55370 --- Ship it! src/main/python/apache/thermos/core/helper.py https://reviews.apache.org/r/25972/#comment95730 Should we log.debug on the absence of uid from the checkpoint record? - Kevin Sweeney On Oct. 3, 2014, 10:55 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 10:55 a.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos. This change allows a process in the Thermos state machine to go directly from WAITING - FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames. Diffs - src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068 src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0 src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512 src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 Diff: https://reviews.apache.org/r/25972/diff/ Testing --- Thanks, Brian Wickman
Review Request 26324: Increase timeout for PyPI HTTP fetches.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- This patch increases the timeout for PyPI HTTP fetches. This was recomended by John Sirois to reduce the flakeyness of Python tests on Apache Jenkins. Diffs - build-support/jenkins/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26328: Add aurora update list and aurora update status commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 3, 2014, 4:47 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description (updated) --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 26328: Add aurora update list and aurora update status commands.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55390
---
src/main/python/apache/aurora/client/cli/__init__.py
https://reviews.apache.org/r/26328/#comment95746
I think we should put an ISO formatted date like
`datetime.datetime.fromtimestamp(time.time()).strftime('%Y-%m-%d %H:%M:%S')`.
- Zameer Manji
On Oct. 3, 2014, 1:47 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/
---
(Updated Oct. 3, 2014, 1:47 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: aurora-779
https://issues.apache.org/jira/browse/aurora-779
Repository: aurora
Description
---
Improve handling of unknown errors in the aurora client.
Instead of dumping the stack on the user's terminal, or
absorbing the error and generating a brief error
message, the client now writes detailed information about
the error is written into an error log file, and the
user is given a clean error message referring them to that
file for details.
Diffs
-
src/main/python/apache/aurora/client/cli/__init__.py
e0c3050151bca1128ed7e476ec5133407a20f6c2
src/main/python/apache/aurora/client/cli/context.py
f639af7de93a069b278dc494b6f92a2f6b10de9c
src/main/python/apache/aurora/client/cli/options.py
9a81a1d7d04c6648e94ff117429278317a9dbed8
src/main/python/apache/aurora/client/cli/standalone_client.py
fd2232bc8b7e5caf487291f657a50184391a8c69
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_api_from_cli.py
78f21d2f20cf71fa2dfe0614885d44d2948decd2
src/test/python/apache/aurora/client/cli/test_create.py
6e55188bdfc576506848605debb391288e696fe3
src/test/python/apache/aurora/client/cli/test_supdate.py
2782fee2867c6ef79349240299de082f07f7967a
src/test/python/apache/aurora/client/cli/util.py
e1ee884c06f3bc22bcd9e908ff61af9459a0b535
Diff: https://reviews.apache.org/r/26328/diff/
Testing
---
New unit test.
Thanks,
Mark Chu-Carroll
Re: Review Request 26328: Add aurora update list and aurora update status commands.
On Oct. 3, 2014, 1:56 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 434
https://reviews.apache.org/r/26328/diff/1/?file=713687#file713687line434
I think we should put an ISO formatted date like
`datetime.datetime.fromtimestamp(time.time()).strftime('%Y-%m-%d
%H:%M:%S')`.
Kevin pointed out to me we could just use `datetime.datetime.isoformat`:
https://docs.python.org/2/library/datetime.html#datetime.datetime.isoformat
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55390
---
On Oct. 3, 2014, 1:47 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/
---
(Updated Oct. 3, 2014, 1:47 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: aurora-779
https://issues.apache.org/jira/browse/aurora-779
Repository: aurora
Description
---
Improve handling of unknown errors in the aurora client.
Instead of dumping the stack on the user's terminal, or
absorbing the error and generating a brief error
message, the client now writes detailed information about
the error is written into an error log file, and the
user is given a clean error message referring them to that
file for details.
Diffs
-
src/main/python/apache/aurora/client/cli/__init__.py
e0c3050151bca1128ed7e476ec5133407a20f6c2
src/main/python/apache/aurora/client/cli/context.py
f639af7de93a069b278dc494b6f92a2f6b10de9c
src/main/python/apache/aurora/client/cli/options.py
9a81a1d7d04c6648e94ff117429278317a9dbed8
src/main/python/apache/aurora/client/cli/standalone_client.py
fd2232bc8b7e5caf487291f657a50184391a8c69
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_api_from_cli.py
78f21d2f20cf71fa2dfe0614885d44d2948decd2
src/test/python/apache/aurora/client/cli/test_create.py
6e55188bdfc576506848605debb391288e696fe3
src/test/python/apache/aurora/client/cli/test_supdate.py
2782fee2867c6ef79349240299de082f07f7967a
src/test/python/apache/aurora/client/cli/util.py
e1ee884c06f3bc22bcd9e908ff61af9459a0b535
Diff: https://reviews.apache.org/r/26328/diff/
Testing
---
New unit test.
Thanks,
Mark Chu-Carroll
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55402 --- Pinging Kevin for final ship it and commit. - Zameer Manji On Oct. 2, 2014, 6:44 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Oct. 2, 2014, 6:44 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji
Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55404 --- Kevin, Mark - ping? - Bill Farner On Oct. 3, 2014, 4:52 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 3, 2014, 4:52 a.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Repository: aurora Description --- Fixes two problems: - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 Diff: https://reviews.apache.org/r/26308/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55405 --- src/test/python/apache/aurora/client/cli/test_api_from_cli.py https://reviews.apache.org/r/26308/#comment95761 Can you also assert that this was called? src/test/python/apache/aurora/client/cli/test_api_from_cli.py https://reviews.apache.org/r/26308/#comment95762 can you instead .assert_called_once_with(args) ? - Joe Smith On Oct. 2, 2014, 9:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 2, 2014, 9:52 p.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Repository: aurora Description --- Fixes two problems: - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 Diff: https://reviews.apache.org/r/26308/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Re: Review Request 25972: Make thermos more cognizant of user deletions
On Oct. 3, 2014, 6:17 p.m., Joe Smith wrote: src/test/python/apache/thermos/core/test_helper.py, line 33 https://reviews.apache.org/r/25972/diff/2/?file=713532#file713532line33 from psutil._common import puids Looks like I wasn't using this at all, so dropped entirely. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55371 --- On Oct. 3, 2014, 5:55 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 5:55 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos. This change allows a process in the Thermos state machine to go directly from WAITING - FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames. Diffs - src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068 src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0 src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512 src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 Diff: https://reviews.apache.org/r/25972/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 25972: Make thermos more cognizant of user deletions
On Oct. 3, 2014, 6:18 p.m., Kevin Sweeney wrote: src/main/python/apache/thermos/core/helper.py, line 157 https://reviews.apache.org/r/25972/diff/2/?file=713528#file713528line157 Should we log.debug on the absence of uid from the checkpoint record? Sure, won't hurt. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55370 --- On Oct. 3, 2014, 5:55 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 5:55 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos. This change allows a process in the Thermos state machine to go directly from WAITING - FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames. Diffs - src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068 src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0 src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512 src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 Diff: https://reviews.apache.org/r/25972/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 25972: Make thermos more cognizant of user deletions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 10:16 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Changes --- Address feedback. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos. This change allows a process in the Thermos state machine to go directly from WAITING - FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames. Diffs (updated) - src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068 src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0 src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512 src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 Diff: https://reviews.apache.org/r/25972/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 25972: Make thermos more cognizant of user deletions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55410 --- Ship it! Ship It! - Joe Smith On Oct. 3, 2014, 3:16 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 3:16 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos. This change allows a process in the Thermos state machine to go directly from WAITING - FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames. Diffs - src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068 src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0 src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512 src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 Diff: https://reviews.apache.org/r/25972/diff/ Testing --- Thanks, Brian Wickman
Review Request 26333: Add exit status contract between thermos runner and aurora executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/ --- Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures. Diffs - src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413 src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b Diff: https://reviews.apache.org/r/26333/diff/ Testing --- Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here. Thanks, Brian Wickman
Re: Review Request 26333: Add exit status contract between thermos runner and aurora executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/#review55413 --- Hmm, I might have prematurely sent this review. I think this will still yield LOST tasks if there is no associated checkpoint stream, so it looks like there's still some contract to be mended between the ThermosTaskRunner and AuroraExecutor. - Brian Wickman On Oct. 3, 2014, 11:19 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/ --- (Updated Oct. 3, 2014, 11:19 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures. Diffs - src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413 src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b Diff: https://reviews.apache.org/r/26333/diff/ Testing --- Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here. Thanks, Brian Wickman
Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 3, 2014, 11:25 p.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Changes --- I need to do some more work here - started pulling a thread on using `TaskQuery.jobKeys`. Still need to correct some tests after that switch. Repository: aurora Description --- Fixes two problems: - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. Diffs (updated) - src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba src/main/python/apache/aurora/client/api/command_runner.py a1fed5fc75dde3a79c840515e6daa4741156ef97 src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654 src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/main/python/apache/aurora/common/aurora_job_key.py a7ca7b6df6b9566b3ce617283ccac948deb2eb83 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 src/test/python/apache/aurora/client/cli/test_task_run.py 1ce9a632874e818eee71573cd481842affae3615 src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4 Diff: https://reviews.apache.org/r/26308/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
