Re: Review Request 26328: Add aurora update list and aurora update status commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55493 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/26328/#comment95880 This is a filename, not a print statement. The only reason that I'm using a time there is to ensure that it's unique. Creating filenames in the users workspace with spaces in it causes lots of unpleasantness for the user. It's just obnoxious to do that. - Mark Chu-Carroll On Oct. 3, 2014, 4:47 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 3, 2014, 4:47 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 26004: Add aurora update list and aurora update status commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Oct. 6, 2014, 9:16 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-742 https://issues.apache.org/jira/browse/aurora-742 Repository: aurora Description --- Add support for commands to query and display active updates being managed by the scheduler. Two commands are added: * aurora update list, which shows all active updates that are being processed by the server. * aurora update status, which shows detailed status information about an update in-progress on the server. Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review55511 --- *ping* Kevin. - Joshua Cohen On Oct. 3, 2014, 4:51 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/ --- (Updated Oct. 3, 2014, 4:51 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-780 https://issues.apache.org/jira/browse/AURORA-780 Repository: aurora Description --- Skip checkstyle on python file in 3rdparty. Diffs - 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b Diff: https://reviews.apache.org/r/26320/diff/ Testing --- Committed file w/ precommit hook in place. Thanks, Joshua Cohen
Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review55512 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/26363/#comment95894 Are these debug statements? Should they be removed or switched to log.debug? src/test/python/apache/aurora/client/cli/test_update.py https://reviews.apache.org/r/26363/#comment95895 This sequence of mocks and writing config to a file is repeated in... many (all?) of these tests. Can you refactor to remove the repetition? - Joshua Cohen On Oct. 6, 2014, 2:57 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/ --- (Updated Oct. 6, 2014, 2:57 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-792 https://issues.apache.org/jira/browse/aurora-792 Repository: aurora Description --- Make the large-update check in the client update command consider instance parameters. Diffs - src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 Diff: https://reviews.apache.org/r/26363/diff/ Testing --- New unit tests added, all test pass. Thanks, Mark Chu-Carroll
Re: Review Request 26137: Fix help for new update command.
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote: src/main/python/apache/aurora/client/cli/update.py, line 45 https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45 Could you update a test case to catch accessing these as properties to catch accidental regressions? David McLaughlin wrote: Piggy backing this issue to add that my ship it is pending a test for this command at least? Mark Chu-Carroll wrote: I don't know of any way to write a single test that would always catch this. Joe Smith wrote: Rebased off your diff: [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff diff --git a/src/main/python/apache/aurora/client/cli/update.py b/src/main/python/apache/aurora/client/cli/update.py index 41475a7..ef07a11 100644 --- a/src/main/python/apache/aurora/client/cli/update.py +++ b/src/main/python/apache/aurora/client/cli/update.py @@ -42,7 +42,6 @@ class StartUpdate(Verb): INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT ] - @property def help(self): return textwrap.dedent(\ Start a scheduler-driven rolling upgrade on a running job, using the update diff --git a/src/test/python/apache/aurora/client/cli/test_update.py b/src/test/python/apache/aurora/client/cli/test_update.py index eeed774..1a38ffe 100644 --- a/src/test/python/apache/aurora/client/cli/test_update.py +++ b/src/test/python/apache/aurora/client/cli/test_update.py @@ -23,6 +23,7 @@ from apache.aurora.client.api.quota_check import QuotaCheck from apache.aurora.client.api.scheduler_mux import SchedulerMux from apache.aurora.client.cli import EXIT_INVALID_CONFIGURATION, EXIT_OK from apache.aurora.client.cli.client import AuroraCommandLine +from apache.aurora.client.cli.update import StartUpdate from apache.aurora.client.cli.util import AuroraClientCommandTest, FakeAuroraCommandContext, IOMock from apache.aurora.config import AuroraConfig @@ -301,6 +302,10 @@ class TestUpdateCommand(AuroraClientCommandTest): 'Update completed successfully'] assert mock_err.get() == [] + def test_update_start_help(self): +start = StartUpdate() +assert 'Start a scheduler-driven rolling' in start.help + @classmethod def assert_correct_addinstance_calls(cls, api): assert api.addInstances.call_count == 20 [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants ./src/test/python/apache/aurora/client/cli:job Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, job)]) test session starts = platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 61 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py .. src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ..F... == FAILURES == __ TestUpdateCommand.test_update_start_help __ self = test_update.TestUpdateCommand testMethod=test_update_start_help def test_update_start_help(self): start = StartUpdate() assert 'Start a scheduler-driven rolling' in start.help E TypeError: argument of type 'instancemethod' is not iterable src/test/python/apache/aurora/client/cli/test_update.py:307: TypeError
Review Request 26372: Update as property
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/
---
Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer Manji.
Bugs: AURORA-748
https://issues.apache.org/jira/browse/AURORA-748
Repository: aurora
Description
---
Test all the nouns and verbs
Diffs
-
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_help.py
e1602b145a6b100efca8663104a7d44cc119c5a5
Diff: https://reviews.apache.org/r/26372/diff/
Testing
---
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py ..
==
6 passed in 0.71 seconds
==
src.test.python.apache.aurora.client.cli.help
. SUCCESS
And confirmed via:
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
diff --git a/src/main/python/apache/aurora/client/cli/update.py
b/src/main/python/apache/aurora/client/cli/update.py
index 41475a7..142ba5e 100644
--- a/src/main/python/apache/aurora/client/cli/update.py
+++ b/src/main/python/apache/aurora/client/cli/update.py
@@ -42,7 +42,7 @@ class StartUpdate(Verb):
INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
]
- @property
+ #@property
def help(self):
return textwrap.dedent(\
Start a scheduler-driven rolling upgrade on a running job, using the
update
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py F.
==
FAILURES
==
___
TestHelp.test_all_help
___
self = test_help.TestHelp testMethod=test_all_help
def test_all_help(self):
for noun in self.cmd.registered_nouns:
with
patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out',
side_effect=self.mock_print):
self.cmd.execute(['help', noun])
assert 'Usage for noun %s:' % noun in self.transcript
assert self.err_transcript == []
self.transcript = []
for verb in self.cmd.nouns.get(noun).verbs.keys():
self.cmd.execute(['help', noun, verb])
assert 'Usage for verb %s %s:' % (noun, verb) in self.transcript
E AssertionError: assert ('Usage for verb %s %s:' % ('beta-update',
'start')) in []
E+ where [] = test_help.TestHelp
testMethod=test_all_help.transcript
src/test/python/apache/aurora/client/cli/test_help.py:50: AssertionError
Captured stderr call
Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review55520 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 7:57 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/ --- (Updated Oct. 6, 2014, 7:57 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-792 https://issues.apache.org/jira/browse/aurora-792 Repository: aurora Description --- Make the large-update check in the client update command consider instance parameters. Diffs - src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 Diff: https://reviews.apache.org/r/26363/diff/ Testing --- New unit tests added, all test pass. Thanks, Mark Chu-Carroll
Re: Review Request 26372: Update as property
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/#review55521
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 6, 2014, 9:55 a.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/
---
(Updated Oct. 6, 2014, 9:55 a.m.)
Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer
Manji.
Bugs: AURORA-748
https://issues.apache.org/jira/browse/AURORA-748
Repository: aurora
Description
---
Test all the nouns and verbs
Diffs
-
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_help.py
e1602b145a6b100efca8663104a7d44cc119c5a5
Diff: https://reviews.apache.org/r/26372/diff/
Testing
---
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py ..
==
6 passed in 0.71 seconds
==
src.test.python.apache.aurora.client.cli.help
. SUCCESS
And confirmed via:
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
diff --git a/src/main/python/apache/aurora/client/cli/update.py
b/src/main/python/apache/aurora/client/cli/update.py
index 41475a7..142ba5e 100644
--- a/src/main/python/apache/aurora/client/cli/update.py
+++ b/src/main/python/apache/aurora/client/cli/update.py
@@ -42,7 +42,7 @@ class StartUpdate(Verb):
INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
]
- @property
+ #@property
def help(self):
return textwrap.dedent(\
Start a scheduler-driven rolling upgrade on a running job, using the
update
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py F.
==
FAILURES
==
___
TestHelp.test_all_help
___
self = test_help.TestHelp testMethod=test_all_help
def test_all_help(self):
for noun in self.cmd.registered_nouns:
with
patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out',
side_effect=self.mock_print):
self.cmd.execute(['help', noun])
assert 'Usage for noun %s:' % noun in self.transcript
assert self.err_transcript == []
self.transcript = []
for verb in self.cmd.nouns.get(noun).verbs.keys():
self.cmd.execute(['help', noun, verb])
assert 'Usage for verb %s %s:' % (noun, verb) in self.transcript
E
Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/
---
(Updated Oct. 6, 2014, 9:58 a.m.)
Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer Manji.
Changes
---
Fix summary
Summary (updated)
-
Test all the nouns and verbs within the Aurora Command Line for help output
Bugs: AURORA-748
https://issues.apache.org/jira/browse/AURORA-748
Repository: aurora
Description (updated)
---
This steps through each noun within the commandline, and each verb attached to
those nouns to validate help output appears as expected.
Diffs
-
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_help.py
e1602b145a6b100efca8663104a7d44cc119c5a5
Diff: https://reviews.apache.org/r/26372/diff/
Testing
---
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py ..
==
6 passed in 0.71 seconds
==
src.test.python.apache.aurora.client.cli.help
. SUCCESS
And confirmed via:
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
diff --git a/src/main/python/apache/aurora/client/cli/update.py
b/src/main/python/apache/aurora/client/cli/update.py
index 41475a7..142ba5e 100644
--- a/src/main/python/apache/aurora/client/cli/update.py
+++ b/src/main/python/apache/aurora/client/cli/update.py
@@ -42,7 +42,7 @@ class StartUpdate(Verb):
INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
]
- @property
+ #@property
def help(self):
return textwrap.dedent(\
Start a scheduler-driven rolling upgrade on a running job, using the
update
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py F.
==
FAILURES
==
___
TestHelp.test_all_help
___
self = test_help.TestHelp testMethod=test_all_help
def test_all_help(self):
for noun in self.cmd.registered_nouns:
with
patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out',
side_effect=self.mock_print):
self.cmd.execute(['help', noun])
assert 'Usage for noun %s:' % noun in self.transcript
assert self.err_transcript == []
self.transcript = []
for verb in self.cmd.nouns.get(noun).verbs.keys():
self.cmd.execute(['help', noun, verb])
assert 'Usage for verb %s %s:' % (noun, verb) in self.transcript
E AssertionError: assert ('Usage for verb %s %s:' % ('beta-update',
'start')) in []
E+ where [] = test_help.TestHelp
testMethod=test_all_help.transcript
Re: Review Request 26288: Fixing log_response in context.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55522 --- src/main/python/apache/aurora/client/cli/context.py https://reviews.apache.org/r/26288/#comment95901 When I wrote code that did that check, Bill specifically told me to remove it, because anything in the deprecated field would *always* also be in the details list. So unless we're moving backwards, this is the wrong approach. If there's a place where the scheduler is sending things via the deprecated field but not via the details list, then that should be changed. - Mark Chu-Carroll On Oct. 2, 2014, 6:28 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 2, 2014, 6:28 p.m.) Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-786 https://issues.apache.org/jira/browse/AURORA-786 Repository: aurora Description --- Fixing log_response in context.py Diffs - src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION Diff: https://reviews.apache.org/r/26288/diff/ Testing --- ./pants src/tests/python:all Thanks, Maxim Khutornenko
Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/#review55527
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Oct. 6, 2014, 12:58 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/
---
(Updated Oct. 6, 2014, 12:58 p.m.)
Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer
Manji.
Bugs: AURORA-748
https://issues.apache.org/jira/browse/AURORA-748
Repository: aurora
Description
---
This steps through each noun within the commandline, and each verb attached
to those nouns to validate help output appears as expected.
Diffs
-
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_help.py
e1602b145a6b100efca8663104a7d44cc119c5a5
Diff: https://reviews.apache.org/r/26372/diff/
Testing
---
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py ..
==
6 passed in 0.71 seconds
==
src.test.python.apache.aurora.client.cli.help
. SUCCESS
And confirmed via:
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
diff --git a/src/main/python/apache/aurora/client/cli/update.py
b/src/main/python/apache/aurora/client/cli/update.py
index 41475a7..142ba5e 100644
--- a/src/main/python/apache/aurora/client/cli/update.py
+++ b/src/main/python/apache/aurora/client/cli/update.py
@@ -42,7 +42,7 @@ class StartUpdate(Verb):
INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
]
- @property
+ #@property
def help(self):
return textwrap.dedent(\
Start a scheduler-driven rolling upgrade on a running job, using the
update
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py F.
==
FAILURES
==
___
TestHelp.test_all_help
___
self = test_help.TestHelp testMethod=test_all_help
def test_all_help(self):
for noun in self.cmd.registered_nouns:
with
patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out',
side_effect=self.mock_print):
self.cmd.execute(['help', noun])
assert 'Usage for noun %s:' % noun in self.transcript
assert self.err_transcript == []
self.transcript = []
for verb in self.cmd.nouns.get(noun).verbs.keys():
Re: Review Request 26288: Fixing log_response in context.py
On Oct. 6, 2014, 5:12 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/context.py, line 131 https://reviews.apache.org/r/26288/diff/1/?file=712783#file712783line131 When I wrote code that did that check, Bill specifically told me to remove it, because anything in the deprecated field would *always* also be in the details list. So unless we're moving backwards, this is the wrong approach. If there's a place where the scheduler is sending things via the deprecated field but not via the details list, then that should be changed. You are correct about the scheduler duplicating error messages in both fields. That, however, does not cover the updater.py case where the Response object is generated on the client to fit the API return type convention. The alternative would be fixing the updater.py to populate correct fields but I thought this would be the right place to fix in case there are other places on the client where the Response is simulated. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55522 --- On Oct. 2, 2014, 10:28 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 2, 2014, 10:28 p.m.) Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-786 https://issues.apache.org/jira/browse/AURORA-786 Repository: aurora Description --- Fixing log_response in context.py Diffs - src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION Diff: https://reviews.apache.org/r/26288/diff/ Testing --- ./pants src/tests/python:all Thanks, Maxim Khutornenko
Re: Review Request 26288: Fixing log_response in context.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/#review55531 --- src/main/python/apache/aurora/client/cli/context.py https://reviews.apache.org/r/26288/#comment95906 If the client-side API is using a deprecated field of this structure, then that should be fixed. We shouldn't be patching this to prevent the need to remove deprecations from the client-side API. - Mark Chu-Carroll On Oct. 2, 2014, 6:28 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 2, 2014, 6:28 p.m.) Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-786 https://issues.apache.org/jira/browse/AURORA-786 Repository: aurora Description --- Fixing log_response in context.py Diffs - src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION Diff: https://reviews.apache.org/r/26288/diff/ Testing --- ./pants src/tests/python:all Thanks, Maxim Khutornenko
Re: Review Request 25972: Make thermos more cognizant of user deletions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55537 --- thanks, build-support/jenkins/build.sh passed, going to merge to master. - Brian Wickman On Oct. 3, 2014, 10:16 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 10:16 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos. This change allows a process in the Thermos state machine to go directly from WAITING - FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames. Diffs - src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068 src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0 src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512 src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 Diff: https://reviews.apache.org/r/25972/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 26333: Add exit status contract between thermos runner and aurora executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26333/ --- (Updated Oct. 6, 2014, 6:12 p.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 https://issues.apache.org/jira/browse/AURORA-175 Repository: aurora Description --- Adds an exit status contract between the ThermosTaskRunner and the thermos_runner.pex so that we can discriminate between losses / failures. Diffs - src/main/python/apache/aurora/executor/BUILD 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413 src/main/python/apache/aurora/executor/thermos_runner.py 396753e0f95ce1342dba05ea1897a6842e6547df src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083 src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54 src/test/python/apache/aurora/executor/test_thermos_task_runner.py 8e4042b29dce8a815c5995b9e2701c95fe3f034b Diff: https://reviews.apache.org/r/26333/diff/ Testing (updated) --- Added tests. Refers to Process.UnknownUserError which is added in https://reviews.apache.org/r/25972/ but not available here. Update: ran build-support/jenkins/build.sh after the merge of 25972 and it passed. Thanks, Brian Wickman
Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/#review55540
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 6, 2014, 4:58 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/
---
(Updated Oct. 6, 2014, 4:58 p.m.)
Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer
Manji.
Bugs: AURORA-748
https://issues.apache.org/jira/browse/AURORA-748
Repository: aurora
Description
---
This steps through each noun within the commandline, and each verb attached
to those nouns to validate help output appears as expected.
Diffs
-
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_help.py
e1602b145a6b100efca8663104a7d44cc119c5a5
Diff: https://reviews.apache.org/r/26372/diff/
Testing
---
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py ..
==
6 passed in 0.71 seconds
==
src.test.python.apache.aurora.client.cli.help
. SUCCESS
And confirmed via:
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
diff --git a/src/main/python/apache/aurora/client/cli/update.py
b/src/main/python/apache/aurora/client/cli/update.py
index 41475a7..142ba5e 100644
--- a/src/main/python/apache/aurora/client/cli/update.py
+++ b/src/main/python/apache/aurora/client/cli/update.py
@@ -42,7 +42,7 @@ class StartUpdate(Verb):
INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
]
- @property
+ #@property
def help(self):
return textwrap.dedent(\
Start a scheduler-driven rolling upgrade on a running job, using the
update
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py F.
==
FAILURES
==
___
TestHelp.test_all_help
___
self = test_help.TestHelp testMethod=test_all_help
def test_all_help(self):
for noun in self.cmd.registered_nouns:
with
patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out',
side_effect=self.mock_print):
self.cmd.execute(['help', noun])
assert 'Usage for noun %s:' % noun in self.transcript
assert self.err_transcript == []
self.transcript = []
for verb in self.cmd.nouns.get(noun).verbs.keys():
Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/#review55542
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 6, 2014, 4:58 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/
---
(Updated Oct. 6, 2014, 4:58 p.m.)
Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer
Manji.
Bugs: AURORA-748
https://issues.apache.org/jira/browse/AURORA-748
Repository: aurora
Description
---
This steps through each noun within the commandline, and each verb attached
to those nouns to validate help output appears as expected.
Diffs
-
src/main/python/apache/aurora/client/cli/update.py
b4dd792dc12f19424c620f4d91748113e272f0c9
src/test/python/apache/aurora/client/cli/test_help.py
e1602b145a6b100efca8663104a7d44cc119c5a5
Diff: https://reviews.apache.org/r/26372/diff/
Testing
---
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py ..
==
6 passed in 0.71 seconds
==
src.test.python.apache.aurora.client.cli.help
. SUCCESS
And confirmed via:
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
diff --git a/src/main/python/apache/aurora/client/cli/update.py
b/src/main/python/apache/aurora/client/cli/update.py
index 41475a7..142ba5e 100644
--- a/src/main/python/apache/aurora/client/cli/update.py
+++ b/src/main/python/apache/aurora/client/cli/update.py
@@ -42,7 +42,7 @@ class StartUpdate(Verb):
INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
]
- @property
+ #@property
def help(self):
return textwrap.dedent(\
Start a scheduler-driven rolling upgrade on a running job, using the
update
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants
./src/test/python/apache/aurora/client/cli:help
Build operating on top level addresses:
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
help)])
test session starts
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 6 items
src/test/python/apache/aurora/client/cli/test_help.py F.
==
FAILURES
==
___
TestHelp.test_all_help
___
self = test_help.TestHelp testMethod=test_all_help
def test_all_help(self):
for noun in self.cmd.registered_nouns:
with
patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out',
side_effect=self.mock_print):
self.cmd.execute(['help', noun])
assert 'Usage for noun %s:' % noun in self.transcript
assert self.err_transcript == []
self.transcript = []
for verb in self.cmd.nouns.get(noun).verbs.keys():
Re: Review Request 26328: Improve handling of unknown errors in the aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 6, 2014, 2:54 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Changes --- Apologies - I've got 5 different changes open in RB, and I accidentally based this diff against the wrong one. I'll have the correct diff uploaded in a couple of minutes. Summary (updated) - Improve handling of unknown errors in the aurora client. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 26328: Improve handling of unknown errors in the aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 6, 2014, 2:55 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Changes --- Rebase the changes against the correct branch. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs (updated) - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/#review55548 --- Ship it! build-support/jenkins/build.sh https://reviews.apache.org/r/26324/#comment95914 Please include a comment about this non-default setting for posterity. - Bill Farner On Oct. 3, 2014, 6:58 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- (Updated Oct. 3, 2014, 6:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- This patch increases the timeout for PyPI HTTP fetches. This was recomended by John Sirois to reduce the flakeyness of Python tests on Apache Jenkins. Diffs - build-support/jenkins/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26004: Add aurora update list and aurora update status commands.
On Sept. 24, 2014, 6:28 p.m., David McLaughlin wrote: What was the rationale for hiding update IDs from the user and making job key the parameter for update status? It's nice you can quickly see if a job key has an update in progress.. but what happens if you're wanting to see a recent deploy that is already finished or see further back? I think update list should return the update ids and update status should accept an update id. Well maybe not update status.. but update show or something? Something which is consistent with the job verbs would be great. Mark Chu-Carroll wrote: I was following the pattern that I saw in the API implementation. In early iterations, it exposed updated ids; in later ones, the IDs were removed from the user-level API. We don't use those identifiers for pausing or resuming an active update; why would we use them for checking on the status of an update? That would become a very awkward interface for users: start an update? use the jobkey. Pause an update? User the jobkey. Abort an update? Use the jobkey. Check the status of an update? Use some other identifier that you don't know without running another command. I can certainly add the updateID to the list command, and add a command (or alternative parameter) for checking on a job by update-ID, but I don't think that making it the normal parameter to status is a good design for the command-line. Mark Chu-Carroll wrote: ping? David McLaughlin wrote: Can we add updateID to the list command? Then this looks ready to ship. ping? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review54466 --- On Oct. 6, 2014, 9:16 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Oct. 6, 2014, 9:16 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-742 https://issues.apache.org/jira/browse/aurora-742 Repository: aurora Description --- Add support for commands to query and display active updates being managed by the scheduler. Two commands are added: * aurora update list, which shows all active updates that are being processed by the server. * aurora update status, which shows detailed status information about an update in-progress on the server. Diffs - src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- (Updated Oct. 6, 2014, 12:02 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Add a comment Repository: aurora Description --- This patch increases the timeout for PyPI HTTP fetches. This was recomended by John Sirois to reduce the flakeyness of Python tests on Apache Jenkins. Diffs (updated) - build-support/jenkins/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26004: Add aurora update list and aurora update status commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review2 --- src/test/python/apache/aurora/client/cli/test_supdate.py https://reviews.apache.org/r/26004/#comment95916 Can you add the update id to status too? - David McLaughlin On Oct. 6, 2014, 1:16 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Oct. 6, 2014, 1:16 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-742 https://issues.apache.org/jira/browse/aurora-742 Repository: aurora Description --- Add support for commands to query and display active updates being managed by the scheduler. Two commands are added: * aurora update list, which shows all active updates that are being processed by the server. * aurora update status, which shows detailed status information about an update in-progress on the server. Diffs - src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 26375: Disable flaky test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26375/ --- (Updated Oct. 6, 2014, 12:04 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-798 https://issues.apache.org/jira/browse/AURORA-798 Repository: aurora Description --- Disable flaky test Diffs - src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java c9ec8e50486b6d7c84a3d13269dbd8dd55fb862c Diff: https://reviews.apache.org/r/26375/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 26328: Improve handling of unknown errors in the aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review3 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 11:55 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 6, 2014, 11:55 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Review Request 26375: Disable flaky test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26375/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Disable flaky test Diffs - src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java c9ec8e50486b6d7c84a3d13269dbd8dd55fb862c Diff: https://reviews.apache.org/r/26375/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/#review5 --- Ship it! Ship It! - Kevin Sweeney On Oct. 6, 2014, 12:02 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- (Updated Oct. 6, 2014, 12:02 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- This patch increases the timeout for PyPI HTTP fetches. This was recomended by John Sirois to reduce the flakeyness of Python tests on Apache Jenkins. Diffs - build-support/jenkins/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Review Request 26376: Implementing non-prod MTTA/R SLA metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/ --- Review request for Aurora. Bugs: AURORA-774 https://issues.apache.org/jira/browse/AURORA-774 Repository: aurora Description --- Implementing non-prod MTTA/R SLA metrics. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java dca680415426be2bc760875d5774c9e9399ea94b src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 33b6bbe4b39d516595276128bbfa0686d0bb9cbd src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java aeb90bbb822254cbe4691e45092b9581596ad800 src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java 96a04389e6b14c4d1c0bdb4d06abc046e7ea2151 Diff: https://reviews.apache.org/r/26376/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/ --- (Updated Oct. 6, 2014, 7:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-774 https://issues.apache.org/jira/browse/AURORA-774 Repository: aurora Description --- Implementing non-prod MTTA/R SLA metrics. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java dca680415426be2bc760875d5774c9e9399ea94b src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 33b6bbe4b39d516595276128bbfa0686d0bb9cbd src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java aeb90bbb822254cbe4691e45092b9581596ad800 src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java 96a04389e6b14c4d1c0bdb4d06abc046e7ea2151 Diff: https://reviews.apache.org/r/26376/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 26004: Add aurora update list and aurora update status commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Oct. 6, 2014, 3:30 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Changes --- Add ids to the status command. Bugs: aurora-742 https://issues.apache.org/jira/browse/aurora-742 Repository: aurora Description --- Add support for commands to query and display active updates being managed by the scheduler. Two commands are added: * aurora update list, which shows all active updates that are being processed by the server. * aurora update status, which shows detailed status information about an update in-progress on the server. Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 26004: Add aurora update list and aurora update status commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review55564 --- Ship it! Ship It! - David McLaughlin On Oct. 6, 2014, 7:30 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Oct. 6, 2014, 7:30 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-742 https://issues.apache.org/jira/browse/aurora-742 Repository: aurora Description --- Add support for commands to query and display active updates being managed by the scheduler. Two commands are added: * aurora update list, which shows all active updates that are being processed by the server. * aurora update status, which shows detailed status information about an update in-progress on the server. Diffs - src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Review Request 26378: Upgrade to pants 0.0.24
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/ --- Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji. Bugs: AURORA-363 https://issues.apache.org/jira/browse/AURORA-363 Repository: aurora Description --- Upgrade to pants 0.0.24 Diffs - pants 61468a9ea51f3abe7db48f605f8623321005c3a8 pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 Diff: https://reviews.apache.org/r/26378/diff/ Testing --- [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh Thanks, Joe Smith
Re: Review Request 26378: Upgrade to pants 0.0.24
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/#review55566 --- Ship it! The big win we are getting from this is the repo wide interpreter enforcement. - Zameer Manji On Oct. 6, 2014, 12:47 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/ --- (Updated Oct. 6, 2014, 12:47 p.m.) Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji. Bugs: AURORA-363 https://issues.apache.org/jira/browse/AURORA-363 Repository: aurora Description --- Upgrade to pants 0.0.24 Diffs - pants 61468a9ea51f3abe7db48f605f8623321005c3a8 pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 Diff: https://reviews.apache.org/r/26378/diff/ Testing --- [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh Thanks, Joe Smith
Re: Review Request 26378: Upgrade to pants 0.0.24
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/ --- (Updated Oct. 6, 2014, 12:53 p.m.) Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji. Changes --- Added changelog (thanks for the nudge, Zameer!) Bugs: AURORA-363 https://issues.apache.org/jira/browse/AURORA-363 Repository: aurora Description (updated) --- Upgrade to pants 0.0.24 The biggest highlight from the changelog at https://pypi.python.org/pypi/pantsbuild.pants/0.0.24 is this will enforce python2.7 across the repository. Diffs - pants 61468a9ea51f3abe7db48f605f8623321005c3a8 pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 Diff: https://reviews.apache.org/r/26378/diff/ Testing --- [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh Thanks, Joe Smith
Re: Review Request 26375: Disable flaky test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26375/#review55569 --- Ship it! Ship It! - Bill Farner On Oct. 6, 2014, 7:04 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26375/ --- (Updated Oct. 6, 2014, 7:04 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-798 https://issues.apache.org/jira/browse/AURORA-798 Repository: aurora Description --- Disable flaky test Diffs - src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java c9ec8e50486b6d7c84a3d13269dbd8dd55fb862c Diff: https://reviews.apache.org/r/26375/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55570 --- Kevin, Mark - ping? - Bill Farner On Oct. 4, 2014, 5:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/ --- (Updated Oct. 4, 2014, 5:55 p.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Repository: aurora Description --- Fixes two problems: - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. Diffs - src/main/python/apache/aurora/client/api/__init__.py 26300792594e4005dacc139a9f89711b8a66ab61 src/main/python/apache/aurora/client/api/command_runner.py a1fed5fc75dde3a79c840515e6daa4741156ef97 src/main/python/apache/aurora/client/api/job_monitor.py 18d5c0381d43fc7b24bae4b2e5e6fdc774a74b52 src/main/python/apache/aurora/client/api/scheduler_client.py 311c954f1db245b75192d00c6aca0721085fbf32 src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/main/python/apache/aurora/common/aurora_job_key.py a7ca7b6df6b9566b3ce617283ccac948deb2eb83 src/test/python/apache/aurora/client/api/test_job_monitor.py 5b26539f86a0a82f72753a803a769eda77cbc332 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/api/test_updater.py 6905831b23a84320e7f41843efd62b86da366c0b src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_cancel_update.py c15e142930c9474c7873dd931261b6ab4eb5967f src/test/python/apache/aurora/client/cli/test_command_hooks.py 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_diff.py e1a6f764830e06c73d0bc10a3b5da67219da836c src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 src/test/python/apache/aurora/client/cli/test_task_run.py 1ce9a632874e818eee71573cd481842affae3615 src/test/python/apache/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 src/test/python/apache/aurora/client/commands/test_admin.py 1192556c027dc3adf16bb37adeac7798cf9ef93d src/test/python/apache/aurora/client/commands/test_cancel_update.py 5f05ef7c0643d189de3de38c75aae58c2a3814a4 src/test/python/apache/aurora/client/commands/test_create.py 7503345ea1c0f224a894ce02cc2c2d8719574e32 src/test/python/apache/aurora/client/commands/test_diff.py 8f5da7d2bca9b0486b635afe49d3885151624e12 src/test/python/apache/aurora/client/commands/test_hooks.py 0861f13b13a8406950ba953efba0ffae186a8253 src/test/python/apache/aurora/client/commands/test_kill.py c0a6fd44c5691cde50746ffdec325bb11a33469a src/test/python/apache/aurora/client/commands/test_run.py e97b5156609f80a4170028e780bcd891e56983ff src/test/python/apache/aurora/client/commands/test_ssh.py c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 src/test/python/apache/aurora/client/commands/test_status.py bda1f28d544ae48428129f8167d8632ef27f5fba src/test/python/apache/aurora/client/commands/test_update.py af2cbc7f88287201a472ba36902b00d90bc77d3b Diff: https://reviews.apache.org/r/26308/diff/ Testing --- ./pants src/test/python:all -vxs Thanks, Bill Farner
Review Request 26383: Health Check Disabler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Repository: aurora Description --- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The path of the snooze file and the snooze duration can be set in the HealthCheckConfig. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec docs/configuration-tutorial.md 67998e9dab6ac429d96d7c0d2df959336b767f32 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing --- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan
Review Request 26388: Build break fix.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26388/ --- Review request for Aurora. Repository: aurora Description --- The https://reviews.apache.org/r/26004/ broke tests added in https://reviews.apache.org/r/26372. Diffs - src/main/python/apache/aurora/client/cli/update.py 9debc91cd244c015ae2d925829d05d7de67bc3b5 Diff: https://reviews.apache.org/r/26388/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:help Build operating on top level addresses: set([BuildFileAddress(/Users/mkhutornenko/workspace3/aurora/src/test/python/apache/aurora/client/cli/BUILD, help)]) test session starts platform darwin -- Python 2.6.7 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 6 items src/test/python/apache/aurora/client/cli/test_help.py .. = 6 passed in 0.67 seconds == src.test.python.apache.aurora.client.cli.help . SUCCESS Thanks, Maxim Khutornenko
Re: Review Request 26388: Build break fix.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26388/ --- (Updated Oct. 6, 2014, 10:01 p.m.) Review request for Aurora and Mark Chu-Carroll. Repository: aurora Description --- The https://reviews.apache.org/r/26004/ broke tests added in https://reviews.apache.org/r/26372. Diffs - src/main/python/apache/aurora/client/cli/update.py 9debc91cd244c015ae2d925829d05d7de67bc3b5 Diff: https://reviews.apache.org/r/26388/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:help Build operating on top level addresses: set([BuildFileAddress(/Users/mkhutornenko/workspace3/aurora/src/test/python/apache/aurora/client/cli/BUILD, help)]) test session starts platform darwin -- Python 2.6.7 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 6 items src/test/python/apache/aurora/client/cli/test_help.py .. = 6 passed in 0.67 seconds == src.test.python.apache.aurora.client.cli.help . SUCCESS Thanks, Maxim Khutornenko
Re: Review Request 26383: Health Check Disabler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55592 --- docs/configuration-reference.md https://reviews.apache.org/r/26383/#comment95956 Is there any reason this needs to be configurable? Why not just hardcode the filename as '.healthchecksnooze' and then allow the user to specify the snooze at runtime, e.g. echo '600' .healthchecksnooze to sleep for 600 seconds. (And if the value is malformed, just unlink and don't snooze.) - Brian Wickman On Oct. 6, 2014, 9:24 p.m., David Pan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 6, 2014, 9:24 p.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Repository: aurora Description --- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The path of the snooze file and the snooze duration can be set in the HealthCheckConfig. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec docs/configuration-tutorial.md 67998e9dab6ac429d96d7c0d2df959336b767f32 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing --- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan
Re: Review Request 26378: Upgrade to pants 0.0.24
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/#review55595 --- Ship it! Ship It! - Joshua Cohen On Oct. 6, 2014, 7:53 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/ --- (Updated Oct. 6, 2014, 7:53 p.m.) Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji. Bugs: AURORA-363 https://issues.apache.org/jira/browse/AURORA-363 Repository: aurora Description --- Upgrade to pants 0.0.24 The biggest highlight from the changelog at https://pypi.python.org/pypi/pantsbuild.pants/0.0.24 is this will enforce python2.7 across the repository. Diffs - pants 61468a9ea51f3abe7db48f605f8623321005c3a8 pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 Diff: https://reviews.apache.org/r/26378/diff/ Testing --- [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh Thanks, Joe Smith
Re: Review Request 26388: Build break fix.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26388/#review55602 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 6, 2014, 6:01 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26388/ --- (Updated Oct. 6, 2014, 6:01 p.m.) Review request for Aurora and Mark Chu-Carroll. Repository: aurora Description --- The https://reviews.apache.org/r/26004/ broke tests added in https://reviews.apache.org/r/26372. Diffs - src/main/python/apache/aurora/client/cli/update.py 9debc91cd244c015ae2d925829d05d7de67bc3b5 Diff: https://reviews.apache.org/r/26388/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:help Build operating on top level addresses: set([BuildFileAddress(/Users/mkhutornenko/workspace3/aurora/src/test/python/apache/aurora/client/cli/BUILD, help)]) test session starts platform darwin -- Python 2.6.7 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 6 items src/test/python/apache/aurora/client/cli/test_help.py .. = 6 passed in 0.67 seconds == src.test.python.apache.aurora.client.cli.help . SUCCESS Thanks, Maxim Khutornenko
Review Request 26391: Remove special casing of 'rack' attribute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26391/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-662 https://issues.apache.org/jira/browse/AURORA-662 Repository: aurora Description --- This patch removes the auto injection of the 'rack' attribute in the constraint of every job. This will allow for jobs without the 'rack' attribute to be scheduled and allow Aurora to schedule jobs on Mesos slaves that don't have the 'rack' attribute. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 Diff: https://reviews.apache.org/r/26391/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 26391: Remove special casing of 'rack' attribute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26391/#review55606 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 6, 2014, 11:21 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26391/ --- (Updated Oct. 6, 2014, 11:21 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-662 https://issues.apache.org/jira/browse/AURORA-662 Repository: aurora Description --- This patch removes the auto injection of the 'rack' attribute in the constraint of every job. This will allow for jobs without the 'rack' attribute to be scheduled and allow Aurora to schedule jobs on Mesos slaves that don't have the 'rack' attribute. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 Diff: https://reviews.apache.org/r/26391/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 26288: Fixing log_response in context.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26288/ --- (Updated Oct. 6, 2014, 11:40 p.m.) Review request for Aurora and Mark Chu-Carroll. Changes --- Moving the fix into the client updater. Bugs: AURORA-786 https://issues.apache.org/jira/browse/AURORA-786 Repository: aurora Description --- Fixing log_response in context.py Diffs (updated) - src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/test/python/apache/aurora/client/api/test_updater.py 6905831b23a84320e7f41843efd62b86da366c0b Diff: https://reviews.apache.org/r/26288/diff/ Testing --- ./pants src/tests/python:all Thanks, Maxim Khutornenko
Review Request 26394: Deprecating Identity struct (renaming fields).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26394/ --- Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Bill Farner. Bugs: AURORA-84 https://issues.apache.org/jira/browse/AURORA-84 Repository: aurora Description --- Part 1 of Identity struct deprecation: renaming fields. Will require some rebasing when https://reviews.apache.org/r/26308 lands. Diffs - examples/jobs/hello_world.aurora fc7877c3a60e56e301d9ee1fabd73446afca7236 src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 5c75cc8cae53edfa069c85c37ebad34774682081 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java e9f251508257cd7287ff00773e0073a3cd130df8 src/main/java/org/apache/aurora/scheduler/base/JobKeys.java a76c3fac71b35115064fba6644cff0066fd9e630 src/main/java/org/apache/aurora/scheduler/base/Query.java eded7a59eb394748b93d7fbc085a1bdf64b043cc src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/main/java/org/apache/aurora/scheduler/http/Utilization.java a0cb7bf56aeb7edd92b25d8d69a739d87452777a src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 8c20ab6f2bebf1d1c0f91fed3f1e48361cdf45d6 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5dcae4a6132026504cf02093ad4c68ab521e4ab8 src/main/python/apache/aurora/client/api/__init__.py 26300792594e4005dacc139a9f89711b8a66ab61 src/main/python/apache/aurora/client/api/command_runner.py a1fed5fc75dde3a79c840515e6daa4741156ef97 src/main/python/apache/aurora/client/api/instance_watcher.py b390aa8993205f1f6938f8c295e3c16a0bf4df6d src/main/python/apache/aurora/client/api/job_monitor.py 18d5c0381d43fc7b24bae4b2e5e6fdc774a74b52 src/main/python/apache/aurora/client/api/sla.py b9b64680b15f5395ed6aca681b9b1c30ffe2822c src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 src/main/python/apache/aurora/client/cli/task.py c41484bdc27266443bc4e139e1ebb362a59be0f9 src/main/python/apache/aurora/client/commands/admin.py deee0250f3ba9837feeb92acc654f5b3b68b4e0f src/main/python/apache/aurora/client/commands/core.py 58f419e674f1a9a0ae9da6faa2e39c8167bab597 src/main/python/apache/aurora/client/commands/ssh.py 9ee94a0bdfd8bbc030ae978e2ac3fe39571b4ce2 src/main/python/apache/aurora/common/aurora_job_key.py a7ca7b6df6b9566b3ce617283ccac948deb2eb83 src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7b6018814798494acd4687fcd3dce32a9bf63308 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 371ae87f5954fa5f092db1f6d21e2291d7576173 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 606c4434b7158220ccf1403b6deac939021fee31 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java 131bd826dfe47f40f3c27f29c095ed42953e316c src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java efdde15939b2a851e38be53cceab395cc2cd82a1 src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 53d2c6bb78ad08a84639c1ecd48ba64d17c3f9fc src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 6534329a92bf005223fa8907cbe4a8a3a511e142 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9970948bace4c0ecbc51d6fc79270d77fb17bf87 src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java b8b9c1b8cdf7b641976c583a71fdd9b0c14e6e5f src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
Re: Review Request 26378: Upgrade to pants 0.0.24
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/#review55613 --- Ship it! Ship It! - Brian Wickman On Oct. 6, 2014, 7:53 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/ --- (Updated Oct. 6, 2014, 7:53 p.m.) Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji. Bugs: AURORA-363 https://issues.apache.org/jira/browse/AURORA-363 Repository: aurora Description --- Upgrade to pants 0.0.24 The biggest highlight from the changelog at https://pypi.python.org/pypi/pantsbuild.pants/0.0.24 is this will enforce python2.7 across the repository. Diffs - pants 61468a9ea51f3abe7db48f605f8623321005c3a8 pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 Diff: https://reviews.apache.org/r/26378/diff/ Testing --- [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh Thanks, Joe Smith
