Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69420 --- Master (3fa004b) is red with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69404 --- Master (3fa004b) is red with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69439 --- @ReviewBot retry - Steve Niemitz On Jan. 23, 2015, 5:23 p.m.,

Re: Review Request 30224: Stream backups directly to file.

2015-01-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30224/#review69443 --- Ship it! - Bill Farner On Jan. 23, 2015, 7:19 p.m., Kevin

Re: Review Request 30224: Stream backups directly to file.

2015-01-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30224/#review69444 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2015, 11:19 a.m.,

Re: Review Request 30224: Stream backups directly to file.

2015-01-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30224/#review69445 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2015, 11:25 a.m.,

Review Request 30224: Stream backups directly to file.

2015-01-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30224/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1053

Review Request 30225: Modifying update controller to support heartbeats.

2015-01-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.

Re: Review Request 30224: Stream backups directly to file.

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30224/#review69452 --- Master (3fa004b) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69447 --- Ship it! Master (3fa004b) is green with this patch.

Re: Review Request 30207: Simplify AuroraCommandContext

2015-01-23 Thread Zameer Manji
On Jan. 23, 2015, 12:47 p.m., Maxim Khutornenko wrote: I am not convinced there is enough value in this diff to risk possible regression. Besides, the majority of what this diff touches will die out along with the client updater. Zameer Manji wrote: Is there an ETA for the

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review69469 --- @ReviewBot retry - Bill Farner On Jan. 22, 2015, 9:09 p.m., Bill

Re: Review Request 30204: Upgrade to rbt=0.7.0.

2015-01-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30204/#review69473 --- Ship it! Ship It! - Zameer Manji On Jan. 22, 2015, 6:11 p.m.,

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review69478 --- Master (e3b8905) is red with this patch.

Re: Review Request 30207: Simplify AuroraCommandContext

2015-01-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30207/#review69458 --- I am not convinced there is enough value in this diff to risk

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review69460 --- Master (3fa004b) is red with this patch.

Re: Review Request 30207: Simplify AuroraCommandContext

2015-01-23 Thread Maxim Khutornenko
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote: I am not convinced there is enough value in this diff to risk possible regression. Besides, the majority of what this diff touches will die out along with the client updater. Zameer Manji wrote: Is there an ETA for the

Re: Review Request 30207: Simplify AuroraCommandContext

2015-01-23 Thread Zameer Manji
On Jan. 23, 2015, 12:47 p.m., Maxim Khutornenko wrote: I am not convinced there is enough value in this diff to risk possible regression. Besides, the majority of what this diff touches will die out along with the client updater. Is there an ETA for the destruction of the client

Re: Review Request 30207: Simplify AuroraCommandContext

2015-01-23 Thread Maxim Khutornenko
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote: I am not convinced there is enough value in this diff to risk possible regression. Besides, the majority of what this diff touches will die out along with the client updater. Zameer Manji wrote: Is there an ETA for the

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69480 --- this is looking great. just a few small nits and one higher level

Re: Review Request 30207: Simplify AuroraCommandContext

2015-01-23 Thread Maxim Khutornenko
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote: I am not convinced there is enough value in this diff to risk possible regression. Besides, the majority of what this diff touches will die out along with the client updater. Zameer Manji wrote: Is there an ETA for the

Re: Review Request 30207: Simplify AuroraCommandContext

2015-01-23 Thread Bill Farner
On Jan. 23, 2015, 8:47 p.m., Maxim Khutornenko wrote: I am not convinced there is enough value in this diff to risk possible regression. Besides, the majority of what this diff touches will die out along with the client updater. Zameer Manji wrote: Is there an ETA for the

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

2015-01-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30203/#review69487 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2015, 1:48 p.m.,

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

2015-01-23 Thread Bill Farner
On Jan. 23, 2015, 9:44 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 47 https://reviews.apache.org/r/30203/diff/1/?file=831389#file831389line47 Given peak 170MB, rounding to 256 feels too wasteful. This change predates the bug

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

2015-01-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30203/ --- (Updated Jan. 23, 2015, 9:48 p.m.) Review request for Aurora, Maxim

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

2015-01-23 Thread Bill Farner
On Jan. 23, 2015, 10:14 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java, line 36 https://reviews.apache.org/r/30203/diff/2/?file=832278#file832278line36 Can you add a ticket to track this TODO?

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

2015-01-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30203/ --- (Updated Jan. 24, 2015, 12:33 a.m.) Review request for Aurora, Maxim

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69508 ---

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30203/#review69522 --- This patch does not apply cleanly on master (7ba6226), do you need

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69505 --- Ship it! sweet! ship it modulo minor nit below

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69512 --- Ship it! Ship It! - Kevin Sweeney On Jan. 23, 2015, 4 p.m.,

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-23 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 23, 2015, 9:20 vorm.) Review request for Aurora, Bill Farner and

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review69375 --- Ship it! Master (3fa004b) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Steve Niemitz
On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote: docs/deploying-aurora-scheduler.md, line 163 https://reviews.apache.org/r/28920/diff/18/?file=823201#file823201line163 Philosophical question: if there's already a hard requirement that the container have Python 2.7 why not

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 23, 2015, 4:25 p.m.) Review request for Aurora, Jay Buffington,

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Steve Niemitz
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, lines 153-158 https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153 can't the stuff in DOCKER_COMMAND_PREFIX be accomplished with a