Review Request 30467: Update mesos lib to 0.21.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1028 https://issues.apache.org/jira/browse/AURORA-1028 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs - build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 Diff: https://reviews.apache.org/r/30467/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30446: Fix compile errors under Java 8.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70403 --- Ship it! Ship It! - Kevin Sweeney On Jan. 30, 2015, 10:53 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 10:53 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Fix compile errors under Java 8. I think this is just caused by the Java 8 compiler having better type inference than Java 7? Diffs - src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 30467: Update mesos lib to 0.21.1
On Jan. 30, 2015, 10:55 p.m., Stephan Erb wrote: What about the other references to 0.20.1? (e.g., 3rdparty/python/requirements.txt). Is it safe to update just one of them? Kevin Sweeney wrote: +1, please refer to previous mesos upgrade patches you'll also want to build new eggs and upload them to svn.apache.org so the vagrant image will continue to work Yeah, sorry - this was hasty. Wow, i didn't know i needed to build artifacts as well. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70432 --- On Jan. 30, 2015, 10:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 30, 2015, 10:07 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1028 https://issues.apache.org/jira/browse/AURORA-1028 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs - build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 Diff: https://reviews.apache.org/r/30467/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30467: Update mesos lib to 0.21.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70438 --- Ship it! Master (c739122) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 30, 2015, 10:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 30, 2015, 10:07 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1028 https://issues.apache.org/jira/browse/AURORA-1028 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs - build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 Diff: https://reviews.apache.org/r/30467/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30433: Prevent multiple active job updates from being inserted into storage.
On Jan. 30, 2015, 5:44 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 152 https://reviews.apache.org/r/30433/diff/1/?file=841071#file841071line152 Suggest adding an explanation of what active update means, e.g.: An update in one of the following states is considered active + ACTIVE_JOB_UPDATE_STATES. Otherwise, it can be unclear why PAUSED update prevents from creating a new one. Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/#review70316 --- On Jan. 30, 2015, 12:21 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/ --- (Updated Jan. 30, 2015, 12:21 a.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1023 https://issues.apache.org/jira/browse/AURORA-1023 Repository: aurora Description --- This adds a guard before an update is saved to make sure we don't already have an active update for the given job. This was an implied invariant due to the relationship between the locks table and job updates table, but that relationship can be compromised by outside user action. Diffs - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java a992938d4e12b20f81608be6bbdc24c0a211c3fd src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4c827b183a87b4d97774edbfaa960bd1c3de72a5 Diff: https://reviews.apache.org/r/30433/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30325: Implementing pulseJobUpdate RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70379 --- Ship it! Master (4f04a34) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:23 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1009 https://issues.apache.org/jira/browse/AURORA-1009 Repository: aurora Description --- Implemented the `pulseJobUpdate` RPC. Also, moved it into AuroraAdmin interface to support AOP capability validation. The RB is diffed against https://reviews.apache.org/r/30225/ Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/auth/CapabilityValidator.java 45ef643ebe57c1517cdae373574331ea302a8b74 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8c19f3b08135eb5f3098591ebf9931b42a086318 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 Diff: https://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 30, 2015, 7:18 nachm.) Review request for Aurora, Bill Farner and Zameer Manji. Changes --- removed the mentioned(and some more) newlines Bugs: AURORA-184 https://issues.apache.org/jira/browse/AURORA-184 Repository: aurora Description --- [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints This is the first step for AURORA-184, that removes the default hostrack limit constraints. The second step that's still missing would be to add s.th. like --default-constraints as start parameter to the scheduler. AURORA-174 could probably be closed with this?(since the rack limit constraint can be configured in the .aurora file) I can't really estimate the effect of my changes in StorageBackfillTestSchedulerThriftInterfaceTest, please have a closer look at the changes I did there. Since this is also my first code submit, comments about codestyleother bad habbits are very appreciated. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 5dfbcf1f6de716502a28f7da33a095968eb8420e src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 92ba45033ada8114349c435316c9681395aea706 Diff: https://reviews.apache.org/r/30010/diff/ Testing --- Added test for ConfigurationManager.hasName Added test testNoHostAndRackConstraintsAdded, that checks if the constraints are present Tested on vagrant devcluster to see if constraints are also gone in real life Thanks, Florian Pfeiffer
Re: Review Request 30325: Implementing pulseJobUpdate RPC.
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126 https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126 Have we considered adding a batch interface, to avoid having to make multiple RPCs for a collection of updates? Not sure how that will work on the caller side given different schedules updates may operate on. Adding a batch API will be quite easy given the need. I don't think it's justified yet. On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1388 https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1388 This is consistent with the message above, but we should just say 'a positive integer' here. Zero is the default accepted value. By stating non-negative in the error message we identify the acceptable range as zero or a positive integer. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70377 --- On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:23 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1009 https://issues.apache.org/jira/browse/AURORA-1009 Repository: aurora Description --- Implemented the `pulseJobUpdate` RPC. Also, moved it into AuroraAdmin interface to support AOP capability validation. The RB is diffed against https://reviews.apache.org/r/30225/ Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/auth/CapabilityValidator.java 45ef643ebe57c1517cdae373574331ea302a8b74 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8c19f3b08135eb5f3098591ebf9931b42a086318 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 Diff: https://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review70434 --- Ship it! Master (c739122) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 30, 2015, 10:31 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- (Updated Jan. 30, 2015, 10:31 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1071 https://issues.apache.org/jira/browse/AURORA-1071 Repository: aurora Description --- - Adding pulse_interval_secs into client UpdateConfig and validating its range - Raising an error in client updater for pulse_interval_secs Diffs - src/main/python/apache/aurora/client/api/updater.py 9f91de625f55514530a4f948d7ecdf7b5614b594 src/main/python/apache/aurora/client/api/updater_util.py 9d2e893a6ecff0fc48c7944575578443d41ced78 src/main/python/apache/aurora/config/schema/base.py e4433d2d47668f59bce169359131284d361bad09 src/test/python/apache/aurora/client/api/test_api.py ff1aff2eac391f219bc7c2483a16e35f916a224c src/test/python/apache/aurora/client/api/test_updater.py dd3f228c5062d388b4393aa4fd5b60a685bdb3a6 src/test/python/apache/aurora/client/api/test_updater_util.py fe3ac49491ca710761632405ac09de0cc0d038a5 Diff: https://reviews.apache.org/r/30461/diff/ Testing --- ./pants test.pytest src/test/python/apache/aurora/client:: Thanks, Maxim Khutornenko
Re: Review Request 30467: Update mesos lib to 0.21.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70432 --- What about the other references to 0.20.1? (e.g., 3rdparty/python/requirements.txt). Is it safe to update just one of them? - Stephan Erb On Jan. 30, 2015, 10:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 30, 2015, 10:07 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1028 https://issues.apache.org/jira/browse/AURORA-1028 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs - build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 Diff: https://reviews.apache.org/r/30467/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- (Updated Jan. 30, 2015, 10:31 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Changes --- Fixing broken test. Bugs: AURORA-1071 https://issues.apache.org/jira/browse/AURORA-1071 Repository: aurora Description --- - Adding pulse_interval_secs into client UpdateConfig and validating its range - Raising an error in client updater for pulse_interval_secs Diffs (updated) - src/main/python/apache/aurora/client/api/updater.py 9f91de625f55514530a4f948d7ecdf7b5614b594 src/main/python/apache/aurora/client/api/updater_util.py 9d2e893a6ecff0fc48c7944575578443d41ced78 src/main/python/apache/aurora/config/schema/base.py e4433d2d47668f59bce169359131284d361bad09 src/test/python/apache/aurora/client/api/test_api.py ff1aff2eac391f219bc7c2483a16e35f916a224c src/test/python/apache/aurora/client/api/test_updater.py dd3f228c5062d388b4393aa4fd5b60a685bdb3a6 src/test/python/apache/aurora/client/api/test_updater_util.py fe3ac49491ca710761632405ac09de0cc0d038a5 Diff: https://reviews.apache.org/r/30461/diff/ Testing (updated) --- ./pants test.pytest src/test/python/apache/aurora/client:: Thanks, Maxim Khutornenko
Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review70427
---
Master (c739122) is red with this patch.
./build-support/jenkins/build.sh
[1mraise AssertionError('Expected call:
%s\nNot called' % (expected,))[0m
[1m[0m
[1mif self.call_args != (args, kwargs):[0m
[1mmsg =
self._format_mock_failure_message(args, kwargs)[0m
[1m raise AssertionError(msg)[0m
[1m[31mE AssertionError: Expected call:
startJobUpdate(JobUpdateRequest(instanceCount=5,
settings=JobUpdateSettings(blockIfNoPulsesAfterMs=None,
updateOnlyTheseInstances=None, maxPerInstanceFailures=2,
maxWaitToInstanceRunningMs=5, waitForBatchCompletion=False,
rollbackOnFailure=True, minWaitInInstanceRunningMs=5, updateGroupSize=1,
maxFailedInstances=1), taskConfig=TaskConfig(isService=None, priority=None,
taskLinks=None, container=Container(docker=None, mesos=MesosContainer()),
executorConfig=None, metadata=None, requestedPorts=None, jobName=None,
environment=None, ramMb=None, job=None, production=None, diskMb=None,
owner=None, maxTaskFailures=None, contactEmail=None, numCpus=None,
constraints=None)))[0m
[1m[31mE Actual call:
startJobUpdate(JobUpdateRequest(instanceCount=5,
settings=JobUpdateSettings(blockIfNoPulsesAfterMs=0,
updateOnlyTheseInstances=None, maxPerInstanceFailures=2,
maxWaitToInstanceRunningMs=5, waitForBatchCompletion=False,
rollbackOnFailure=True, minWaitInInstanceRunningMs=5, updateGroupSize=1,
maxFailedInstances=1), taskConfig=TaskConfig(isService=None, priority=None,
taskLinks=None, container=Container(docker=None, mesos=MesosContainer()),
executorConfig=None, metadata=None, requestedPorts=None, jobName=None,
environment=None, ramMb=None, job=None, production=None, diskMb=None,
owner=None, maxTaskFailures=None, contactEmail=None, numCpus=None,
constraints=None)))[0m
/tmp/user/2395/tmph5gM1a/.deps/mock-1.0.1-py2-none-any.whl/mock.py:835:
AssertionError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.api.api.xml
[1m[31m== 1 failed, 10 passed in 0.74 seconds
===[0m
src.test.python.apache.aurora.admin.admin
. SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
. SUCCESS
src.test.python.apache.aurora.admin.maintenance
. SUCCESS
src.test.python.apache.aurora.client.api.api
. FAILURE
src.test.python.apache.aurora.client.api.updater
. SUCCESS
src.test.python.apache.aurora.client.base
. SUCCESS
src.test.python.apache.aurora.client.binding_helper
. SUCCESS
src.test.python.apache.aurora.client.cli.config
. SUCCESS
src.test.python.apache.aurora.client.cli.cron
. SUCCESS
src.test.python.apache.aurora.client.cli.sla
. SUCCESS
src.test.python.apache.aurora.client.config
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
. SUCCESS
src.test.python.apache.aurora.common.test_cluster
. SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
. SUCCESS
src.test.python.apache.aurora.common.test_clusters
. SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
. SUCCESS
src.test.python.apache.aurora.common.test_pex_version
. SUCCESS
src.test.python.apache.aurora.common.test_shellify
. SUCCESS
src.test.python.apache.aurora.common.test_transport
. SUCCESS
Re: Review Request 30467: Update mesos lib to 0.21.1
On Jan. 30, 2015, 2:55 p.m., Stephan Erb wrote: What about the other references to 0.20.1? (e.g., 3rdparty/python/requirements.txt). Is it safe to update just one of them? +1, please refer to previous mesos upgrade patches you'll also want to build new eggs and upload them to svn.apache.org so the vagrant image will continue to work - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70432 --- On Jan. 30, 2015, 2:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 30, 2015, 2:07 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1028 https://issues.apache.org/jira/browse/AURORA-1028 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs - build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 Diff: https://reviews.apache.org/r/30467/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70422 --- Ship it! Master (4f04a34) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 30, 2015, 7:18 p.m., Florian Pfeiffer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 30, 2015, 7:18 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-184 https://issues.apache.org/jira/browse/AURORA-184 Repository: aurora Description --- [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints This is the first step for AURORA-184, that removes the default hostrack limit constraints. The second step that's still missing would be to add s.th. like --default-constraints as start parameter to the scheduler. AURORA-174 could probably be closed with this?(since the rack limit constraint can be configured in the .aurora file) I can't really estimate the effect of my changes in StorageBackfillTestSchedulerThriftInterfaceTest, please have a closer look at the changes I did there. Since this is also my first code submit, comments about codestyleother bad habbits are very appreciated. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 5dfbcf1f6de716502a28f7da33a095968eb8420e src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 92ba45033ada8114349c435316c9681395aea706 Diff: https://reviews.apache.org/r/30010/diff/ Testing --- Added test for ConfigurationManager.hasName Added test testNoHostAndRackConstraintsAdded, that checks if the constraints are present Tested on vagrant devcluster to see if constraints are also gone in real life Thanks, Florian Pfeiffer
Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70407 --- Ship it! Ship It! - Zameer Manji On Jan. 30, 2015, 11:18 a.m., Florian Pfeiffer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 30, 2015, 11:18 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-184 https://issues.apache.org/jira/browse/AURORA-184 Repository: aurora Description --- [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints This is the first step for AURORA-184, that removes the default hostrack limit constraints. The second step that's still missing would be to add s.th. like --default-constraints as start parameter to the scheduler. AURORA-174 could probably be closed with this?(since the rack limit constraint can be configured in the .aurora file) I can't really estimate the effect of my changes in StorageBackfillTestSchedulerThriftInterfaceTest, please have a closer look at the changes I did there. Since this is also my first code submit, comments about codestyleother bad habbits are very appreciated. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 5dfbcf1f6de716502a28f7da33a095968eb8420e src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 92ba45033ada8114349c435316c9681395aea706 Diff: https://reviews.apache.org/r/30010/diff/ Testing --- Added test for ConfigurationManager.hasName Added test testNoHostAndRackConstraintsAdded, that checks if the constraints are present Tested on vagrant devcluster to see if constraints are also gone in real life Thanks, Florian Pfeiffer
Re: Review Request 30433: Prevent multiple active job updates from being inserted into storage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/ --- (Updated Jan. 30, 2015, 6:34 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1023 https://issues.apache.org/jira/browse/AURORA-1023 Repository: aurora Description --- This adds a guard before an update is saved to make sure we don't already have an active update for the given job. This was an implied invariant due to the relationship between the locks table and job updates table, but that relationship can be compromised by outside user action. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java a992938d4e12b20f81608be6bbdc24c0a211c3fd src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4c827b183a87b4d97774edbfaa960bd1c3de72a5 Diff: https://reviews.apache.org/r/30433/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 3:24 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description (updated) --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30325: Implementing pulseJobUpdate RPC.
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126 https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126 Have we considered adding a batch interface, to avoid having to make multiple RPCs for a collection of updates? Maxim Khutornenko wrote: Not sure how that will work on the caller side given different schedules updates may operate on. Adding a batch API will be quite easy given the need. I don't think it's justified yet. Sounds good. On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1388 https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1388 This is consistent with the message above, but we should just say 'a positive integer' here. Maxim Khutornenko wrote: Zero is the default accepted value. By stating non-negative in the error message we identify the acceptable range as zero or a positive integer. This field should probably have been an optional. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70377 --- On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:23 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1009 https://issues.apache.org/jira/browse/AURORA-1009 Repository: aurora Description --- Implemented the `pulseJobUpdate` RPC. Also, moved it into AuroraAdmin interface to support AOP capability validation. The RB is diffed against https://reviews.apache.org/r/30225/ Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/auth/CapabilityValidator.java 45ef643ebe57c1517cdae373574331ea302a8b74 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8c19f3b08135eb5f3098591ebf9931b42a086318 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 Diff: https://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70449 --- Ship it! Master (c739122) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 30, 2015, 11:24 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 11:24 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30446: Fix compile errors under Java 8.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:18 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description (updated) --- Fix compile errors under Java 8. I think this is just caused by the Java 8 compiler having better type inference than Java 7? Diffs - src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 97ecb742d6e0418890f875394ded8d9fdae2b1c2 src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 4e7efb3c1214c3d193afd61f162713490eb8effb src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java f96110c55011699768f17cc2d4afdc8bf7daa16c src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 4ed6b159afda3f118e8ae28d03fdf796cbd98149 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 422d5a9a42310979752eb7282658316c2b772419 src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java 131bd826dfe47f40f3c27f29c095ed42953e316c src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 6eaf3ce765c8e50b6724e40848ceb9105e1ab529 src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 88fc172be6c24fefb6f708ce757487082542 src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java 763f8b5f31349f291c0ede7b5d3292f6ca5b src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java 020b67187a18bba64d9b562c3a6c0969fc85d469 src/test/java/org/apache/aurora/scheduler/http/MnameTest.java afa83f2c6f8b03fbd869c8e5c4d81b27a0cc5be5 src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 09593b15c9bd711530ddcb5508ed85b58a2ebe02 src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0a5cc51967f756411ca1489d81872f863c045b6b src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 8fc3cb865fbcd467db91f4cb828d381a02ba7595 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 30467: Update mesos lib to 0.21.1
On Jan. 30, 2015, 10:55 p.m., Stephan Erb wrote: What about the other references to 0.20.1? (e.g., 3rdparty/python/requirements.txt). Is it safe to update just one of them? Kevin Sweeney wrote: +1, please refer to previous mesos upgrade patches you'll also want to build new eggs and upload them to svn.apache.org so the vagrant image will continue to work Bill Farner wrote: Yeah, sorry - this was hasty. Wow, i didn't know i needed to build artifacts as well. https://mesosphere.com/downloads/details/index.html#apache-mesos I guess you could also just download them from mesosphere. - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70432 --- On Jan. 30, 2015, 10:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 30, 2015, 10:07 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1028 https://issues.apache.org/jira/browse/AURORA-1028 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs - build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 Diff: https://reviews.apache.org/r/30467/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70456 --- src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java https://reviews.apache.org/r/30471/#comment115649 Consider [TextFormat.shortDebugString](https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/TextFormat.html#shortDebugString(com.google.protobuf.MessageOrBuilder)) here instead. - Kevin Sweeney On Jan. 30, 2015, 3:54 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 3:54 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30325: Implementing pulseJobUpdate RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70383 --- Ship it! Ship It! - David McLaughlin On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:23 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1009 https://issues.apache.org/jira/browse/AURORA-1009 Repository: aurora Description --- Implemented the `pulseJobUpdate` RPC. Also, moved it into AuroraAdmin interface to support AOP capability validation. The RB is diffed against https://reviews.apache.org/r/30225/ Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/auth/CapabilityValidator.java 45ef643ebe57c1517cdae373574331ea302a8b74 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8c19f3b08135eb5f3098591ebf9931b42a086318 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 Diff: https://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 3:48 p.m.) Review request for Aurora and Bill Farner. Changes --- Review feedback. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70461 --- Ship it! Master (c739122) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 31, 2015, 12:09 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 31, 2015, 12:09 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30467: Update mesos lib to 0.21.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 31, 2015, 1:45 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1080 https://issues.apache.org/jira/browse/AURORA-1080 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs - 3rdparty/python/requirements.txt 0c88e4c299ffe5886bb3ab7d83b0187cb4b7888a build-support/python/make-mesos-native-egg 2cba8ede04e22aee1e6ec5c979161904a6f8fddb build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 docs/deploying-aurora-scheduler.md 9bf5b5a92bf65b31b2f8fda102003b113f61186a examples/vagrant/provision-dev-cluster.sh fa0de88314169bc9fe31aaf41126cedd0865ed5a Diff: https://reviews.apache.org/r/30467/diff/ Testing (updated) --- This is blocked by https://issues.apache.org/jira/browse/MESOS-2310 Thanks, Bill Farner
Re: Review Request 30467: Update mesos lib to 0.21.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70481 --- Master (7fbe5bb) is red with this patch. ./build-support/jenkins/build.sh :buildSrc:compileJava UP-TO-DATE :buildSrc:processResources UP-TO-DATE :buildSrc:classes UP-TO-DATE :buildSrc:jar :buildSrc:assemble :buildSrc:compileTestJava UP-TO-DATE :buildSrc:processTestResources UP-TO-DATE :buildSrc:testClasses UP-TO-DATE :buildSrc:test UP-TO-DATE :buildSrc:check UP-TO-DATE :buildSrc:build BUILD SUCCESSFUL Total time: 4 mins 26.374 secs + export PIP_DEFAULT_TIMEOUT=60 + PIP_DEFAULT_TIMEOUT=60 + mkdir -p third_party + pip install -d third_party -r /dev/fd/63 ++ grep -v mesos.native 3rdparty/python/requirements.txt Downloading/unpacking bottle==0.11.6 (from -r /dev/fd/63 (line 1)) Saved ./third_party/bottle-0.11.6-py2.py3-none-any.whl Downloading/unpacking CherryPy==3.6.0 (from -r /dev/fd/63 (line 2)) Saved ./third_party/CherryPy-3.6.0.tar.gz Running setup.py (path:/tmp/user/2395/pip_build_jenkins/CherryPy/setup.py) egg_info for package CherryPy Downloading/unpacking mako==0.4.0 (from -r /dev/fd/63 (line 3)) Saved ./third_party/Mako-0.4.0.tar.gz Running setup.py (path:/tmp/user/2395/pip_build_jenkins/mako/setup.py) egg_info for package mako warning: no files found matching '*.xml' under directory 'examples' warning: no files found matching '*.mako' under directory 'examples' warning: no files found matching 'ez_setup.py' no previously-included directories found matching 'doc/build/output' Downloading/unpacking mesos.interface==0.21.1 (from -r /dev/fd/63 (line 4)) Could not find a version that satisfies the requirement mesos.interface==0.21.1 (from -r /dev/fd/63 (line 4)) (from versions: 0.20.0, 0.20.1, 0.21.0) Some externally hosted files were ignored (use --allow-external to allow). Cleaning up... No distributions matching the version for mesos.interface==0.21.1 (from -r /dev/fd/63 (line 4)) Storing debug log for failure in /home/jenkins/.pip/pip.log I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 31, 2015, 1:45 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 31, 2015, 1:45 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1080 https://issues.apache.org/jira/browse/AURORA-1080 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs - 3rdparty/python/requirements.txt 0c88e4c299ffe5886bb3ab7d83b0187cb4b7888a build-support/python/make-mesos-native-egg 2cba8ede04e22aee1e6ec5c979161904a6f8fddb build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 docs/deploying-aurora-scheduler.md 9bf5b5a92bf65b31b2f8fda102003b113f61186a examples/vagrant/provision-dev-cluster.sh fa0de88314169bc9fe31aaf41126cedd0865ed5a Diff: https://reviews.apache.org/r/30467/diff/ Testing --- This is blocked by https://issues.apache.org/jira/browse/MESOS-2310 Thanks, Bill Farner
Re: Review Request 30446: Fix compile errors under Java 8.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/#review70393
---
I was able to address these compiler errors with a more targeted change, adding
a type witness:
```
$ git diff
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
diff --git
a/src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
b/src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
index d492e17..6feddc3 100644
---
a/src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
+++
b/src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
@@ -75,7 +75,7 @@ public class StorageTestUtil {
public T IExpectationSettersT expectRead() {
final CaptureWorkT, RuntimeException work =
EasyMockTest.createCapture();
-return expect(storage.read(capture(work)))
+return expect(storage.T, RuntimeExceptionread(capture(work)))
.andAnswer(new IAnswerT() {
@Override
public T answer() {
@@ -86,7 +86,7 @@ public class StorageTestUtil {
public T IExpectationSettersT expectWrite() {
final CaptureMutateWorkT, RuntimeException work =
EasyMockTest.createCapture();
-return expect(storage.write(capture(work))).andAnswer(new IAnswerT() {
+return expect(storage.T,
RuntimeExceptionwrite(capture(work))).andAnswer(new IAnswerT() {
@Override
public T answer() {
return work.getValue().apply(mutableStoreProvider);
```
- Bill Farner
On Jan. 30, 2015, 6:18 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/
---
(Updated Jan. 30, 2015, 6:18 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
---
Fix compile errors under Java 8.
I think this is just caused by the Java 8 compiler having better type
inference than Java 7?
Diffs
-
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java
97ecb742d6e0418890f875394ded8d9fdae2b1c2
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java
4e7efb3c1214c3d193afd61f162713490eb8effb
src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java
f96110c55011699768f17cc2d4afdc8bf7daa16c
src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java
4ed6b159afda3f118e8ae28d03fdf796cbd98149
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java
422d5a9a42310979752eb7282658316c2b772419
src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java
131bd826dfe47f40f3c27f29c095ed42953e316c
src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java
6eaf3ce765c8e50b6724e40848ceb9105e1ab529
src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java
88fc172be6c24fefb6f708ce757487082542
src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java
763f8b5f31349f291c0ede7b5d3292f6ca5b
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java
020b67187a18bba64d9b562c3a6c0969fc85d469
src/test/java/org/apache/aurora/scheduler/http/MnameTest.java
afa83f2c6f8b03fbd869c8e5c4d81b27a0cc5be5
src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java
09593b15c9bd711530ddcb5508ed85b58a2ebe02
src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java
cb98834e925793fc116814371548a30470830164
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java
0a5cc51967f756411ca1489d81872f863c045b6b
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
8fc3cb865fbcd467db91f4cb828d381a02ba7595
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
d492e176e73cbd2b3c696fc488010db16106b36a
Diff: https://reviews.apache.org/r/30446/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
Re: Review Request 30433: Prevent multiple active job updates from being inserted into storage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/#review70418 --- Ship it! Master (4f04a34) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 30, 2015, 6:34 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/ --- (Updated Jan. 30, 2015, 6:34 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1023 https://issues.apache.org/jira/browse/AURORA-1023 Repository: aurora Description --- This adds a guard before an update is saved to make sure we don't already have an active update for the given job. This was an implied invariant due to the relationship between the locks table and job updates table, but that relationship can be compromised by outside user action. Diffs - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java a992938d4e12b20f81608be6bbdc24c0a211c3fd src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4c827b183a87b4d97774edbfaa960bd1c3de72a5 Diff: https://reviews.apache.org/r/30433/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70443 --- src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java https://reviews.apache.org/r/30471/#comment115628 If we're going to maintain this test there should be a reference to an upstream issue. Theoretically the semantics of an unset optional field with a default and a set field should be the same. - Kevin Sweeney On Jan. 30, 2015, 3:24 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 3:24 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30325: Implementing pulseJobUpdate RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:23 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Changes --- Re-parenting against the right branch. Bugs: AURORA-1009 https://issues.apache.org/jira/browse/AURORA-1009 Repository: aurora Description --- Implemented the `pulseJobUpdate` RPC. Also, moved it into AuroraAdmin interface to support AOP capability validation. The RB is diffed against https://reviews.apache.org/r/30225/ Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/auth/CapabilityValidator.java 45ef643ebe57c1517cdae373574331ea302a8b74 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8c19f3b08135eb5f3098591ebf9931b42a086318 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 Diff: https://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 30446: Fix compile errors under Java 8.
On Jan. 30, 2015, 4:56 p.m., Maxim Khutornenko wrote: I'm not in love with this fix, but the alternative is to declare these methods as throwing Exception which propagates out pretty widely. - that happens to be exactly what we do in java unit tests. No matter the type, it will still surface in the run log. Ok, incoming large diff ;). - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70374 --- On Jan. 30, 2015, 7:04 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 7:04 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Fix compile errors under Java 8. I think this is just caused by the Java 8 compiler having better type inference than Java 7? I'm not in love with this fix, but the alternative is to declare these methods as throwing `Exception` which propagates out pretty widely. Happy to go that route if folks prefer, but figured I'd start with the more tactical fix. Diffs - src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70453 --- Ship it! Ship It! - Bill Farner On Jan. 30, 2015, 11:48 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 11:48 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 4:09 p.m.) Review request for Aurora and Bill Farner. Changes --- Use shortDebugString. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30446: Fix compile errors under Java 8.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:18 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Propagate exceptions throughout all tests. Repository: aurora Description --- Fix compile errors under Java 8. I think this is just caused by the Java 8 compiler having better type inference than Java 7? I'm not in love with this fix, but the alternative is to declare these methods as throwing `Exception` which propagates out pretty widely. Happy to go that route if folks prefer, but figured I'd start with the more tactical fix. Diffs (updated) - src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 97ecb742d6e0418890f875394ded8d9fdae2b1c2 src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 4e7efb3c1214c3d193afd61f162713490eb8effb src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java f96110c55011699768f17cc2d4afdc8bf7daa16c src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 4ed6b159afda3f118e8ae28d03fdf796cbd98149 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 422d5a9a42310979752eb7282658316c2b772419 src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java 131bd826dfe47f40f3c27f29c095ed42953e316c src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 6eaf3ce765c8e50b6724e40848ceb9105e1ab529 src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 88fc172be6c24fefb6f708ce757487082542 src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java 763f8b5f31349f291c0ede7b5d3292f6ca5b src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java 020b67187a18bba64d9b562c3a6c0969fc85d469 src/test/java/org/apache/aurora/scheduler/http/MnameTest.java afa83f2c6f8b03fbd869c8e5c4d81b27a0cc5be5 src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 09593b15c9bd711530ddcb5508ed85b58a2ebe02 src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0a5cc51967f756411ca1489d81872f863c045b6b src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 8fc3cb865fbcd467db91f4cb828d381a02ba7595 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 3:54 p.m.) Review request for Aurora and Bill Farner. Changes --- Appease checkstyle. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30473: Fixing copyright notice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30473/#review70478 --- Ship it! Ship It! - Bill Farner On Jan. 31, 2015, 1:11 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30473/ --- (Updated Jan. 31, 2015, 1:11 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1072 https://issues.apache.org/jira/browse/AURORA-1072 Repository: aurora Description --- Fixing copyright notice Diffs - NOTICE 712c10a70a055b729401f7c047ae5afe7a98b564 Diff: https://reviews.apache.org/r/30473/diff/ Testing --- Thanks, Maxim Khutornenko
Re: Review Request 30474: Preparing for 0.7.0 RC3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30474/#review70477 --- Ship it! Ship It! - Bill Farner On Jan. 31, 2015, 1:17 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30474/ --- (Updated Jan. 31, 2015, 1:17 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This reverts commit ee24fdb5c10e0f6706770d771bb40fedb71224e8. This reverts commit b8d2646e07f539ff1f3cb983f5c60bbbf0525592. Diffs - CHANGELOG 22ae6165a36302adbf6df4f6a0c691392e8ff99f src/main/resources/apache/aurora/client/cli/.auroraversion 7df013a38b2f1b55ddb10bbad6f1dee87c3f51ba Diff: https://reviews.apache.org/r/30474/diff/ Testing --- Thanks, Maxim Khutornenko
Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1071 https://issues.apache.org/jira/browse/AURORA-1071 Repository: aurora Description --- - Adding pulse_interval_secs into client UpdateConfig and validating its range - Raising an error in client updater for pulse_interval_secs Diffs - src/main/python/apache/aurora/client/api/updater.py 9f91de625f55514530a4f948d7ecdf7b5614b594 src/main/python/apache/aurora/client/api/updater_util.py 9d2e893a6ecff0fc48c7944575578443d41ced78 src/main/python/apache/aurora/config/schema/base.py e4433d2d47668f59bce169359131284d361bad09 src/test/python/apache/aurora/client/api/test_updater.py dd3f228c5062d388b4393aa4fd5b60a685bdb3a6 src/test/python/apache/aurora/client/api/test_updater_util.py fe3ac49491ca710761632405ac09de0cc0d038a5 Diff: https://reviews.apache.org/r/30461/diff/ Testing --- ./pants test.pytest src/test/python/apache/aurora/client/api:updater ./pants test.pytest src/test/python/apache/aurora/client/api:updater_util Thanks, Maxim Khutornenko
Re: Review Request 30446: Fix compile errors under Java 8.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70413 --- Ship it! Master (4f04a34) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 30, 2015, 6:53 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:53 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Fix compile errors under Java 8. I think this is just caused by the Java 8 compiler having better type inference than Java 7? Diffs - src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70451 --- Master (c739122) is red with this patch. ./build-support/jenkins/build.sh :api:compileJava UP-TO-DATE :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :assemble :compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7' 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java:75:39: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java:76:53: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java:77:32: '+' should be on a new line. [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java:78:15: '+' should be on a new line. FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':checkstyleTest'. Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.xml * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 45.126 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 30, 2015, 11:48 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 11:48 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30325: Implementing pulseJobUpdate RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70377 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/30325/#comment115507 Have we considered adding a batch interface, to avoid having to make multiple RPCs for a collection of updates? src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/30325/#comment115508 This is consistent with the message above, but we should just say 'a positive integer' here. - David McLaughlin On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:23 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Bugs: AURORA-1009 https://issues.apache.org/jira/browse/AURORA-1009 Repository: aurora Description --- Implemented the `pulseJobUpdate` RPC. Also, moved it into AuroraAdmin interface to support AOP capability validation. The RB is diffed against https://reviews.apache.org/r/30225/ Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/auth/CapabilityValidator.java 45ef643ebe57c1517cdae373574331ea302a8b74 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8c19f3b08135eb5f3098591ebf9931b42a086318 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 Diff: https://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Review Request 30474: Preparing for 0.7.0 RC3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30474/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- This reverts commit ee24fdb5c10e0f6706770d771bb40fedb71224e8. This reverts commit b8d2646e07f539ff1f3cb983f5c60bbbf0525592. Diffs - CHANGELOG 22ae6165a36302adbf6df4f6a0c691392e8ff99f src/main/resources/apache/aurora/client/cli/.auroraversion 7df013a38b2f1b55ddb10bbad6f1dee87c3f51ba Diff: https://reviews.apache.org/r/30474/diff/ Testing --- Thanks, Maxim Khutornenko
Re: Review Request 30467: Update mesos lib to 0.21.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 31, 2015, 1:36 a.m.) Review request for Aurora and Kevin Sweeney. Changes --- Updated other references to the mesos version, built and posted trusty64 egg, working on centos 6 and 7. Bugs: AURORA-1028 https://issues.apache.org/jira/browse/AURORA-1028 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs (updated) - 3rdparty/python/requirements.txt 0c88e4c299ffe5886bb3ab7d83b0187cb4b7888a build-support/python/make-mesos-native-egg 2cba8ede04e22aee1e6ec5c979161904a6f8fddb build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 docs/deploying-aurora-scheduler.md 9bf5b5a92bf65b31b2f8fda102003b113f61186a examples/vagrant/provision-dev-cluster.sh fa0de88314169bc9fe31aaf41126cedd0865ed5a Diff: https://reviews.apache.org/r/30467/diff/ Testing (updated) --- I have yet to try running the end-to-end tests, will block on commit until that happens successfully. Thanks, Bill Farner
Re: Review Request 30474: Preparing for 0.7.0 RC3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30474/#review70479 --- Master (7fbe5bb) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 31, 2015, 1:17 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30474/ --- (Updated Jan. 31, 2015, 1:17 a.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- This reverts commit ee24fdb5c10e0f6706770d771bb40fedb71224e8. This reverts commit b8d2646e07f539ff1f3cb983f5c60bbbf0525592. Diffs - CHANGELOG 22ae6165a36302adbf6df4f6a0c691392e8ff99f src/main/resources/apache/aurora/client/cli/.auroraversion 7df013a38b2f1b55ddb10bbad6f1dee87c3f51ba Diff: https://reviews.apache.org/r/30474/diff/ Testing --- Thanks, Maxim Khutornenko
Re: Review Request 30473: Fixing copyright notice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30473/#review70480 --- Ship it! Master (7fbe5bb) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 31, 2015, 1:11 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30473/ --- (Updated Jan. 31, 2015, 1:11 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1072 https://issues.apache.org/jira/browse/AURORA-1072 Repository: aurora Description --- Fixing copyright notice Diffs - NOTICE 712c10a70a055b729401f7c047ae5afe7a98b564 Diff: https://reviews.apache.org/r/30473/diff/ Testing --- Thanks, Maxim Khutornenko
Re: Review Request 30446: Fix compile errors under Java 8.
On Jan. 30, 2015, 6:44 p.m., Bill Farner wrote:
I was able to address these compiler errors with a more targeted change,
adding a type witness:
```
$ git diff
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
diff --git
a/src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
b/src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
index d492e17..6feddc3 100644
---
a/src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
+++
b/src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
@@ -75,7 +75,7 @@ public class StorageTestUtil {
public T IExpectationSettersT expectRead() {
final CaptureWorkT, RuntimeException work =
EasyMockTest.createCapture();
-return expect(storage.read(capture(work)))
+return expect(storage.T, RuntimeExceptionread(capture(work)))
.andAnswer(new IAnswerT() {
@Override
public T answer() {
@@ -86,7 +86,7 @@ public class StorageTestUtil {
public T IExpectationSettersT expectWrite() {
final CaptureMutateWorkT, RuntimeException work =
EasyMockTest.createCapture();
-return expect(storage.write(capture(work))).andAnswer(new IAnswerT()
{
+return expect(storage.T,
RuntimeExceptionwrite(capture(work))).andAnswer(new IAnswerT() {
@Override
public T answer() {
return work.getValue().apply(mutableStoreProvider);
```
Thank you, I knew there had to be a cleaner way to do this! Will send updated
diff.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/#review70393
---
On Jan. 30, 2015, 6:18 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/
---
(Updated Jan. 30, 2015, 6:18 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
---
Fix compile errors under Java 8.
I think this is just caused by the Java 8 compiler having better type
inference than Java 7?
Diffs
-
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java
97ecb742d6e0418890f875394ded8d9fdae2b1c2
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java
4e7efb3c1214c3d193afd61f162713490eb8effb
src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java
f96110c55011699768f17cc2d4afdc8bf7daa16c
src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java
4ed6b159afda3f118e8ae28d03fdf796cbd98149
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java
422d5a9a42310979752eb7282658316c2b772419
src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java
131bd826dfe47f40f3c27f29c095ed42953e316c
src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java
6eaf3ce765c8e50b6724e40848ceb9105e1ab529
src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java
88fc172be6c24fefb6f708ce757487082542
src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java
763f8b5f31349f291c0ede7b5d3292f6ca5b
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
4c2448ffba5c7e0f0ea59fc6484fbcdfc7df7f52
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java
020b67187a18bba64d9b562c3a6c0969fc85d469
src/test/java/org/apache/aurora/scheduler/http/MnameTest.java
afa83f2c6f8b03fbd869c8e5c4d81b27a0cc5be5
src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java
09593b15c9bd711530ddcb5508ed85b58a2ebe02
src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java
cb98834e925793fc116814371548a30470830164
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java
0a5cc51967f756411ca1489d81872f863c045b6b
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
8fc3cb865fbcd467db91f4cb828d381a02ba7595
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
d492e176e73cbd2b3c696fc488010db16106b36a
Diff: https://reviews.apache.org/r/30446/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70445 --- src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java https://reviews.apache.org/r/30471/#comment115632 Can you take a stab at serializing the thrift objec to a string and using that as your golden data to compare against? That would at least be resistant to refactors. - Bill Farner On Jan. 30, 2015, 11:24 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 11:24 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 30187: Remove support for cluster metadata in YAML format.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review70419 --- Ship it! Ship It! - Brian Wickman On Jan. 28, 2015, 8:26 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/ --- (Updated Jan. 28, 2015, 8:26 p.m.) Review request for Aurora, Brian Wickman and Zameer Manji. Bugs: AURORA-1029 https://issues.apache.org/jira/browse/AURORA-1029 Repository: aurora Description --- Remove support for cluster metadata in YAML format. Diffs - src/main/python/apache/aurora/common/clusters.py e55aa774b4b868f696a7de51bb016f950871dd1e src/test/python/apache/aurora/common/BUILD 14165b96be99b8de418f4bb8def9f27eaf29e67d src/test/python/apache/aurora/common/test_clusters.py 45250e609cca1149dc296b2aaf645ff2f58f8288 Diff: https://reviews.apache.org/r/30187/diff/ Testing --- ./build-support/jenkins/build.sh test_end_to_end.sh is currently broken on master, i will address that and ensure it passes before committing this. Thanks, Bill Farner
Re: Review Request 30325: Implementing pulseJobUpdate RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:19 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Changes --- Adding validation for blockIfNoPulsesAfterMs. Bugs: AURORA-1009 https://issues.apache.org/jira/browse/AURORA-1009 Repository: aurora Description --- Implemented the `pulseJobUpdate` RPC. Also, moved it into AuroraAdmin interface to support AOP capability validation. The RB is diffed against https://reviews.apache.org/r/30225/ Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf src/main/java/org/apache/aurora/auth/CapabilityValidator.java 45ef643ebe57c1517cdae373574331ea302a8b74 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8c19f3b08135eb5f3098591ebf9931b42a086318 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java d3b30d48b76d8d7c64cda006a34f7ed3296526f2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java a992938d4e12b20f81608be6bbdc24c0a211c3fd src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 27a5b9026f5ac3b3bdeb32813b10435bc3dab173 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4c827b183a87b4d97774edbfaa960bd1c3de72a5 src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987 Diff: https://reviews.apache.org/r/30325/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 30446: Fix compile errors under Java 8.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:53 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Cleaner fix, thanks Bill! Repository: aurora Description --- Fix compile errors under Java 8. I think this is just caused by the Java 8 compiler having better type inference than Java 7? Diffs (updated) - src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen
Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70384 --- Florian, can you remove the two empty lines Bill has pointed out? - Zameer Manji On Jan. 26, 2015, 5:08 p.m., Florian Pfeiffer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 26, 2015, 5:08 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-184 https://issues.apache.org/jira/browse/AURORA-184 Repository: aurora Description --- [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints This is the first step for AURORA-184, that removes the default hostrack limit constraints. The second step that's still missing would be to add s.th. like --default-constraints as start parameter to the scheduler. AURORA-174 could probably be closed with this?(since the rack limit constraint can be configured in the .aurora file) I can't really estimate the effect of my changes in StorageBackfillTestSchedulerThriftInterfaceTest, please have a closer look at the changes I did there. Since this is also my first code submit, comments about codestyleother bad habbits are very appreciated. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 5dfbcf1f6de716502a28f7da33a095968eb8420e src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 92ba45033ada8114349c435316c9681395aea706 Diff: https://reviews.apache.org/r/30010/diff/ Testing --- Added test for ConfigurationManager.hasName Added test testNoHostAndRackConstraintsAdded, that checks if the constraints are present Tested on vagrant devcluster to see if constraints are also gone in real life Thanks, Florian Pfeiffer
Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70447 --- Ship it! This looks good to me. As long as the default value is true there's no changes to the functionality my Docker implementation needs. I'm still curious why I'm not running into this issues though. - Steve Niemitz On Jan. 30, 2015, 11:24 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 11:24 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1076 https://issues.apache.org/jira/browse/AURORA-1076 Repository: aurora Description --- The Docker patch (7ba6226) started to set the shell attribute of of ExecutorInfo. This breaks backwards compatability for the GC executor as it will continue to have the same id but different info now. In addition it is not necessary to set this value because it defaults to true. Diffs - src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Review Request 30473: Fixing copyright notice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30473/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1072 https://issues.apache.org/jira/browse/AURORA-1072 Repository: aurora Description --- Fixing copyright notice Diffs - NOTICE 712c10a70a055b729401f7c047ae5afe7a98b564 Diff: https://reviews.apache.org/r/30473/diff/ Testing --- Thanks, Maxim Khutornenko
Re: Review Request 28731: Implemented TaskScheduler benchmarks.
On Jan. 31, 2015, 12:16 a.m., Zameer Manji wrote: Ship It! Zameer Manji wrote: My comment got chompted, I'm expecting these tests to be run on Jenkins for every commit. If you check the RB history this has been discussed earlier. The outcome: perf testing is too machine state sensitive to block the build on its results. That said, we may run them in jenkins just to prevent bit rot. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/#review70458 --- On Jan. 29, 2015, 8:11 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/ --- (Updated Jan. 29, 2015, 8:11 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora Description --- Added baseline benchmarks for a few static veto cases. Diffs - build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 src/jmh/java/org/apache/aurora/benchmark/Hosts.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/Offers.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java 5cecada93e4e04b689e826af49f691ed7e94ae49 src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/Tasks.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java b6402ae42e3c7e4dca1c120fa6ef82d2d69e69d5 src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java 03c2a8fde4a3fe5ac73f44da2cbe227995501c46 src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java f7e157c890b5627411acd4bd5c2559ef4829147c src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 0204d14b19ae412236f19ca274d81decb4eba12d Diff: https://reviews.apache.org/r/28731/diff/ Testing --- Sample run on a local box: ``` # VM invoker: /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant # Warmup: 10 iterations, 1 s each # Measurement: 100 iterations, 1 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.aurora.benchmark.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.runBenchmark # Run progress: 0.00% complete, ETA 00:05:30 # Fork: 1 of 1 # Warmup Iteration 1: 278284250.000 ns/op # Warmup Iteration 2: 70294312.500 ns/op # Warmup Iteration 3: 19293379.310 ns/op # Warmup Iteration 4: 11945387.097 ns/op # Warmup Iteration 5: 10725388.350 ns/op # Warmup Iteration 6: 13043282.353 ns/op # Warmup Iteration 7: 9233083.333 ns/op # Warmup Iteration 8: 9521051.724 ns/op # Warmup Iteration 9: 10750854.369 ns/op # Warmup Iteration 10: 7460243.243 ns/op Iteration 1: 7885364.286 ns/op Iteration 2: 7735139.860 ns/op Iteration 3: 7660208.333 ns/op Iteration 4: 7761204.225 ns/op Iteration 5: 7868907.143 ns/op Iteration 6: 7567404.110 ns/op Iteration 7: 7611000.000 ns/op Iteration 8: 7766154.930 ns/op Iteration 9: 7669344.828 ns/op Iteration 10: 7707783.217 ns/op Iteration 11: 7435651.007 ns/op Iteration 12: 7697631.944 ns/op Iteration 13: 7712531.469 ns/op Iteration 14: 7899407.143 ns/op Iteration 15: 7448472.973 ns/op Iteration 16: 7791521.127 ns/op Iteration 17: 7612213.793 ns/op Iteration 18: 7710867.133 ns/op Iteration 19: 7649296.552 ns/op Iteration 20: 7768309.859 ns/op Iteration 21: 7688666.667 ns/op Iteration 22: 7531557.823 ns/op Iteration 23: 7381193.333 ns/op Iteration 24: 7726006.993 ns/op Iteration 25: 7603358.621 ns/op Iteration 26: 7653631.944 ns/op Iteration 27: 7442275.168 ns/op Iteration 28: 7613186.207 ns/op Iteration 29: 7765823.944 ns/op Iteration 30: 7489687.075 ns/op Iteration 31: 7811443.662 ns/op Iteration 32: 8015007.246 ns/op Iteration 33: 8192392.593 ns/op Iteration 34: 8040335.766 ns/op Iteration 35: 7584212.329 ns/op Iteration 36: 8001934.783 ns/op Iteration 37: 9744815.789 ns/op Iteration 38: 11688284.211 ns/op Iteration 39: 8661406.250 ns/op Iteration 40: 7678413.793 ns/op Iteration 41: 8502223.077 ns/op Iteration 42: 7640820.690 ns/op Iteration 43: 7875624.113 ns/op Iteration 44: 7506809.524 ns/op Iteration 45:
