---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review70992
---
Ship it!
Master (8bcb2ba) is green with this patch.
On Feb. 4, 2015, 1:47 a.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/client/cli/test_cron.py, line 138
https://reviews.apache.org/r/30586/diff/2/?file=846914#file846914line138
You may want to drop unused CLUSTER patching in other tests as well.
Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/
---
(Updated Feb. 4, 2015, 5:24 p.m.)
Review request for Aurora, David McLaughlin,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30585/#review71014
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 3, 2015, 4:24 p.m.,
On Feb. 4, 2015, 1:59 a.m., David McLaughlin wrote:
LGTM, thanks for the patch.
Although I'm a little bit concerned about adding support for hooks in an
environment where we can't support post-hooks.
Thanks!
I agree that it is certainly not ideal, but it does allow us to at least
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71148
---
Please put the pants release notes in the commit. Or at least some
On Feb. 4, 2015, 11:34 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 273
https://reviews.apache.org/r/30225/diff/4/?file=848246#file848246line273
I think avoid acquisition of a write lock here is a good goal to aim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review71063
---
I suggest you skip to the big comment before paying attention to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/#review71079
---
Can you see any opportunity to break this diff apart? As it stands
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30467/#review71096
---
Ship it!
Master (b49e1a0) is green with this patch.
On Feb. 4, 2015, 11:34 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 273
https://reviews.apache.org/r/30225/diff/4/?file=848246#file848246line273
I think avoid acquisition of a write lock here is a good goal to aim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/#review71084
---
Master (b49e1a0) is red with this patch.
On Feb. 5, 2015, 12:01 a.m., Bill Farner wrote:
Can you see any opportunity to break this diff apart? As it stands i'm
having a hard time giving a thoughtful review. Perhaps you can start by
introducing the `Assignment` class?
I'd really prefer keeping this diff as a whole. The
On Feb. 5, 2015, 12:01 a.m., Bill Farner wrote:
Can you see any opportunity to break this diff apart? As it stands i'm
having a hard time giving a thoughtful review. Perhaps you can start by
introducing the `Assignment` class?
Maxim Khutornenko wrote:
I'd really prefer keeping
On Feb. 4, 2015, 11:34 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 273
https://reviews.apache.org/r/30225/diff/4/?file=848246#file848246line273
I think avoid acquisition of a write lock here is a good goal to aim
On Feb. 4, 2015, 11:34 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 273
https://reviews.apache.org/r/30225/diff/4/?file=848246#file848246line273
I think avoid acquisition of a write lock here is a good goal to aim
On Feb. 4, 2015, 11:34 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 273
https://reviews.apache.org/r/30225/diff/4/?file=848246#file848246line273
I think avoid acquisition of a write lock here is a good goal to aim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review71114
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---
(Updated Feb. 5, 2015, 1:46 a.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---
(Updated Feb. 5, 2015, 1:45 a.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---
Review request for Aurora.
Repository: aurora
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71127
---
Master (edcc252) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/
---
(Updated Feb. 4, 2015, 6:08 p.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review71128
---
Maxim, can you review the changes to the tests?
- Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review71140
---
Ship it!
LGTM. Minor suggestion below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/
---
Review request for Aurora and Brian Wickman.
Bugs: AURORA-1104
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review71138
---
Ship it!
Master (edcc252) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review71143
---
Ship it!
Master (edcc252) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review71109
---
Ship it!
Ship It!
- Bill Farner
On Feb. 4, 2015, 1:14 a.m.,
On Feb. 4, 2015, 11:34 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 273
https://reviews.apache.org/r/30225/diff/4/?file=848246#file848246line273
I think avoid acquisition of a write lock here is a good goal to aim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71137
---
On Feb. 4, 2015, 11:34 p.m., Bill Farner wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 565
https://reviews.apache.org/r/30225/diff/4/?file=848240#file848240line565
Maybe s/BLOCKED/AWAITING_PULSE/?
That would at least self-document and avoid
On Feb. 5, 2015, 1:15 a.m., David McLaughlin wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 293
https://reviews.apache.org/r/30225/diff/4/?file=848246#file848246line293
I think we still want to update the last pulse time even if it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/
---
(Updated Feb. 5, 2015, 2:34 a.m.)
Review request for Aurora, David McLaughlin,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/
---
(Updated Feb. 4, 2015, 11:38 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/#review71171
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 4, 2015, 8:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71172
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 4, 2015, 8:13 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review71150
---
src/test/python/apache/aurora/client/cli/test_cron.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/
---
Review request for Aurora, Brian Wickman and Zameer Manji.
Bugs: AURORA-979
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/#review71157
---
Ship it!
Master (1c78721) is green with this patch.
On Feb. 4, 2015, 7:39 p.m., Zameer Manji wrote:
Please put the pants release notes in the commit. Or at least some sort of
summary that explains what is new.
Done.
- Joe
---
This is an automatically generated e-mail. To reply,
41 matches
Mail list logo
