Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/#review72209 --- Ship it! Ship It! - Bill Farner On Feb. 12, 2015, 6:05 p.m.,

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

On Feb. 11, 2015, 11:54 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 34 https://reviews.apache.org/r/30890/diff/1/?file=861039#file861039line34 I feel like `VetoType` still applies and is actually a better name. It's

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

On Feb. 11, 2015, 11:54 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 253 https://reviews.apache.org/r/30890/diff/1/?file=861038#file861038line253 s/SchedulingFilter.// Done. On Feb. 11, 2015, 11:54 p.m., Bill Farner wrote:

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/ --- (Updated Feb. 12, 2015, 6:05 p.m.) Review request for Aurora, Kevin Sweeney

Review Request 30942: Displaying blockIfNoPulseAfterMs in the UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30942/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-1088

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/#review72204 --- Master (994d669) is red with this patch.

Re: Review Request 30942: Displaying blockIfNoPulseAfterMs in the UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30942/#review72210 --- Master (ab8fae2) is green with this patch.

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review72195 --- Ship it! Master (994d669) is green with this patch.

Review Request 30950: Add the option to make a non-hooked API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs:

Re: Review Request 30950: Add the option to make a non-hooked API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/#review72249 --- src/test/python/apache/aurora/client/cli/util.py

Re: Review Request 30950: Add the option to make a non-hooked API.

On Feb. 12, 2015, 10:03 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/util.py, line 313 https://reviews.apache.org/r/30950/diff/1/?file=862321#file862321line313 Why don't you just use the imported values instead of declaring them here again? Just trying to

Re: Review Request 30950: Add the option to make a non-hooked API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/#review72251 --- Ship it! Ship It! - Zameer Manji On Feb. 12, 2015, 1:59 p.m.,

Re: Review Request 30950: Add the option to make a non-hooked API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/#review72254 --- Ship it! Master (ab8fae2) is green with this patch.

Re: Review Request 30942: Displaying blockIfNoPulseAfterMs in the UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30942/#review72248 --- Ship it! Ship It! - David McLaughlin On Feb. 12, 2015, 6:40

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

On Feb. 13, 2015, 1:17 a.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 78 https://reviews.apache.org/r/30890/diff/3/?file=862710#file862710line78 Can you add a getCounterName() abstract method to the VetoGroup enum? That will make the

Re: Review Request 30950: Add the option to make a non-hooked API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/#review72265 --- Ship it! Ship It! - David McLaughlin On Feb. 12, 2015, 9:59

Re: Review Request 30888: Offer filtering for static vetoes. Part 1 of 4: TaskAssigner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30888/ --- (Updated Feb. 12, 2015, 11:44 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30913: Adding UPDATE_COORDINATOR role access into pause/resume/abort RPCs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30913/#review72275 --- Ship it! Ship It! - David McLaughlin On Feb. 12, 2015, 2:47

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/#review72286 --- Ship it! Master (b62ec61) is green with this patch.

Re: Review Request 30888: Offer filtering for static vetoes. Part 1 of 4: TaskAssigner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30888/#review72290 --- Ship it! Master (b62ec61) is green with this patch.

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/ --- (Updated Feb. 13, 2015, 12:58 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72282 --- This patch does not apply cleanly on master (b62ec61), do you need

Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/ --- (Updated Feb. 13, 2015, 12:58 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/#review72300 --- Ship it! src/main/java/org/apache/aurora/scheduler/TaskVars.java

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72308 --- Master (f3473a3) is red with this patch.

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/#review72307 --- Ship it! Master (f3473a3) is green with this patch.

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30890/#review72274 --- @ReviewBot retry - Maxim Khutornenko On Feb. 12, 2015, 6:05

Re: Review Request 29117: Adding thrift API changes document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- (Updated Feb. 13, 2015, 12:35 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 29117: Adding thrift API changes document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review72291 --- docs/thrift-deprecation.md

Re: Review Request 29117: Adding thrift API changes document.

On Feb. 13, 2015, 12:41 a.m., David McLaughlin wrote: docs/thrift-deprecation.md, line 20 https://reviews.apache.org/r/29117/diff/4/?file=862696#file862696line20 Sorry I missed this first review, but AFAIK this isn't true for dynamic languages (incl. our own scheduler UI)? Can

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/ --- (Updated Feb. 12, 2015, 4:55 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/ --- (Updated Feb. 13, 2015, 1:04 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

On Feb. 11, 2015, 11:54 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 34 https://reviews.apache.org/r/30890/diff/1/?file=861039#file861039line34 I feel like `VetoType` still applies and is actually a better name. It's

Re: Review Request 30913: Adding UPDATE_COORDINATOR role access into pause/resume/abort RPCs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30913/#review72263 --- Ship it! Ship It! - Bill Farner On Feb. 12, 2015, 2:47 a.m.,

Re: Review Request 30888: Offer filtering for static vetoes. Part 1 of 4: TaskAssigner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30888/#review72269 --- Ship it! Ship It! - Kevin Sweeney On Feb. 11, 2015, 2:52 p.m.,

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72311 --- Master (f3473a3) is red with this patch.

Re: Review Request 30915: Increase findbugs heap size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30915/#review72262 --- Ship it! Thanks. Findbugs also acknoewledges that this is a

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/ --- (Updated Feb. 12, 2015, 4:33 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 29117: Adding thrift API changes document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review72295 --- Ship it! Master (b62ec61) is green with this patch.

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/ --- (Updated Feb. 13, 2015, 2:27 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72321 --- Ship it! Master (7637200) is green with this patch.

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- (Updated Feb. 12, 2015, 5:40 p.m.) Review request for Aurora, David