On Feb. 18, 2015, 5:17 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java,
line 166
https://reviews.apache.org/r/31170/diff/1/?file=868472#file868472line166
Shouldn't PruneVictim have the IJobUpdateKey as the parameter?
Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170/#review73199
---
Ship it!
Ship it, modulo my concern over uncessarily creating an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review73174
---
Drive-by piecemeal review - should we create a top-level directory
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review73208
---
Looks good! Only a few minor suggestions.
On Feb. 20, 2015, 12:06 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java,
line 261
https://reviews.apache.org/r/31171/diff/2/?file=869995#file869995line261
It may exceed your appetite for this review, but i would actually
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31171/#review73226
---
Master (e0e3f2e) is red with this patch.
On Feb. 18, 2015, 7:42 p.m., Kevin Sweeney wrote:
Hi Craig, thanks for the contribution. I'm wondering if this document might
be better suited as a gist or blog post given that it's dated (0.7.1) and
we don't have automated test coverage to ensure it doesn't diverge from the
rest of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31171/#review73225
---
On Feb. 19, 2015, 1:45 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java,
line 144
https://reviews.apache.org/r/31171/diff/1/?file=868489#file868489line144
I think the defer should be here. As the diff stands, `backupNow()`
