/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/21247/#comment76642>
Please delete the code for the task summary table from the controller.
- Suman Karumuri
On May 12, 2014, 8:28 p.m., David McLaughlin
Thanks,
Suman Karumuri
/files/2014/05/13/eb16f07d-2ea8-4fe3-a9f8-5e1657a530b0__Screen_Shot_2014-05-12_at_6.07.50_PM.png
Thanks,
Suman Karumuri
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/#review42789
---
On May 12, 2014, 8:36 p.m., Suman Karumuri wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21170/#review42840
---
Ship it!
Ship It!
- Suman Karumuri
On May 7, 2014, 6:48 p.m
/files/2014/05/14/ef23cf5d-561a-4ae3-aad2-4321b1dd08e2__Screen_Shot_2014-05-13_at_8.40.48_PM.png
Thanks,
Suman Karumuri
factor getTasksForJob.
- Suman Karumuri
On May 14, 2014, 1:30 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On May 14, 2014, 4:26 a.m., Suman Karumuri wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
> > line 386
> > <https://reviews.apache.org/r/21247/diff/5/?file=581259#file581259line386>
> >
> > I see this function c
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42981
---
Thanks for the changes.
- Suman Karumuri
On May 14, 2014, 3:46
/diff/
Testing
---
Tested on local laptop.
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21407/#review43011
---
Ship it!
Ship It!
- Suman Karumuri
On May 13, 2014, 9:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42980
---
Ship it!
Ship It!
- Suman Karumuri
On May 14, 2014, 3:46 p.m
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/#review43034
---
On May 14, 2014, 9:42 p.m., Suman Karumuri wrote:
>
> --
: https://reviews.apache.org/r/21460/diff/
Testing
---
Tested on laptop.
Thanks,
Suman Karumuri
://reviews.apache.org/media/uploaded/files/2014/05/07/bc2d25f8-79ef-4f3e-b44f-81e668bd32b8__Screen_Shot_2014-05-06_at_6.38.46_PM.png
Thanks,
Suman Karumuri
-89fc-7fea74f36b29__Screen_Shot_2014-05-14_at_2.37.49_PM.png
Thanks,
Suman Karumuri
ause the UI to render incorrectly and it would
be really hard to debug what went wrong.
- Suman Karumuri
On May 8, 2014, 11:45 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail
-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
Thanks,
Suman Karumuri
65fb8f0062c9b71d1ff14dd8e306d9989c1483cc
Diff: https://reviews.apache.org/r/21145/diff/
Testing
---
Tested on local laptop.
Thanks,
Suman Karumuri
value nor whitespace or borders
> > to separate different label/value pairs.
>
> Suman Karumuri wrote:
> Trying to be a minimalist here. What do you recommend? A table with the
> keys in the header and values as data?
Spoke with designer and replaced it with a smart table
> On May 15, 2014, 5:06 p.m., Suman Karumuri wrote:
> > build.gradle, line 246
> > <https://reviews.apache.org/r/21407/diff/2/?file=581989#file581989line246>
> >
> > Should we be adding generated thrift sources here?
> >
> > 'ACTIVE_
ticket.
- Suman Karumuri
On May 15, 2014, 9:46 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-15_at_5.12.06_PM.png
Thanks,
Suman Karumuri
-d3f138ea14ee__Screen_Shot_2014-05-15_at_12.03.26_PM.png
Screenshot with CORS flags
https://reviews.apache.org/media/uploaded/files/2014/05/15/fbf1bc72-3b9c-4b6f-a1e1-401d00cb07f7__Screen_Shot_2014-05-15_at_12.27.23_PM.png
Thanks,
Suman Karumuri
e.org/r/21426/#review43018
---
On May 15, 2014, 1:34 a.m., Suman Karumuri wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
associated ticket.
- Suman Karumuri
On May 15, 2014, 9:47 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/2014/05/15/0df1216b-d58e-4720-932b-be1de2a053d0__Screen_Shot_2014-05-14_at_6.30.41_PM.png
narrow page
https://reviews.apache.org/media/uploaded/files/2014/05/15/9b32c1eb-6aae-4361-a82d-d90f89f54551__Screen_Shot_2014-05-14_at_6.32.47_PM.png
Thanks,
Suman Karumuri
/files/2014/05/15/fbf1bc72-3b9c-4b6f-a1e1-401d00cb07f7__Screen_Shot_2014-05-15_at_12.27.23_PM.png
Thanks,
Suman Karumuri
summary.
https://reviews.apache.org/media/uploaded/files/2014/05/15/5e8e58e8-b83a-41e9-b266-af73798bce61__Screen_Shot_2014-05-14_at_5.45.14_PM.png
Thanks,
Suman Karumuri
/uploaded/files/2014/05/15/80efccf2-73cd-423e-9bcc-ad9e8a27a607__Screen_Shot_2014-05-14_at_5.45.07_PM.png
cron job page with expanded show summary.
https://reviews.apache.org/media/uploaded/files/2014/05/15/5e8e58e8-b83a-41e9-b266-af73798bce61__Screen_Shot_2014-05-14_at_5.45.14_PM.png
Thanks,
Suman
<https://reviews.apache.org/r/21273/#comment77147>
What does bind do here? A comment may be needed.
- Suman Karumuri
On May 13, 2014, 6:09 p.m., Mark Chu-Carroll wrote:
>
> ---
> This is an automatically generated e-mail.
tomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/#review43160
---
On May 15, 2014, 12:46 a.m., Suman Karumuri wrote:
>
> --
-c10c-4f17-9ead-326a6748dc49__Screen_Shot_2014-05-15_at_5.10.36_PM.png
cors with default whitelist.
https://reviews.apache.org/media/uploaded/files/2014/05/16/5af2094a-b015-42c6-a802-7ad016d06480__Screen_Shot_2014-05-15_at_5.12.06_PM.png
Thanks,
Suman Karumuri
133>
Should we be adding generated thrift sources here?
'ACTIVE_STATES' is not defined.
(/Users/dmclaughlin/t/incubator-aurora/src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js:211:27)
> return _.contains(ACTIVE_STATES, task.status);
- Suma
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/#review43234
---
On May 16, 2014, 12:16 a.m., Suman Karumuri wrote:
>
>
14-05-15_at_5.10.36_PM.png
cors with default whitelist.
https://reviews.apache.org/media/uploaded/files/2014/05/16/5af2094a-b015-42c6-a802-7ad016d06480__Screen_Shot_2014-05-15_at_5.12.06_PM.png
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21662/#review43502
---
Why?
- Suman Karumuri
On May 19, 2014, 9:24 p.m., David
> On May 20, 2014, 5:44 p.m., Suman Karumuri wrote:
> > Why?
Sorry just saw the ticket. Commenting there.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21662/#re
/js/services.js
<https://reviews.apache.org/r/21523/#comment77688>
s/if(/if (/
Can jsHint catch this?
- Suman Karumuri
On May 16, 2014, 1:30 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically gener
> > filter("/scheduler").through(LeaderRedirectFilter.class);
Thanks for pointing that out. Changed.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/#review43438
--
apache.org/media/uploaded/files/2014/05/16/2d3a938f-c10c-4f17-9ead-326a6748dc49__Screen_Shot_2014-05-15_at_5.10.36_PM.png
cors with default whitelist.
https://reviews.apache.org/media/uploaded/files/2014/05/16/5af2094a-b015-42c6-a802-7ad016d06480__Screen_Shot_2014-05-15_at_5.12.06_PM.png
Than
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43671
---
Pushed. Please close out this review.
- Suman Karumuri
On May 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review43750
---
Ship it!
Ship It!
- Suman Karumuri
On May 21, 2014, 10:35 p.m
://reviews.apache.org/media/uploaded/files/2014/05/22/759d50e5-6ab2-41bf-91b4-5d8954f07723__Screen_Shot_2014-05-22_at_12.06.04_PM.png
job page
https://reviews.apache.org/media/uploaded/files/2014/05/22/00c7cd6b-d8f6-40b0-a62a-81953641382c__Screen_Shot_2014-05-22_at_12.05.34_PM.png
Thanks,
Suman Karumuri
eparate ticket.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43760
---
On May 22, 2014, 7:09
> On May 22, 2014, 7:33 p.m., David McLaughlin wrote:
> > I would have to object to the amount of new files added with this review.
> > Is there any way to tell bower to only install the files defined in main?
> > The vast majority of these new files are superfluous.
>
59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Thanks,
Suman Karumuri
32_PM.png
all tasks tab
https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Thanks,
Suman Karumuri
magic number?
Was trying to minimize the amount of code. Setting it accurately now.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43794
----
-91b4-5d8954f07723__Screen_Shot_2014-05-22_at_12.06.04_PM.png
job page
https://reviews.apache.org/media/uploaded/files/2014/05/22/00c7cd6b-d8f6-40b0-a62a-81953641382c__Screen_Shot_2014-05-22_at_12.05.34_PM.png
Thanks,
Suman Karumuri
/media/uploaded/files/2014/05/22/00c7cd6b-d8f6-40b0-a62a-81953641382c__Screen_Shot_2014-05-22_at_12.05.34_PM.png
Thanks,
Suman Karumuri
502-8690-1511f4e4fac8__Screen_Shot_2014-05-22_at_6.20.25_PM.png
Tabs with task counts
https://reviews.apache.org/media/uploaded/files/2014/05/23/eeef957c-521f-421f-821d-d22c3d23ff26__Screen_Shot_2014-05-23_at_1.53.41_PM.png
Thanks,
Suman Karumuri
. To reply, visit:
https://reviews.apache.org/r/21825/#review43875
---
On May 23, 2014, 8:54 p.m., Suman Karumuri wrote:
>
> ---
> This is an automatica
_2014-05-23_at_1.53.41_PM.png
Thanks,
Suman Karumuri
rg/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Tabs with task counts
https://reviews.apache.org/media/uploaded/files/2014/05/23/c5a6a3c6-bef0-4726-ae2f-83bf8a575e61__Screen_Shot_2014-05-23_at_2.16.36_PM.png
Thanks,
Suman Karumuri
-22_at_12.06.04_PM.png
job page
https://reviews.apache.org/media/uploaded/files/2014/05/22/00c7cd6b-d8f6-40b0-a62a-81953641382c__Screen_Shot_2014-05-22_at_12.05.34_PM.png
Thanks,
Suman Karumuri
job page
https://reviews.apache.org/media/uploaded/files/2014/05/22/00c7cd6b-d8f6-40b0-a62a-81953641382c__Screen_Shot_2014-05-22_at_12.05.34_PM.png
Thanks,
Suman Karumuri
_2014-05-23_at_2.16.36_PM.png
Thanks,
Suman Karumuri
ws.apache.org/r/21791/
> ---
>
> (Updated May 21, 2014, 10:35 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
>
>
> Bugs: AURORA-455
> https://issues.apache.org/jira/browse/AURORA
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21828/#review44173
---
Ship it!
Ship It!
- Suman Karumuri
On May 22, 2014, 9:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21828/#review44175
---
Pushed to master. Please close out this review.
- Suman Karumuri
/javascript/bower_components/jquery/dist/jquery.min.js PRE-CREATION
3rdparty/javascript/bower_components/jquery/dist/jquery.min.map PRE-CREATION
Diff: https://reviews.apache.org/r/21994/diff/
Testing
---
./gradlew run && ./gradlew clean build.
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21780/#review44246
---
Ship it!
Ship It!
- Suman Karumuri
On May 21, 2014, 5:45 p.m
.apache.org/r/21497/diff/4/?file=585947#file585947line35>
> >
> > Apologies for not bringing this up earlier, but test coverage for this
> > class would be greatly appreciated.
Added.
- Suman
------
-4f17-9ead-326a6748dc49__Screen_Shot_2014-05-15_at_5.10.36_PM.png
cors with default whitelist.
https://reviews.apache.org/media/uploaded/files/2014/05/16/5af2094a-b015-42c6-a802-7ad016d06480__Screen_Shot_2014-05-15_at_5.12.06_PM.png
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review44340
---
Pushed to master.
- Suman Karumuri
On May 28, 2014, 8:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22065/#review44341
---
Ship it!
Ship It!
- Suman Karumuri
On May 30, 2014, 1:32 a.m
://issues.apache.org/jira/browse/AURORA-485
Repository: aurora
Description
---
Added a comment to .gitignore.
Diffs
-
.gitignore bed5b8b8a02e957e05b8bcc8fed925f1432973cf
Diff: https://reviews.apache.org/r/22092/diff/
Testing
---
Thanks,
Suman Karumuri
eply, visit:
https://reviews.apache.org/r/21994/#review44214
-------
On May 28, 2014, 10:40 p.m., Suman Karumuri wrote:
>
> ---
> This is an automatically ge
ected.
./gradlew installBowerComponents works as expected.
./gradlew runJsTests (fails since our code needs to be updated).
Thanks,
Suman Karumuri
/r/22092/diff/
Testing
---
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22476/#review45434
---
Ship it!
Ship It!
- Suman Karumuri
On June 11, 2014, 9:53 p.m
> On June 12, 2014, 12:15 a.m., David McLaughlin wrote:
> > Curious why you didn't make this part of the Thrift API?
>
> Maxim Khutornenko wrote:
> I don't see a use case for it on the client. This data is rarely needed
> and for debugging purposes only.
>
> Is there something spe
201 - 273 of 273 matches
Mail list logo
