Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/#review77449 --- Ship it! Master (3bb1372) is green with this patch.

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Joshua Cohen
On March 23, 2015, 5:43 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 77 https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line77 This method also appears to be used here:

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Kevin Sweeney
On March 23, 2015, 10:43 a.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 61 https://reviews.apache.org/r/32377/diff/1/?file=902302#file902302line61 Can you push the lazy instantiation logic to ModuleParser and

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Joshua Cohen
On March 23, 2015, 5:43 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 77 https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line77 This method also appears to be used here:

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/#review77423 --- src/main/java/org/apache/aurora/scheduler/app/Modules.java

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Bill Farner
On March 23, 2015, 5:43 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 99 https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line99 Can you push this to ModuleParser? Good call, done. On March 23, 2015, 5:43 p.m., Kevin

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/ --- (Updated March 23, 2015, 6:51 p.m.) Review request for Aurora and Kevin

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/#review77424 --- src/main/java/org/apache/aurora/scheduler/app/Modules.java

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/#review77447 --- Ship it!

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/ --- (Updated March 24, 2015, 12:31 a.m.) Review request for Aurora and Kevin

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Bill Farner
On March 23, 2015, 6:56 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 99 https://reviews.apache.org/r/32377/diff/2/?file=903369#file903369line99 consider adding a Class? extends Module... overload. -1 on the overload, +1 on the switch

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377/#review77354 --- Ship it! Master (a3a35e9) is green with this patch.